; http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00125.html
> >
> > Changes from v1 (by Hu Tao):
> > - Keep pvpanic device enabled by default for 1.5
> > for backport compatibility
> > - Addressed Andreas Färber review (removed bus type)
> > - Small ch
On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote:
> This isn't patch review, just a couple of observations and questions.
>
> Current use of categories, please correct misunderstandings:
>
> * A device can have multiple categories. Most (all?) devices currently
> have exactly one.
Al
On Wed, 2013-08-21 at 11:23 +0200, Markus Armbruster wrote:
> Marcel Apfelbaum writes:
>
> > On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote:
> >> This isn't patch review, just a couple of observations and questions.
> >>
> >&g
Thanks to Markus Armbruster
for finding this bug.
Signed-off-by: Marcel Apfelbaum
---
hw/usb/dev-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index 66c6331..5956720 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -658,7
ame "NAME", bus "BUS"...
...
Storage devices:
...
This way, showing devices with multiple categories once per category
actually makes sense.
Note that the "categories to each line" is kept for 2 reasons:
1. Preparation for multifunction devices
2. Ability to
usb-tablet device was wrongy assgined to Misc category
Reported-by: Markus Armbruster
Signed-off-by: Marcel Apfelbaum
Reviewed-by: Andreas Färber
---
Changes from v2:
- Add cc to qemu-stable and Gerd Hoffmann
- Changed subject prefix from hw to usb/dev-hid
hw/usb/dev-hid.c | 2 +-
1 file
usb-tablet device was wrongly assigned to Misc category
Reported-by: Markus Armbruster
Signed-off-by: Marcel Apfelbaum
Reviewed-by: Andreas Färber
---
Changes from v2:
- Corrected spelling
Changes from v1:
- Add cc to qemu-stable and Gerd Hoffmann
- Changed subject prefix from hw to usb/dev
usb-tablet device was wrongly assigned to Misc category
Reported-by: Markus Armbruster
Cc: qemu-sta...@nongnu.org
Signed-off-by: Marcel Apfelbaum
Reviewed-by: Andreas Färber
---
Changes from v3:
- Added "Cc: qemu-sta...@nongnu.org" this time in the sign-off area ...
Chang
On Thu, 2013-08-22 at 09:34 -0600, Eric Blake wrote:
> On 08/22/2013 08:13 AM, Markus Armbruster wrote:
>
> >>> +++ b/qdev-monitor.c
> >>> @@ -156,6 +156,8 @@ static void
> >>> qdev_print_category_devices(DeviceCategory category)
> >>> DeviceClass *dc;
> >>> GSList *list, *curr;
> >>>
On Thu, 2013-08-22 at 15:48 +0300, Marcel Apfelbaum wrote:
> This patch follows Markus Armbruster suggestion:
>
> A possibly better way to group help by category: instead of adding
> categories to each line, add category headlines, like this:
>
> Controller/Bridge/Hub d
On Sun, 2013-08-25 at 13:23 +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 22, 2013 at 08:11:36PM +0300, Marcel Apfelbaum wrote:
> > usb-tablet device was wrongly assigned to Misc category
> >
> > Reported-by: Markus Armbruster
> > Cc: qemu-sta...@nongnu.org
> >
subregions.
Signed-off-by: Marcel Apfelbaum
---
include/exec/memory.h | 6 +++---
memory.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index ebe0d24..6995087 100644
--- a/include/exec/memory.h
+++ b/include/exec
ned-off-by: Marcel Apfelbaum
---
hw/pci-host/piix.c| 8
hw/pci-host/q35.c | 19 ---
include/hw/pci-host/q35.h | 1 +
3 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index dc1718f..27b04a6 100644
--- a/h
at all the reads/writes to
the pci address space are done by the cpu.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pci.c | 18 ++
include/hw/pci/pci.h | 3 +++
2 files changed, 21 insertions(+)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 4c004f5..f0289fc 100644
--- a/hw
:
For the moment the code assumes that all the reads/writes on
pci address space are done by the cpu.
Marcel Apfelbaum (3):
memory: allow MemoryRegion's priority field to accept negative values
hw/pci: add MemoryRegion ops for unassigned pci addresses
hw/pci-host: catch acesses to unas
On Mon, 2013-09-02 at 15:30 +0100, Peter Maydell wrote:
> On 2 September 2013 15:13, Marcel Apfelbaum wrote:
> > Note: The series is incomplete, for review only
> >
> > PCI spec requires that a transaction that has not been claimed
> > by any PCI bus devices will be
On Mon, 2013-09-02 at 15:38 +0100, Peter Maydell wrote:
> On 2 September 2013 15:13, Marcel Apfelbaum wrote:
> > Priority is used to make visible some subregions by obscuring
> > the parent MemoryRegion addresses overlapping with the subregion.
> >
> > By allowing the
On Mon, 2013-09-02 at 17:48 +0300, Michael S. Tsirkin wrote:
> On Mon, Sep 02, 2013 at 05:13:08PM +0300, Marcel Apfelbaum wrote:
> > The MemoryRegions assigned with this ops shall "intercept"
> > the accesses to unassigned pci address space and the
> > associated cal
On Mon, 2013-09-02 at 15:39 +0100, Peter Maydell wrote:
> On 2 September 2013 15:13, Marcel Apfelbaum wrote:
> > Added a memory region that has negative priority and
> > extends over all the pci adddress space. This region will
> > "catch" all the accesses to the u
On Mon, 2013-09-02 at 15:42 +0100, Peter Maydell wrote:
> On 2 September 2013 15:13, Marcel Apfelbaum wrote:
> > +const MemoryRegionOps pci_unassigned_mem_ops = {
> > +.valid.accepts = pci_unassigned_mem_accepts,
> > +.endianness = DEVICE_NATIVE_ENDIAN,
> > +}
On Mon, 2013-09-02 at 15:43 +0100, Peter Maydell wrote:
> On 2 September 2013 15:39, Marcel Apfelbaum wrote:
> > On Mon, 2013-09-02 at 15:30 +0100, Peter Maydell wrote:
> >> On 2 September 2013 15:13, Marcel Apfelbaum wrote:
> >> > Note: The series
On Mon, 2013-09-02 at 16:53 +0100, Peter Maydell wrote:
> On 2 September 2013 16:42, Marcel Apfelbaum wrote:
> > On Mon, 2013-09-02 at 15:39 +0100, Peter Maydell wrote:
> >> This is happening at the wrong layer -- you want this memory
> >> region to be created and mana
On Fri, 2014-09-19 at 11:39 +0200, Markus Armbruster wrote:
> John Snow writes:
>
> > Signed-off-by: John Snow
> > ---
> > blockdev.c| 10 --
> > device-hotplug.c | 2 +-
> > hw/i386/pc_q35.c | 3 ++-
> > include/hw/boards.h | 3 ++-
> > includ
On Mon, 2014-09-22 at 15:36 +0300, Michael S. Tsirkin wrote:
> On Mon, Sep 22, 2014 at 02:29:08PM +0200, Laszlo Ersek wrote:
> > On 09/22/14 14:04, Andreas Färber wrote:
> > > Am 22.09.2014 um 13:26 schrieb Laszlo Ersek:
> > >> Based on the registration order captured in the previous patch, we
> >
On Mon, 2014-09-22 at 15:43 +0200, Laszlo Ersek wrote:
> On 09/22/14 14:50, Marcel Apfelbaum wrote:
> > On Mon, 2014-09-22 at 15:36 +0300, Michael S. Tsirkin wrote:
> >> On Mon, Sep 22, 2014 at 02:29:08PM +0200, Laszlo Ersek wrote:
> >>> On 09/22/14 14:04, A
efined listing order for machine types
> i386/pc: add piix and q35 machtypes to sorting families for -M \?
>
> include/hw/boards.h | 2 ++
> hw/i386/pc.c| 1 +
> hw/i386/pc_piix.c | 1 +
> hw/i386/pc_q35.c| 1 +
> vl.c | 38 ++
On Wed, 2014-10-01 at 07:26 +0200, Knut Omang wrote:
> On Tue, 2014-09-30 at 21:38 +0800, Gonglei wrote:
> > > Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari
> > > capability of
> > > pcie devices
> > >
> > > On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrot
Hi,
On Mon, 2014-06-09 at 17:38 +0300, Michael S. Tsirkin wrote:
> On Mon, Jun 09, 2014 at 10:20:57AM -0400, Don Slutz wrote:
> > On 06/08/14 11:40, Michael S. Tsirkin wrote:
> > >On Fri, Jun 06, 2014 at 01:52:05PM -0400, Don Slutz wrote:
> > >>This is a pc & q35 only machine opt. One use is to a
On Mon, 2014-06-09 at 17:37 +0200, Igor Mammedov wrote:
> On Mon, 09 Jun 2014 18:10:27 +0300
> Marcel Apfelbaum wrote:
>
> > Hi,
> >
> > On Mon, 2014-06-09 at 17:38 +0300, Michael S. Tsirkin wrote:
> > > On Mon, Jun 09, 2014 at 10:20:57AM -0400, Don Sl
On Thu, 2014-06-12 at 10:02 +0200, Igor Mammedov wrote:
> On Thu, 12 Jun 2014 03:22:24 -0300
> Eduardo Habkost wrote:
>
> > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine
> > definitions to corresponding class registration code.
> >
> > Having the PC code converted to p
ion migration.
> Need to handle that depending on pc version as appropriate.
Besides the above comment,
Tested-by: Marcel Apfelbaum
Reviewed-by: Marcel Apfelbaum
Thanks,
Marcel
>
> > ---
> > hw/i386/acpi-build.c | 21 ++---
> > 1 file changed, 14 insertio
commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830
hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached
introduced support for hot-plugging devices behind pci-2-pci bridges.
Extend hotplug support also for pci express downstream ports.
Signed-off-by: Marcel Apfelbaum
Trivial issue, discovered while debugging.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 02cde6f..ae92f00 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -224,7 +224,7 @@ static void
Hotplug triggers both 'present detect change' and
'attention button pressed'.
Hotunplug starts by triggering 'attention button pressed',
then waits for the OS to power off the device and only
then detaches it.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pcie.c | 2
unctionality, so we need to think about converting
virtio devices to pci express.
Linux outputs a "Surprise Removal/Addition" info message because
we trigger 2 events in the same time, however this warning
can be disregarded or a kernel patch submitted for our scenario.
Mar
It is needed by hot-unplug in order to get an indication
from the OS when the device can be physically detached.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pcie.c | 15 ++-
include/hw/pci/pcie_regs.h | 2 ++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git
On Thu, 2014-06-19 at 17:21 +0300, Michael S. Tsirkin wrote:
> On Thu, Jun 19, 2014 at 04:52:17PM +0300, Marcel Apfelbaum wrote:
> > commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830
> > hw/pci: reserve IO and mem for pci-2-pci bridges with no devices
> > attached
> &
On Thu, 2014-06-19 at 17:39 +0300, Michael S. Tsirkin wrote:
> On Thu, Jun 19, 2014 at 04:52:20PM +0300, Marcel Apfelbaum wrote:
> > It is needed by hot-unplug in order to get an indication
> > from the OS when the device can be physically detached.
> >
> > Sign
On Thu, 2014-06-19 at 17:43 +0300, Michael S. Tsirkin wrote:
> On Thu, Jun 19, 2014 at 04:52:21PM +0300, Marcel Apfelbaum wrote:
> > Hotplug triggers both 'present detect change' and
> > 'attention button pressed'.
> >
> > Hotunplug starts by trigge
On Sun, 2014-06-22 at 14:03 +0300, Michael S. Tsirkin wrote:
> On Sun, Jun 22, 2014 at 01:54:06PM +0300, Marcel Apfelbaum wrote:
> > On Thu, 2014-06-19 at 17:43 +0300, Michael S. Tsirkin wrote:
> > > On Thu, Jun 19, 2014 at 04:52:21PM +0300, Marcel Apfelbaum wrote:
> > &
On Sun, 2014-06-22 at 14:11 +0300, Michael S. Tsirkin wrote:
> On Sun, Jun 22, 2014 at 01:52:46PM +0300, Michael S. Tsirkin wrote:
> > On Sun, Jun 22, 2014 at 01:47:24PM +0300, Marcel Apfelbaum wrote:
> > > On Thu, 2014-06-19 at 17:39 +0300, Michael S. Tsirkin wrote:
> >
On Sun, 2014-06-22 at 14:12 +0300, Michael S. Tsirkin wrote:
> On Sun, Jun 22, 2014 at 02:11:05PM +0300, Marcel Apfelbaum wrote:
> > On Sun, 2014-06-22 at 14:03 +0300, Michael S. Tsirkin wrote:
> > > On Sun, Jun 22, 2014 at 01:54:06PM +0300, Marcel Apfelbaum wrote:
> > >
the OS to power off the device and only
then detaches it.
Fixes CVE-2014-3471.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pcie.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index d6d9eb8..da32589 100644
--
owever this warning
can be disregarded or a kernel patch submitted for our scenario.
Marcel Apfelbaum (3):
hw/pcie: corrected a debug message
hw/pcie: implement power controller functionality
hw/pcie: better hotplug/hotunplug support
hw/pci-bridge/ioh3420.c
Trivial issue, discovered while debugging.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 02cde6f..ae92f00 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -224,7 +224,7 @@ static void
It is needed by hot-unplug in order to get an indication
from the OS when the device can be physically detached.
Signed-off-by: Marcel Apfelbaum
---
hw/pci-bridge/ioh3420.c| 7 +++
hw/pci-bridge/xio3130_downstream.c | 7 +++
hw/pci/pcie.c | 33
On Mon, 2014-06-23 at 14:41 +0300, Michael S. Tsirkin wrote:
> On Mon, Jun 23, 2014 at 02:15:24PM +0300, Marcel Apfelbaum wrote:
> > Trivial issue, discovered while debugging.
> >
> > Signed-off-by: Marcel Apfelbaum
>
> Can you rebase on pci branch pls?
Sure,
Mar
the OS to power off the device and only
then detaches it.
Fixes CVE-2014-3471.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pcie.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index d6d9eb8..da32589 100644
--
because
we trigger 2 events in the same time, however this warning
can be disregarded or a kernel patch submitted for our scenario.
Marcel Apfelbaum (3):
hw/pcie: corrected a debug message
hw/pcie: implement power controller functionality
hw/pcie: better hotplug/hotunplug support
Trivial issue, discovered while debugging.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 02cde6f..ae92f00 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -224,7 +224,7 @@ static void
It is needed by hot-unplug in order to get an indication
from the OS when the device can be physically detached.
Signed-off-by: Marcel Apfelbaum
---
hw/pci-bridge/ioh3420.c| 7 +++
hw/pci-bridge/xio3130_downstream.c | 7 +++
hw/pci/pcie.c | 33
Commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830
hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached
introduced support for hot-plugging devices behind pci-2-pci bridges.
Extend hotplug support also for pci express downstream ports.
Signed-off-by: Marcel Apfelbaum
On Mon, 2014-06-23 at 23:41 +0200, Andreas Färber wrote:
> Am 23.06.2014 23:35, schrieb Alexey Kardashevskiy:
> > Looks like I must copy PC_COMPAT_X_X as PSERIES_COMPAT_X_X starting 1.6 (or
> > 1.7 - whichever starts supporting migration well enough on pseries) because
> > pretty much of what they
On Tue, 2014-06-24 at 14:55 -0300, Eduardo Habkost wrote:
> On Tue, Jun 24, 2014 at 05:47:53PM +0100, Peter Maydell wrote:
> > On 24 June 2014 17:44, Eduardo Habkost wrote:
> > > (I would go even further and say that no compat_props bit need to be
> > > specific to a machine-type family, and they
On Tue, 2014-06-24 at 15:02 -0300, Eduardo Habkost wrote:
> The QEMU_COMPAT_* macros will contain compat properties that are not
> specific to PC, and may be reused by other machine-types.
>
> PC-specific properties were left on the PC_COMPAT_* macros.
>
> Signed-off-by: Eduardo Habkost
> ---
>
On Tue, 2014-06-24 at 15:02 -0300, Eduardo Habkost wrote:
> They are not used anywhere else, to it is simpler to just keep them
> closer to the places where they are used.
Isolation is always welcomed.
Reviewed-by: Marcel Apfelbaum
>
> Signed-off-by: Eduardo Habkost
> ---
>
On Tue, 2014-06-24 at 15:02 -0300, Eduardo Habkost wrote:
> All compat properties are only applied if a device of an specific type
> is instantiated. There's no need to keep a PC-specific list of compat
> properties, as properties for PC-specific devices won't affect other
> machine-types anyway.
On Sun, 2014-08-17 at 13:00 +0200, Michael S. Tsirkin wrote:
> On Fri, Aug 15, 2014 at 07:33:29AM +, Gonglei (Arei) wrote:
> > Hi,
> >
> > I noticed that the qemu-2.1 release change log says
> > " PCIe: Basic hot-plug/hot-unplug support for Q35 machine."
> > And then I made a testing for the h
On Mon, 2014-08-18 at 15:54 +0800, zhanghailiang wrote:
> The function fopen() may fail, so check its return value.
>
> Signed-off-by: zhanghailiang
> Signed-off-by: Li Liu
> Reviewed-by: Alex Bennée
> ---
> tests/bios-tables-test.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git
On Mon, 2014-08-18 at 15:37 +0400, Michael Tokarev wrote:
> 18.08.2014 13:13, Marcel Apfelbaum wrote:
> > On Mon, 2014-08-18 at 15:54 +0800, zhanghailiang wrote:
> >> The function fopen() may fail, so check its return value.
> >>
> >> Signed-off-by: zhang
On Tue, 2014-08-19 at 21:08 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
Hi,
>
> Right now, ARI Forwarding dose not support in QEMU.
I would replace the above sentence with "ARI Forwarding is not supported".
By the way, there is some support for ARI, I don't know if
is enabled yet. I'l
On Tue, 2014-08-19 at 15:18 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> When 'bsel == ACPI_PCIHP_MAX_HOTPLUG_BUS', the
> s->acpi_pcihp_pci_status[bsel] array will out of bounds.
I would change the commit message to something like
"Prevent out-of-bounds array access on acpi_pcihp_pci
atic uint64_t pci_read(void *opaque, hwaddr addr,
> unsigned int size)
> uint32_t val = 0;
> int bsel = s->hotplug_select;
>
> -if (bsel < 0 || bsel > ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> +if (bsel < 0 || bsel >= ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> return 0;
> }
>
Reviewed-by: Marcel Apfelbaum
On Wed, 2014-08-20 at 03:20 +, Gonglei (Arei) wrote:
> Hi,
>
> > > Right now, ARI Forwarding dose not support in QEMU.
> > I would replace the above sentence with "ARI Forwarding is not supported".
> >
> OK.
>
> > By the way, there is some support for ARI, I don't know if
> > is enabled yet.
On Wed, 2014-08-20 at 08:53 +0200, Knut Omang wrote:
> Enable the PCIe capability bit that indicates that this port is able to
> support
> and forward requests to > 8 functions for ARI capable devices.
>
> Signed-off-by: Knut Omang
> ---
> hw/pci-bridge/ioh3420.c | 7 +++
> 1 file changed,
On Wed, 2014-08-20 at 08:52 +0200, Knut Omang wrote:
> PCI_ARI_CAP_NFN is for reading next function not writing it
The commit message is not so clear, maybe something like
"Fix incorrect write to ari capability
or similar?
Other than that the patch looks OK to me.
Thanks,
Marcel
>
> Signed-
On Thu, 2014-08-21 at 17:47 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> If ARI Forwarding is disabled, according to PCIe spec
> section 7.3.1, only slot 0 with the device attached to
> logic bus representing the link from downstream
> ports and root ports.
>
> So, adding check for
Categorize devices that appear as output to "-device ?" command
by logical functionality. Sort the devices by logical categories
before showing them to user.
The sort is done by functionality rather than alphabetical.
Signed-off-by: Marcel Apfelbaum
---
Changes from RFC
Made categor
embly - hosts/hubs/...
Management - controllers
...
(All others are self explanatory)
Changes from RFC patch:
Made category a bitmap to support multifunction PCI devices.
Assigned all devices to their category.
Marcel Apfelbaum (2):
qemu-help: Sort devices by logical functionality
devices: Associ
Assigned all devices to their category.
Marcel Apfelbaum (3):
hw: import bitmap operations in qdev-core header
qemu-help: Sort devices by logical functionality
devices: Associate devices to their logical category
hw/9pfs/virtio-9p-device.c | 1 +
hw/audio/ac97.c
Made small tweaks in code to prevent compilation issues
when importing qemu/bitmap.h in qdev-core
Signed-off-by: Marcel Apfelbaum
---
hw/core/qdev-properties.c | 4 ++--
hw/net/eepro100.c | 1 -
include/hw/qdev-core.h| 1 +
3 files changed, 3 insertions(+), 3 deletions(-)
diff
Categorize devices that appear as output to "-device ?" command
by logical functionality. Sort the devices by logical categories
before showing them to user.
The sort is done by functionality rather than alphabetical.
Signed-off-by: Marcel Apfelbaum
---
Changes from v1:
Address
On Mon, 2013-07-29 at 09:36 +0200, Paolo Bonzini wrote:
> Il 28/07/2013 11:14, Marcel Apfelbaum ha scritto:
> > Categories:
> > Assembly - hosts/hubs/...
>
> A lot of these seem to fit in a "bridge" category.
I wanted to group in a category as much as possibl
On Mon, 2013-07-29 at 10:42 +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 29, 2013 at 10:07:33AM +0300, Marcel Apfelbaum wrote:
> > Made small tweaks in code to prevent compilation issues
> > when importing qemu/bitmap.h in qdev-core
> >
> > Signed-off-by: Marcel Apfe
On Mon, 2013-07-29 at 11:04 +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 29, 2013 at 10:07:34AM +0300, Marcel Apfelbaum wrote:
> > Categorize devices that appear as output to "-device ?" command
> > by logical functionality. Sort the devices by logical categories
> &
On Mon, 2013-07-29 at 11:20 +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 29, 2013 at 11:14:11AM +0300, Marcel Apfelbaum wrote:
> > On Mon, 2013-07-29 at 11:04 +0300, Michael S. Tsirkin wrote:
> > > On Mon, Jul 29, 2013 at 10:07:34AM +0300, Marcel Apfelbaum wrote:
> > >
On Mon, 2013-07-29 at 12:22 +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 29, 2013 at 12:09:45PM +0300, Marcel Apfelbaum wrote:
> > On Mon, 2013-07-29 at 11:20 +0300, Michael S. Tsirkin wrote:
> > > On Mon, Jul 29, 2013 at 11:14:11AM +0300, Marcel Apfelbaum wrote:
> > >
ment category by USB
Changes from v1:
Addressed Michael Tsirkin review:
Used bitmap operations on categories
Moved category names into the header file
Changes from RFC patch:
Made category a bitmap to support multifunction PCI devices.
Assigned all devices to their category.
Marcel Apfe
Categorize devices that appear as output to "-device ?" command
by logical functionality. Sort the devices by logical categories
before showing them to user.
The sort is done by functionality rather than alphabetical.
Signed-off-by: Marcel Apfelbaum
---
Changes from v2:
Address
Made small tweaks in code to prevent compilation issues
when importing qemu/bitmap.h in qdev-core
Signed-off-by: Marcel Apfelbaum
---
Changes from v2
- explicit inclusion of the bitmap headers
- modified names of all methods of qdev_prop_bit
to prevent compilation errors
hw/core
On Mon, 2013-07-29 at 15:11 +0300, Marcel Apfelbaum wrote:
> Categorize devices that appear as output to "-device ?" command
> by logical functionality. Sort the devices by logical categories
> before showing them to user.
>
> The sort is done by functionality
On Mon, 2013-07-29 at 13:27 +0200, Paolo Bonzini wrote:
> Il 29/07/2013 10:00, Marcel Apfelbaum ha scritto:
> > On Mon, 2013-07-29 at 09:36 +0200, Paolo Bonzini wrote:
> >> Il 28/07/2013 11:14, Marcel Apfelbaum ha scritto:
> >>> Categories:
> >>> Asse
On Mon, 2013-07-29 at 14:32 +0200, Paolo Bonzini wrote:
> Il 29/07/2013 14:11, Marcel Apfelbaum ha scritto:
> > Running qemu with "-device ?" option returns ~145 lines.
> > It is hard to manage understanding the output.
> >
> > Theses patches aim to partia
On Mon, 2013-07-29 at 15:28 +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 29, 2013 at 03:11:42PM +0300, Marcel Apfelbaum wrote:
> > Categorize devices that appear as output to "-device ?" command
> > by logical functionality. Sort the devices by logical categories
> &
On Mon, 2013-07-29 at 15:42 +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 29, 2013 at 03:36:24PM +0300, Marcel Apfelbaum wrote:
> > On Mon, 2013-07-29 at 15:28 +0300, Michael S. Tsirkin wrote:
> > > On Mon, Jul 29, 2013 at 03:11:42PM +0300, Marcel Apfelbaum wrote:
> > >
. Tsirkin review:
Used bitmap operations on categories
Moved category names into the header file
Changes from RFC patch:
Made category a bitmap to support multifunction PCI devices.
Assigned all devices to their category.
Marcel Apfelbaum (3):
hw: import bitmap operations in qdev-core header
Made small tweaks in code to prevent compilation issues
when importing qemu/bitmap.h in qdev-core
Signed-off-by: Marcel Apfelbaum
---
Changes from v2
- explicit inclusion of the bitmap headers
- modified names of all methods of qdev_prop_bit
to prevent compilation errors
hw/core
Categorize devices that appear as output to "-device ?" command
by logical functionality. Sort the devices by logical categories
before showing them to user.
The sort is done by functionality rather than alphabetical.
Signed-off-by: Marcel Apfelbaum
---
Changes from v3:
- fixe
On Tue, 2013-07-30 at 22:41 +0200, Stefan Weil wrote:
> The definition of macro BIT in tci/tcg-target.c now conflicts with the
> definition of the same macro in includes qemu/bitops.h.
>
> This conflict was triggered by a recent change in the include chain of
> tcg.c (probably commit 949fc82314cc8
Hi,
The problem with pvpanic being an internal device is that VMs running
operating systems without a driver for this device will have problems
when qemu will be upgraded (from qemu without this pvpanic).
The outcome may be, for example: in Windows(let's say XP) the Device manager
will open a "ne
On Thu, 2013-08-01 at 19:31 +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 01, 2013 at 10:26:53AM -0600, Eric Blake wrote:
> > On 08/01/2013 08:18 AM, Gerd Hoffmann wrote:
> > > On 08/01/13 15:08, Marcel Apfelbaum wrote:
> > >> Hi,
> > >>
> > >>
On Thu, 2013-08-01 at 16:32 +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 01, 2013 at 04:08:57PM +0300, Marcel Apfelbaum wrote:
> > Hi,
> >
> > The problem with pvpanic being an internal device is that VMs running
> > operating systems without a driver for this device
of 1.5
machine.
Signed-off-by: Marcel Apfelbaum
---
Changes from v1:
- Keep pvpanic device enabled by default for 1.5
for backport compatibility
hw/i386/pc_piix.c | 9 -
hw/i386/pc_q35.c | 7 ---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/i386/pc_p
This patch is based on Hu Tao's:
http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00125.html
The pvpanic device may be enabled now with "-device pvpanic"
from command line.
Signed-off-by: Marcel Apfelbaum
---
Changes from V1:
- Addressed Andreas Färber review (r
ddressed Andreas Färber review (removed bus type)
- Small changes to be posible to enable pvpanic
both from command line and from machine_init
- Added pvpanic to MISC category
Marcel Apfelbaum (2):
hw/misc: don't create pvpanic device by default
hw/misc: make pvpanic known to user
hw/i3
Device
> >>> manager will open a "new device" wizard and the device will appear as
> >>> an unrecognized device. On a cluster with hundreds of such VMs, If
> >>> that cluster has a health monitoring service it may show all the VMs
> >>> in a &qu
On Mon, 2013-08-12 at 09:53 -0600, Eric Blake wrote:
> On 08/11/2013 09:10 AM, Marcel Apfelbaum wrote:
> > Creating the pvpanic device as part of the machine type has the
> > potential to trigger guest OS, guest firmware and driver bugs.
> > The potential of such was origina
ther that doesn't support required machine type yet (the version
> user downgraded to have to have this patch applied too, of course).
>
> Signed-off-by: Michal Novotny
> ---
> vl.c | 5 +
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Marcel Apfelbaum
> dif
A wrong offset was added to the tables pointed by RSDT
if the HPET table is not present.
Signed-off-by: Marcel Apfelbaum
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index c98df88..d65fab0 100644
--- a
On Sun, 2014-05-11 at 11:07 +0800, lijun wrote:
> On 04/22/2014 05:21 PM, Marcel Apfelbaum wrote:
> > On Wed, 2014-04-16 at 22:20 +0800, Jun Li wrote:
> >> Add remove_boot_device_path() function to remove bootindex when hot-unplug
> >> a device. This patch fixed virt
1 - 100 of 2768 matches
Mail list logo
