bexec/virtiofsd" sig=31 arch=8016 syscall=119
compat=0 ip=0x3fff15f748a code=0x8000AUID="unset" UID="root" GID="root"
ARCH=s390x SYSCALL=sigreturn
Signed-off-by: Marc Hartmayer
---
tools/virtiofsd/passthrough_seccomp.c | 1 +
1 file cha
German Maglione writes:
> On Fri, Nov 25, 2022 at 3:40 PM Marc Hartmayer wrote:
>>
>> The virtiofsd currently crashes on s390x. This is because of a
>> `sigreturn` system call. See audit log below:
>>
>> type=SECCOMP msg=audit(1669382477.611:459): auid=42949672
"Dr. David Alan Gilbert" writes:
> * Marc Hartmayer (mhart...@linux.ibm.com) wrote:
>> The virtiofsd currently crashes on s390x. This is because of a
>> `sigreturn` system call. See audit log below:
>>
>> type=SECCOMP msg=audit(1669382477.611:459): auid=4294
Christian Borntraeger writes:
> Am 29.11.22 um 10:52 schrieb Christian Borntraeger:
>>
>>
>> Am 29.11.22 um 10:42 schrieb Dr. David Alan Gilbert:
>>> * Marc Hartmayer (mhart...@linux.ibm.com) wrote:
>>>> "Dr. David Alan Gilbert" writes:
German Maglione writes:
> On Mon, Nov 28, 2022 at 10:00 AM Marc Hartmayer
> wrote:
>>
>> German Maglione writes:
>>
>> > On Fri, Nov 25, 2022 at 3:40 PM Marc Hartmayer
>> > wrote:
>> >>
>> >> The virtiofsd currently crashes
On Fri, Nov 03, 2023 at 01:56 PM +0300, Dmitrii Gavrilov
wrote:
> Original goal of addition of drain_call_rcu to qmp_device_add was to cover
> the failure case of qdev_device_add. It seems call of drain_call_rcu was
> misplaced in 7bed89958bfbf40df what led to waiting for pending RCU callbacks
>
On Fri, Apr 26, 2024 at 11:57 AM +0300, Dmitrii Gavrilov
wrote:
> 26.04.2024, 11:17, "Marc Hartmayer" :
>
> On Fri, Nov 03, 2023 at 01:56 PM +0300, Dmitrii Gavrilov
> wrote:
>
> Original goal of addition of drain_call_rcu to qmp_device_add was to c
((char *)_sccb, 0, sizeof(ReadInfo));
> -sccb->h.length = sizeof(ReadInfo);
> +sccb->h.length = SCCB_SIZE;
> if (!sclp_service_call(SCLP_CMDW_READ_SCP_INFO, sccb)) {
> ebcdic_to_ascii((char *) sccb->loadparm, loadparm, LOADPARM_LEN);
> }
> --
> 2.7.4
o, so with older kernels this field
would read zero and we must then assume that only 896 bytes are available.
Acked-by: Viktor Mihajlovski
Signed-off-by: Marc Hartmayer
---
hw/s390x/ipl.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/hw/s390x/ipl.c
David Hildenbrand writes:
> On 22.11.21 12:29, Marc Hartmayer wrote:
>> In the past s390 used a fixed command line length of 896 bytes. This has
>> changed
>> with the Linux commit 5ecb2da660ab ("s390: support command lines longer than
>> 896
>> bytes"
Check if the provided kernel command line exceeds the maximum size of the s390x
Linux kernel command line size, which is 896 bytes.
Reported-by: Sven Schnelle
Signed-off-by: Marc Hartmayer
---
hw/s390x/ipl.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/hw
_active_state=0x3ff73efb67c) at ../migration/migration.c:2710
#18 migration_completion (s=0x2aa3625d1f0) at ../migration/migration.c:2774
#19 migration_iteration_run (s=0x2aa3625d1f0) at ../migration/migration.c:3198
#20 migration_thread (opaque=opaque@entry=0x2aa3625d1f0) at
../migration/migration.c:
the
> user tries to save or migrate the VM state. Fix it by using s390_get_flic()
> to get the correct device here instead.
>
> Reported-by: Marc Hartmayer
> Fixes: 9d1b0f5bf5 ("s390_flic: add migration-enabled property")
> Signed-off-by: Thomas Huth
> ---
> hw/i
Thomas Huth writes:
> On 06/10/2021 11.26, Marc Hartmayer wrote:
>> Check if the provided kernel command line exceeds the maximum size of the
>> s390x
>> Linux kernel command line size, which is 896 bytes.
>>
>> Reported-by: Sven Schnelle
>> Signed-off-b
Janosch Frank writes:
> Let's start bundling the writes of the headers and of the data so we
> have a clear ordering between them. Since the ELF header uses offsets
> to the headers we can freely order them.
>
> Signed-off-by: Janosch Frank
> ---
> dump/dump.c | 31 ++---
Janosch Frank writes:
> On 10/17/22 14:49, Marc Hartmayer wrote:
>> Janosch Frank writes:
>>
>>> Let's start bundling the writes of the headers and of the data so we
>>> have a clear ordering between them. Since the ELF header uses offsets
>&
macro for this
- e.g. STACK_FRAME_SIZE.
Besides that,
Reviewed-by: Marc Hartmayer
>
> /* clear bss */
> larl%r2,__bss_start
> --
> 2.39.3
>
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research &
mmand 4 (KVM_PV_VERIFY) failed: header rc 102 rrc
1b IOCTL rc: -22
Protected boot has failed: 0xa02
--
Kind regards / Beste Grüße
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
Public bug reported:
I ran into a bug when I started several VMs in parallel using
libvirt. The VMs are using only a kernel and a initrd (which includes a
minimal OS). The guest OS itself does a 'poweroff -f' as soon as the
login prompt shows up. So the expectaction is that the VMs will start,
the
On Thu, Oct 12, 2017 at 02:07 PM +0200, Jiri Denemark
wrote:
> On Mon, Oct 09, 2017 at 10:16:48 +0200, Marc Hartmayer wrote:
>> On Thu, Oct 05, 2017 at 02:11 PM +0200, Jiri Denemark
>> wrote:
>> > But it's going to be a bit complicated because we ask QEMU what
sistent host-model copy option? So
> instead of copying at every start, only copy and replace it once in the XML?
>
> Easy to specify by the user and no CPU feature changes will happend
> "blindly".
>
>
> --
>
> Thanks,
>
> David
>
--
Beste Grüße / Kind regards
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
On Mon, Aug 03, 2020 at 11:26 AM +0200, Cornelia Huck wrote:
> On Thu, 30 Jul 2020 16:07:31 +0200
> Marc Hartmayer wrote:
>
>> Since virtio existed even before it got standardized, the virtio
>> standard defines the following types of virtio devices:
>>
>>
ardev=char0,tag=myfs \
-drive if=virtio,file=disk.qcow2 \
-m 2G -smp 2 -nographic
Log into the guest and mount it
$ mount -t virtiofs myfs /mnt
Halil Pasic (1):
virtio: add vhost-user-fs-ccw device
Marc Hartmayer (3):
libvhost-user: print invalid address on vu_panic
libvhost-user: h
This patch exists only to show the actual problem that libvhost-user
and it's users are architecture dependent as soon as we're trying to
support legacy virtio.
Signed-off-by: Marc Hartmayer
---
Makefile.objs | 1 +
contrib/libvhost-user/libvhost-ac
From: Halil Pasic
Wire up the CCW device for vhost-user-fs.
Signed-off-by: Halil Pasic
---
hw/s390x/Makefile.objs | 1 +
hw/s390x/vhost-user-fs-ccw.c | 74
2 files changed, 75 insertions(+)
create mode 100644 hw/s390x/vhost-user-fs-ccw.c
diff --git
andle
virtio endianness as required by the virtio specification [1].
[1]
https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-210003
Signed-off-by: Marc Hartmayer
---
contrib/libvhost-user/libvhost-access.h | 88 +
contrib/libvhost-user/libvhost-u
uot;: replace qdev_set_parent_bus
and object_property_set_bool by qdev_realize
+ patch "libvhost-user: handle endianness as mandated by the spec":
Drop support for legacy virtio devices
+ add patch to fence legacy virtio devices
Halil Pasic (1):
virtio: add vhost-user-fs-ccw dev
libvhost-user has no support for legacy virtio devices therefore
let's fence them.
Signed-off-by: Marc Hartmayer
---
contrib/libvhost-user/libvhost-access.h | 10 ++
contrib/libvhost-user/libvhost-user.c | 6 ++
2 files changed, 16 insertions(+)
diff --git a/contrib/lib
From: Halil Pasic
Wire up the CCW device for vhost-user-fs.
Signed-off-by: Halil Pasic
---
hw/s390x/Makefile.objs | 1 +
hw/s390x/vhost-user-fs-ccw.c | 73
2 files changed, 74 insertions(+)
create mode 100644 hw/s390x/vhost-user-fs-ccw.c
diff --git
andle virtio
endianness for non-legacy as required by the virtio specification
[1]. We will fence non-legacy virtio devices with the upcoming patch.
[1]
https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-210003
Signed-off-by: Marc Hartmayer
---
Note: As we don'
On Tue, Jul 21, 2020 at 06:44 PM +0200, Halil Pasic wrote:
> On Tue, 21 Jul 2020 09:40:10 -0400
> "Michael S. Tsirkin" wrote:
>
>> On Fri, Jul 17, 2020 at 11:29:28AM +0200, Marc Hartmayer wrote:
>> > Since virtio existed even before it got standardized, th
On Wed, Jul 29, 2020 at 10:13 AM -0400, "Michael S. Tsirkin"
wrote:
> On Tue, Jul 28, 2020 at 12:52:11PM +0200, Marc Hartmayer wrote:
>> On Tue, Jul 21, 2020 at 06:44 PM +0200, Halil Pasic
>> wrote:
>> > On Tue, 21 Jul 2020 09:40:10 -0400
>> > &qu
On Tue, Jul 21, 2020 at 01:48 PM +0100, Stefan Hajnoczi
wrote:
> On Fri, Jul 17, 2020 at 11:29:28AM +0200, Marc Hartmayer wrote:
>> Since virtio existed even before it got standardized, the virtio
>> standard defines the following types of virtio devices:
>>
>> + le
andle virtio
endianness for non-legacy as required by the virtio specification
[1]. The fencing of legacy virtio devices is done in
`vu_set_features_exec`.
[1]
https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-210003
Signed-off-by: Marc Hartmayer
---
contrib/libvhost
-ccw device": replace qdev_set_parent_bus
and object_property_set_bool by qdev_realize
+ patch "libvhost-user: handle endianness as mandated by the spec":
Drop support for legacy virtio devices
+ add patch to fence legacy virtio devices
*** BLURB HERE ***
Halil Pasic (1):
virtio: add
From: Halil Pasic
Wire up the CCW device for vhost-user-fs.
Signed-off-by: Halil Pasic
---
hw/s390x/Makefile.objs | 1 +
hw/s390x/vhost-user-fs-ccw.c | 75
2 files changed, 76 insertions(+)
create mode 100644 hw/s390x/vhost-user-fs-ccw.c
diff --git
On Sun, Aug 02, 2020 at 01:13 AM -0400, "Michael S. Tsirkin"
wrote:
> On Thu, Jul 30, 2020 at 04:07:31PM +0200, Marc Hartmayer wrote:
>> Since virtio existed even before it got standardized, the virtio
>> standard defines the following types of virtio devices:
>>
This can be helpful for debugging.
Signed-off-by: Marc Hartmayer
---
contrib/libvhost-user/libvhost-user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/libvhost-user/libvhost-user.c
b/contrib/libvhost-user/libvhost-user.c
index d315db139606..9e8750a9dabc 100644
Don't read the block if a null block number is reached, because this means that
the end of chunk is reached.
Reviewed-by: Collin Walling
Signed-off-by: Marc Hartmayer
---
pc-bios/s390-ccw/bootmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/bootma
On Thu, Oct 22, 2020 at 06:31 AM -0400, Janosch Frank
wrote:
> Diag318 fencing needs to be determined on the current VM PV state and
> not on the state that the VM has when we create the CPU model.
>
> Signed-off-by: Janosch Frank
> Reported-by: Marc Hartmayer
> Fixes: fabdad
It was fixed with commit 4cf077b59fc73eec29f8b7 (see patch series
https://lists.gnu.org/archive/html/qemu-block/2018-09/msg00504.html).
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1788582
Title:
;)
Reviewed-by: Collin Walling
Signed-off-by: Marc Hartmayer
---
pc-bios/s390-ccw/bootmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
index 97205674e59a..0d29dceaa3cc 100644
--- a/pc-bios/s390-ccw/bootmap.c
++
Break the loop if `cur_block_nr` is a null block number because this
means that the end of chunk is reached. In this case we will try to
boot the default entry.
Fixes: ba831b25262a ("s390-ccw: read stage2 boot loader data to find menu")
Reviewed-by: Collin Walling
Signed-off-by: Marc
ere is a branch:
https://gitlab.com/mhartmay/qemu/-/tree/bios_fixes
Marc Hartmayer (3):
pc-bios/s390-ccw: fix off-by-one error
pc-bios/s390-ccw: break loop if a null block number is reached
pc-bios/s390-ccw: Update s390-ccw.img bios binary
pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes
Contains the fixes "pc-bios/s390-ccw: fix off-by-one error" and
"pc-bios/s390-ccw: break loop if a null block number is reached".
Signed-off-by: Marc Hartmayer
---
pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git
On Thu, Sep 24, 2020 at 12:02 PM +0200, Philippe Mathieu-Daudé
wrote:
> Hi Marc,
>
> On 9/24/20 10:59 AM, Marc Hartmayer wrote:
>> This error takes effect when the magic value "zIPL" is located at the
>> end of a block. For example if s2_cur_blk = 0x7fe18000 a
On Thu, Sep 24, 2020 at 01:49 PM +0200, Thomas Huth wrote:
> On 24/09/2020 10.59, Marc Hartmayer wrote:
>> Break the loop if `cur_block_nr` is a null block number because this
>> means that the end of chunk is reached. In this case we will try to
>> boot the defaul
move directory options from config-host.mak to
meson")
Signed-off-by: Marc Hartmayer
---
contrib/vhost-user-gpu/meson.build | 2 +-
tools/virtiofsd/meson.build| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/vhost-user-gpu/meson.build
b/contrib/vhos
On Tue, Nov 03, 2020 at 12:23 PM +0100, Marc Hartmayer
wrote:
> The option `libexecdir` is relative to `prefix` (see
> https://mesonbuild.com/Builtin-options.html), so we have to be aware
> of this when creating 50-qemu-gpu.json and
> 50-qemu-virtiofsd.json. Otherwise, tools like
On Tue, Nov 03, 2020 at 12:55 PM +0100, Paolo Bonzini
wrote:
> On 03/11/20 12:28, Marc Hartmayer wrote:
>> On Tue, Nov 03, 2020 at 12:23 PM +0100, Marc Hartmayer
>> wrote:
>>> The option `libexecdir` is relative to `prefix` (see
>>> https://mesonbuild.com/Bui
n.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-210003
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Marc Hartmayer
---
contrib/libvhost-user/libvhost-user.c | 77 +++
1 file changed, 43 insertions(+), 34 deletions(-)
diff --git a/contrib/libvhost-user/libvhost-user
From: Halil Pasic
Wire up the CCW device for vhost-user-fs.
Reviewed-by: Cornelia Huck
Signed-off-by: Halil Pasic
---
hw/s390x/meson.build | 1 +
hw/s390x/vhost-user-fs-ccw.c | 75
2 files changed, 76 insertions(+)
create mode 100644 hw/s390x/vho
patch "libvhost-user: handle endianness as mandated by the spec":
Drop support for legacy virtio devices
+ add patch to fence legacy virtio devices
Halil Pasic (1):
virtio: add vhost-user-fs-ccw device
Marc Hartmayer (1):
libvhost-user: handle endianness as m
On Wed, Oct 02, 2024 at 11:57 AM +0200, Thomas Huth wrote:
> On 01/10/2024 17.36, Marc Hartmayer wrote:
>>
>> Jens Remus (2):
>>pc-bios/s390-ccw: Clarify alignment is in bytes
>>pc-bios/s390-ccw: Don't generate TEXTRELs
>>
>> Marc Hart
Some packaging tools want to override `LDFLAGS` when building QEMU, this will
result in a build error as most likely no `-nostdlib` flag is passed. Introduce
`EXTRA_LDFLAGS` so that the packager can override `LDFLAGS` without breaking the
build.
Signed-off-by: Marc Hartmayer
---
Note: Normally
request is in bytes. No functional change.
[1] https://sourceware.org/binutils/docs/as/Align.html
[2] https://sourceware.org/binutils/docs/as/Balign.html
Signed-off-by: Jens Remus
Reviewed-by: Marc Hartmayer
---
pc-bios/s390-ccw/start.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
e that the R_390_RELATIVE relocations are taken care of by function
glue() in include/hw/elf_ops.h.inc introduced by commit 5dce07e1cb67
("elf-loader: Provide the possibility to relocate s390 ELF files").
Reported-by: Marc Hartmayer
Signed-off-by: Jens Remus
Reviewed-by: Marc Hartmayer
Jens Remus (2):
pc-bios/s390-ccw: Clarify alignment is in bytes
pc-bios/s390-ccw: Don't generate TEXTRELs
Marc Hartmayer (1):
pc-bios/s390-ccw: Introduce `EXTRA_LDFLAGS`
pc-bios/s390-ccw/netboot.mak | 2 +-
pc-bios/s390-ccw/Makefile| 5 +++--
pc-bios/s390-ccw/start.S
58 matches
Mail list logo
