Janosch Frank <fran...@linux.ibm.com> writes: > On 10/17/22 14:49, Marc Hartmayer wrote: >> Janosch Frank <fran...@linux.ibm.com> writes: >> >>> Let's start bundling the writes of the headers and of the data so we >>> have a clear ordering between them. Since the ELF header uses offsets >>> to the headers we can freely order them. >>> >>> Signed-off-by: Janosch Frank <fran...@linux.ibm.com> >>> --- >>> dump/dump.c | 31 ++++++++++++++----------------- >>> 1 file changed, 14 insertions(+), 17 deletions(-) >>> >>> diff --git a/dump/dump.c b/dump/dump.c >>> index e7a3b54ebe..b168a25321 100644 >>> --- a/dump/dump.c >>> +++ b/dump/dump.c >>> @@ -583,6 +583,8 @@ static void dump_begin(DumpState *s, Error **errp) >>> * -------------- >>> * | elf header | >>> * -------------- >>> + * | sctn_hdr | >>> + * -------------- >> >> While you’re at it, I would suggest to add the location for the program >> headers (phdr) as well. This would it make easier to understand the >> memory layout & the code below as well. >> >> I guess it looks like: >> >> … >> --------------- >> | sctn_hdr | >> --------------- >> | prog_hdr | >> --------------- >> … >> >> >> […snip] >> > > > They are already in there, have a look at the PT_* entries. I've left > them like this because I assumed that the original author wanted to make > a point by having them like this.
Makes sense - I mistakenly assumed that these were the actual segment contents. […snip]
