Re: [Qemu-devel] Bug#758881: [bisected] VNC server can't get all sent chars correctly

2014-08-25 Thread Marc
ld be non-zero? --  Marc

Re: [Qemu-devel] [Android-virt] [PATCH 00/12] Add support for Cortex-A15 and vexpress-a15

2012-01-27 Thread Marc Zyngier
On 17/01/12 19:08, Peter Maydell wrote: > On 15 January 2012 22:56, Christoffer Dall wrote: >> On Fri, Jan 13, 2012 at 3:57 PM, Peter Maydell >> wrote: >>> PPS: these patches are against qemu-master so for kvm you'd need >>> to (a) rebase them on qemu-linaro (b) put the kvm patches on top >>> of

Re: [Qemu-devel] [PATCH v2 08/10] target-xtensa: implement FP0 conversions

2012-09-09 Thread Marc Gauthier
description, without human intervention. > Looks like it's either documentation error or silicon error, probably > there's an erratum issued. Marc, can you please comment? If it's the Tensilica ISS, behavior indeed should match hardware, from a common description (am simplifying

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-17 Thread Marc Marí
El Tue, 16 Sep 2014 00:17:57 +0200 Marc Marí escribió: > > This means agressive timeout is not the problem. The problem is the > ISR not being raised at all after sending a read or write request. > > If this is the log of the failing case: > https://travis-ci.org/qemu/qe

Re: [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver

2014-10-03 Thread Marc Marí
El Thu, 2 Oct 2014 13:02:25 +0100 Stefan Hajnoczi escribió: > On Thu, Sep 04, 2014 at 06:24:37PM +0200, Marc Marí wrote: > > @@ -60,25 +60,25 @@ static void > > qvirtio_pci_assign_device(QVirtioDevice *d, void *data) *vpcidev = > > (QVirtioPCIDevice *)d; } >

Re: [Qemu-devel] [SeaBIOS] [RFC][PATCH 1/2] acpi: add ASL for Embedded Controller

2013-04-17 Thread Marc Jones
What EC is this for? The device and interface is defined by the spec, but the offsets and methods are custom for every EC. Marc On Wed, Apr 17, 2013 at 1:22 AM, liguang wrote: > defined at ACPI SPEC v5 chapter 12: > "ACPI Embedded Controller Interface Specification" &

[Qemu-devel] [RFC] Libqos virtio API

2014-06-17 Thread Marc Marí
This is the draft for the libqos virtio API to create test cases for virtio devices. I'm looking forward to your comments. Signed-off-by: Marc Marí --- tests/libqos/virtio.h | 148 + 1 file changed, 148 insertions(+) create mode 100644

[Qemu-devel] [RFC] Functions bus_foreach and device_find from libqos virtio API

2014-06-23 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos/virtio-pci.c | 123

Re: [Qemu-devel] [RFC] Functions bus_foreach and device_find from libqos virtio API

2014-06-24 Thread Marc Marí
gt; > +++ b/tests/virtio-blk-test.c > > @@ -2,6 +2,7 @@ > > * QTest testcase for VirtIO Block Device > > * > > * Copyright (c) 2014 SUSE LINUX Products GmbH > > + * Copyright (c) 2014 Marc Marí > > * > > * This work is licensed under th

Re: [Qemu-devel] [RFC] Functions bus_foreach and device_find from libqos virtio API

2014-06-24 Thread Marc Marí
Hello > > -/* Tests only initialization so far. TODO: Replace with functional > > tests */ -static void pci_nop(void) > > +#define TEST_IMAGE_SIZE (64 * 1024 * 1024) > > + > > +static char tmp_path[] = "/tmp/qtest.XX"; > > +extern QVirtioBus qvirtio_pci; > > + > > +static void pci_basic(void)

[Qemu-devel] [PATCH v4 00/11] Virtio PCI libqos driver

2014-08-12 Thread Marc Marí
Add functions for virtio PCI libqos driver. Add more debugging tools. Solve bugs found while generating tests. v3: Solved problems, added indirect descriptor support and test for configuration changes v4: Solved bugs, changed some interfaces, added MSI-X and event_idx support. Marc Marí (11

[Qemu-devel] [PATCH v4 03/11] libqtest: add QTEST_LOG for debugging qtest testcases

2014-08-12 Thread Marc Marí
Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí --- tests/libqtest.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 98e8f4b..fbd600d 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -167,11 +167,12

[Qemu-devel] [PATCH v4 01/11] tests: Functions bus_foreach and device_find from libqos virtio API

2014-08-12 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos/virtio-pci.c | 75

[Qemu-devel] [PATCH v4 10/11] libqos: Added MSI-X support

2014-08-12 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí --- tests/libqos/pci.c| 110 - tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c | 145

[Qemu-devel] [PATCH v4 05/11] libqos: Change free function called in malloc

2014-08-12 Thread Marc Marí
Reviewed-by: John Snow Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/libqos/malloc.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h index 46f6000..5565381 100644 --- a/tests/libqos/malloc.h +++ b/tests

[Qemu-devel] [PATCH v4 04/11] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc

2014-08-12 Thread Marc Marí
Reviewed-by: John Snow Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí --- tests/libqos/malloc-pc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c index db1496c..2efd095 100644 --- a

[Qemu-devel] [PATCH v4 02/11] tests: Add virtio device initialization

2014-08-12 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 57 + tests/libqos/virtio-pci.h | 18

[Qemu-devel] [PATCH v4 07/11] libqos: Added basic virtqueue support to virtio implementation

2014-08-12 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 91 ++- tests/libqos/virtio-pci.h |2 + tests/libqos/virtio.c | 100

[Qemu-devel] [PATCH v4 06/11] virtio-blk: Correct bug in support for flexible descriptor layout

2014-08-12 Thread Marc Marí
Without this correction, only a three descriptor layout is accepted, and requests with just two descriptors are not completed and no error message is displayed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- hw/block/virtio-blk.c | 14 +++--- 1 file changed, 7 insertions

[Qemu-devel] [PATCH v4 11/11] libqos: Added EVENT_IDX support

2014-08-12 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 26 +- tests/libqos/virtio.h |5 + tests/virtio-blk-test.c | 33

[Qemu-devel] [PATCH v4 09/11] libqos: Added test case for configuration changes in virtio-blk test

2014-08-12 Thread Marc Marí
Signed-off-by: Marc Marí --- tests/virtio-blk-test.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 06a9ac8..7269ade 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c @@ -225,13

[Qemu-devel] [PATCH v4 08/11] libqos: Added indirect descriptor support to virtio implementation

2014-08-12 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 10 tests/libqos/virtio.c | 63 tests/libqos/virtio.h | 22 - tests/virtio-blk-test.c

Re: [Qemu-devel] [PATCH v4 07/11] libqos: Added basic virtqueue support to virtio implementation

2014-08-13 Thread Marc Marí
El Wed, 13 Aug 2014 18:27:40 +0100 Stefan Hajnoczi escribió: > > +void qvring_init(const QGuestAllocator *alloc, QVirtQueue *vq, > > uint64_t addr) +{ > > +int i; > > + > > +vq->desc = addr; > > +vq->avail = vq->desc + vq->size*sizeof(QVRingDesc); > > +vq->used = (uint64_t)((vq->av

[Qemu-devel] [PATCH v5 0/7] Virtio PCI libqos driver

2014-08-18 Thread Marc Marí
v3: Solved problems, added indirect descriptor support and test for configuration changes v4: Solved bugs, changed some interfaces, added MSI-X and event_idx support. v5: Simplified virtio-blk-test, solved bugs, avoid patches already merged. Marc Marí (5): libqos: Added basic virtqueue

[Qemu-devel] [PATCH v5 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-08-18 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64 + tests/libqos/virtio.h | 22 +- tests/virtio-blk-test.c

[Qemu-devel] [PATCH v5 6/7] libqos: Added MSI-X support

2014-08-18 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí --- tests/libqos/pci.c| 111 +- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c | 142

[Qemu-devel] [PATCH v5 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-08-18 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos

[Qemu-devel] [PATCH v5 2/7] tests: Add virtio device initialization

2014-08-18 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 67 + tests/libqos/virtio-pci.h | 18

[Qemu-devel] [PATCH v5 7/7] libqos: Added EVENT_IDX support

2014-08-18 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 - tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 133

[Qemu-devel] [PATCH v5 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-08-18 Thread Marc Marí
Signed-off-by: Marc Marí --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c @@ -359,6

[Qemu-devel] [PATCH v5 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-08-18 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 82 + tests/libqos/virtio-pci.h |2 + tests/libqos/virtio.c | 100

Re: [Qemu-devel] [PATCH v5 6/7] libqos: Added MSI-X support

2014-08-18 Thread Marc Marí
>El Mon, 18 Aug 2014 14:46:11 +0200 >Marc Marí escribió: > +void qpci_msix_enable(QPCIDevice *dev) > +{ > +uint8_t addr; > +uint16_t val; > +uint32_t table; > +uint8_t bir_table; > +uint8_t bir_pba; > +void *offset; > + >

Re: [Qemu-devel] [PATCH v5 2/7] tests: Add virtio device initialization

2014-08-18 Thread Marc Marí
>El Mon, 18 Aug 2014 14:46:07 +0200 >Marc Marí escribió: > +void qvirtio_pci_device_enable(QVirtioPCIDevice *d) > +{ > +qpci_device_enable(d->pdev); > +d->addr = qpci_iomap(d->pdev, 0); > +g_assert(d->addr != NULL); > +} > + qpci_iomap changed i

[Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-20 Thread Marc Marí
qtest malloc is necessary and not one per machine, as it is implemented at the moment (malloc-pc uses fw_cfg). The actual output is this: http://pastebin.com/nHAH9Jie Which corresponds to this info mtree: http://pastebin.com/B5vw8DDf Signed-off-by: Marc Marí --- memory.c | 148

Re: [Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-20 Thread Marc Marí
El Wed, 20 Aug 2014 13:09:20 -0600 Eric Blake escribió: > On 08/20/2014 11:46 AM, Marc Marí wrote: > > Add command query-mtree to get the memory tree of the guest. > > > > As we were looking for a flexible solution on accessing the guest > > memory from qtests, S

Re: [Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-21 Thread Marc Marí
El Thu, 21 Aug 2014 11:06:51 +0200 Paolo Bonzini escribió: > Il 20/08/2014 19:46, Marc Marí ha scritto: > > Add command query-mtree to get the memory tree of the guest. > > > > As we were looking for a flexible solution on accessing the guest > > memory from qtests, S

[Qemu-devel] [PATCH v6 0/7] Virtio PCI libqos driver

2014-08-25 Thread Marc Marí
v3: Solved problems, added indirect descriptor support and test for configuration changes v4: Solved bugs, changed some interfaces, added MSI-X and event_idx support. v5: Simplified virtio-blk-test, solved bugs, avoid patches already merged. v6: Solve bugs (qpci_iomap changed prototype) Marc

[Qemu-devel] [PATCH v6 2/7] tests: Add virtio device initialization

2014-08-25 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 67 + tests/libqos/virtio-pci.h | 18

[Qemu-devel] [PATCH v6 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-08-25 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos

[Qemu-devel] [PATCH v6 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-08-25 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 82 + tests/libqos/virtio-pci.h |2 + tests/libqos/virtio.c | 100

[Qemu-devel] [PATCH v6 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-08-25 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64 + tests/libqos/virtio.h | 22 +- tests/virtio-blk-test.c

[Qemu-devel] [PATCH v6 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-08-25 Thread Marc Marí
Signed-off-by: Marc Marí --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c @@ -359,6

[Qemu-devel] [PATCH v6 7/7] libqos: Added EVENT_IDX support

2014-08-25 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 +- tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 124

[Qemu-devel] [PATCH v6 6/7] libqos: Added MSI-X support

2014-08-25 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí --- tests/libqos/pci.c| 111 +++- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c | 142

[Qemu-devel] [PATCH v7 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-08-29 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64 + tests/libqos/virtio.h | 22

[Qemu-devel] [PATCH v7 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-08-29 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 82 + tests/libqos/virtio-pci.h |2 + tests

[Qemu-devel] [PATCH v7 0/7] Virtio PCI libqos driver

2014-08-29 Thread Marc Marí
: Solve bugs (qvirtio_pci_config_readq endianness) Marc Marí (7): tests: Functions bus_foreach and device_find from libqos virtio API tests: Add virtio device initialization libqos: Added basic virtqueue support to virtio implementation libqos: Added indirect descriptor support to virtio

[Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 73 + tests/libqos/virtio-pci.h | 18

[Qemu-devel] [PATCH v7 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-08-29 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos

[Qemu-devel] [PATCH v7 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-08-29 Thread Marc Marí
Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754 100644 --- a/tests/virtio-blk-test.c +++ b/tests

[Qemu-devel] [PATCH v7 6/7] libqos: Added MSI-X support

2014-08-29 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí --- tests/libqos/pci.c| 111 +++- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c | 142

[Qemu-devel] [PATCH v7 7/7] libqos: Added EVENT_IDX support

2014-08-29 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 +- tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 124

Re: [Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-14 Thread Marc Zyngier
On 2013-08-14 09:16, Alexander Graf wrote: On 14.08.2013, at 10:11, Marc Zyngier wrote: On 2013-08-14 07:32, Alexander Graf wrote: On 13.08.2013, at 20:03, Peter Maydell wrote: These patches add support to target-arm for '-cpu host'. The general semantics are the same as for ppc a

Re: [Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-14 Thread Marc Zyngier
On 2013-08-14 07:32, Alexander Graf wrote: On 13.08.2013, at 20:03, Peter Maydell wrote: These patches add support to target-arm for '-cpu host'. The general semantics are the same as for ppc and x86 (ie "whatever the host kernel can support that looks basically like the host CPU"), but the mec

[Qemu-devel] [PATCH v2 04/16] highbank: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/xgmac.c | 10 ++ 1

[Qemu-devel] [PATCH v2 07/16] stellaris: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/stellaris_enet.c | 21

[Qemu-devel] [PATCH v2 15/16] pci-host: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/pci-host/bonito.c | 10

[Qemu-devel] [PATCH v2 08/16] tpm: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/tpm/tpm_passthrough.c |8

[Qemu-devel] [PATCH v2 06/16] spapr: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/spapr_llan.c |6 -- 1

[Qemu-devel] [PATCH v2 10/16] i8257: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/dma/i8257.c | 13

[Qemu-devel] [PATCH v2 13/16] isa: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/isa/vt82c686.c | 10

[Qemu-devel] [PATCH v2 16/16] common: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- include/qemu-common.h |7

[Qemu-devel] [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/i386/kvm/pci-assign.c |9

[Qemu-devel] [PATCH v2 11/16] rc4030: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/dma/rc4030.c | 11 +-- 1

[Qemu-devel] [PATCH v2 09/16] i82374: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/dma/i82374.c | 11 +-- 1

[Qemu-devel] [PATCH v2 14/16] lan9118: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/lan9118.c | 26

[Qemu-devel] [PATCH v2 12/16] sd: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/sd/sd.c |7 --- hw/sd

[Qemu-devel] [PATCH v2 03/16] scsi: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/scsi/lsi53c895a.c | 17

[Qemu-devel] [PATCH v2 00/16] Convert conditional compilation of debug printfs

2014-05-13 Thread Marc Marí
A macro has been added to qemu-common.h to simplify and standarize the debug printfs. Some of those printfs have been changed too. Marc Marí (16): x86: Convert conditional compilation of debug printfs to regular ifs s390: Convert conditional compilation of debug printfs to regular ifs scsi

[Qemu-devel] [PATCH v2 02/16] s390: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/s390x/s390-virtio-bus.c |8

[Qemu-devel] [PATCH v2 05/16] xilinx: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/cadence_gem.c | 11

Re: [Qemu-devel] [PATCH v2 15/16] pci-host: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
El Tue, 13 May 2014 09:02:51 +0200 Marc Marí escribió: > diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c > index c80b7cb..dfeb19e 100644 > --- a/hw/pci-host/ppce500.c > +++ b/hw/pci-host/ppce500.c > @@ -21,12 +21,16 @@ > #include "qemu/bswap.h" >

Re: [Qemu-devel] [PATCH v2 11/16] rc4030: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
El Tue, 13 May 2014 09:02:47 +0200 Marc Marí escribió: > hw/dma/rc4030.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c > index af26632..84f9f33 100644 > --- a/hw/dma/rc4030.c > +++ b/hw/dma/rc4030

Re: [Qemu-devel] [PATCH v2 09/16] i82374: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
El Tue, 13 May 2014 09:02:45 +0200 Marc Marí escribió: > hw/dma/i82374.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c > index b8ad2e6..7026f24 100644 > --- a/hw/dma/i82374.c > +++ b/hw/dma/i82374

Re: [Qemu-devel] [PATCH v2 08/16] tpm: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
El Tue, 13 May 2014 09:02:44 +0200 Marc Marí escribió: > diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c > index 6f0a4d2..302f2bf 100644 > --- a/hw/tpm/tpm_tis.c > +++ b/hw/tpm/tpm_tis.c > @@ -30,16 +30,16 @@ > #include "qemu-common.h" > #include "qemu/mai

Re: [Qemu-devel] [PATCH v2 05/16] xilinx: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
El Tue, 13 May 2014 09:02:41 +0200 Marc Marí escribió: > Modify debug macros to have the same format through the codebase and > use regular ifs instead of ifdef. > > As the debug printf is always put in code, some casting had to be > added to avoid warnings treated as errors

Re: [Qemu-devel] [PATCH v2 04/16] highbank: Convert conditional compilation of debug printfs to regular ifs

2014-05-13 Thread Marc Marí
El Tue, 13 May 2014 09:02:40 +0200 Marc Marí escribió: > Modify debug macros to have the same format through the codebase and > use regular ifs instead of ifdef. > > As the debug printf is always put in code, some casting had to be > added to avoid warnings treated as errors

Re: [Qemu-devel] [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs

2014-05-15 Thread Marc Marí
"pci_assign", __VA_ARGS__) > I found some problems to convert from ## __VA_ARGS__ to __VA_ARGS__ in some parts, and as I asked in IRC, it was pointed that "our HACKING document recommends the fmt, ## __VA_ARGS__ approach, and it obviously works on all the compilers we care about". So I will leave this as it is now. Marc

[Qemu-devel] [PATCH v3 00/16] Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Add QEMU_DPRINTF to substitute debug printfs and use the same format through the codebase. Marc Marí (16): include/qemu-common.h: Add QEMU_DPRINTF macro x86: Convert debug printfs to QEMU_DPRINTF s390: Convert debug printfs to QEMU_DPRINTF scsi: Convert debug printfs to QEMU_DPRINTF

[Qemu-devel] [PATCH v3 02/16] x86: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- hw/i386/kvm/pci-assign.c | 11 ++- hw/i386/multiboot.c |7 +-- target-i386/kvm.c|9 + xen-hvm.c|9

[Qemu-devel] [PATCH v3 10/16] i8257: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some formats had to be changed to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/dma/i8257.c | 14

[Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- hw/s390x/s390-virtio-bus.c |9 + hw/s390x/s390-virtio.c |9 + target-s390x/helper.c | 23 +++ target-s390x

[Qemu-devel] [PATCH v3 01/16] include/qemu-common.h: Add QEMU_DPRINTF macro

2014-05-17 Thread Marc Marí
Create this macro to let debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- include/qemu-common.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index 3f3fd60

[Qemu-devel] [PATCH v3 07/16] spapr: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí Acked-by: Alexander Graf --- hw/net/spapr_llan.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/net/spapr_llan.c b/hw/net

[Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- hw/sd/sd.c |8 +--- hw/sd/ssi-sd.c | 19 --- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c

[Qemu-devel] [PATCH v3 05/16] highbank: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Remove header and __func__ in debug printfs, to avoid duplicated messages. Signed-off-by: Marc Marí --- hw/net/xgmac.c | 27 +++ 1 file changed, 15 insertions(+), 12

[Qemu-devel] [PATCH v3 04/16] scsi: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some warnings appeared because of non-existing (old) variables, which were removed. Signed-off-by: Marc Marí --- hw/scsi/lsi53c895a.c | 22

[Qemu-devel] [PATCH v3 09/16] i82374: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the QEMU_DPRINTF already writes the function name, remove the __func__ to avoid writing the function name two times. Signed-off-by: Marc Marí --- hw/dma/i82374.c | 31

[Qemu-devel] [PATCH v3 08/16] stellaris: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- hw/net/stellaris_enet.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net

[Qemu-devel] [PATCH v3 06/16] xilinx: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As QEMU_DPRINTF adds a header to the message, when the message is not in a new line, printf has to be used. Signed-off-by: Marc Marí --- hw/net/cadence_gem.c | 24

[Qemu-devel] [PATCH v3 14/16] lan9118: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some formats had to be changed to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí --- hw/net/lan9118.c | 29

[Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some formats had to be changed to avoid warnings treated as errors at compile time.. Signed-off-by: Marc Marí --- hw/isa/vt82c686.c | 12

[Qemu-devel] [PATCH v3 16/16] common: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- migration-rdma.c | 31 +-- page_cache.c | 11 +++ 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a

[Qemu-devel] [PATCH v3 11/16] rc4030: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Change the output of debug messages from stdout to stderr. Remove header in debug printfs, as QEMU_DPRINTF already adds it. Signed-off-by: Marc Marí --- hw/dma/rc4030.c | 29

[Qemu-devel] [PATCH v3 15/16] pci-host: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
, __func__ was removed from debug printfs. Signed-off-by: Marc Marí --- hw/pci-host/bonito.c | 13 + hw/pci-host/ppce500.c | 21 + 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index 56292ad..814b6d8

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Marc Marí
El Sun, 18 May 2014 19:37:12 +1000 Peter Crosthwaite escribió: > On Sun, May 18, 2014 at 9:03 AM, Marc Marí > wrote: > > Modify debug macros to have the same format through the codebase > > and use regular ifs instead of ifdef. > > > > Signed-off-by: Marc Marí >

Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Marc Marí
El Mon, 19 May 2014 15:07:18 -0600 Eric Blake escribió: > On 05/17/2014 05:03 PM, Marc Marí wrote: > > Modify debug macros to have the same format through the codebase > > and use regular ifs instead of ifdef. > > > > As the debug printf is always put in code, some fo

[Qemu-devel] [GSoC] Presentation

2014-05-20 Thread Marc Marí
Hello everyone I'm Marc Marí (markmb in IRC), and I'm funded to work on virtio and I2C libqos device drivers for 12 weeks as a Google Summer of Code Student [1]. In particular, I'll create drivers for both PIIX4 (i440fx) and ICH9 (q35) SMBus, and the libqos virtio device inte

[Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-18 Thread Marc Marí
allocator parameters. As a result, only the allocator initalizer and unitializer are arch dependent. Signed-off-by: Marc Marí --- tests/Makefile |2 +- tests/libqos/malloc-pc.c | 280 +- tests/libqos/malloc-pc.h | 11 +- tests/libqos

Re: [Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-22 Thread Marc Marí
> > +void alloc_uninit(QGuestAllocator *allocator) > > +{ > > +MemBlock *node; > > +MemBlock *tmp; > > +QAllocOpts mask; > > + > > +/* Check for guest leaks, and destroy the list. */ > > +QTAILQ_FOREACH_SAFE(node, &allocator->used, MLIST_ENTNAME, > > tmp) { > > +if (allo

  1   2   3   4   5   6   7   8   9   10   >