Reviewed-by: Konstantin Kostiuk
On Sun, Nov 13, 2022 at 9:32 PM Philippe Mathieu-Daudé
wrote:
> On 12/11/22 12:40, Brad Smith wrote:
> > qga: Add initial OpenBSD and NetBSD support
> >
> > Signed-off-by: Brad Smith
> > ---
> > meson.build | 2
Reviewed-by: Konstantin Kostiuk
On Tue, Nov 15, 2022 at 8:46 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> In the next patch ZFS TRIM support for FreeBSD will be added. Move
> Linux-specific TRIM code to commands-linux.c file.
>
> Signed-off-by: Alexander Iv
Reviewed-by: Konstantin Kostiuk
On Tue, Nov 15, 2022 at 8:46 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> Use zpool tool for ZFS pools trimming in FreeBSD.
>
> Signed-off-by: Alexander Ivanov
> ---
> qga/co
Reviewed-by: Konstantin Kostiuk
Will merge this patch in QGA series
On Thu, Nov 10, 2022 at 12:06 PM Akihiko Odaki
wrote:
> GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
> defined by MinGW-w64. They are not only unnecessary, but can lead to
> duplicate definiti
Reviewed-by: Konstantin Kostiuk
On Sun, Nov 20, 2022 at 4:09 PM Kfir Manor wrote:
> Refactoring code to avoid duplication of creating an empty PCI address
> code.
>
> Signed-off-by: Kfir Manor
> ---
> qga/commands-win32.c | 20 +---
> 1 file changed
Reviewed-by: Konstantin Kostiuk
On Sun, Nov 20, 2022 at 4:01 PM Kfir Manor wrote:
> Skip getting PCI info from disks type USB and give them an empty PCI
> address instead.
>
> Signed-off-by: Kfir Manor
> ---
> qga/commands-win32.c | 12
> 1 file change
On Wed, Jul 27, 2022 at 10:47 AM Bin Meng wrote:
> From: Bin Meng
>
> Support for the unix socket has existed both in BSD and Linux for the
> longest time, but not on Windows. Since Windows 10 build 17063 [1],
> the native support for the unix socket has came to Windows. Starting
> this build, t
On Wed, Jul 27, 2022 at 10:36 AM Bin Meng wrote:
> From: Bin Meng
>
> Drop its own ga_get_win_version() implementation, and use the one
> provided in oslib-win32 instead.
>
> Signed-off-by: Bin Meng
> ---
>
> qga/commands-win32.c | 27 +--
> 1 file changed, 1 insertion(
Reviewed-by: Konstantin Kostiuk
On Wed, Jul 27, 2022 at 12:21 PM Thomas Huth wrote:
> Let's use better, more inclusive wording here.
>
> Signed-off-by: Thomas Huth
> ---
> qga/qapi-schema.json | 4 +--
> qga/guest-agent-core.h | 2 +-
> qga/commands-posix.c
Reviewed-by: Konstantin Kostiuk
On Wed, Jul 27, 2022 at 12:21 PM Thomas Huth wrote:
> Let's use better, more inclusive wording here.
>
> Signed-off-by: Thomas Huth
> ---
> tests/unit/test-qga.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
Reviewed-by: Konstantin Kostiuk
On Wed, Jul 27, 2022 at 12:29 PM Daniel P. Berrangé
wrote:
> On Wed, Jul 27, 2022 at 11:21:33AM +0200, Thomas Huth wrote:
> > Let's use a more appropriate wording for this command line and config
> > file option. The old ones ar
On Wed, Jul 27, 2022 at 2:58 PM Bin Meng wrote:
> On Wed, Jul 27, 2022 at 6:00 PM Daniel P. Berrangé
> wrote:
> >
> > On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote:
> > > On Wed, Jul 27, 2022 at 4:50 PM Yan Vugenfirer
> wrote:
> > > >
> > > > On Wed, Jul 27, 2022 at 10:43 AM Bin Meng
Best Regards,
Konstantin Kostiuk.
On Mon, Feb 26, 2024 at 7:02 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> Since the commit 25b5ff1a86 ("qga: add mountpoint usage info to
> GuestFilesystemInfo") we have 2 values reported in guest-get-fsinfo:
> u
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Documentation claims the command can "return NULL". "NULL" doesn't
> exist in JSON. "null" does, but the command returns lists, and null
> isn't
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> "Returns:" sections of guest-fsfreeze-freeze and
> guest-fsfreeze-freeze-list describe both command behavior and success
> response. Move behavior out, so "Returns:" is
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 22 ++
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/qga/qapi-sche
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Drop "on success" where it is redundant with "Returns:".
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 16
> 1 file
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 12
> 1 file changed, 12 deletions(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
For series
Reviewed-by: Konstantin Kostiuk
On Fri, Mar 1, 2024 at 7:29 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> v1 --> v2:
> * Replace commit for guest-get-fsinfo: instead of reporting statvfs(3)
>values directly, keep the old ones but add an a
ieu-Daudé
Message-ID: <20240222152835.72095-3-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 52 +---
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/qga/commands-win32.c b
From: Dehan Meng
Add support of Windows Server 2025 in get-osinfo command
Signed-off-by: Dehan Meng
Message-ID: <20240222152835.72095-4-phi...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32
From: Philippe Mathieu-Daudé
Most of the code base use the 'const' qualifier *before*
the type being qualified. Use the same style to unify.
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240222152835.72095-2-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Signed-of
Respin of Philippe's v3 to fix multidimensional array compilation error.
Supersedes: <20240222025437.58996-1-dem...@redhat.com>
Supersedes: <20240222152835.72095-1-phi...@linaro.org>
Dehan Meng (1):
qga-win: Add support of Windows Server 2025 in get-osinfo command
Philippe Mathieu-Daudé (2):
Reviewed-by: Konstantin Kostiuk
On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json |
Reviewed-by: Konstantin Kostiuk
On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json |
On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng wrote:
> Add support of Windows Server 2025 in get-osinfo command
>
> Signed-off-by: Dehan Meng
> ---
> qga/commands-win32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 697c65507c..f3c7e
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 22, 2024 at 5:28 PM Philippe Mathieu-Daudé
wrote:
> Most of the code base use the 'const' qualifier *before*
> the type being qualified. Use the same style to unify.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 22, 2024 at 5:28 PM Philippe Mathieu-Daudé
wrote:
> ga_get_win_name() iterates over all elements in the arrays by
> checking the 'version' field is non-NULL. Since the arrays are
> guarded by a NULL terminating element, we do
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 22, 2024 at 5:29 PM Philippe Mathieu-Daudé
wrote:
> From: Dehan Meng
>
> Add support of Windows Server 2025 in get-osinfo command
>
> Signed-off-by: Dehan Meng
> Message-ID: <20240222025352.58859-2-dem...@redhat.com>
&
’
as multidimensional array must have bounds for all dimensions except the
first
I think we can do the same as with Win10 and create 2 variables:
WIN_SERVER_VERSION_MATRIX and WIN_CLIENT_VERSION_MATRIX
If you want I can fix this by myself.
Best Regards,
Konstantin Kostiuk.
{
Reviewed-by: Konstantin Kostiuk
On Mon, Jan 29, 2024 at 1:50 PM Markus Armbruster wrote:
> Documentation of commands guest-ssh-get-authorized-keys,
> guest-ssh-add-authorized-keys, and guest-ssh-remove-authorized-keys
> describes the command's purpose after its arguments. E
Reviewed-by: Konstantin Kostiuk
On Mon, Jan 29, 2024 at 1:50 PM Markus Armbruster wrote:
> Documentation of type BlockdevOptionsIscsi describes the type's
> purpose after its members. Everywhere else, we do it the other way
> round. Move it for consistency.
>
> S
The following changes since commit 11be70677c70fdccd452a3233653949b79e97908:
Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into
staging (2024-01-29 10:53:56 +)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-2024-01-30
f
From: Samuel Tardieu
guest-exec invocation does not need the full path of the executable to
execute. Using only the command names ensures correct execution of the
test on systems not adhering to the FHS.
Signed-off-by: Samuel Tardieu
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Philippe
From: "Angel M. Villegas"
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1757
Updates to qga help output and documentation for --allow-rpcs and --blocks-rpcs
Signed-off-by: "Angel M. Villegas"
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
--
:
https://learn.microsoft.com/en-us/windows/win32/api/winioctl/ns-winioctl-volume_disk_extents
Signed-off-by: Peng Ji
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qga/commands-win32.c b/qga
From: Nick Briggs
Solaris has net/if_arp.h and netinet/if_ether.h rather than net/ethernet.h,
but does not define ETHER_ADDR_LEN, instead providing ETHERADDRL.
Signed-off-by: Nick Briggs
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 5 -
1
Hi Andrey,
I am ok with these changes.
No need new iteration with the version change, I will update before merging.
I will merge it after release.
Best Regards,
Konstantin Kostiuk.
On Mon, Apr 1, 2024 at 5:49 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> On 3/22
> create mode 100644 qga/commands-common-ssh.h
>
> Kostiantyn, if you take this patch, please amend the commit
> description and prefix the subject with 'qga: ' :)
>
I will do this.
Best Regards,
Konstantin Kostiuk.
> Thanks,
>
> Phil.
>
>
Hi Markus,
I will merge qga-related patches in my PULL.
Best Regards,
Konstantin Kostiuk.
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> We use doc comment "Returns" sections both for success and error
> response. This series moves the latter to new "Errors
From: Dehan Meng
Add support of Windows Server 2025 in get-osinfo command
Signed-off-by: Dehan Meng
Message-ID: <20240222152835.72095-4-phi...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
Link: https://lore.kernel
The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f:
Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging
(2024-03-09 20:12:21 +)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-2024-03-11-2
for
ieu-Daudé
Message-ID: <20240222152835.72095-3-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
Link: https://lore.kernel.org/r/20240304134532.28506-3-kkost...@redhat.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 48 +
From: Philippe Mathieu-Daudé
Most of the code base use the 'const' qualifier *before*
the type being qualified. Use the same style to unify.
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240222152835.72095-2-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Reviewed-by
On Tue, Mar 19, 2024 at 8:18 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
> ---
> qga/commands-posix-ssh.c | 47 +--
> qga/commands-ssh-core.c| 52 +++
> qga/commands-ssh-core.h| 20 ++
> qga/commands-windows-ssh.c | 686 +
> qga/meson
Hi Aidan,
Thank you for these patches. Currently, I don't have any comments.
I asked QE from my team to test this patch and wait for feedback.
Also, QEMU is in the code freeze stage now, so I plan to merge all QGA
patches after release.
Best Regards,
Konstantin Kostiuk.
On Tue, Apr 16,
proper
permissions
to make the SSH server happy.
[image: Screenshot_20240422_112242.png]
[image: Screenshot_20240422_112352.png]
Best Regards,
Konstantin Kostiuk.
On Fri, Mar 29, 2024 at 5:32 PM wrote:
> From: aidaleuc
>
> This patch aims to implement guest-ssh-add-authorized-ke
On Mon, Apr 22, 2024 at 9:25 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
> ---
> qga/commands-windows-ssh.c | 712 +
> qga/commands-windows-ssh.h | 26 ++
> qga/meson.build| 7 +-
> qga/qapi-schema.json | 17 +-
> 4 files cha
On Tue, Apr 23, 2024 at 6:02 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
>
Please resend with the real name in Signed-off-by
Assuming this changes:
Reviewed-by: Konstantin Kostiuk
> ---
> qga/commands-windows-ssh.c | 712 +++
On Tue, Apr 23, 2024 at 6:01 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
>
Please resend with the real name in Signed-off-by
Assuming this changes:
Reviewed-by: Konstantin Kostiuk
> ---
> qga/commands-common-ssh.c | 50 +
To series:
Reviewed-by: Konstantin Kostiuk
On Wed, Mar 20, 2024 at 6:17 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> v3 -> v4:
> * Patch 1/7:
> - Replaced "since 8.3" with "since 9.0" as we're now at v9.0.0-rc0;
>
Compilation QGA without system and user fails
./configure --disable-system --disable-user --enable-guest-agent
Fixes: 3a15604900c4f433c970cc6294520a98f201287e
Signed-off-by: Konstantin Kostiuk
---
stubs/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/stubs
On Fri, Apr 26, 2024 at 2:08 PM Philippe Mathieu-Daudé
wrote:
> On 25/4/24 13:04, Konstantin Kostiuk wrote:
> > Compilation QGA without system and user fails
> > ./configure --disable-system --disable-user --enable-guest-agent
>
> So this config isn't tested on CI.
&g
v1 -> v2:
- Added the link failure output
Konstantin Kostiuk (1):
stubs: Add missing qga stubs
stubs/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
--
2.44.0
Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Konstantin Kostiuk
---
stubs/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/stubs/meson.build b/stubs/meson.build
index 8ee1fd5753..3b9d42023c 100644
--- a/stubs/meson.build
+++ b/stubs/meson.b
Reviewed-by: Konstantin Kostiuk
On Fri, Apr 26, 2024 at 7:23 PM Thomas Huth wrote:
> According to the comment in qga/meson.build, the test got disabled
> since there were problems with the fuzzing job. But instead of
> disabling this test completely, we should still be fine running
Hi Paolo,
Are you ok if I merge this patch with other QGA patches?
Or don't you agree with this version of the patch?
Best Regards,
Konstantin Kostiuk.
On Fri, Apr 26, 2024 at 3:15 PM Konstantin Kostiuk
wrote:
> Compilation QGA without system and user fails
> ./configure --dis
-by: Aidan Leuck
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Dehan Meng
Reviewed-by: Konstantin Kostiuk
Link: https://lore.kernel.org/r/20240424144029.30665-2-aidan_le...@selinc.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-common-ssh.c | 50 +
From: Andrey Drobyshev
There's no need to check for the existence of the hook executable, as the
exec() call will do that for us.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158
rm one write to /sys/power/state.
Let's just use g_file_set_contents() to simplify things here.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.15
The following changes since commit 9c6c079bc6723da8061ccfb44361d67b1dd785dd:
Merge tag 'pull-target-arm-20240430' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-04-30
09:58:54 -0700)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/
-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-3-andrey.drobys...@virtuozzo.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 150 +++
1 file changed, 150 insertions(+)
diff --git a/qga/commands-posix.c b/qga/c
From: aidaleuc
Signed-off-by: Aidan Leuck
Tested-by: Dehan Meng
Reviewed-by: Konstantin Kostiuk
Link: https://lore.kernel.org/r/20240424144029.30665-3-aidan_le...@selinc.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-windows-ssh.c | 712 +
qga
From: Andrey Drobyshev
There's no need to check for the existence of "/sbin/hwclock", the
exec() call will do that for us.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-
represent f_blocks value as returned
by statvfs(3).
While here, also tweak the docs to reflect better where those values
come from.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-2-andr
From: Andrey Drobyshev
Also remove the G_GNUC_UNUSED attribute added in the previous commit from
the helper.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-4-andrey.drobys...@virtuozzo.com
From: Andrey Drobyshev
There's no need to check for the existence of the "chpasswd", "pw"
executables, as the exec() call will do that for us.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
Reviewed-by: Konstantin Kostiuk
On Thu, Jan 19, 2023 at 9:00 AM Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes.
>
> Sig
Hi Daniel,
I will merge this series after the 8.0 release.
Best Regards,
Konstantin Kostiuk.
On Fri, Mar 31, 2023 at 11:24 PM Daniel Xu wrote:
> Hi Daniel,
>
> On Thu, Mar 23, 2023, at 3:26 AM, Daniel P. Berrangé wrote:
> > On Wed, Mar 22, 2023 at 06:19:27PM -0600,
Reviewed-by: Konstantin Kostiuk
On Tue, Apr 4, 2023 at 2:59 PM Markus Armbruster wrote:
> Delete "error state indicates", because it doesn't make sense.
> I suspect it was an accident.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 2
Reviewed-by: Konstantin Kostiuk
On Sun, Jan 22, 2023 at 5:33 PM Kfir Manor wrote:
> ---
> qga/commands-posix.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index ebd33a643c..aab9d3bd50 100644
&g
Hi Kfir,
You missed adding the Signed-off-by line to the patch.
Please resend.
Best Regards,
Konstantin Kostiuk.
On Sun, Jan 22, 2023 at 5:33 PM Kfir Manor wrote:
> ---
> qga/commands-posix.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/c
Reviewed-by: Konstantin Kostiuk
On Mon, Jan 23, 2023 at 3:31 PM Kfir Manor wrote:
> Signed-off-by: Kfir Manor
> ---
> qga/commands-posix.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index e
ping
On Wed, Aug 24, 2022 at 5:37 PM Konstantin Kostiuk
wrote:
> Hi Michael and Paolo,
>
> I write to you as maintainers of mc146818rtc.c. I am working on bug
> https://bugzilla.redhat.com/show_bug.cgi?id=2054781
> and reproduced it on the current master branch.
>
> I add
On Fri, Jul 1, 2022 at 4:53 PM Marc-André Lureau
wrote:
> Hi
>
> On Fri, Jul 1, 2022 at 7:11 AM zhenwei pi wrote:
>
>> A vCPU thread always reaches 100% utilization when:
>> - guest uses idle=poll
>> - disable HLT vm-exit
>> - enable MWAIT
>>
>> Add new guest agent command 'guest-get-cpustats' t
Hi Michael,
You cherry-picked one of my patch qga/win32: Remove change action from MSI
installer
but it is part of the CVE fix.
Please cherry-pick one more patch.
Original mail:
https://patchew.org/QEMU/20230303192008.109549-1-kkost...@redhat.com/
Best Regards,
Konstantin Kostiuk.
On Thu
Reviewed-by: Konstantin Kostiuk
On Thu, May 4, 2023 at 11:19 AM Daniel P. Berrangé
wrote:
> On Thu, May 04, 2023 at 09:54:09AM +0200, Thomas Huth wrote:
> > All current versions of glib require _WIN32_WINNT set to 0x0601
> > or higher already, and we also use this value as a
Reviewed-by: Konstantin Kostiuk
On Thu, Apr 6, 2023 at 3:42 PM Mark Somerville wrote:
> Allow the Linux guest agent to attempt each of the suspend methods
> (systemctl, pm-* and writing to /sys) in turn.
>
> Prior to this guests without systemd failed to suspend due to
>
consumers can have a pristine
view of the original command output.
Signed-off-by: Daniel Xu
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Konstantin Kostiuk
---
qga/commands.c | 25 +++--
qga/qapi-schema.json | 5 -
2 files changed, 27 insertions(+), 3 deletions
From: Kfir Manor
Signed-off-by: Kfir Manor
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 079689d79a..97754930c1 100644
--- a
From: Daniel Xu
This commit adds a test to ensure `merged` functions as expected.
We also add a negative test to ensure we haven't regressed previous
functionality.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Daniel Xu
Signed-off-by: Konstantin Kostiuk
---
tests/unit/test-qga.c
From: Kostiantyn Kostiuk
The following changes since commit 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a:
Merge tag 'migration-20230428-pull-request' of
https://gitlab.com/juan.quintela/qemu into staging (2023-05-03 10:29:30 +0100)
are available in the Git repository at:
g...@github.com:kost
`.
Signed-off-by: Mark Somerville
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 97754930c1..def857d773 100644
--- a/qga/commands
.
Signed-off-by: Thomas Huth
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index b5fee6a2cd..d23875264f 100644
--- a/qga
an enum for capture mode
instead while preserving backwards compatibility.
Suggested-by: Daniel P. Berrangé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Daniel Xu
Signed-off-by: Konstantin Kostiuk
---
qga/commands.c | 37 ++---
qga/qapi-schema.json | 33
Thanks, Richard. It was ok to use git@ URL last time but not a problem to
fix.
Best Regards,
Konstantin Kostiuk.
On Thu, May 4, 2023 at 2:10 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 5/4/23 10:56, Konstantin Kostiuk wrote:
> > From: Kostiantyn Kostiuk
2023-03-08
Kfir Manor (3):
qga/win/installer: add VssOption to installer
qga/win/vss: query VSS backup type
qga/win/vss: requester_freeze changes
Konstantin Kostiuk (2):
qga/win32: Remove change action from MSI installer
qga/win32: Use rundll for VSS installa
behaviors or values return default VSS backup type VSS_BT_FULL instead
Signed-off-by: Kfir Manor
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/requester.cpp | 38 +
qga/vss-win32/vss-handles.h | 3 +++
2 files changed, 41
curity issue.
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423
fixes: CVE-2023-0664 (part 1 of 2)
Signed-off-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
Reported-by: Brian Wiltse
---
qga/installer/qemu-ga.wxs | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/installer/qemu-ga.w
From: Kfir Manor
Adds registry value VssOption with value 1 to QEMU Guest Agent VSS Provider
service registry key
Signed-off-by: Kfir Manor
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/installer/qemu-ga.wxs | 4
1 file changed, 4 insertions(+)
diff --git
COMRegister/COMUnregister functions with proper arguments.
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423
fixes: CVE-2023-0664 (part 2 of 2)
Signed-off-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
Reported-by: Brian Wiltse
---
qga/installer/qemu-ga.wxs | 10 +-
qga/vss
From: Kfir Manor
Change requester_freeze so that the VSS backup type queried from the registry
Signed-off-by: Kfir Manor
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/requester.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Hi Pierrick,
Thanks for reminding me. You are fully right to ping me. I really lost this
commit.
As QEMU is already at the code freeze stage, I don't want to push this into
8.0.
I hope it will be ok to merge after 8.0 was released.
Best Regards,
Konstantin Kostiuk.
On Tue, Mar 21, 2023
From: Kostiantyn Kostiuk
The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd:
Merge tag 'pull-riscv-to-apply-20230306' of
https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 +)
are available in the Git repository at:
g...@github.com:kostya
E_CONTROL_STOP, NULL))) {
^~
../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here
return hr;
^~
Signed-off-by: Pierrick Bouvier
Fixes: 917ebcb170 ("qga-win: Fix QGA VSS Provider service stop failure")
R
ping
On Tue, Sep 14, 2021 at 3:14 PM Kostiantyn Kostiuk
wrote:
> Windows Server 2016, 2019, 2022 are based on Windows 10 and
> have the same major and minor versions. So, the only way to
> detect the proper version is to use the build number.
>
> Before this commit, the guest agent use the last
Signed-off-by: Konstantin Kostiuk
On Thu, Feb 3, 2022 at 8:08 PM Paolo Bonzini wrote:
> From: Marc-André Lureau
>
> widl from mingw64-tools and wine can compile a TLB file.
>
> Signed-off-by: Marc-André Lureau
> Signed-off-by: Paolo Bonzini
> ---
> qga/v
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 8, 2022 at 1:14 PM Konstantin Kostiuk
wrote:
> Signed-off-by: Konstantin Kostiuk
>
> On Thu, Feb 3, 2022 at 8:14 PM Paolo Bonzini wrote:
>
>> From: Marc-André Lureau
>>
>> C++ presence is checked by the qga/ directory
Signed-off-by: Konstantin Kostiuk
On Thu, Feb 3, 2022 at 8:14 PM Paolo Bonzini wrote:
> From: Marc-André Lureau
>
> C++ presence is checked by the qga/ directory, so it can be assumed
> when building VSS module.
>
> Signed-off-by: Marc-André Lureau
> Signed-
Reviewed-by: Konstantin Kostiuk
On Fri, Feb 4, 2022 at 7:23 AM Philippe Mathieu-Daudé via <
qemu-devel@nongnu.org> wrote:
> On 3/2/22 18:33, Paolo Bonzini wrote:
> > From: Marc-André Lureau
> >
> > The glib_dynamic detection does not work because the dependency is
1 - 100 of 539 matches
Mail list logo
