Hi Daniel, I will merge this series after the 8.0 release.
Best Regards, Konstantin Kostiuk. On Fri, Mar 31, 2023 at 11:24 PM Daniel Xu <d...@dxuuu.xyz> wrote: > Hi Daniel, > > On Thu, Mar 23, 2023, at 3:26 AM, Daniel P. Berrangé wrote: > > On Wed, Mar 22, 2023 at 06:19:27PM -0600, Daniel Xu wrote: > >> Currently, any captured output (via `capture-output`) is segregated into > >> separate GuestExecStatus fields (`out-data` and `err-data`). This means > >> that downstream consumers have no way to reassemble the captured data > >> back into the original stream. > >> > >> This is relevant for chatty and semi-interactive (ie. read only) CLI > >> tools. Such tools may deliberately interleave stdout and stderr for > >> visual effect. If segregated, the output becomes harder to visually > >> understand. > >> > >> This commit adds a new enum variant to the GuestExecCaptureOutputMode > >> qapi to merge the output streams such that consumers can have a pristine > >> view of the original command output. > >> > >> Signed-off-by: Daniel Xu <d...@dxuuu.xyz> > >> --- > >> qga/commands.c | 25 +++++++++++++++++++++++-- > >> qga/qapi-schema.json | 5 ++++- > >> 2 files changed, 27 insertions(+), 3 deletions(-) > > > > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > > Is there anyone in particular I should CC to get this series merged? > > Thanks, > Daniel > >
