On Mon, Feb 18, 2013 at 05:57:02PM -0600, Anthony Liguori wrote:
> Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we
> don't allow arbitrary scaling based on window resizing. The current behavior
> with SDL causes a lot of problems for me.
>
> Sometimes I accidentally re
On Mon, Feb 18, 2013 at 06:03:32PM -0500, Jeff Cody wrote:
>
> Signed-off-by: Jeff Cody
> ---
> block/Makefile.objs | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index c067f38..a819577 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefi
On Mon, Feb 18, 2013 at 05:56:59PM -0600, Anthony Liguori wrote:
> This is minimalistic and just contains the basic widget infrastructure. The
> GUI
> consists of a menu and a GtkNotebook. To start with, the notebook has its
> tabs
> hidden which provides a UI that looks very similar to SDL wit
On Tue, Feb 19, 2013 at 08:26:35AM -0500, Jeff Cody wrote:
> On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote:
> > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote:
> > > +#include "qemu/crc32c.h"
> > > +#include "block/vhdx.h"
> > > +
> > > +#define vhdx_nop(x) do { (void)(
On Tue, Feb 19, 2013 at 10:04:07AM -0500, Jeff Cody wrote:
> On Tue, Feb 19, 2013 at 03:30:10PM +0100, Kevin Wolf wrote:
> > The whole point of packed structs is to enable the unaligned data
> > access, so yes, you're right with that. But in my opinion declaring the
> >
On Tue, Feb 19, 2013 at 08:11:48AM -0500, Jeff Cody wrote:
> On Tue, Feb 19, 2013 at 10:02:51AM +0100, Stefan Hajnoczi wrote:
> > On Mon, Feb 18, 2013 at 06:03:30PM -0500, Jeff Cody wrote:
> > > +/* the guid is a 16 byte unique ID - the definition for this used by
> > > + * Microsoft is not just 16
On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote:
> This is preliminary and beta support for the VHDX image format,
> as specified in:
>"VHDX Format Specification v0.95", published 4/12/2012
> https://www.microsoft.com/en-us/download/details.aspx?id=29681
>
> This RFC patch has th
On Tue, Feb 19, 2013 at 10:10:18AM -0600, Anthony Liguori wrote:
> Kevin Wolf writes:
>
> > On Mon, Feb 18, 2013 at 05:57:02PM -0600, Anthony Liguori wrote:
> >> Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we
> >> don't allo
On Tue, Feb 19, 2013 at 11:59:09AM +0100, Paolo Bonzini wrote:
> The coroutine pool code is duplicated between the ucontext and
> sigaltstack backends, and absent from the win32 backend. But the
> code can be shared easily by moving it to qemu-coroutine.c.
>
> Signed-off-by: Paolo Bonzini
Thank
On Tue, Feb 19, 2013 at 04:45:03PM +0100, Stefan Hajnoczi wrote:
> It is not completely clear to me what is being flushed in
> qcow2_alloc_bytes() but bdrv_flush(bs->file) is probably wrong. At
> least the refcount cache should be flushed since this function calls
> update_cluster_refcount().
>
>
On Tue, Feb 19, 2013 at 04:45:00PM +0100, Stefan Hajnoczi wrote:
> Users have reported that qcow2 internal snapshot creation is slow. I filed a
> bug report at https://bugs.launchpad.net/qemu/+bug/1126369.
>
> This patch series reduces the time for qcow2 internal snapshot creation
> significantly
On Wed, Feb 20, 2013 at 09:01:16AM +0100, Markus Armbruster wrote:
> Dietmar Maurer writes:
>
> >> > * Backup to a single archive file
> >> > * Backup contain all data to restore VM (full backup)
> >> > * Do not depend on storage type or image format
> >> > * Avoid use of temporary storage
> >> >
On Wed, Feb 20, 2013 at 11:47:56AM +0100, Tiziano Müller wrote:
> Hi everyone
>
> According to http://wiki.qemu.org/Migration/Storage section "Image
> Formats" qemu can't do live migration without data corruption when using
> qcow2 or qed due to the metadata caches.
> Wasn't that fixed by commit 0
On Mon, Feb 18, 2013 at 05:56:57PM -0600, Anthony Liguori wrote:
> GTK won't build with strict-prototypes due to gtkitemfactory.h:
>
> /* We use () here to mean unspecified arguments. This is deprecated
> * as of C99, but we can't change it without breaking compatibility.
> * (Note t
On Wed, Feb 20, 2013 at 02:14:47PM +0100, Tiziano Müller wrote:
> Am Mittwoch, den 20.02.2013, 12:20 +0100 schrieb Kevin Wolf:
> > On Wed, Feb 20, 2013 at 11:47:56AM +0100, Tiziano Müller wrote:
> > > Hi everyone
> > >
> > > According to http://wiki.qemu.
On Fri, Feb 08, 2013 at 02:06:14PM +0100, Paolo Bonzini wrote:
> Because discard is now a host parameter, we can always fake it as enabled
> in the guest. This is an extension of the current choice to ignore
> "not supported" errors from the host when discard_granularity is set
> to nonzero.
>
>
On Wed, Feb 20, 2013 at 03:50:11PM +0100, Laszlo Ersek wrote:
> On 02/20/13 12:31, Kevin Wolf wrote:
> > On Mon, Feb 18, 2013 at 05:56:57PM -0600, Anthony Liguori wrote:
> >> GTK won't build with strict-prototypes due to gtkitemfactory.h:
> >>
> >>
On Mon, Feb 18, 2013 at 01:49:43PM +0100, Paolo Bonzini wrote:
> Il 18/02/2013 13:48, Peter Lieven ha scritto:
> > bdrv_truncate() invalidates the bdrv_check_request() result for
> > in-flight requests, so there should better be none.
> >
> > Signed-off-by: Peter Lie
On Wed, Feb 20, 2013 at 04:33:50PM +0100, Laszlo Ersek wrote:
> On 02/20/13 15:57, Kevin Wolf wrote:
> > On Wed, Feb 20, 2013 at 03:50:11PM +0100, Laszlo Ersek wrote:
> >> On 02/20/13 12:31, Kevin Wolf wrote:
> >>> On Mon, Feb 18, 2013 at 05:56:57PM -0600, Anthony L
On Fri, Feb 08, 2013 at 02:06:13PM +0100, Paolo Bonzini wrote:
> Similar to --cache and --aio, this option mimics the discard suboption
> of "-drive".
>
> Signed-off-by: Paolo Bonzini
> ---
> qemu-nbd.c| 18 +++---
> qemu-nbd.texi | 4
> 2 files changed, 19 insertions(+), 3
On Wed, Feb 20, 2013 at 06:26:55PM +0100, Andreas Färber wrote:
> Am 20.02.2013 18:05, schrieb Anthony Liguori:
> > Andreas Färber writes:
> >
> >> Am 20.02.2013 14:43, schrieb Anthony Liguori:
> >>> This includes a de_DE translation from Kevin Wolf and an it
On Thu, Feb 21, 2013 at 09:48:56AM +0100, Stefan Hajnoczi wrote:
> On Wed, Feb 20, 2013 at 03:09:51PM +0100, Paolo Bonzini wrote:
> > Il 13/02/2013 11:39, Stefan Hajnoczi ha scritto:
> > >> > .type = QEMU_OPT_STRING,
> > >> > .help = "disk image",
> > >> > },{
> >
On Mon, Feb 18, 2013 at 04:42:55PM +0100, Stefan Hajnoczi wrote:
> On Wed, Feb 13, 2013 at 02:22:09PM +0100, Kevin Wolf wrote:
> > diff --git a/block/qcow2.c b/block/qcow2.c
> > index 57552aa..2819336 100644
> > --- a/block/qcow2.c
> > +++ b/block/qcow2.c
> >
On Mon, Feb 18, 2013 at 04:46:49PM +0100, Stefan Hajnoczi wrote:
> On Wed, Feb 13, 2013 at 02:22:10PM +0100, Kevin Wolf wrote:
> > @@ -707,6 +710,16 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs,
> > QCowL2Meta *m)
> > }
> >
On Thu, Feb 21, 2013 at 10:35:42AM +0100, Kevin Wolf wrote:
> On Mon, Feb 18, 2013 at 04:42:55PM +0100, Stefan Hajnoczi wrote:
> > On Wed, Feb 13, 2013 at 02:22:09PM +0100, Kevin Wolf wrote:
> > > diff --git a/block/qcow2.c b/block/qcow2.c
> > > index 57552aa..28193
On Fri, Dec 14, 2012 at 05:44:37PM -0700, Keith Busch wrote:
> NVM Express is an open standard for PCI-e attached Non-Volatile Memory
> storage. This commit adds an emulated device that supports the register
> interface and command set defined by this standard. The standard can be
> viewed at nvmex
On Thu, Feb 21, 2013 at 08:20:28AM +, Dietmar Maurer wrote:
> Honestly, 64k*4G = 128T is not a limit for me. And we still have one byte
> reserved,
> so we can have up to 1P per image, and up to 253 images.
>
> For now I have no plans to backup such large VMs.
640k ought to be enough for any
On Thu, Feb 21, 2013 at 06:53:24AM +, Dietmar Maurer wrote:
> > How would VMA fit in if the backup block job took a BlockDriverState
> > destination and vmsave worked atomically with backup block jobs? You could
> > have QEMU write to NBD server ports that a VMA writer process has open.
> > VM
On Wed, Feb 20, 2013 at 04:04:49PM +, Dietmar Maurer wrote:
> > The backup writer abstraction is a special case interface somewhere
> > between an image format and live migration. I'd prefer it if the backup
> > block job stuck to BlockDriverState as the destination for backup data.
> > Then y
On Thu, Feb 21, 2013 at 12:02:18PM +, Dietmar Maurer wrote:
> > The problem is about cache coherency. Local files work just fine with
> > cache=writeback, but if you migrate to a different host, you get the problem
> > that the destination kernel may cache some parts of the image while the
> >
Am 22.02.2013 um 11:31 hat Stefan Hajnoczi geschrieben:
> On Thu, Feb 21, 2013 at 03:56:15PM +, Dietmar Maurer wrote:
> > > On Wed, Feb 20, 2013 at 04:04:49PM +, Dietmar Maurer wrote:
> > > > > The backup writer abstraction is a special case interface somewhere
> > > > > between an image fo
Am 22.02.2013 um 08:51 hat Peter Lieven geschrieben:
> is there any project or plans to integrate a readcache in qemu either for
> iscsi or for the whole block layer?
>
> I was thinking of 2 options:
> a) assign (up to) a fixed amount of ram for readcaching of a VMs disk I/O.
> Without SG_IO thi
Am 21.02.2013 um 18:05 hat Paolo Bonzini geschrieben:
> Il 21/02/2013 17:33, Stefan Hajnoczi ha scritto:
> > * BlockDriverState <-> AioContext
> >
> >It probably makes sense to bind a BlockDriverState to an AioContext
> >in which its file descriptors and aio activity happens.
>
> ... and
Am 22.02.2013 um 12:21 hat Dietmar Maurer geschrieben:
> > > For now I have no plans to backup such large VMs.
> >
> > 640k ought to be enough for anybody?
> >
> > Code is easy enough to change that "works for now" can be good enough.
> > Changing file formats and external interfaces is hard, tho
Am 22.02.2013 um 14:11 hat Dietmar Maurer geschrieben:
> > > We currently only need 8 bytes per cluster, which results in small files.
> >
> > So how big is the metadata overhead? If you always copy 64k at once (which
> > is a
> > very conservative assumption - at least for the background copy yo
Am 22.02.2013 um 15:31 hat Dietmar Maurer geschrieben:
> > > Honestly, 64k*4G = 128T is not a limit for me. And we still have one
> > > byte reserved, so we can have up to 1P per image, and up to 253 images.
> > >
> > > For now I have no plans to backup such large VMs.
> >
> > 640k ought to be eno
Am 22.02.2013 um 14:57 hat Dietmar Maurer geschrieben:
> > And it would only be needed if VMAs support backing files, because for
> > normal
> > sparse blocks, I don't even see any reason why the VMA should contain any
> > information about them. They are never written to, so they are by definitio
Am 22.02.2013 um 14:52 hat Dietmar Maurer geschrieben:
> > > For example, if you backup a file which mostly contains empty blocks,
> > > you will duplicate the size of the resulting file!
> >
> > If describing an empty image takes more than a couple of bytes, you're doing
> > something seriously w
One part of this patch reverts commit 22bc9a46, which disabled the
warning. The rest of it deals with the warning by adding a #pragma for
newer gcc and by disabling -Werror for compilers that can't deal with
the #pragma.
Signed-off-by: Kevin Wolf
---
configure | 19 +--
ui/
Am 22.02.2013 um 21:33 hat Stefan Weil geschrieben:
> Am 22.02.2013 21:08, schrieb Kevin Wolf:
> > One part of this patch reverts commit 22bc9a46, which disabled the
> > warning. The rest of it deals with the warning by adding a #pragma for
> > newer gcc and by disabling -Werr
Kevin Wolf (1):
qemu-iotests: Test qcow2 image creation options
Miroslav Rezanina (4):
block: Add synchronous wrapper for bdrv_co_is_allocated_above
qemu-img: Add "Quiet mode" option
qemu-img: Add compare subcommand
qemu-iotests: Add qemu-img compare t
From: Stefan Hajnoczi
The qemu-img check fragmentation printf() is missing a space before the
'=' sign. The human output is not guaranteed to be stable and we are
not aware of screen scrapers, so add the missing space.
Also fix the missing indentation of the printf() arguments.
Signed-off-by:
From: Miroslav Rezanina
There's no synchronous wrapper for bdrv_co_is_allocated_above function
so it's not possible to check for sector allocation in an image with
a backing file.
Signed-off-by: Miroslav Rezanina
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
--
From: Stefan Hajnoczi
Show how many clusters are compressed. This can be used to monitor how
many compressed clusters remain and whether to recompress the image.
Suggested-by: Cole Robinson
Signed-off-by: Stefan Hajnoczi
---
include/block/block.h| 1 +
qapi-schema.json |
ical block size or 4k, whichever
is largest, because cluster sizes below 4k are rarely used and 4K is a
typical block size for files.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
hw/block-common.h | 2 +-
hw/ide/qdev.c | 5 -
hw/scsi-disk.c| 13 ++---
3 files c
From: Stefan Hajnoczi
Negative I/O throttling iops and bps values do not make sense so reject
them with an error message.
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
blockdev.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index
From: Miroslav Rezanina
Simple test for qemu-img compare to check it's working correctly.
Signed-off-by: Miroslav Rezanina
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/048 | 78 ++
tests/qemu-iotests/04
es, though there is a disadvantage: if
the guest is buggy and issues discards for data that is in use, there
will be no way to migrate storage for that guest without downgrading
the machine type to an older one.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c
Just create lots of images and try out each of the creation options that
qcow2 provides (except backing_file/fmt for now)
I'm not totally happy with the behaviour of qemu-img in each of the
cases, but let's be explicit and update the test when we do change
things later.
Signed-off-by:
From: Paolo Bonzini
Add support for BDRV_O_UNMAP from the QEMU command-line.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
blockdev.c | 11 +++
qemu-options.hx | 2 ++
2 files changed, 13 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index b307ed9..0e67d06
From: Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi
---
block/qcow2-refcount.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 771b7b2..55543ed 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -968,6 +968,7 @@ static
ror
messages to do_check_io_limits(). The next patch adds a new check.
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
blockdev.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 63e6f1e..9b03513 100644
--- a/blockdev.c
+++ b/block
n Hajnoczi
Signed-off-by: Kevin Wolf
---
tests/test-coroutine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-coroutine.c b/tests/test-coroutine.c
index 4c6cc81..39be046 100644
--- a/tests/test-coroutine.c
+++ b/tests/test-coroutine.c
@@ -183,7 +183,7 @@ static void pe
From: Paolo Bonzini
Similar to --cache and --aio, this option mimics the discard suboption
of "-drive".
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
qemu-nbd.c| 18 +++---
qemu-nbd.texi | 4
2 files changed, 19 insertions(+), 3 deletions(-)
di
From: Peter Lieven
bdrv_truncate() invalidates the bdrv_check_request() result for
in-flight requests, so there should better be none.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
Reported-by: Kevin Wolf
Reviewed-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c | 4
1
From: Stefan Hajnoczi
The qemu-img check command can display fragmentation statistics:
* Total number of clusters in virtual disk
* Number of allocated clusters
* Number of fragmented clusters
This patch adds fragmentation statistics support to qcow2.
Compressed and normal clusters count as
From: Miroslav Rezanina
This patch adds new qemu-img subcommand that compares content of two disk
images.
Signed-off-by: Miroslav Rezanina
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
qemu-img-cmds.hx | 6 ++
qemu-img.c | 290
From: Miroslav Rezanina
There can be a need to turn output to stdout off. This patch adds a -q option
that enable "Quiet mode". In Quiet mode, only errors are printed out.
Signed-off-by: Miroslav Rezanina
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
block.c
From: Paolo Bonzini
The coroutine pool code is duplicated between the ucontext and
sigaltstack backends, and absent from the win32 backend. But the
code can be shared easily by moving it to qemu-coroutine.c.
Signed-off-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
Simoncelli
Signed-off-by: Kevin Wolf
---
block/qcow2-refcount.c | 10 --
include/block/block.h| 1 +
qemu-img.c | 4
tests/qemu-iotests/026 | 6 +++---
tests/qemu-iotests/036 | 3 ++-
tests/qemu-iotests/039 | 2 +-
tests/qemu-iotests
From: Stefan Hajnoczi
The check_refcounts_l1/l2() functions have a check_copied argument to
check that the QCOW_O_COPIED flag is consistent with refcount == 1.
This should be a bool, not an int.
However, the next patch introduces qcow2 fragmentation statistics and
also needs to pass an option to
From: Paolo Bonzini
Adds both pc-i440fx-1.4 and pc-q35-1.4.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
hw/pc.h | 31 +++
hw/pc_piix.c | 18 --
hw/pc_q35.c | 19 ---
3 files changed, 63 insertions(+), 5
From: Federico Simoncelli
This option --output=[human|json] makes qemu-img check output a human
or JSON representation at the choice of the user.
Signed-off-by: Federico Simoncelli
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
qapi-schema.json | 46 +++
qemu-img-cmds.hx
Am 25.02.2013 um 16:01 hat Markus Armbruster geschrieben:
> >> The behaviour then would be nop on no medium during commit all. But if
> >> you specifically tried to just run commit() on a single device that
> >> had no medium, you would receive ENOMEDIUM. That seems logical to me.
> >
> > I think,
' now means a commit on all COW drives.
>
> This means an individual commit to a specific non-COW drive will still
> return the appropriate error (-ENOMEDIUM if eject / not present, -ENOTSUP
> if no backing file).
>
> Reported-by: Jan Kiszka
> Signed-off-by: Jeff Cody
Reviewed-by: Kevin Wolf
Am 25.02.2013 um 16:12 hat Eric Blake geschrieben:
> On 02/24/2013 11:37 PM, Dietmar Maurer wrote:
> > I tried to do that, but it seems that gcc does not support sizeof in
> > preprocessor conditionals,
> > so I added a runtime check in vma_writer_create().
>
> Then you've never written a compile
Am 27.02.2013 um 10:48 hat Paolo Bonzini geschrieben:
> Finally, and unrelated to the code above, we usually do not add new "if"
> values. It's enough to have access via if=none & -device. In any case
> it should be a separate patch, so it's easy to drop it if that's the
> decision.
-device is a
Am 27.02.2013 um 10:49 hat Paolo Bonzini geschrieben:
> Il 27/02/2013 01:47, Keith Busch ha scritto:
> > Adds logging at various levels of detail throughout the code so that
> > a developer may see what is occuring within a device interacting with
> > their nvme drivers and utilities.
>
> Please u
Am 26.02.2013 um 18:14 hat Benoît Canet geschrieben:
>
> Hello Kevin,
>
> As you are best person to discuss QCOW2 implementations issues with I am
> writing
> this mail so you can know what has been done on deduplication and what I am
> planning to do next.
>
> In short I need your feedback bef
Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:
> Wenchao Xia writes:
>
> > Signed-off-by: Wenchao Xia
> > Reviewed-by: Eric Blake
> > ---
> > block.c | 24
> > include/block/block.h |2 ++
> > savevm.c | 22
Am 27.02.2013 um 16:58 hat Benoît Canet geschrieben:
> > > The current prototype of the QCOW2 deduplication uses 32 bytes SHA256 or
> > > SKEIN
> > > hashes to identify each 4KB clusters with a very low probability of
> > > collisions.
> >
> > How do you handle the rare collision cases? Do you r
Signed-off-by: Kevin Wolf
---
include/qapi/qmp/qdict.h | 2 ++
qobject/qdict.c | 22 ++
2 files changed, 24 insertions(+)
diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
index 6d9a4be..685b2e3 100644
--- a/include/qapi/qmp/qdict.h
+++ b/include
It doesn't do anything yet except storing the options QDict in the
BlockDriverState.
Signed-off-by: Kevin Wolf
---
block.c | 38 +-
block/blkverify.c | 2 +-
block/qcow2.c | 2 +-
block/vmdk.c
Signed-off-by: Kevin Wolf
---
block.c | 4 ++--
block/bochs.c | 2 +-
block/cloop.c | 2 +-
block/cow.c | 2 +-
block/dmg.c | 2 +-
block/parallels.c | 2 +-
block/qcow.c | 2 +-
block/qcow2.c
definitely has to go away) and possibly allow
specifying options for backing files or the protocol as well with a syntax like
"backing.lazy_refcounts=on". If all options starts using this, maybe even
something like "backing.cache=writeback" could be made to work.
Kevin Wolf (6):
The options are passed down to the block drivers, which are supposed to
remove all options they have processed. Anything that is left over in
the end is an unknown option and results in an error.
Signed-off-by: Kevin Wolf
---
block.c | 33 +++--
1 file changed, 27
qcow2 images now accept a boolean lazy_refcouns options. Use it like
this:
-drive file=test.qcow2,lazy_refcounts=on
If the option is specified on the comman line, it overrides the default
specified by the qcow2 header flags that were set when creating the
image.
Signed-off-by: Kevin Wolf
Any non-default -drive options are now passed down to the block drivers.
Signed-off-by: Kevin Wolf
---
blockdev.c | 55 +++
1 file changed, 51 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index f13f829..d6680a1 100644
Am 20.09.2012 08:30, schrieb Bharata B Rao:
> On Tue, Sep 18, 2012 at 04:08:43PM +0200, Kevin Wolf wrote:
>> Am 18.09.2012 15:31, schrieb Paolo Bonzini:
>>> Il 18/09/2012 15:22, Kevin Wolf ha scritto:
>>>> Am 17.09.2012 17:23, schrieb Bharata B Rao:
>>>&g
Am 19.09.2012 20:47, schrieb Blue Swirl:
> On Tue, Sep 18, 2012 at 11:40 AM, Kevin Wolf wrote:
>> Signed-off-by: Kevin Wolf
>> ---
>> block/qcow2-cluster.c | 29 +
>> block/qcow2.c | 31 ---
>&
Am 13.08.2012 09:54, schrieb Kevin Wolf:
> Am 12.08.2012 04:48, schrieb Kevin Shanahan:
>> So qmp_change_blockdev uses bdrv_is_read_only() to check whether to
>> try and open the backing file read only, which uses the ->read_only
>> member of struct BlockDriverState to de
Am 20.09.2012 11:12, schrieb Bharata B Rao:
> On Thu, Sep 20, 2012 at 10:20:33AM +0200, Paolo Bonzini wrote:
>> Il 20/09/2012 09:53, Paolo Bonzini ha scritto:
>> Would look a bit nicer with strstart() form cutils.c instead of
>> strncmp().
> strstart() works with const char pointers, b
Am 18.09.2012 20:53, schrieb Jeff Cody:
> This is based on Supriya Kannery's bdrv_reopen() patch series.
>
> This provides a transactional method to reopen multiple
> images files safely.
>
> Image files are queue for reopen via bdrv_reopen_queue(), and the
> reopen occurs when bdrv_reopen_multip
Am 18.09.2012 20:53, schrieb Jeff Cody:
> Move AIO initialization for raw-posix block driver into a helper function.
>
> In addition to just code motion, the aio_ctx pointer is checked for NULL,
> prior to calling laio_init(), to make sure laio_init() is only run once.
>
> Signed-off-by: Jeff Cod
Am 18.09.2012 20:53, schrieb Jeff Cody:
> This is derived from the Supriya Kannery's reopen patches.
>
> This contains the raw-posix driver changes for the bdrv_reopen_*
> functions. All changes are staged into a temporary scratch buffer
> during the prepare() stage, and copied over to the live s
Am 18.09.2012 20:53, schrieb Jeff Cody:
> This patch supports reopen for VMDK image files. VMDK extents are added
> to the existing reopen queue, so that the transactional model of reopen
> is maintained with multiple image files.
>
> Signed-off-by: Jeff Cody
> ---
> block/vmdk.c | 35 +
Am 21.09.2012 01:20, schrieb Kevin Shanahan:
> If readonly=on is given at device creation time, the ->readonly flag
> needs to be set in the block driver state for this device so that
> readonly-ness is preserved across media changes (qmp change command).
> Similarly, to preserve the snapshot prope
Am 20.09.2012 21:13, schrieb Jeff Cody:
> This is the support for reopen, for win32. Note that there is a key
> difference in the win32 reopen, namely that it is not guaranteed safe
> like all the other drivers. Attempts are made to reopen the file, or
> open the file in a new handle prior to clo
Am 20.09.2012 21:13, schrieb Jeff Cody:
> Move AIO initialization for raw-posix block driver into a helper function.
>
> In addition to just code motion, the aio_ctx pointer is checked for NULL,
> prior to calling laio_init(), to make sure laio_init() is only run once.
>
> Signed-off-by: Jeff Cod
Am 20.09.2012 21:13, schrieb Jeff Cody:
> These patches are based off Supriya Kannery's original bdrv_reopen()
> patches as part of the hostcache series.
>
> This provides support for safe reopen of a single image, or transactional
> reopening of multiple images atomically.
>
> These changes are
Am 20.09.2012 23:00, schrieb Eduardo Otubo:
> Seccomp syscall whitelist updated after tests running qemu under
> libvirt. Reference to the bug -
> https://bugzilla.redhat.com/show_bug.cgi?id=855162
>
> Regards,
> ---
> qemu-seccomp.c | 21 -
> 1 file changed, 20 insertions(+),
Am 22.09.2012 20:53, schrieb Stefan Weil:
> Am 22.09.2012 18:29, schrieb Stefan Hajnoczi:
>> On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote:
> [snip]
>>> offset_end = (offset_end + 511) >> 9;
>>> -bdrv_write(pfl->bs, offset, pfl->storage + (offset << 9),
>>> -
Am 24.09.2012 10:41, schrieb Markus Armbruster:
> Kevin Wolf writes:
>
>> Am 22.09.2012 20:53, schrieb Stefan Weil:
>>> Am 22.09.2012 18:29, schrieb Stefan Hajnoczi:
>>>> On Wed, Sep 19, 2012 at 06:41:14PM +0200, Stefan Weil wrote:
>>> [snip]
>>&g
Am 24.09.2012 13:32, schrieb ching:
> Hi all,
>
> My host is qemu-1.1.1 and x64 kernel 3.5.4. The guest is using aio="native"
>
> I am trying to use unsafe cache mode to boost i/o performance.
aio=native requires the image to be opened with O_DIRECT, i.e.
cache=none or cache=directsync. If you s
From: Jeff Cody
These are the stubs for the file reopen drivers for the qcow format.
There is currently nothing that needs to be done by the qcow driver
in reopen.
Signed-off-by: Jeff Cody
Signed-off-by: Kevin Wolf
---
block/qcow.c | 10 ++
1 files changed, 10 insertions(+), 0
From: Jeff Cody
Block drivers should ignore BDRV_O_CACHE_WB in .bdrv_open flags,
and in the bs->open_flags.
This patch removes the code, leaving the behaviour behind as if
BDRV_O_CACHE_WB was set.
Signed-off-by: Jeff Cody
Signed-off-by: Kevin Wolf
---
block/iscsi.c |4
bl
From: Jeff Cody
Code motion, to move parsing of open flags into a helper function.
Signed-off-by: Jeff Cody
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 38 --
block/raw-win32.c | 43 +++
2 files changed, 47
From: Jeff Cody
Move AIO initialization for raw-posix block driver into a helper function.
In addition to just code motion, the aio_ctx pointer is checked for NULL,
prior to calling laio_init(), to make sure laio_init() is only run once.
Signed-off-by: Jeff Cody
Signed-off-by: Kevin Wolf
From: Jeff Cody
These are the stubs for the file reopen drivers for the qed format.
There is currently nothing that needs to be done by the qed driver
in reopen.
Signed-off-by: Jeff Cody
Signed-off-by: Kevin Wolf
---
block/qed.c |9 +
1 files changed, 9 insertions(+), 0
From: Jeff Cody
There is currently nothing that needs to be done for VDI reopen.
Signed-off-by: Jeff Cody
Signed-off-by: Kevin Wolf
---
block/vdi.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index 550cf58..f35b12e 100644
--- a
701 - 800 of 24367 matches
Mail list logo
