Am 20.09.2012 11:12, schrieb Bharata B Rao: > On Thu, Sep 20, 2012 at 10:20:33AM +0200, Paolo Bonzini wrote: >> Il 20/09/2012 09:53, Paolo Bonzini ha scritto: >>>>>> Would look a bit nicer with strstart() form cutils.c instead of >>>>>> strncmp(). >>>>> strstart() works with const char pointers, but I have char pointers here >>>>> which I need to modify. >>> You can pass a char* to a function that accepts const char*. In your >>> case, the last argument to strstart would be NULL. >> >> As you pointed out on IRC, you meant the last argument. I don't think >> it would be a problem to cast that from char ** to const char **. >> >> Perhaps it would be cleaner to make qemu_gluster_parseuri and >> parse_gluster_spec accept a const char *. You can replace strtok_r + >> g_strdup with strspn/strcspn followed by g_strndup. > > I feel the current approach of using the combination of strncmp, strtok_r > and g_strdup should be good enough.
Now that Paolo agreed that there wouldn't be a problem with casting, let's use strstart with a cast to (const char**) for the third parameter. Using strtok_r is okay with me. Kevin
