On 03/17/2015 01:47 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
The goal here is to add a new method to transactions that allows
developers to specify a callback that will get invoked only once
all jobs spawned by a transaction are completed, allowing developers
the chance
On 03/17/2015 02:18 PM, Eric Blake wrote:
On 03/17/2015 12:04 PM, John Snow wrote:
+typedef void (CallbackFn)(void *opaque, int ret);
+
+/* Temporary. Removed in the next patch. */
Actually, no. :-)
(remove in patch 7)
Why are you making them non-static in the first place? I see both
On 03/17/2015 02:44 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
Allow bitmap successors to carry reference counts.
We can in a later patch use this ability to clean up the dirty bitmap
according to both the individual job's success and the success of all
jobs i
On 03/17/2015 02:51 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
We'd like to be able to specify the callback given to backup_start
manually in the case of transactions, so split apart qmp_drive_backup
into an implementation and a wrapper.
Switch drive_backup_prepare t
Since we seem to be rejecting patches that introduce clang warnings on
Peter Maydell's OSX configuration, I felt like I should detail the long
list of errors we currently have that prevent me from thoroughly testing
with clang in 3.5.0.
There are five classes of errors that currently plague ou
On 03/17/2015 03:34 PM, Peter Maydell wrote:
On 17 March 2015 at 19:30, John Snow wrote:
-Wunused-command-line-argument currently complains about the many include
flags passed to each CC incantation -- presumably this is not really
fixable, because we'd have to fix our Makefile to be
A thinko that clang 3.5.0 caught.
Thankfully does not introduce any new failures.
Signed-off-by: John Snow
---
tests/ahci-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index cf0b98b..169e83b 100644
--- a/tests/ahci-test.c
+++ b
On 03/17/2015 04:59 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
Use a transaction to request an incremental backup across two drives.
Coerce one of the jobs to fail, and then re-run the transaction.
Verify that no bitmap data was lost due to the partial transaction
failure
On 03/17/2015 02:44 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
Allow bitmap successors to carry reference counts.
We can in a later patch use this ability to clean up the dirty bitmap
according to both the individual job's success and the success of all
jobs i
On 03/17/2015 03:49 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
This patch actually implements the transactional callback system
for the drive_backup transaction.
(1) We manually pick up a reference to the bitmap if present to allow
its cleanup to be delayed until
On 03/17/2015 04:44 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
The original test was not particularly good about keeping the
relationships between bitmaps, drives, and images very explicit,
so this patch adds an explicit 'drive' dict that is used to
keep these rel
On 03/17/2015 04:50 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
Allow tests to call just the backup preparation routine
without invoking a backup. Useful for transactions where
we want to prepare, but don't wish to issue the QMP command.
Signed-off-by: John
On 03/18/2015 03:11 AM, Markus Armbruster wrote:
John Snow writes:
A thinko that clang 3.5.0 caught.
Thankfully does not introduce any new failures.
Signed-off-by: John Snow
How you caught the bug is interesting enough to be mentioned in the
commit message, but the nature of the bug
On 03/17/2015 07:07 PM, Peter Maydell wrote:
On 17 March 2015 at 19:59, John Snow wrote:
On 03/17/2015 03:34 PM, Peter Maydell wrote:
On 17 March 2015 at 19:30, John Snow wrote:
-Wunused-command-line-argument currently complains about the
many include flags passed to each CC incantation
On 03/18/2015 09:41 AM, Max Reitz wrote:
On 2015-03-17 at 19:27, John Snow wrote:
On 03/17/2015 03:49 PM, Max Reitz wrote:
On 2015-03-04 at 23:15, John Snow wrote:
This patch actually implements the transactional callback system
for the drive_backup transaction.
(1) We manually pick up a
On 03/18/2015 04:28 PM, Peter Maydell wrote:
On 18 March 2015 at 19:22, John Snow wrote:
There's one case of error here that's interesting that ccache unearths:
we use a gnu extension to give return values to compound statement blocks,
then wrap these blocks into macros as if
-Wabsolute-value
- Added a workaround to help suppress ccache warnings
The result is that you *should* be able to use clang 3.5.0 *with* ccache and
-Werror and produce all targets.
John Snow (3):
tricore: remove no-op abs() calls
configure: silence glib unknown attribute __alloc_size__
hether glib headers cause warnings and disables
-Wunknown-attributes if that is the case.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 15 +++
1 file changed, 15 insertions(+)
diff --git a/configure b/configure
index 062df84..9db53ba 100755
--- a/configure
+
Calling abs() on a uint32_t is a no-op, so remove it.
clang 3.5.0 will not compile this if -Werror is set,
throwing a -Wabsolute-value warning.
Signed-off-by: John Snow
---
target-tricore/op_helper.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-tricore
est passed without -Werror but failed with -Werror.
Make the -nopie test use -Werror so that compile_prog works for both gcc
and clang.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/confi
issue:
http://peter.eisentraut.org/blog/2014/12/01/ccache-and-clang-part-3/
Signed-off-by: John Snow
---
configure | 31 +++
1 file changed, 31 insertions(+)
diff --git a/configure b/configure
index 9db53ba..f242181 100755
--- a/configure
+++ b/configure
@@ -4167,6
On 03/18/2015 06:51 PM, Peter Maydell wrote:
On 18 March 2015 at 22:43, John Snow wrote:
Calling abs() on a uint32_t is a no-op, so remove it.
clang 3.5.0 will not compile this if -Werror is set,
throwing a -Wabsolute-value warning.
Signed-off-by: John Snow
This is probably the wrong fix
Andreas brought this failure to my attention; it looks like PIO
read/writes for nsectors > 1 for IDE or AHCI will fail on ppc64.
The failure is in the IDE core layer.
In a nutshell, we've never *actually* supported PIO r/w for nsectors >
1, I just started testing it as a spec compliance item (
On 03/19/2015 10:25 AM, Mark Cave-Ayland wrote:
On 17/03/15 06:43, Hervé Poussineau wrote:
Hi,
Le 16/03/2015 22:48, John Snow a écrit :
On 03/14/2015 12:50 PM, Hervé Poussineau wrote:
They were introduced in 6f7e9aec5eb5bdfa57a9e458e391b785c283a007 and
27;G_GNUC_ALLOC_SIZE'
#define G_GNUC_ALLOC_SIZE(x) __attribute__((__alloc_size__(x)))
This patch checks whether glib headers cause warnings and disables
-Wunknown-attributes if it is able to.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 12
1 fi
Factor out the function that checks if a compiler
flag is supported or not.
Signed-off-by: John Snow
---
configure | 36 ++--
1 file changed, 22 insertions(+), 14 deletions(-)
diff --git a/configure b/configure
index 062df84..9a0e4ef 100755
--- a/configure
+++ b
est passed without -Werror but failed with -Werror.
Make the -nopie test use -Werror so that compile_prog works for both gcc
and clang.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/confi
issue:
http://peter.eisentraut.org/blog/2014/12/01/ccache-and-clang-part-3/
Signed-off-by: John Snow
---
configure | 31 +++
1 file changed, 31 insertions(+)
diff --git a/configure b/configure
index fbcbf50..75219a9 100755
--- a/configure
+++ b/configure
@@ -4172,6
patch, which I think was fine.
- Fixed the -Wno-unknown-attributes patch.
- Added a tricore fix for -Wabsolute-value
- Added a workaround to help suppress ccache warnings
The result is that you *should* be able to use clang 3.5.0 *with* ccache and
-Werror and produce all targets.
John Sn
We need to adjust the sector being written to
prior to calling ide_transfer_start, otherwise
we'll write to the same sector again.
Signed-off-by: John Snow
---
hw/ide/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index ef52f35..0e
Similar to the cmd_write_pio fix, update the nsector count and
ide sector before we invoke ide_transfer_start.
Signed-off-by: John Snow
---
hw/ide/core.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 0e9da64..a895fd8 100644
--- a
My pattern was cyclical every 256 bytes, so it missed a fairly obvious
failure case. Add some rand() pepper into the test pattern, and for large
patterns that exceed 256 sectors, start writing an ID per-sector so that
we never generate identical sector patterns.
Signed-off-by: John Snow
. ahci-test didn't catch
this because it used a pattern that was identical for each
sector.
So the pattern has been corrected and the underlying issue
fixed.
This should clear up the test failures (properly) for ppc64.
John Snow (4):
ide: fix cmd_write_pio when nsectors >
by moving the offset addition OUTSIDE of the le64_to_cpu
calculation.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index e1ae36f..7a223be 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -799,7 +799,7
We treat this field with a variety of different types everywhere
in the code. Now it's just uint32_t.
Reviewed-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
block.c | 11 ++-
block/mirror.c
o block-core.json will be re-used in future patches
in this series, see:
'qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}'
Signed-off-by: John Snow
---
block.c | 20 +
block/mirror.c| 10
removed for now until
a use case emerges where this state must be revealed to the user.
The disabled state WILL be used internally for bitmap migration and
bitmap persistence.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 25
empt to scrub memory if fix_count is 0
Changes made with Reviews kept:
02: Since 2.4
04: Since 2.4
Demingled the QMP command documentation.
08: Additions to what was qmp_block_dirty_enable/disable
are no longer present as those function no longer exist.
09: Since 2.4
10: Since 2.4
As a convenience: between incremental backups, bitmap migrations
and bitmap persistence we seem to need to recalculate these a lot.
Because the lengths are a little bit-twiddly, let's just solidly
cache them and be done with it.
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
This returns the granularity (in bytes) of dirty bitmap,
which matches the QMP interface and the existing query
interface.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
---
block.c | 8 ++--
include/block/block.h | 1
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
docs/bitmaps.md | 311
1 file changed, 311 insertions(+)
create mode 100644 docs/bitmaps.md
diff --git a/docs/bitmaps.md b/docs/bitmaps.md
new file mode 100644
index 000..ad8c33b
A filter is added to allow callers to request very specific
events to be pulled from the event queue, while leaving undesired
events still in the stream.
This allows to poll for completion data for multiple asynchronous
events in any arbitrary order.
Signed-off-by: John Snow
Reviewed-by: Max
QMP transactions that enable/disable bitmaps have extra error checking
surrounding them that prevent modifying bitmaps that are frozen.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 104 +-
blockdev.c|
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c| 18 +
include/qemu/hbitmap.h | 10 ++
util/hbitmap.c | 52 ++
3 files changed, 80 insertions(+)
diff --git a/block.c b/block.c
index
running speed for particularly sparse
bitmaps by using iterators, but the running time for dense maps
will be worse.
We present the simpler solution first, and we can refine it later
if needed.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
include/qemu/hbitmap.h | 11 +++
util
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 153 +
tests/qemu-iotests/124.out | 4 +-
2 files changed, 155 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124
index 85675ec..ce2cda7 100644
--- a
For "dirty-bitmap" sync mode, the block job will iterate through the
given dirty bitmap to decide if a sector needs backup (backup all the
dirty clusters and skip clean ones), just as allocation conditions of
"top" sync mode.
Signed-off-by: Fam Zheng
Signed-off-by: John Sn
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 104 +
tests/qemu-iotests/124.out | 5 +++
tests/qemu-iotests/group | 1 +
3 files changed, 110 insertions(+)
create mode 100644 tests/qemu-iotests/124
create mode 100644 tests/qemu
bdrv_find_dirty_bitmap to find a dirty bitmap by name, will
be used later when other QMP commands want to reference dirty bitmap by
name.
Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by
Add the "frozen" status booleans, to inform clients
when a bitmap is occupied doing a task.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 1 +
qapi/block-core.json | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
di
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 005b535..c2e1b27 100644
--- a/block.c
+++ b/block.c
@@ -60,11 +60,11 @@
* or enabled. A frozen bitmap can only abdicate() or
Add bdrv_clear_dirty_bitmap and a matching QMP command,
qmp_block_dirty_bitmap_clear that enables a user to reset
the bitmap attached to a drive.
This allows us to reset a bitmap in the event of a full
drive backup.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c
long)
- Less than sizeof(unsigned long), but across a ulong boundary
- More than sizeof(unsigned long)
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
tests/test-hbitmap.c | 255 +++
1 file changed, 255 insertions(+)
diff --git a/tests/test
We often don't need the BlockDriverState for functions
that operate on bitmaps. Remove it.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block.c | 13 ++---
block/backup.c| 2 +-
block/mirror.c| 26 ++
block
Test the failure case for incremental backups.
Signed-off-by: John Snow
---
blockdev.c | 1 -
tests/qemu-iotests/124 | 55 ++
tests/qemu-iotests/124.out | 4 ++--
3 files changed, 57 insertions(+), 3 deletions(-)
diff --git a
On 03/20/2015 03:52 PM, Max Reitz wrote:
On 2015-03-20 at 15:16, John Snow wrote:
I've run out of cheeky jokes for my cover letters.
This patchset enables the in-memory part of the incremental backup
feature, without transactional support.
Support for transactions was separated i
On 03/20/2015 04:08 PM, Programmingkid wrote:
On Mar 20, 2015, at 4:03 AM, Mark Cave-Ayland wrote:
On 20/03/15 02:38, Programmingkid wrote:
On Mar 19, 2015, at 11:29 AM, Alexander Graf wrote:
On 19.03.15 15:50, Programmingkid wrote:
On Mar 19, 2015, at 3:18 AM, Alexander Graf wrote:
On 03/20/2015 06:25 PM, Programmingkid wrote:
On Mar 20, 2015, at 4:35 PM, John Snow wrote:
If you feel like the CD rom boot failure is "new", I'd be very interested to
know how recent that failure is.
The macio RFC might help, but if you have the cycles to do a bisect ups
On 03/23/2015 09:03 AM, Stefan Hajnoczi wrote:
On Thu, Mar 19, 2015 at 03:01:35PM -0400, John Snow wrote:
+cc_has_warning_flag() {
+if [ "$2" != "--keep-tmpc" ]; then
+write_c_skeleton;
+fi
+
# Use the positive sense of the flag when tes
On 03/23/2015 09:11 AM, Peter Maydell wrote:
On 19 March 2015 at 19:01, John Snow wrote:
Test if ccache is interfering with our life, and
disable its habit of trying to compile already pre-processed
versions of code if so.
In particular, clang has different semantic warnings based on
if the
On 03/23/2015 11:14 AM, Peter Maydell wrote:
On 23 March 2015 at 14:52, John Snow wrote:
On 03/23/2015 09:11 AM, Peter Maydell wrote:
This is really working around a bug in either ccache or
in the way Fedora has configured ccache, so I kind of
feel it ought to be dealt with there. However I
We need to adjust the sector being written to
prior to calling ide_transfer_start, otherwise
we'll write to the same sector again.
Signed-off-by: John Snow
Reviewed-by: Stefan Hajnoczi
Tested-by: Andreas Färber
Message-id: 1426811056-2202-2-git-send-email-js...@redhat.com
---
hw/ide/c
quest
for you to fetch changes up to 54fced034e4d32d8ba6d1e27ecb7e2e2fb2f45d4:
ahci-test: improve rw buffer patterns (2015-03-23 12:24:16 -0400)
----
John Snow (4):
My pattern was cyclical every 256 bytes, so it missed a fairly obvious
failure case. Add some rand() pepper into the test pattern, and for large
patterns that exceed 256 sectors, start writing an ID per-sector so that
we never generate identical sector patterns.
Signed-off-by: John Snow
Reviewed
Similar to the cmd_write_pio fix, update the nsector count and
ide sector before we invoke ide_transfer_start.
Signed-off-by: John Snow
Reviewed-by: Stefan Hajnoczi
Tested-by: Andreas Färber
Message-id: 1426811056-2202-3-git-send-email-js...@redhat.com
---
hw/ide/core.c | 8 +++-
1 file
On 03/23/2015 12:56 PM, John Snow wrote:
The following changes since commit 3c6c9fe034c0c07b77f272e4a53d7735220a16a4:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into
staging (2015-03-20 12:26:09 +)
are available in the git repository at:
by moving the offset addition OUTSIDE of the le64_to_cpu
calculation.
Signed-off-by: John Snow
Reviewed-by: Stefan Hajnoczi
Tested-by: Andreas Färber
Message-id: 1426811056-2202-4-git-send-email-js...@redhat.com
---
hw/ide/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
3/2015 03:22 PM, John Snow wrote:
This is a re-send of patches 7 & 8 from an earlier series,
"[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced
back because I used some glib functions that were too new.
v2:
- Patchew caught a pathing problem with the qemu-img
27;G_GNUC_ALLOC_SIZE'
#define G_GNUC_ALLOC_SIZE(x) __attribute__((__alloc_size__(x)))
This patch checks whether glib headers cause warnings and disables
-Wunknown-attributes if it is able to.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 12
1 fi
cache-and-clang-part-3/
Signed-off-by: John Snow
---
configure | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 87a7f40..36274cc 100755
--- a/configure
+++ b/configure
@@ -103,7 +103,8 @@ update_cxx
Factor out the function that checks if a compiler
flag is supported or not.
Signed-off-by: John Snow
---
configure | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/configure b/configure
index 7a8637e..6f4bf4f 100755
--- a/configure
+++ b
value
- Added a workaround to help suppress ccache warnings
The result is that you *should* be able to use clang 3.5.0 *with* ccache and
-Werror and produce all targets.
John Snow (3):
configure: factor out supported flag check
configure: silence glib unknown attribute __alloc_size__
conf
est passed without -Werror but failed with -Werror.
Make the -nopie test use -Werror so that compile_prog works for both gcc
and clang.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/confi
ss to QEMU
*
Reviewed-by: John Snow
On 03/24/2015 06:45 PM, Andreas Färber wrote:
Replace g_test_add_func() with new qtest_add_func() and modify the path
passed to g_test_add() macro.
Signed-off-by: Andreas Färber
---
tests/i440fx-test.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/i440fx
On 03/24/2015 07:20 PM, Andreas Färber wrote:
Am 25.03.2015 um 00:09 schrieb John Snow:
On 03/24/2015 06:45 PM, Andreas Färber wrote:
Replace g_test_add_func() with new qtest_add_func() and modify the path
passed to g_test_add() macro.
Signed-off-by: Andreas Färber
---
tests/i440fx
On 03/25/2015 10:48 AM, Markus Armbruster wrote:
I just had another cc: to an address gotten from MAINTAINERS bounce with
"user unknown".
How do we weed out dead MAINTAINERS entries?
Automated spambot that runs once a release cycle and reports back to the
list which entries were dead?
--
test_start:
* @args: other arguments to pass to QEMU
*
Reviewed-by: John Snow
;, &data, test_i440fx_pam);
+add_firmware_test("i440fx/firmware/bios", request_bios);
+add_firmware_test("i440fx/firmware/pflash", request_pflash);
ret = g_test_run();
return ret;
Reviewed-by: John Snow
On 03/25/2015 02:20 PM, Andreas Färber wrote:
Replace uses of g_test_add_data_func() for QTest test cases.
It is still valid to use it for any non-QTest test cases,
which are not run for multiple target binaries.
Suggested-by: John Snow
Signed-off-by: Andreas Färber
---
tests/ahci-test.c
On 03/25/2015 08:55 AM, Stefan Hajnoczi wrote:
On Fri, Mar 13, 2015 at 03:22:01PM -0400, John Snow wrote:
This is a re-send of patches 7 & 8 from an earlier series,
"[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced
back because I used some glib functions tha
On 03/10/2015 04:14 PM, John Snow wrote:
This series is based on:
"[Qemu-devel] [PATCH 0/2] ahci: test varying sector offsets"
There appear to be some upstream issues for iotests 051 and 061,
but this series does not appear to alter the existing bad behavior
of those tests.
Thi
Factor out the function that checks if a compiler
flag is supported or not.
Signed-off-by: John Snow
---
configure | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/configure b/configure
index 7a8637e..3e71bb8 100755
--- a/configure
+++ b
cache-and-clang-part-3/
Signed-off-by: John Snow
---
configure | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index c02a26b..dfd23ad 100755
--- a/configure
+++ b/configure
@@ -103,7 +103,8 @@ update_cxx
27;G_GNUC_ALLOC_SIZE'
#define G_GNUC_ALLOC_SIZE(x) __attribute__((__alloc_size__(x)))
This patch checks whether glib headers cause warnings and disables
-Wunknown-attributes if it is able to.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 12
1 fi
ed optimization from cc_has_warning_flag()
- Renamed ccache variable to ccache_cpp2
John Snow (3):
configure: factor out supported flag check
configure: silence glib unknown attribute __alloc_size__
configure: Add workaround for ccache and clang
Stefan Hajnoczi (1):
configure: handle clang -no
est passed without -Werror but failed with -Werror.
Make the -nopie test use -Werror so that compile_prog works for both gcc
and clang.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: John Snow
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/confi
On 03/26/2015 09:19 AM, Kevin Wolf wrote:
Am 25.03.2015 um 16:45 hat John Snow geschrieben:
On 03/25/2015 10:48 AM, Markus Armbruster wrote:
I just had another cc: to an address gotten from MAINTAINERS bounce with
"user unknown".
How do we weed out dead MAINTAINERS entries?
On 03/26/2015 11:41 AM, Andreas Färber wrote:
Am 25.03.2015 um 23:14 schrieb John Snow:
On 03/25/2015 02:20 PM, Andreas Färber wrote:
Replace uses of g_test_add_data_func() for QTest test cases.
It is still valid to use it for any non-QTest test cases,
which are not run for multiple target
un to
backup_complete.
Signed-off-by: John Snow
---
block.c | 65 ++-
block/backup.c| 20 ++--
include/block/block.h | 10
3 files changed, 70 insertions(+), 25 deletions(-)
diff --git a/block.c b/block.c
index 42
Test simple usage cases for using transactions to create
and synchronize incremental backups.
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 51 ++
tests/qemu-iotests/124.out | 4 ++--
2 files changed, 53 insertions(+), 2 deletions
We'd like to be able to specify the callback given to backup_start
manually in the case of transactions, so split apart qmp_drive_backup
into an implementation and a wrapper.
Switch drive_backup_prepare to use the new wrapper, but don't overload
the callback and closure yet.
Signed-of
cleanup.
(4) backup_transaction_complete will perform the final cleanup on the
backup job.
(5) In the case of transaction cancellation, drive_backup_cb is still
responsible for cleaning up the mess we may have already made.
Signed-off-by: John Snow
---
block/backup.c| 9
s.
Signed-off-by: John Snow
---
blockdev.c | 191 +++--
1 file changed, 187 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index f806d40..d404251 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1239,6 +1239,8 @@ type
Use a transaction to request an incremental backup across two drives.
Coerce one of the jobs to fail, and then re-run the transaction.
Verify that no bitmap data was lost due to the partial transaction
failure.
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 119
sactions operate.
This patch changes only comments and names, and should not affect
behavior in any way.
Signed-off-by: John Snow
---
blockdev.c | 114 ++---
1 file changed, 64 insertions(+), 50 deletions(-)
diff --git a/blockdev.c b/bl
In general, since transactions may reference QMP function helpers,
it would be nice for them to sit beneath them.
This will avoid the need for forward declaring any QMP interfaces,
which would be aggravating to update in so many places.
Signed-off-by: John Snow
---
blockdev.c | 2581
us more efficiently delete items in arbitrary order, which will
be more important in the future when some actions will expire at the end
of the transaction, but others may persist until all callbacks triggered
by the transaction are recollected.
Signed-off-by: John Snow
---
blockdev.c | 66
If we want to get at the job after the life of the job,
we'll need a refcount for this object.
This may occur for example if we wish to inspect the actions
taken by a particular job after a transactional group of jobs
runs, and further actions are required.
Signed-off-by: John
alongside a full backup to
accomplish a clean synchronization point.
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
---
blockdev.c | 100 +++
qapi-schema.json | 6 +++-
2 files changed, 105 insertions(+), 1 deletion(-)
diff --git a
501 - 600 of 11520 matches
Mail list logo
