Re: [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default

2012-09-11 Thread Jan Kiszka
On 2012-09-11 14:14, Julien Grall wrote: > On 09/11/2012 12:57 PM, Jan Kiszka wrote: > >> On 2012-09-11 13:48, Jan Kiszka wrote: >>> On 2012-09-11 13:27, Julien Grall wrote: >>>> On 09/11/2012 10:25 AM, Avi Kivity wrote: >>>>> On 09/11/2012 12:15

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Jan Kiszka
On 2012-09-11 14:20, Avi Kivity wrote: > On 09/11/2012 02:08 PM, Jan Kiszka wrote: >> On 2012-09-11 13:03, Avi Kivity wrote: >>> On 09/11/2012 01:04 PM, Jan Kiszka wrote: >>> >>>>> DMA is inherently asynchronous, so we already drop the lock between >&g

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-11 Thread Jan Kiszka
On 2012-09-11 14:30, Avi Kivity wrote: >> The other option is to keep DMA requests issued by devices synchronous >> but let them fail if we are about to lock up. Still requires changes, >> but is probably more comprehensible for device model developers. > > How do you handle fai

Re: [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default

2012-09-11 Thread Jan Kiszka
On 2012-09-11 14:53, Avi Kivity wrote: > On 09/11/2012 02:57 PM, Jan Kiszka wrote: > >> Only listen on debug ports when we also handle them. They are better >> handled by debugcon these days which is runtime configurable. >> >> Signed-off-by: Jan Kiszka >>

Re: [Qemu-devel] [PATCH] pc: Don't listen on debug ports by default

2012-09-11 Thread Jan Kiszka
On 2012-09-11 16:19, Avi Kivity wrote: > On 09/11/2012 05:11 PM, Jan Kiszka wrote: >> On 2012-09-11 14:53, Avi Kivity wrote: >>> On 09/11/2012 02:57 PM, Jan Kiszka wrote: >>> >>>> Only listen on debug ports when we also handle them. They are better >&

Re: [Qemu-devel] Linux KVM, Windows 7 guest choppy sound

2012-09-11 Thread Jan Kiszka
[re-adding the list] On 2012-09-11 16:23, Erik Lotspeich wrote: > On 09/08/2012 05:53 AM, Jan Kiszka wrote: >> Known issue, likely unfixable in QEMU due to hard-coded constraints of >> the driver Windows uses (too small playback buffers). > > Thanks so much for your response

[Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports

2012-09-11 Thread Jan Kiszka
We have debugcon these days to listen on those ports that receive debug messages. Also drop the others that have no effect anymore. Signed-off-by: Jan Kiszka --- hw/pc.c | 27 --- 1 files changed, 0 insertions(+), 27 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index

Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports

2012-09-11 Thread Jan Kiszka
On 2012-09-11 16:48, Andreas Färber wrote: > Am 11.09.2012 16:38, schrieb Jan Kiszka: >> We have debugcon these days to listen on those ports that receive debug >> messages. Also drop the others that have no effect anymore. >> >> Signed-off-by: Jan Kiszka > &g

Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports

2012-09-11 Thread Jan Kiszka
On 2012-09-11 17:11, Andreas Färber wrote: > Am 11.09.2012 17:04, schrieb Jan Kiszka: >> On 2012-09-11 16:48, Andreas Färber wrote: >>> Am 11.09.2012 16:38, schrieb Jan Kiszka: >>>> We have debugcon these days to listen on those ports that receive debug >>&g

Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu

2012-09-11 Thread Jan Kiszka
On 2012-09-11 05:02, Kevin O'Connor wrote: > On Mon, Sep 10, 2012 at 11:25:38AM +0200, Jan Kiszka wrote: >> On 2012-09-09 17:45, Avi Kivity wrote: >>> On 09/07/2012 11:50 AM, Jan Kiszka wrote: >>>> >>>>> +} else { >>>>

[Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-09-11 Thread Jan Kiszka
Our one and only BIOS depends on a writable shadowed BIOS in the ISA range. As we have no interface to control the write property, make that region writable by default. Signed-off-by: Jan Kiszka --- This unbreaks isapc for TCG, and keep it working for KVM once it starts supporting read-only

Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu

2012-09-11 Thread Jan Kiszka
On 2012-09-11 18:15, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-09-11 05:02, Kevin O'Connor wrote: >>> On Mon, Sep 10, 2012 at 11:25:38AM +0200, Jan Kiszka wrote: >>>> On 2012-09-09 17:45, Avi Kivity wrote: >>

Re: [Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-09-12 Thread Jan Kiszka
[forgot to CC stable: this one apparently qualifies for older QEMU releases as well but would require some adaptions for < 1.1] On 2012-09-11 17:53, Jan Kiszka wrote: > Our one and only BIOS depends on a writable shadowed BIOS in the ISA > range. As we have no interface to control

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-12 Thread Jan Kiszka
On 2012-09-12 10:01, Avi Kivity wrote: > On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: >> Intel's definition of "edge triggered" means: "asserted with a >> low-to-high transition at the time an interrupt is registered >> and then kept high until the interrupt is served via one of the >> EOI mechan

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-12 Thread Jan Kiszka
On 2012-09-12 10:51, Avi Kivity wrote: > On 09/12/2012 11:48 AM, Jan Kiszka wrote: >> On 2012-09-12 10:01, Avi Kivity wrote: >>> On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: >>>> Intel's definition of "edge triggered" means: "asserted with a &g

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Jan Kiszka
On 2012-09-12 15:54, Anthony Liguori wrote: > > Hi, > > We've been running into a lot of problems lately with Windows guests and > I think they all ultimately could be addressed by revisiting the missed > tick catchup algorithms that we use. Mike and I spent a while talking > about it yesterday

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Jan Kiszka
On 2012-09-12 16:44, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-09-12 15:54, Anthony Liguori wrote: >>> >>> Hi, >>> >>> We've been running into a lot of problems lately with Windows guests and >>> I think they all u

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Jan Kiszka
On 2012-09-12 17:06, Gleb Natapov wrote: Are there other issues with reinjection that people are aware of? Does anything seem obviously wrong with the above? >>> >>> We should take the chance and design everything in a way that the HPET >>> can finally be (left) enabled. >> >> I thought

Re: [Qemu-devel] [PATCH v3 2/2] slirp: Implement TFTP Blocksize option

2012-09-13 Thread Jan Kiszka
On 2012-09-13 07:55, Hervé Poussineau wrote: > This option is described in RFC 1783. As this is only an optional field, > we may ignore it in some situations and handle it in some others. > > However, MS Windows 2003 PXE boot client requests a block size of the MTU > (most of the times 1472 bytes)

Re: [Qemu-devel] [PATCH v3 1/2] slirp: Handle more than 65535 blocks in TFTP transfers

2012-09-13 Thread Jan Kiszka
On 2012-09-13 07:55, Hervé Poussineau wrote: > RFC 1350 does not mention block count roll-over. However, a lot of TFTP > servers > implement it to be able to transmit big files, so do it also. > > Current block size is 512 bytes, so TFTP files were limited to 32 MB. > > Signed-off-by: Hervé Pous

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-13 Thread Jan Kiszka
On 2012-09-13 15:41, Maciej W. Rozycki wrote: > On Wed, 12 Sep 2012, Matthew Ogilvie wrote: > >> Also, how big of a concern is a very rare gained or lost IRQ0 >> actually? Under normal conditions, I would expect this to at most >> cause a one time clock drift in the guest OS of a fraction of >> a

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-13 Thread Jan Kiszka
On 2012-09-13 07:49, Matthew Ogilvie wrote: > On Wed, Sep 12, 2012 at 10:57:57AM +0200, Jan Kiszka wrote: >> On 2012-09-12 10:51, Avi Kivity wrote: >>> On 09/12/2012 11:48 AM, Jan Kiszka wrote: >>>> On 2012-09-12 10:01, Avi Kivity wrote: >>>>>

Re: [Qemu-devel] [PATCH v3 2/2] slirp: Implement TFTP Blocksize option

2012-09-13 Thread Jan Kiszka
On 2012-09-13 21:56, Hervé Poussineau wrote: > Jan Kiszka a écrit : >> On 2012-09-13 07:55, Hervé Poussineau wrote: >>> This option is described in RFC 1783. As this is only an optional field, >>> we may ignore it in some situations and handle it in some others. >&

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Jan Kiszka
On 2012-09-14 11:39, Michael Tokarev wrote: > On 14.09.2012 13:33, Daniel P. Berrange wrote: >> On Fri, Sep 14, 2012 at 11:39:38AM +0400, Michael Tokarev wrote: >>> What's the difference between the two except that the >>> latter adds some more instructions (actually whole new >>> subsytem) to the

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Jan Kiszka
On 2012-09-14 12:03, Michael Tokarev wrote: > On 14.09.2012 14:00, Jan Kiszka wrote: > [] >> The major difference in qemu-system-i386 vs. qemu-system-x86_64 is on >> the TCG side: We measured noticeable performance benefits when running >> 32/16 bit OSes against qemu-sy

Re: [Qemu-devel] qemu-system-i386 vs qemu-system-x86_64 ?

2012-09-14 Thread Jan Kiszka
On 2012-09-14 12:20, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 12:12:43PM +0200, Jan Kiszka wrote: >> On 2012-09-14 12:03, Michael Tokarev wrote: >>> On 14.09.2012 14:00, Jan Kiszka wrote: >>> [] >>>> The major difference in qemu-system-i386 vs. qem

[Qemu-devel] [PATCH] slirp: Remove unused return value of tftp_send_next_block

2012-09-14 Thread Jan Kiszka
No caller actually makes use of this value, so let's simplify the code. Signed-off-by: Jan Kiszka --- Applies on top of http://thread.gmane.org/gmane.comp.emulators.qemu/169909 slirp/tftp.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/slirp/tft

[Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-09-15 Thread Jan Kiszka
From: Jan Kiszka This follows the logic of host-linux: If a 2.0 device has no ISO endpoint and no interrupt endpoint with a packet size > 64, we can attach it also to an 1.1 host controller. In case the redir server does not report endpoint sizes, play safe and remove the 1.1 compatibility

Re: [Qemu-devel] [PATCH] fix warnings from printf target addresses

2012-09-16 Thread Jan Kiszka
On 2012-09-16 02:05, Mike Frysinger wrote: > Current code triggers: > memory.c: In function 'invalid_read': > memory.c:1001: warning: format '%#x' expects type 'unsigned int', > but argument 4 has type 'target_phys_addr_t' > memory.c: In function 'invalid_write': > memory.c:1013: warning: for

[Qemu-devel] [PULL] slirp: enhancements of TFTP and small fixes

2012-09-16 Thread Jan Kiszka
prove TFTP performance slirp: Handle more than 65535 blocks in TFTP transfers slirp: Implement TFTP Blocksize option Jan Kiszka (1): slirp: Remove unused return value of tftp_send_next_block Stefan Weil (2): slirp: Remove wrong type casts ins debug statements slirp:

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-17 Thread Jan Kiszka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2012-09-16 22:55, Mike Frysinger wrote: > On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: >> Am 16.09.2012 22:11, schrieb Mike Frysinger: >>> +libcacard/vscclient +a.out* +.gdb_history +core +gmon.out >>> +*.diff +*.patch +*.rej >> >> IMHO

Re: [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-09-17 Thread Jan Kiszka
On 2012-09-17 11:08, Hans de Goede wrote: > Hi, > > On 09/15/2012 06:27 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This follows the logic of host-linux: If a 2.0 device has no ISO >> endpoint and no interrupt endpoint with a packet size > 64, we

Re: [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-09-17 Thread Jan Kiszka
On 2012-09-17 16:24, Hans de Goede wrote: > Hi, > > On 09/17/2012 11:18 AM, Jan Kiszka wrote: >> On 2012-09-17 11:08, Hans de Goede wrote: > > > >>> Although not pretty I'm ok with this, since I actually want to add >>> similar code to allow us

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-17 Thread Jan Kiszka
On 2012-09-17 20:32, Mike Frysinger wrote: > On Monday 17 September 2012 03:19:54 Jan Kiszka wrote: >> On 2012-09-16 22:55, Mike Frysinger wrote: >>> On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: >>>> Am 16.09.2012 22:11, schrieb Mike Frysinger: >

Re: [Qemu-devel] Breakage

2012-09-17 Thread Jan Kiszka
On 2012-09-17 21:54, malc wrote: > On Mon, 17 Sep 2012, Anthony Liguori wrote: > >> malc writes: >> >>> Some(thing|one) broke compilation with pcspk enabled. >>> Symptoms being: >>> >>> ../libhw32/hw/pcspk.o: In function `pcspk_io_write': >>> /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined re

Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)

2012-09-17 Thread Jan Kiszka
On 2012-09-17 22:14, Stefan Weil wrote: > This configuration requires CONFIG_i8254: > > configure --target-list=xtensa-softmmu --audio-card-list=pcspk This is wrong. The pcspk "audio card" is registered automatically for those targets that support it. > > Reported-by: Vassili Karpov (malc) > S

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Jan Kiszka
On 2012-09-18 03:52, Wen Congyang wrote: > At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: >> Hi Wen, >> >> We've re-reviewed the dump-guest-memory command and found some >> possible issues with the -p option. >> >> The main issue is that it seems possible for a malicious guest to set >> page tables

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Jan Kiszka
On 2012-09-18 14:23, Markus Armbruster wrote: > Jan Kiszka writes: > >> On 2012-09-18 03:52, Wen Congyang wrote: >>> At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: >>>> Hi Wen, >>>> >>>> We've re-reviewed the dump-guest-memory

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-18 Thread Jan Kiszka
On 2012-09-18 14:50, GaoYi wrote: > Hi Jan, > >I have followed a previous thread about ELI proposed by Abel Gordon, > http://www.spinics.net/lists/kvm/msg73907.html. >I wonder whether this mechanism will be incorporated in KVM someday. Likely not. Both Intel and AMD will soon ship hardwa

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Jan Kiszka
On 2012-09-18 15:33, Luiz Capitulino wrote: > On Tue, 18 Sep 2012 14:41:53 +0200 > Jan Kiszka wrote: > >> On 2012-09-18 14:23, Markus Armbruster wrote: >>> Jan Kiszka writes: >>> >>>> On 2012-09-18 03:52, Wen Congyang wrote: >>>>>

Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Jan Kiszka
>> >> Cc: Paolo Bonzini >> Cc: Jan Kiszka >> Signed-off-by: Anthony Liguori >> --- >> Please note, this is lightly tested. Since this is such a fundamental >> change, >> I'd like to do some performance analysis before committing but wan

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-19 Thread Jan Kiszka
On 2012-09-19 06:40, Peter Crosthwaite wrote: > On Wed, Sep 19, 2012 at 2:32 PM, Edgar E. Iglesias > wrote: >> On Wed, Sep 19, 2012 at 02:25:48PM +1000, Peter Crosthwaite wrote: >>> Ping for PMM, >>> >>> This is the root case of your block on the SDHCI series - this is a >>> discussion on resoluti

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-19 Thread Jan Kiszka
On 2012-09-19 11:23, Avi Kivity wrote: > On 09/19/2012 12:19 PM, liu ping fan wrote: >> On Wed, Sep 19, 2012 at 5:14 PM, Paolo Bonzini wrote: >>> Il 19/09/2012 11:11, liu ping fan ha scritto: >> Why not? devA will drop its local lock, devX will retake the big lock >> recursively, devB will

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-19 Thread Jan Kiszka
On 2012-09-19 11:27, Jan Kiszka wrote: > On 2012-09-19 11:23, Avi Kivity wrote: >> On 09/19/2012 12:19 PM, liu ping fan wrote: >>> On Wed, Sep 19, 2012 at 5:14 PM, Paolo Bonzini wrote: >>>> Il 19/09/2012 11:11, liu ping fan ha scritto: >>>>>>>

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-19 Thread Jan Kiszka
On 2012-09-19 11:00, liu ping fan wrote: > On Wed, Sep 19, 2012 at 4:06 PM, Avi Kivity wrote: >> On 09/19/2012 06:02 AM, liu ping fan wrote: >>> Currently, cpu_physical_memory_rw() can be used directly or indirectly >>> by mmio-dispatcher to access other devices' memory region. This can >>> cause

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-19 Thread Jan Kiszka
On 2012-09-19 11:50, Avi Kivity wrote: > On 09/19/2012 12:34 PM, Jan Kiszka wrote: >> >> What about the following: >> >> What we really need to support in practice is MMIO access triggers RAM >> access of device model. Scenarios where a device access triggers an

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-19 Thread Jan Kiszka
[putting Avi on CC as the final decision maker] On 2012-09-19 15:37, Muli Ben-Yehuda wrote: > On Tue, Sep 18, 2012 at 03:08:40PM +0200, Jan Kiszka wrote: >> On 2012-09-18 14:50, GaoYi wrote: >>> Hi Jan, >>> >>>I have followed a previous thread about EL

Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd

2012-09-19 Thread Jan Kiszka
Please turn of HTML in you mailer. It's very hard to parse your reply. On 2012-09-19 16:15, Peter Portante wrote: > On Wed, Sep 19, 2012 at 3:44 AM, Jan Kiszka > mailto:jan.kis...@siemens.com>> wrote: > On 2012-09-19 09:26, Paolo Bonzini wrote: >> Il 18/09/2012 22:37,

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-19 Thread Jan Kiszka
On 2012-09-19 16:43, Abel Gordon wrote: > >> It's imperfect as you need to dedicate a core to pure guest-mode load >> and cannot run userspace on that core (cannot walk through >> userspace-based device models e.g.). > > That's not correct. > For the evaluation, we dedicated a core for each guest

Re: [Qemu-devel] [PATCH] Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs

2012-09-19 Thread Jan Kiszka
On 2012-09-19 19:49, Auld, Will wrote: > From 9d5201975d2c9da4da8a945fcd9531c9fb2073c0 Mon Sep 17 00:00:00 2001 > From: Will Auld > Date: Wed, 12 Sep 2012 18:31:41 -0700 > Subject: [PATCH] Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs > > CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is

Re: [Qemu-devel] [PATCH v13 2/8] start vm after resetting it

2013-02-28 Thread Jan Kiszka
On 2013-02-28 13:13, Hu Tao wrote: > From: Wen Congyang > > The guest should run after resetting it, but it does not run if its > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > We don't set runstate to RUN_STATE_PAUSED when resetting the guest, > so the runstate will be changed f

Re: [Qemu-devel] [PATCH 2/2] Revert "gdbstub: Do not kill target in system emulation mode"

2013-03-05 Thread Jan Kiszka
On 2013-03-05 17:03, Fabien Chouteau wrote: > This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8. Should also tell us why (by pointing to the other commit e.g.). Will give this a try ASAP! Thanks, Jan > > Signed-off-by: Fabien Chouteau > --- > gdbstub.c |2 -- > 1 file changed,

Re: [Qemu-devel] [PATCH 1/2] Add GDB qAttached support

2013-03-10 Thread Jan Kiszka
On 2013-03-05 17:03, Fabien Chouteau wrote: > With this patch GDB will issue a "detach" command at the end of a > debugging session instead of a "kill". This behavior can be inverted > with the new option -gdb-not-attached. > > This patch implements the requirement described in Jan Kiszka's patch:

Re: [Qemu-devel] [PATCH 1/2] Add GDB qAttached support

2013-03-11 Thread Jan Kiszka
On 2013-03-11 12:22, Fabien Chouteau wrote: > On 03/10/2013 09:06 AM, Jan Kiszka wrote: >>> @@ -2491,6 +2493,10 @@ static int gdb_handle_packet(GDBState *s, const char >>> *line_buf) >>> break; >>> } >>> #endif

Re: [Qemu-devel] [PATCH 1/2] Add GDB qAttached support

2013-03-12 Thread Jan Kiszka
On 2013-03-12 15:31, Fabien Chouteau wrote: > With this patch QEMU handles qAttached request from gdb. When QEMU > replies 1, GDB sends a "detach" command at the end of a debugging > session otherwise GDB sends "kill". > > The default value for qAttached is 1 on system emulation and 0 on user > em

[Qemu-devel] [PATCH] qemu-char: Fix typo in virtual console registration

2013-03-14 Thread Jan Kiszka
Regression of 01f45d986f. Signed-off-by: Jan Kiszka --- ui/console.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/console.c b/ui/console.c index 83a6fa3..0f96177 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1742,7 +1742,7 @@ PixelFormat

[Qemu-devel] [PATCH v4] Add GDB qAttached support

2013-03-14 Thread Jan Kiszka
n by Fabien Chouteau. Signed-off-by: Jan Kiszka --- As Fabien dropped his attempt to make this configurable, let's preserve the value of exposing this feature to gdb statically. gdbstub.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub

Re: [Qemu-devel] [PATCH V3 2/3] Revert "gdbstub: Do not kill target in system emulation mode"

2013-03-14 Thread Jan Kiszka
and; > } > case 'k': > -#ifdef CONFIG_USER_ONLY > /* Kill the target */ > fprintf(stderr, "\nQEMU: Terminated via GDBstub\n"); > exit(0); > -#endif > case 'D': > /* Detach packet */ &g

[Qemu-devel] [PATCH] vmxcap: Update according to SDM of January 2013

2013-03-17 Thread Jan Kiszka
From: Jan Kiszka This adds reporting of VMCS shadowing, #VE, IA32_SMBASE, unrestricted VMWRITE and fixes the range of the MSEG revision ID. Signed-off-by: Jan Kiszka --- scripts/kvm/vmxcap |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/scripts/kvm/vmxcap b

Re: [Qemu-devel] Using aio_poll for timer carrier threads

2013-08-19 Thread Jan Kiszka
On 2013-08-19 15:21, Paolo Bonzini wrote: > Il 13/08/2013 16:54, Jan Kiszka ha scritto: >>>> Using an AioContext lock for timers is somewhat complicated for lock >>>> ordering, because context A could try to modify a timer from context B, >>>> at the same t

Re: [Qemu-devel] [PATCH v3 3/3] slirp: set mainloop timeout with more precise value

2013-08-23 Thread Jan Kiszka
On 2013-08-21 10:07, liu ping fan wrote: > On Wed, Aug 21, 2013 at 3:36 PM, Alex Bligh wrote: >> >> >> --On 21 August 2013 10:15:52 +0800 Liu Ping Fan wrote: >> >>> -void slirp_update_timeout(uint32_t *timeout) >>> +static void slirp_update_timeout(uint32_t *timeout) >>> { >>> -if (!QTAILQ_E

Re: [Qemu-devel] [PATCH v3 3/3] slirp: set mainloop timeout with more precise value

2013-08-23 Thread Jan Kiszka
On 2013-08-21 04:15, Liu Ping Fan wrote: > If slirp needs to emulate tcp timeout, then the timeout value > for mainloop should be more precise, which is determined by > slirp's fasttimo or slowtimo. Achieve this by swap the logic > sequence of slirp_pollfds_fill and slirp_update_timeout. > > Signe

Re: [Qemu-devel] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers

2013-08-23 Thread Jan Kiszka
& htonl(~(0xf << 28))) != 0); > +assert((ip_addr & htonl(~(0xfU << 28))) != 0); > > /* If broadcast address */ > if (ip_addr == 0x || ip_addr == broadcast_addr) { > Acked-by: Jan Kiszka -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux

Re: [Qemu-devel] Direct guest device access from nested guest

2013-08-28 Thread Jan Kiszka
On 2013-08-28 16:28, Lluís Vilanova wrote: > Hi, > > I want to get the following setup, but don't know how (or if it's even > possible): > > * A guest VM with two AHCI controllers, with one device each. One of the AHCI > controllers provides the VM's disk ("system"), while the other provides >

Re: [Qemu-devel] [PATCH v4 0/3] slirp: fill mainloop with more precise timeout value

2013-08-28 Thread Jan Kiszka
+- > 5 files changed, 49 insertions(+), 27 deletions(-) > Thanks, applied to the slirp queue. I'm carrying the tiny cleanup below on top. Jan --- slirp: clean up slirp_update_timeout No need to write out the timeout early, keep it local until we are done. Signed-off-by: Jan

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-28 Thread Jan Kiszka
On 2013-08-28 18:37, Markus Armbruster wrote: >>> 3. Why does CONFIG_MIXEMU exist? >>> >> I can post a patch for it (again) on top of these changes and >> see where it goes. If the default value of the "mixer" property stays >> off, malc's concerns mentioned elsewhere in this thread will be taken

Re: [Qemu-devel] Direct guest device access from nested guest

2013-08-28 Thread Jan Kiszka
On 2013-08-28 20:12, Lluís Vilanova wrote: > Jan Kiszka writes: > [...] >>> Is it possible to give a nested guest direct access to a device on the >>> guest? >>> (more specifically, an AHCI controller). > >> Nope, we are lacking support for emulat

Re: [Qemu-devel] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows

2013-08-30 Thread Jan Kiszka
On 2013-08-15 21:25, Taimoor wrote: > From: Taimoor Mirza > > port redirection code uses SO_REUSEADDR socket option before binding to > host port. Behavior of SO_REUSEADDR is different on Windows and Linux. > Relaunching QEMU with same host and guest port redirection values on Linux > throws erro

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows

2013-09-01 Thread Jan Kiszka
On 2013-09-01 18:13, Stefan Weil wrote: > Am 01.09.2013 17:46, schrieb Michael Tokarev: >> 30.08.2013 15:04, Jan Kiszka wrote: >>> On 2013-08-15 21:25, Taimoor wrote: >>>> From: Taimoor Mirza >>>> >>>> port redirection code uses SO_RE

Re: [Qemu-devel] [PATCH v2 for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-09-02 Thread Jan Kiszka
On 2013-09-02 15:52, Peter Maydell wrote: > On 12 August 2013 16:39, Andreas Färber wrote: >> Am 12.08.2013 17:29, schrieb Jan Kiszka: >>> Accesses to unassigned io ports shall return -1 on read and be ignored >>> on write. Ensure these properties via dedicated ops,

Re: [Qemu-devel] [PATCH v2 for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-09-02 Thread Jan Kiszka
On 2013-09-02 17:58, Andreas Färber wrote: > Am 02.09.2013 17:56, schrieb Jan Kiszka: >> On 2013-09-02 15:52, Peter Maydell wrote: >>> On 12 August 2013 16:39, Andreas Färber wrote: >>>> Am 12.08.2013 17:29, schrieb Jan Kiszka: >>>>> Accesses to unass

[Qemu-devel] [PATCH v3 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-09-02 Thread Jan Kiszka
Accesses to unassigned io ports shall return -1 on read and be ignored on write. Ensure these properties via dedicated ops, decoupling us from the memory core's handling of unassigned accesses. Signed-off-by: Jan Kiszka --- exec.c| 3 ++- include/exec/ioport.h

[Qemu-devel] [PATCH v3 2/2] Revert "memory: Return -1 again on reads from unsigned regions"

2013-09-02 Thread Jan Kiszka
This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. The commit was wrong: We only return -1 on invalid accesses, not on valid but unbacked ones. This broke various corner cases. Signed-off-by: Jan Kiszka --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH v3 0/2] Fix unassigned memory and I/O access handling

2013-09-02 Thread Jan Kiszka
Repost of what missed the 1.6 release. Jan Kiszka (2): memory: Provide separate handling of unassigned io ports accesses Revert "memory: Return -1 again on reads from unsigned regions" exec.c| 3 ++- include/exec/ioport.h | 4 ioport.c

Re: [Qemu-devel] [PATCH] linux-headers: update to 3.11

2013-09-03 Thread Jan Kiszka
On 2013-09-03 11:32, Alexey Kardashevskiy wrote: > On 09/03/2013 07:29 PM, Peter Maydell wrote: >> On 3 September 2013 09:27, Alexey Kardashevskiy wrote: >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> >>> I need this update as VFIO on PPC64/pseries got in upstream kernel >>> and this is requ

Re: [Qemu-devel] [KVM] segmentation fault happened when reboot VM after hot-uplug virtio NIC

2013-09-03 Thread Jan Kiszka
On 2013-09-03 14:18, Gleb Natapov wrote: > On Tue, Sep 03, 2013 at 12:06:33PM +, Zhanghaoyu (A) wrote: >> Hi, all >> >> Segmentation fault happened when reboot VM after hot-unplug virtio NIC, >> which can be reproduced 100%. >> See similar bug report to https://bugzilla.redhat.com/show_bug.cgi

Re: [Qemu-devel] [KVM] segmentation fault happened when reboot VM after hot-uplug virtio NIC

2013-09-03 Thread Jan Kiszka
On 2013-09-03 14:06, Zhanghaoyu (A) wrote: > Hi, all > > Segmentation fault happened when reboot VM after hot-unplug virtio NIC, which > can be reproduced 100%. > See similar bug report to https://bugzilla.redhat.com/show_bug.cgi?id=988256 > > test environment: > host: SLES11SP2 (kenrel version:

Re: [Qemu-devel] [KVM] segmentation fault happened when reboot VM after hot-uplug virtio NIC

2013-09-03 Thread Jan Kiszka
On 2013-09-03 15:22, Zhanghaoyu (A) wrote: >>> Hi, all >>> >>> Segmentation fault happened when reboot VM after hot-unplug virtio NIC, >>> which can be reproduced 100%. >>> See similar bug report to >>> https://bugzilla.redhat.com/show_bug.cgi?id=988256 >>> >>> test environment: >>> host: SLES11S

Re: [Qemu-devel] [KVM] segmentation fault happened when reboot VM after hot-uplug virtio NIC

2013-09-03 Thread Jan Kiszka
On 2013-09-03 15:57, Jan Kiszka wrote: > On 2013-09-03 15:22, Zhanghaoyu (A) wrote: >>>> Hi, all >>>> >>>> Segmentation fault happened when reboot VM after hot-unplug virtio NIC, >>>> which can be reproduced 100%. >>>> See similar

[Qemu-devel] [uq/master][PATCH 3/3] kvmvapic: Clear also physical ROM address when entering INACTIVE state

2013-09-03 Thread Jan Kiszka
To avoid misinterpreting INACTIVE after migration as old qemu-kvm's STANDBY, also clear rom_state_paddr when going back to this state. CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka --- hw/i386/kvmvapic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/kvmvapic.c b/hw

[Qemu-devel] [uq/master][PATCH 1/3] kvmvapic: Catch invalid ROM size

2013-09-03 Thread Jan Kiszka
If not caught early, a zero-length ROM will cause a NULL-pointer access later on in patch_hypercalls when allocating a zero-length ROM copy and trying to read from it. CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka --- hw/i386/kvmvapic.c | 11 +-- 1 file changed, 9 insertions

[Qemu-devel] [uq/master][PATCH 0/3] Fix initialization bugs in kvmvapic

2013-09-03 Thread Jan Kiszka
Addresses the issue Daniel reported in http://thread.gmane.org/gmane.comp.emulators.qemu/231577 CC: qemu-sta...@nongnu.org Jan Kiszka (3): kvmvapic: Catch invalid ROM size kvmvapic: Enter inactive state on hardware reset kvmvapic: Clear also physical ROM address when entering INACTIVE

[Qemu-devel] [uq/master][PATCH 2/3] kvmvapic: Enter inactive state on hardware reset

2013-09-03 Thread Jan Kiszka
ROM layout may change after reset of devices are hotplugged, so we have to pick up the physical address again when the ROM is initialized. This is best achieved by resetting the state to INACTIVE. CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka --- hw/i386/kvmvapic.c | 4 +--- 1 file

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-04 Thread Jan Kiszka
On 2013-09-04 16:27, Paolo Bonzini wrote: > Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: >> This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems >> the default behavior is equivalent to SO_REUSEADDR on other operating >> systems. SO_REUSEADDR can still be set but resul

Re: [Qemu-devel] [PATCH v4 2/8] ahci: MSI capability should be at 0x80, not 0x50.

2014-09-17 Thread Jan Kiszka
On 2014-08-21 19:44, John Snow wrote: > In the Intel ICH9 data sheet, the MSI capability offset > in the PCI configuration space for ICH9 AHCI devices is > specified to be 0x80. > > Further, the PCI capability pointer should always point > to 0x80 in ICH9 devices, despite the fact that AHCI 1.3 >

Re: [Qemu-devel] [PATCH] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Jan Kiszka
On 2014-09-17 13:41, Petr Matousek wrote: > When guest sends udp packet with source port and source addr 0, > uninitialized socket is picked up when looking for matching and already > created udp sockets, and later passed to sosendto() where NULL pointer > dereference is hit during so->slirp->vnetw

Re: [Qemu-devel] [PATCH v2] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Jan Kiszka
-152,7 +152,7 @@ udp_input(register struct mbuf *m, int iphlen) >* Locate pcb for datagram. >*/ > so = slirp->udp_last_so; > - if (so->so_lport != uh->uh_sport || > + if (so == &slirp->udb || so->so_lport != uh->uh_sport || >

Re: [Qemu-devel] [PATCH v7 00/11] target-arm: Parts of the AArch64 EL2/3 exception model

2014-09-29 Thread Jan Kiszka
On 2014-09-26 17:23, Peter Maydell wrote: > On 26 September 2014 09:08, Edgar E. Iglesias > wrote: >> From: "Edgar E. Iglesias" >> >> Hi, >> >> This is a second round of AArch64 EL2/3 patches working on the exception >> model. Among other things adding HVC/SMC, interrupt routing to EL2/3 and >>

Re: [Qemu-devel] [PATCH v7 00/11] target-arm: Parts of the AArch64 EL2/3 exception model

2014-09-29 Thread Jan Kiszka
On 2014-09-29 12:41, Peter Maydell wrote: > On 29 September 2014 11:31, Jan Kiszka wrote: >> Sorry for hijacking the thread, but it seems related: These bits address >> AArch64, but what is the status of AArch32 /wrt hyp mode emulation? >> After playing with the "fast&

[Qemu-devel] [PATCH] configure: Filter out system includes for pixman

2014-10-02 Thread Jan Kiszka
Other packages may provide includes for pixman as well if the host has a devel package installed. Remove them from QEMU_CFLAGS before adding our version to unsure that the right headers are used. Signed-off-by: Jan Kiszka --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Jan Kiszka
On 2014-09-02 17:11, Michael Roth wrote: > Quoting Markus Armbruster (2014-07-30 06:19:36) >> Paolo Bonzini writes: >> >>> Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: >>>> On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: >>>>>

[Qemu-devel] [PATCH] configure: Prepend pixman and ftd flags to overrule system-provided ones

2014-10-02 Thread Jan Kiszka
Other packages may provide includes for pixman as well if the host has a devel package installed. So add ours to the front to unsure that the right version is used. Signed-off-by: Jan Kiszka --- Replaces "configure: Filter out system includes for pixman" And, yes, the scenario

Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models

2014-10-02 Thread Jan Kiszka
On 2014-10-02 10:03, Michael S. Tsirkin wrote: > On Thu, Oct 02, 2014 at 09:27:41AM +0200, Jan Kiszka wrote: >> On 2014-09-02 17:11, Michael Roth wrote: >>> Quoting Markus Armbruster (2014-07-30 06:19:36) >>>> Paolo Bonzini writes: >>>> >>>&g

[Qemu-devel] [PATCH] Add linux-headers to QEMU_INCLUDES

2013-04-10 Thread Jan Kiszka
From: Jan Kiszka virtio/dataplane/vring.c requires the Linux headers and is built for all targets. So we need to add the corresponding include to QEMU_INCLUDES to avoid that outdated distribution headers are used. Signed-off-by: Jan Kiszka --- configure |5 + 1 files changed, 1

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-10 Thread Jan Kiszka
On 2013-04-03 13:50, Gerd Hoffmann wrote: > Hi, > >>> No, it is not, and yes, this is where the inconsistency comes >>> from. We read wred+wgreen+wblue directly from the surface >>> whereas depth is cached in the vmware vga state struct. Patch >>> attached. Not fully tested yet. >> >> Unfo

Re: [Qemu-devel] [PATCH] ui/gtk: Set QEMU window icon

2013-04-10 Thread Jan Kiszka
On 2013-03-30 15:21, Stefan Weil wrote: > The QEMU icon which is already used for SDL > is now also loaded by GTK. > > Signed-off-by: Stefan Weil > --- > ui/gtk.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/ui/gtk.c b/ui/gtk.c > index a5a8156..c15023b 100644 > ---

Re: [Qemu-devel] [PATCH] ui/gtk: Set QEMU window icon

2013-04-11 Thread Jan Kiszka
On 2013-04-11 21:46, Stefan Weil wrote: > Am 10.04.2013 13:48, schrieb Jan Kiszka: >> On 2013-03-30 15:21, Stefan Weil wrote: >>> The QEMU icon which is already used for SDL >>> is now also loaded by GTK. >>> >>> Signed-off-by: Stefan Weil >>>

Re: [Qemu-devel] [qemu-devel] Bug Report: VM crashed for some kinds of vCPU in nested virtualization

2013-04-15 Thread Jan Kiszka
On 2013-04-15 08:24, 李春奇 wrote: > Hi all, > In a nested virtualization environment of qemu+KVM, some emulated CPU (such > as core2duo) may cause L2 guest crash after booting for a while. Here's my > configuration: > > Host: > Linux 3.5.7 You should better use latest version from kvm.git [1], bra

Re: [Qemu-devel] [PATCH 14/19] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE

2013-04-15 Thread Jan Kiszka
On 2013-04-15 17:34, Andreas Färber wrote: > Am 11.04.2013 16:51, schrieb Igor Mammedov: >> ... and put APIC_SPACE_SIZE in public header so that it could be >> reused later elsewhere. >> >> Signed-off-by: Igor Mammedov > > mst or Jan, can one of you please ack or nack? Well, the problem remains

Re: [Qemu-devel] [qemu-devel] Bug Report: VM crashed for some kinds of vCPU in nested virtualization

2013-04-16 Thread Jan Kiszka
On 2013-04-16 05:49, 李春奇 wrote: > I changed to the latest version of kvm kernel but the bug also occured. > > On the startup of L1 VM on the host, the host kern.log will output: > Apr 16 11:28:22 Blade1-02 kernel: [ 4908.458090] kvm [2808]: vcpu0 > unhandled rdmsr: 0x345 > Apr 16 11:28:22 Blade1-

<    4   5   6   7   8   9   10   11   12   13   >