Hey Peter,
I need some advice. I'm adding a -dtb option to qemu for specifying a
dtb filename to be passed on to the kernel, similar to how the -initrd
flag works. The dtb filename needs to then be passed on to the
selected machine, and it looks like the machine->init() callback is
the best way
. Other platforms can easily be added.
Signed-off-by: Jeremy Kerr
[grant.likely: Changed from platform specifying dtb to user option]
[grant.likely: Squashed in initrd and memory property manipulation patches]
Signed-off-by: Grant Likely
Cc: Paul Brook
Cc: Peter Maydell
Cc: Rob Herring
Cc: Edgar
On Fri, Jan 27, 2012 at 10:34:01PM +, Paul Brook wrote:
> > If compiled with CONFIG_FDT, allow user to specify a device tree file using
> > the -dtb argument. If the machine supports it then the dtb will be loaded
> > into memory and passed to the kernel on boot.
>
> Adding annother machine f
On Sun, Jan 29, 2012 at 11:15:42AM +, Paul Brook wrote:
> Clearly we need to have some sort of FDT support. However I'm unconvinced
> that it's the correct format for the primary data structure. For one thing
> it's a hierarchical tree structure, and in my experience describing links
> out
On Sun, Jan 29, 2012 at 07:13:55PM +, Peter Maydell wrote:
> On 29 January 2012 16:01, Grant Likely wrote:
> > diff --git a/configure b/configure
> > index f69e08f..0c2deab 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3411,6 +3411,9 @@ case "$
On Mon, Jan 30, 2012 at 12:36:40PM +0100, Andreas Färber wrote:
> Am 29.01.2012 21:36, schrieb Grant Likely:
> > On Sun, Jan 29, 2012 at 07:13:55PM +, Peter Maydell wrote:
> >> On 29 January 2012 16:01, Grant Likely wrote:
> >>> +DEF("dtb", HAS_ARG,
On Sun, Jan 29, 2012 at 09:29:58PM +, Peter Maydell wrote:
> On 29 January 2012 18:48, Andreas Färber wrote:
> > Am 29.01.2012 17:01, schrieb Grant Likely:
> >> Okay, well at least let's start with this. Here is an updated version of
> >> the
> >>
On Mon, Jan 30, 2012 at 09:54:45AM +1000, Peter Crosthwaite wrote:
> On Mon, Jan 30, 2012 at 6:42 AM, Edgar E. Iglesias > On Sat, Jan 28, 2012 at 11:48:37AM -0700, Grant Likely wrote:
> > > On Fri, Jan 27, 2012 at 10:34:01PM +, Paul Brook wrote:
> Another major issue with
issues
Signed-off-by: Jeremy Kerr
Signed-off-by: Grant Likely
Cc: Paul Brook
Cc: Peter Maydell
Cc: Rob Herring
Cc: Edgar E. Iglesias
---
Makefile.target |1 +
configure |1 +
hw/arm_boot.c | 100 ++
hw/boards.h |1
On Tue, Jan 31, 2012 at 6:44 PM, Alexander Graf wrote:
>
> On 01.02.2012, at 02:35, Paul Brook wrote:
>
>>> We could also just change machine->init() and pass the dtb in there. In a
>>> QOM world these would become machine device properties anyways.
>>>
>>> machine->init(ram_size, boot_devices,
On Wed, 23 Jan 2013 23:45:13 +, Paul Brook wrote:
> > +#ifdef USE_THIS_DEAD_CODE
> > +void mdio_detach(struct qemu_mdio *bus, struct qemu_phy *phy, unsigned int
> > addr) +{
> > +bus->devs[addr & 0x1f] = NULL;
> > +}
> > +#endif
>
> This is clearly wrong.
It's in both versions of the ori
On Thu, 24 Jan 2013 10:09:26 +0100, Andreas Färber wrote:
> Am 23.01.2013 17:15, schrieb Grant Likely:
> > This is a trivial patch to harmonize the coding style on
> > hw/etraxfs_eth.c. This is in preparation to split off the bitbang mdio
> > code into a separate file.
>
Hi Edgar,
Here is one more version of this patch set. I've addressed as many
comments as I could. There is more work to be done, particularly in
moving to the common GPIO api, but that work can be done as a follow on
patch series.
Cheers,
g.
This is a trivial patch to harmonize the coding style on
hw/etraxfs_eth.c. This is in preparation to split off the bitbang mdio
code into a separate file.
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw
Trivial patch to add #defines for defined PHY register address and bit fields
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/mdio.c |8
hw/mdio.h | 24 ++--
2 files changed
thony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/etraxfs_eth.c|2 +-
hw/mdio.c | 14 +++---
hw/mdio.h |2 +-
hw/xilinx_axienet.c |2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c
out also.
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/mdio.c | 16
hw/mdio.h |1 +
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/hw/mdio.c b/hw/mdio.c
index 040ecf6
s
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/Makefile.objs |2 +-
hw/smc91c111.c | 23 ---
2 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index af93dfc..4ec6fb8 100644
---
with GPIO connection in a follow-on patch
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/etraxfs_eth.c | 11 ++---
hw/mdio.c| 134 ++
hw/md
: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/Makefile.objs |2 +-
hw/cris/Makefile.objs |1 +
hw/etraxfs_eth.c | 278 +
hw/mdio.c | 262
The MDIO model needs to have VMState support before it can be used by
devices that support VMState. This patch adds VMState macros for both
qemu_mdio and qemu_phy.
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
On Sat, 2 Feb 2013 23:51:42 +, Peter Maydell
wrote:
> On 2 February 2013 23:40, Grant Likely wrote:
> > static const VMStateDescription vmstate_smc91c111 = {
> > @@ -71,6 +76,8 @@ static const VMStateDescription vmstate_smc91c111 = {
> > VMSTATE_BUFFER_UNSAFE(
ields because this patch
add fields to the state structure.
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/Makefile.objs |2 +-
hw/smc91c111.c | 27 ++-
2 files changed, 23 inser
Hi Peter,
What's the status on this patch? Is it able to be merged?
g.
On Wed, Jul 10, 2013 at 9:16 AM, Grant Likely wrote:
> Sometimes we want to boot the system via firmware instead of loading a
> kernel into ram with the -kernel parameter. This patch makes the -kernel
> para
On Fri, Aug 30, 2013 at 2:12 PM, Andreas Färber wrote:
> Hi,
>
> Am 30.08.2013 12:58, schrieb Grant Likely:
>> Hi Peter,
>>
>> What's the status on this patch? Is it able to be merged?
>
> I had posted a slightly different patch earlier that just returned
>
From: Jeremy Kerr
Signed-off-by: Jeremy Kerr
Cc: Paul Brook
Cc: Peter Maydell
Cc: Rob Herring
Signed-off-by: Grant Likely
---
hw/arm_boot.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/arm_boot.c b/hw/arm_boot.c
index de8f1a4..f2b7332 100644
--- a
l will
> >> never be booted without devicetree and in that case this number is
> >> irrelevant. This is the legacy boot interface and qemu really needs to
> >> learn to boot with a separate dtb.
> >
> > Yeah, but the documentation even for DTB boot says we s
On Fri, Jan 20, 2012 at 01:57:29PM +, Peter Maydell wrote:
> On 20 January 2012 13:48, Rob Herring wrote:
> > Kernel DT co-maintainer is not authoritative enough for you?
>
> Only if I recognise their name :-) [ie, sorry.]
>
> > The documentation needs some clarification.
> >
> >> But this i
On Fri, Jan 20, 2012 at 11:43 AM, Grant Likely
wrote:
> From: Jeremy Kerr
>
> Signed-off-by: Jeremy Kerr
> Cc: Paul Brook
> Cc: Peter Maydell
> Cc: Rob Herring
> Signed-off-by: Grant Likely
Oops, this one won't apply directly since it's build on top of anot
.
Signed-off-by: Grant Likely
Tested-by: Roy Franz
Cc: Peter Maydell
---
hw/arm/vexpress.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
index 67628af58840..80c549caa662 100644
--- a/hw/arm/vexpress.c
+++ b/hw/arm/vexpress.c
@@ -28,6 +28,7
On Tue, 15 Apr 2014 16:46:50 +0100, Peter Maydell
wrote:
> On 28 March 2014 17:57, Grant Likely wrote:
> > Right now to run firmware inside the QEMU VExpress model requires
> > padding out the firmware image to the size of the virtual flash and
> > passing it in via the -pf
On Tue, 15 Apr 2014 16:50:06 +0100, Peter Maydell
wrote:
> On 28 March 2014 17:57, Grant Likely wrote:
> > Right now to run firmware inside the QEMU VExpress model requires
> > padding out the firmware image to the size of the virtual flash and
> > passing it in via the -pf
This series extracts the MDIO bitbang code from the etraxfs driver and
makes it usable on targets using the smc9 Ethernet controller. I've
tested this using u-boot on the versatile-pb model.
net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation
net/bitbang_mdio: Never set PHY RST and
s
Cc: Anthony Liguori
Signed-off-by: Grant Likely
---
hw/Makefile.objs |2 +-
hw/smc91c111.c | 29 +
2 files changed, 26 insertions(+), 5 deletions(-)
diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index 74b07a7..0104fd4 100644
--- a/hw/Makefile.objs
+++
Liguori
Signed-off-by: Grant Likely
---
hw/bitbang_mdio.c | 263 +++
hw/bitbang_mdio.h | 72 +
hw/cris/Makefile.objs |1 +
hw/etraxfs_eth.c | 273 +
4 files changed, 337
: Grant Likely
---
hw/bitbang_mdio.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/bitbang_mdio.c b/hw/bitbang_mdio.c
index f0ee6af..28ac695 100644
--- a/hw/bitbang_mdio.c
+++ b/hw/bitbang_mdio.c
@@ -30,6 +30,10 @@
#define D(x)
/* Advertisement control register
On Sun, 20 Jan 2013 11:29:32 +, Peter Maydell
wrote:
> On 19 January 2013 22:28, Grant Likely wrote:
> > The smc91c111 device has bitbanged MDIO access, but the model doesn't
> > yet implement it. This patch uses the generalized bitbang MDIO support
> > pulled out
On Sun, 20 Jan 2013 18:29:25 +0100, Andreas Färber wrote:
> Am 19.01.2013 23:28, schrieb Grant Likely:
> > The etraxfs Ethernet model implements quite a nice bitbanging core. The
> > change splits it out into a separate .c file. There are no functional
> > changes here, just
On Sun, 20 Jan 2013 18:26:06 +0100, Andreas Färber wrote:
> Am 19.01.2013 23:28, schrieb Grant Likely:
> > This series extracts the MDIO bitbang code from the etraxfs driver and
> > makes it usable on targets using the smc9 Ethernet controller. I've
> > teste
On Mon, 21 Jan 2013 13:51:02 +0100, "Edgar E. Iglesias"
wrote:
> On Sat, Jan 19, 2013 at 06:28:10PM -0400, Grant Likely wrote:
> > The etraxfs Ethernet model implements quite a nice bitbanging core. The
> > change splits it out into a separate .c file. There are no fu
: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/Makefile.objs |2 +-
hw/cris/Makefile.objs |1 +
hw/etraxfs_eth.c | 278 +
hw/mdio.c | 266
This is a trivial patch to harmonize the coding style on
hw/etraxfs_eth.c. This is in preparation to split off the bitbang mdio
code into a separate file.
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw
s
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/Makefile.objs |2 +-
hw/smc91c111.c | 25 +
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index af93dfc..4ec6fb8 100644
---
No need for drivers to open code the check for clock state change. This
patch moves it into the common code.
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
---
hw/etraxfs_eth.c |7 ++-
hw/mdio.c
Hopefully I've responded to everyone's comments here. Edgar, I did end
up fixing up xilinx_axienet, so can you take a look and make sure it is
correct?
Peter, I'm also unsure about the VMState stuff. I think I got it right,
but I've not worked with that code before and I haven't been able to
figur
Färber
Signed-off-by: Grant Likely
---
hw/mdio.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/mdio.c b/hw/mdio.c
index 20d7603..b138efa 100644
--- a/hw/mdio.c
+++ b/hw/mdio.c
@@ -30,6 +30,10 @@
#define D(x)
/* Advertisement control register. */
+#define
The MDIO model needs to have VMState support before it can be used by
devices that support VMState. This patch adds VMState macros for both
qemu_mdio and qemu_phy.
Cc: Peter Maydell
Cc: Paul Brook
Cc: Edgar E. Iglesias
Cc: Anthony Liguori
Cc: Andreas Färber
Signed-off-by: Grant Likely
is
some code for the emulator to execute.
Signed-off-by: Grant Likely
Cc: Peter Maydell
Cc: qemu-devel@nongnu.org
---
hw/arm/boot.c | 47 ++-
1 file changed, 22 insertions(+), 25 deletions(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 7c0090f
: Currently the file must be at least the size of the emulated flash
device (ie 64M for VExpress) otherwise QEMU will silently not use the
data. This will be fixed in a separate patch
v2: just return if the kernel filename isn't provided
Signed-off-by: Grant Likely
Cc: Peter Maydell
Cc: qemu-
On Wed, Jul 10, 2013 at 8:44 AM, Peter Maydell wrote:
> On 10 July 2013 08:33, Grant Likely wrote:
>> Sometimes we want to boot the system via firmware instead of loading a
>> kernel into ram with the -kernel parameter. This patch makes the -kernel
>> parameter optional
el patches
real-soon-now.
This series is based on Jeremy Kerr's device tree branch found here:
git://kernel.ubuntu.com/jk/dt/qemu.git
Cheers,
g.
---
Grant Likely (7):
devicetree: Add fdt_populate hook to smc91x device
devicetree: Add fdt_populate hook to pl011 device
Signed-off-by: Grant Likely
---
device_tree.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/device_tree.c b/device_tree.c
index 426a631..bad4810 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -41,8 +41,8 @@ void *load_device_tree(const char *filename_path,
This patch adds hooks to the qemu device model to auto-generate device
tree nodes from the registered qemu devices, and calls the device tree
populate hook when booting ARM platforms.
Signed-off-by: Grant Likely
---
hw/arm_boot.c |3 ++
hw/qdev.c | 91
This patch adds the qbus_fdt_irq_to_number() helper to determine the
interrupt number and phandle needed for adding the interrupts property
to a device node in the device tree.
Signed-off-by: Grant Likely
---
hw/qdev.c | 48
hw/qdev.h |1
This patch adds sysbus specific fdt_populate hooks to fill sysbus
device nodes with 'reg' and 'interrupts' properties, and to
provide 'ranges' properties for correct address translations.
Signed-off-by: Grant Li
This patch allows simple registration of devices to include a
device tree node populate function.
Signed-off-by: Grant Likely
---
hw/sysbus.c | 15 +++
hw/sysbus.h |2 ++
2 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/hw/sysbus.c b/hw/sysbus.c
index 861572f
Signed-off-by: Grant Likely
---
hw/pl011.c | 29 +
1 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/hw/pl011.c b/hw/pl011.c
index 81de91e..efc06d2 100644
--- a/hw/pl011.c
+++ b/hw/pl011.c
@@ -286,6 +286,27 @@ static int pl011_load(QEMUFile *f, void
Signed-off-by: Grant Likely
---
hw/smc91c111.c | 20
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/hw/smc91c111.c b/hw/smc91c111.c
index b7398c9..300d209 100644
--- a/hw/smc91c111.c
+++ b/hw/smc91c111.c
@@ -721,8 +721,28 @@ static int smc91c111_init1
Thanks for the comments. Replies below...
On Wed, Apr 7, 2010 at 1:10 PM, Blue Swirl wrote:
> On 4/7/10, Grant Likely wrote:
>> Hi everyone,
>>
>> This is an experimental set of patches for populating the flattened
>> device tree (fdt) data from the actual s
On Wed, Apr 7, 2010 at 1:01 AM, Jeremy Kerr wrote:
> Hi Grant,
>
>> This is an experimental set of patches for populating the flattened
>> device tree (fdt) data from the actual set of qdevs in the platform.
>
> Neat. I've pulled these into my qemu tree, and have updated it to the current
> qemu m
Fix bug where temporary buffer for sprintf() was not large enough
when setting a device tree node name.
Signed-off-by: Grant Likely
---
Hi Jeremy. Here's the fix I promised. With this change your current tree
works beautifully. I've pushed out the kernel that works with this QEMU
you have both on-chip and external devices.
Certainly. What would be a good (preferably ARM) platform to look at?
I'm fairly new to working with QEMU, so I'm not very familiar with
the platforms that are available.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
changes the device tree loading code to add a fixed 8k of
>> additional space to the dtb buffer.
>
> In that case you almost certainly want double+8k. Or have the calleee tell you
> how much they're expecting to grow the tree.
Good point. I think I like the latter option.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
cted vi both i2s and gpio based i2c. All these
> should be fairly well qdev-ified.
This looks like a good candidate too then. Getting i2c, spi and gpio
sorted out is higher priority for me right now than pci.
> Arguably the most interesting is the PPC boards as we already know what device
&
64 matches
Mail list logo
