low, but only so many years into the future that it's
beyond our lifetime, so I don't mind leaving it as is.
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ile at a time, but with contents instead
of being a stub (for example, merge patch 1 and 3, and merge patch 2 and
6). It just feels like you have subdivided this series too far.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.
yright notice is a no-no.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
low. Better would be:
if (time_ns < 0 || time_ns / 100 > INT64_MAX - W32_FT_OFFSET) {
error ...
}
time = time_ns / 100 + W32_FT_OFFSET;
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 03/06/2013 11:07 PM, Wenchao Xia wrote:
> Parameter *fmt was not used, so remove it.
>
> Reviewed-by: Eric Blake
>
> Signed-off-by: Wenchao Xia
Typically, these annotations should be kept in chronological order.
That is, the first line should always be a Signed-off-by (yo
an accurate code motion patch. But see my
comments earlier in the series about merging this with 1/20.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
^-//p' patch) <(sed -n 's/^\+//p' patch)
It's okay to have differences (such as 'static void collect_image_info'
becoming exported 'void bdrv_collect_image_info', and to see
reindentation to line up to the new function name), but the differences
should
block layer API.
>
> Signed-off-by: Wenchao Xia
> ---
> block/qapi.c | 52 +
> include/block/qapi.h |4 ++-
> qemu-img.c |4 ++-
> 3 files changed, 45 insertions(+), 15 deletions(-)
Reviewed-by: Eri
it be
smarter to have the function return bool (true for valid vm snapshot,
false if the image snapshot is not usable as a vm snapshot)?
Also, it might be nicer to name it snapshot_valid_for_vm, as in:
if (vm_snapshot && !snapshot_valid_for_vm(...)) {
continue;
}
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
napshot info.
>
> Signed-off-by: Wenchao Xia
> ---
> block/qapi.c | 39 ---
> include/block/qapi.h |7 +++
> qemu-img.c |7 ++-
> 3 files changed, 37 insertions(+), 16 deletions(-)
Reviewed-by: Eric Blake
ing)
> +- "name": internal snapshot name (json-string)
> +- "vm-state-size": size of the VM state in bytes (json-int)
> +- "date-sec": UTC date of the snapshot in seconds (json-int)
> +- "date-nsec": fractional part in nano seconds to be used wi
ld be added?
The copyright of the .c file should be copied to the .h file then.
EVERY file needs a copyright, not just one of a pair of files.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
#x27;iops_rd': 'int', 'iops_wr': 'int',
> +'virtual_size': 'int' } }
I was about to suggest 'virtual-size' instead of 'virtual_size', since
we prefer '-' over '_' in QMP; but since this command has pre-existing
uses of '_', keeping consistency within the struct trumps consistency
with the rest of QMP.
The idea makes sense, and my only complaint was a trivial documentation
matter; so feel free to add this when re-posting without the RFC:
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
tion itself is correct,
without a maintainer chiming in on whether your licensing is appropriate
or needs an adjustment.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
"guest-set-time failed: %d", GetLastError());
> +error_setg_errno(errp, errno, "Failed to set time to guest");
> +return;
> +}
> +}
> +
> int64_t qmp_guest_file_open(const char *path, bool has_mode, const char
> *mode, Error **err)
> {
> error_set(err, QERR_UNSUPPORTED);
>
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
gt; +
> +/*
> * Checks if a buffer is all zeroes
> *
> * Attention! The len must be a multiple of 4 * sizeof(long) due to
oh, probably because of copy and paste.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
return buffer_find_nonzero_offset(buf, len)==len;
> +}
> +
> size_t i;
> long d0, d1, d2, d3;
> const long * const data = buf;
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
cs, memdups and frees
s/unneccssary/unnecessary/
> are saved.
Earlier, I asked you for some benchmark numbers, and you provided some.
Mentioning them in the commit message will make an even stronger
argument for including this patch.
--
Eric Blake eblake redhat com+1-919
instead of magic 8.
> + unsigned long tmp2 =
> + buffer_find_nonzero_offset(p, ((size/BITS_PER_BYTE) &
> ~(8*sizeof(VECTYPE)-1)));
Spaces around binary operators.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t these patches.
>
> Thanks,
> Peter
>
> Peter Lieven (9):
Your patches were not properly threaded, which makes it hard to review
this series.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ot BITS_PER_BYTE or CHAR_BITS its the number of
> vectors in one loop in buffer_find_nonzero_offset(). I will add
> a constant for this to make it clearer.
Indeed, now I see it - 8 is the unroll factor. Well, all the more
evidence that a named constant makes the code easier to read, compared
to
On 03/11/2013 11:01 PM, Wenchao Xia wrote:
> δΊ 2013-3-12 1:49, Eric Blake ει:
>> On 03/11/2013 05:23 AM, Wenchao Xia wrote:
>>>This patch adds block/snapshot.c and then moves the function
>>> there. It also fixes small code style errors reported by check script
tead of having to call two commands to
build up the complete picture.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 03/12/2013 10:15 AM, Eric Blake wrote:
> As far as I can tell, there is nothing wrong with leaving the file as
> BSD licensed instead of trying to insist that it be LGPL. The block
> layer will still be [L]GPL because of other files linked together, but
> there is nothing inherentl
);
> break;
> #endif
> +case CHARDEV_BACKEND_KIND_VC:
> +chr = vc_init(backend->vc);
> +break;
> default:
> error_setg(errp, "unknown chardev backend (%d)", backend->kind);
> break;
>
--
Eric Blake eblake redhat com
what the resolution is for 1/14, you should do the
same thing here.
Everything else looks okay, but I'm reluctant to add reviewed-by without
the license issue sorted.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
bytes_sent += 1;
> } else if (!ram_bulk_stage && migrate_use_xbzrle()) {
> current_addr = block->offset + offset;
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
will be ignored in
> + load_vmstate(). */
> +while ((bs1 = bdrv_next(bs1))) {
> +if (bdrv_can_snapshot(bs1) && bs1 != bs) {
Minor optimization - you could rearrange the conjunct and check 'bs1 !=
bs' first, to avoid the overhead of bdrv_can_snapshot on
p-commands.hx | 55
> ++
> 3 files changed, 87 insertions(+), 0 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
eed, without you
having to add filtering into the qmp code. HMP can do filtering, since
it is supposed to be human-friendly, but I don't see a reason to make
QMP give reduced information.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
str(Visitor *v, char **obj, const char *name, Error **errp);
> void visit_type_number(Visitor *v, double *obj, const char *name, Error
> **errp);
> +void visit_start_carray(Visitor *v, void **obj, const char *name,
> + size_t elem_count, size_t elem_size, Error **err
ommand implementation has already
> been accepted, the reference link:
Series: Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
I want to see data on image.raw, as well as on snapshots a, b, and
c, all in one command. For my example, 'images' would be a
three-element array, with element 0 describing top.qcow2 and its two
internal snapshots, element 1 describing middle.qcow2 and its snapshot,
and element 2 descr
lders. You don't have to ask anyone to exercise it.
Cool - I like that explanation. In that case, my concern has been
answered, and you are free to add:
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
sig
On 03/12/2013 01:41 PM, Eric Blake wrote:
> On 03/11/2013 05:23 AM, Wenchao Xia wrote:
>> This patch adds block/qapi.c and moves the functions there. To avoid
>> conflict and tip better, macro in header file is BLOCK_QAPI_H instead
>> of QAPI_H. The moving is for making
e/block/qapi.h |1 +
> qemu-img.c | 69
> +-
> 3 files changed, 69 insertions(+), 68 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.or
x | 14 ++
> hmp.c| 15 +++
> hmp.h| 1 +
> qapi-schema.json | 11 +++
> qmp-commands.hx | 22 ++
> vl.c | 5 +
> 6 files changed, 68 insertions(+)
Reviewed-by: Eric Blake
--
Eric Bl
}
> + }
> +
> +while (shift >= 0) {
> +buf[2+c] = (val >> shift);
Another case of spaces around binary operator (I didn't look closely, so
you may want to scrub the entire patch for more instances than what I
saw on a casual quick read)
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
gt; +case 0x40:
> +num.mpn.sign = ((number.first & 0x1) != 0);
> +num.mpn.biased_exponent = ~0;
> +num.mpn.mantissa_low = 0;
> +num.mpn.mantissa_high = 0;
> +*obj = num.v_double;
Is this really portable enough? In other words, do we rea
++
> 1 file changed, 8 insertions(+)
> +++ b/MAINTAINERS
> +F: include/qapi/ber*
> \ No newline at end of file
Fix that.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
asking on the libvirt list, be sure to mention what
version of libvirtd is running on nova-compute-lnx001. Meanwhile, when
libvirtd gets in a stuck lock state, you can often restart libvirtd to
get past that point, with no negative consequences to your running qemu
guests.
--
Eric Blake
nstead of size_t for offset; and size_t
instead of int for size (which implies ssize_t for return value)?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 03/14/2013 02:57 AM, Gerd Hoffmann wrote:
> Hi,
>
> v5 if the series, completing the chardev convwersion to qapi.
v4 in subject, v5 in contents - hope Anthony's scripts don't get confused...
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtuali
eader flags that were set when creating the
> image.
Question - how would I get at the lazy_refcounts option when hotplugging
a drive after the fact? In other words, we need to wire up access to
per-format options into QMP, to match what we have done on the command line.
--
Eric Blake eblake
Stefan Hajnoczi
> ---
> block.c | 28
> include/block/block.h | 1 -
> savevm.c | 19 +++
> 3 files changed, 15 insertions(+), 33 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-326
specifying `-device pv-event' in the qemu command
> + line.
> +
> +2. load pvevent device driver in guest OS.
Missing is a sentence stating that the management app then has the
option of waiting for GUEST_PANICKED events, and/or polling for
guest-panicked RunState, to learn when
- do you need to update other locations
(such as BlockJobInfo's @type, and in QMP/qmp-events.txt under
BLOCK_JOB_CANCELLED/BLOCK_JOB_COMPLETED @type) to call out what string
is used for the new job type? For that matter, is it finally time to
introduce a new enum type for all valid block job
time).
The concept is indeed useful; more so if we can wire this into
'transaction' to capture multiple disks at the same point in time.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
f-by: Michael S. Tsirkin
Series: Reviewed-by: Eric Blake
>
> If there are no more comments I'll stick this on my
> pci branch.
Of course, libvirt still has to still add a patch to start using this
event, but I think we have reached a good design, including
consideration for distr
, I didn't know that.
>>
>> Just to make sure: does this automatic removal completion send
>> DEVICE_DELETED events?
>
> With my patch, it does.
Good. That is the best behavior, if libvirt is going to start relying
on the event as a means to avoid polling on all but l
been accepted, the reference link:
>
> http://article.gmane.org/gmane.comp.emulators.qemu/198472
>
> Notes:
> Now It was tested on Windows XP SP3 and Windows 7.
> Please comment!
Series: Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtu
On 03/15/2013 11:17 AM, Corey Bryant wrote:
> Signed-off-by: Corey Bryant
> ---
> qemu-options.hx | 3 ++-
> qmp-commands.hx | 59
> +
> 2 files changed, 61 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
E
, 15 insertions(+), 3 deletions(-)
Series: Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
e (green
> arrow). Is it a bug?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
sb of x.
>>
>> l = 5, we want 4, not 1. Thanks,
>
> It still doesn't require a loop.
>
> l = 1 << (31 - clz32(l));
or even pow2floor() declared in qemu-common.h and implemented in
cutils.c. No need to reinvent what we already have.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
"Invalid release");
As in v1, I'm not a fan of using sscanf for integer parsing (it has
undefined behavior if the user provides a value that overflows the
destination type); but as this is code motion, it does not invalidate my
review.
--
Eric Blake eblake redhat com+1-919-
w still stands. The series looks good to me.
>
> (And I don't have the slightest clue why it hasn't been merged after
> your Reviewed-by; it was posted, and reviewed, and pinged, before the
> hard freeze for 1.6)
I have no idea what happened either.
--
Eric Bla
rmats
when needed; that should land in libvirt before qmeu 1.7, so from that
point of view, I have no objection to this.
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/19/2013 12:33 PM, Mike Day wrote:
Your subject line is atrociously long. Please put a blank line between
the summary (ca. 60 characters or less) and the rest of your commit
message. 'git shortlog -30' will give you a hint on typical summary naming.
--
Eric Blake eblake
changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Shetty
> Signed-off-by: Stefan Hajnoczi
> ---
> util/osdep.c | 19 +++
> 1 file changed, 19 insertions(+)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
se 'local:...' are rejected
unless you first use migrate-set-capabilities to turn on localhost
migration support.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
e question that the behavior is machine-type dependent (-M pc-1.5
behaves differently than -M pc-1.6).
>
> I suggest that this patch be included in an 1.6.1 release as soon as
> possible, and perhaps in the 1.5 branch too.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Paolo Bo
the status quo (the tag is effectively
ignored because without pvpanic device, there is no way for libvirt to
learn if a guest panicked). Or does it mean we expose a new sub-element
of , similar to how we have a subelement that
controls whether the memballoon device is show to the guest, and j
> may be fine, but it doesn't seem very user-friendly.
No less friendly than having a device, and certainly
automatable via libosinfo integration into virt-install.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
permission to create temp files. Does that mean that libvirt still has
to use the long-hand pre-creation rather than this new shorthand?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
', '*writable':
> 'bool'} }
> +{ 'command': 'nbd-server-add', 'data': {'device': 'str', '*writable': 'bool',
> +'*snapshot': 'bool'} }
When documenting the new option,
asty races in unlinking a
just-created file. I'm starting to think Dan's suggestion has merit
after all, if done correctly.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
h myself, nor to care if you end up keeping the split .gitignore,
but if I did care, I'd be consolidating in the opposite direction (move
tests/.gitignore to the toplevel).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
HMP are already capable of converting shorthand
like 1G into proper byte counts for use in QAPI).
> +
> +##
> +# @NumaMemOptions
> +#
> +# Set memory information of guest NUMA node.
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @size: #optional memory size of t
atory (here, and in NumaNodeOptions)?
>
> The defaults are all consistent with original behaviour. If nodeid is
> omitted, the option will be assigned node by node from node0.
What will be assigned? If I omit both nodeid and size, there's nothing
left in the object I'm pas
aped -help output, changing it to use stdout would
be an incompatible change. But now that libvirt uses QMP, I would also
welcome a change to use stdout (but also fall in the category of "not
enough of a bother for ME to fix it).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
tp://thread.gmane.org/gmane.comp.emulators.qemu/225678/focus=225714
My fault for coming into the conversation late, but a note to that
effect in the commit log, and/or in the description of why this type is
listed in the qapi document, would be handy.
--
Eric Blake eblake redhat com+1-919-301-3266
L
rying about guarantees for
synchronous I/O).
But enough of that side diversion - that one #define of O_DIRECT is not
related to the file you are touching. I like the elegance of your patch
(nicer than the race in my double-open attempt).
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/22/2013 01:31 PM, Alex Bligh wrote:
>
>
> --On 22 August 2013 11:57:56 -0600 Eric Blake wrote:
>
>> # define O_DIRECT 0
>>
>> so that the rest of the code can just blindly use open(...,|O_DIRECT)
>> (provided, of course, that not having O_DIRECT semant
ser can add -C as a
synonym for -n (at least, until upstream DOES add a -C with different
semantics), or rewrite their scripts.
I too would like to reuse -n for consistency.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/22/2013 01:41 PM, Laszlo Ersek wrote:
> On 08/22/13 21:19, Paolo Bonzini wrote:
>> Il 22/08/2013 19:15, Laszlo Ersek ha scritto:
2) On all versions, will only work if the element is there.
>>>
>>> I like this, because, if on_crash doesn't work without panic_notifier
>>> *at all*, then w
Peter Maydell
> ---
> slirp/arp_table.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
AG
> definitions to use the ULL suffix rather than LL, though only the
> shift by 63 is undefined behaviour.
>
> Signed-off-by: Peter Maydell
> ---
> block/qcow2.h |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake
B_MASK || env->hflags &
HF_LMA_MASK)
+? "DS " : "DS16");
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
r, 1.6 is already released, so this should now be:
@default #optional string representation of the default used if
the option is omitted (since 1.7).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
can provide better defaults:
>> manufacturer QEMU, product & version taken from QEMUMachine desc and
>> name.
>>
>> Take care to do this only for new machine types, of course.
>>
>> Signed-off-by: Markus Armbruster
>> Reviewed-by: Eric Blake
>
uot;,
> +strerror(errno));
> +return 1;
> +}
> +fd = strtol(argv[2], NULL, 10);
> +if (errno) {
> +fprintf(stderr, "Failed in strtol for fd to send, reason: %s.\n",
> +strerror(errno));
> +r
of using the new format outweigh the pain.
>
> qemu-iotests already runs with compat=1.1 by default.
>
> Signed-off-by: Kevin Wolf
> ---
> block/qcow2.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake
commended max,
or the larger kernel absolute max? Which of the two values does the QMP
'MachineInfo' type return in its 'cpu-max' field during the
'query-machines' command? Should we be modifying QMP to return both
values, so that libvirt can also expose the logic to the
nificant amount of time; please consider adding support for -p
(progress meter) as part of this addition. (I'm already bothered by the
fact that the 'commit' operation lacks a progress meter; and even
'check' might have cases where it could be long-running)
--
Eric Blake eb
implies touching the
stack (because someone, somewhere in the stack, will have good reason
for setting policy different than the lowest layer); fix the maximum
instead, and the whole stack complies without having to worry about
policy. IMO, this is a case where fewer knobs is better.
--
Eric Blak
t would be skipped.
>
> v17->v18:
> 1) print opt->value.uint directly while type is QEMU_OPT_SIZE.
When making a change to a previously-reviewed patch, unrelated to the
reviewer's comments...
>
> Reviewed-by: Eric Blake
> Signed-off-by: Dong Xu Wang
...it is prob
n NULL.
>
> Signed-off-by: Dong Xu Wang
> Reviewed-by: Eric Blake
>
> v13->v14:
> 1) change code style.
> 2) assert errors.
>
> Signed-off-by: Dong Xu Wang
>
> Conflicts:
> util/qemu-option.c
> ---
Awkward. You should never have a 'C
> ##
> { 'command': 'cpu-add', 'data': {'id': 'int'} }
>
> +# @cpu-del
> +
> +# Deletes CPU with specified ID
> +#
> +# @id: ID of CPU to be deleted, valid values [0..max_cpus)
> +#
> +# Returns: Nothing on success
>
fixing)
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ename}. Only the format @code{qcow2} supports this.
We might add support for other file formats in the future; we'd have to
remember to update this sentence at that time. Could you use a more
generic statement, such as "not all file formats support this", so we
don't end up with stale docs if we forget to touch it down the road?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
an error
will at least alert someone to the fact that they need to add some
(potentially complicated) code here?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 08/29/2013 08:00 AM, Paolo Bonzini wrote:
> Eric Blake also requested including the output in qapi-schema.json,
> so that it is published through the introspection mechanism.
>
> Signed-off-by: Paolo Bonzini
> ---
> qapi-schema.json | 29 +
>
Any downstreamers that plans to backport blockdev-add would also
backport this as part of their efforts. I don't see that as any
different from any other backport effort that includes requiring
multiple non-contiguous pre-req patches. We don't need it on the 1.6
stable tree, and do
t; v4: use cache in bdrv_getlength
> block.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
> Reviewed-by: Eric Blake
> Signed-off-by: Paolo Bonzini
Here (and on others in the series where you carried forward a prior
review), the reviewed-by tag is still valid.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signa
On 08/29/2013 08:00 AM, Paolo Bonzini wrote:
> This is more robust when the device has removable media.
>
> Signed-off-by: Paolo Bonzini
> ---
> block.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat
ite loops.
>
> Fix the callers to always look for errors.
>
> Cc: qemu-sta...@nongnu.org
> Reviewed-by: Eric Blake
> Signed-off-by: Paolo Bonzini
> ---
> v4: also fix bdrv_commit, cow_read, img_convert, alloc_f
Hmm - the v4 changelog implies things changed since my rev
601 - 700 of 23401 matches
Mail list logo
