On 03/12/2013 04:07 AM, Stefan Hajnoczi wrote: > On Mon, Mar 11, 2013 at 07:23:02PM +0800, Wenchao Xia wrote: >> In the use of snapshot a way to retrieve related info at runtime is needed, >> so this serial of patches will merge some code for qemu and qemu-img, and add >> following interfaces for qemu: >>
> Is there a reason you added the new query-images command instead of > extending BlockDeviceInfo with an ImageInfo field? Then query-block, > which is already used today, just provides ImageInfo as well. > > I suggest this because it makes life easier for clients - they can issue > a single command to extract all image information. If we have two > commands they may have to invoke both and then match the results > together. Indeed, from the libvirt perspective, I would much prefer that a single command gives me everything, instead of having to call two commands to build up the complete picture. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
