[Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include

2013-04-25 Thread Ed Maste
sys/param.h was included to define __FreeBSD_version, but the conditional using it was removed by commit d05ef160453e98546a4197496dc8a3cb2defac53 (Brad Smith, "Allow clock_gettime() monotonic clock to be utilized on more OS's"), so the include is no longer needed here. Signed-o

Re: [Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include

2013-04-25 Thread Ed Maste
On 25 April 2013 12:59, Peter Maydell wrote: > (Our other use of __FreeBSD_version is preceded by a direct > include of sys/param.h in translate-all.c.) I noticed that one. It's checking for __FreeBSD_version >= 700104, which corresponds to a point in time a little before the 7.1 release. Since

[Qemu-devel] [PATCH] Rename hexdump to avoid FreeBSD libutil conflict

2013-04-25 Thread Ed Maste
On FreeBSD libutil is used for openpty(), but it also provides a hexdump() which conflicts with QEMU's. Signed-off-by: Ed Maste --- hw/dma/pl330.c| 4 ++-- include/qemu-common.h | 2 +- util/hexdump.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/h

Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu

2014-06-17 Thread Ed Maste
On 10 June 2014 01:56, Paolo Bonzini wrote: > From: Michael Tokarev > > Use glib-provided thread primitives in vscclient instead of > qemu ones, and do not use qemu sockets in there (open-code > call to WSAStartup() for windows to initialize things). > > This way, vscclient becomes more stand-alo

Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu

2014-06-17 Thread Ed Maste
On 17 June 2014 13:15, Paolo Bonzini wrote: > Il 17/06/2014 19:10, Ed Maste ha scritto: > >> This change breaks the build on FreeBSD: >> >> libcacard/vscclient.c: In function 'send_msg': >> libcacard/vscclient.c:111: warning: implicit declaration of functi

[Qemu-devel] [PATCH] vscclient: Restore sockets.h include to fix build on FreeBBSD

2014-06-17 Thread Ed Maste
Commit 2a0c46d ("vscclient: use glib thread primitives not qemu") removed #include "qemu/sockets.h", required for socket-related function declarations and constants. Signed-off-by: Ed Maste --- libcacard/vscclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD

2014-06-18 Thread Ed Maste
Signed-off-by: Ed Maste --- libcacard/vscclient.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ab9b2b8..80111df 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -11,6 +11,8 @@ */ #ifndef _WIN32 +#include

Re: [Qemu-devel] [PATCH] vscclient: Restore sockets.h include to fix build on FreeBBSD

2014-06-18 Thread Ed Maste
On 17 June 2014 15:23, Ed Maste wrote: > Commit 2a0c46d ("vscclient: use glib thread primitives not qemu") > removed #include "qemu/sockets.h", required for socket-related function > declarations and constants. Disregard this patch; a replacement has been sent to add the two required headers.

Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD

2014-06-20 Thread Ed Maste
On 18 June 2014 11:22, Andreas Färber wrote: > Am 18.06.2014 16:41, schrieb Paolo Bonzini: >> Il 18/06/2014 14:58, Ed Maste ha scritto: >>> Signed-off-by: Ed Maste >>> --- >>> libcacard/vscclient.c | 2 ++ >>> 1 file changed, 2 insertions(+)

Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version

2014-04-02 Thread Ed Maste
On 11 March 2014 12:13, Dr. David Alan Gilbert wrote: > Except pthread_setname_np is not portable and was previously > ifdef'd _GNU_SOURCE anyway, and the parameters on other OSs > maybe different (freebsd has got a 3rd parameter for no > apparent reason). No, glibc's arguments are identical to

Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0

2014-04-02 Thread Ed Maste
On 2 April 2014 14:52, Richard Henderson wrote: > On 04/02/2014 07:06 AM, Andreas Färber wrote: >> FreeBSD 10.0-RELEASE has bswap16() etc. macros defined in sys/endian.h, >> which leads to a conflict with our static inline definitions. >> >> Force using the system version of the macros. >> >> Sign

[Qemu-devel] Request for volunteer to commit bsd-user patch set

2013-12-29 Thread Ed Maste
On 13 December 2013 07:44, Paolo Bonzini wrote: > > Post the patches. I'll review the non-bsd-user parts again. And then > the next step is to find someone who commits them... shouldn't be hard > since you probably know much more about this code than anyone else. Is someone willing to shepherd

[Qemu-devel] [PATCH] bsd-user: OS-agnostic 64-bit SYSCTL types

2013-04-29 Thread Ed Maste
-user-001). Signed-off-by: Ed Maste --- bsd-user/syscall.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 69e3466..34b8dfc 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -211,10 +211,11 @@ static int

[Qemu-devel] [PATCH v2] bsd-user: OS-agnostic 64-bit SYSCTL types

2013-04-30 Thread Ed Maste
-user-001). Signed-off-by: Ed Maste --- v2: Delete stray : at end of #ifdef conditional bsd-user/syscall.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 69e3466..a4d1583 100644 --- a/bsd-user/syscall.c +++ b/bsd-user

[Qemu-devel] [PATCH] m25p80.c: Sync Flash chip list with Linux

2013-05-01 Thread Ed Maste
, s25fl016k, s25fl064k (These devices have only some blocks that support small erase sizes.) - Linux lacks n25q128 - Devices without a Jedec ID have been excluded Signed-off-by: Ed Maste --- hw/block/m25p80.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH 4/4] usb-host: raise libusbx minimum version to 1.0.13

2013-05-02 Thread Ed Maste
I recently discovered QEMU's libusb support and hoped that this would provide a good solution for the USB host issue on current FreeBSD versions. (Right now the FreeBSD ports tree sets USB_HOST=stub, since the bsd USB code isn't compatible with FreeBSD 8.x and later.) I'm wondering how best to ad

[Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state

2013-05-07 Thread Ed Maste
USB_RET_ASYNC is -6, so inflight was always false. Signed-off-by: Ed Maste --- hw/usb/host-libusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index d1186b8..0af6ce3 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c

[Qemu-devel] [PATCH v2] Rename hexdump to avoid FreeBSD libutil conflict

2013-05-16 Thread Ed Maste
On FreeBSD libutil is used for openpty(), but it also provides a hexdump() which conflicts with QEMU's. Signed-off-by: Ed Maste --- v1->v2: Add hexdump() use in iov.c If desired I can workaround this via #define hacks in qemu-common.h instead; please let me know and I will submit th

[Qemu-devel] Could configure generate QEMU's linker scripts?

2013-05-19 Thread Ed Maste
On 19 May 2013 10:51, in a thread relating to the sparc-linux-user linker script, Michael Tokarev wrote: > If we apply this for 1.5, it will be the first release of debian > package without extra fixes. Hopefully anyway :) > > (Ofcourse we may add more fixes later but... ;) Would it be reasonabl

Re: [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet state

2013-05-21 Thread Ed Maste
On 7 May 2013 10:06, Ed Maste wrote: > USB_RET_ASYNC is -6, so inflight was always false. Ping. I believe the "if (inflight)" block in usb_host_req_abort() can never be executed in the current code. > Signed-off-by: Ed Maste > --- > hw/usb/host-libusb.c | 2 +- > 1

Re: [Qemu-devel] Could configure generate QEMU's linker scripts?

2013-05-21 Thread Ed Maste
On 20 May 2013 13:21, Richard Henderson wrote: > In general I believe that using the -Ttext-segment ADDR flag for ld > would completely obviate the need for even editing the link script. That sounds cleaner, although there's a wrinkle for FreeBSD. We're still using binutils version 2.17.50 in th

[Qemu-devel] [PATCH] configure: remove confusing file manipulation

2013-05-22 Thread Ed Maste
The configure script had some code to manipulate config-host.ld~ (i.e., a common backup filename), comparing it with the newly-generated file. I believe the sense of the comparison was backwards. Since it seemed to serve little purpose anyway, remove it to avoid any confusion. Signed-off-by: Ed

Re: [Qemu-devel] [PATCH v3 01/19] bsd-user: refresh freebsd system call numbers

2014-02-01 Thread Ed Maste
On 27 January 2014 14:30, Peter Maydell wrote: > > though this patch would look much nicer if you hadn't > changed every single line in the file including the > ones for syscalls we already had the #defines for. The new version of this file was generated from the canonical FreeBSD syscall numberi

Re: [Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-12-12 Thread Ed Maste
On 27 November 2013 06:29, Paolo Bonzini wrote: > Il 26/11/2013 22:01, Ed Maste ha scritto: >> On 8 November 2013 11:33, Stacey Son wrote: >>> [v2] >>> >>> - Rebases to 1.7.0-rc0. (Requires, however, Andreas Tobler's patch to >>> build: see >

Re: [Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-11-26 Thread Ed Maste
On 8 November 2013 11:33, Stacey Son wrote: > [v2] > > - Rebases to 1.7.0-rc0. (Requires, however, Andreas Tobler's patch to > build: see > http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg0.html) > - Fixes deadlock in the _umtx_op() system call handler. > - Fixes race condition

Re: [Qemu-devel] [PATCH 01/18] bsd-user: refresh freebsd system call numbers

2013-10-23 Thread Ed Maste
On 16 October 2013 10:36, Stacey Son wrote: > Update FreeBSD system call numbers in freebsd/syscall_nr.h. > > Signed-off-by: Stacey Son Reviewed-by: Ed Maste

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 23 March 2015 at 12:56, John Snow wrote: > My pattern was cyclical every 256 bytes, so it missed a fairly obvious > failure case. Add some rand() pepper into the test pattern, and for large > patterns that exceed 256 sectors, start writing an ID per-sector so that > we never generate identical

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 16:58, John Snow wrote: > > which test case does it fail under? io_rw_simple is shared by a number of > different tests. I'm not sure off hand how to run an individual test to confirm, but the testrun output up to the failure is: LINK tests/spapr-phb-test GTESTER check-qte

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:44, John Snow wrote: > > My apologies; Not at all, thanks for your help! > Head into your build directory and try this: > >> make tests/ahci-test >> export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386 >> export QTEST_QEMU_IMG=./qemu-img >> ./tests/ahci-test > > This sho

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:55, Ed Maste wrote: > > feynman% ./tests/ahci-test > /i386/ahci/sanity: OK > /i386/ahci/pci_spec: OK > /i386/ahci/pci_enable: OK > /i386/ahci/hba_spec: OK > /i386/ahci/hba_enable: OK > /i386/ahci/identify: OK > /i386/ahci/io/pio/lba28/simple: *

[Qemu-devel] [PATCH] Use $(MAKE) for recursive make

2015-04-01 Thread Ed Maste
On BSDs "make" is typically BSD make, while "gmake" is GNU make. Signed-off-by: Ed Maste --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 88bce56..ee40397 100644 --- a/Makefile +++ b/Makefile @@ -331,8 +331,8

[Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-01 Thread Ed Maste
Signed-off-by: Ed Maste --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 12d65bd..54550a8 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -453,6 +453,7 @@ void qtest_qmp_discard_response(QTestState *s, const char *fmt

Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-02 Thread Ed Maste
On 1 April 2015 at 18:45, Peter Maydell wrote: > On 1 April 2015 at 22:14, Paolo Bonzini wrote: >> On 01/04/2015 23:06, John Snow wrote: >>> >>> if (qemu == NULL) { >>> fprintf(stderr, "..."); >>> g_assert_not_reached(); >>> } >>> >>> Though that does read a little strangely. ("Here's a nice

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Put tempfiles in subdir so we can clean up libtool files

2014-05-28 Thread Ed Maste
On 6 May 2014 10:36, Eric Blake wrote: > > mktemp is not POSIX. BSD mktemp lacks -t: > > http://www.freebsd.org/cgi/man.cgi?query=mktemp&apropos=0&sektion=1&manpath=Red+Hat+Linux%2Fi386+9&format=html You managed to link to a mktemp man page for some old Red Hat version there (note the URL); Free

Re: [Qemu-devel] [PATCH] bsd-user/mmap.c: Don't try to override g_malloc/g_free

2014-06-04 Thread Ed Maste
seem to have > further issues. > > Signed-off-by: Peter Maydell Reviewed-by: Ed Maste

[Qemu-devel] [PATCH] io: fix build on FreeBSD

2016-02-25 Thread Ed Maste
EAI_ADDRFAMILY is obsolete and FreeBSD/s netdb.h does not provide a definition. Signed-off-by: Ed Maste --- tests/test-io-channel-socket.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c index 0697363

Re: [Qemu-devel] [PATCH] io: fix build on FreeBSD

2016-02-26 Thread Ed Maste
On 25 February 2016 at 11:41, Daniel P. Berrange wrote: > On Thu, Feb 25, 2016 at 09:37:18AM -0700, Eric Blake wrote: >> >> Oh, right. That's annoying. What about: >> >> #ifndef EAI_ADDRFAMILY >> #define EAI_ADDRFAMILY 0 >> #endif >> >> if ((EAI_ADDRFAMILY && gaierr == EAIADDRFAMILY) || >> ga

[Qemu-devel] [PATCH] configure: try pkg-config ncurses first

2013-05-24 Thread Ed Maste
When probing for ncurses, try pkg-config first rather than after explicit -lncurses and -lcurses. This fixes static linking in the case that ncurses has additional dependencies, such as -ltinfo (as on FreeBSD). Signed-off-by: Ed Maste --- configure | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [Bug 1094786] Re: static build with curses fails if requires -ltinfo

2013-05-24 Thread Ed Maste
** Also affects: freebsd-ports-mirror Importance: Undecided Status: New ** No longer affects: freebsd-ports-mirror -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1094786 Title: static bui

[Qemu-devel] [Bug 1094786] Re: static build with curses fails if requires -ltinfo

2013-05-24 Thread Ed Maste
I ran into the same issue on FreeBSD, and just posted my patch to the qemu-devel list. It's the same solution stefanha describes above. (On FreeBSD we have an additional issue; we don't ship the .pc file with the ncurses port right now. I just hacked one together to include -ltinfo in Libs.priva

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config ncurses first

2013-05-25 Thread Ed Maste
On 25 May 2013 00:25, Michael Tokarev wrote: > 25.05.2013 00:07, Ed Maste wrote: >> When probing for ncurses, try pkg-config first rather than after >> explicit -lncurses and -lcurses. This fixes static linking in the case >> that ncurses has additional dependencies, s

[Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-05-29 Thread Ed Maste
Based on the datasheet at http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf Signed-off-by: Ed Maste --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 759c84d

Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-06-04 Thread Ed Maste
On 4 June 2013 07:31, Peter Crosthwaite wrote: >> /* Micron */ >> +{ INFO("n25q032a",0x20bb16, 0, 64 << 10, 64, ER_4K) }, > > Does this have a11 and a13 variants as well? > >> { INFO("n25q128a11", 0x20bb18, 0, 64 << 10, 256, 0) }, >> { INFO("n25q128a13", 0x20b

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

2013-06-04 Thread Ed Maste
On 20 May 2013 19:09, Peter Maydell wrote: > I'm not sure that's worth the effort at this point when we don't > actually have any targets in tree which aren't enabled by default, > though. (I did cross-check the old and new lists so this patch > isn't accidentally enabling a previously disabled co

[Qemu-devel] [PATCH] block/m25p80: Update Micron entries

2013-06-04 Thread Ed Maste
- Split 32Mb and 256Mb parts into a11 and a13 variants. - Add the 4K sector flag to the 128Mb parts. (These entries were taken from the Linux kernel list, which is missing the flag.) - Fill out the table of sizes with entries for 64Mb parts. Prodded by Peter Crosthwaite. Signed-off-by: Ed

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

2013-06-04 Thread Ed Maste
On 4 June 2013 12:04, Peter Maydell wrote: > You don't need to do this, because there are no config files > in default-configs/ for these, so this patch set will not > change the behaviour for them. Oh, my apologies; I tested the bsd-user WIP at some point in the past, and it seems I have arm- an

[Qemu-devel] [PATCH] configure: Use ${config_host_ld} variable

2013-06-05 Thread Ed Maste
Signed-off-by: Ed Maste --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1654413..ec833df 100755 --- a/configure +++ b/configure @@ -4445,7 +4445,7 @@ fi if test "$ARCH" = "tci"; then linker_script="&quo

Re: [Qemu-devel] [PATCH] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-05 Thread Ed Maste
On 5 June 2013 10:51, Michael Tokarev wrote: > This change removes #including of , > and other rather specific system headers out of qemu-common.h, > which isn't a place for such specific headers really. I needed to add the #include of in qemu-openpty.h in order for this to build on FreeBSD.

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-06-05 Thread Ed Maste
On 5 June 2013 10:04, Anthony Liguori wrote: > > In terms of policy, we should consider buildbot coverage as a > requirement for a platform/architecture to be fully supported. Fully > supported means (1) that code will be rejected/reverted if it breaks one > of these platforms (2) breaking these

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable

2013-06-05 Thread Ed Maste
On 5 June 2013 16:03, Michael Tokarev wrote: > 05.06.2013 19:02, Ed Maste wrote: >> - linker_script="-Wl,-T../config-host.ld >> -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" >> + linker_script="-Wl,-T../${config_host_ld} >> -Wl,-T,\$(SRC_PATH)/ldscripts/

Re: [Qemu-devel] kFreeBSD and USB support

2013-06-05 Thread Ed Maste
On 5 June 2013 16:17, Michael Tokarev wrote: > Hello. > > On debian we, for a long time, used the following hack > in a build script of qemu: > > # Hack alert. qemu-1.3 still needs this. > # On recent kFreebsd, old USB host API has been removed, > # but qemu did not learn to use new USB API. > #

[Qemu-devel] [PATCH] configure: remove ${config_host_ld} variable

2013-06-06 Thread Ed Maste
It was only used in one place (and already expanded in one other). Signed-off-by: Ed Maste --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 1654413..e197b91 100755 --- a/configure +++ b/configure @@ -3556,7 +3556,6 @@ echo "-&

[Qemu-devel] [PATCH] configure: Disable host-bsd USB on FreeBSD

2013-06-06 Thread Ed Maste
It hasn't built since FreeBSD 8.x, and is disabled by a patch in the FreeBSD ports tree. FreeBSD is migrating to QEMU's libusb support. Signed-off-by: Ed Maste --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index e197b9

Re: [Qemu-devel] [PATCH 2/2] usb/host-libusb: Fix building with libusb git master code

2013-06-07 Thread Ed Maste
On 6 June 2013 10:39, Hans de Goede wrote: > +#if LIBUSBX_API_VERSION >= 0x01000102 > +rc = libusb_get_port_numbers(dev, path, 7); > +#else > rc = libusb_get_port_path(ctx, dev, path, 7); > +#endif I just added libusb_get_port_numbers to FreeBSD's libusb, but we don't have LIBUSBX_API_VE

[Qemu-devel] [Bug 830723] Re: bad patch net_h.patch on freebsd ports

2013-06-13 Thread Ed Maste
Does not appear to be an issue any longer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/830723 Title: bad patch net_h.patch on freebsd ports Status in QEMU: New Bug description: work patch fi

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-08 Thread Ed Maste
On 3 July 2013 04:57, Stefan Hajnoczi wrote: > On Tue, Jul 02, 2013 at 09:35:41AM +0200, Christian Berendt wrote: >> On 07/02/2013 09:31 AM, Stefan Hajnoczi wrote: >> >I think the solution is to add another buildmaster administrator. I >> >believe Christian offered that in the past. >> >> Sure. I

[Qemu-devel] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-12 Thread Ed Maste
Signed-off-by: Ed Maste --- The issue comes from slirp/mbuf.h #defining m_flags, which conflicts with a header included via on FreeBSD. I'm not sure exactly when this broke; I assume that it used to work because something previously caused the conflicting header to be included earlier

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-13 Thread Ed Maste
On 13 July 2013 05:12, Michael Tokarev wrote: > Remaining: > > struct mbuf { > union M_dat { > charm_dat_[1]; /* ANSI don't like 0 sized arrays */ > char*m_ext_; > } M_dat; > }; > > #define m_dat M_dat.m_dat_ > #define m_ext

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-17 Thread Ed Maste
On 17 July 2013 04:54, Michael Tokarev wrote: > 17.07.2013 12:32, Jan Kiszka wrote: >> No problem, as Peter already said. Please provide an according patch. > > http://thread.gmane.org/gmane.comp.emulators.qemu/221949/focus=221975 > (an attachtment there) > http://git.corpit.ru/?p=qemu.git;a=comm

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-17 Thread Ed Maste
On 8 July 2013 11:15, Ed Maste wrote: > > Ok, as soon as I can get a password (after the buildbot disk space > issues are sorted out) I'll contribute a FreeBSD 9 amd64 builder. It seems the disk space / inode issue is resolved; is there anything further still in the way of ad

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Ed Maste
On 19 July 2013 05:11, Michael Tokarev wrote: > This is another trivial-patches pull request. This time > we have just 5 patches accumulated in two (!) weeks period. > Please consider apply. ... > Michael Tokarev (2): > slirp: remove mbuf(m_hdr,m_dat) indirection Any idea when this might g

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 2/5] slirp: remove mbuf(m_hdr, m_dat) indirection

2013-07-24 Thread Ed Maste
On 19 July 2013 05:11, Michael Tokarev wrote: > --- > slirp/mbuf.h | 51 ++- > slirp/tcp_subr.c | 12 ++-- > 2 files changed, 24 insertions(+), 39 deletions(-) Tested-by: Ed Maste

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Ed Maste
On 24 July 2013 09:32, Anthony Liguori wrote: > Ed Maste writes: > >> On 19 July 2013 05:11, Michael Tokarev wrote: >>> This is another trivial-patches pull request. This time >>> we have just 5 patches accumulated in two (!) weeks period. >>> Please con

Re: [Qemu-devel] [RFT PATCH] configure: Simplify alternate .text segment

2013-06-19 Thread Ed Maste
On 19 June 2013 14:25, Richard Henderson wrote: > Given the large variance in the true default, I wonder if we shouldn't ignore > it entirely. I wonder if we can't edit more like this: > > s/[.] = .* [+] SIZEOF_HEADERS/. = $textseg_addr + SIZEOF_HEADERS/ Sounds good, although we need to pick u

[Qemu-devel] [RFT PATCH v2] configure: Simplify alternate .text segment

2013-06-20 Thread Ed Maste
ed to edit the default linker script. Note that ldscripts/alpha.ld was already unused prior to this change, as it was handled by the "default placement of the application is fine" case. Signed-off-by: Ed Maste --- Changes from v1: - Drop removal of ldscripts from the patch for now. The

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-06-20 Thread Ed Maste
On 5 June 2013 10:04, Anthony Liguori wrote: > > Hi, > > Below is the coverage we currently have in buildbot. It's not terribly > complete but I suspect it does reflect what people are actually testing > and care about. > > In terms of policy, we should consider buildbot coverage as a > requireme

Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-06-24 Thread Ed Maste
t set the address with -Ttext-segment if supported, or by using sed to > edit the default linker script. > > Cc: Ed Maste > Signed-off-by: Richard Henderson > --- > configure | 48 +++- > 2 files changed, 31 insertions(+),

[Qemu-devel] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-24 Thread Ed Maste
Signed-off-by: Ed Maste --- I have had this in a local tree for some time, and it is needed by the BSD-user work that is now being proposed. As an aside, an abstraction was recently proposed for Open vSwtich that can use any of _Thread_local, __thread, or pthread_getspecific() which may make a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-28 Thread Ed Maste
On 28 June 2013 06:34, Michael Tokarev wrote: > 24.06.2013 23:21, Ed Maste wrote: >> Signed-off-by: Ed Maste >> --- >> I have had this in a local tree for some time, and it is needed by the >> BSD-user work that is now being proposed. > > So I'm not applyi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-28 Thread Ed Maste
On 28 June 2013 09:05, Peter Maydell wrote: > On 28 June 2013 14:03, Paolo Bonzini wrote: >> Il 28/06/2013 14:54, Ed Maste ha scritto: >>> An objection seemed to be that it is not really needed yet, but as >>> pointed out by Peter this isn't really the case. T

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tls.h: Enable TLS on FreeBSD

2013-06-28 Thread Ed Maste
On 28 June 2013 11:11, Paolo Bonzini wrote: > And of course if bsd-user supported 1:1 mapping between guest and host > threads on FreeBSD, cpu_single_env would have to be thread-local. This is the case for the bsd-user work that Stacey posted at the beginning of the week and is currently being re

Re: [Qemu-devel] [PATCH 05/30] exec: do not use qemu/tls.h

2013-06-28 Thread Ed Maste
On 28 June 2013 14:26, Paolo Bonzini wrote: > > +/* This is thread-local depending on __linux__ because: Is the comment perhaps unchanged from an earlier revision that used a different test? It seems odd to me to reference __linux__ here. > + * - the only -user mode supporting multiple VCPU th

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-01 Thread Ed Maste
On 1 July 2013 07:47, Stefan Hajnoczi wrote: > Yes, Christian Berendt admins the buildmaster. How much time has passed > since you emailed? June 7; perhaps the email was lost. I would like to start with a FreeBSD 9.x x86_64 instance, potentially adding i386 and FreeBSD 10-CURRENT to the mix la

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: add TLS wrappers

2013-07-01 Thread Ed Maste
On 1 July 2013 05:35, Stefan Hajnoczi wrote: > From: Paolo Bonzini > > Fast TLS is not available on some platforms, but it is always nice to > use it. This wrapper implementation falls back to pthread_get/setspecific > on POSIX systems that lack __thread, but uses the dynamic linker's TLS > sup

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: add TLS wrappers

2013-07-01 Thread Ed Maste
On 1 July 2013 15:25, Peter Maydell wrote: > Does any OS have a __thread which compiles but is broken, or can > we just have a configure test for this? That would let MacOSX+clang > use __thread. I believe this was recently the case on NetBSD - code with __thread would build, but fail at run time

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-09-09 Thread Ed Maste
On 17 July 2013 20:07, Ed Maste wrote: > On 8 July 2013 11:15, Ed Maste wrote: > > > > Ok, as soon as I can get a password (after the buildbot disk space > > issues are sorted out) I'll contribute a FreeBSD 9 amd64 builder. > > It seems the disk space / i

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-09-18 Thread Ed Maste
amd64)? On 10 September 2013 03:44, Stefan Hajnoczi wrote: > On Mon, Sep 09, 2013 at 02:15:57PM -0400, Ed Maste wrote: >> On 17 July 2013 20:07, Ed Maste wrote: >> >> > On 8 July 2013 11:15, Ed Maste wrote: >> > > >> > > Ok, as soon as I c

[Qemu-devel] [PATCH] tap-bsd: use user-specified tap device if it already exists

2015-10-23 Thread Ed Maste
--- As an aside this was reviewed on FreeBSD's Phabricator here: https://reviews.freebsd.org/D3969 net/tap-bsd.c | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 7028d9b..0103a97 100644 --- a/net/tap-bs

[Qemu-devel] [PATCH] tap-bsd: use user-specified tap device if it already exists

2015-10-23 Thread Ed Maste
Acked-by: Roger Pau Monné Signed-off-by: Ed Maste --- As an aside this was reviewed on FreeBSD's Phabricator here: https://reviews.freebsd.org/D3969 Resend with Signed-off-by. net/tap-bsd.c | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH] bsd-user: add necessary includes to fix warnings

2016-04-04 Thread Ed Maste
Signed-off-by: Ed Maste --- bsd-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 35f784c..47cf865 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -17,6 +17,8 @@ * along with this program; if not, see <h

Re: [Qemu-devel] [PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)

2016-04-04 Thread Ed Maste
On 4 April 2016 at 10:35, Alex Bennée wrote: > Only the first patch has actually changed. Instead of moving the read > inside the write seqlock it is now done using the seqlock_read_* > primitives. > > Build tested on a FreeBSB/i386 VM with these applied: > > https://github.com/berrange/qemu/tre

Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test

2016-04-04 Thread Ed Maste
fine for me. > Thanks! > > Bruce > > Tested-by: Bruce Rogers This fixes one of the three FreeBSD test failures I reported earlier in the thread "[PATCH v2 0/2] Fix for compile on FreeBSD/i386 (and others?)". Tested-by: Ed Maste

Re: [Qemu-devel] [PATCH v2] util: retry getaddrinfo if getting EAI_BADFLAGS with AI_V4MAPPED

2016-04-04 Thread Ed Maste
V4MAPPED > - Don't disable AI_V4MAPPED at build time, detect it >at runtime, so we catch any platform with broken impl This fixes the remaining two of three failures I reported earlier today in 'gmake check' on FreeBSD. Tested-by: Ed Maste

[Qemu-devel] [PATCH] bsd-user: add qemu/cutils.h include after f348b6d

2016-04-05 Thread Ed Maste
Signed-off-by: Ed Maste --- bsd-user/uaccess.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c index 7cb6d17..b7b3a06 100644 --- a/bsd-user/uaccess.c +++ b/bsd-user/uaccess.c @@ -1,5 +1,6 @@ /* User memory access */ #include "qemu/osdep.h"

[Qemu-devel] [PATCH] bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning

2016-04-05 Thread Ed Maste
This is the same change as b55266b5 in linux-user. Signed-off-by: Ed Maste --- bsd-user/uaccess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsd-user/uaccess.c b/bsd-user/uaccess.c index b7b3a06..91e2067 100644 --- a/bsd-user/uaccess.c +++ b/bsd-user/uaccess.c @@ -51,7

Re: [Qemu-devel] [PATCH] bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning

2016-04-05 Thread Ed Maste
On 5 April 2016 at 10:54, Peter Maydell wrote: > On 5 April 2016 at 15:46, Ed Maste wrote: >> This is the same change as b55266b5 in linux-user. >> >> Signed-off-by: Ed Maste > > Do you have many more of these bsd related patches to come? > It might be easie

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-22 Thread Ed Maste
On 15 June 2016 at 06:10, Peter Maydell wrote: > > A quick scan through http://fxr.watson.org/fxr/source/arm64/arm64/gic_v3.c > doesn't seem to show it setting the IGROUPR registers anywhere, > so it probably is a guest bug. (You can use "-d 'trace:gicv3*'" to > enable the tracepoints for the GIC

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-22 Thread Ed Maste
On 22 June 2016 at 16:53, Peter Maydell wrote: > > Yeah, it looks like the same bug is also present in UEFI itself > (it's super popular!). Laszlo, Ard, do you have a prebuilt > UEFI binary with Ard's fix? > > Probably you'll find that if UEFI is configuring the GIC interrupt > groups FreeBSD will

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-23 Thread Ed Maste
On 23 June 2016 at 07:36, Laszlo Ersek wrote: > On 06/22/16 22:53, Peter Maydell wrote: >> On 22 June 2016 at 19:09, Ed Maste wrote: >>> On 15 June 2016 at 06:10, Peter Maydell wrote: >>>> >>>> A quick scan through http://fxr.watson.org/fxr/source/arm6

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

2019-03-07 Thread Ed Maste
On Mon, 4 Mar 2019 at 06:39, Thomas Huth wrote: > > > > Can we get report of failures? (IRC, mail to ML, patchew icon) > > Honestly, I've got no clue ... this is the only help text that I've > found so far: > > https://cirrus-ci.org/guide/notifications/ I asked on twitter and was pointed at that

Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task

2019-03-07 Thread Ed Maste
ine for this operating system here, too. > > > Signed-off-by: Thomas Huth > Reviewed-by: Philippe Mathieu-Daudé Acked-by: Ed Maste

[Qemu-devel] [PATCH] Fix FreeBSD (10.x) build after 7dc9ae43

2016-11-21 Thread Ed Maste
Include sys/user.h for declaration of 'struct kinfo_proc'. Add -lutil to qemu-ga link for kinfo_getproc. Signed-off-by: Ed Maste --- configure | 2 ++ util/oslib-posix.c | 1 + 2 files changed, 3 insertions(+) diff --git a/configure b/configure index 7d2a34e..5e66828 10

[Qemu-devel] [PATCH] bsd-user: fix FreeBSD build after d148d90e

2016-10-04 Thread Ed Maste
Signed-off-by: Ed Maste --- bsd-user/main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index d803d3e..d8367bd 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -695,6 +695,16 @@ static void usage(void) THREAD CPUState *thread_cpu

[Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-22 Thread Ed Maste
Must include "qemu-version.h" for the QEMU_PKGVERSION definition. Signed-off-by: Ed Maste --- bsd-user/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index b4a0a00..0fb08e4 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -

Re: [Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-22 Thread Ed Maste
On 22 August 2016 at 12:20, Peter Maydell wrote: > > Awkward that this missed rc4 by an hour or two :-( Indeed, and I'm sorry that's the case. It wasn't even in the context of the upcoming release that I tried building and stumbled across this - I'm just back after some time away. This is a good

[Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var evaluation

2017-03-30 Thread Ed Maste
cro 'IPMI_BT_SET_HBUSY' (((v & 1) << IPMI_BT_HBUSY_BIT))) ^ ~ Signed-off-by: Ed Maste --- hw/ipmi/isa_ipmi_bt.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/ipmi/

Re: [Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var evaluation

2017-03-30 Thread Ed Maste
On 30 March 2017 at 12:12, Corey Minyard wrote: > This isn't quite right, a lot of these need parenthesis around the whole > thing, and some of the macros are unused and need to be removed. > I had submitted something for this a while ago, but it hadn't been > taken. I will re-submit. Ok, thanks

Re: [Qemu-devel] [PATCH for-2.9? v4] ipmi: Fix macro issues

2017-03-31 Thread Ed Maste
y Minyard > Reviewed-by: Eric Blake Reviewed-by: Ed Maste

[Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2018-12-05 Thread Ed Maste
I'd very much like to have CI coverage for QEMU on FreeBSD, and as of yesterday there's a hosted CI service that supports FreeBSD: Cirrus CI. They also offer free service for OSS projects. I created a .cirrus.yml (shown below) in a QEMU GitHub fork and successfully executed a build test. I can sub

Re: [Qemu-devel] Hosted CI for FreeBSD - Cirrus CI

2018-12-05 Thread Ed Maste
On Wed, 5 Dec 2018 at 15:59, Kamil Rytarowski wrote: > > There are already FreeBSD, OpenBSD and NetBSD test scripts in the qemu > project. I see scripts under tests/vm/ for FreeBSD, NetBSD, and OpenBSD, but they're for testing BSD guests on QEMU, while I'm interested in building and testing QEMU

  1   2   >