On 5 June 2013 16:03, Michael Tokarev <m...@tls.msk.ru> wrote:
> 05.06.2013 19:02, Ed Maste wrote:
>> -  linker_script="-Wl,-T../config-host.ld 
>> -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld"
>> +  linker_script="-Wl,-T../${config_host_ld} 
>> -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld"
>
> Do we really care?  To me it looks like it is better
> to just remove the variable (which is nothing but just
> an extra indirection) and be done with it.

I don't really care one way or another, and am happy to expand the
other uses of it if that's preferred; it just seems odd to me to use
the variable in one spot and the literal filename in another.

(I found this while doing a little cleanup in preparation to avoid use
of the ldscripts/ files on FreeBSD.)

Reply via email to