race condition.
Dmitry Fleytman (2):
Fix a race condition in E1000 device implementation:
Fix a race condition in E1000 device live migration. One of
data-transfer related flags not in migrated fields list.
hw/e1000.c | 25 +++--
1 file changed, 23 insertions(+
Signed-off-by: Dmitry Fleytman
---
hw/e1000.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 1e66ecf..efbe0c9 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -92,7 +92,7 @@ typedef struct E1000State_st {
uint32_t rxbuf_size;
uint32_t
attempt or guest memory gets corrupted.
Reported-by: Chris Webb
Reported-by: Richard Davies
Signed-off-by: Dmitry Fleytman
---
hw/e1000.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 63fee10..1e66ecf 100644
--- a/hw/e1000.c
%3DBck6zSoMQ-9S3ZJo7w%40mail.gmail.com&forum_name=e1000-devel).
We'll submit the final patch soon.
Dmitry.
On Mon, Oct 15, 2012 at 6:48 PM, Dmitry Fleytman wrote:
> Following patches fix a few race conditions in E1000 code:
>
> 1st patch fixes race condition between driver s
th no regressions,
please, take a look.
Dmitry Fleytman (2):
Ignore RX tail kicks when RX disabled.
Add check_rxov into VMState.
hw/e1000.c | 39 +--
1 file changed, 33 insertions(+), 6 deletions(-)
--
1.7.11.4
) and then memory corruption
occures.
Device has to ignore RX tail kicks unless RX enabled.
Reported-by: Chris Webb
Reported-by: Richard Davies
Signed-off-by: Dmitry Fleytman
---
hw/e1000.c | 29 +
1 file changed, 25 insertions(+), 4 deletions(-)
diff --git a/hw/e100
E1000State::check_rxov field must be preserved on live migration.
Signed-off-by: Dmitry Fleytman
---
hw/e1000.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 606bf3a..26ad03c 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -92,7 +92,7
Oops, you are right :)
On Thu, Oct 18, 2012 at 9:24 AM, Stefan Hajnoczi wrote:
> On Wed, Oct 17, 2012 at 08:31:47PM +0200, Dmitry Fleytman wrote:
>> @@ -1100,6 +1100,11 @@ static bool is_version_1(void *opaque, int version_id)
>> return version_id == 1;
>> }
>>
&
= 1 and RDH == RDT == 0.
>
> BTW the Linux e1000 driver does not follow the sequence recommended in
> the datasheet 14.4 Receive Initialization, which would avoid the weird
> window of time where RDH == RDT == 0.
>
> If we get rid of check_rxov and always check rxbuf space then we
abort();
[...]
}
Thanks for review,
Dmitry.
On Thu, Oct 18, 2012 at 9:31 AM, Stefan Hajnoczi wrote:
>
> On Wed, Oct 17, 2012 at 08:31:46PM +0200, Dmitry Fleytman wrote:
> > Device RX initization from driver's side consists of following steps:
> > 1. Initialize head
12 at 10:34 AM, Dmitry Fleytman wrote:
>>> The real purpose of check_rxov it a bit confusing indeed, mainly
>>> because of unclear name (rename?),
>>> however it works as following:
>>>
>>> There are 2 possible when RDT == RDH for RX ring:
>>>
got deleted
Also I've made short experiment with an Intel adapter controlled by e1000e
driver.
Indeed I saw no RX indication attempt when RX ring's RDH and RDT are equal.
Dmitry Fleytman (1):
Drop check_rxov, always treat RX ring with RHD == RDT as empty
hw/e1000.c | 7 ++-
1 fi
Real HW always treats RX ring with RDH == RDT as empty.
Emulation is supposed to behave the same.
Reported-by: Chris Webb
Reported-by: Richard Davies
Signed-off-by: Dmitry Fleytman
---
hw/e1000.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000
Thanks, Peter
I'll resend the patch.
Sent from my iPad
On Oct 18, 2012, at 9:20 PM, Peter Maydell wrote:
> On 18 October 2012 19:59, Dmitry Fleytman wrote:
>> Real HW always treats RX ring with RDH == RDT as empty.
>> Emulation is supposed to behave the same.
>
>
patch (live migration) dropped because corresponding field got deleted
Also I've made short experiment with an Intel adapter controlled by e1000e
driver.
Indeed I saw no RX indication attempt when RX ring's RDH and RDT are equal.
Dmitry Fleytman (1):
e1000: drop check_rxov, always tre
Real HW always treats RX ring with RDH == RDT as empty.
Emulation is supposed to behave the same.
Reported-by: Chris Webb
Reported-by: Richard Davies
Signed-off-by: Dmitry Fleytman
---
hw/e1000.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000
Thanks Stefan,
It was my very first idea to drop check_rxov and solve the problem,
however for some reason I was sure that it required to emulate real HW behavior.
I'm glad we clarified this.
Regards,
Dmitry Fleytman
On Fri, Oct 19, 2012 at 9:52 AM, Stefan Hajnoczi wrote:
> On Fri
Adding utility function net_raw_checksum() that calculates checksum
of buffer given
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
net/checksum.c | 13 +++--
net/checksum.h | 14 +-
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/net
by Michael S. Tsirkin
Reported-by: Michael S. Tsirkin
Patches regrouped as suggested by Paolo Bonzini
Reported-by: Paolo Bonzini
Changes in V4:
Fixed a few problems uncovered by NETIO test suit
Assertion on failure to initialize MSI/MSI-X replaced with warning
message and fallbac
Signed-off-by: Dmitry Fleytman
---
hw/vmxnet_pkt.c | 758
hw/vmxnet_pkt.h | 309 +++
2 files changed, 1067 insertions(+)
create mode 100644 hw/vmxnet_pkt.c
create mode 100644 hw/vmxnet_pkt.h
diff --git a/hw
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
iov.h | 5 +
net/checksum.c | 28
net/checksum.h | 8
3 files changed, 41 insertions(+)
diff --git a/iov.h b/iov.h
index 34c8ec9..c184a80 100644
--- a/iov.h
+++ b/iov.h
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 143 +++
hw/vmxnet_debug.h | 121 +++
hw/vmxnet_utils.c | 219 +++
hw/vmxnet_utils.h | 340
Hi Everyone
Is there any progress with these patches?
Is there a chance they will be committed any time soon?
Thanks,
Dmitry
On Fri, Dec 7, 2012 at 1:15 PM, Dmitry Fleytman wrote:
> This set of patches implements VMWare VMXNET3 paravirtual NIC device.
> The device supports of all the
Stefan,
Is there any else needs to be done in order to get these patches committed?
Thanks,
Dmitry.
On Wed, Jan 23, 2013 at 7:30 AM, Dmitry Fleytman wrote:
> This set of patches implements VMWare VMXNET3 paravirtual NIC device.
> The device supports of all the device features inc
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 143 ++
hw/vmxnet_debug.h | 115 ++
include/net/eth.h | 347 ++
net/Makefile.objs | 1 +
net/eth.c | 217
net_checksum_add_cont()
checksum calculation for scattered data with odd chunk sizes
net_raw_checksum()
checksum calculation for a buffer
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 14 +-
net/checksum.c | 13 +++--
2
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/Makefile.objs | 1 +
hw/vmxnet_rx_pkt.c | 187 ++
hw/vmxnet_rx_pkt.h | 174
hw/vmxnet_tx_pkt.c | 567 +
hw/vmxnet_tx_pkt.h | 148
-by: Michael S. Tsirkin
Patches regrouped as suggested by Paolo Bonzini
Reported-by: Paolo Bonzini
Changes in V4:
Fixed a few problems uncovered by NETIO test suit
Assertion on failure to initialize MSI/MSI-X replaced with warning
message and fallback to Legacy/MSI r
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 8
net/checksum.c | 28
2 files changed, 36 insertions(+)
diff --git a/include/net/checksum.h b/include/net/checksum.h
index 3e7b93d..b1cf18a 100644
--- a
Done.
On Thu, Feb 21, 2013 at 12:47 PM, Stefan Hajnoczi wrote:
> Hi Dmitry,
> The net multiqueue feature went into QEMU 1.4 and conflicts with vmxnet3.c.
>
> Please post a rebased version onto qemu.git/master so vmxnet3 can be
> merged. I'm currently getting the following compiler errors with
>
er wrote:
> > Am 25.02.2013 21:11, schrieb Dmitry Fleytman:
> [...]
> > > diff --git a/include/net/checksum.h b/include/net/checksum.h
> > > index 3e7b93d..b1cf18a 100644
> > > --- a/include/net/checksum.h
> > > +++ b/include/net/checksum.h
>
Thanks Andreas,
fixed.
On Mon, Feb 25, 2013 at 10:37 PM, Andreas Färber wrote:
> Am 25.02.2013 21:11, schrieb Dmitry Fleytman:
> > Signed-off-by: Dmitry Fleytman
> > Signed-off-by: Yan Vugenfirer
> > ---
> > include/net/checksum.h | 8
>
at was the proper convention that days.
Anyway, I've fixed almost everything you've pointed out. See below my
comments on specific issues.
On Tue, Feb 26, 2013 at 12:05 AM, Andreas Färber wrote:
> Am 25.02.2013 21:11, schrieb Dmitry Fleytman:
> [snip]
> > +static int
&g
net_checksum_add_cont()
checksum calculation for scattered data with odd chunk sizes
net_raw_checksum()
checksum calculation for a buffer
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 14 +-
net/checksum.c | 13 +++--
2
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 12
net/checksum.c | 29 +
2 files changed, 41 insertions(+)
diff --git a/include/net/checksum.h b/include/net/checksum.h
index 3e7b93d..80203fb 100644
laced with warning
message and fallback to Legacy/MSI respectively
Reported-by: Gerhard Wiesinger
Various coding style adjustments and patch split-up as suggested by Anthony
Liguori
Reported-by: Anthony Liguori
Live migration support added
Changes in V3:
Fixed
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/Makefile.objs | 1 +
hw/vmxnet_rx_pkt.c | 187 ++
hw/vmxnet_rx_pkt.h | 174
hw/vmxnet_tx_pkt.c | 567 +
hw/vmxnet_tx_pkt.h | 148
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 143 ++
hw/vmxnet_debug.h | 115 ++
include/net/eth.h | 347 ++
net/Makefile.objs | 1 +
net/eth.c | 217
:28 PM, Stefan Hajnoczi wrote:
> On Sat, Mar 02, 2013 at 02:44:39PM +0200, Dmitry Fleytman wrote:
> > diff --git a/hw/vmxnet3.h b/hw/vmxnet3.h
> > new file mode 100644
> > index 000..22787b1
> > --- /dev/null
> > +++ b/hw/vmxnet3.h
> > @@ -0,0 +1,760
net_checksum_add_cont()
checksum calculation for scattered data with odd chunk sizes
net_raw_checksum()
checksum calculation for a buffer
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 14 +-
net/checksum.c | 13 +++--
2
4:
Fixed a few problems uncovered by NETIO test suit
Assertion on failure to initialize MSI/MSI-X replaced with warning
message and fallback to Legacy/MSI respectively
Reported-by: Gerhard Wiesinger
Various coding style adjustments and patch split-up as suggested by Anthony
Lig
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 143 ++
hw/vmxnet_debug.h | 115 ++
include/net/eth.h | 347 ++
net/Makefile.objs | 1 +
net/eth.c | 217
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/Makefile.objs | 1 +
hw/vmxnet_rx_pkt.c | 187 ++
hw/vmxnet_rx_pkt.h | 174
hw/vmxnet_tx_pkt.c | 567 +
hw/vmxnet_tx_pkt.h | 148
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 12
net/checksum.c | 29 +
2 files changed, 41 insertions(+)
diff --git a/include/net/checksum.h b/include/net/checksum.h
index 3e7b93d..80203fb 100644
Stefan,
I've sent V13 of patches with license changed.
Dmitry.
On Mon, Mar 4, 2013 at 4:52 PM, Dmitry Fleytman wrote:
> Oops, forgot to address this part...
>
> Is it enough to make following change:
>
> - * This work is licensed under the terms of the GNU GPL,
No problem.
On Wed, Mar 6, 2013 at 11:26 AM, Stefan Hajnoczi wrote:
> On Wed, Mar 06, 2013 at 09:24:35AM +0200, Dmitry Fleytman wrote:
> > I've sent V13 of patches with license changed.
>
> Thanks for resending. I'm happy to do trivial fixups while merging but
> I
Thanks, Andreas
Now I see.
We'll resubmit our patches soon.
Dmitry.
On Thu, Mar 7, 2013 at 2:59 PM, Andreas Färber wrote:
> Am 06.03.2013 08:21, schrieb Dmitry Fleytman:
> > Signed-off-by: Dmitry Fleytman
> > Signed-off-by: Yan Vugenfirer
> > ---
> >
ported-by: Paolo Bonzini
Changes in V4:
Fixed a few problems uncovered by NETIO test suit
Assertion on failure to initialize MSI/MSI-X replaced with warning
message and fallback to Legacy/MSI respectively
Reported-by: Gerhard Wiesinger
Various coding style adjustment
net_checksum_add_cont()
checksum calculation for scattered data with odd chunk sizes
net_raw_checksum()
checksum calculation for a buffer
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 14 +-
net/checksum.c | 13 +++--
2
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 143 ++
hw/vmxnet_debug.h | 115 ++
include/net/eth.h | 347 ++
net/Makefile.objs | 1 +
net/eth.c | 217
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/Makefile.objs | 1 +
hw/vmxnet_rx_pkt.c | 187 ++
hw/vmxnet_rx_pkt.h | 174
hw/vmxnet_tx_pkt.c | 567 +
hw/vmxnet_tx_pkt.h | 148
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
include/net/checksum.h | 12
net/checksum.c | 29 +
2 files changed, 41 insertions(+)
diff --git a/include/net/checksum.h b/include/net/checksum.h
index 3e7b93d..80203fb 100644
On Thu, Apr 18, 2013 at 1:54 PM, Paolo Bonzini wrote:
> Il 18/04/2013 11:38, Dmitry Fleytman ha scritto:
> >
> > > +static void
> > > +pvscsi_free_queue(PVSCSIRequestList *req_list)
> >
> > This shouldn't be needed.
> >
> >
>
: Paolo Bonzini
Dmitry Fleytman (1):
VMWare PVSCSI paravirtual device implementation
default-configs/pci.mak|1 +
docs/specs/pvscsi-spec.txt | 92
hw/Makefile.objs |1 +
hw/pci/pci.h |1 +
hw/pvscsi.c| 1194
Hello All,
Any news regarding this patch?
Thanks,
Dmitry
On Sun, Apr 7, 2013 at 9:34 AM, Dmitry Fleytman wrote:
> From: Dmitry Fleytman
>
> This patch implements recently accepted by virtio-spec
> dynamic offloads configuration feature.
> See commit message for details.
Paolo, thanks for review.
Regarding the change - it's ok with me, but why do one needs this? I think
we always set proper status before request cancellation.
May QEMU call cancel callback on its own?
Dmitry.
On Fri, Apr 19, 2013 at 10:37 AM, Paolo Bonzini wrote:
> Il 19/04/2013 09:05
I see.
Thanks.
On Fri, Apr 19, 2013 at 10:58 AM, Paolo Bonzini wrote:
> Il 19/04/2013 09:53, Dmitry Fleytman ha scritto:
> > Paolo, thanks for review.
> >
> > Regarding the change - it's ok with me, but why do one needs this? I
> > think we always set proper st
Spec patch already inside.
Sent from my iPad
On Apr 20, 2013, at 8:04 PM, "Michael S. Tsirkin" wrote:
> On Fri, Apr 19, 2013 at 10:10:01AM +0300, Dmitry Fleytman wrote:
>> Hello All,
>>
>> Any news regarding this patch?
>>
>> Thanks,
>> Dmitr
> generally.
Hi Michael,
I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me.
I think this patch is correct and needed.
As we saw a few times already on different operating systems,
vmware drivers expect short packets to be padded as required
by corresponding RFC
On Aug 24, 2014, at 16:10 PM, Michael Tokarev wrote:
> 24.08.2014 16:28, Dmitry Fleytman wrote:
>
>> Hi Michael,
>>
>> I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me.
>
> Maybe you can add yourself to MAINTAINERS file as well? :)
Ye
Signed-off-by: Dmitry Fleytman
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 59940f9..1b3e2be 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -678,6 +678,12 @@ S: Maintained
F: hw/*/xilinx_*
F: include/hw/xilinx.h
+Vmware
+M: Dmitry
ACK
Thanks for fixing.
On May 19, 2014, at 16:47 PM, Jiri Pirko wrote:
> In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with
> VMXNET3_MAX_INTRS. That is not correct since vector of
> value VMXNET3_MAX_INTRS was never used. Also all the used vectors
> are not un-used. So call vm
> On 29 באוג 2014, at 19:24, Michael Tokarev wrote:
>
> Applied to -trivial, dunno if it'll be picked up by anyone else ;)
This patch is pretty trivial indeed ;)
>
> Thank you!
>
> /mjt
Ubuntu 10.4
Centos 6.2
Windows 2008R2
Windows 2008 64bit
Windows 2008 32bit
Windows 2003 64bit
Windows 2003 32bit
Dmitry Fleytman (5):
Utility function strpadcpy() added
Vendor name and product name parameters for SCSI devices Options
"vendor_name
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
cutils.c | 13 +
qemu-common.h |1 +
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/cutils.c b/cutils.c
index af308cd..0df7fdf 100644
--- a/cutils.c
+++ b/cutils.c
@@ -27,6 +27,19
Sample command line for pvscsi-based disk is:
-drive file=image.raw,if=none,cache=off,id=pvscsi1 \
-device pvscsi,id=pvscsi -device scsi-disk,drive=pvscsi1,bus=pvscsi.0 \
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
Makefile.objs |1 +
blockdev.c
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 122 +
1 files changed, 122 insertions(+), 0 deletions(-)
create mode 100644 hw/vmware_utils.h
diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h
new file
Sample command line is:
-drive file=image.raw,if=none,cache=off,id=scsi1 \
-device lsi,id=scsi -device
scsi-disk,drive=scsi1,bus=scsi.0,product_name="VENDOR SCSI
DISK",vendor_name="[VENDOR]" \
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
b
cases when net device that is used as
network fronted has no virtio HDR support.
Reported-by: Gerhard Wiesinger
Changes in V2:
License text changed accoring to community suggestions
Standard license header from GPLv2+ - licensed QEMU files used
Dmitry Fleytman (9):
Adding missing
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
iov.c | 29 +
iov.h |3 +++
2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/iov.c b/iov.c
index 0f96493..5d4f94c 100644
--- a/iov.c
+++ b/iov.c
@@ -16,6 +16,7 @@
*/
#include
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/virtio-net.h | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/virtio-net.h b/hw/virtio-net.h
index 4468741..fa3c17b 100644
--- a/hw/virtio-net.h
+++ b/hw/virtio-net.h
@@ -78,13 +78,14
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
Makefile.objs |1 +
default-configs/pci.mak |1 +
hw/pci.c|2 ++
hw/pci.h|1 +
net.c |2 +-
5 files changed, 6 insertions(+), 1 deletions(-)
diff
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmxnet_debug.h | 121
hw/vmxnet_utils.c | 165 +++
hw/vmxnet_utils.h | 320 +
3 files changed, 606 insertions(+), 0 deletions
Avi,
We are considering this option as well...
Dmitry Fleytman.
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmxnet_pkt.c | 1243 +++
hw/vmxnet_pkt.h | 479 +
2 files changed, 1722 insertions(+), 0 deletions(-)
create mode 100644 hw/vmxnet_pkt.c
create mode
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/pci.c|5 +
hw/virtio-pci.c |2 --
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index bf046bf..9146d3f 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -31,6 +31,7 @@
#include
Adding utility function net_raw_checksum() that calculates checksum
of buffer given
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
net/checksum.c | 13 +++--
net/checksum.h | 14 +-
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/net
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 122 +
1 files changed, 122 insertions(+), 0 deletions(-)
create mode 100644 hw/vmware_utils.h
diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h
new file
Michael,
Great. I believe higher level API if what really needed here.
I'll revert this patch and move msix_load/store invocations into the
device code.
Thanks.
On Fri, Mar 16, 2012 at 1:00 AM, Michael S. Tsirkin wrote:
> On Thu, Mar 15, 2012 at 11:09:03PM +0200, Dmitry Fleytm
Good point. Fixed. Thanks.
On Thu, Mar 15, 2012 at 11:46 AM, Paolo Bonzini wrote:
> Il 15/03/2012 10:02, Dmitry Fleytman ha scritto:
>> Sample command line for pvscsi-based disk is:
>> -drive file=image.raw,if=none,cache=off,id=pvscsi1 \
>> -device pvscsi,id=pvs
laced with your one.
On Thu, Mar 15, 2012 at 11:53 AM, Paolo Bonzini wrote:
> Il 15/03/2012 10:02, Dmitry Fleytman ha scritto:
>> Signed-off-by: Dmitry Fleytman
>> Signed-off-by: Yan Vugenfirer
>> ---
>> cutils.c | 13 +
>> qemu-common.h | 1
On Thu, Mar 15, 2012 at 11:56 AM, Paolo Bonzini wrote:
> Il 15/03/2012 10:02, Dmitry Fleytman ha scritto:
>> Signed-off-by: Dmitry Fleytman
>> Signed-off-by: Yan Vugenfirer
>> ---
>> hw/vmware_utils.h | 122
>> +
Unused stuff cleaned out.
On Thu, Mar 15, 2012 at 11:55 AM, Paolo Bonzini wrote:
> Il 15/03/2012 10:02, Dmitry Fleytman ha scritto:
>> Sample command line is:
>>
>> -drive file=image.raw,if=none,cache=off,id=scsi1 \
>> -device lsi,id=scsi -device
>>
Fixed.
On Fri, Mar 16, 2012 at 1:35 PM, Paolo Bonzini wrote:
> Il 15/03/2012 22:09, Dmitry Fleytman ha scritto:
>> Signed-off-by: Dmitry Fleytman
>> Signed-off-by: Yan Vugenfirer
>> ---
>> Makefile.objs | 1 +
>> default-configs/pci.mak | 1 +
&
Ubuntu 10.4
Centos 6.2
Windows 2008R2
Windows 2008 64bit
Windows 2008 32bit
Windows 2003 64bit
Windows 2003 32bit
Changes in V2:
Various fixes and beautification as suggested by Paolo Bonzini
Reported-by: Paolo Bonzini
Dmitry Fleytman (4):
Utility function
Sample command line is:
-drive file=image.raw,if=none,cache=off,id=scsi1 \
-device lsi,id=scsi -device
scsi-disk,drive=scsi1,bus=scsi.0,product_name="VENDOR SCSI
DISK",vendor_name="[VENDOR]" \
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
h
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 126 +
1 files changed, 126 insertions(+), 0 deletions(-)
create mode 100644 hw/vmware_utils.h
diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h
new file
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
cutils.c |7 +++
qemu-common.h |1 +
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/cutils.c b/cutils.c
index af308cd..3ccf45c 100644
--- a/cutils.c
+++ b/cutils.c
@@ -27,6 +27,13 @@
#include
no virtio HDR support.
Reported-by: Gerhard Wiesinger
Changes in V2:
License text changed accoring to community suggestions
Standard license header from GPLv2+ - licensed QEMU files used
Dmitry Fleytman (7):
Adding missing flag VIRTIO_NET_HDR_F_DATA_VALID from Linux kernel
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/virtio-net.h | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/virtio-net.h b/hw/virtio-net.h
index 4468741..fa3c17b 100644
--- a/hw/virtio-net.h
+++ b/hw/virtio-net.h
@@ -78,13 +78,14
Adding utility function net_raw_checksum() that calculates checksum
of buffer given
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
net/checksum.c | 13 +++--
net/checksum.h | 14 +-
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/net
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmxnet_pkt.c | 1243 +++
hw/vmxnet_pkt.h | 479 +
2 files changed, 1722 insertions(+), 0 deletions(-)
create mode 100644 hw/vmxnet_pkt.c
create mode
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmware_utils.h | 126 +
1 files changed, 126 insertions(+), 0 deletions(-)
create mode 100644 hw/vmware_utils.h
diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h
new file
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/vmxnet_debug.h | 121
hw/vmxnet_utils.c | 165 +++
hw/vmxnet_utils.h | 320 +
3 files changed, 606 insertions(+), 0 deletions
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
iov.c | 29 +
iov.h |3 +++
2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/iov.c b/iov.c
index 0f96493..5d4f94c 100644
--- a/iov.c
+++ b/iov.c
@@ -16,6 +16,7 @@
*/
#include
Hello, Gerhard
I've rechecked SSH connection both incoming and outgoing with patch v5.
Everything works fine.
If you still see problems, please, provide your exact configuration.
Thanking you for your support,
Dmitry Fleytman.
On Sun, Mar 18, 2012 at 10:29 AM, Gerhard Wiesinger
wrote:
&g
evice just falls back to MSI interrupts,
but anyway, why does it fail? Could it be some QEMU/KVM versions
incompartibility?
Best regards,
Dmitry Fleytman.
On Mon, Mar 19, 2012 at 9:24 PM, Gerhard Wiesinger wrote:
> Hello Dmitry,
>
> Tried also v5 patch without success:
> /root/downl
Hello, Anthony
Thanks for you comments, see inline.
On Mon, Apr 16, 2012 at 11:06 PM, Anthony Liguori wrote:
> On 03/18/2012 04:27 AM, Dmitry Fleytman wrote:
>>
>> Signed-off-by: Dmitry Fleytman
>> Signed-off-by: Yan Vugenfirer
>> ---
From: Dmitry Fleytman
This set of patches implements VMWare VMXNET3 paravirtual NIC device.
The device supports of all the device features including offload capabilties,
VLANs and etc.
The device is tested on different OSes:
Fedora 15
Ubuntu 10.4
Centos 6.2
Windows 2008R2
From: Dmitry Fleytman
Signed-off-by: Dmitry Fleytman
Signed-off-by: Yan Vugenfirer
---
hw/virtio-net.h | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/virtio-net.h b/hw/virtio-net.h
index 4468741..fa3c17b 100644
--- a/hw/virtio-net.h
+++ b/hw/virtio
1 - 100 of 421 matches
Mail list logo
