[Qemu-devel] [Bug 1268279] [NEW] Windows 7 x86 does not start on 1.7.50 from git

2014-01-12 Thread Dmitry
Public bug reported: I have "Debian 7.2 x64". Install last QEMU from git: aptitude install git gcc make autoconf libglib2.0-dev libcurl4-gnutls- dev libpixman-1-dev libcap-dev libaio-dev libcap-ng-dev libjpeg8-dev libpng12-dev libssh2-1-dev uuid-dev #cd /usr/src #git clone git://git.qemu.org/q

[Qemu-devel] [Bug 1268279] Re: Windows 7 x86 does not start on 1.7.50 from git

2014-01-12 Thread Dmitry
** Description changed: I have "Debian 7.2 x64". Install last QEMU from git: aptitude install git gcc make autoconf libglib2.0-dev libcurl4-gnutls- dev libpixman-1-dev libcap-dev libaio-dev libcap-ng-dev libjpeg8-dev libpng12-dev libssh2-1-dev uuid-dev #cd /usr/src #git clo

[Qemu-devel] [Bug 1268279] Re: Windows 7 x86 does not start on 1.7.50 from git

2014-01-12 Thread Dmitry
** Tags added: windows -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1268279 Title: Windows 7 x86 does not start on 1.7.50 from git Status in QEMU: New Bug description: I have "Debian 7.2 x64

Re: [Qemu-devel] [Bug 1268279] Re: Windows 7 x86 does not start on 1.7.50 from git

2017-11-07 Thread Dmitry
Ticket have to been closed 2017-10-28 16:54 GMT+03:00 Thomas Huth <1268...@bugs.launchpad.net>: > Triaging old bug tickets... can you still reproduce this issue with the > latest version of QEMU? Or could we close this ticket nowadays? > > ** Changed in: qemu >Status: New => Incomplete >

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
BTW, before "sudo bash -c "echo -1 > /proc/sys/fs/binfmt_misc/qemu- s390x" njs-s390 also works on the host: $ ./njs-s390 -c 'console.log("hello")' hello $ file njs-s390 njs-s390: ELF 64-bit MSB executable, IBM S/390, version 1 (GNU/Linux), statically linked, BuildID[sha1]=e37618578fb0a8c60f4268

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
@langston0 Thanks for detailed explanation, got the same problem for qemu-s390. The way to reproduce (linux kernel >= 4.8, for example: Ubuntu 18.04): # Register qemu binfmt_misc handlers $ docker run --rm --privileged multiarch/qemu-user-static --reset -p yes $ cat Dockerfile.s390x FROM s390x/

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
> runs just fine on top of the Linux kernel in QEMU full-system emulation, but crashes before main in user-mode emulation So it seems system vs user-mode is not the issue here, probably it is related to gdb mode in user-mode qemu. -- You received this bug notification because you are a member of

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
@Langston will do tomorrow. s390x ABI requires heavy changes to the python script. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885332 Title: Error in user-mode calculation of ELF aux vector's A

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-11 Thread Dmitry
When I switch to armv7 the issue goes away $ cat Dockerfile.armv7 FROM arm32v7/ubuntu RUN apt-get update && \ apt-get install -y \ gcc make libpcre3-dev libreadline-dev git RUN cd /home && git clone https://github.com/nginx/njs RUN cd /home/njs && ./configure --cc-opt='-O0 -static -lm -

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-13 Thread Dmitry
Built the latest QEMU, the issue goes away $ bin/debug/native/s390x-linux-user/qemu-s390x --version qemu-s390x version 5.0.50 (v5.0.0-2358-g6c87d9f311-dirty) Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers $ bin/debug/native/s390x-linux-user/qemu-s390x ../njs/njs-s390 -c

[Qemu-devel] ICH6+ chipset emulation

2012-01-27 Thread Dmitry Zamaruev
Hi, I'm trying to run specific firmware under QEMU, and it is tied (hardcoded) to newer chipsets than QEMU currently supports. I know there was an effort to emulate Q35, but it seems not to get mainstream. Is there any chance to see one of ICH6/7/8/9/10 emulated in QEMU ? wbr, Dmitry.

Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-31 Thread Dmitry Zamaruev
This is used in many places. Maybe to simulate 'private' variables and access methods like in C++. If you define structure in .c file then every function that works with this structure must reside in same file. And any other code to use structure must use access-functions (api) to alter it and not

[Qemu-devel] [PATCH 0/2] A few race conditions in E1000 device fixed

2012-10-15 Thread Dmitry Fleytman
race condition. Dmitry Fleytman (2): Fix a race condition in E1000 device implementation: Fix a race condition in E1000 device live migration. One of data-transfer related flags not in migrated fields list. hw/e1000.c | 25 +++-- 1 file changed, 23 insertions(+

[Qemu-devel] [PATCH 2/2] Fix a race condition in E1000 device live migration. One of data-transfer related flags not in migrated fields list.

2012-10-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/e1000.c b/hw/e1000.c index 1e66ecf..efbe0c9 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -92,7 +92,7 @@ typedef struct E1000State_st { uint32_t rxbuf_size; uint32_t

[Qemu-devel] [PATCH 1/2] Fix a race condition in E1000 device implementation:

2012-10-15 Thread Dmitry Fleytman
attempt or guest memory gets corrupted. Reported-by: Chris Webb Reported-by: Richard Davies Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/hw/e1000.c b/hw/e1000.c index 63fee10..1e66ecf 100644 --- a/hw/e1000.c

Re: [Qemu-devel] [PATCH 0/2] A few race conditions in E1000 device fixed

2012-10-15 Thread Dmitry Fleytman
%3DBck6zSoMQ-9S3ZJo7w%40mail.gmail.com&forum_name=e1000-devel). We'll submit the final patch soon. Dmitry. On Mon, Oct 15, 2012 at 6:48 PM, Dmitry Fleytman wrote: > Following patches fix a few race conditions in E1000 code: > > 1st patch fixes race condition between driver s

[Qemu-devel] [PATCH 0/2] E1000 RX/Live migration bugs fixed

2012-10-17 Thread Dmitry Fleytman
th no regressions, please, take a look. Dmitry Fleytman (2): Ignore RX tail kicks when RX disabled. Add check_rxov into VMState. hw/e1000.c | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) -- 1.7.11.4

[Qemu-devel] [PATCH 1/2] Ignore RX tail kicks when RX disabled.

2012-10-17 Thread Dmitry Fleytman
) and then memory corruption occures. Device has to ignore RX tail kicks unless RX enabled. Reported-by: Chris Webb Reported-by: Richard Davies Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/hw/e100

[Qemu-devel] [PATCH 2/2] Add check_rxov into VMState.

2012-10-17 Thread Dmitry Fleytman
E1000State::check_rxov field must be preserved on live migration. Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 606bf3a..26ad03c 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -92,7 +92,7

Re: [Qemu-devel] [PATCH 2/2] Add check_rxov into VMState.

2012-10-18 Thread Dmitry Fleytman
Oops, you are right :) On Thu, Oct 18, 2012 at 9:24 AM, Stefan Hajnoczi wrote: > On Wed, Oct 17, 2012 at 08:31:47PM +0200, Dmitry Fleytman wrote: >> @@ -1100,6 +1100,11 @@ static bool is_version_1(void *opaque, int version_id) >> return version_id == 1; >> } >> &

Re: [Qemu-devel] [PATCH 1/2] Ignore RX tail kicks when RX disabled.

2012-10-18 Thread Dmitry Fleytman
ring we'll probably get correct behavior for current Linux driver's code (needs testing of course), however we have no idea how Windows drivers work. Also drivers tend to change... Dmitry. On Thu, Oct 18, 2012 at 10:09 AM, Stefan Hajnoczi wrote: > On Wed, Oct 17, 2012 at 08:31:

Re: [Qemu-devel] [PATCH 1/2] Ignore RX tail kicks when RX disabled.

2012-10-18 Thread Dmitry Fleytman
escriptor and tries to perform "DMA" to arbitrary address from descriptor. Depending on address value it corrupts guest memory or abort()'s here: void *qemu_get_ram_ptr(ram_addr_t addr) { [...] fprintf(stderr, "Bad ram offset %" PRIx64 "\n", (uint64_t)addr);

Re: [Qemu-devel] [PATCH 1/2] Ignore RX tail kicks when RX disabled.

2012-10-18 Thread Dmitry Fleytman
12 at 10:34 AM, Dmitry Fleytman wrote: >>> The real purpose of check_rxov it a bit confusing indeed, mainly >>> because of unclear name (rename?), >>> however it works as following: >>> >>> There are 2 possible when RDT == RDH for RX ring: >>>

[Qemu-devel] [PATCH V2] E1000 RX ring management fix

2012-10-18 Thread Dmitry Fleytman
got deleted Also I've made short experiment with an Intel adapter controlled by e1000e driver. Indeed I saw no RX indication attempt when RX ring's RDH and RDT are equal. Dmitry Fleytman (1): Drop check_rxov, always treat RX ring with RHD == RDT as empty hw/e1000.c | 7 ++- 1 fi

[Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty

2012-10-18 Thread Dmitry Fleytman
Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb Reported-by: Richard Davies Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/e1000.c b/hw/e1000

Re: [Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty

2012-10-18 Thread Dmitry Fleytman
Thanks, Peter I'll resend the patch. Sent from my iPad On Oct 18, 2012, at 9:20 PM, Peter Maydell wrote: > On 18 October 2012 19:59, Dmitry Fleytman wrote: >> Real HW always treats RX ring with RDH == RDT as empty. >> Emulation is supposed to behave the same. > >

[Qemu-devel] [PATCH V3] E1000 RX ring management fix

2012-10-18 Thread Dmitry Fleytman
patch (live migration) dropped because corresponding field got deleted Also I've made short experiment with an Intel adapter controlled by e1000e driver. Indeed I saw no RX indication attempt when RX ring's RDH and RDT are equal. Dmitry Fleytman (1): e1000: drop check_rxov, always tre

[Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-10-18 Thread Dmitry Fleytman
Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb Reported-by: Richard Davies Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/e1000.c b/hw/e1000

Re: [Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-10-19 Thread Dmitry Fleytman
Thanks Stefan, It was my very first idea to drop check_rxov and solve the problem, however for some reason I was sure that it required to emulate real HW behavior. I'm glad we clarified this. Regards, Dmitry Fleytman On Fri, Oct 19, 2012 at 9:52 AM, Stefan Hajnoczi wrote: > On Fri

[Qemu-devel] [PATCH V8 1/5] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2012-12-07 Thread Dmitry Fleytman
Adding utility function net_raw_checksum() that calculates checksum of buffer given Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- net/checksum.c | 13 +++-- net/checksum.h | 14 +- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/net

[Qemu-devel] [PATCH V8 0/5] VMXNET3 paravirtual NIC device implementation

2012-12-07 Thread Dmitry Fleytman
by Michael S. Tsirkin Reported-by: Michael S. Tsirkin Patches regrouped as suggested by Paolo Bonzini Reported-by: Paolo Bonzini Changes in V4: Fixed a few problems uncovered by NETIO test suit Assertion on failure to initialize MSI/MSI-X replaced with warning message and fallbac

[Qemu-devel] [PATCH V8 4/5] Adding packet abstraction for VMWARE network devices

2012-12-07 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman --- hw/vmxnet_pkt.c | 758 hw/vmxnet_pkt.h | 309 +++ 2 files changed, 1067 insertions(+) create mode 100644 hw/vmxnet_pkt.c create mode 100644 hw/vmxnet_pkt.h diff --git a/hw

[Qemu-devel] [PATCH V8 2/5] Adding utility function net_checksum_add_iov() for iovec checksum calculation

2012-12-07 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- iov.h | 5 + net/checksum.c | 28 net/checksum.h | 8 3 files changed, 41 insertions(+) diff --git a/iov.h b/iov.h index 34c8ec9..c184a80 100644 --- a/iov.h +++ b/iov.h

[Qemu-devel] [PATCH V8 3/5] Adding common definitions for VMWARE devices

2012-12-07 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 143 +++ hw/vmxnet_debug.h | 121 +++ hw/vmxnet_utils.c | 219 +++ hw/vmxnet_utils.h | 340

Re: [Qemu-devel] [PATCH V8 0/5] VMXNET3 paravirtual NIC device implementation

2012-12-26 Thread Dmitry Fleytman
Hi Everyone Is there any progress with these patches? Is there a chance they will be committed any time soon? Thanks, Dmitry On Fri, Dec 7, 2012 at 1:15 PM, Dmitry Fleytman wrote: > This set of patches implements VMWare VMXNET3 paravirtual NIC device. > The device supports of all the

Re: [Qemu-devel] [PATCH V10 0/5] VMXNET3 paravirtual NIC device implementation

2013-02-05 Thread Dmitry Fleytman
Stefan, Is there any else needs to be done in order to get these patches committed? Thanks, Dmitry. On Wed, Jan 23, 2013 at 7:30 AM, Dmitry Fleytman wrote: > This set of patches implements VMWare VMXNET3 paravirtual NIC device. > The device supports of all the device features inc

[Qemu-devel] [PATCH v11 3/5] Common definitions for VMWARE devices

2013-02-25 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 143 ++ hw/vmxnet_debug.h | 115 ++ include/net/eth.h | 347 ++ net/Makefile.objs | 1 + net/eth.c | 217

[Qemu-devel] [PATCH v11 1/5] Checksum-related utility functions

2013-02-25 Thread Dmitry Fleytman
net_checksum_add_cont() checksum calculation for scattered data with odd chunk sizes net_raw_checksum() checksum calculation for a buffer Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 14 +- net/checksum.c | 13 +++-- 2

[Qemu-devel] [PATCH v11 4/5] Packet abstraction for VMWARE network devices

2013-02-25 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/Makefile.objs | 1 + hw/vmxnet_rx_pkt.c | 187 ++ hw/vmxnet_rx_pkt.h | 174 hw/vmxnet_tx_pkt.c | 567 + hw/vmxnet_tx_pkt.h | 148

[Qemu-devel] [PATCH V11 0/5] VMXNET3 paravirtual NIC device implementation

2013-02-25 Thread Dmitry Fleytman
-by: Michael S. Tsirkin Patches regrouped as suggested by Paolo Bonzini Reported-by: Paolo Bonzini Changes in V4: Fixed a few problems uncovered by NETIO test suit Assertion on failure to initialize MSI/MSI-X replaced with warning message and fallback to Legacy/MSI r

[Qemu-devel] [PATCH v11 2/5] iovec checksum calculation fuction

2013-02-25 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 8 net/checksum.c | 28 2 files changed, 36 insertions(+) diff --git a/include/net/checksum.h b/include/net/checksum.h index 3e7b93d..b1cf18a 100644 --- a

Re: [Qemu-devel] [PATCH V10 0/5] VMXNET3 paravirtual NIC device implementation

2013-02-25 Thread Dmitry Fleytman
Done. On Thu, Feb 21, 2013 at 12:47 PM, Stefan Hajnoczi wrote: > Hi Dmitry, > The net multiqueue feature went into QEMU 1.4 and conflicts with vmxnet3.c. > > Please post a rebased version onto qemu.git/master so vmxnet3 can be > merged. I'm currently getting the following

Re: [Qemu-devel] [PATCH v11 2/5] iovec checksum calculation fuction

2013-03-02 Thread Dmitry Fleytman
Eduardo, Andreas, Thanks for pointing out, we didn't know about this limitation of qemu-common.h usage. Include directive will be moved to corresponding .c file. Dmitry. On Tue, Feb 26, 2013 at 3:38 PM, Eduardo Habkost wrote: > On Mon, Feb 25, 2013 at 09:37:52PM +0100, Andreas Färb

Re: [Qemu-devel] [PATCH v11 2/5] iovec checksum calculation fuction

2013-03-02 Thread Dmitry Fleytman
Thanks Andreas, fixed. On Mon, Feb 25, 2013 at 10:37 PM, Andreas Färber wrote: > Am 25.02.2013 21:11, schrieb Dmitry Fleytman: > > Signed-off-by: Dmitry Fleytman > > Signed-off-by: Yan Vugenfirer > > --- > > include/net/checksum.h | 8 >

Re: [Qemu-devel] [PATCH v11 5/5] VMXNET3 device implementation

2013-03-02 Thread Dmitry Fleytman
at was the proper convention that days. Anyway, I've fixed almost everything you've pointed out. See below my comments on specific issues. On Tue, Feb 26, 2013 at 12:05 AM, Andreas Färber wrote: > Am 25.02.2013 21:11, schrieb Dmitry Fleytman: > [snip] > > +static int &g

[Qemu-devel] [PATCH V12 1/5] Checksum-related utility functions

2013-03-02 Thread Dmitry Fleytman
net_checksum_add_cont() checksum calculation for scattered data with odd chunk sizes net_raw_checksum() checksum calculation for a buffer Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 14 +- net/checksum.c | 13 +++-- 2

[Qemu-devel] [PATCH V12 2/5] net: iovec checksum calculator

2013-03-02 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 12 net/checksum.c | 29 + 2 files changed, 41 insertions(+) diff --git a/include/net/checksum.h b/include/net/checksum.h index 3e7b93d..80203fb 100644

[Qemu-devel] [PATCH V12 0/5] VMXNET3 paravirtual NIC device implementation

2013-03-02 Thread Dmitry Fleytman
laced with warning message and fallback to Legacy/MSI respectively Reported-by: Gerhard Wiesinger Various coding style adjustments and patch split-up as suggested by Anthony Liguori Reported-by: Anthony Liguori Live migration support added Changes in V3: Fixed

[Qemu-devel] [PATCH V12 4/5] Packet abstraction for VMWARE network devices

2013-03-02 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/Makefile.objs | 1 + hw/vmxnet_rx_pkt.c | 187 ++ hw/vmxnet_rx_pkt.h | 174 hw/vmxnet_tx_pkt.c | 567 + hw/vmxnet_tx_pkt.h | 148

[Qemu-devel] [PATCH V12 3/5] Common definitions for VMWARE devices

2013-03-02 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 143 ++ hw/vmxnet_debug.h | 115 ++ include/net/eth.h | 347 ++ net/Makefile.objs | 1 + net/eth.c | 217

Re: [Qemu-devel] [PATCH V12 5/5] VMXNET3 device implementation

2013-03-04 Thread Dmitry Fleytman
Oops, forgot to address this part... Is it enough to make following change: - * This work is licensed under the terms of the GNU GPL, version 2 or later. + * This work is licensed under the terms of the GNU GPL, version 2. Do you want me to resend the series? Dmitry. On Mon, Mar 4, 2013 at 4

[Qemu-devel] [PATCH v13 1/5] Checksum-related utility functions

2013-03-05 Thread Dmitry Fleytman
net_checksum_add_cont() checksum calculation for scattered data with odd chunk sizes net_raw_checksum() checksum calculation for a buffer Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 14 +- net/checksum.c | 13 +++-- 2

[Qemu-devel] [PATCH V13 0/5] VMXNET3 paravirtual NIC device implementation

2013-03-05 Thread Dmitry Fleytman
4: Fixed a few problems uncovered by NETIO test suit Assertion on failure to initialize MSI/MSI-X replaced with warning message and fallback to Legacy/MSI respectively Reported-by: Gerhard Wiesinger Various coding style adjustments and patch split-up as suggested by Anthony Lig

[Qemu-devel] [PATCH v13 3/5] Common definitions for VMWARE devices

2013-03-05 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 143 ++ hw/vmxnet_debug.h | 115 ++ include/net/eth.h | 347 ++ net/Makefile.objs | 1 + net/eth.c | 217

[Qemu-devel] [PATCH v13 4/5] Packet abstraction for VMWARE network devices

2013-03-05 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/Makefile.objs | 1 + hw/vmxnet_rx_pkt.c | 187 ++ hw/vmxnet_rx_pkt.h | 174 hw/vmxnet_tx_pkt.c | 567 + hw/vmxnet_tx_pkt.h | 148

[Qemu-devel] [PATCH v13 2/5] net: iovec checksum calculator

2013-03-05 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 12 net/checksum.c | 29 + 2 files changed, 41 insertions(+) diff --git a/include/net/checksum.h b/include/net/checksum.h index 3e7b93d..80203fb 100644

Re: [Qemu-devel] [PATCH V12 5/5] VMXNET3 device implementation

2013-03-05 Thread Dmitry Fleytman
Stefan, I've sent V13 of patches with license changed. Dmitry. On Mon, Mar 4, 2013 at 4:52 PM, Dmitry Fleytman wrote: > Oops, forgot to address this part... > > Is it enough to make following change: > > - * This work is licensed under the terms of the GNU GPL,

Re: [Qemu-devel] [PATCH V12 5/5] VMXNET3 device implementation

2013-03-06 Thread Dmitry Fleytman
No problem. On Wed, Mar 6, 2013 at 11:26 AM, Stefan Hajnoczi wrote: > On Wed, Mar 06, 2013 at 09:24:35AM +0200, Dmitry Fleytman wrote: > > I've sent V13 of patches with license changed. > > Thanks for resending. I'm happy to do trivial fixups while merging but > I

Re: [Qemu-devel] [PATCH v13 5/5] VMXNET3 device implementation

2013-03-07 Thread Dmitry Fleytman
Thanks, Andreas Now I see. We'll resubmit our patches soon. Dmitry. On Thu, Mar 7, 2013 at 2:59 PM, Andreas Färber wrote: > Am 06.03.2013 08:21, schrieb Dmitry Fleytman: > > Signed-off-by: Dmitry Fleytman > > Signed-off-by: Yan Vugenfirer > > --- > >

[Qemu-devel] [PATCH V14 0/5] VMXNET3 paravirtual NIC device implementation

2013-03-09 Thread Dmitry Fleytman
ported-by: Paolo Bonzini Changes in V4: Fixed a few problems uncovered by NETIO test suit Assertion on failure to initialize MSI/MSI-X replaced with warning message and fallback to Legacy/MSI respectively Reported-by: Gerhard Wiesinger Various coding style adjustment

[Qemu-devel] [PATCH V14 1/5] Checksum-related utility functions

2013-03-09 Thread Dmitry Fleytman
net_checksum_add_cont() checksum calculation for scattered data with odd chunk sizes net_raw_checksum() checksum calculation for a buffer Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 14 +- net/checksum.c | 13 +++-- 2

[Qemu-devel] [PATCH V14 3/5] Common definitions for VMWARE devices

2013-03-09 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 143 ++ hw/vmxnet_debug.h | 115 ++ include/net/eth.h | 347 ++ net/Makefile.objs | 1 + net/eth.c | 217

[Qemu-devel] [PATCH V14 4/5] Packet abstraction for VMWARE network devices

2013-03-09 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/Makefile.objs | 1 + hw/vmxnet_rx_pkt.c | 187 ++ hw/vmxnet_rx_pkt.h | 174 hw/vmxnet_tx_pkt.c | 567 + hw/vmxnet_tx_pkt.h | 148

[Qemu-devel] [PATCH V14 2/5] net: iovec checksum calculator

2013-03-09 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- include/net/checksum.h | 12 net/checksum.c | 29 + 2 files changed, 41 insertions(+) diff --git a/include/net/checksum.h b/include/net/checksum.h index 3e7b93d..80203fb 100644

Re: [Qemu-devel] [PATCH 1/1 V6] VMWare PVSCSI paravirtual device implementation

2013-04-18 Thread Dmitry Fleytman
On Thu, Apr 18, 2013 at 1:54 PM, Paolo Bonzini wrote: > Il 18/04/2013 11:38, Dmitry Fleytman ha scritto: > > > > > +static void > > > +pvscsi_free_queue(PVSCSIRequestList *req_list) > > > > This shouldn't be needed. > > > > >

[Qemu-devel] [PATCH 0/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Dmitry Fleytman
: Paolo Bonzini Dmitry Fleytman (1): VMWare PVSCSI paravirtual device implementation default-configs/pci.mak|1 + docs/specs/pvscsi-spec.txt | 92 hw/Makefile.objs |1 + hw/pci/pci.h |1 + hw/pvscsi.c| 1194

Re: [Qemu-devel] [PATCH 0/1 V4] virtio-net: dynamic network offloads configuration

2013-04-19 Thread Dmitry Fleytman
Hello All, Any news regarding this patch? Thanks, Dmitry On Sun, Apr 7, 2013 at 9:34 AM, Dmitry Fleytman wrote: > From: Dmitry Fleytman > > This patch implements recently accepted by virtio-spec > dynamic offloads configuration feature. > See commit message for details.

Re: [Qemu-devel] [PATCH 1/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Dmitry Fleytman
Paolo, thanks for review. Regarding the change - it's ok with me, but why do one needs this? I think we always set proper status before request cancellation. May QEMU call cancel callback on its own? Dmitry. On Fri, Apr 19, 2013 at 10:37 AM, Paolo Bonzini wrote: > Il 19/04/2013 09:05

Re: [Qemu-devel] [PATCH 1/1 V7] VMWare PVSCSI paravirtual device implementation

2013-04-19 Thread Dmitry Fleytman
I see. Thanks. On Fri, Apr 19, 2013 at 10:58 AM, Paolo Bonzini wrote: > Il 19/04/2013 09:53, Dmitry Fleytman ha scritto: > > Paolo, thanks for review. > > > > Regarding the change - it's ok with me, but why do one needs this? I > > think we always set proper st

Re: [Qemu-devel] [PATCH 0/1 V4] virtio-net: dynamic network offloads configuration

2013-04-20 Thread Dmitry Fleytman
Spec patch already inside. Sent from my iPad On Apr 20, 2013, at 8:04 PM, "Michael S. Tsirkin" wrote: > On Fri, Apr 19, 2013 at 10:10:01AM +0300, Dmitry Fleytman wrote: >> Hello All, >> >> Any news regarding this patch? >> >> Thanks, >> Dmitr

Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-24 Thread Dmitry Fleytman
> generally. Hi Michael, I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me. I think this patch is correct and needed. As we saw a few times already on different operating systems, vmware drivers expect short packets to be padded as required by corresponding RFC

Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-24 Thread Dmitry Fleytman
On Aug 24, 2014, at 16:10 PM, Michael Tokarev wrote: > 24.08.2014 16:28, Dmitry Fleytman wrote: > >> Hi Michael, >> >> I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me. > > Maybe you can add yourself to MAINTAINERS file as well? :) Ye

[Qemu-devel] [PATCH] MAINTAINERS: Add VMWare devices maintainer

2014-08-26 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 59940f9..1b3e2be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -678,6 +678,12 @@ S: Maintained F: hw/*/xilinx_* F: include/hw/xilinx.h +Vmware +M: Dmitry

Re: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse

2014-05-20 Thread Dmitry Fleytman
ACK Thanks for fixing. On May 19, 2014, at 16:47 PM, Jiri Pirko wrote: > In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with > VMXNET3_MAX_INTRS. That is not correct since vector of > value VMXNET3_MAX_INTRS was never used. Also all the used vectors > are not un-used. So call vm

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-10-14 Thread Dmitry Poletaev
What do you mean? 29.07.2014, 23:07, "Richard Henderson" : > On 07/23/2014 05:04 AM, Dmitry Poletaev wrote: >>  +    if (env->fp_status.float_exception_flags & FPUS_IE) { > > Mixing bit masks.  s/FPUS_IE/float_status_invalid/ > > r~

Re: [Qemu-devel] [Qemu-trivial] [PATCH] MAINTAINERS: Add VMWare devices maintainer

2014-08-29 Thread Dmitry Fleytman
> On 29 באוג 2014, at 19:24, Michael Tokarev wrote: > > Applied to -trivial, dunno if it'll be picked up by anyone else ;) This patch is pretty trivial indeed ;) > > Thank you! > > /mjt

[Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-07-14 Thread Dmitry Poletaev
ording to tcg tests), but I am not shure it doesn't breaks anything. From: Dmitry Poletaev Signed-off-by: Dmitry Poletaev --- fpu/softfloat.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 9274ebf..580c322 100644 --- a/fp

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-07-23 Thread Dmitry Poletaev
14.07.2014, 18:59, "Peter Maydell" : >  Since softfloat's status flags are sticky ... What does it mean?

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-07-23 Thread Dmitry Poletaev
I'm understood. So, am I right? From: Dmitry Poletaev Signed-off-by: Dmitry Poletaev --- target-i386/fpu_helper.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c index 1b2900d..c4fdad8 100644

Re: [Qemu-devel] [PATCH] target-i386/FPU: wrong conversion infinity from float80 to int32/int64

2014-07-24 Thread Dmitry Poletaev
23.07.2014, 21:13, "Peter Maydell" : >  On 23 July 2014 16:04, Dmitry Poletaev wrote: >>   I'm understood. So, am I right? >  Pretty much, except it's better to use the accessor functions >  get_float_exception_flags() and set_float_e

[Qemu-devel] [PATCH] target-i386/fpu_helper.c: fbld instruction doesn't set minus sign

2014-07-25 Thread Dmitry Poletaev
Obviously, there is a misprint in function implementation. From: Dmitry Poletaev Signed-off-by: Dmitry Poletaev --- target-i386/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c index 1b2900d..be1e545 100644

Re: [Qemu-devel] [PATCH v4 11/11] Exynos4210: added display controller implementation

2011-12-22 Thread Dmitry Solodkiy
Dear Dmitry, Thank you for feedback. As you probably know, there is some decision making process in large corporations. We'll discuss naming conventions on project meeting, make proposal, send it to peers, get approve and apply. Regards, Dmitry Solodkiy, Mobile SW PL, Adv

[Qemu-devel] [PATCH 0/5] VMWare PVSCSI paravirtual device implementation

2012-03-15 Thread Dmitry Fleytman
Ubuntu 10.4 Centos 6.2 Windows 2008R2 Windows 2008 64bit Windows 2008 32bit Windows 2003 64bit Windows 2003 32bit Dmitry Fleytman (5): Utility function strpadcpy() added Vendor name and product name parameters for SCSI devices Options "vendor_name

[Qemu-devel] [PATCH 1/5] Utility function strpadcpy() added

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- cutils.c | 13 + qemu-common.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index af308cd..0df7fdf 100644 --- a/cutils.c +++ b/cutils.c @@ -27,6 +27,19

[Qemu-devel] [PATCH 5/5] PVSCSI paravirtualized device integration Bus type "pvscsi" added.

2012-03-15 Thread Dmitry Fleytman
Sample command line for pvscsi-based disk is: -drive file=image.raw,if=none,cache=off,id=pvscsi1 \ -device pvscsi,id=pvscsi -device scsi-disk,drive=pvscsi1,bus=pvscsi.0 \ Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- Makefile.objs |1 + blockdev.c

[Qemu-devel] [PATCH 3/5] Header with various utility functions shared by VMWARE SCSI and network devices

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 122 + 1 files changed, 122 insertions(+), 0 deletions(-) create mode 100644 hw/vmware_utils.h diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h new file

[Qemu-devel] [PATCH 2/5] Vendor name and product name parameters for SCSI devices Options "vendor_name" and "product_name" added for SCSI disks.

2012-03-15 Thread Dmitry Fleytman
Sample command line is: -drive file=image.raw,if=none,cache=off,id=scsi1 \ -device lsi,id=scsi -device scsi-disk,drive=scsi1,bus=scsi.0,product_name="VENDOR SCSI DISK",vendor_name="[VENDOR]" \ Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- b

Re: [Qemu-devel] [PATCH V2 3/3] hw: add Atmel maxtouch touchscreen implementation

2012-03-15 Thread Dmitry Solodkiy
Dear Andreas, "All rights reserved" was added by accident and going to be removed on next update of all our patches. Thanks,      Dmitry Solodkiy,      Emulator/Kernel PL, Mobile Group,    Moscow R&D center, Samsung Electronics -Original Message- From: Andreas Färber

[Qemu-devel] [PATCH v4 0/9] VMXNET3 paravirtual NIC device implementation

2012-03-15 Thread Dmitry Fleytman
cases when net device that is used as network fronted has no virtio HDR support. Reported-by: Gerhard Wiesinger Changes in V2: License text changed accoring to community suggestions Standard license header from GPLv2+ - licensed QEMU files used Dmitry Fleytman (9): Adding missing

[Qemu-devel] [PATCH v4 3/9] Adding utility function iov_net_csum_add() for iovec checksum calculation

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- iov.c | 29 + iov.h |3 +++ 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/iov.c b/iov.c index 0f96493..5d4f94c 100644 --- a/iov.c +++ b/iov.c @@ -16,6 +16,7 @@ */ #include

[Qemu-devel] [PATCH v4 1/9] Adding missing flag VIRTIO_NET_HDR_F_DATA_VALID from Linux kernel source tre Reformatting comments according to checkpatch.pl requirements

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/virtio-net.h | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/virtio-net.h b/hw/virtio-net.h index 4468741..fa3c17b 100644 --- a/hw/virtio-net.h +++ b/hw/virtio-net.h @@ -78,13 +78,14

[Qemu-devel] [PATCH v4 9/9] VMXNET3 paravirtualized device integration. Interface type "vmxnet3" added.

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- Makefile.objs |1 + default-configs/pci.mak |1 + hw/pci.c|2 ++ hw/pci.h|1 + net.c |2 +- 5 files changed, 6 insertions(+), 1 deletions(-) diff

[Qemu-devel] [PATCH v4 6/9] Various utility functions used by VMWARE network devices

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmxnet_debug.h | 121 hw/vmxnet_utils.c | 165 +++ hw/vmxnet_utils.h | 320 + 3 files changed, 606 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH 0/5] VMWare PVSCSI paravirtual device implementation

2012-03-15 Thread Dmitry Fleytman
Avi, We are considering this option as well... Dmitry Fleytman.

[Qemu-devel] [PATCH v4 7/9] Packet abstraction used by VMWARE network devices

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmxnet_pkt.c | 1243 +++ hw/vmxnet_pkt.h | 479 + 2 files changed, 1722 insertions(+), 0 deletions(-) create mode 100644 hw/vmxnet_pkt.c create mode

[Qemu-devel] [PATCH v4 4/9] MSI-X state save/load invocations moved to PCI Device save/load callbacks to avoid code duplication in MSI-X-enabled devices that support live migration

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/pci.c|5 + hw/virtio-pci.c |2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index bf046bf..9146d3f 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -31,6 +31,7 @@ #include

[Qemu-devel] [PATCH v4 2/9] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2012-03-15 Thread Dmitry Fleytman
Adding utility function net_raw_checksum() that calculates checksum of buffer given Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- net/checksum.c | 13 +++-- net/checksum.h | 14 +- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/net

[Qemu-devel] [PATCH v4 5/9] Header with various utility functions shared by VMWARE SCSI and network devi

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 122 + 1 files changed, 122 insertions(+), 0 deletions(-) create mode 100644 hw/vmware_utils.h diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h new file

Re: [Qemu-devel] [PATCH v4 4/9] MSI-X state save/load invocations moved to PCI Device save/load callbacks to avoid code duplication in MSI-X-enabled devices that support live migration

2012-03-16 Thread Dmitry Fleytman
Michael, Great. I believe higher level API if what really needed here. I'll revert this patch and move msix_load/store invocations into the device code. Thanks. On Fri, Mar 16, 2012 at 1:00 AM, Michael S. Tsirkin wrote: > On Thu, Mar 15, 2012 at 11:09:03PM +0200, Dmitry Fleytm

Re: [Qemu-devel] [PATCH 5/5] PVSCSI paravirtualized device integration Bus type "pvscsi" added.

2012-03-18 Thread Dmitry Fleytman
Good point. Fixed. Thanks. On Thu, Mar 15, 2012 at 11:46 AM, Paolo Bonzini wrote: > Il 15/03/2012 10:02, Dmitry Fleytman ha scritto: >> Sample command line for pvscsi-based disk is: >>     -drive file=image.raw,if=none,cache=off,id=pvscsi1 \ >>     -device pvscsi,id=pvs

  1   2   3   4   5   6   7   8   9   10   >