Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Daniel P. Berrange
On Mon, Aug 13, 2012 at 03:21:32PM -0300, Marcelo Tosatti wrote: > On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote: > > We can know the guest is panicked when the guest runs on xen. > > But we do not have such feature on kvm. > > > > Another purpose of this feature is: management app(

[Qemu-devel] [PATCH] Add support for pretty-printing response in qmp-shell

2012-08-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a '-p' arg to the QMP/qmp-shell test program, which uses the python pprint module to pretty-print the dictionary returned from a command $ qmp-shell -p /tmp/qemu Welcome to the QMP low-level shell! Connected to QEMU 1.1.50 (QEMU) query

[Qemu-devel] [PATCH] Hack qmp.py to support reading a JSON multi-line response

2012-08-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The qmp-shell code assumes the JSON response is only on a single line. If the QEMU monitor is configured in "pretty print" mode the JSON response can be multi-line. The basic Python JSON APIs do not appear to support a streaming mode, so the simple

[Qemu-devel] [PATCH] Add a '-r' option to qmp-shell to print out raw JSON replies

2012-08-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" By default, the JSON reply is parsed and the corresponding python object printed on the console. When developing JSON client apps for QEMU though, it is handy to see the raw JSON document instead. Add a '-r' option that will cause the raw JSON to be

[Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a 'query-target' QAPI command to allow management applications to determine what target architecture a QEMU binary is emulating without having to parse the binary name or -help output $ qmp-shell -p /tmp/qemu (QEMU) query-target { u

Re: [Qemu-devel] [PATCH] Hack qmp.py to support reading a JSON multi-line response

2012-08-20 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 03:03:11PM -0300, Luiz Capitulino wrote: > On Mon, 20 Aug 2012 15:01:37 +0100 > "Daniel P. Berrange" wrote: > > > From: "Daniel P. Berrange" > > > > The qmp-shell code assumes the JSON response is only on a single > &g

Re: [Qemu-devel] [PATCH] Add a '-r' option to qmp-shell to print out raw JSON replies

2012-08-20 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 03:22:35PM -0300, Luiz Capitulino wrote: > On Mon, 20 Aug 2012 15:02:23 +0100 > "Daniel P. Berrange" wrote: > > > From: "Daniel P. Berrange" > > > > By default, the JSON reply is parsed and the corresponding python > >

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 04:48:24PM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > From: "Daniel P. Berrange" > > > > Add a 'query-target' QAPI command to allow management applications > > to determine what target a

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Daniel P. Berrange
On Mon, Aug 20, 2012 at 04:02:39PM -0300, Luiz Capitulino wrote: > On Mon, 20 Aug 2012 15:31:38 +0100 > "Daniel P. Berrange" wrote: > > > From: "Daniel P. Berrange" > > > > Add a 'query-target' QAPI command to allow management appl

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2012 at 11:17:40AM +0100, Peter Maydell wrote: > On 21 August 2012 11:05, Daniel P. Berrange wrote: > > On Mon, Aug 20, 2012 at 04:48:24PM -0500, Anthony Liguori wrote: > >> "bits" is really ambiguous. What it means in QEMU (specifically the >

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size

2012-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2012 at 09:53:55AM -0300, Luiz Capitulino wrote: > On Tue, 21 Aug 2012 11:07:50 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, Aug 20, 2012 at 04:02:39PM -0300, Luiz Capitulino wrote: > > > On Mon, 20 Aug 2012 15:31:38 +0100

Re: [Qemu-devel] [PATCH] Add guest-get-hostname to retrieve the guests current hostname

2012-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2012 at 01:57:54PM +0200, Guido Günther wrote: > This allows to retrieve the guest's hostname via gethostname(2). > > This can be useful to identify a VM e.g. one without network. > > Signed-off-by: Guido Günther > --- > We have an API in libvirt for that (virDomainGetHostname).

Re: [Qemu-devel] [PATCH] Add guest-get-hostname to retrieve the guests current hostname

2012-08-22 Thread Daniel P. Berrange
On Wed, Aug 22, 2012 at 10:04:33AM +0200, Guido Günther wrote: > On Tue, Aug 21, 2012 at 07:31:17PM +0100, Daniel P. Berrange wrote: > > On Tue, Aug 21, 2012 at 01:57:54PM +0200, Guido Günther wrote: > [..snip..] > > > > Why no impl ? Winsock has the gethostname()

Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size (v2)

2012-08-22 Thread Daniel P. Berrange
You can remove '/bit size' in the commit message 1st line. On Wed, Aug 22, 2012 at 10:09:38AM -0500, Anthony Liguori wrote: > From: "Daniel P. Berrange" > > Add a 'query-target' QAPI command to allow management applications > to determine what targ

[Qemu-devel] How to reliably start a bare QEMU target to query capabilities via QMP

2012-08-22 Thread Daniel P. Berrange
I've been adapting libvirt to use to the various new QMP commands to query QEMU's capabilities, instead of the hated -help parsing. Obviously the critical part of this is being able to reliably start a bare QEMU process with no actual guest OS configured (no disks, no kernel, etc) and talk to its m

Re: [Qemu-devel] How to reliably start a bare QEMU target to query capabilities via QMP

2012-08-23 Thread Daniel P. Berrange
On Wed, Aug 22, 2012 at 03:25:38PM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > I've been adapting libvirt to use to the various new QMP commands to > > query QEMU's capabilities, instead of the hated -help parsing. Obviously > >

[Qemu-devel] Race condition in char device setup causing SEGV

2012-08-23 Thread Daniel P. Berrange
When testing with the new "-M none" arg, I've noticed that ~70% of the time libvirt starts QEMU will result in a SEGV from QEMU with the following stack trace: (gdb) bt #0 0x in ?? () #1 0x5567a37f in json_lexer_feed_char (lexer=0x5658fb20, ch=123 '{', flush=false) a

Re: [Qemu-devel] Race condition in char device setup causing SEGV

2012-08-23 Thread Daniel P. Berrange
On Thu, Aug 23, 2012 at 12:01:05PM +0100, Daniel P. Berrange wrote: > When testing with the new "-M none" arg, I've noticed that ~70% > of the time libvirt starts QEMU will result in a SEGV from QEMU > with the following stack trace: > > (gdb) bt > #0

Re: [Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-23 Thread Daniel P. Berrange
On Thu, Aug 23, 2012 at 02:28:07PM +0200, Benoît Canet wrote: > Usage: > (qemu) migrate file:/path/to/vm_statefile > > Signed-off-by: Benoit Canet > --- > migration-fd.c |4 ++-- > migration.c| 20 +++- > migration.h|2 +- > 3 files changed, 22 insertions(+), 4

Re: [Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-23 Thread Daniel P. Berrange
On Thu, Aug 23, 2012 at 02:48:19PM +0200, Benoît Canet wrote: > Le Thursday 23 Aug 2012 à 13:34:01 (+0100), Daniel P. Berrange a écrit : > > On Thu, Aug 23, 2012 at 02:28:07PM +0200, Benoît Canet wrote: > > > Usage: > > > (qemu) migrate file:/path/to/vm_statefile > &g

Re: [Qemu-devel] [PATCH] monitor: move json init from OPEN event to init

2012-08-23 Thread Daniel P. Berrange
in OPEN appears harmless. > > Reported-by: Daniel Berrange > Signed-off-by: Anthony Liguori Signed-off-by: Daniel P. Berrange Works in my testing. I have also fixed libvirt so that it does not try to send commands to QMP, until QMP has sent out its initial greeting, thus avoiding the

Re: [Qemu-devel] [PATCH] Remove O_NOATIME flag from 9pfs open() calls in readonly mode

2012-01-23 Thread Daniel P. Berrange
Any thoughts on this fix ? Read-only mode is pretty useless without it for non-root users. Daniel On Mon, Jan 16, 2012 at 06:11:40PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > When 2c74c2cb4bedddbfa67628fbd5f9273b4e0e9903 added support for > the &

Re: [Qemu-devel] [PATCH 1/2] qdev: Introduce lost tick policy property

2012-01-23 Thread Daniel P. Berrange
On Mon, Jan 23, 2012 at 08:15:11PM +0100, Jan Kiszka wrote: > Potentially tick-generating timer devices will gain a common property: > lock_tick_policy. It allows to encode 4 different ways how to deal with > tick events the guest did not process in time: > > discard - ignore lost ticks (e.g. if t

Re: [Qemu-devel] [PATCH] READCONFIG: Allow reading the configuration from a pre-existing filedescriptor

2012-01-26 Thread Daniel P. Berrange
On Thu, Jan 26, 2012 at 08:40:02AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > On 01/25/2012 03:23 PM, Ronnie Sahlberg wrote: > >> diff --git a/qemu-config.c b/qemu-config.c > >> index b030205..c12c5eb 100644 > >> --- a/qemu-config.c > >> +++ b/qemu-config.c > >> @@ -770,8 +770,19 @@

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-26 Thread Daniel P. Berrange
On Thu, Jan 26, 2012 at 08:54:11PM +1100, ronnie sahlberg wrote: > Ok so what about this > > You use a filename starting with "/proc/self/fd/" and you dont have a > proc filesystem mounted? you are on your own! IMHO that would be bad - turning what could easily be a platform neutral feature in

Re: [Qemu-devel] [Qemu-trivial] [PATCH] keep the PID file locked for the lifetime of the process

2012-01-27 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 06:36:39AM +, Stefan Hajnoczi wrote: > On Thu, Jan 26, 2012 at 10:36:41PM +0100, Laszlo Ersek wrote: > > The lockf() call in qemu_create_pidfile() aims at ensuring mutual > > exclusion. We shouldn't close the pidfile on success, because that drops > > the lock as well [1

Re: [Qemu-devel] Coroutines and ucontext

2012-01-27 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 03:39:22PM +0100, Paolo Bonzini wrote: > On 01/27/2012 01:39 PM, Alex Barcelo wrote: > >I have read that one of the reasons for using makecontext is that it > >saves the signal state. But there also exist functions like > >"sigsetjmp" and "siglongjmp" which can be used to ju

Re: [Qemu-devel] cry for help: wiki.qemu.org spam

2012-01-27 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 01:14:11PM +0400, Michael Tokarev wrote: > The amount of spam our wiki.qemu.org collects, is > increasing every day. It was easy several months > ago to manually delete these pages once a week to > keep wiki spam-free, now they sometimes manage to > re-create a page while I

[Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor command

2012-02-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This is a followup to http://patchwork.ozlabs.org/patch/121004/ With the acceptance of some new APIs to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE

Re: [Qemu-devel] [PATCH] qemu-ga: add guest-sync-delimited

2012-02-07 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 06:07:35PM -0600, Michael Roth wrote: > guest-sync leaves it as an exercise to the user as to how to reliably > obtain the response to guest-sync if the client had previously read in a > partial response (due qemu-ga previously being restarted mid-"sentence" > due to reboot,

Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled

2012-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2012 at 01:45:15PM +0530, Aneesh Kumar K.V wrote: > On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge > wrote: > > There have been reports [1, 2] where folks have had issues building > > VirtFS and the virtio backend on older systems. I personally saw > > problems due to the use of

Re: [Qemu-devel] [libvirt] QEMU applying for Google Summer of Code 2012

2012-02-10 Thread Daniel P. Berrange
On Fri, Feb 10, 2012 at 10:30:24AM +, Stefan Hajnoczi wrote: > This year's Google Summer of Code has been announced: > > http://www.google-melange.com/gsoc/events/google/gsoc2012 > > For those who haven't heard of GSoC before, it funds university > students to work on open source projects dur

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-10 Thread Daniel P. Berrange
On Fri, Feb 10, 2012 at 10:34:13PM +0800, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > oslib-posix.c |4 ++-- > oslib-win32.c |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/oslib-posix.c b/oslib-posix.c > index b6a3c7f..f97

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-13 Thread Daniel P. Berrange
On Fri, Feb 10, 2012 at 11:35:11AM -0700, Eric Blake wrote: > On 02/10/2012 07:41 AM, Daniel P. Berrange wrote: > > >> @@ -80,7 +80,7 @@ void *qemu_oom_check(void *ptr) > >> { > >> if (ptr == NULL) { > >> fprintf(stderr, "Failed

[Qemu-devel] QEMU desired libiscsi.so clashes with libiscsi.so from iscsi-initiator-utils

2012-02-13 Thread Daniel P. Berrange
I was investigating how to build latest QEMU with the iSCSI block driver enabled. I saw that configure wanted a libiscsi.so, so I installed that library from Fedora RPMs via the iscsi-initiator-utils package, but it still wouldn't build. After further investigation, I find that QEMU in fact wants

[Qemu-devel] [PATCH v3] Add SPICE support to add_client monitor command

2012-02-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" With the acceptance of some new APIs to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE can use TLS or plain connections, the command also gains a new '

Re: [Qemu-devel] [PATCH 3/3] coroutine: adding enable/disable options for sigaltstack method

2012-02-13 Thread Daniel P. Berrange
On Mon, Feb 13, 2012 at 03:42:30PM +0100, Alex Barcelo wrote: > It's possible to enable/disable sigaltstack, but it always has > less priority than ucontext method (to force sigaltstack, > ucontext has to be disabled). > > Signed-off-by: Alex Barcelo > --- > Makefile.objs |4 > configur

[Qemu-devel] [PATCH] vnc: Don't demote authentication scheme when changing password/disabling login

2012-02-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently when disabling login in VNC, the password is cleared out and the authentication protocol is forced to AUTH_VNC. If you're using a stronger authentication protocol, this has the effect of downgrading your security protocol. Fix this by on

Re: [Qemu-devel] [PATCH] oslib: make error handling more reasonable

2012-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2012 at 12:42:58PM +, Paul Brook wrote: > > > abort can create core dumps or start a debugger which is > > > useful for me and maybe other developers, too. > > > > I consider abort() on OOM somewhat eccentric. abort() is for > > programming errors. Resource shortage is an env

Re: [Qemu-devel] [MASCOT CONTEST] Andreas Faerber #1

2012-02-15 Thread Daniel P. Berrange
On Wed, Feb 15, 2012 at 08:33:35AM -0600, Anthony Liguori wrote: > Please respond to this note with an '+1', or an Ack, to vote for this icon. ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://vi

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-15 Thread Daniel P. Berrange
On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: > On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: > > Here is the sequence sent to disconnect only the host side, then > > reconnect it with a new tap device. (although the fd is the same, this > > is because the old tap

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-16 Thread Daniel P. Berrange
On Tue, Oct 16, 2012 at 10:08:21AM +0200, Stefan Hajnoczi wrote: > On Mon, Oct 15, 2012 at 10:25:58AM +0100, Daniel P. Berrange wrote: > > On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: > > > On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: &

Re: [Qemu-devel] [libseccomp-discuss] [RFC] [PATCHv2 0/2] Sandboxing Qemu guests with Libseccomp

2012-10-29 Thread Daniel P. Berrange
On Mon, Oct 29, 2012 at 11:11:15AM -0400, Corey Bryant wrote: > > > On 06/15/2012 09:54 AM, Paul Moore wrote: > >On Thursday, June 14, 2012 02:59:06 PM Kees Cook wrote: > >>On Wed, Jun 13, 2012 at 1:31 PM, Paul Moore wrote: > >>>On Wednesday, June 13, 2012 04:20:20 PM Eduardo Otubo wrote: >

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Fri, Jun 15, 2012 at 07:06:10PM +, Blue Swirl wrote: > On Wed, Jun 13, 2012 at 8:30 PM, Daniel P. Berrange > wrote: > > On Wed, Jun 13, 2012 at 04:20:22PM -0300, Eduardo Otubo wrote: > >> I added a syscall struct using priority levels as described in the > >

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: > > I think allowing execve() would render seccomp pretty much useless. > > Not necessarily. > > I'll agree that it does seem a bit odd to allow execve(), but there is still > val

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Fri, Jun 15, 2012 at 07:04:45PM +, Blue Swirl wrote: > On Wed, Jun 13, 2012 at 8:33 PM, Daniel P. Berrange > wrote: > > On Wed, Jun 13, 2012 at 07:56:06PM +, Blue Swirl wrote: > >> On Wed, Jun 13, 2012 at 7:20 PM, Eduardo Otubo > >> wrote: > &g

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2012 at 09:31:03AM +0100, Daniel P. Berrange wrote: > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: > > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: > > > I think allowing execve() would render seccomp pretty much useless. > &

Re: [Qemu-devel] How to management KVM virtual machines via libvirt?

2012-06-18 Thread Daniel P. Berrange
On Sat, Jun 16, 2012 at 08:00:00PM +0800, 陳韋任 (Wei-Ren Chen) wrote: > CC'ed to libvirt-users. > > On Sat, Jun 16, 2012 at 07:00:59PM +0800, GaoYi wrote: > > Hi all, > >   > >    I am trying to management the VMs created by KVM commandline. However, I > > found the libvirt cannot connect to the V

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2012 at 09:52:44AM -0400, Paul Moore wrote: > On Monday, June 18, 2012 09:31:03 AM Daniel P. Berrange wrote: > > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: > > > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: > > > > I think

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-19 Thread Daniel P. Berrange
On Tue, Jun 19, 2012 at 09:39:34AM +0200, Kevin Wolf wrote: > Am 18.06.2012 20:31, schrieb Anthony Liguori: > > Irrespective of anything else, I think it's safe to say the experiment of > > "rich > > errors" has been a failure. We still have way too many places using > > error_report. > > > >

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Daniel P. Berrange
On Mon, Jun 18, 2012 at 08:15:37PM +, Blue Swirl wrote: > On Mon, Jun 18, 2012 at 8:31 AM, Daniel P. Berrange > wrote: > > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: > >> On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: > >> > I thi

Re: [Qemu-devel] [PATCH v3 0/5] file descriptor passing using pass-fd

2012-06-20 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 09:25:29AM +0200, Kevin Wolf wrote: > Am 19.06.2012 18:14, schrieb Eric Blake: > >> Maybe it's better to have a monitor command that just prepares a reopen > >> and means "for the next reopen of /dev/fd/42, the passed FD will have > >> the right flags (if it hasn't, the reop

Re: [Qemu-devel] [PATCH v4 1/2] Force driftfix=none on previous machines

2012-06-20 Thread Daniel P. Berrange
On Tue, Jun 19, 2012 at 04:38:44PM -0300, Crístian Viana wrote: > The current value for the -rtc driftfix option is 'none'. This patch > makes sure that the old machines configuration will work the same way > even after that option changes its default value. > > Signed-off-by: Crístian Viana > --

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-20 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 12:29:32PM +0530, Amit Shah wrote: > The Linux kernel already has a virtio-rng driver, this is the device > implementation. > > When the guest asks for entropy from the virtio hwrng, it puts a buffer > in the vq. We then put entropy into that buffer, and push it back to >

[Qemu-devel] Threaded VNC server status - time to enable by default ?

2012-06-20 Thread Daniel P. Berrange
We recently had a request in Fedora to enable the VNC server thread support in our builds of QEMU. There have been periodic messages on this list that suggest the threaded VNC server has better performance and less latency. My view though, is that there must be some good reason why QEMU does not e

Re: [Qemu-devel] Threaded VNC server status - time to enable by default ?

2012-06-20 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 07:58:53AM -0500, Anthony Liguori wrote: > On 06/20/2012 04:15 AM, Daniel P. Berrange wrote: > >We recently had a request in Fedora to enable the VNC server thread > >support in our builds of QEMU. There have been periodic messages on > >this list that

[Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" QEMU now has a fundamental requirement for pthreads, so there is no compelling reason to retain support for the non-threaded VNC server. Remove the --{enable,disable}-vnc-thread configure arguments, and all CONFIG_VNC_THREAD conditionals Signed-off-by

Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-21 Thread Daniel P. Berrange
On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote: > 20.06.2012 16:24, Daniel P. Berrange wrote: > > delete mode 100644 ui/vnc-jobs-async.c > > delete mode 100644 ui/vnc-jobs-sync.c > > create mode 100644 ui/vnc-jobs.c > > Is there a reason to rename v

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-06-21 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 02:48:38PM -0300, Luiz Capitulino wrote: > Yet another thread fork. > > After talking with Daniel and Markus about QMP errors (which is not just about > QMP, as this affects QEMU as whole), I've put together the proposal below. > > I'll discuss three points. First, the err

Re: [Qemu-devel] qemu -numa option and non-contiguous CPU ranges

2012-06-22 Thread Daniel P. Berrange
On Thu, Jun 21, 2012 at 11:39:46PM +0200, Andre Przywara wrote: > On 06/21/2012 07:51 PM, Eduardo Habkost wrote: > >Hi, > > > >I just noticed libvirt tries to use the -numa option in a way that qemu > >never understood: if a node is configured to have a non-contiguous set > >of CPUs, it tries to ge

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 07:22:51AM -0500, Anthony Liguori wrote: > On 06/22/2012 07:12 AM, Markus Armbruster wrote: > >Anthony Liguori writes: > >>Nack. > >> > >>Use a protocol. This is not what QMP events are designed for! > >> > >>No human is going to launch nc to a unix domain socket to launch

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 07:58:53AM -0500, Anthony Liguori wrote: > On 06/22/2012 07:31 AM, Daniel P. Berrange wrote: > >On Fri, Jun 22, 2012 at 07:22:51AM -0500, Anthony Liguori wrote: > >>On 06/22/2012 07:12 AM, Markus Armbruster wrote: > >>>Anthony Liguori writes

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: > On 06/22/2012 01:50 PM, Amit Shah wrote: > >On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: > >>On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: > >>> > >>>Oh, that's a good

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: > On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: > >On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: > >>On 06/22/2012 01:50 PM, Amit Shah wrote: > >>>On (Fri) 22 Jun 2012 [08

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 07:54:18AM -0500, Anthony Liguori wrote: > On 06/25/2012 07:30 AM, Daniel P. Berrange wrote: > >On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: > >>On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: > >>>On Fri, Jun 22, 201

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: > libvirt's sVirt security driver provides SELinux MAC isolation for > Qemu guest processes and their corresponding image files. In other > words, sVirt uses SELinux to prevent a QEMU process from opening > files that do not belong to i

Re: [Qemu-devel] [RFC 3/3] memory/qmp: add set-memory-merge command

2012-06-26 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 05:05:45PM -0500, Anthony Liguori wrote: > On 06/25/2012 11:55 AM, Luiz Capitulino wrote: > >Allow to enable/disable memory merging during run-time. > > > >This is implemented by extending the qemu_set_mem_merge() function. > > > >To test on HMP: > > > > (qemu) set_memory_

Re: [Qemu-devel] [RFC] Fixing the error failure

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 09:54:21AM +0200, Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 21 Jun 2012 13:42:19 +0100 > > "Daniel P. Berrange" wrote: > > > > [...] > > > >> > However, we'd change how we use &#x

Re: [Qemu-devel] [RFC 3/3] memory/qmp: add set-memory-merge command

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 09:53:32AM -0300, Luiz Capitulino wrote: > On Tue, 26 Jun 2012 10:25:22 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, Jun 25, 2012 at 05:05:45PM -0500, Anthony Liguori wrote: > > > On 06/25/2012 11:55 AM, Luiz Capitulino wrote: >

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 09:52:51AM -0400, Corey Bryant wrote: > >So now from a client's POV you'd have a flow like > > > >* drive_add "file=/dev/fd/N" FDSET={N} > > IIUC then drive_add would loop and pass each fd in the set via SCM_RIGHTS? Yes, you'd probably use the JSON to tell QEMU exactl

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 03:11:40PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 26, 2012 at 09:52:51AM -0400, Corey Bryant wrote: > > >So now from a client's POV you'd have a flow like > > > > > >* drive_add "file=/dev/fd/N" FDSET={N} > &

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-26 Thread Daniel P. Berrange
On Tue, Jun 26, 2012 at 02:40:03PM -0400, Corey Bryant wrote: > > > On 06/26/2012 11:37 AM, Corey Bryant wrote: > > > > > >On 06/26/2012 11:03 AM, Daniel P. Berrange wrote: > >>On Tue, Jun 26, 2012 at 03:11:40PM +0100, Daniel P. Berrange wrote: > >

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-27 Thread Daniel P. Berrange
On Wed, Jun 27, 2012 at 11:16:32AM +0200, Kevin Wolf wrote: > Am 27.06.2012 00:54, schrieb Eric Blake: > >> It seems like libvirt would be in a better position to understand when a > >> file is no longer in use, and then it can call close_fd. No? Of course > >> the the only fd that needs to be cl

Re: [Qemu-devel] [PATCH 5/6 v5] deal with guest panicked event accoring to -onpanic parameter

2012-06-27 Thread Daniel P. Berrange
On Wed, Jun 27, 2012 at 04:52:32PM +0200, Cornelia Huck wrote: > On Wed, 27 Jun 2012 15:02:23 +0800 > Wen Congyang wrote: > > > When the guest is panicked, it will write 0x1 to the port KVM_PV_PORT. > > So if qemu reads 0x1 from this port, we can do the folloing three > > things according to the

Re: [Qemu-devel] [RFC PATCH 0/6] option to not remove files inside -mem-path dir (v2)

2012-07-02 Thread Daniel P. Berrange
On Mon, Jul 02, 2012 at 03:06:32PM -0300, Eduardo Habkost wrote: > Resending series, after fixing some coding style issues. Does anybody has any > feedback about this proposal? > > Changes v1 -> v2: > - Coding style fixes > > Original cover letter: > > I was investigating if there are any mecha

Re: [Qemu-devel] [RFC PATCH 0/6] option to not remove files inside -mem-path dir (v2)

2012-07-03 Thread Daniel P. Berrange
On Mon, Jul 02, 2012 at 04:54:03PM -0300, Eduardo Habkost wrote: > On Mon, Jul 02, 2012 at 07:56:58PM +0100, Daniel P. Berrange wrote: > > On Mon, Jul 02, 2012 at 03:06:32PM -0300, Eduardo Habkost wrote: > > > Resending series, after fixing some coding style issues. Does anyb

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-03 Thread Daniel P. Berrange
On Mon, Jul 02, 2012 at 04:31:09PM -0600, Eric Blake wrote: > On 07/02/2012 04:02 PM, Corey Bryant wrote: > > > Here's another option that Kevin and I discussed today on IRC. I've > > modified a few minor details since the discussion. And Kevin please > > correct me if anything is wrong. > > > >

Re: [Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-07-09 Thread Daniel P. Berrange
On Sun, Jul 08, 2012 at 11:45:34PM +0100, Peter Maydell wrote: > On 8 July 2012 20:44, Michael Tokarev <1022...@bugs.launchpad.net> wrote: > > Please take this to your shell. The queston mark is a metacharacter for > > any *nix shell, you should just quote or backslash it. The same > > question m

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 04:54:08PM +0800, Wenchao Xia wrote: > Hi, Paolo and folks, > qemu have good capabilities to access different virtual disks, I want > to expose its block layer API to let 3rd party program linked in, such > as management stack or block tools, to access images data directly

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 06:07:48AM -0600, Eric Blake wrote: > On 07/09/2012 05:52 AM, Peter Maydell wrote: > > For command line options which permit '?' meaning 'please list the > > permitted values', add support for 'help' as a synonym, by abstracting > > the check out into a helper function. > >

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-10 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 04:00:37PM -0300, Luiz Capitulino wrote: > On Mon, 09 Jul 2012 13:40:34 -0500 > Anthony Liguori wrote: > > > On 06/26/2012 04:10 AM, Daniel P. Berrange wrote: > > > On Fri, Jun 22, 2012 at 02:36:07PM -0400, Corey Bryant wrote: > > >

Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface

2012-07-10 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 02:17:04PM -0500, miny...@acm.org wrote: > diff --git a/qemu-options.hx b/qemu-options.hx > index 125a4da..823f6bc 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2204,6 +2204,41 @@ Three button serial mouse. Configure the guest to use > Microsoft protocol. >

Re: [Qemu-devel] detecting seccomp sandbox capability via QMP

2012-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2012 at 03:42:32PM +0100, Ján Tomko wrote: > On 12/04/12 12:46, Luiz Capitulino wrote: > > On Mon, 03 Dec 2012 16:55:35 +0100 > > Ján Tomko wrote: > > > >> Hello, > >> > >> is there a way to check if QEMU was compiled with --enable-seccomp via QMP? > > > > Not that I'm aware of.

Re: [Qemu-devel] detecting seccomp sandbox capability via QMP

2012-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2012 at 01:13:46PM -0600, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Tue, Dec 04, 2012 at 03:42:32PM +0100, Ján Tomko wrote: > >> On 12/04/12 12:46, Luiz Capitulino wrote: > >> > On Mon, 03 Dec 2012 16:55:35 +0100 >

Re: [Qemu-devel] detecting seccomp sandbox capability via QMP

2012-12-06 Thread Daniel P. Berrange
On Tue, Dec 04, 2012 at 03:44:54PM -0600, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Tue, Dec 04, 2012 at 01:13:46PM -0600, Anthony Liguori wrote: > >> "Daniel P. Berrange" writes: > >> > >> > > >> &g

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-06 Thread Daniel P. Berrange
On Tue, Dec 04, 2012 at 01:04:48PM -0200, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > docs/virtio-balloon-stats.txt | 73 > +++ > 1 file changed, 73 insertions(+) > create mode 100644 docs/virtio-balloon-stats.txt > > diff --git a/doc

Re: [Qemu-devel] detecting seccomp sandbox capability via QMP

2012-12-06 Thread Daniel P. Berrange
On Thu, Dec 06, 2012 at 08:00:56AM -0600, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Tue, Dec 04, 2012 at 03:44:54PM -0600, Anthony Liguori wrote: > >> "Daniel P. Berrange" writes: > >> > >> > On Tue, Dec 04, 20

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Daniel P. Berrange
On Thu, Dec 20, 2012 at 11:49:29AM +0100, Michal Privoznik wrote: > On 19.12.2012 16:58, Gerd Hoffmann wrote: > > Hi, > > > > Chardev hotplug patch series reloaded. Not finished yet, commit > > messages not finalized yet, totally untested other than building on > > linux+windows. > > > > I dou

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Daniel P. Berrange
On Thu, Dec 20, 2012 at 12:45:33PM +0100, Gerd Hoffmann wrote: > I doubt I manage to finish (and test!) it before xmas. > > ^ > > > >>> Okay, the QMP interface seems sane to me (from libvirt POV). However, > >>> what about other chardev

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Daniel P. Berrange
On Fri, Dec 21, 2012 at 10:01:46AM +0100, Gerd Hoffmann wrote: > Hi, > > >> pty looks like another non-trivial challenge. How does libvirt gather > >> the pty device today? IIRC there is some stderr parsing? Or was it > >> info chardev? With QMP we probably want switch to a more sane model >

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Daniel P. Berrange
On Thu, Jan 03, 2013 at 02:23:03PM +0100, Gerd Hoffmann wrote: > Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty > support because it tried to figure the pts name from stderr output. > > Fix this by moving the label to the end of the line, this way the > libvirt parser does stil

Re: [Qemu-devel] [PATCH] sandbox: Report error on forbidden system call

2013-02-06 Thread Daniel P. Berrange
On Tue, Feb 05, 2013 at 09:28:51AM -0500, Corey Bryant wrote: > > On 02/05/2013 06:02 AM, Michal Privoznik wrote: > >Currently, it we call a not white listed system call, we get killed > >immediately without reporting any error. It would be far more useful, > >if we can at least shout something on

Re: [Qemu-devel] QMP's chardev-add less capable than HMP's

2013-02-06 Thread Daniel P. Berrange
On Wed, Feb 06, 2013 at 03:35:13PM +0100, Markus Armbruster wrote: > As a general rule, HMP commands must be built on top of the QMP API. > Luiz and others have worked long & hard to make HMP conform to this > rule. > > However, a new command has crept in that violates it. > > QMP's chardev-add r

Re: [Qemu-devel] [libvirt] q35 machine type and libvirt.

2013-02-07 Thread Daniel P. Berrange
On Wed, Feb 06, 2013 at 01:15:05PM -0700, Alex Williamson wrote: > On Wed, 2013-02-06 at 14:13 -0500, Laine Stump wrote: > > 2) Are there other issues aside from implicit controller devices I > > need to consider for q35? For example, are there any devices that (as > > I recall is the case for some

Re: [Qemu-devel] [PATCH] sandbox: Report error on forbidden system call

2013-02-08 Thread Daniel P. Berrange
On Fri, Feb 08, 2013 at 09:44:10AM -0500, Corey Bryant wrote: > > > On 02/05/2013 06:02 AM, Michal Privoznik wrote: > >Currently, it we call a not white listed system call, we get killed > >immediately without reporting any error. It would be far more useful, > >if we can at least shout something

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v5)

2013-02-20 Thread Daniel P. Berrange
On Wed, Feb 20, 2013 at 05:10:54PM +0100, Andreas Färber wrote: > Am 20.02.2013 14:43, schrieb Anthony Liguori: > > This includes a de_DE translation from Kevin Wolf and an it translation from > > Paolo Bonzini. > > > > Cc: Paolo Bonzini > > Cc: Kevin Wolf > > Cc: Stefan Hajnoczi > > Signed-off

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v5)

2013-02-20 Thread Daniel P. Berrange
On Wed, Feb 20, 2013 at 05:24:02PM +0100, Andreas Färber wrote: > Am 20.02.2013 17:16, schrieb Daniel P. Berrange: > > On Wed, Feb 20, 2013 at 05:10:54PM +0100, Andreas Färber wrote: > >> Am 20.02.2013 14:43, schrieb Anthony Liguori: > >>> This includes a de_DE tran

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v5)

2013-02-20 Thread Daniel P. Berrange
On Wed, Feb 20, 2013 at 06:19:49PM +0100, Andreas Färber wrote: > Am 20.02.2013 17:53, schrieb Daniel P. Berrange: > > On Wed, Feb 20, 2013 at 05:24:02PM +0100, Andreas Färber wrote: > >> Am 20.02.2013 17:16, schrieb Daniel P. Berrange: > >>> On Wed, Feb 20, 201

Re: [Qemu-devel] [PATCH v2] ui/vnc: VA API based H.264 encoding for VNC

2013-02-21 Thread Daniel P. Berrange
On Wed, Feb 13, 2013 at 11:45:04AM +0100, David Verbeiren wrote: > This patch implements H.264 encoding of the VNC framebuffer updates > using hardware acceleration through the VA API. > > This is experimental support to let the community explore the possibilities > offered by the potential bandwi

Re: [Qemu-devel] GTK UI is now the default

2013-02-22 Thread Daniel P. Berrange
On Fri, Feb 22, 2013 at 11:12:35AM +0100, Laurent Desnogues wrote: > On Fri, Feb 22, 2013 at 12:04 AM, Anthony Liguori wrote: > > > > Since this is a pretty visible change for a lot of people, I thought I'd > > send a top level note. The GTK UI is now committed and is the default > > UI provided

  1   2   3   4   5   6   7   8   9   10   >