Re: [PATCH v5 6/8] configure: Enable test and libs for zstd

2020-02-14 Thread Daniel P . Berrangé
On Thu, Feb 13, 2020 at 10:08:59PM +0100, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Jan 29, 2020 at 12:56:53PM +0100, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela > >> Reviewed-by: Dr. David Alan Gilbert &g

Re: docs: Update vhost-user spec regarding backend program conventions

2020-02-14 Thread Daniel P . Berrangé
On Fri, Feb 14, 2020 at 03:00:34PM +0100, Marc-André Lureau wrote: > Hi > > On Fri, Feb 14, 2020 at 2:24 PM Boeuf, Sebastien > wrote: > > > > Hi Marc-Andre, > > > > On Tue, 2020-02-11 at 22:24 +0100, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, Feb 11, 2020 at 4:24 PM Boeuf, Sebastien >

Re: Error compiling Qemu-4.1 on Linux

2019-12-05 Thread Daniel P . Berrangé
On Thu, Dec 05, 2019 at 01:40:11PM +, aijaz.b...@protonmail.com wrote: > Hello > > I’m trying to compile Qemu from sources and as such face the well known > errors of requiring Glib-2.4 and gthread-2.0 > > ERROR: glib-2.40 gthread-2.0 is required to compile QEMU > > I’m on Linux Mint and I’

[PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Daniel P . Berrangé
Mention that this is a PCI device address & give the format it is expected it. Also mention that it must be first unbound from any host kernel driver. Signed-off-by: Daniel P. Berrangé --- qapi/block-core.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/b

Re: [PATCH] qapi: better document NVMe blockdev @device parameter

2019-12-06 Thread Daniel P . Berrangé
On Fri, Dec 06, 2019 at 08:51:15AM -0600, Eric Blake wrote: > On 12/6/19 8:38 AM, Daniel P. Berrangé wrote: > > Mention that this is a PCI device address & give the format it is > > expected it. Also mention that it must be first unbound from any > > maybe s/expec

Re: Error compiling Qemu-4.1 on Linux

2019-12-06 Thread Daniel P . Berrangé
On Fri, Dec 06, 2019 at 04:55:37PM +, aijaz.b...@protonmail.com wrote: > Here is the content of config.log: https://pastebin.com/6zrSXWAG > > I am configuring it for 'arm-softmmu' as can be seen from the above paste Looks like it is failing on $ pkg-config --atleast-version=2.40 gthread-

Re: Insufficiently documented deprecated command arguments

2019-12-11 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 01:24:17PM +0100, Kevin Wolf wrote: > Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: > > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > > > Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > > > > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbrust

Re: [PATCH] build-sys: build vhost-user-gpu only if CONFIG_TOOLS

2019-12-11 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 03:23:22PM +0100, Paolo Bonzini wrote: > From: Marc-André Lureau > > vhost-user-gpu is always built and installed, but it is not part of the > emulator > proper. Cut it if --disable-tools is specified. I don't feel like this is something that people would really conside

Re: [PATCH] ff Signed-off-by: Paolo Bonzini

2019-12-11 Thread Daniel P . Berrangé
Missing commit message subject line :-) On Wed, Dec 11, 2019 at 03:46:33PM +0100, Paolo Bonzini wrote: > --- > hw/ppc/e500.c | 1 - > hw/ppc/spapr_irq.c | 8 > 2 files changed, 9 deletions(-) > > diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c > index 928efaa..12b6a5b 100644 > --- a/hw/

Re: [PATCH v6 3/8] docs: start a document to describe D-Bus usage

2019-12-12 Thread Daniel P . Berrangé
quot; prefix is reserved for the QEMU project. Perhaps change the last few words to 'for services implemented & distributed by the QEMU project' > diff --git a/docs/interop/index.rst b/docs/interop/index.rst > index 3e33fb5933..ded134ea75 100644 > --- a/docs/interop/index.rst > +++ b/docs/interop/index.rst > @@ -13,6 +13,7 @@ Contents: > :maxdepth: 2 > > bitmaps > + dbus > live-block-operations > pr-helper > qemu-ga Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v6 4/8] util: add dbus helper unit

2019-12-12 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 05:45:02PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > MAINTAINERS | 2 ++ > include/qemu/dbus.h | 18 +++ > util/Makefile.objs | 3 +++ > util/dbus.c | 55 + > 4 file

Re: [PATCH v6 5/8] Add dbus-vmstate object

2019-12-12 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 05:45:03PM +0400, Marc-André Lureau wrote: > When instantiated, this object will connect to the given D-Bus bus > "addr". During migration, it will take/restore the data from > org.qemu.VMState1 instances. See documentation for details. > > Signed-off-by: Marc-André Lureau

Re: [PATCH v6 6/8] configure: add GDBUS_CODEGEN

2019-12-12 Thread Daniel P . Berrangé
onfig_host_mak > + echo "GDBUS_CODEGEN=$gdbus_codegen" >> $config_host_mak > fi > echo "CONFIG_TLS_PRIORITY=\"$tls_priority\"" >> $config_host_mak > if test "$gnutls" = "yes" ; then Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v6 7/8] dockerfiles: add dbus-daemon to some of latest distributions

2019-12-12 Thread Daniel P . Berrangé
s/fedora.docker | 1 + > tests/docker/dockerfiles/ubuntu.docker | 1 + > 4 files changed, 4 insertions(+) For docker Reviewed-by: Daniel P. Berrangé Does it need adding to travis, gitlab, shippable, etc CI configs too ? Regards, Daniel -- |: https://berrange.com -o-ht

Re: [PATCH v6 8/8] tests: add dbus-vmstate-test

2019-12-12 Thread Daniel P . Berrangé
On Wed, Dec 11, 2019 at 05:45:06PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > MAINTAINERS | 1 + > tests/Makefile.include | 22 +- > tests/dbus-vmstate-daemon.sh | 95 + > tests/dbus-vmstate-test.c| 399 +++

Re: [libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough

2019-12-13 Thread Daniel P . Berrangé
On Fri, Dec 13, 2019 at 04:07:06PM +0100, Peter Krempa wrote: > On Fri, Dec 13, 2019 at 15:56:08 +0100, Paolo Bonzini wrote: > > On 13/12/19 15:46, Stefan Hajnoczi wrote: > > > The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough > > > support. Deprecate this feature in QEMU to

Re: [PATCH v6 8/8] tests: add dbus-vmstate-test

2019-12-16 Thread Daniel P . Berrangé
On Fri, Dec 13, 2019 at 06:20:15PM +, Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Signed-off-by: Marc-André Lureau > > > +static gboolean > > +vmstate_save(VMState1 *object, GDBusMethodInvocation *invocation, > > + gpointer user_dat

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-25 Thread Daniel P . Berrangé
On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: > On Monday, November 25, 2019, Philippe Mathieu-Daudé > wrote: > > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > > logical change was in 2005 (9542611a6). After we can count 164 > > maintenance commits (QE

[PATCH] block: always fill entire LUKS header space with zeros

2019-11-25 Thread Daniel P . Berrangé
fail for any pre-existing disk images created prior to this change, unless at least 1 byte of the payload is written to. Fully writing zeros to the entire LUKS header is a good idea regardless as it ensures that space has been allocated on the host filesystem (or whatever block storage backend

Re: virtiofsd: Where should it live?

2019-11-26 Thread Daniel P . Berrangé
On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle. > >

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-26 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 11:04:41AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: > >> Tao Xu writes: > >> > >> > Add do_strtomul() to convert string according to different suffixes. > >> > > >> > Reviewed-by: E

Re: [RFC 00/10] R300 QEMU device V2

2019-11-26 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 06:14:27PM +0530, aaron.zakh...@gmail.com wrote: > From: Aaron Dominick > > I have removed the botched patches and have got the code working upto the > GART initialization. > I am not sure how to implement the GART. I am guessing it should be an IOMMU > device but I thin

Re: [RFC 00/10] R300 QEMU device V2

2019-11-27 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 04:00:01PM +0100, Philippe Mathieu-Daudé wrote: > Hi Daniel, Aaron. > > On 11/26/19 3:19 PM, Daniel P. Berrangé wrote: > > On Tue, Nov 26, 2019 at 06:14:27PM +0530, aaron.zakh...@gmail.com wrote: > > > From: Aaron Dominick > > > > &g

Re: [RFC 00/10] R300 QEMU device V2

2019-11-27 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 04:13:18PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing more. > > On 11/27/19 4:05 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 27, 2019 at 04:00:01PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi Daniel, Aaron. > > > > > >

Re: [RFC 00/10] R300 QEMU device V2

2019-11-27 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 05:12:10PM +0100, Gerd Hoffmann wrote: > Hi, > > > It does become a slight usability issue, as any users need to go and find > > the suitable BIOS in order to use the device. No downstream OS vendors are > > going to be able to distribute this BIOS either > > > > I don't

Re: [PATCH RFC] qga: fence guest-set-time if hwclock not available

2019-11-28 Thread Daniel P . Berrangé
On Thu, Nov 28, 2019 at 01:36:58PM +0100, Cornelia Huck wrote: > The Posix implementation of guest-set-time invokes hwclock to > set/retrieve the time to/from the hardware clock. If hwclock > is not available, the user is currently informed that "hwclock > failed to set hardware clock to system tim

Re: [PATCH v5] qga: add command guest-get-devices for reporting VirtIO devices

2019-11-28 Thread Daniel P . Berrangé
On Thu, Nov 28, 2019 at 01:45:13PM +0100, Tomáš Golembiovský wrote: > Add command for reporting devices on Windows guest. The intent is not so > much to report the devices but more importantly the driver (and its > version) that is assigned to the device. This gives caller the > information whether

Re: [PATCH 1/7] console: add graphic_hw_update_done()

2019-11-28 Thread Daniel P . Berrangé
h| 2 ++ > ui/console.c| 9 + > 4 files changed, 19 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop1

Re: [PATCH RFC] qga: fence guest-set-time if hwclock not available

2019-11-28 Thread Daniel P . Berrangé
On Thu, Nov 28, 2019 at 01:49:32PM +0100, Cornelia Huck wrote: > On Thu, 28 Nov 2019 12:45:32 + > Daniel P. Berrangé wrote: > > > On Thu, Nov 28, 2019 at 01:36:58PM +0100, Cornelia Huck wrote: > > > The Posix implementation of guest-set-time invokes hwclock to > &

Re: [PATCH 0/2] RFC: add -mem-shared option

2019-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 11:30:51AM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Nov 29, 2019 at 11:03 AM Gerd Hoffmann wrote: > > > > On Thu, Nov 28, 2019 at 06:15:16PM +0400, Marc-André Lureau wrote: > > > Hi, > > > > > > Setting up shared memory for vhost-user is a bit complicated from > >

Re: libcap vs libcap-ng mess

2019-11-29 Thread Daniel P . Berrangé
On Thu, Nov 28, 2019 at 07:04:08PM +, Dr. David Alan Gilbert wrote: > Hi, > We seem to have a bit of a mess with libcap and libcap-ng; and I'm not > sure if we should try and untangle it. > > a) Our configure script has tests for both libcap and libcap-ng > for libcap it says $cap, for lib

Re: [PATCH v2] qga: fence guest-set-time if hwclock not available

2019-11-29 Thread Daniel P . Berrangé
> Signed-off-by: Cornelia Huck > --- > > v1 (RFC) -> v2: > - use hwclock_path[] > - use access() instead of stat() > > --- > qga/commands-posix.c | 13 ++++- > 1 file changed, 12 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards

Re: [PATCH 0/2] RFC: add -mem-shared option

2019-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 10:33:39AM +0100, Paolo Bonzini wrote: > On 29/11/19 10:27, Daniel P. Berrangé wrote: > >> Yes, with a fallback path currently using a temporary file under /tmp > >> (we may want to use shm_open() instead, or a different location such > >>

Re: [PATCH 0/2] RFC: add -mem-shared option

2019-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 01:31:11PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Nov 29, 2019 at 1:27 PM Daniel P. Berrangé > wrote: > > > > On Fri, Nov 29, 2019 at 11:30:51AM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-11-29 Thread Daniel P . Berrangé
On Wed, Nov 20, 2019 at 06:43:19AM -0500, Janosch Frank wrote: > Most of the QEMU changes for PV are related to the new IPL type with > subcodes 8 - 10 and the execution of the necessary Ultravisor calls to > IPL secure guests. Note that we can only boot into secure mode from > normal mode, i.e. st

Re: [PATCH] virtfs-proxy-helper: switch from libcap to libcap-ng

2019-11-29 Thread Daniel P . Berrangé
; --- > configure | 18 +-- > fsdev/virtfs-proxy-helper.c | 100 > 2 files changed, 46 insertions(+), 72 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrang

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 01:14:27PM +0100, Janosch Frank wrote: > On 11/29/19 12:08 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 20, 2019 at 06:43:19AM -0500, Janosch Frank wrote: > >> Most of the QEMU changes for PV are related to the new IPL type with > >> subcodes

Re: [PATCH] ci: Use libcap-ng

2019-11-29 Thread Daniel P . Berrangé
v >xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev > librbd-dev > - ./configure --cc=clang --cxx=clang++ --enable-werror > --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu Reviewed-by: Daniel P. Berrangé Regards, Daniel --

Re: [PATCH] virtfs-proxy-helper: switch from libcap to libcap-ng

2019-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 12:16:32PM +0100, Paolo Bonzini wrote: > virtfs-proxy-helper is the only user of libcap; everyone else is using > the simpler libcap-ng API. Switch and remove the configure code to > detect libcap. > > Signed-off-by: Paolo Bonzini > --- > configure | 1

Re: [PATCH 00/21] Error handling fixes, may contain 4.2 material

2019-12-02 Thread Daniel P . Berrangé
On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: > PATCH 2-4 fix crash bugs. Including them would be a no-brainer at > -rc0. But we're post -rc3, and even for crash bugs we require a > certain likelihood of users getting bitten. > > Jens, please assess impact of PATCH 2's crash

Re: [PATCH 2/7] ppm-save: pass opened fd

2019-12-02 Thread Daniel P . Berrangé
off-by: Marc-André Lureau > --- > ui/console.c| 45 ++--- > ui/trace-events | 2 +- > 2 files changed, 23 insertions(+), 24 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://w

Re: [PATCH 3/7] ui: add pixman image g_autoptr support

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:51:58PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/ui/qemu-pixman.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://ww

Re: [PATCH 4/7] object: add g_autoptr support

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:51:59PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/qom/object.h | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flick

Re: [PATCH 5/7] screendump: replace FILE with QIOChannel and fix close()/qemu_close()

2019-12-02 Thread Daniel P . Berrangé
-off-by: Marc-André Lureau > --- > ui/console.c | 38 +- > 1 file changed, 17 insertions(+), 21 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvi

Re: [PATCH 7/7] screendump: use qemu_unlink()

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:52:02PM +0400, Marc-André Lureau wrote: > Don't attempt to remove /dev/fdset files. > > Signed-off-by: Marc-André Lureau > --- > ui/console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regar

Re: [PATCH 6/7] osdep: add qemu_unlink()

2019-12-02 Thread Daniel P . Berrangé
--- > include/qemu/osdep.h | 1 + > util/osdep.c | 15 +++ > 2 files changed, 16 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [PATCH] io/channel-websock: treat 'binary' and no sub-protocol as the same

2019-12-02 Thread Daniel P . Berrangé
44 > > Signed-off-by: Yu-Chen Lin > --- > io/channel-websock.c | 35 +++ > 1 file changed, 23 insertions(+), 12 deletions(-) Thank you, I have queued this for 5.0. Signed-off-by: Daniel P. Berrangé Also CC'ing stable for the first 4

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-12-03 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 03:02:41PM +0100, Janosch Frank wrote: > On 11/29/19 1:35 PM, Daniel P. Berrangé wrote: > > Is there any way to prevent a guest from using protected mode even > > if QEMU supports it ? eg the mgmt app may want to be able to > > guarantee that all V

Re: virtiofsd: Where should it live?

2019-12-03 Thread Daniel P . Berrangé
On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > wrote: > > > > We seem to be coming to the conclusion something that: > > > > a) It should live in the qemu tree > > b) It shouldn't live under contrib > > c) We'll create

Re: [PATCH v2 01/18] crypto: Fix certificate file error handling crash bug

2019-12-04 Thread Daniel P . Berrangé
this > logs a ERROR_OVERWRITTEN_WARNING warning message and leaves @gerr > unchanged. qcrypto_tls_creds_load_cert() then dereferences the > uninitialized @gerr. > > Fix by initializing @gerr properly. > > Fixes: 9a2fd4347c40321f5cbb4ab4220e759fcbf87d03 > Cc: "Daniel P. Be

Re: [PATCH v2 02/18] crypto: Fix typo in QCryptoTLSSession's comment

2019-12-04 Thread Daniel P . Berrangé
On Wed, Dec 04, 2019 at 10:36:09AM +0100, Markus Armbruster wrote: > Cc: "Daniel P. Berrangé" > Signed-off-by: Markus Armbruster > --- > include/crypto/tlssession.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Daniel P. Berrangé Reg

Re: [PATCH v2 03/18] io: Fix Error usage in a comment

2019-12-04 Thread Daniel P . Berrangé
On Wed, Dec 04, 2019 at 10:36:10AM +0100, Markus Armbruster wrote: > Cc: "Daniel P. Berrangé" > Signed-off-by: Markus Armbruster > --- > include/io/task.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Daniel P. Berrangé Regards, Daniel -- |: htt

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-09 Thread Daniel P . Berrangé
On Fri, Aug 09, 2019 at 08:06:09AM +0800, Wei Yang wrote: > On Thu, Aug 08, 2019 at 10:22:13AM +0100, Daniel P. Berrangé wrote: > >On Thu, Aug 08, 2019 at 04:46:53PM +0800, Wei Yang wrote: > >> On Thu, Aug 08, 2019 at 09:02:29AM +0100, Daniel P. Berrangé wrote: > >> >

Re: [Qemu-devel] Does i386-linux-user build on an i686 host?

2019-08-09 Thread Daniel P . Berrangé
On Fri, Aug 09, 2019 at 01:49:07PM +0100, Peter Maydell wrote: > On Fri, 9 Aug 2019 at 13:22, Peter Maydell wrote: > > > > On Thu, 8 Aug 2019 at 16:37, Markus Armbruster wrote: > > > > > > Fails for me, but perhaps I'm doing it wrong: > > > > > > > NOTE: cross-compilers enabled: 'cc' > > > $ mak

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: > When we have lots of channels, sometimes multifd migration fails > with the following error: > > (qemu) migrate -d tcp:0: > (qemu) qemu-system-x86_64: multifd_send_pages: channel 17 has already quit! > qemu-system-x86_64: multifd

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Mon, Aug 19, 2019 at 12:33:45PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: > >> When we have lots of channels, sometimes multifd migration fails > >> with the following error: > >

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Mon, Aug 19, 2019 at 12:46:20PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Aug 14, 2019 at 04:02:18AM +0200, Juan Quintela wrote: > >> When we have lots of channels, sometimes multifd migration fails > >> with the following error: > >&

Re: [Qemu-devel] [PATCH 6/6] RFH: We lost "connect" events

2019-08-19 Thread Daniel P . Berrangé
On Mon, Aug 19, 2019 at 12:00:15PM +0100, Peter Maydell wrote: > On Mon, 19 Aug 2019 at 11:50, Daniel P. Berrangé wrote: > > I don't think we want to expose this in the QAPI schema for the socket > > address, since the correct value is really something that QEMU should >

Re: [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 10:24:55AM +0200, Juan Quintela wrote: > Current parameter was always one. We continue with that value for now > in all callers. > > Signed-off-by: Juan Quintela > --- > include/qemu/sockets.h| 2 +- > io/channel-socket.c | 2 +- > qga/channel-posix.c |

Re: [Qemu-devel] [PATCH v2 2/5] socket: Add num connections to qio_channel_socket_sync()

2019-08-20 Thread Daniel P . Berrangé
scsi/qemu-pr-helper.c | 2 +- > tests/test-char.c | 4 ++-- > tests/test-io-channel-socket.c | 2 +- > tests/tpm-emu.c| 2 +- > 8 files changed, 13 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https

Re: [Qemu-devel] [PATCH v2 3/5] socket: Add num connections to qio_channel_socket_async()

2019-08-20 Thread Daniel P . Berrangé
nnel-socket.c | 2 +- > 4 files changed, 27 insertions(+), 9 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https

Re: [Qemu-devel] [PATCH v2 4/5] socket: Add num connections to qio_net_listener_open_sync()

2019-08-20 Thread Daniel P . Berrangé
| 2 +- > qemu-nbd.c| 2 +- > scsi/qemu-pr-helper.c | 3 ++- > ui/vnc.c | 4 ++-- > 8 files changed, 12 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr

Re: [Qemu-devel] [PATCH v2 5/5] multifd: Use number of channels as listen backlog

2019-08-20 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 10:24:59AM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/socket.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [Qemu-devel] [PATCH v4 2/2] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-08-20 Thread Daniel P . Berrangé
() at vl.c:1885 > #16 0x5558b819140d in main_loop () at vl.c:1924 > #17 0x5558b8198c84 in main (argc=18, argv=0x7ffc355df3f8, > envp=0x7ffc355df490) at vl.c:4665 > > This patch adds a lock to protect tcp_chr_disconnect() and > socket_reconnect_timeout() > > Si

Re: [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen

2019-08-20 Thread Daniel P . Berrangé
2 +- > io/channel-socket.c | 2 +- > qga/channel-posix.c | 2 +- > tests/test-util-sockets.c | 12 ++-- > util/qemu-sockets.c | 33 ++--- > util/trace-events | 3 +++ > 6 files changed, 34 insertions(+), 20 deletions(-

Re: [Qemu-devel] [PATCH 0/2] ssh: add password and privkey auth methods

2019-07-26 Thread Daniel P . Berrangé
On Fri, Jul 26, 2019 at 04:35:27PM +0100, Richard W.M. Jones wrote: > On Fri, Jul 26, 2019 at 10:06:43AM -0500, Eric Blake wrote: > > On 7/26/19 9:45 AM, Pino Toscano wrote: > > > On Friday, 26 July 2019 16:27:11 CEST Richard W.M. Jones wrote: > > >> On Fri, Jul 26, 2019 at 04:09:52PM +0200, Pino T

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Daniel P . Berrangé
On Sat, Jul 27, 2019 at 07:20:15PM +0100, Peter Maydell wrote: > On Sat, 27 Jul 2019 at 13:24, Paolo Bonzini wrote: > > > > On 27/07/19 09:16, Markus Armbruster wrote: > > > We started with a single trace-events. That wasn't good, so we split it > > > up into one per directory. That isn't good,

Re: [Qemu-devel] [for 4.1 PATCH] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs"

2019-07-29 Thread Daniel P . Berrangé
On Mon, Jul 29, 2019 at 04:59:09PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This reverts commit f2784eed306449c3d04a71a05ed6463b8289aedf > since that accidentally removes the PCIe capabilities from virtio > devices because virtio_pci_dc_realize is called bef

Re: [Qemu-devel] [PATCH v2 1/2] Revert "Revert "globals: Allow global properties to be optional""

2019-07-29 Thread Daniel P . Berrangé
in. > > Signed-off-by: Dr. David Alan Gilbert > --- > include/hw/qdev-core.h | 3 +++ > qom/object.c | 3 +++ > 2 files changed, 6 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.c

Re: [Qemu-devel] [PATCH v2 2/2] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs"

2019-07-29 Thread Daniel P . Berrangé
hw/virtio/virtio-crypto-pci.c | 4 +--- > hw/virtio/virtio-input-pci.c | 4 +--- > hw/virtio/virtio-pci.c| 26 ++ > hw/virtio/virtio-pci.h| 31 ++- > 7 files changed, 23 insertions(+), 73 deletions(-) Reviewed-by: Da

Re: [Qemu-devel] [For 4.1 PATCH v2 0/2] Reversions to fix PCIe in virtio

2019-07-29 Thread Daniel P . Berrangé
On Mon, Jul 29, 2019 at 05:43:17PM +0100, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 17:36, Dr. David Alan Gilbert > wrote: > > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Mon, 29 Jul 2019 17:29:01 +0100 > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Ala

Re: [Qemu-devel] When to use qemu/typedefs.h

2019-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2019 at 11:45:41AM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2019 at 09:40, Thomas Huth wrote: > > IMHO we should get rid of mandating typedefs. They are causing too much > > trouble - e.g. do you also remember the issues with duplicated typedefs > > in certain compiler versions

Re: [Qemu-devel] [PATCH v2 0/3] require newer glib2 to enable autofree'ing of stack variables exiting scope

2019-07-31 Thread Daniel P . Berrangé
On Wed, Jul 31, 2019 at 03:04:29PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > Both GCC and CLang support a C extension attribute((cleanup)) which > > allows you to define a function that is invoked when a stack variable > > exits scope. This typica

Re: [Qemu-devel] [PATCH v2] virtiofsd: fix compile error if 'F_OFD_GETLK' not defined

2019-08-02 Thread Daniel P . Berrangé
On Fri, Aug 02, 2019 at 11:53:52AM +0100, Dr. David Alan Gilbert wrote: > * piaojun (piao...@huawei.com) wrote: > > Use F_GETLK for fcntl when F_OFD_GETLK not defined, such as kernel 3.10. > > > > Signed-off-by: Jun Piao > > > > --- > > v2: > > - Use F_OFD_SETLK to replace F_OFD_GETLK in #ifdef

Re: [Qemu-devel] [PATCH] crypto: move common bits for all emulators to libqemuutil

2019-08-06 Thread Daniel P . Berrangé
On Tue, Aug 06, 2019 at 09:11:15AM +0200, Paolo Bonzini wrote: > qcrypto_random_*, AES and qcrypto_init do not need to be linked as a whole > and are the only parts that are used by user-mode emulation. Place them > in libqemuutil, so that whatever needs them will pick them up automatically. > >

Re: [Qemu-devel] [RFC PATCH-for-4.1] Makefile: Fix the NSIS Windows builds

2019-08-06 Thread Daniel P . Berrangé
ists.gnu.org/archive/html/qemu-devel/2019-07/msg03204.html > > $ file qemu-setup-4.0.90.exe > qemu-setup-4.0.90.exe: PE32 executable (GUI) Intel 80386 (stripped to > external PDB), for MS Windows, Nullsoft Installer self-extracting archive > --- > Makefile | 1 + > 1 file cha

Re: [Qemu-devel] [PATCH] crypto: move common bits for all emulators to libqemuutil

2019-08-06 Thread Daniel P . Berrangé
On Tue, Aug 06, 2019 at 03:07:40PM +0200, Paolo Bonzini wrote: > On 06/08/19 11:41, Daniel P. Berrangé wrote: > > On Tue, Aug 06, 2019 at 09:11:15AM +0200, Paolo Bonzini wrote: > >> qcrypto_random_*, AES and qcrypto_init do not need to be linked as a whole > >> and are t

Re: [Qemu-devel] [RFC PATCH-for-4.1] Makefile: Fix the NSIS Windows builds

2019-08-06 Thread Daniel P . Berrangé
On Tue, Aug 06, 2019 at 02:25:27PM +0100, Peter Maydell wrote: > On Tue, 6 Aug 2019 at 13:44, Daniel P. Berrangé wrote: > > > > On Sat, Jul 13, 2019 at 06:58:56PM +0200, Philippe Mathieu-Daudé wrote: > > > The qemu-nsis.bmp file was not listed with the other blobs, thus &g

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-08 Thread Daniel P . Berrangé
On Thu, Aug 08, 2019 at 10:07:23AM +0800, Wei Yang wrote: > Current qemu fails tests/test-util-filemonitor. You'll need to provide more info. The test works for me and passes in all the QEMU CI environments. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/db

Re: [Qemu-devel] [Fail] tests/test-util-filemonitor fails

2019-08-08 Thread Daniel P . Berrangé
On Thu, Aug 08, 2019 at 04:46:53PM +0800, Wei Yang wrote: > On Thu, Aug 08, 2019 at 09:02:29AM +0100, Daniel P. Berrangé wrote: > >On Thu, Aug 08, 2019 at 10:07:23AM +0800, Wei Yang wrote: > >> Current qemu fails tests/test-util-filemonitor. > > > >You'll need t

Re: [Qemu-devel] [RFC PATCH 1/6] utils/python_api: add scripting interface for Qemu with python lib

2019-08-08 Thread Daniel P . Berrangé
On Wed, Aug 07, 2019 at 12:44:40PM +0530, Balamuruhan S wrote: > Adds scripting interface with python library to call functions in > python modules from Qemu that can be used to feed input externally > and without recompiling Qemu that can be used for early development, > testing and can be extende

Re: [Qemu-devel] [RFC PATCH 1/6] utils/python_api: add scripting interface for Qemu with python lib

2019-08-08 Thread Daniel P . Berrangé
On Thu, Aug 08, 2019 at 11:10:13AM +0100, Stefan Hajnoczi wrote: > On Wed, Aug 07, 2019 at 12:20:47PM +0200, Philippe Mathieu-Daudé wrote: > > > +void python_args_clean(char *args[], int nargs) > > > +{ > > > +for (int i = 0; i < nargs; i++) { > > > +g_free(args[i]); > > > +} > > >

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-04 Thread Daniel P . Berrangé
On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > [adding Markus] > > > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: > >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: > >>> On 1/31/20

Re: Does Libvirt's json parser support single quoted string in qmp json string?

2020-02-04 Thread Daniel P . Berrangé
On Tue, Feb 04, 2020 at 09:11:27AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > [adding Markus] > > > > On 2/3/20 4:13 AM, Daniel P. Berrangé wrote: > >> On Fri, Jan 31, 2020 at 06:44:42AM -0600, Eric Blake wrote: > >>> On 1/31/20

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

2020-02-04 Thread Daniel P . Berrangé
On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > Although I've never experienced it, due to not running Windows guests, I've > recently learned that a Windows guest permits a user (hopefully only one > with local admin privileges??!) to "hot-unplug" any PCI device. I've also > learned

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

2020-02-05 Thread Daniel P . Berrangé
On Wed, Feb 05, 2020 at 10:30:11AM +0100, Kevin Wolf wrote: > Am 05.02.2020 um 09:24 hat Markus Armbruster geschrieben: > > Daniel, Kevin, any comments or objections to the QAPI schema design > > sketch developed below? > > > > For your convenience, here's the result again: > > > > { 'enum':

Re: Disabling PCI "hot-unplug" for a guest (and/or a single PCI device)

2020-02-05 Thread Daniel P . Berrangé
On Tue, Feb 04, 2020 at 11:35:37AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 04, 2020 at 05:13:54PM +0100, Julia Suvorova wrote: > > On Tue, Feb 4, 2020 at 11:26 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Feb 03, 2020 at 05:19:51PM -0500, Laine Stump wrote: > > > > 3) qemu could add a "

Re: [PATCH for-5.0 3/4] Remove the core bluetooth code

2020-02-05 Thread Daniel P . Berrangé
On Wed, Feb 05, 2020 at 06:40:31PM +0100, Aleksandar Markovic wrote: > On Sat, Feb 1, 2020 at 7:53 PM Philippe Mathieu-Daudé wrote: > > > > > >> @@ -1151,10 +1150,6 @@ for opt do > > > >>;; > > > >>--enable-brlapi) brlapi="yes" > > > >>;; > > > >> - --disable-bluez) bluez="no" > > > >

Re: [PATCH for-5.0 3/4] Remove the core bluetooth code

2020-02-05 Thread Daniel P . Berrangé
On Wed, Feb 05, 2020 at 06:46:24PM +0100, Thomas Huth wrote: > On 05/02/2020 18.40, Aleksandar Markovic wrote: > > On Sat, Feb 1, 2020 at 7:53 PM Philippe Mathieu-Daudé > > wrote: > >> > >> On Sat, Feb 1, 2020 at 7:51 PM Thomas Huth wrote: > >>> On 01/02/2020 17.09, Philippe Mathieu-Daudé wrote:

Re: [PATCH for-5.0 3/4] Remove the core bluetooth code

2020-02-06 Thread Daniel P . Berrangé
On Wed, Feb 05, 2020 at 08:13:19PM +0100, Philippe Mathieu-Daudé wrote: > On 2/5/20 6:51 PM, Daniel P. Berrangé wrote: > > On Wed, Feb 05, 2020 at 06:40:31PM +0100, Aleksandar Markovic wrote: > >> On Sat, Feb 1, 2020 at 7:53 PM Philippe Mathieu-Daudé > >> wrote:

Re: qmp-shell for GSoC/Outreachy?

2020-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2020 at 10:40:37AM +0100, Markus Armbruster wrote: > > If the user screwsup, it should give an error that prompts the user > > to the parameter they got wrong. > > > > Output from commands should normally be pretty formatted (with an option > > to display raw json for those needing

Re: qmp-shell for GSoC/Outreachy?

2020-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2020 at 01:11:58PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Feb 06, 2020 at 10:40:37AM +0100, Markus Armbruster wrote: > >> > If the user screwsup, it should give an error that prompts the user > >>

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

2020-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2020 at 02:20:11PM +0100, Markus Armbruster wrote: > One more question regarding the array in > > { 'struct': 'QCryptoBlockAmendOptionsLUKS', > 'data' : { > 'keys': ['LUKSKeyslotUpdate'], > '*unlock-secret' : 'str' } } > > Why an array?

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

2020-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2020 at 02:44:45PM +0100, Markus Armbruster wrote: > Markus Armbruster writes: > > > Kevin Wolf writes: > > > >> Am 05.02.2020 um 11:03 hat Markus Armbruster geschrieben: > >>> Kevin Wolf writes: > [...] > >>> > Adding a key gets more complicated with your proposed interface bec

Re: should we have a new 'tools' manual?

2020-02-07 Thread Daniel P . Berrangé
On Fri, Feb 07, 2020 at 11:50:37AM +, Peter Maydell wrote: > So far we've been converting docs to Sphinx and assigning them > to manuals according to the division originally set out by > Paolo on the wiki: https://wiki.qemu.org/Features/Documentation > > * QEMU User-mode Emulation User's Guid

[PULL 0/3] Misc patches

2020-02-07 Thread Daniel P . Berrangé
x compatibility with noVNC in websocket impl * Remove inaccurate docs aout default NIC model -------- Daniel P. Berrangé (1): docs: stop documenting the e1000 NIC model as the default Jafar Abdi (1): authz: fix usage of bool in listfile.c

[PULL 2/3] authz: fix usage of bool in listfile.c

2020-02-07 Thread Daniel P . Berrangé
r variables that are declared as "bool" (the type from ). Signed-off-by: Jafar Abdi Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- authz/listfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/authz/listfile.c b/authz/listfile.c index e7a8c19bcb.

[PULL 3/3] docs: stop documenting the e1000 NIC model as the default

2020-02-07 Thread Daniel P . Berrangé
2.11. Rather than try to explain which NIC model is used for each machine type version, remove mention of e1000 as the default, and steer users towards always specifying their desired model. Reviewed-by: Thomas Huth Reviewed by: Aleksandar Markovic Signed-off-by: Daniel P. Berrangé --- qemu

[PULL 1/3] io/channel-websock: treat 'binary' and no sub-protocol as the same

2020-02-07 Thread Daniel P . Berrangé
b-protocol as the same so that we can support different version of noVNC client. Tested on noVNC before c912230 and after c912230. Buglink: https://bugs.launchpad.net/qemu/+bug/1849644 Signed-off-by: Yu-Chen Lin Signed-off-by: Daniel P. Berrangé --- io/channel-websock.c | 36 ++

[PATCH v2] block: always fill entire LUKS header space with zeros

2020-02-07 Thread Daniel P . Berrangé
fail for any pre-existing disk images created prior to this change, unless at least 1 byte of the payload is written to. Fully writing zeros to the entire LUKS header is a good idea regardless as it ensures that space has been allocated on the host filesystem (or whatever block storage backend

<    5   6   7   8   9   10   11   12   13   14   >