Returns negative error codes and accompanying error messages in cases where
the device has no tray or the tray is locked and isn't forced open. This
extra information should result in better flexibility in functions that
call do_open_tray.
Signed-off-by: Colin Lord
---
v2: fix fun
Returns negative error codes and accompanying error messages in cases where
the device has no tray or the tray is locked and isn't forced open. This
extra information should result in better flexibility in functions that
call do_open_tray.
Signed-off-by: Colin Lord
Suggested by: M
This commit causes qmp_blockdev_change_medium to report an error if an
attempt is made to open a device with a locked tray.
Signed-off-by: Colin Lord
This is based off my previous patch regarding the do_open_tray function
(currently at v3). Probably should have been submitted as a patch set
but
When opening a device with a locked tray, gives an error explaining the
device tray is locked and that the user should wait and try again. This
is less confusing than the previous error, which simply stated that the
tray was locked.
Signed-off-by: Colin Lord
---
Reworded commit message to
This is a repost of some previous patches written by Marc Marí which
were also reposted by Richard Jones a few months ago. The original
series and reposted series are here:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01995.html
https://lists.nongnu.org/archive/html/qemu-devel/2016-04/
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
include/qemu/module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin
been disabled as a module.
All the necessary module information is located in a new structure found in
include/qemu/module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Makefile | 3 --
block.c
On 06/16/2016 12:59 AM, Fam Zheng wrote:
> On Wed, 06/15 14:40, Colin Lord wrote:
>> From: Marc Mari
>>
>> To simplify the addition of new block modules, add a script that generates
>> include/qemu/module_block.h automatically from the modules' source code.
>>
On 06/15/2016 06:50 PM, Paolo Bonzini wrote:
>
>
> On 15/06/2016 20:40, Colin Lord wrote:
>>
>> The only block drivers that can be converted into modules are the drivers
>> that don't perform any init operation except for registering themselves. This
>>
On 06/16/2016 10:05 AM, Paolo Bonzini wrote:
>
>
> On 16/06/2016 16:00, Colin Lord wrote:
>>>>> The only block drivers that can be converted into modules are the drivers
>>>>> that don't perform any init operation except for registering themselves
On 06/17/2016 05:54 AM, Stefan Hajnoczi wrote:
> On Wed, Jun 15, 2016 at 02:40:53PM -0400, Colin Lord wrote:
>> 1) Denis Lunev suggested having block_module_load_one return the
>> loaded driver to reduce duplicated for loops in many of the functions
>> in block.c. I'
On 06/21/2016 05:32 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 20, 2016 at 11:32:38AM -0400, Colin Lord wrote:
>> On 06/17/2016 05:54 AM, Stefan Hajnoczi wrote:
>>> On Wed, Jun 15, 2016 at 02:40:53PM -0400, Colin Lord wrote:
>>>> 1) Denis Lunev suggested having bl
en't any messages about the driver not being found.
That hopefully explains some of the issues, and why I'm submitting this
with the duplicated loops still intact. If there are other ideas for
dealing with this my ears are open, but this is what I have for now.
Colin Lord (1):
blockdev:
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
include/qemu/module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Mari
Signed-off-by: Colin
o the main binary.
Signed-off-by: Colin Lord
---
block/iscsi.c | 36
vl.c | 36
2 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 7e78ade..6193499 100644
--- a/
odule information is located in a new structure found in
include/qemu/module_block.h
Signed-off-by: Marc Mari
Signed-off-by: Colin Lord
---
Makefile | 3 --
block.c | 86 +--
include/qemu/module.h | 3 ++
util/module.c
On 06/22/2016 05:35 PM, Colin Lord wrote:
> This is v2 of the series I sent out last week. These are the changes I
> made based on the feedback I got:
> - Fixed typo and Marc's email address in the python script
> - Moved registration of iscsi_opts into vl.c
>
> What I did
On 06/22/2016 09:22 PM, Fam Zheng wrote:
> On Wed, 06/22 17:35, Colin Lord wrote:
>> This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
>> struct out of block/iscsi.c in order to allow it to be dynamically
>> loaded. Drivers that perform init operations o
a new structure found in
module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
block.c | 37 +++--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
util/module.c | 38 +++---
4 files ch
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (1):
blockdev: prepare iSCSI block driver for dynamic loading
Marc Mari (2):
blockdev: Add dy
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Mak
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
On 07/23/2016 02:21 PM, Max Reitz wrote:
> On 20.07.2016 16:30, Colin Lord wrote:
>> Here's v5 of the modularization series. Since it seems the concensus is
>> that modularizing the format drivers is unnecessary, this series no
>> longer modularizes those and is thu
Updates the messages displayed in the help option to reflect that GTK is
the default display, not SDL.
---
qemu-options.hx | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 8e0d9a5..5bec1d3 100644
--- a/qemu-options.hx
+++
Removes some superfluous lines from the Makefile which should have been
removed as part of the patch series to add dynamic loading for block
driver modules.
Signed-off-by: Colin Lord
---
Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Makefile b/Makefile
index 4b9384e..c7aa8cd
protocol block driver that links to external libraries that
has not been modularized (once my last patch set is applied).
Colin Lord (2):
blockdev: Remove unnecessary lines from Makefile
blockdev: Modularize nfs block driver
Makefile| 3 ---
block/Makefile.objs | 1 +
configure
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 595f366..fa4d8b8 100644
On 07/27/2016 02:26 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
> ---
> Makefile.objs | 1 +
> configure | 4 +--
> include/qemu/module.h | 2 ++
> include/ui/console.h | 5 ++--
> ui/Makefile.objs | 2 ++
> ui/sdl-init.c | 75
>
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Mak
nd
in module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Makefile | 3 ---
block.c | 62 +--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
util/module.c
Modularizes the nfs block driver so that it gets dynamically loaded.
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 595f366..fa4d8b8 100644
--- a/block/Makefile.objs
+++ b/b
On 08/02/2016 10:12 AM, Colin Lord wrote:
> I'm sending one more version of this series. v5 didn't seem to need any
> huge makeovers, but I found a small bug in it so I'm hoping it hasn't
> been committed yet. In v5, if a user explicitly specified the driver to
>
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
ey follow the naming
pattern of format-probe.c
- Renamed crypto probe file to be crypto-probe.c, luks is no longer in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_pro
le loading for
block drivers'.
Colin Lord (1):
gtk: Modularize GTK display
Fam Zheng (1):
rules.mak: Don't extract libs from .mo-libs in link command
Makefile.objs| 1 +
configure| 5 ++--
include/ui/console.h | 6 +
rules.mak| 2
None.
This should give improvements in terms of performance, since much less
libraries will be loaded at startup if GTK is not being used, and in
terms of packaging, since GTK should be able to be packaged separately
in binary package managers now.
Signed-off-by: Colin Lord
---
Makefile.objs
link command incorrectly,
spoiling the purpose of modularization.
Currently we don't have any .mo-libs usage, but it will be used soon
when we modularize more multi-source objects, like sdl and gtk.
Reported-by: Colin Lord
Signed-off-by: Fam Zheng
---
rules.mak | 2 +-
1 file chang
Updates the help messages to reflect that GTK is the default display (if
enabled), not SDL.
Signed-off-by: Colin Lord
---
v2: Update to try to implement Paolo's suggested wordings. It looks to
me like the subsections get wrapped at 72 lines, which mean there was a
bit of a ripple effec
On 07/06/2016 09:17 AM, Max Reitz wrote:
> On 05.07.2016 17:24, Colin Lord wrote:
>> From: Marc Mari
>>
>> To simplify the addition of new block modules, add a script that generates
>> module_block.h automatically from the modules' source code.
>>
>> Th
On 07/06/2016 11:59 AM, Max Reitz wrote:
> On 05.07.2016 17:24, Colin Lord wrote:
>> Modifies the bochs probe to return the format name as well as the
>> score as the final step of separating the probe function from the
>> driver. This keeps the probe completely inde
On 07/06/2016 04:24 AM, Kevin Wolf wrote:
> Am 05.07.2016 um 22:50 hat John Snow geschrieben:
>>
>>
>> On 07/05/2016 11:49 AM, Daniel P. Berrange wrote:
>>> On Tue, Jul 05, 2016 at 11:24:04AM -0400, Colin Lord wrote:
>>>> This puts the bochs probe func
This adds a python equivalent of the _use_sample_img and _rm_sample_img
testing functions.
Signed-off-by: Colin Lord
---
tests/qemu-iotests/iotests.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 1687c33
.com/dramborleg/qemu/tree/probe-iotests/tests/qemu-iotests/sample_images
Colin Lord (3):
iotests: Add dmg format option
iotests: Add python functions for using sample images
iotests: Test format probes
tests/qemu-iotests/158| 53 +++
tests/qem
Adds option to test the dmg format.
Signed-off-by: Colin Lord
---
tests/qemu-iotests/common | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index d60ea2c..dc937c7 100644
--- a/tests/qemu-iotests/common
+++ b/tests/qemu-iotests
the given format, and one check is done against a raw image. This is to
ensure that a probe correctly returns a high score when the format is
matched, and does not return a high score when the format should not be
matched, as would be the case with raw images.
Signed-off-by: Colin Lord
---
tests
On 07/12/2016 05:17 PM, John Snow wrote:
>
>
> On 07/11/2016 03:50 PM, Colin Lord wrote:
>> Adds a new iotest for testing that the format probing functions work as
>> expected. This is done by booting up a vm with a disk image without
>> specifying the image format.
Isolates cloop probing function as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/cloop-probe.c | 17 +
block/cloop.c | 16 +---
include/block/probe.h | 1 +
4 files changed
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Max
Completes the separation of the dmg probe from the dmg driver. The dmg
probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Isolates qcow2 probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/qcow2-probe.c | 16
block/qcow2.c | 13 +
include/block/probe.h | 1 +
4 files changed, 19 insertions
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
odule information is located in a new structure found in
module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c | 110 ++
include/qemu/module.h | 3 ++
util/module.c
Completes the separation of the raw probe from the raw driver. The
raw probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Isolates the luks probe function as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/crypto-probe.c | 23 +++
block/crypto.c| 21 +
include/block/probe.h | 2 ++
4
Isolate qed probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/qed-probe.c | 18 ++
block/qed.c | 15 +--
include/block/probe.h | 1 +
4 files changed, 21 insertions
onger in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (30):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Move bochs
Isolate parallels probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 1 +
block/parallels-probe.c | 21 +
block/parallels.c | 43 ++-
block/parallels.h
Completes the separation of the vhdx probe from the vhdx driver. The
vhdx probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Isolates qcow probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/qcow-probe.c| 16
block/qcow.c | 31 ++-
block/qcow.h | 21
This puts the bochs probe function into its own separate file as part of
the process of modularizing block drivers. Having the probe functions
separate from the rest of the driver allows us to probe without having
to potentially unnecessarily load the driver.
Signed-off-by: Colin Lord
Reviewed
Isolate raw probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 1 +
block/raw-probe.c | 10 ++
block/raw_bsd.c | 9 +
include/block/probe.h | 1 +
4 files changed, 13 insertions(+), 8 deletions
Isolate dmg probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/dmg-probe.c | 17 +
block/dmg.c | 16 +---
include/block/probe.h | 1 +
4 files changed, 20 insertions
Completes the separation of the luks probe from the crypto driver. The
luks probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
Isolates vmdk probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vmdk-probe.c| 60 +++
block/vmdk.c | 60
This commit finalizes the separation of the block driver and probe
function by removing the .bdrv_probe field from all BlockDrivers.
Probing is now accomplished solely by iterating over the array of probe
function pointers in the format_probes array.
Signed-off-by: Colin Lord
Reviewed-by: Max
Completes the separation of the parallels probe from the parallels
driver. The parallels probe now returns the format in addition to the
score, allowing correlation of the score and driver without the probe
function being part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max
allows the score to be correlated to the
driver without the probe function needing to be part of the driver.
Signed-off-by: Colin Lord
---
block.c | 20
block/bochs-probe.c | 25 -
block/bochs.c | 1 -
include/block/probe.h | 3
Isolates vdi probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vdi-probe.c | 26 +++
block/vdi.c | 69 ++-
block/vdi.h
Completes the separation of the qcow2 probe from the qcow2 driver. The
qcow2 probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
Isolates vpc probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vpc-probe.c | 9 +
block/vpc.c | 8 +---
include/block/probe.h | 1 +
4 files changed, 12 insertions(+), 8 deletions
Isolates vhdx probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vhdx-probe.c| 21 +
block/vhdx.c | 20 +---
include/block/probe.h | 1 +
4 files changed, 24
Completes the separation of the cloop probe from the cloop driver. The
cloop probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
Completes the separation of the vpc probe from the vpc driver. The
vpc probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the qed probe from the qed driver. The
qed probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the vmdk probe from the vmdk driver. The
vmdk probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the qcow probe from the qcow driver. The
qcow probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Completes the separation of the vdi probe from the vdi driver. The
vdi probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
This commit finalizes the separation of the BlockDriver from its
device probing function. Now the accesses to these functions in block.c
occur through the protocol_probes array, and each function returns a
score and protocol name with which to find the corresponding driver.
Signed-off-by: Colin
This puts the bdrv_probe_device functions into their own files to
facilitate the modularization of the block drivers.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 1 +
block/host_cdrom-probe.c | 40 +
block/host_device
On 07/18/2016 12:28 PM, Max Reitz wrote:
> On 14.07.2016 21:03, Colin Lord wrote:
>> Modifies the bochs probe to return the format name as well as the
>> score as the final step of separating the probe function from the
>> driver. This keeps the probe completely inde
On 07/19/2016 06:54 AM, Paolo Bonzini wrote:
>
>
> On 14/07/2016 21:02, Colin Lord wrote:
>> Here's v4 of the modularization series. Things that have changed since
>> v3 include:
>>
>> - Fix indentation of the generated header file module_block.h
>&g
On 08/08/2016 11:18 AM, Stefan Hajnoczi wrote:
> On Tue, Aug 02, 2016 at 10:12:14AM -0400, Colin Lord wrote:
>> diff --git a/vl.c b/vl.c
>> index e7c2c62..1a5f807 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -506,6 +506,41 @@ static QemuOptsList qemu_fw_cfg_opts = {
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 40
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (2):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Modularize nfs block driver
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: S
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
a new structure found
in module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
Makefile | 3 ---
block.c | 62 +--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
On 08/10/2016 02:37 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> From: Marc Mari
>>
>> Extend the current module interface to allow for block drivers to be
>> loaded dynamically on request. The only block drivers that can be
>> converted into m
On 08/10/2016 03:04 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> Modularizes the nfs block driver so that it gets dynamically loaded.
>>
>> Signed-off-by: Colin Lord
>> Reviewed-by: Stefan Hajnoczi
>> ---
>> block/Makefile.objs | 1 +
On 08/10/2016 03:04 PM, Colin Lord wrote:
> On 08/10/2016 02:37 PM, Max Reitz wrote:
>> On 08.08.2016 20:07, Colin Lord wrote:
>>> From: Marc Mari
>>>
>>> Extend the current module interface to allow for block drivers to be
>>> loaded dynamically o
On 08/10/2016 03:24 PM, Colin Lord wrote:
> On 08/10/2016 03:04 PM, Colin Lord wrote:
>> On 08/10/2016 02:37 PM, Max Reitz wrote:
>>> On 08.08.2016 20:07, Colin Lord wrote:
>>>> From: Marc Mari
>>>>
>>>> Extend the current module interface to
On 08/10/2016 11:23 PM, Fam Zheng wrote:
> On Wed, 08/10 21:06, Max Reitz wrote:
>> On 10.08.2016 21:04, Colin Lord wrote:
>>> On 08/10/2016 02:37 PM, Max Reitz wrote:
>>>> On 08.08.2016 20:07, Colin Lord wrote:
>>>>> From: Marc Mari
>>>>
ibbz2, while the
main QEMU package needn't to. With this patch, we (temporarily) change
the case so that the main QEMU depends on libbz2 again.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
Makefile | 3 ---
block.c
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: S
On 08/11/2016 09:29 PM, Fam Zheng wrote:
> On Thu, 08/11 12:03, Colin Lord wrote:
>> On 08/10/2016 11:23 PM, Fam Zheng wrote:
>>> On Wed, 08/10 21:06, Max Reitz wrote:
>>>> On 10.08.2016 21:04, Colin Lord wrote:
>>>>> On 08/10/2016 02:37 PM, Max Reitz
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
---
block/iscsi.c | 36
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Stefan Hajnoczi
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
no longer in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (2):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Modularize
Updates the help messages to remove misleading information about SDL
being the normal display used.
Signed-off-by: Colin Lord
---
v3: Try to make help more general to cover all cases nicely.
qemu-options.hx | 38 +-
1 file changed, 21 insertions(+), 17
Isolates the luks probe function as part of the modularization process.
Signed-off-by: Colin Lord
---
block/Makefile.objs | 2 +-
block/crypto.c| 21 +
block/probe/luks.c| 23 +++
include/block/probe.h | 2 ++
4 files changed, 27
1 - 100 of 132 matches
Mail list logo
