routine to write explicitly the
kvm_get_htab_header structs in big endian. The ptes are left untouched.
Signed-off-by: Cédric Le Goater
Cc: pau...@samba.org
Cc: a...@ozlabs.ru
Cc: gk...@linux.vnet.ibm.com
---
This patch needs to be completed by a relatively simple modification of
kvm_htab_write
These two small patches add a VHOST_VRING_F_BYTESWAP flag to the
vring which will be used by the kernel to byteswap the different
vring indexes.
The kernel patchset can be found on the kvm@ and kvm-ppc@ mailing
lists.
Cédric Le Goater (2):
vhost: add VHOST_VRING_F_BYTESWAP flag
vhost_net
When the guest and the host have a different endian order, the data
being accessed in the vring queues needs to be byteswapped.
This patch adds a VHOST_VRING_F_BYTESWAP flag to inform the vhost
kernel backend to byteswap vring data.
Signed-off-by: Cédric Le Goater
---
hw/virtio/vhost.c
revert 371df9f5e0f1 "vhost-net: disable when cross-endian"
Signed-off-by: Cédric Le Goater
---
hw/net/vhost_net.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 4e3a06162291..721fb2da52f8 100644
--- a/hw/net/v
and other commands, in TCG mode :
invalid bits: 0200 for opcode: 1f - 16 - 08 (7e09322c) 3fff799feca0
This patch adds the extended opcodes as no-ops just like the 'dcbt'
instruction. Other 'dcb*' instructions might be impacted but they
have not showed up yet.
S
and other commands, in TCG mode :
invalid bits: 0200 for opcode: 1f - 16 - 08 (7e09322c) 3fff799feca0
This patch adds the extended opcodes for dcbt/dcbtst as no-ops just
like the 'dcbt' instruction.
Signed-off-by: Cédric Le Goater
---
Changes in v2:
- added extended opcodes
routine to write explicitly the
kvm_get_htab_header structs in big endian. The ptes are left untouched.
Signed-off-by: Cédric Le Goater
Cc: Paul Mackerras
Cc: Alexey Kardashevskiy
Cc: Gregory Kurz
---
This patch needs to be completed by a relatively simple modification of
kvm_htab_write() in
ARRAY_SIZE() is simple to use and removes the need to pre-define
the size of the command arrays.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
This is a simulator. Just return an unknown cause (0).
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
---
hw/ipmi/ipmi_bmc_sim.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 7c0f2a1d9799
as an extension of this patchset. (Work in progress)
Based on 3db34bf64ab4 and also available here :
https://github.com/legoater/qemu/commits/ipmi
Thanks,
Cédric Le Goater (9):
ppc: add IPMI support
ipmi: replace goto by a return statement
ipmi: replace *_MAXCMD defines
ipmi
Open PowerNV systems use a BT device to communicate with the BMC.
Provide support for it.
Signed-off-by: Cédric Le Goater
---
default-configs/ppc64-softmmu.mak | 4
1 file changed, 4 insertions(+)
diff --git a/default-configs/ppc64-softmmu.mak
b/default-configs/ppc64-softmmu.mak
index
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
---
hw/ipmi/ipmi_bmc_sim.c | 45 -
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 803c7e5130c0..7c0f2a1d9799 100644
--- a/hw
The IPMI BMC simulator populates the SDR table with a set of initial
SDRs. The length of each SDR is taken from the record itself (byte 4)
which does not include the size of the header. But, the full length
(header + data) is required by the sdr_add_entry() routine.
Signed-off-by: Cédric Le
.
The code exits in ipmi_sim_handle_command() are a little different
from the rest and a "possible" error in the macro IPMI_ADD_RSP_DATA is
handled before making use of it. This might be a bit excessive as a
minimum response len is currently 300 bytes and the patch checks that
at least 3 are available.
S
Signed-off-by: Cédric Le Goater
---
Changes since v1:
- added ACPI to command names.
hw/ipmi/ipmi_bmc_sim.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index e882af3f1b40..53c75cb21c1a
assumption is
made on the type of SDR. This leave rooms to potential usage of other
types in the future.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 65 +++---
include/hw/ipmi/ipmi.h | 44 ++
2 files changed, 84
"Boot Count" sensor.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
---
hw/ipmi/ipmi_bmc_sim.c | 135 +
1 file changed, 135 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 53c75cb21c1a..0aa
On 01/22/2016 11:49 AM, Greg Kurz wrote:
> On Thu, 21 Jan 2016 18:18:49 +0100
> Cédric Le Goater wrote:
>
>> Currently, sdr attributes are identified using byte offsets and this
>> can be a bit confusing.
>>
>> This patch adds a struct ipmi_sdr_compact co
On 01/22/2016 12:07 PM, Greg Kurz wrote:
> On Thu, 21 Jan 2016 18:18:51 +0100
> Cédric Le Goater wrote:
>
>> Signed-off-by: Cédric Le Goater
>> Acked-by: Corey Minyard
>> ---
>
> Reviewed-by: Greg Kurz
>
> Just two nits be
On 01/22/2016 11:56 AM, Greg Kurz wrote:
> On Thu, 21 Jan 2016 18:18:50 +0100
> Cédric Le Goater wrote:
>> The IPMI BMC simulator populates the SDR table with a set of initial
>> SDRs. The length of each SDR is taken from the record itself (byte 4)
>> which does not includ
On 01/22/2016 12:24 PM, Greg Kurz wrote:
> On Thu, 21 Jan 2016 18:18:53 +0100
> Cédric Le Goater wrote:
>
>> Signed-off-by: Cédric Le Goater
>> ---
>>
>> Changes since v1:
>> - added ACPI to command na
4 and also available here :
https://github.com/legoater/qemu/commits/ipmi
Thanks,
Cédric Le Goater (10):
ppc: add IPMI support
ipmi: replace goto by a return statement
ipmi: replace *_MAXCMD defines
ipmi: cleanup error_report messages
ipmi: fix SDR length value
ipmi: introduc
assumption is
made on the type of SDR. This leave rooms to potential usage of other
types in the future.
Signed-off-by: Cédric Le Goater
---
Changes since v2:
- changed sdr_add_entry() prototype to use struct a ipmi_sdr_header
hw/ipmi/ipmi_bmc_sim.c | 72
.
The code exits in ipmi_sim_handle_command() are a little different
from the rest and a "possible" error in the macro IPMI_ADD_RSP_DATA is
handled before making use of it. This might be a bit excessive as a
minimum response len is currently 300 bytes and the patch checks that
at least 3 are availa
Open PowerNV systems use a BT device to communicate with the BMC.
Provide support for it.
Signed-off-by: Cédric Le Goater
Cc: David Gibson
Cc: qemu-...@nongnu.org
---
default-configs/ppc64-softmmu.mak | 4
1 file changed, 4 insertions(+)
diff --git a/default-configs/ppc64-softmmu.mak
b
ARRAY_SIZE() is simple to use and removes the need to pre-define
the size of the command arrays.
Signed-off-by: Cédric Le Goater
Reviewed-by: Greg Kurz
---
hw/ipmi/ipmi_bmc_sim.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b
"Boot Count" sensor.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Greg Kurz
---
hw/ipmi/ipmi_bmc_sim.c | 135 +
1 file changed, 135 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
in
Signed-off-by: Cédric Le Goater
Cc: Greg Kurz
---
hw/ipmi/ipmi_bmc_sim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index fc596a548df7..2c540c0782c9 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
-by: Cédric Le Goater
Acked-by: Corey Minyard
---
Changes since v1:
- added ACPI to command names.
hw/ipmi/ipmi_bmc_sim.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 1b552732b
The IPMI BMC simulator populates the SDR table with a set of initial
SDRs. The length of each SDR is taken from the record itself (byte 4)
which does not include the size of the header. But, the full length
(header + data) is required by the sdr_add_entry() routine.
Signed-off-by: Cédric Le
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Greg Kurz
---
hw/ipmi/ipmi_bmc_sim.c | 45 -
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 3960c2f90094
This is a simulator. Just return an unknown cause (0).
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Greg Kurz
---
hw/ipmi/ipmi_bmc_sim.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
On 01/26/2016 06:46 AM, David Gibson wrote:
> On Mon, Jan 25, 2016 at 03:07:26PM +0100, Cédric Le Goater wrote:
>> Open PowerNV systems use a BT device to communicate with the BMC.
>> Provide support for it.
>
> Given that there's quite a bit of work to be done to ma
On 11/12/2015 08:02 PM, miny...@acm.org wrote:
> This is a long delayed patch set, but I think I have things reworked
> to make Igor happy with the way ACPI and SMBIOS work. This is more
> consistent with the way most other things work, anyway. It did
> require adding stubs for systems without IP
A few comments below,
On 11/12/2015 08:02 PM, miny...@acm.org wrote:
> From: Corey Minyard
>
> This provides a minimal local BMC, basically enough to comply with the
> spec and provide a complete watchdog timer (including a sensor, SDR,
> and event).
>
> Signed-off-by: Corey Minyard
> ---
> d
Hello Marcin,
Some comments below
On 02/04/2016 01:23 PM, marcin.krzemin...@nokia.com wrote:
> From: Marcin Krzeminski
>
> This patch adds only 4byte address mode (does not cover dummy cycles).
> This mode is needed to access more than 16 MiB of flash.
>
> Signed-off-by: Marcin Krzeminski
>
On 02/04/2016 01:23 PM, marcin.krzemin...@nokia.com wrote:
> From: Marcin Krzeminski
>
> Extend address mode allows to switch flash 16 MiB banks,
> allowing user to access all flash sectors.
> This access mode is used by u-boot.
>
> Signed-off-by: Marcin Krzeminski
> Reviewed-by: Peter Crosthwa
On 02/04/2016 01:23 PM, marcin.krzemin...@nokia.com wrote:
> From: Marcin Krzeminski
>
> This patch handles dummy cycles.
>
> Signed-off-by: Marcin Krzeminski
> ---
> hw/block/m25p80.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index
This will be useful to define and use properties when the object is
instanciated.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index e1ad19b8db6e
Currently, the code initializing the sdr table relies on an ending
record with a recid of 0x. This patch changes the loop to use the
sdr size as a breaking condition.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions
This patch adds a couple of variables to manipulate the raw sdr
entries. The const attribute is also removed on init_sdrs. This will
ease the introduction of a sdr loader using a file.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 15 ++-
1 file changed, 10 insertions
created as a default. Just enough to
start some simulation.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 140 +
1 file changed, 140 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 69318eb6b556
platforms in some occasions.
Based on e4a096b1cd43 and also available here :
https://github.com/legoater/qemu/commits/ipmi
Thanks,
C.
Cédric Le Goater (8):
ipmi: add a realize function to the device class
ipmi: use a function to initialize the SDR table
ipmi: remove the need of an ending
of a device
tree.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 16
include/hw/ipmi/ipmi.h | 2 ++
2 files changed, 18 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index b0754893fc08..c952219429f4 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
file to use is
defined through a new 'sdr' property of the simulator device.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index af
This patch does not change anything. It only moves the code section
initializing the sdrs in its own routine and prepares ground for the
subsequent patches.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 49 -
1 file changed, 28
It will be used to fill the message buffer with custom events expected
by some systems. Typically, an Open PowerNV platform guest is notified
with an OEM SEL message before a shutdown or a reboot.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 24
include
Hello Corey,
On 02/09/2016 07:25 PM, Corey Minyard wrote:
> On 02/09/2016 06:13 AM, Cédric Le Goater wrote:
>> The first patches are cleanups and prepare ground for an extension of
>> the BMC simulator providing a SDR loader using a file. A simple FRU
>> support comes next.
&
On 02/10/2016 05:06 PM, Corey Minyard wrote:
> On 02/10/2016 08:05 AM, Cédric Le Goater wrote:
>> Hello Corey,
>>
>> On 02/09/2016 07:25 PM, Corey Minyard wrote:
>>> On 02/09/2016 06:13 AM, Cédric Le Goater wrote:
>>>> The first patches are cleanups and p
On 02/14/2016 09:31 AM, Marcel Apfelbaum wrote:
> On 02/09/2016 02:13 PM, Cédric Le Goater wrote:
>> This patch does not change anything.
>
> Hi,
>
> Well, it changes *something*, otherwise ... :)
>
> Maybe "This is only a re-factoring."
Yes. This is much b
On 02/14/2016 09:55 AM, Marcel Apfelbaum wrote:
> On 02/09/2016 02:13 PM, Cédric Le Goater wrote:
>> This patch adds a couple of variables to manipulate the raw sdr
>> entries. The const attribute is also removed on init_sdrs. This will
>> ease the introduction of a sd
On 02/14/2016 10:08 AM, Marcel Apfelbaum wrote:
> On 02/09/2016 02:13 PM, Cédric Le Goater wrote:
>> The IPMI BMC simulator populates the sdr/sensor tables with a minimal
>> set of entries (Watchdog). But some qemu platforms might want to use
>> extra entries for their cus
On 02/14/2016 10:25 AM, Marcel Apfelbaum wrote:
> On 02/09/2016 02:13 PM, Cédric Le Goater wrote:
>> This patch provides a simple FRU support for the BMC simulator. FRUs
>> are loaded from a file which name is specified in the object
>> properties, each entry having a fixed si
On 02/14/2016 10:30 AM, Marcel Apfelbaum wrote:
> On 02/09/2016 02:13 PM, Cédric Le Goater wrote:
>> This patch exposes a new IPMI routine to query a sdr entry from the
>> sdr table maintained by the IPMI BMC simulator. The API is very
>> similar to the internal sdr_find_entry
if ((cmd[2] > MAX_SENSORS) ||
> hw/ipmi/ipmi_bmc_sim.c:if ((cmd[2] > MAX_SENSORS) ||
> hw/ipmi/ipmi_bmc_sim.c:if ((cmd[2] > MAX_SENSORS) ||
> hw/ipmi/ipmi_bmc_sim.c:if ((cmd[2] > MAX_SENSORS) ||
I missed that. Here is a patch.
Thanks,
C.
From: Cédric Le Goat
On 02/16/2016 04:38 AM, Corey Minyard wrote:
> On 02/15/2016 12:40 PM, Marcel Apfelbaum wrote:
>> On 02/15/2016 07:17 PM, Cédric Le Goater wrote:
>>> On 02/14/2016 10:25 AM, Marcel Apfelbaum wrote:
>>>> On 02/09/2016 02:13 PM, Cédric Le Goater wrote:
>>>>
On 11/24/2015 08:46 PM, Corey Minyard wrote:
> On 11/24/2015 07:31 AM, Cédric Le Goater wrote:
>> A few comments below,
>
> Thanks a bunch for the review. As you probably have guessed, this was
> not really intended as a fully functional BMC, though it has most of the
>
On 11/28/2015 08:59 AM, Benjamin Herrenschmidt wrote:
> On Fri, 2015-11-27 at 11:21 +0100, Alexander Graf wrote:
>>
>> How does real hardware store petitboot? If it's flash, you could pass it
>> in using -pflash and thus model things even more closely and allow users
>> to just take the ROM image a
On 11/30/2015 09:09 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2015-11-30 at 19:15 +0100, Cédric Le Goater wrote:
>> The pnor file is compiled from github. The patch is below (without the dirty
>> cut and paste I did in loader.c). The offset for the PAYLOAD and BOOTKERNEL
>>
On 12/07/2015 02:25 AM, Stewart Smith wrote:
> Cédric Le Goater writes:
>> On 11/28/2015 08:59 AM, Benjamin Herrenschmidt wrote:
>>> On Fri, 2015-11-27 at 11:21 +0100, Alexander Graf wrote:
>>>>
>>>> How does real hardware store petitboot? If it's
Hello,
On 01/08/2016 08:41 PM, Corey Minyard wrote:
> On 01/05/2016 11:29 AM, Cédric Le Goater wrote:
>> This patch provides a simplistic FRU support for the IPMI BMC
>> simulator. The FRU area contains 32 entries * 256 bytes which should
>> be enough to start some simulat
On 01/08/2016 08:46 PM, Corey Minyard wrote:
> On 01/05/2016 11:29 AM, Cédric Le Goater wrote:
>> Signed-off-by: Cédric Le Goater
>> ---
>> hw/ipmi/ipmi_bmc_sim.c | 55
>> ++
>> 1 file changed, 55 inserti
On 01/08/2016 09:23 PM, Corey Minyard wrote:
> Acked-by: Corey Minyard
>
> I agree with Greg's comments, too.
Me also. I will rework the code to use ARRAY_SIZE or something similar.
Thanks,
C.
> -corey
>
> On 01/05/2016 11:29 AM, Cédric Le Goater wrote:
>> Si
eeds are simple, but if you
> need something more extensive we probably should think about something
> else.
>
> A few comments inline, too.
>
> On 01/05/2016 11:30 AM, Cédric Le Goater wrote:
>> This routine will let qemu platforms populate the sdr/sensor tables of
&g
On 01/08/2016 09:20 PM, Corey Minyard wrote:
> On 01/06/2016 02:14 AM, Cédric Le Goater wrote:
>> On 01/05/2016 08:59 PM, Eric Blake wrote:
>>> On 01/05/2016 10:29 AM, Cédric Le Goater wrote:
>>>
>>> [meta-comment] Your messages were not marked in-reply-to
On 01/17/2016 01:08 PM, Marcel Apfelbaum wrote:
> On 01/17/2016 02:04 PM, Marcel Apfelbaum wrote:
>> On 01/05/2016 07:29 PM, Cédric Le Goater wrote:
>>> Signed-off-by: Cédric Le Goater
>>> ---
>>> hw/ipmi/ipmi_bmc_sim.c | 55
>>> ++
On 01/21/2016 05:37 PM, Corey Minyard wrote:
> On 01/17/2016 08:16 AM, Michael S. Tsirkin wrote:
>> On Sun, Jan 17, 2016 at 02:04:32PM +0200, Marcel Apfelbaum wrote:
>>> On 01/05/2016 07:29 PM, Cédric Le Goater wrote:
>>>> Signed-off-by: Cédric Le Goater
>>
Hello Marcin,
On 12/16/2015 01:57 PM, marcin.krzemin...@nokia.com wrote:
> From: Marcin Krzeminski
>
> Signed-off-by: Marcin Krzeminski
> ---
> hw/block/m25p80.c | 31 ---
> 1 file changed, 28 insertions(+), 3 deletions(-)
>
> diff --git a/hw/block/m25p80.c b/hw/b
The IPMI BMC simulator populates the SDR table with a set of initial
SDRs. The length of each SDR is taken from the record itself (byte 4)
which does not include the size of the header. But, the full length
(header + data) is required by the sdr_add_entry() routine.
Signed-off-by: Cédric Le
...
};
struct ipmi_sdr_compact *sdr =
(struct ipmi_sdr_compact *) &my_init_sdrs[0];
ipmi_bmc_init_sensor(IPMI_BMC(obj), my_init_sdrs[0],
sdr->rec_length + 5, &sdr->sensor_owner_number);
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 61 ++
This is a simulator. Just return an unknown cause (0).
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 061db8437479..5db94491b130 100644
This patch provides a simplistic FRU support for the IPMI BMC
simulator. The FRU area contains 32 entries * 256 bytes which should
be enough to start some simulation.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 119 +
1 file
"Boot Count" sensor.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 141 -
1 file changed, 140 insertions(+), 1 deletion(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index c3a06d0ac7e4..4f7c74da4b6b 10064
It will be used to fill the message buffer with custom events expected
by some systems. Typically, an Open PowerNV platform guest is notified
with an OEM SEL message before a shutdown or a reboot.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 24
include
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 55 ++
1 file changed, 55 insertions(+)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 60586a67104e..c3a06d0ac7e4 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi
/legoater/qemu/commits/ipmi
Thanks,
Cédric Le Goater (8):
ipmi: fix SDR length value
ipmi: add get and set SENSOR_TYPE commands
ipmi: add GET_SYS_RESTART_CAUSE chassis command
ipmi: add FRU support
ipmi: add ACPI power and GUID commands
ipmi: add SET_SENSOR_READING command (tentative try
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 51 --
1 file changed, 49 insertions(+), 2 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 559e1398d669..061db8437479 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
On 01/05/2016 08:59 PM, Eric Blake wrote:
> On 01/05/2016 10:29 AM, Cédric Le Goater wrote:
>
> [meta-comment] Your messages were not marked in-reply-to: the 0/8 cover
> letter, but came through as separate threads. This makes it harder to
> follow, especially in mail clients that
On 01/06/2016 10:55 AM, Greg Kurz wrote:
> On Tue, 5 Jan 2016 18:29:56 +0100
> Cédric Le Goater wrote:
>
>> Signed-off-by: Cédric Le Goater
>> ---
>
> Acked-by: Greg Kurz
>
> Just some minor comments on the form below.
>
handlers
- Fixed property naming
- Kept the API extensions to expose SDR and generate events for
later
Based on 9c279bec754a and also available here :
https://github.com/legoater/qemu/commits/ipmi
Thanks,
C.
Cédric Le Goater (10):
ipmi: remove IPMI_CHECK_CMD_LEN() macro
ipmi
This patch moves the code section initializing the sdrs in its own
routine to prepare ground for changes in the subsequent patches.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
---
hw/ipmi/ipmi_bmc_sim.c | 49 -
1 file changed, 28
r
routines to store byte(s) in a response buffer. rsp_buffer_push()
replaces the macro IPMI_ADD_RSP_DATA() and rsp_buffer_pushmore() is
new helper to push multiple bytes. The latest is used in the command
handlers get_msg() and get_sdr() which are manipulating the buffer
directly.
Signed-off-by:
This will be useful to define and use properties when the object is
instantiated.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Marcel Apfelbaum
---
Changes since v1:
- removed empty properties.
hw/ipmi/ipmi_bmc_sim.c | 7 ---
1 file changed, 4 insertions(+), 3
The third byte in the response buffer of an IPMI command holds the
error code. In many IPMI command handlers, this byte is updated
directly. This patch adds a helper routine to clarify why this byte is
being used.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 115
file to use is
defined through a new 'sdr' property of the simulator device.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Marcel Apfelbaum
---
Changes since v1:
- log an error if file does not exist.
- change property name to 'sdrfile'
- add
created as a default. Just enough to
start some simulation.
These commands complies with the IPMI spec : "34. FRU Inventory Device
Commands".
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
---
Changes since v1:
- change property name to 'fruareasize' and
Currently, the code initializing the sdr table relies on an ending
record with a recid of 0x. This patch changes the loop to use the
sdr size as a breaking condition.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Marcel Apfelbaum
---
hw/ipmi/ipmi_bmc_sim.c | 13
patch adds a 'cmd_len_min' attribute to the struct IPMICmdHandler
defining the minimal number of arguments expected by the command and
moves this check in the global command handler ipmi_sim_handle_command().
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_s
Some IPMI command handlers in the BMC simulator use a macro
IPMI_CHECK_RESERVATION() to check a SDR reservation but the macro
implicitly uses local variables. This patch simply removes it.
Signed-off-by: Cédric Le Goater
---
hw/ipmi/ipmi_bmc_sim.c | 33 +++--
1 file
This patch adds a couple of variables to manipulate the raw sdr
entries. The const attribute is also removed on init_sdrs. This will
ease the introduction of a sdr loader using a file.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Marcel Apfelbaum
---
hw/ipmi
On 03/02/2016 11:25 AM, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2016 at 11:14:50AM +0100, Cédric Le Goater wrote:
>> The IPMI command handlers in the BMC simulator use a macro
>> IPMI_ADD_RSP_DATA() to push bytes in a response buffer. The macro
>> hides the fact th
On 03/02/2016 07:02 PM, Michael S. Tsirkin wrote:
> On Wed, Mar 02, 2016 at 06:53:08PM +0100, Cédric Le Goater wrote:
>>> typedef struct RspBuffer RspBuffer;
>>
>> OK. So that's the rule for structs in qemu. It is not that clear
>> when you look at the code arou
On 03/05/2016 12:41 PM, Corey Minyard wrote:
> On 03/02/2016 04:14 AM, Cédric Le Goater wrote:
>> Most IPMI command handlers in the BMC simulator start with a call to
>> the macro IPMI_CHECK_CMD_LEN() which verifies that a minimal number of
>> arguments expected by the command
On 03/07/2016 11:40 AM, Cédric Le Goater wrote:
> On 03/05/2016 12:41 PM, Corey Minyard wrote:
>> On 03/02/2016 04:14 AM, Cédric Le Goater wrote:
>>> Most IPMI command handlers in the BMC simulator start with a call to
>>> the macro IPMI_CHECK_CMD_LEN() which verifi
On 03/09/2016 05:07 AM, Corey Minyard wrote:
> On 03/09/2016 12:06 AM, Cédric Le Goater wrote:
>> On 03/07/2016 11:40 AM, Cédric Le Goater wrote:
>>> On 03/05/2016 12:41 PM, Corey Minyard wrote:
>>>> On 03/02/2016 04:14 AM, Cédric Le Goater wrote:
>>>&
On 03/02/2016 09:30 PM, Thomas Huth wrote:
> On 11.11.2015 01:28, Benjamin Herrenschmidt wrote:
>> WORT and PID this time
>>
>> Signed-off-by: Benjamin Herrenschmidt
>> ---
>> target-ppc/cpu.h| 2 ++
>> target-ppc/translate_init.c | 16
>> 2 files changed, 14 inserti
Currently, the code initializing the sdr table relies on an ending
record with a recid of 0x. This patch changes the loop to use the
sdr size as a breaking condition.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Marcel Apfelbaum
---
hw/ipmi/ipmi_bmc_sim.c | 13
This will be useful to define and use properties when the object is
instantiated.
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
Reviewed-by: Marcel Apfelbaum
---
Changes since v1:
- removed empty properties.
hw/ipmi/ipmi_bmc_sim.c |7 ---
1 file changed, 4 insertions
c279bec754a and also available here :
https://github.com/legoater/qemu/commits/ipmi
Thanks,
C.
Cédric Le Goater (10):
ipmi: remove IPMI_CHECK_CMD_LEN() macro
ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers
ipmi: remove IPMI_CHECK_RESERVATION() macro
ipmi: add rsp_buffer_set_e
s a helper ipmi_get_handler().
Signed-off-by: Cédric Le Goater
Acked-by: Corey Minyard
---
Changes since v2:
- introduced ipmi_get_handler() helper.
hw/ipmi/ipmi_bmc_sim.c | 164 +
1 file changed, 84 insertions(+), 80 deletions(-)
I
1 - 100 of 12249 matches
Mail list logo
