RE: hexagon docker test failure

2022-07-26 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Richard Henderson > Sent: Tuesday, July 26, 2022 12:42 PM > To: Taylor Simpson > Cc: qemu-devel > Subject: Re: hexagon docker test failure > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or

RE: [PATCH v3 2/3] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 2/3] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 1/3] Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it

2024-02-16 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, February 13, 2024 10:27 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v3 11/29] target/hexagon: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-29 Thread Brian Cain
enderson ; > Philippe Mathieu-Daudé ; Brian Cain > > Subject: [PATCH v3 11/29] target/hexagon: Prefer fast cpu_env() over slower > CPU QOM cast macro > > WARNING: This email originated from outside of Qualcomm. Please be wary of > any links or attachments, and do not ena

RE: [PATCH-for-9.1 08/27] target/hexagon: Convert to TCGCPUOps::get_cpu_state()

2024-03-22 Thread Brian Cain
; Philippe Mathieu-Daudé ; Brian Cain > > Subject: [PATCH-for-9.1 08/27] target/hexagon: Convert to > TCGCPUOps::get_cpu_state() > > WARNING: This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > > Convert cp

RE: [PATCH v2 8/9] Hexagon (target/hexagon) Remove gen_shortcode.py

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 9/9] Hexagon (target/hexagon) Remove hex_common.read_attribs_file

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 7/9] Hexagon (target/hexagon) Remove gen_op_regs.py

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 6/9] Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 4/9] Hexagon (target/hexagon) Mark has_pred_dest in trans functions

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 5/9] Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 3/9] Hexagon (target/hexagon) Mark dest_idx in trans functions

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 2/9] Hexagon (target/hexagon) Mark new_read_idx in trans functions

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 1/9] Hexagon (target/hexagon) Add is_old/is_new to Register class

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Wednesday, March 6, 2024 9:23 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 3/3] Hexagon (target/hexagon) Enable more short-circuit packets (HVX)

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, February 1, 2024 4:34 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 2/3] Hexagon (target/hexagon) Enable more short-circuit packets (scalar core)

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, February 1, 2024 4:34 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH v2 1/3] Hexagon (target/hexagon) Analyze reads before writes

2024-03-28 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, February 1, 2024 4:34 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; > Marco Liebel (QUIC) ; > richard.hender...@linaro.org; phi...@linaro.org;

RE: [PATCH] Hexagon: add PC alignment check and exception

2024-04-26 Thread Brian Cain
> -Original Message- > From: Matheus Bernardino (QUIC) > Sent: Friday, April 26, 2024 1:16 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: add PC alignment check a

RE: [PATCH v3] Hexagon: add PC alignment check and exception

2024-04-30 Thread Brian Cain
> -Original Message- > From: Richard Henderson > Sent: Tuesday, April 30, 2024 10:53 AM > To: Matheus Bernardino (QUIC) ; qemu- > de...@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com; Laurent Vivier > > Subj

[PULL 01/15] Hexagon (target/hexagon) Analyze reads before writes

2024-05-05 Thread Brian Cain
to improving the analysis for short-circuiting the packet semantics in a subsequent commit Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240201103340.119081-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 9 +++--

[PULL 03/15] Hexagon (target/hexagon) Enable more short-circuit packets (HVX)

2024-05-05 Thread Brian Cain
From: Taylor Simpson Look for read-after-write instead of overlap of reads and writes HVX instructions with helpers have pass-by-reference semantics, so we check for overlaps of reads and writes within the same instruction. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id

[PULL 09/15] Hexagon (target/hexagon) Mark dest_idx in trans functions

2024-05-05 Thread Brian Cain
From: Taylor Simpson Check that the value matches opcode_reginfo/opcode_wregs Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 2 ++ target/h

[PULL 00/15] Hexagon: simplify gen for packets w/o read-after-write

2024-05-05 Thread Brian Cain
The following changes since commit 248f6f62df073a3b4158fd0093863ab885feabb5: Merge tag 'pull-axp-20240504' of https://gitlab.com/rth7680/qemu into staging (2024-05-04 08:39:46 -0700) are available in the Git repository at: https://github.com/quic/qemu tags/pull-hex-20240505 for you to fetc

[PULL 08/15] Hexagon (target/hexagon) Mark new_read_idx in trans functions

2024-05-05 Thread Brian Cain
From: Taylor Simpson Check that the value matches opcode_reginfo Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 2 ++ target/h

[PULL 12/15] Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc

2024-05-05 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-7-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 55 +++-- target/hexagon/mmvec/decode_ext_mmvec.

[PULL 13/15] Hexagon (target/hexagon) Remove gen_op_regs.py

2024-05-05 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-8-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 1 - target/hexagon/gen_op_regs.py | 125 -- target/h

[PULL 04/15] Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it

2024-05-05 Thread Brian Cain
From: Taylor Simpson Rather than reading P0 from the env, pass it explicitly Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson Reviewed-by: Brian Cain Message-Id: <20240214042726.19290-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain ---

[PULL 02/15] Hexagon (target/hexagon) Enable more short-circuit packets (scalar core)

2024-05-05 Thread Brian Cain
set_label $L0 exit_tb $0x7f976443 Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240201103340.119081-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/translate.c | 21 - target/hexagon/translate.h | 13 +++-- 2

[PULL 07/15] Hexagon (target/hexagon) Add is_old/is_new to Register class

2024-05-05 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/hex_common.py | 12 1 file changed, 12 insertions(+)

[PULL 11/15] Hexagon (tests/tcg/hexagon) Test HVX .new read from high half of pair

2024-05-05 Thread Brian Cain
From: Taylor Simpson Make sure the decoding of HVX .new is correctly handling this case Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-6-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- tests/tcg/hexagon/hvx_misc.c | 16 +++-

[PULL 06/15] Hexagon (target/hexagon) Only pass env to generated helper when needed

2024-05-05 Thread Brian Cain
idef-parser disabled: 1543 total, 550 with env Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson Message-Id: <20240214042726.19290-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_helper_protos.py | 12 +++

[PULL 15/15] Hexagon (target/hexagon) Remove hex_common.read_attribs_file

2024-05-05 Thread Brian Cain
From: Taylor Simpson The attribinfo data structure is not used Adjust the command-line arguments to the python scripts Add hex_common.read_common_files for TCG/helper generation scripts Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Message-Id

[PULL 05/15] Hexagon (target/hexagon) Pass SP explicitly to helpers that need it

2024-05-05 Thread Brian Cain
From: Taylor Simpson Rather than reading SP from the env, pass it explicitly Signed-off-by: Taylor Simpson Reviewed-by: Anton Johansson Tested-by: Anton Johansson Reviewed-by: Brian Cain Message-Id: <20240214042726.19290-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain ---

[PULL 14/15] Hexagon (target/hexagon) Remove gen_shortcode.py

2024-05-05 Thread Brian Cain
From: Taylor Simpson This data structure is not used Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240307032327.4799-9-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 1 - target/h

[PULL 10/15] Hexagon (target/hexagon) Mark has_pred_dest in trans functions

2024-05-05 Thread Brian Cain
From: Taylor Simpson Check that the value matches opcode_wregs Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240307032327.4799-5-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c | 3 +++ target/hexagon/gen_trans_funcs.

RE: [PATCH v6] Hexagon: add PC alignment check and exception

2024-05-07 Thread Brian Cain
> -Original Message- > From: Matheus Bernardino (QUIC) > Sent: Friday, May 3, 2024 11:53 AM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com; > richard.hender...@linaro.org; Laurent Vivier > Sub

RE: [PATCH] Use hexagon toolchain version 16.0.0

2023-03-29 Thread Brian Cain
CHAIN_RELEASE}-cross- > hexagon-unknown-linux-musl" > ENV TOOLCHAIN_URL https://codelinaro.jfrog.io/artifactory/codelinaro- > toolchain-for- > hexagon/v${TOOLCHAIN_RELEASE}/${TOOLCHAIN_BASENAME}.tar.xz > > -- > 2.25.1 > Reviewed-by: Brian Cain

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Brian Cain
> -Original Message- > From: Marco Liebel (QUIC) > Sent: Tuesday, May 9, 2023 1:43 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain ; > Matheus Bernardino (QUIC) ; Marco Liebel > (QUIC) > Subject: [PATCH] Remove test_vshuff from hvx_misc tests

RE: [PATCH] Remove test_vshuff from hvx_misc tests

2023-05-09 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Tuesday, May 9, 2023 2:28 PM > To: Marco Liebel (QUIC) ; qemu- > de...@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > > Subject: RE: [PATCH] Remove test_vshuff from hvx_misc tests > >

RE: [PATCH v3 5/6] Hexagon (gdbstub): add HVX support

2023-05-12 Thread Brian Cain
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Thursday, May 4, 2023 10:38 AM > To: qemu-devel@nongnu.org > Cc: alex.ben...@linaro.org; Brian Cain ; > f4...@amsat.org; peter.mayd...@linaro.org; Taylor Simpson > ; phi...@linaro.org; richard.hender...@

RE: [PATCH v2 11/21] Hexagon (target/hexagon) Short-circuit packet register writes

2023-04-27 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, April 27, 2023 6:00 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > &g

RE: [PATCH v2] Hexagon (target/hexagon) Fix assignment to tmp registers

2023-05-22 Thread Brian Cain
> -Original Message- > From: Marco Liebel (QUIC) > Sent: Monday, May 22, 2023 12:47 PM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain ; > Marco Liebel (QUIC) > Subject: [PATCH v2] Hexagon (target/hexagon) Fix assignment to tmp registers &g

RE: Help finding Coverity defects for generated Hexagon code

2023-05-23 Thread Brian Cain
> -Original Message- > From: qemu-devel-bounces+bcain=quicinc@nongnu.org bounces+bcain=quicinc@nongnu.org> On Behalf Of Richard Henderson > Sent: Tuesday, May 23, 2023 10:32 AM > To: a...@rev.ng; Paolo Bonzini ; Peter Maydell > > Cc: qemu-devel@nongnu.org > Subject: Re: Help fin

[ Job Ad ] Qualcomm hiring developers to work on QEMU

2022-02-24 Thread Brian Cain
/* moderators - this is a job ad, please discard if it's not permitted by the community */ Qualcomm has openings for developers to help work on QEMU for the Hexagon DSP. If you like QEMU and are interested in challenging work, please apply! https://qualcomm.wd5.myworkdayjobs.com/External/job/A

hexagon container update

2021-10-01 Thread Brian Cain
Alex, We need to update the docker container used for hexagon for new test cases proposed in Taylor's recent patch series under review. Thankfully, CodeLinaro has provided a binary of the hexagon cross toolchain so now I think we can simplify the hexagon docker file to something like the below

RE: hexagon container update

2021-10-01 Thread Brian Cain
> -Original Message- > From: Richard Henderson ... > On 10/1/21 12:59 PM, Brian Cain wrote: > > Alex, > > > > We need to update the docker container used for hexagon for new test cases > proposed in Taylor's recent patch series under review. Thankfully,

RE: hexagon container update

2021-10-01 Thread Brian Cain
> -Original Message- > From: Brian Cain ... > > -Original Message- > > From: Richard Henderson > ... > > On 10/1/21 12:59 PM, Brian Cain wrote: > > > Alex, > > > > > > We need to update the docker container used for hexago

RE: hexagon container update

2022-01-14 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Friday, October 1, 2021 7:23 PM > To: Richard Henderson ; Alex Bennée > ; qemu-devel@nongnu.org > Cc: Taylor Simpson > Subject: RE: hexagon container update > > > -Original Message- > > From:

RE: hexagon container update

2022-01-18 Thread Brian Cain
> -Original Message- > From: Alex Bennée .. > Brian Cain writes: > ... > > We had some issues with the previous attempt to update the container. > > The linux-user "signals" test failed. Richard pointed out that the > > archive of the C library

RE: hexagon container update

2022-01-18 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Tuesday, January 18, 2022 9:25 AM > To: Alex Bennée > Cc: Richard Henderson ; qemu- > de...@nongnu.org; Taylor Simpson > Subject: RE: hexagon container update > > > -Original Message- > > Fr

[PATCH] tests: Remove unused "wcount" from linux-test.c

2022-05-20 Thread Brian Cain
clang reports this variable as 'set but not used'. Signed-off-by: Brian Cain --- tests/tcg/multiarch/linux/linux-test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/tcg/multiarch/linux/linux-test.c b/tests/tcg/multiarch/linux/linux-test.c index

RE: [PATCH] tests: Remove unused "wcount" from linux-test.c

2022-05-20 Thread Brian Cain
> -Original Message- > From: Peter Maydell > Sent: Friday, May 20, 2022 8:21 AM > To: Brian Cain > Cc: Daniel P. Berrangé ; qemu-devel@nongnu.org; > Alex Bennée > Subject: Re: [PATCH] tests: Remove unused "wcount" from linux-test.c > > WARNING:

[PATCH] Hexagon (target/hexagon) implement mutability mask for GPRs

2022-09-01 Thread Brian Cain
Some registers are defined to have immutable bits, this commit will implement that behavior. Signed-off-by: Brian Cain --- target/hexagon/gen_masked.c | 44 target/hexagon/gen_masked.h | 26 target/hexagon/genptr.c | 33 - target/hexagon

RE: [PATCH] linux-test.c: Remove unused but set variable

2023-01-05 Thread Brian Cain
> -Original Message- > From: Brian Cain > Sent: Thursday, January 5, 2023 11:10 AM > To: Taylor Simpson ; qemu-devel@nongnu.org; > alex.ben...@linaro.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Mat

RE: [PATCH] linux-test.c: Remove unused but set variable

2023-01-05 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Thursday, January 5, 2023 10:24 AM > To: qemu-devel@nongnu.org; alex.ben...@linaro.org > Cc: Taylor Simpson ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Mat

Re: [PATCH] target/hexagon: don't look for static glib

2024-08-05 Thread Brian Cain
On 8/5/2024 5:49 AM, Alyssa Ross wrote: When cross compiling QEMU configured with --static, I've been getting configure errors like the following: Build-time dependency glib-2.0 found: NO ../target/hexagon/meson.build:303:15: ERROR: Dependency lookup for glib-2.0 with method 'pkgco

Re: [PATCH] target/hexagon: don't look for static glib

2024-08-05 Thread Brian Cain
On 8/5/2024 8:57 AM, Brian Cain wrote: On 8/5/2024 5:49 AM, Alyssa Ross wrote: When cross compiling QEMU configured with --static, I've been getting configure errors like the following: Build-time dependency glib-2.0 found: NO ../target/hexagon/meson.build:303:15:

Re: [PATCH] target/hexagon: don't look for static glib

2024-08-06 Thread Brian Cain
binaries to be static. Signed-off-by: Alyssa Ross --- Reviewed-by: Brian Cain target/hexagon/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build index b0b253aa6b..9ea1f4fc59 100644 --- a/target/hexagon/meson.build

[PULL 6/6] target/hexagon: switch to dc set_props() list

2024-08-07 Thread Brian Cain
Define a hexagon_cpu_properties list to match the idiom used by other targets. Signed-off-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Taylor Simpson --- target/hexagon/cpu.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/target

[PULL 4/6] MAINTAINERS: Add my hexagon git tree

2024-08-07 Thread Brian Cain
Add my git tree for hexagon. Note that the branch is "hex-next" and not "hex.next" as had been used previously. But I'll keep the "hex.next" branch in sync with "hex-next" until this commit lands to avoid confusion. Signed-off-by: Brian Cain R

[PULL 5/6] target/hexagon: define a v66 CPU

2024-08-07 Thread Brian Cain
For now, v66 behavior is the same as other CPUs. Signed-off-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Taylor Simpson --- target/hexagon/cpu-qom.h | 1 + target/hexagon/cpu.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/target/hexagon/cpu-qom.h b/target

[PULL 1/6] Hexagon: fix F2_conv_* instructions for negative zero

2024-08-07 Thread Brian Cain
ed-by: Brian Cain Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/op_helper.c | 18 +- tests/tcg/hexagon/usr.c| 12 +++- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c

[PULL 0/6] hex queue

2024-08-07 Thread Brian Cain
_conv* fix Anton Johansson (1): target/hexagon/idef-parser: Remove self-assignment Brian Cain (3): MAINTAINERS: Add my hexagon git tree target/hexagon: define a v66 CPU target/hexagon: switch to dc set_props() list Matheus Tavares Bernardino (1): He

[PULL 2/6] Hexagon: lldb read/write predicate registers p0/p1/p2/p3

2024-08-07 Thread Brian Cain
Predicate Registers: p0 = 0x00 p1 = 0xff p2 = 0x00 p3 = 0xff Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino Message-Id: <20240613182209.140082-1-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- gdb

[PULL 3/6] target/hexagon/idef-parser: Remove self-assignment

2024-08-07 Thread Brian Cain
From: Anton Johansson The self assignment is clearly useless, and @1.last_column does not have to be set for an expression with only a single token, so remove it. Reported-by: Peter Maydell Signed-off-by: Anton Johansson Reviewed-by: Brian Cain Reviewed-by: Philippe Mathieu-Daudé Message-Id

Re: [PULL 0/6] hex queue

2024-08-08 Thread Brian Cain
On 8/8/2024 5:39 PM, Richard Henderson wrote: On 8/8/24 13:42, Brian Cain wrote: The following changes since commit 4c395ac42e55ff8e9fd4c992e351a04b10785503:    Merge tag 'pull-tcg-20240808' of https://gitlab.com/rth7680/qemu into staging (2024-08-08 09:07:00 +1000) are availa

[PATCH 3/3] target/hexagon: add enums for event, cause

2024-08-16 Thread Brian Cain
Signed-off-by: Brian Cain --- target/hexagon/cpu_bits.h | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/target/hexagon/cpu_bits.h b/target/hexagon/cpu_bits.h index eec456d8f9..2454ef72bf 100644 --- a/target/hexagon/cpu_bits.h +++ b/target/hexagon

[PATCH 2/3] target/hexagon: rename HEX_EVENT_TRAP0=>HEX_CAUSE_TRAP0

2024-08-16 Thread Brian Cain
The value previously used for "HEX_EVENT_TRAP0" was the cause code definition and not the event number. So in this commit, we update the name to reflect the cause code and add a new "HEX_EVENT_TRAP0" with the correct event number. Signed-off-by: Brian Cain --- target/he

[PATCH 1/3] target/hexagon: Rename HEX_EXCP_ => HEX_EVENT_

2024-08-16 Thread Brian Cain
Change the name of these definitions to reflect that they correspond to the event code for the exception. Signed-off-by: Brian Cain --- linux-user/hexagon/cpu_loop.c | 4 ++-- target/hexagon/cpu.h | 2 +- target/hexagon/cpu_bits.h | 14 +++--- target/hexagon/gen_tcg.h

RE: KVM Community Call (20/8/24) agenda items?

2024-08-20 Thread Brian Cain
> -Original Message- > From: Alex Bennée > Sent: Tuesday, August 20, 2024 5:59 AM > To: QEMU Developers > Cc: Alessandro Di Federico ; Alistair Francis > ; Anton Johansson ; Markus > Armbruster ; Brian Cain ; Daniel P. > Berrange ; Chao Peng ; > c...@nvidi

Re: [Semihosting Tests PATCH v2 1/3] .editorconfig: add code conventions for tooling

2024-05-30 Thread Brian Cain
On 5/30/2024 6:23 AM, Alex Bennée wrote: It's a pain when you come back to a code base you haven't touched in a while and realise whatever indent settings you were using having carried over. Add an editorconfig and be done with it. Signed-off-by: Alex Bennée Adding an editorconfig seems li

Re: [PATCH v4 1/4] target/hexagon: idef-parser remove unused defines

2024-06-05 Thread Brian Cain
Reviewed-by: Taylor Simpson Reviewed-by: Brian Cain --- Queued -- at https://github.com/quic/qemu/tree/hex.next target/hexagon/idef-parser/idef-parser.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef-parser/idef

Re: [PATCH] Hexagon: fix HVX store new

2024-06-05 Thread Brian Cain
On 5/20/2024 10:53 AM, Matheus Tavares Bernardino wrote: At 09a7e7db0f (Hexagon (target/hexagon) Remove uses of op_regs_generated.h.inc, 2024-03-06), we've changed the logic of check_new_value() to use the new pre-calculated packet->insn[...].dest_idx instead of calculating the index on the fly

RE: [PATCH v2 0/3] Hexagon (target/hexagon) Use QEMU decodetree

2024-01-15 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Monday, January 15, 2024 4:15 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

RE: [PATCH v2 0/9] Hexagon (target/hexagon) Make generators object oriented

2024-01-15 Thread Brian Cain
> -Original Message- > From: Taylor Simpson > Sent: Sunday, December 10, 2023 4:07 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Matheus Bernardino (QUIC) > ; Sid Manning ; Marco > Liebel (QUIC) ; richard.hender...@linaro.org; > phi...@linaro.org;

[PULL 00/15] target-hexagon queue, hexagon docker

2024-01-21 Thread Brian Cain
decodetree -------- Brian Cain (2): tests/docker: Hexagon toolchain update target/hexagon: reduce scope of def_regnum, remove dead assignment Taylor Simpson (13): Hexagon (target/hexagon) Fix shadow variable when idef-parser is off Hexag

[PULL 08/15] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs

2024-01-21 Thread Brian Cain
From: Taylor Simpson Reviewed-by: Brian Cain Signed-off-by: Taylor Simpson Message-Id: <20231210220712.491494-7-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_op_regs.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/h

[PULL 09/15] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs

2024-01-21 Thread Brian Cain
From: Taylor Simpson This patch conflicts with https://lists.gnu.org/archive/html/qemu-devel/2023-11/msg00729.html If that series goes in first, we'll rework this patch and vice versa. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-8-lta

[PULL 05/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos

2024-01-21 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_helper_protos.py | 149 ++-- target/hexagon/hex_common.py| 7

[PULL 03/15] Hexagon (target/hexagon) Clean up handling of modifier registers

2024-01-21 Thread Brian Cain
register corresponding to the modifier register specified in the instruction. We create a TCGv variable "CS" to hold the value to pass to the helper. Reviewed-by: Brian Cain Signed-off-by: Taylor Simpson Message-Id: <20231210220712.491494-2-ltaylorsimp...@gmail.com> Signed-of

[PULL 14/15] Hexagon (target/hexagon) Remove old dectree.py

2024-01-21 Thread Brian Cain
From: Taylor Simpson Now that we are using QEMU decodetree.py, remove the old decoder Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240115221443.365287-4-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/decode.c

[PULL 06/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_funcs

2024-01-21 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-5-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_helper_funcs.py | 370 + target/hexagon/hex_common.py | 48 +

[PULL 12/15] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions)

2024-01-21 Thread Brian Cain
2-bit instructions Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20240115221443.365287-2-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 13 +- target/hexagon/decode.c | 54 - target/hexagon/decode.h

[PULL 02/15] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off

2024-01-21 Thread Brian Cain
From: Taylor Simpson Adding -Werror=shadow=compatible-local causes Hexagon not to build when idef-parser is off. The "label" variable in CHECK_NOSHUF_PRED shadows a variable in the surrounding code. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Philippe Mat

[PULL 01/15] tests/docker: Hexagon toolchain update

2024-01-21 Thread Brian Cain
This update includes support for privileged instructions. Signed-off-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino Tested-by: Matheus Tavares Bernardino Message-Id: <20240114232354.4109231-1-bc...@quicinc.com> --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 4 ++--

[PULL 13/15] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions)

2024-01-21 Thread Brian Cain
Brian Cain Message-Id: <20240115221443.365287-3-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/README | 1 + target/hexagon/decode.c | 85 + target/hexagon/gen_decodetree.py | 12 - target/hexagon/gen_trans_fu

[PULL 04/15] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs

2024-01-21 Thread Brian Cain
ommon that use regtype/regid (e.g., is_read) This patch creates the class hierarchy in hex_common and converts gen_tcg_funcs.py. The other scripts will be converted in subsequent patches in this series. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.

[PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead assignment

2024-01-21 Thread Brian Cain
This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino Message-Id: <20240114234453.4114587-1-bc...@quicinc.com> --- target/hexagon/mmvec/decode_ext_mmvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PULL 07/15] Hexagon (target/hexagon) Make generators object oriented - gen_idef_parser_funcs

2024-01-21 Thread Brian Cain
From: Taylor Simpson Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-6-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/gen_idef_parser_funcs.py | 20 1 file changed, 4 insertions(+), 16 deletions(-)

[PULL 10/15] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute

2024-01-21 Thread Brian Cain
From: Taylor Simpson This is the only remaining use of the is_written function. We will remove it in the subsequent commit. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-9-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/h

[PULL 11/15] Hexagon (target/hexagon) Remove dead functions from hex_common.py

2024-01-21 Thread Brian Cain
From: Taylor Simpson These functions are no longer used after making the generators object oriented. Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Message-Id: <20231210220712.491494-10-ltaylorsimp...@gmail.com> Signed-off-by: Brian Cain --- target/hexagon/hex_common.p

hexagon: modeling a shared lock state

2024-01-24 Thread Brian Cain
Philippe, For hexagon sysemu, while internally reviewing patches to be upstreamed we noticed that our design for a lock instruction is not quite suitable. The k0lock instruction will halt if some other hexagon hardware CPU has already claimed the kernel lock, only to continue executing once so

RE: hexagon: modeling a shared lock state

2024-01-25 Thread Brian Cain
> -Original Message- > From: Richard Henderson > Sent: Wednesday, January 24, 2024 6:22 PM > To: Brian Cain ; Philippe Mathieu-Daudé > > Cc: qemu-devel@nongnu.org; Sid Manning ; Marco > Liebel ; Matheus Bernardino > > Subject: Re: hexagon: modeling a sha

KVM Forum 2024?

2024-01-26 Thread Brian Cain
All, https://kvm-forum.qemu.org/ shows a plan for "Spring 2024" - so that's as soon as ~mid-March or as late as mid-June? I'd like to understand if we think that it's more likely to be later in that range? Last year was mid June I think? So should we expect something similar this year? -Bria

Re: [PATCH] Hexagon: fix HVX store new

2024-05-20 Thread Brian Cain
r, we also used to follow an alphabetical order on the register type: 'd', 'e', 'x', and 'y'. No longer following that makes us select the wrong register index and the HVX store new instruction does not update the memory like expected. Signed-off-by:

Re: [PATCH v3 2/4] target/hexagon: idef-parser remove undefined functions

2024-05-21 Thread Brian Cain
On 5/21/2024 3:16 PM, Anton Johansson via wrote: Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- Reviewed-by: Brian Cain target/hexagon/idef-parser/parser-helpers.h | 13 - 1 file changed, 13 deletions(-) diff --git a/target/hexagon/idef-parser/parser

Re: [PATCH v3 3/4] target/hexagon: idef-parser fix leak of init_list

2024-05-21 Thread Brian Cain
rvalue predicate, gen_inst_init_args() isn't called and init_list will never be freed. Free init_list from free_instruction() if it hasn't already been freed. A comment in free_instruction is also updated. Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- Reviewed-by:

Re: [PATCH v3 1/4] target/hexagon: idef-parser remove unused defines

2024-05-21 Thread Brian Cain
Reviewed-by: Taylor Simpson --- Reviewed-by: Brian Cain target/hexagon/idef-parser/idef-parser.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef-parser/idef-parser.h index 3faa1deecd..8594cbe3a2 100644 --- a

Re: [PATCH v3 4/4] target/hexagon: idef-parser simplify predicate init

2024-05-21 Thread Brian Cain
--- Reviewed-by: Brian Cain target/hexagon/idef-parser/idef-parser.y| 2 -- target/hexagon/idef-parser/parser-helpers.c | 26 +++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef-parser/idef-parser.y

  1   2   3   4   >