> -----Original Message-----
> From: Taylor Simpson <tsimp...@quicinc.com>
> Sent: Tuesday, May 9, 2023 2:28 PM
> To: Marco Liebel (QUIC) <quic_mlie...@quicinc.com>; qemu-
> de...@nongnu.org
> Cc: Brian Cain <bc...@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathb...@quicinc.com>
> Subject: RE: [PATCH] Remove test_vshuff from hvx_misc tests
> 
> 
> 
> > -----Original Message-----
> > From: Marco Liebel (QUIC) <quic_mlie...@quicinc.com>
> > Sent: Tuesday, May 9, 2023 1:43 PM
> > To: qemu-devel@nongnu.org
> > Cc: Taylor Simpson <tsimp...@quicinc.com>; Brian Cain
> > <bc...@quicinc.com>; Matheus Bernardino (QUIC)
> > <quic_mathb...@quicinc.com>; Marco Liebel (QUIC)
> > <quic_mlie...@quicinc.com>
> > Subject: [PATCH] Remove test_vshuff from hvx_misc tests
> >
> > test_vshuff checks that the vshuff instruction works correctly when both
> > vector registers are the same. Using vshuff in this way is undefined and 
> > will
> > be rejected by the compiler in a future version of the toolchain.
> >
> > Signed-off-by: Marco Liebel <quic_mlie...@quicinc.com>
> > ---
> >  tests/tcg/hexagon/hvx_misc.c | 45 ------------------------------------
> >  1 file changed, 45 deletions(-)
> 
> Let's not remove the test completely.  Just change it to use different 
> registers.

I'm fine either way.  But IIRC we added this test particularly in order to 
verify the potentially ambiguous behavior of the same operand here.  It may be 
well tested otherwise.

Reply via email to