Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 7:33 AM, Paolo Bonzini wrote: > Il 03/07/2012 21:09, Blue Swirl ha scritto: >>> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest >>> > *req, uint8_t *outbuf) >>> > outbuf[bufl

Re: [Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 8:34 AM, Kevin Wolf wrote: > Am 03.07.2012 21:19, schrieb Blue Swirl: >> On Tue, Jul 3, 2012 at 10:07 AM, Kevin Wolf wrote: >>> Am 09.06.2012 14:12, schrieb Blue Swirl: >>>> Move logging functions from exec.c to qemu-log.c, >>>>

Re: [Qemu-devel] plan for device assignment upstream

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 8:05 AM, Avi Kivity wrote: > On 07/03/2012 10:06 PM, Blue Swirl wrote: >> On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity wrote: >>> On 07/02/2012 12:30 PM, Jan Kiszka wrote: >>>> On 2012-07-02 11:18, Michael S. Tsirkin wrote: >>>>>

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-05 Thread Blue Swirl
On Tue, Jul 3, 2012 at 8:15 PM, Andreas Färber wrote: > Am 03.07.2012 21:11, schrieb Blue Swirl: >> On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote: >>> On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote: >>>> Andreas Färber writes: >>>>

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 4:36 PM, Eric Blake wrote: > On 07/04/2012 10:19 AM, Paolo Bonzini wrote: >> Il 03/07/2012 22:15, Andreas Färber ha scritto: > > I'd also vote for %u. PRI*32 do not seem very useful compared to plain > int versions. >>> If it's not useful we should use unsigned i

Re: [Qemu-devel] [PATCH v8 08/16] target-or32: Add instruction translation

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 11:59 PM, Jia Liu wrote: > On Wed, Jul 4, 2012 at 10:23 AM, Jia Liu wrote: >> Hi Blue, >> >> On Wed, Jul 4, 2012 at 2:48 AM, Blue Swirl wrote: >>> On Sun, Jul 1, 2012 at 2:45 AM, Jia Liu wrote: >>>> +swi

Re: [Qemu-devel] [RFC][PATCH v2 2/4] tcg: add extended MMU helpers to softmmu targets

2012-07-05 Thread Blue Swirl
On Thu, Jul 5, 2012 at 1:43 PM, Peter Maydell wrote: > On 5 July 2012 14:23, Yeongkyoon Lee wrote: >> Add extended MMU helpers to softmmu targets, where the targets are alpha, >> arm, cris, i386, lm32, m68k, microblaze, mips, ppc, s390x, sh4, sparc and >> xtensa. >> >> Signed-off-by: Yeongkyoon

Re: [Qemu-devel] [PATCH 5/6] hw/arm_boot.c: Support DTBs which use 64 bit addresses

2012-07-05 Thread Blue Swirl
On Thu, Jul 5, 2012 at 5:00 PM, Peter Maydell wrote: > Support the case where the device tree blob specifies that > #address-cells and #size-cells are greater than 1. (This > is needed for device trees which can handle 64 bit physical > addresses and thus total RAM sizes over 4GB.) > > Signed-off-

Re: [Qemu-devel] [PATCH] target-i386: Fix compilation with --enable-debug

2012-07-05 Thread Blue Swirl
Thanks, applied. On Fri, Jun 29, 2012 at 8:38 PM, Stefan Weil wrote: > commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table > type safety which now raises compiler errors when latest QEMU was > configured with --enable-debug. > > Fix this by splitting the SSE tables even further to

Re: [Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly

2012-07-07 Thread Blue Swirl
On Fri, Jul 6, 2012 at 6:57 AM, Markus Armbruster wrote: > Each test litters /tmp with several files: a pid file and two > sockets. Tidy up. > > Signed-off-by: Markus Armbruster While a nice patch, I don't think it should belong to this series. > --- > tests/libqtest.c | 29

Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-07 Thread Blue Swirl
On Fri, Jul 6, 2012 at 7:05 AM, Paolo Bonzini wrote: > Il 05/07/2012 20:03, Blue Swirl ha scritto: >> > > > +if (s->wwn) { >> > > > +outbuf[buflen++] = 0x1; // Binary >> > > > +outbuf[buflen++] =

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-07 Thread Blue Swirl
On Fri, Jul 6, 2012 at 11:43 AM, Yeongkyoon Lee wrote: > On 2012년 07월 05일 23:06, Peter Maydell wrote: >> >> On 5 July 2012 14:23, Yeongkyoon Lee wrote: >>> >>> Add an option "--enable-ldst-optimization" to enable >>> CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only >>>

Re: [Qemu-devel] [PATCH 3/4 V3] Header with various utility functions shared

2012-07-07 Thread Blue Swirl
On Sat, Jul 7, 2012 at 5:05 AM, Deep Debroy wrote: > Signed-off-by: Deep Debroy > --- > hw/vmware_utils.h | 126 > + > 1 file changed, 126 insertions(+) > create mode 100644 hw/vmware_utils.h > > diff --git a/hw/vmware_utils.h b/hw/vmware_ut

Re: [Qemu-devel] [PULL 00/10] arm-devs queue

2012-07-07 Thread Blue Swirl
On Wed, Jul 4, 2012 at 11:14 AM, Peter Maydell wrote: > Usual arm-devs pullreq; this contains some minor exynos fixes > and the iMX31 model. Please pull. Thanks, pulled. > > thanks > -- PMM > > > The following changes since commit 71ea2e016131a9fcde6f1ffd3e0e34a64c21f593: > > bsd-user: fix bui

Re: [Qemu-devel] [PATCH 0/3] target-i386: minor code cleanups

2012-07-07 Thread Blue Swirl
On Thu, Jul 5, 2012 at 9:28 PM, Peter Maydell wrote: > These three patches fix some minor code cleanliness issues I > noticed while reviewing Stefan Weil's recent build-breakage > fixing patch. No behavioural changes. Thanks, applied all. > > Peter Maydell (3): > target-i386: Remove unused mac

Re: [Qemu-devel] [PATCH v4] bitops.h: Add functions to extract and deposit bitfields

2012-07-07 Thread Blue Swirl
On Fri, Jul 6, 2012 at 2:48 PM, Peter Maydell wrote: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. > > Suggested-by: Jia Liu > Suggested-by: Avi Kivity > Signed-off-by:

[Qemu-devel] [PATCH] qemu-log: fix x86 and user logging

2012-07-07 Thread Blue Swirl
5726c27fa913296aafab9f50b912cea5b3709271 broke x86 specific options and user emulation specific stdio buffering. Always enable all log items. They may not be useful for non-x86 targets, but there's no harm either. Fix user emulation buffering by passing around a flag. Signed-off-by: Blue

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-07-08 Thread Blue Swirl
On Sun, Jul 8, 2012 at 11:37 AM, Avi Kivity wrote: > On 06/28/2012 08:58 AM, Markus Armbruster wrote: Better code is an argument only if the effect can be demonstrated. >>> >>> I don't know even for which compilers or CPUs this is true so it's >>> unlikely I could demonstrate it. However

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-08 Thread Blue Swirl
On Sun, Jul 8, 2012 at 12:09 PM, Andreas Schwab wrote: > blauwir...@gmail.com writes: > >> +pstrcpy(bs->backing_format, sizeof(bs->backing_format), >> +backing_fmt ? backing_file : ""); > > s/backing_file/backing_fmt/ Thanks, will fix. I accidentally sent the patches using wrong

Re: [Qemu-devel] [PATCH] bitops: fix types

2012-07-08 Thread Blue Swirl
On Sun, Jul 8, 2012 at 2:04 PM, Peter Maydell wrote: > On 8 July 2012 13:12, wrote: >> -static inline uint64_t deposit64(uint64_t value, int start, int length, >> - uint64_t fieldval) >> +static inline uint64_t deposit64(uint64_t value, unsigned int start, >> +

Re: [Qemu-devel] [PATCH] bitops: fix types

2012-07-08 Thread Blue Swirl
On Sun, Jul 8, 2012 at 6:54 PM, Peter Maydell wrote: > On 8 July 2012 19:32, Blue Swirl wrote: >> On Sun, Jul 8, 2012 at 2:04 PM, Peter Maydell >> wrote: >>> On 8 July 2012 13:12, wrote: >>>> -static inline uint64_t deposit64(u

Re: [Qemu-devel] [PATCH] bitops: fix types

2012-07-08 Thread Blue Swirl
On Sun, Jul 8, 2012 at 7:32 PM, Peter Maydell wrote: > On 8 July 2012 20:12, Blue Swirl wrote: >> On Sun, Jul 8, 2012 at 6:54 PM, Peter Maydell >> wrote: >>> On 8 July 2012 19:32, Blue Swirl wrote: >>>> On Sun, Jul 8, 2012 at 2:04 PM, Peter Maydell &g

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-10 Thread Blue Swirl
On Mon, Jul 9, 2012 at 7:35 AM, Markus Armbruster wrote: > blauwir...@gmail.com writes: > >> From: Blue Swirl >> >> Replace expr1 ?: expr2 with expr1 ? expr1 : expr2 as K&R intended. >> >> If expr1 has side effects, introduce a temporary v

Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types

2012-07-10 Thread Blue Swirl
On Mon, Jul 9, 2012 at 7:49 AM, Markus Armbruster wrote: > blauwir...@gmail.com writes: > >> From: Blue Swirl >> >> Use 'unsigned int' for bit numbers instead of 'unsigned long' or >> 'int'. Adjust asserts. > > I'd like

Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool

2012-07-10 Thread Blue Swirl
On Mon, Jul 9, 2012 at 7:43 AM, Markus Armbruster wrote: > blauwir...@gmail.com writes: > >> From: Blue Swirl >> >> Use 'bool' type for return value of bit test functions. > > Matter of taste. 'bool' makes sense if you think of these funct

Re: [Qemu-devel] [PATCH v2] console: Implementing blinking of cursor

2012-07-10 Thread Blue Swirl
On Mon, Jul 9, 2012 at 2:53 PM, Jan Kiszka wrote: > Let the text console cursor blink at 2 HZ. > > Signed-off-by: Jan Kiszka > --- > > Changes in v2: > - fixed semantic of CONSOLE_CURSOR_PERIOD and reduced frequency > > I know there was a concern regarding the approach in general, but I > still

Re: [Qemu-devel] Disk geometry and migration

2012-07-10 Thread Blue Swirl
On Tue, Jul 10, 2012 at 6:34 PM, Markus Armbruster wrote: > Scenario: > > 1. Start a guest with a blank disk (need not be the only disk) and >default disk geometry. > > 2. Examine the disk's physical geometry > >Details depend on the device model. scsi-hd exposes it in mode pages >4 a

Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types

2012-07-10 Thread Blue Swirl
On Tue, Jul 10, 2012 at 7:37 PM, Peter Maydell wrote: > On 10 July 2012 20:18, Blue Swirl wrote: >> On Mon, Jul 9, 2012 at 7:49 AM, Markus Armbruster wrote: >>> There is no consensus. I recognize the power of maintainers to force a >>> change even without consens

Re: [Qemu-devel] [PATCH 1/5] target-i386: cpu: separate feature string parsing from CPU model lookup

2012-12-04 Thread Blue Swirl
On Mon, Dec 3, 2012 at 5:27 PM, Eduardo Habkost wrote: > Instead of using parsing the whole cpu_model string inside > cpu_x86_find_by_name(), first split it into the CPU model name and the > full feature string, then parse the feature string into pieces. > > When using CPU model classes, those two

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-04 Thread Blue Swirl
On Mon, Dec 3, 2012 at 9:30 PM, Anthony Liguori wrote: > > Hi, > > Based on popular demand, I'd like to continue with a 3-month release > cycle for the foreseeable future. One thing I'd like to "fix" though is > to avoid major holidays during the -rc cycles. > > The best cycle I can figure is: >

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 8:11 AM, liguang wrote: > Signed-off-by: liguang > --- > target-i386/helper.c | 70 > + > target-i386/machine.c |2 +- > target-i386/misc_helper.c |4 +- > target-i386/seg_helper.c |6 ++-- > 4 files chan

Re: [Qemu-devel] [RFC 6/8] qdev-properties.c: separate core from the code used only by qemu-system-*

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 1:19 PM, Eduardo Habkost wrote: > This separates the qdev properties code in two parts: > - qdev-properties.c, that contains most of the qdev properties code; > - qdev-properties-system.c for code specific for qemu-system-*, >containing: >- Property types: drive, c

Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 2:49 PM, Petar Jovanovic wrote: > From: Petar Jovanovic > > helper_shilo has not been shifting an accumulator value correctly for negative > values in 'shift' field. Minor optimization for shift=0 case. > This change also adds tests that will trigger issue and check for reg

Re: [Qemu-devel] [RFC 6/8] qdev-properties.c: separate core from the code used only by qemu-system-*

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 7:01 PM, Eduardo Habkost wrote: > On Tue, Dec 04, 2012 at 06:55:17PM +0000, Blue Swirl wrote: >> On Tue, Dec 4, 2012 at 1:19 PM, Eduardo Habkost wrote: >> > This separates the qdev properties code in two parts: >> > - qdev-properties.c, tha

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 6:42 PM, Peter Maydell wrote: > On 4 December 2012 18:38, Blue Swirl wrote: >> The definition of the hard freeze bothers me. A few patches that went >> in after 1.3-rc0 were not bug fixes but just new features, so the >> difference between soft and

Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 7:43 PM, Richard Henderson wrote: > On 2012-12-04 13:00, Blue Swirl wrote: >>> > +if (rs5_0 == 0) >>> > +return; >> The check should be moved to translation time so that the call to this >> helper is not generated at all.

Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 7:48 PM, Jovanovic, Petar wrote: >> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c >> index e7949c2..f8a7a9f 100644 >> --- a/target-mips/dsp_helper.c >> +++ b/target-mips/dsp_helper.c >> @@ -3814,17 +3814,17 @@ void helper_shilo(target_ulong ac, target_ulon

[Qemu-devel] [PATCH 2/4] exec: extract TB watchpoint check

2012-12-04 Thread Blue Swirl
Will be moved by the next patch. Signed-off-by: Blue Swirl --- exec.c | 22 ++ 1 files changed, 14 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index 6efd93e..7ee0650 100644 --- a/exec.c +++ b/exec.c @@ -2985,12 +2985,24 @@ static const MemoryRegionOps

[Qemu-devel] [PATCH 0/4] exec.c refactoring

2012-12-04 Thread Blue Swirl
Refactor TranslationBlock handling out of exec.c. This could also help make TCG more optional or add other code generators. Blue Swirl (4): exec: fix coding style exec: extract TB watchpoint check exec: move TB handling to translate-all.c exec: refactor cpu_restore_state exec-all.h

[Qemu-devel] [PATCH 1/4] exec: fix coding style

2012-12-04 Thread Blue Swirl
Fix coding style in areas to be moved by later patches. Signed-off-by: Blue Swirl --- exec.c | 178 +++ 1 files changed, 110 insertions(+), 68 deletions(-) diff --git a/exec.c b/exec.c index 8435de0..6efd93e 100644 --- a/exec.c +++ b

[Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state

2012-12-04 Thread Blue Swirl
Refactor common code around calls to cpu_restore_state(). tb_find_pc() has now no external users, make it static. Signed-off-by: Blue Swirl --- exec-all.h|6 ++ hw/kvmvapic.c |4 +--- target-alpha/helper.c | 14 +++--- target

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-05 Thread Blue Swirl
On Tue, Dec 4, 2012 at 10:00 PM, Anthony Liguori wrote: > Peter Maydell writes: > >> On 4 December 2012 18:38, Blue Swirl wrote: >>> The definition of the hard freeze bothers me. A few patches that went >>> in after 1.3-rc0 were not bug fixes but just new features,

Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state

2012-12-05 Thread Blue Swirl
On Wed, Dec 5, 2012 at 11:10 AM, Andreas Färber wrote: > Am 04.12.2012 22:20, schrieb Blue Swirl: >> Refactor common code around calls to cpu_restore_state(). >> >> tb_find_pc() has now no external users, make it static. >> >> Signed-off-by: Blue Swirl > >

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-05 Thread Blue Swirl
On Wed, Dec 5, 2012 at 7:41 PM, Hans de Goede wrote: > Hi, > > > On 12/05/2012 08:28 PM, Blue Swirl wrote: >> >> On Tue, Dec 4, 2012 at 10:00 PM, Anthony Liguori >> wrote: >>> >>> Peter Maydell writes: >>> >>>> On 4 December

Re: [Qemu-devel] [PATCH 1/1] tmp105: Fix I2C protocol bug

2012-12-06 Thread Blue Swirl
On Wed, Dec 5, 2012 at 7:48 PM, Alex Horn wrote: > The private buffer length field must only be incremented after the I2C > frame has been transmitted. > > To expose this bug, assume the temperature in the TMP105 hardware model > is +0.125 C (e.g. snow slush). Note that eleven bit precision is req

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-06 Thread Blue Swirl
On Thu, Dec 6, 2012 at 8:05 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Wed, Dec 5, 2012 at 7:41 PM, Hans de Goede wrote: >>> Hi, >>> >>> >>> On 12/05/2012 08:28 PM, Blue Swirl wrote: >>>> >>>> On Tue, Dec 4,

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-06 Thread Blue Swirl
On Thu, Dec 6, 2012 at 9:01 AM, Andreas Färber wrote: > Am 05.12.2012 20:28, schrieb Blue Swirl: >> On Tue, Dec 4, 2012 at 10:00 PM, Anthony Liguori wrote: >>> What was committed post hard freeze that's not a >>> bug fix? >> >> d3067b0 Documentation

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-06 Thread Blue Swirl
On Thu, Dec 6, 2012 at 10:19 AM, Kevin Wolf wrote: > Am 05.12.2012 20:58, schrieb Blue Swirl: >> On Wed, Dec 5, 2012 at 7:41 PM, Hans de Goede wrote: >>> Hi, >>> >>> >>> On 12/05/2012 08:28 PM, Blue Swirl wrote: >>>> >>

Re: [Qemu-devel] [PATCH] exec: Advise huge pages for the TCG code gen buffer

2012-12-08 Thread Blue Swirl
Thanks, applied. On Thu, Nov 1, 2012 at 10:20 PM, Richard Henderson wrote: > After allocating 32MB or more contiguous memory, huge pages > would seem to be ideal. > > Signed-off-by: Richard Henderson > --- > exec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/exec.c b/exec.c > ind

Re: [Qemu-devel] [PATCH] curses: Remove OpenBSD workaround

2012-12-08 Thread Blue Swirl
Thanks, applied. On Mon, Nov 19, 2012 at 9:22 AM, Brad Smith wrote: > I removed the same sort of workaround for OpenBSD within the > configure script with commit 4dcc3f5876fa638d5c35bd47be3b717ea74cc2e7 > but didn't bother to grep further to come across this same chunk > of code in the curses cod

Re: [Qemu-devel] [PATCH 0/5] TCG global gen_opc_ arrays clean-up

2012-12-08 Thread Blue Swirl
Thanks, applied all. On Tue, Dec 4, 2012 at 4:49 AM, Evgeny Voevodin wrote: > On 11/26/2012 08:19 AM, Evgeny Voevodin wrote: >> >> On 11/21/2012 11:43 AM, Evgeny Voevodin wrote: >>> >>> This set of patches moves global variables to tcg_ctx: >>> gen_opc_instr >>> gen_opparam_icount >>> gen_opc_pc

Re: [Qemu-devel] [PATCH] pixman: require 0.18.4 or newer

2012-12-08 Thread Blue Swirl
Thanks, applied. On Tue, Nov 27, 2012 at 12:19 PM, Gerd Hoffmann wrote: > When older versions are found the internal pixman version is prefered. > > Signed-off-by: Gerd Hoffmann > --- > configure |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/config

Re: [Qemu-devel] [PATCH v2] HACKING: List areas where we may rely on impdef C behaviour

2012-12-08 Thread Blue Swirl
Thanks, applied. On Wed, Oct 31, 2012 at 9:30 AM, Peter Maydell wrote: > Add a section to HACKING saying which version of the C spec > we use and describing the bits of implementation defined C > compiler behaviour which C code in QEMU is allowed to rely on. > > Signed-off-by: Peter Maydell > --

Re: [Qemu-devel] [PULL] Memory API ioport cleanups

2012-12-08 Thread Blue Swirl
Thanks, pulled. On Tue, Dec 4, 2012 at 4:48 PM, Andreas Färber wrote: > Hello, > > As coordinated with Avi and Gerd, here's some ioport conversions to Memory > API. > > Cc: Avi Kivity > Cc: Gerd Hoffmann > Cc: Julien Grall > Cc: Jason Baron > > > The following changes since commit 16c6c80ac3

Re: [Qemu-devel] [PATCH] finally kill cpudef config section support

2012-12-08 Thread Blue Swirl
Thanks, applied. On Tue, Dec 4, 2012 at 6:32 PM, Eduardo Habkost wrote: > The external CPU models were removed on QEMU 1.2, and the support for > the "cpudef" config sections was documented as deprecated, but the > actual removal of the config section was pending. > > Now that QEMU 1.3 was releas

Re: [Qemu-devel] [PATCH] finally kill cpudef config section support

2012-12-08 Thread Blue Swirl
On Sat, Dec 8, 2012 at 6:02 PM, Andreas Färber wrote: > Am 08.12.2012 18:54, schrieb Blue Swirl: >> Thanks, applied. > > As discussed this still leaves some cpudef cruft behind. But Eduardo said that it will be removed later. > Eduardo, can you please send a follow-up to m

Re: [Qemu-devel] [PATCH 0/8] xtensa patch queue

2012-12-08 Thread Blue Swirl
Thanks, applied all. On Wed, Dec 5, 2012 at 3:15 AM, Max Filippov wrote: > Hi. > > This is my current patch queue for xtensa: > - add support for a number of Special Registers: ATOMCTL, CACHEATTR, MISC; > - raise exceptions on access to unconfigured SRs/invalid access to configured > SRs; > - ad

Re: [Qemu-devel] [PATCH] linux-user: Merge pread/pwrite into pread64/pwrite64

2012-12-08 Thread Blue Swirl
Thanks, applied. Maybe we need more maintainers for linux-user. On Fri, Dec 7, 2012 at 2:57 PM, Peter Maydell wrote: > Ping^2, now we're out of freeze? Patchwork URL: > http://patchwork.ozlabs.org/patch/191133/ > > -- PMM > > > On 24 October 2012 13:27, Peter Maydell wrote: >> Ping? >> >> -- PM

Re: [Qemu-devel] [PATCH v2] configure: Default to 'cc', not 'gcc'

2012-12-08 Thread Blue Swirl
Thanks, applied. On Fri, Dec 7, 2012 at 3:39 PM, Peter Maydell wrote: > Default to 'cc' as our compiler, rather than 'gcc'. We used to have > to insist on gcc when we still kept the CPU env in a fixed global > register, but this is no longer necessary and we will now compile OK > on clang as well

Re: [Qemu-devel] [PATCH] finally kill cpudef config section support

2012-12-09 Thread Blue Swirl
On Sun, Dec 9, 2012 at 7:13 PM, Andreas Färber wrote: > Am 08.12.2012 21:00, schrieb Blue Swirl: >> On Sat, Dec 8, 2012 at 6:02 PM, Andreas Färber wrote: >>> Am 08.12.2012 18:54, schrieb Blue Swirl: >>>> Thanks, applied. >>> >>> As discussed this

Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 6:29 AM, Andreas Färber wrote: > Exercise all four commands of the TMP105, testing for an issue in the > I2C TX path. The test case is specific to the n800's OMAP I2C for now > and is the first test case for arm. > > Signed-off-by: Andreas Färber > --- > tests/Makefile

Re: [Qemu-devel] [PATCH 5/8] pci: make external dependencies explicit

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 1:14 PM, Michael S. Tsirkin wrote: > Include dependencies from pci core using <> and Nack, the usual convention is to use <> for system headers like and "" for local headers. For example with MSVC the search path for angle brackets does not even include the local directo

Re: [Qemu-devel] [PATCH 7/8] pci: rename pci_internals.h pci_bus.h

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 1:14 PM, Michael S. Tsirkin wrote: > There are lots of external users of pci_internals.h, > apparently making it an internal interface only didn't > work out. Let's stop pretending it's an internal header. > > Signed-off-by: Michael S. Tsirkin > --- > hw/apb_pci.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/19] openpic: rename openpic_t to OpenPICState

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 2:12 PM, Alexander Graf wrote: > Rename the openpic_t struct to OpenPICState, so it adheres better to > the current coding style rules. > > Signed-off-by: Alexander Graf > --- > hw/openpic.c | 68 > +- > 1 files c

Re: [Qemu-devel] [PATCH 0/8] pci core reorg

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 1:13 PM, Michael S. Tsirkin wrote: > This patchset starts some cleanups of the pci core > by rearranging the code: pci core is split out > from devices into its own directory, pci internals.h > is renamed as it's used externally a lot. > > I'd like to merge this quickly to

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-14 Thread Blue Swirl
et_maintainer.pl, > and license update for the q35 files > > I've addressed the comments Blue Swirl had > for the rename patches - would like to merge ASAP > to avoid any conflicts, and we can do code style > fixups later - note this is style of existing files. Usually

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-14 Thread Blue Swirl
On Thu, Dec 13, 2012 at 10:02 PM, Jason Baron wrote: > From: Jason Baron > > Currently, the qtest harness can only spawn 1 qemu instance at a time because > the parent pid is used to create the socket files. Use the child pid instead, > so we can remove that limitation. > > Signed-off-by: Jason B

Re: [Qemu-devel] [PATCH 25/40] openpic: convert to qdev

2012-12-14 Thread Blue Swirl
On Fri, Dec 14, 2012 at 12:13 PM, Alexander Graf wrote: > This patch converts the OpenPIC device to qdev. Along the way it > renames the "openpic" target to "raven" and the "mpic" target to > "fsl_mpic_20", to better reflect the actual models they implement. > > This way we have a generic OpenPIC

Re: [Qemu-devel] [PATCH v7 03/12] dataplane: add host memory mapping code

2012-12-14 Thread Blue Swirl
On Fri, Dec 14, 2012 at 6:00 PM, Stefan Hajnoczi wrote: > The data plane thread needs to map guest physical addresses to host > pointers. Normally this is done with cpu_physical_memory_map() but the > function assumes the global mutex is held. The data plane thread does > not touch the global mu

Re: [Qemu-devel] [PATCH 25/40] openpic: convert to qdev

2012-12-14 Thread Blue Swirl
On Fri, Dec 14, 2012 at 8:42 PM, Alexander Graf wrote: > > On 14.12.2012, at 21:32, Blue Swirl wrote: > >> On Fri, Dec 14, 2012 at 12:13 PM, Alexander Graf wrote: >>> This patch converts the OpenPIC device to qdev. Along the way it >>> renames the "op

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-14 Thread Blue Swirl
et_maintainer.pl, > and license update for the q35 files > > I've addressed the comments Blue Swirl had > for the rename patches - would like to merge ASAP > to avoid any conflicts, and we can do co

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/6] openpic: don't crash on a register access without a CPU context

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 9:58 PM, Alexander Graf wrote: > > On 14.12.2012, at 22:42, Scott Wood wrote: > >> On 12/14/2012 06:35:12 AM, Alexander Graf wrote: >>> On 14.12.2012, at 03:12, Scott Wood wrote: >>> > If we access a register via the QEMU memory inspection commands (e.g. >>> > "xp") rather

Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti wrote: > > The high byte of the ioport address is necessary to compute > the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)" > document, eg: > > 4.2.1.1. DCOM—DMA Command Register (IO) > I/O Address: Channels 0–3—08h; Channels 4–7—0D

Re: [Qemu-devel] [PATCH 0/5] pixman patch queue

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 7:54 AM, Gerd Hoffmann wrote: > Hi, > > Pixman patch queue, fixing vnc tight/png and tackeling build issues. Thanks, applied all. > > cheers, > Gerd > > Gerd Hoffmann (5): > pixman: fix version check for PIXMAN_TYPE_BGRA > Revert "pixman: require 0.18.4 or newer"

Re: [Qemu-devel] [PATCH] target-xtensa: fix ITLB/DTLB page protection flags

2012-12-15 Thread Blue Swirl
Thanks, applied. On Thu, Dec 13, 2012 at 12:13 AM, Max Filippov wrote: > With MMU option xtensa architecture has two TLBs: ITLB and DTLB. ITLB is > only used for code access, DTLB is only for data. However TLB entries in > both TLBs have attribute field controlling write and exec access. These >

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-15 Thread Blue Swirl
On Sat, Dec 15, 2012 at 9:14 AM, Paolo Bonzini wrote: >> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" >> > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp" >> > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid" >> >> These filenames are too predictable from security point of view, > > This need

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2012-12-14

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 12:13 PM, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for ppc. Please pull. Thanks, pulled. > > Alex > > > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > Anthony Liguori (1): > Merge remote-trac

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-19 Thread Blue Swirl
On Mon, Dec 17, 2012 at 5:13 PM, Jason Baron wrote: > On Sat, Dec 15, 2012 at 09:20:13AM +0000, Blue Swirl wrote: >> On Sat, Dec 15, 2012 at 9:14 AM, Paolo Bonzini wrote: >> >> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" >> >> >

Re: [Qemu-devel] [PATCH] target-xtensa: fix search_pc for the last TB opcode

2012-12-19 Thread Blue Swirl
On Tue, Dec 18, 2012 at 7:21 AM, Max Filippov wrote: > Zero out tcg_ctx.gen_opc_instr_start for instructions representing the > last guest opcode in the TB. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Filippov > --- > target-xtensa/translate.c |8 +++- > 1 files changed, 7 insert

Re: [Qemu-devel] [RFC PATCH v4 19/30] Implement "info memory-total" and "query-memory-total"

2012-12-19 Thread Blue Swirl
On Tue, Dec 18, 2012 at 12:41 PM, Vasilis Liaskovitis wrote: > Returns total physical memory available to guest in bytes, including > hotplugged > memory. Note that the number reported here may be different from what the > guest > sees e.g. if the guest has not logically onlined hotplugged memor

Re: [Qemu-devel] [RFC PATCH v4 25/30] acpi_ich9: add hot-remove capability

2012-12-19 Thread Blue Swirl
On Tue, Dec 18, 2012 at 12:41 PM, Vasilis Liaskovitis wrote: > --- > hw/acpi_ich9.c | 28 +++- > hw/acpi_ich9.h |1 + > 2 files changed, 28 insertions(+), 1 deletions(-) > > diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c > index abafbb5..f5dc1c9 100644 > --- a/hw/acpi_

Re: [Qemu-devel] [RFC PATCH V8 13/15] virtio : Remove the function pointer.

2012-12-19 Thread Blue Swirl
On Wed, Dec 19, 2012 at 9:53 AM, wrote: > From: KONRAD Frederic > > This remove the function pointer in VirtIODevice, and use only > VirtioDeviceClass function pointer. It should be applied after all > the device have been refactored. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-blk.c

Re: [Qemu-devel] [RFC PATCH V8 04/15] virtio-pci : Refactor virtio-pci device.

2012-12-19 Thread Blue Swirl
On Wed, Dec 19, 2012 at 9:53 AM, wrote: > From: KONRAD Frederic > > Create the virtio-pci device. This transport device will create a > virtio-pci-bus, so one VirtIODevice can be connected. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c | 130 >

Re: [Qemu-devel] [RFC PATCH V8 14/15] virtio : Remove VirtIOBindings.

2012-12-19 Thread Blue Swirl
On Wed, Dec 19, 2012 at 9:53 AM, wrote: > From: KONRAD Frederic > > This remove VirtIOBindings and use VirtioBusClass instead. It should be > applied > when all the device have been refactored. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-bus.c | 20 > hw/virtio-b

Re: [Qemu-devel] [RFC PATCH V8 08/15] virtio-blk : Add the virtio-blk device.

2012-12-19 Thread Blue Swirl
On Wed, Dec 19, 2012 at 9:53 AM, wrote: > From: KONRAD Frederic > > Create virtio-blk which extends virtio-device, so it can be connected on > virtio-bus. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-blk.c | 101 > +++- > hw/virtio-b

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-19 Thread Blue Swirl
On Wed, Dec 19, 2012 at 8:35 AM, Paolo Bonzini wrote: > Il 19/12/2012 03:13, Alexander Graf ha scritto: >> Does making libfdt a submodule really change things? Developers would >> still have to init the submodule. They could just as well install the >> libfdt-devel packet from their distro of choi

Re: [Qemu-devel] [PATCH 3/9] chardev: reduce chardev ifdef mess a bit

2012-12-19 Thread Blue Swirl
On Wed, Dec 19, 2012 at 3:59 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > qemu-char.c | 22 +++--- > 1 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 9bb3a6b..208c525 100644 > --- a/qemu-char.c > +++ b/qemu

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: > From: Jason Baron > > Currently, the qtest harness can only spawn 1 qemu instance at a time because > the parent pid is used to create the socket files. Use 'mkdtemp()' in But mkdtemp() is not available on Win32. > combination with the paren

Re: [Qemu-devel] [PATCH v2 3/3] qtest: add migrate-test

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: > From: Jason Baron > > Tests a single 'pc' machine migration on the same host. > > Would be nice to extend the test matrix to various machine versions, but that > requires building multiple qemu binaries, which is a bit awkward in the > context

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 8:26 PM, Jason Baron wrote: > On Thu, Dec 20, 2012 at 08:07:02PM +0000, Blue Swirl wrote: >> On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: >> > From: Jason Baron >> > >> > Currently, the qtest harness can only spawn 1 qemu insta

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-19

2012-12-22 Thread Blue Swirl
On Wed, Dec 19, 2012 at 1:36 PM, Andreas Färber wrote: > Hello, > > This is my current QOM CPU patch queue. Please pull. It conflicts with HEAD, please rebase. > > It includes: > * CPU subclasses for target-alpha, > * CPUListState cleanup (basis for all subsequent subclasses series), > * more st

Re: [Qemu-devel] [PATCH v2] target-xtensa: fix search_pc for the last TB opcode

2012-12-22 Thread Blue Swirl
Thanks, applied. On Wed, Dec 19, 2012 at 8:04 PM, Max Filippov wrote: > Zero out tcg_ctx.gen_opc_instr_start for instructions representing the > last guest opcode in the TB. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Filippov > --- > Changes v1 -> v2: > - replace while loop with memset

Re: [Qemu-devel] [PATCH 0/2] Build fixes

2012-12-22 Thread Blue Swirl
Thanks, applied both. On Thu, Dec 20, 2012 at 11:29 AM, Paolo Bonzini wrote: > Two build fixes for configurations not covered by my and Anthony's testing. > > Paolo > > Paolo Bonzini (2): > build: fix includes for VNC > xen: add missing include > > Makefile.target | 5 - > configure

Re: [Qemu-devel] [PATCH] net: Add missing include statement (fix compiler warnings for MinGW)

2012-12-22 Thread Blue Swirl
Thanks, applied. On Thu, Dec 20, 2012 at 10:09 PM, Stefan Weil wrote: > These and some more compiler warnings were caused by a recent commit: > > net/tap-win32.c:724: warning: no previous prototype for ‘tap_has_ufo’ > net/tap-win32.c:729: warning: no previous prototype for ‘tap_has_vnet_hdr’ > ..

Re: [Qemu-devel] [PATCH] net: add missing include file

2012-12-22 Thread Blue Swirl
Thanks, applied. On Fri, Dec 21, 2012 at 8:56 AM, Liming Wang wrote: > To fix building error: > > CCnet/vde.o > net/vde.c: In function ‘vde_cleanup’: > net/vde.c:65:5: error: implicit declaration of function ‘qemu_set_fd_handler’ > [-Werror=implicit-function-declaration] > net/vde.c:65:5: er

Re: [Qemu-devel] [RFC] updated e1000 mitigation patch

2012-12-28 Thread Blue Swirl
On Thu, Dec 27, 2012 at 10:06 AM, Luigi Rizzo wrote: > Before submitting a proper patch, I'd like to hear feedback on the > following proposed change to hw/e1000.c to properly implement > interrupt mitigation. > This is joint work with Vincenzo Maffione and Giuseppe Lettieri (in Cc), > and is a fo

Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

2012-12-28 Thread Blue Swirl
On Fri, Dec 28, 2012 at 10:32 AM, Jason Wang wrote: > This patch implements both userspace and vhost support for multiple queue > virtio-net (VIRTIO_NET_F_MQ). This is done by introducing an array of > VirtIONetQueue to VirtIONet. > > Signed-off-by: Jason Wang > --- > hw/virtio-net.c | 318 > +

Re: [Qemu-devel] [PATCH 05/12] net: multiqueue support

2012-12-28 Thread Blue Swirl
On Fri, Dec 28, 2012 at 10:31 AM, Jason Wang wrote: > This patch adds basic multiqueue support for qemu. The idea is simple, an > array > of NetClientStates were introduced in NICState, parse_netdev() were extended > to > find and match all NetClientStates belongs to the backend and place their

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-19

2012-12-28 Thread Blue Swirl
Thanks, pulled. On Sun, Dec 23, 2012 at 12:00 AM, Andreas Färber wrote: > Am 22.12.2012 13:08, schrieb Blue Swirl: >> On Wed, Dec 19, 2012 at 1:36 PM, Andreas Färber wrote: >>> Hello, >>> >>> This is my current QOM CPU patch queue. Please pull. >>

Re: [Qemu-devel] [PATCH] usb/redirect.c: unbreak compilation due to include/char/char.h

2012-12-28 Thread Blue Swirl
Thanks, applied. On Sun, Dec 23, 2012 at 9:25 PM, Alon Levy wrote: > Broken since: > > commit 927d4878b0ff319ed87fed9363f314613b0a5ed9 > Author: Paolo Bonzini > Date: Mon Dec 17 18:20:05 2012 +0100 > > softmmu: move remaining include files to include/ subdirectories > > Signed-off-by: Alon

<    1   2   3   4   5   6   7   8   9   10   >