On Wed, Dec 5, 2012 at 7:41 PM, Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > > On 12/05/2012 08:28 PM, Blue Swirl wrote: >> >> On Tue, Dec 4, 2012 at 10:00 PM, Anthony Liguori <aligu...@us.ibm.com> >> wrote: >>> >>> Peter Maydell <peter.mayd...@linaro.org> writes: >>> >>>> On 4 December 2012 18:38, Blue Swirl <blauwir...@gmail.com> wrote: >>>>> >>>>> The definition of the hard freeze bothers me. A few patches that went >>>>> in after 1.3-rc0 were not bug fixes but just new features, so the >>>>> difference between soft and hard freezes was not clear. >>>> >>>> >>>> My vote for this would be to adhere to our definition >>>> and only commit bugfixes. >>> >>> >>> Let's get specific. What was committed post hard freeze that's not a >>> bug fix? >> >> >> d3067b0 Documentation: Update image format information >> a13e5e0 Documentation: Update block cache mode information >> 044d003 qemu-tech.texi: update implemented xtensa features list > > > Adding missing / updating docs to be more accurate is a bug fix, > and one with a very low chance of causing regressions at that.
I don't think they are bug fixes but improvements to documentation features. But I agree patches only touching documentation, comment and string contents could be exempted. > > >> a0a7068 target-i386: Enable SSSE3 TCG support >> 80ae416 target-i386/cpu: Add missing flags to Haswell CPU model >> 42015c9 virtio-rng: fix typos, comments >> e1e54f3 target-i386: cpu: add missing flags to Haswell CPU model >> 339c270 qom: make object_finalize static >> 64b625f qdev: simplify (de)allocation of buses >> fde9bf4 qom: make object_delete usable for statically-allocated objects >> 667d22d qdev: move bus removal to object_unparent >> 74c856e tests: add thread pool unit tests >> b2ea25d tests: add AioContext unit tests >> 21022c9 q35: Add kvmclock support >> a1c9304 ich9: Add i82801b11 dmi-to-pci bridge >> df2d8b3 q35: Introduce q35 pc based chipset emulator >> 678e7b9 ich9: Add smbus >> 4d00636 ich9: Add the lpc chip >> e516572 ich9: Add acpi support and definitions >> 410edd9 pc/piix_pci: factor out smram/pam logic >> d8ee038 pc_piix: Move kvm irq routing functions out of pc_piix.c >> a39e356 pc: Move ioapic_init() from pc_piix.c to pc.c >> 9011a1a pc, pc_piix: split out pc nic initialization > > > >> 723aedd usb-redir: Don't handle interrupt output packets async > > Bug-fix This was not clear from the description, from that it looked to me that it's a general change with possibly good and bad effects. > > >> 234e810 usb-redir: Split usb_handle_interrupt_data into separate >> in/out functions > > Preparation patch for the above bugfix, no functional changes. > > >> 33c1a68 usb-bt: Return NAK instead of STALL when interrupt ep has no data > > Bug-fix Word 'fix' was not mentioned in the description. > > > Regards, > > Hans
