Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 8:28 AM, 陳韋任 (Wei-Ren Chen) wrote: >>   The reason why we want to do the measuring is we want to use KVM (sounds >> crazy >> idea) MMU virtualization to speedup the guest -> host memory address >> translation. >> I talked to some people on LinuxCon Japan, included Paolo,

Re: [Qemu-devel] [PATCH 2/2] fdc: Move floppy geometry guessing back from block.c

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:10 AM, Markus Armbruster wrote: > Commit 5bbdbb46 moved it to block.c because "other geometry guessing > functions already reside in block.c".  Device-specific functionality > should be kept in device code, not the block layer.  Move it back. As discussed earlier, this i

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:24 AM, Guan Xuetao wrote: > Coprocessor 0 is system control coprocessor, and we need get/set its contents. > Also, all cache/tlb ops shoule be implemented here, but just ignored with no > harm. > > Coprocessor 1 is OCD (on-chip-debugger), which is used for faked console,

Re: [Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:25 AM, Guan Xuetao wrote: > This patch adds puv3 dma (Direct Memory Access) support, > include dma device simulation for kernel booting. > > Signed-off-by: Guan Xuetao > --- >  hw/Makefile.objs |    1 + >  hw/puv3.c        |    1 + >  hw/puv3_dma.c    |  109 > +

Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:25 AM, Guan Xuetao wrote: > This patch only add puv3 soc/board support, which introduces puv3 > machine description, and specifies console type. > > Signed-off-by: Guan Xuetao > --- >  default-configs/unicore32-softmmu.mak |    1 + >  hw/puv3.c                          

Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:25 AM, Guan Xuetao wrote: > This patch adds puv3 pm (power management) support, > include pm device simulation for kernel booting. > > Signed-off-by: Guan Xuetao > --- >  hw/Makefile.objs |    1 + >  hw/puv3.c        |    1 + >  hw/puv3_pm.c     |  148 > +++

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 8:31 AM, Daniel P. Berrange wrote: > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: >> On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: >> > I think allowing execve() would render seccomp pretty much useless. >> >> Not nece

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 3:22 PM, Corey Bryant wrote: > > > On 06/18/2012 04:33 AM, Daniel P. Berrange wrote: >> >> On Fri, Jun 15, 2012 at 07:04:45PM +, Blue Swirl wrote: >>> >>> On Wed, Jun 13, 2012 at 8:33 PM, Daniel P. Berrange >>> wrote: &g

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Blue Swirl
ri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: >> > > > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: >> > > > > I think allowing execve() would render seccomp pretty much useless. >> > > > >> > > > Not necessar

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 5:53 AM, Stefan Weil wrote: > Am 19.06.2012 04:31, schrieb Scott Wood: > >> If tci_out_label is called in the context of tcg_gen_code_search_pc, we >> could be overwriting an already patched relocation with zero -- and not >> repatch it because the set_label is past search_

Re: [Qemu-devel] [PATCH 2/2] fdc: Move floppy geometry guessing back from block.c

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 7:45 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Mon, Jun 18, 2012 at 9:10 AM, Markus Armbruster wrote: >>> Commit 5bbdbb46 moved it to block.c because "other geometry guessing >>> functions already reside in block

Re: [Qemu-devel] [PATCH v5 12/16] target-or32: Add system instructions

2012-06-19 Thread Blue Swirl
nv); > >    default: >        break; >    } > #endif >    return rd; Is this correct, maybe 0 would be a nice value for unknown SPRs, or is rd the default value? If you later need to add tracepoints (or debug printfs) for the return value, it may be useful to structure the code

Re: [Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 12:54 PM, Alexander Graf wrote: > > On 07.06.2012, at 23:09, Blue Swirl wrote: > >> On Tue, Jun 5, 2012 at 11:52 PM, Alexander Graf wrote: >>> Today we have two separate places where we keep information which device >>> is where: >

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 9:23 AM, Daniel P. Berrange wrote: > On Mon, Jun 18, 2012 at 08:15:37PM +0000, Blue Swirl wrote: >> On Mon, Jun 18, 2012 at 8:31 AM, Daniel P. Berrange >> wrote: >> > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: >> >>

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-19 Thread Blue Swirl
On Tue, Jun 19, 2012 at 11:04 AM, Avi Kivity wrote: > On 06/16/2012 09:46 AM, Blue Swirl wrote: >> On Fri, Jun 15, 2012 at 9:36 PM, Paul Moore wrote: >>> On Friday, June 15, 2012 09:23:46 PM Blue Swirl wrote: >>>> On Fri, Jun 15, 2012 at 9:02 PM, Paul Moore wr

Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 1:56 AM, Guan Xuetao wrote: > On Mon, 2012-06-18 at 20:02 +0000, Blue Swirl wrote: > [snip] >> > diff --git a/hw/puv3.h b/hw/puv3.h >> > new file mode 100644 >> > index 000..bcfc978 >> > --- /dev/null >> > +++ b/hw/

Re: [Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 2:10 AM, Guan Xuetao wrote: > On Mon, 2012-06-18 at 19:59 +0000, Blue Swirl wrote: > [snip] >> > + >> > +#define PUV3_DMA_CH_NR          (6) >> > +#define PUV3_DMA_CH_MASK        (0xff) >> > +#define PUV3_DMA_CH(offset)     (

Re: [Qemu-devel] [PATCH v5 00/16] QEMU OpenRISC support

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 7:10 AM, Jia Liu wrote: > Hi Blue, > > On Tue, Jun 19, 2012 at 3:11 AM, Blue Swirl wrote: >> On Mon, Jun 18, 2012 at 1:02 AM, Jia Liu wrote: >>> This is the OpenCores OpenRISC 1200 support for QEMU. >>> Full implementation of the system-m

Re: [Qemu-devel] [PATCH v5 01/16] target-or32: Add target stubs and cpu support

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 7:14 AM, Jia Liu wrote: > Hi Blue, > > On Tue, Jun 19, 2012 at 2:28 AM, Blue Swirl wrote: >> On Mon, Jun 18, 2012 at 1:02 AM, Jia Liu wrote: >>> Add OpenRISC target stubs and basic cpu support. >>> >>> Signed

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 1:40 AM, Guan Xuetao wrote: > On Mon, 2012-06-18 at 19:51 +0000, Blue Swirl wrote: >> On Mon, Jun 18, 2012 at 9:24 AM, Guan Xuetao wrote: >> > Coprocessor 0 is system control coprocessor, and we need get/set its >> > contents. >> &g

Re: [Qemu-devel] [PATCH 2/2] fdc: Move floppy geometry guessing back from block.c

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 8:21 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Tue, Jun 19, 2012 at 7:45 AM, Markus Armbruster wrote: >>> Blue Swirl writes: >>> >>>> On Mon, Jun 18, 2012 at 9:10 AM, Markus Armbruster >>>> wr

Re: [Qemu-devel] [PATCH 7/8] PPC: Turn hardcoded reset mask into env variable

2012-06-21 Thread Blue Swirl
On Wed, Jun 20, 2012 at 8:11 PM, Alexander Graf wrote: > Some machines have MSR bits they reset with as enabled. Don't hardcode the > logic, but let the individual core implementations save their own reset > mask into an env variable. > > Signed-off-by: Alexander Graf > --- >  target-ppc/cpu.h  

[Qemu-devel] [PATCH v4 00/17] x86 AREG0 conversion

2012-06-21 Thread Blue Swirl
This series actually does not do much conversion. These should be safe, so I'd like to apply them soon. Further AREG0 conversions need more work. Blue Swirl (17): x86: prepare op_helper.c for splitting x86: avoid AREG0 for exceptions x86: split off exception handlers x86: avo

[Qemu-devel] [PATCH 03/17] x86: split off exception handlers

2012-06-21 Thread Blue Swirl
Move exception handlers from op_helper.c to excp_helper.c. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 + target-i386/cpu.h | 10 +++- target-i386/excp_helper.c | 132 + target-i386/op_helper.c | 113

[Qemu-devel] [PATCH 14/17] x86: split off SMM helpers

2012-06-21 Thread Blue Swirl
Move SMM helpers to smm_helper.c. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |2 + target-i386/op_helper.c | 285 - target-i386/smm_helper.c | 307 + 3 files changed, 309 insertions(+), 285

[Qemu-devel] [PATCH RFT 0/9] x86 AREG0 conversion, part deux

2012-06-21 Thread Blue Swirl
These still fail the test but I'll send them for review and to complement the first series. Blue Swirl (9): x86: avoid AREG0 for FPU helpers x86: avoid AREG0 for condition code helpers x86: avoid AREG0 for integer helpers x86: avoid AREG0 for SVM helpers x86: avoid AREG0 for SMM he

[Qemu-devel] [PATCH 2/9] x86: avoid AREG0 for condition code helpers

2012-06-21 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/cc_helper.c | 199 +-- target-i386/cc_helper_template.h| 36 +++--- target-i386/helper.h

[Qemu-devel] [PATCH 5/9] x86: avoid AREG0 for SMM helpers

2012-06-21 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h |2 +- target-i386/smm_helper.c | 14 -- target-i386/translate.c |2 +- 4 files changed, 6 insertions(+), 13

[Qemu-devel] [PATCH 4/9] x86: avoid AREG0 for SVM helpers

2012-06-21 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h | 22 +++--- target-i386/svm_helper.c | 181 ++--- target-i386/translate.c | 21

[Qemu-devel] [PATCH 15/17] x86: split off misc helpers

2012-06-21 Thread Blue Swirl
Move various functions to misc_helper.c. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |3 +- target-i386/misc_helper.c | 603 + target-i386/op_helper.c | 578 --- 3 files changed, 605

[Qemu-devel] [PATCH 12/17] x86: split off integer helpers

2012-06-21 Thread Blue Swirl
Move integer and bit field helpers to int_helper.c. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |3 +- target-i386/int_helper.c | 500 + target-i386/op_helper.c | 478 --- 3 files changed

[Qemu-devel] [PATCH 6/9] x86: avoid AREG0 for misc helpers

2012-06-21 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h | 40 target-i386/misc_helper.c | 73 ++--- target-i386/translate.c

[Qemu-devel] [PATCH 7/9] x86: use wrappers for memory access helpers

2012-06-21 Thread Blue Swirl
Switch to wrapped versions of memory access functions. Signed-off-by: Blue Swirl --- target-i386/cpu.h| 10 ++ target-i386/mem_helper.c | 10 ++ target-i386/seg_helper.c | 209 +++--- 3 files changed, 126 insertions(+), 103 deletions(-) diff

[Qemu-devel] [PATCH 8/9] x86: avoid AREG0 in segmentation helpers

2012-06-21 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Rename remains of op_helper.c to seg_helper.c. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h | 38 target-i386/seg_helper.c | 217

[Qemu-devel] [PATCH 07/17] x86: improve SSE table type safety

2012-06-21 Thread Blue Swirl
SSE function tables could easily be corrupted because of use of void pointers. Introduce function pointer types and helper variables in order to improve type safety. Split sse_op_table3 according to types used. Signed-off-by: Blue Swirl --- target-i386/translate.c | 134

[Qemu-devel] [PATCH 9/9] x86: switch to AREG0 free mode

2012-06-21 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Remove temporary wrappers and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure |2 +- cpu-all.h | 22 ++ target-i386/Makefile.objs |2 - target-i386/cpu.h

[Qemu-devel] [PATCH 09/17] x86: split condition code and shift templates

2012-06-21 Thread Blue Swirl
Move shift templates from helper_template.h to shift_helper_template.h and the condition code helpers to cc_helper_template.h. Signed-off-by: Blue Swirl --- target-i386/cc_helper_template.h| 277 +++ target-i386/helper_template.h | 353

[Qemu-devel] [PATCH 16/17] x86: split off memory access helpers

2012-06-21 Thread Blue Swirl
Move memory access helpers to mem_helper.c. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |3 +- target-i386/mem_helper.c | 161 + target-i386/op_helper.c | 138 +-- 3 files changed, 165

[Qemu-devel] [PATCH 10/17] x86: prepare eflags helpers for general use

2012-06-21 Thread Blue Swirl
Adjust function names and add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/op_helper.c | 68 +- 1 files changed, 37 insertions(+), 31 deletions(-) diff --git a/target-i386/op_helper.c b

[Qemu-devel] [PATCH 04/17] x86: avoid an extern declaration

2012-06-21 Thread Blue Swirl
After the previous patch, we can use the proper declaration in a common header file. Signed-off-by: Blue Swirl --- target-i386/excp_helper.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/target-i386/excp_helper.c b/target-i386/excp_helper.c index 72bd46d..aaa5ca2

[Qemu-devel] [PATCH 08/17] x86: fix coding style in helper_template.h

2012-06-21 Thread Blue Swirl
Fix coding style in helper_template.h before next commit. Signed-off-by: Blue Swirl --- target-i386/helper_template.h | 25 ++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/target-i386/helper_template.h b/target-i386/helper_template.h index afc41fb

[Qemu-devel] [PATCH 11/17] x86: split off condition code helpers

2012-06-21 Thread Blue Swirl
Move condition code helpers to cc_helper.c. Move the shared inline functions lshift(), cpu_load_eflags() and cpu_cc_compute_all() to cpu.h. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |3 +- target-i386/cc_helper.c | 387 +++ target

[Qemu-devel] [PATCH 3/9] x86: avoid AREG0 for integer helpers

2012-06-21 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl --- target-i386/Makefile.objs |1 - target-i386/helper.h| 50 +- target-i386/int_helper.c| 36 +- target-i386

Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions

2012-06-23 Thread Blue Swirl
On Fri, Jun 22, 2012 at 3:29 AM, Benjamin Herrenschmidt wrote: > The emulated devices can run simultaneously with the guest, so > we need to be careful with ordering of load and stores done by > them to the guest system memory, which need to be observed in > the right order by the guest operating

Re: [Qemu-devel] [PATCH 2/2] Creating qemu-seccomp.[ch] and adding call to vl.c

2012-06-23 Thread Blue Swirl
On Thu, Jun 21, 2012 at 10:10 PM, Eduardo Otubo wrote: > I added a syscall struct using priority levels as described in the > libseccomp man page. The priority numbers are based to the frequency > they appear in a sample strace from a regular qemu guest run under > libvirt. > > Libseccomp generate

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-23 Thread Blue Swirl
On Fri, Jun 22, 2012 at 9:58 AM, Xin Tong wrote: > It is a pity that QEMU does not outline the TLB lookup code. I do not > know how much impact the inlined TLB code has due to icache misses... With a test case the impact could be measured. Maybe it could be just a program performing loads in a lo

Re: [Qemu-devel] [PATCH v6 5/6] fdc_test: update media_change test

2012-06-23 Thread Blue Swirl
On Fri, Jun 22, 2012 at 10:33 AM, Pavel Hrdina wrote: > After rewrite DSKCHG bit handling the test has to be updated. Now > is needed to seek to different track to clear DSKCHG bit. > > Signed-off-by: Pavel Hrdina > --- >  tests/fdc-test.c |   29 + >  1 files changed,

Re: [Qemu-devel] [PATCH 2/2] cpu: for cpu-user and cpu-softmmu and make cpu-softmmu a child of DeviceState

2012-06-24 Thread Blue Swirl
On Sat, Jun 23, 2012 at 2:00 PM, Andreas Färber wrote: > Am 22.06.2012 21:36, schrieb Anthony Liguori: >> The line between linux-user and softmmu is not very well defined right now. >> linux-user really don't want to include devices and making CpuState a child >> of >> DeviceState would require p

Re: [Qemu-devel] [PULL 0/4] s390 patch queue 2012-06-18

2012-06-24 Thread Blue Swirl
On Mon, Jun 18, 2012 at 1:36 PM, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for s390. Please pull. Thanks, pulled. > > Alex > > > The following changes since commit eb2aeacf983a2a88a2b31e8fee067c38bd10abd3: >  malc (1): >        audio/winwave: Fix typo > > are

Re: [Qemu-devel] [PULL 00/16] arm-devs queue

2012-06-24 Thread Blue Swirl
On Tue, Jun 19, 2012 at 1:30 PM, Peter Maydell wrote: > Hi; this is an arm-devs pullreq which mostly has patches which I've > had queued since before freeze and my holiday. (I had to make a > trivial fix to one of the GIC patches to account for the list of > object files moving from Makefile.targe

Re: [Qemu-devel] [PULL 00/33] target-arm queue

2012-06-24 Thread Blue Swirl
On Wed, Jun 20, 2012 at 12:26 PM, Peter Maydell wrote: > This is a pullreq for outstanding target-arm patches. In fact it > only has my cp15 rework series in it. (No changes in that since the > v2 series I sent out some weeks back except for a tiny trivial fix > for a textual rebase conflict.) > >

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-24 Thread Blue Swirl
Thanks, applied. On Tue, Jun 19, 2012 at 2:31 AM, Scott Wood wrote: > If tci_out_label is called in the context of tcg_gen_code_search_pc, we > could be overwriting an already patched relocation with zero -- and not > repatch it because the set_label is past search_pc, causing a QEMU crash > when

Re: [Qemu-devel] [PULL 00/72] ppc patch queue 2012-06-24

2012-06-24 Thread Blue Swirl
   PPC: BookE: Support 32 and 64 bit wide MAS2 >      PPC: BookE206: Bump MAS2 to 64bit > > Benjamin Herrenschmidt (4): >      ppc64: Rudimentary Support for extra page sizes on server CPUs >      pseries: Correctly create ibm,segment-page-sizes property >      spapr_vscsi: E

Re: [Qemu-devel] [PATCH] make: Fix dependencies for fpu/*.c and tcg/*.c

2012-06-24 Thread Blue Swirl
Thanks, applied. On Thu, Jun 21, 2012 at 8:18 PM, Stefan Weil wrote: > Commit dcff25f2cd8c11a9368cc2369aeb0319c32d9e26 removed too many *.d > files. The directories fpu/ and tcg/ still don't use the recursive > subdir rules. > > Signed-off-by: Stefan Weil > --- >  Makefile.target |    2 +- >  1

Re: [Qemu-devel] [PATCH] qemu-log: Add GCC format attribute

2012-06-24 Thread Blue Swirl
Thanks, applied. On Sat, Jun 23, 2012 at 6:41 PM, Stefan Weil wrote: > The new inline function qemu_log_vprintf should use this attribute. > > Signed-off-by: Stefan Weil > --- >  qemu-log.h |    3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qemu-log.h b/qemu-log.h > in

Re: [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 2:04 PM, Stefan Weil wrote: > The order of the arguments was wrong (copy+paste error). Confirmed, a bug with d0f1562d6ace0fdb7d2db190dd5a9a2e7492c3b3 > > Signed-off-by: Stefan Weil > --- > > Hi Alex, hi Blue, > > there is still one more bug for target-ppc with --enable-d

Re: [Qemu-devel] [PATCH 8/9] esp: use trace framework instead of stderr output

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 5:15 PM, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- >  hw/esp.c     |   13 ++--- >  trace-events |    3 +++ >  2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/hw/esp.c b/hw/esp.c > index 796cdc1..ec40d93 100644 > --- a/hw/es

[Qemu-devel] [PATCH] bsd-user: fix build

2012-06-24 Thread Blue Swirl
Link in oslib objects also for BSD user, but avoid using the version of qemu_vmalloc() defined in oslib-posix.c. Signed-off-by: Blue Swirl --- Makefile.target |2 +- oslib-posix.c |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target

Re: [Qemu-devel] [PATCH] bsd-user: fix build

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 8:34 PM, Peter Maydell wrote: > On 24 June 2012 21:18, Blue Swirl wrote: >> Link in oslib objects also for BSD user, but avoid using the version of >> qemu_vmalloc() defined in oslib-posix.c. > > Do you happen to know why bsd-user has its

Re: [Qemu-devel] [PULL 0/2] ppc patch queue 2012-06-24

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 8:53 PM, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is a quick fix patch queue for ppc when using. Thanks a lot to > Stefan for finding the issues! > > Please pull. Thanks, pulled. > > Alex > > > The following changes since commit 3c01ae0ea29915d165c384d0bd1cbaf

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Blue Swirl
On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell wrote: > Add field32() and field64() functions which extract a particular > bit field from a word and return it. Based on an idea by Jia Liu. > > Suggested-by: Jia Liu > Signed-off-by: Peter Maydell > --- > Jia Liu had a function like this in the Op

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line

2012-06-26 Thread Blue Swirl
On Mon, Jun 25, 2012 at 10:43 PM, Anthony Liguori wrote: > This will create a new QOM object in the '/objects' path.  Note that > properties > are set in order which allows for simple objects to be initialized entirely > with this option and then realized. > > This option is roughly equivalent to

Re: [Qemu-devel] Is *-bsd-user target broken?

2012-06-26 Thread Blue Swirl
On Tue, Jun 26, 2012 at 3:49 PM, Igor Mammedov wrote: > Hello Blue, > > I've tried to test if *-bsd-user target works but so far wasn't successful > so far. > I've tried qemu-1.x ports on the latest freebsd/openbsd and a freshly > checked out qemu. > > If it works for you, could you tell: >  1. wh

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Blue Swirl
On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell wrote: > On 26 June 2012 18:58, Blue Swirl wrote: >> On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell >> wrote: >>> +static inline uint64_t field64(uint64_t value, int start, int length) >> >> start and length

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-26 Thread Blue Swirl
On Tue, Jun 26, 2012 at 6:41 PM, Peter Maydell wrote: > On 26 June 2012 19:25, Blue Swirl wrote: >> On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell >> wrote: >>> On 26 June 2012 18:58, Blue Swirl wrote: >>>> On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydel

Re: [Qemu-devel] [PATCH 2/4] file_ram_alloc: change length argument to size_t

2012-06-27 Thread Blue Swirl
On Tue, Jun 26, 2012 at 8:51 PM, Eduardo Habkost wrote: > While we are at it, rename it to "length", as "memory" doesn't mean > anything. > > Signed-off-by: Eduardo Habkost > --- >  exec.c |   12 ++-- >  1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/exec.c b/exec.c > in

Re: [Qemu-devel] [PATCH RFC 4/4] add -keep-mem-path-files option

2012-06-27 Thread Blue Swirl
On Tue, Jun 26, 2012 at 8:51 PM, Eduardo Habkost wrote: > This make QEMU create files inside the -mem-path directory using > more predictable names, and not remove them afterwards. > > This allow (for example) users or management layers to use numactl > later, to set NUMA policy for the guest RAM.

Re: [Qemu-devel] [PATCH 3/4] file_ram_alloc(): extract temporary-file creation code to separate function

2012-06-27 Thread Blue Swirl
On Tue, Jun 26, 2012 at 8:51 PM, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- >  exec.c |   35 +-- >  1 file changed, 25 insertions(+), 10 deletions(-) > > diff --git a/exec.c b/exec.c > index 5f3b265..dcbe4e1 100644 > --- a/exec.c > +++ b/exec.c >

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 6:01 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Tue, Jun 26, 2012 at 6:41 PM, Peter Maydell >> wrote: >>> On 26 June 2012 19:25, Blue Swirl wrote: >>>> On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell >>>

Re: [Qemu-devel] [PATCH v13 12/13] Add set_cachesize command

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 10:34 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Sign

Re: [Qemu-devel] [PATCH v7 15/16] target-or32: Add linux user support

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 9:54 AM, Jia Liu wrote: > Add QEMU OpenRISC linux user support. > > Signed-off-by: Jia Liu > --- >  configure                           |    1 + >  default-configs/or32-linux-user.mak |    1 + >  linux-user/elfload.c                |   41 +++ >  linux-user/main.c      

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-27 Thread Blue Swirl
On Wed, Jun 27, 2012 at 10:34 AM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- >  Makefile.objs        |    1

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-28 Thread Blue Swirl
On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori wrote: > On 06/21/2012 03:04 AM, Avi Kivity wrote: >> >> On 06/19/2012 09:58 PM, Blue Swirl wrote: >>>>> >>>>> At least qemu-ifup/down scripts, migration exec and smbd have been >>>>> men

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-28 Thread Blue Swirl
On Thu, Jun 28, 2012 at 5:58 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Wed, Jun 27, 2012 at 6:01 AM, Markus Armbruster wrote: >>> Blue Swirl writes: >>> >>>> On Tue, Jun 26, 2012 at 6:41 PM, Peter Maydell >>>> wrote: >

Re: [Qemu-devel] [PATCH 08/12] savevm: split save_live into stage2 and stage3

2012-06-28 Thread Blue Swirl
On Thu, Jun 28, 2012 at 7:22 PM, Juan Quintela wrote: > We split it into 2 functions, foo_live_iterate, and foo_live_complete. > At this point, we only remove the bits that are for the other stage, > functionally this is equivalent to previous code. > > Signed-off-by: Juan Quintela > --- >  arch_

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 3:27 PM, Corey Bryant wrote: > > > On 06/28/2012 03:49 PM, Blue Swirl wrote: >> >> On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori >> wrote: >>> >>> On 06/21/2012 03:04 AM, Avi Kivity wrote: >>&g

Re: [Qemu-devel] [PATCH 2/2] exynos4210: UART: Added using of CMU-callback functionality

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 4:04 PM, Maksim Kozlov wrote: > Add using of functionality provided by CMU - get_rate and > register_clock_handler. > > Signed-off-by: Maksim Kozlov > --- >  hw/exynos4210_uart.c |   36 +++- >  1 files changed, 35 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH 06/32] qtest: Add hard disk geometry test

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: > So far covers only IDE and tests only CMOS contents. > > Signed-off-by: Markus Armbruster > --- >  tests/Makefile      |    2 + >  tests/hd-geo-test.c |  402 > +++ >  2 files changed, 404

Re: [Qemu-devel] [PATCH 12/13] dirty bitmap: abstract its use

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 4:44 PM, Juan Quintela wrote: > Always use accessors to read/set the dirty bitmap. > > Signed-off-by: Juan Quintela > --- >  exec-obsolete.h |   40 >  exec.c          |    3 +-- >  2 files changed, 21 insertions(+), 22 deletions(-)

Re: [Qemu-devel] [PATCH 04/13] Add debugging infrastructure

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 4:43 PM, Juan Quintela wrote: > From: Orit Wasserman > > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- >  arch_init.c |   33 +++-- >  1 file changed, 27 insertions(+), 6 deletions(-) > > diff --git a/arch_init.c b/arch_ini

Re: [Qemu-devel] [PATCH 09/13] Only TCG needs TLB handling

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 4:44 PM, Juan Quintela wrote: > Refactor the code that is only needed for tcg to an static function. > Call that only when tcg is enabled.  We can't refactor to a dummy > function in the kvm case, as qemu can be compiled at the same time > with tcg and kvm. > > Signed-off-b

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: > Commit f3d54fc4 factored it out of hw/ide.c for reuse.  Sensible, > except it was put into block.c.  Device-specific functionality should > be kept in device code, not the block layer.  Move it to > hw/hd-geometry.c, and make stylistic ch

Re: [Qemu-devel] [PATCH 07/13] Add tracepoints for savevm section start/end

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 4:43 PM, Juan Quintela wrote: > This allows to know how long each section takes to save. > > An awk script like this tells us sections that takes more that 10ms > > $1 ~ /savevm_state_iterate_end/ { >        /* Print savevm_section_end line when > 10ms duration */ >        

Re: [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: > Unless parameter ":floppy:" is given, vvfat creates a virtual image > with DOS MBR defining a single partition which holds the FAT file > system.  The size of the virtual image depends on the width of the > FAT: 32 MiB (CHS 64, 16, 63) fo

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: > Best to use the same type, to avoid unwanted truncation or sign > extension. Awesome patch! :-) > > BlockConf can't use plain int for cyls, heads and secs, because > integer properties require an exact width. > > Signed-off-by: Markus A

Re: [Qemu-devel] [PATCH] target-i386: fix build with -Werror

2012-06-29 Thread Blue Swirl
On Fri, Jun 29, 2012 at 7:35 PM, Stefan Weil wrote: > Am 29.06.2012 08:41, schrieb Dunrong Huang: >> >> Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type >> safety but raises compile error of incompatible pointer type. Fix it by >> casting to correct function type Signed-off-

Re: [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-07-03 Thread Blue Swirl
On Sat, Jun 30, 2012 at 5:50 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote: >>> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, >>> except it was put into block.c. Device-specif

Re: [Qemu-devel] [PATCH] target-i386: Fix compilation with --enable-debug

2012-07-03 Thread Blue Swirl
On Sat, Jun 30, 2012 at 1:46 PM, Stefan Weil wrote: > Am 30.06.2012 14:16, schrieb Dunrong Huang: > >> 2012/6/30 Stefan Weil : >>> >>> commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type >>> safety which now raises compiler errors when latest QEMU was configured with >>> --enab

Re: [Qemu-devel] [PATCH] w32: Fix broken build (missing include file)

2012-07-03 Thread Blue Swirl
On Sun, Jul 1, 2012 at 2:26 PM, Paolo Bonzini wrote: > Il 16/06/2012 20:48, Artyom Tarasenko ha scritto: >> But still, it's not possible for all contributions, right? >> >> To sum this up: >> GPL v2+ are allowed >> non-GPL contributions are allowed > > Yes, as long as they are GPLv2- and v3-compat

Re: [Qemu-devel] [PATCH] vga: Implement blinking of text cursor

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 8:20 AM, Jan Kiszka wrote: > Let the text cursor blink at 5 Hz. No timer is used, instead we rely on > the fact that the display is updated periodically. > > Signed-off-by: Jan Kiszka > --- > hw/vga.c | 14 +- > hw/vga_int.h |2 ++ > 2 files changed,

Re: [Qemu-devel] [PATCH 07/17] x86: improve SSE table type safety

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 8:53 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> SSE function tables could easily be corrupted because of use >> of void pointers. >> >> Introduce function pointer types and helper variables in order >> to improve type safety.

Re: [Qemu-devel] plan for device assignment upstream

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity wrote: > On 07/02/2012 12:30 PM, Jan Kiszka wrote: >> On 2012-07-02 11:18, Michael S. Tsirkin wrote: >>> I've been thinking hard about Jan's patches for device >>> assignment. Basically while I thought it makes sense >>> to make all devices: assignment an

Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 9:41 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/scsi-disk.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index 747e756..e87e57c 100644 > --- a/hw/scsi-disk.c > +++ b/hw/s

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote: > On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote: >> Andreas Färber writes: >> >>> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi: On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote: > Best to use the same type

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:05 PM, Corey Bryant wrote: > > > On 06/28/2012 03:49 PM, Blue Swirl wrote: >> >> On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori >> wrote: >>> >>> On 06/21/2012 03:04 AM, Avi Kivity wrote: >>&g

Re: [Qemu-devel] [PATCH 1/6] file_ram_alloc(): coding style fixes

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:06 PM, Eduardo Habkost wrote: > Cc: Blue Swirl > Signed-off-by: Eduardo Habkost Acked-by: Blue Swirl > --- > exec.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/exec.c b/exec.c > index 8244d54..c8bfd

Re: [Qemu-devel] [PATCH 2/6] file_ram_alloc(): use g_strdup_printf() instead of asprintf()

2012-07-03 Thread Blue Swirl
On Mon, Jul 2, 2012 at 6:06 PM, Eduardo Habkost wrote: > Cc: Blue Swirl > Signed-off-by: Eduardo Habkost Acked-by: Blue Swirl > --- > exec.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/exec.c b/exec.c > index c8bfd27

Re: [Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

2012-07-03 Thread Blue Swirl
On Tue, Jul 3, 2012 at 10:07 AM, Kevin Wolf wrote: > Am 09.06.2012 14:12, schrieb Blue Swirl: >> Move logging functions from exec.c to qemu-log.c, >> compile it only once. >> >> Signed-off-by: Blue Swirl > > This broke the TARGET_I386 specific logging option

Re: [Qemu-devel] [PATCH v14 04/13] Add cache handling functions

2012-07-03 Thread Blue Swirl
On Tue, Jul 3, 2012 at 1:52 PM, Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > Makefile.objs |

Re: [Qemu-devel] [PATCH v14 07/13] Add debugging infrastructure

2012-07-03 Thread Blue Swirl
On Tue, Jul 3, 2012 at 1:52 PM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > arch_init.c | 33 +++-- > 1 files changed, 27 insertions(+), 6 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 9dafb6e..ee20c33 100644 > --- a/arch_init.c >

<    1   2   3   4   5   6   7   8   9   10   >