[Qemu-devel] [RFC V2 02/10] quorum: Create BDRVQuorumState and BlkDriver and do init.

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 046b183..e0405b6 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,10 @@ #include "block_int.h" +typedef struct { +Bl

[Qemu-devel] [RFC V2 09/10] quorum: Add quorum_aio_readv.

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 2df3ae6..13804c1 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -174,6 +174,14 @@ static int quorum_check_ret(Quorum

[Qemu-devel] [RFC V2 07/10] blkverify: Make blkverify_iovec_clone() and blkverify_iovec_compare() public

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c |8 ++-- block/quorum.c|4 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index 9d5f1ec..9e15081 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -11,6 +11,10 @@

[Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength().

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 9da0432..5cd7083 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -118,12 +118,29 @@ static void quorum_close(BlockDriverState *bs)

[Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close().

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 12 1 file changed, 12 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index de58ab8..9da0432 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -107,6 +107,17 @@ clean_exit: return ret; } +static void quorum_clo

[Qemu-devel] [RFC V2 01/10] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2012-08-07 Thread Benoît Canet
) Nodalink, SARL. 2012 + * + * Author: + * Benoît Canet + * + * Based on the design and code of blkverify.c (Copyright (C) 2010 IBM, Corp) + * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc). + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file

[Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 62 1 file changed, 62 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index e0405b6..de58ab8 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -47,11 +47,73 @@ struct QuorumA

[Qemu-devel] [RFC V2 06/10] quorum: Add quorum_aio_writev and its dependencies.

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 110 1 file changed, 110 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 5cd7083..e6d2274 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -133,6 +133,114 @@ static int6

[Qemu-devel] [RFC V2 08/10] quorum: Add quorum_co_flush().

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 16 1 file changed, 16 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 003fc3f..2df3ae6 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -245,6 +245,21 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriv

[Qemu-devel] [RFC V2 10/10] quorum: Add quorum mechanism.

2012-08-07 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 84 1 file changed, 78 insertions(+), 6 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index 13804c1..5914141 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -174,7 +174,7 @

[Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency

2012-08-07 Thread Benoît Canet
: move function prototype of quorum.c one patch down open question: Would the ability to do quorum on 2n+1 images like Blue Swirl suggested be popular ? Benoît Canet (10): quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. quorum: Create BDRVQuorumState and BlkDriver and do

Re: [Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength().

2012-08-09 Thread Benoît Canet
> > +static int64_t quorum_getlength(BlockDriverState *bs) > > +{ > > +BDRVQuorumState *s = bs->opaque; > > +int i; > > +int64_t ret; > > + > > +/* return the length of the first available quorum file */ > > +for (i = 0, ret = bdrv_getlength(s->bs[i]); > > + ret == -ENOM

Re: [Qemu-devel] [RFC V2 06/10] quorum: Add quorum_aio_writev and its dependencies.

2012-08-09 Thread Benoît Canet
Le Wednesday 08 Aug 2012 à 16:37:13 (+0100), Stefan Hajnoczi a écrit : > On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote: > > +static int quorum_check_ret(QuorumAIOCB *acb) > > +{ > > +int i, j; > > + > > +for (i = 0, j = 0; i <= 2; i++)

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-10 Thread Benoît Canet
Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit : > On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c | 62 > > > &g

Re: [Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency

2012-08-10 Thread Benoît Canet
Le Wednesday 08 Aug 2012 à 15:55:58 (+0100), Stefan Hajnoczi a écrit : > On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote: > > This patchset create a block driver implementing a quorum using three qemu > > disk > > images. Writes are mirrored on the three files. > &g

[Qemu-devel] [RFC V3 9/9] quorum: Add quorum mechanism.

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 211 +++- 1 file changed, 210 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 8b449fb..24c8298 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -14,6 +14,20 @@

[Qemu-devel] [RFC V3 7/9] quorum: Add quorum_co_flush().

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 16 1 file changed, 16 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 0a6647f..86962b4 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -279,6 +279,21 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriv

[Qemu-devel] [RFC V3 8/9] quorum: Add quorum_aio_readv.

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 86962b4..8b449fb 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -190,10 +190,16 @@ static void quorum

[Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-14 Thread Benoît Canet
one() and blkverify_iovec_compare() to cutils.c free unconditionally qemu_blockalign() with qemu_vfree() turn assignement into assert in quorum_copy_qiov() Benoît Canet (9): quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. quorum: Cre

[Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength().

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c |9 + 1 file changed, 9 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index f228428..a3f16ed 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -162,12 +162,21 @@ static void quorum_close(BlockDriverState *bs) g_free(s

[Qemu-devel] [RFC V3 1/9] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2012-08-14 Thread Benoît Canet
) 2012 Nodalink, SARL. + * + * Author: + * Benoît Canet + * + * Based on the design and code of blkverify.c (Copyright (C) 2010 IBM, Corp) + * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc). + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING

[Qemu-devel] [RFC V3 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init.

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 65a6b55..bab6175 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block_int.h" +typedef struct { +

[Qemu-devel] [RFC V3 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 113 1 file changed, 113 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index bab6175..f228428 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -52,11 +52,124 @@ struct Quoru

[Qemu-devel] [RFC V3 6/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c | 108 + cutils.c | 103 ++ qemu-common.h |2 + 3 files changed, 107 insertions(+), 106 deletions(-) diff --git a/block/blkveri

[Qemu-devel] [RFC V3 5/9] quorum: Add quorum_aio_writev and its dependencies.

2012-08-14 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 112 1 file changed, 112 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a3f16ed..0a6647f 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -169,6 +169,116 @@ static int6

[Qemu-devel] [RFC] snapshot_tree.py a tool to help build graph of QEMU snapshots

2012-08-14 Thread Benoît Canet
? Benoît Canet (1): contribs: Add snapshot_tree.py a tool to build snapshot graphs. contribs/snapshot_tree.py | 406 + 1 file changed, 406 insertions(+) create mode 100755 contribs/snapshot_tree.py -- 1.7.9.5

[Qemu-devel] [RFC] contribs: Add snapshot_tree.py a tool to build snapshot graphs.

2012-08-14 Thread Benoît Canet
(1) or d3.js JSON output of the snapshots +# in it. +# +# Copyright (C) 2010 Nodalink, SARL. +# +# Author: +# Benoît Canet +# +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the "Software"), to deal

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-14 Thread Benoît Canet
Le Monday 13 Aug 2012 à 09:41:00 (+0200), Kevin Wolf a écrit : > Am 10.08.2012 19:48, schrieb Benoît Canet: > > Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit : > >> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet > >> wrote: > >>> Signed-off-b

Re: [Qemu-devel] [PATCH] let qemu-img info genereate json output

2012-08-15 Thread Benoît Canet
Le Friday 27 Jul 2012 à 08:50:43 (-0500), Anthony Liguori a écrit : > Wenchao Xia writes: > > > This patch would add option -j in qemu-img info command, which > > would generate json output in stdout. > > This is a great idea. > > > > > Signed-off-by: Wenchao Xia > > --- > > qemu-img.c | 3

[Qemu-devel] [PATCH 0/3] Add JSON output to qemu-img info

2012-08-15 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. To use it simply add --machine=json to the command line. Benoît Canet (3): qapi: Add SnapshotInfo.

[Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo.

2012-08-15 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 24 1 file changed, 24 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..8d4df19 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,30 @@ 'running', 'save-vm',

[Qemu-devel] [PATCH 3/3] qemu-img: Add json output option to the info command.

2012-08-15 Thread Benoît Canet
This additionnal --machine=json option make qemu-img info output on stdout a JSON formated representation of the image informations. --machine=json was choosen instead of --format=json because the info command already have a -f parameter. example: { "snapshots": [ { "name"

[Qemu-devel] [PATCH 2/3] qapi: Add ImageInfo.

2012-08-15 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 33 + 1 file changed, 33 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 8d4df19..488da90 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -150,6 +150,39 @@ 'vm-clock-sec

Re: [Qemu-devel] [PATCH 3/3] qemu-img: Add json output option to the info command.

2012-08-15 Thread Benoît Canet
Le Wednesday 15 Aug 2012 à 10:23:32 (-0600), Eric Blake a écrit : > On 08/15/2012 08:54 AM, Benoît Canet wrote: > > This additionnal --machine=json option make qemu-img info output on > > stdout a JSON formated representation of the image informations. > > > > --machi

Re: [Qemu-devel] [PATCH 2/3] qapi: Add ImageInfo.

2012-08-15 Thread Benoît Canet
> > +# > > +# Since: 1.3 > > So no way it will make 1.2 hard freeze today :) I would like to.Just tell me if it would be possible :) > > -- > Eric Blake ebl...@redhat.com+1-919-301-3266 > Libvirt virtualization library http://libvirt.org >

Re: [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo.

2012-08-15 Thread Benoît Canet
Le Wednesday 15 Aug 2012 à 12:04:56 (-0600), Eric Blake a écrit : > On 08/15/2012 08:54 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > qapi-schema.json | 24 > > 1 file changed, 24 insertions(+) > > > &g

Re: [Qemu-devel] [PATCH 1/3] qapi: Add SnapshotInfo.

2012-08-15 Thread Benoît Canet
Le Wednesday 15 Aug 2012 à 14:58:45 (-0300), Luiz Capitulino a écrit : > On Wed, 15 Aug 2012 16:54:24 +0200 > "Benoît Canet" wrote: > > > Signed-off-by: Benoit Canet > > --- > > qapi-schema.json | 24 > > 1 file changed,

[Qemu-devel] [PATCH V2 0/2] Add JSON output to qemu-img info

2012-08-15 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. To use it simply add --machine=json to the command line. Benoît Canet (3): qapi: Add SnapshotInfo.

[Qemu-devel] [PATCH V2 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-15 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 60 ++ 1 file changed, 60 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..fbf61e7 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,66 @@

[Qemu-devel] [PATCH V2 2/2] qemu-img: Add json output option to the info command.

2012-08-15 Thread Benoît Canet
This additionnal --machine=json option make qemu-img info output on stdout a JSON formated representation of the image informations. --machine=json was choosen instead of --format=json because the info command already have a -f parameter. example: { "backing-filename-format": "raw", "snap

[Qemu-devel] [PATCH V3 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-15 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 60 ++ 1 file changed, 60 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..fbf61e7 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,66 @@

[Qemu-devel] [PATCH V3 0/2] Add JSON output to qemu-img info

2012-08-15 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. To use it simply add --machine=json to the command line. Benoît Canet (3): qapi: Add SnapshotInfo.

[Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-15 Thread Benoît Canet
This additionnal --machine=json option make qemu-img info output on stdout a JSON formated representation of the image informations. --machine=json was choosen instead of --format=json because the info command already have a -f parameter. example: { "backing-filename-format": "raw", "snap

Re: [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength().

2012-08-16 Thread Benoît Canet
Le Tuesday 14 Aug 2012 à 10:08:24 (-0600), Eric Blake a écrit : > On 08/14/2012 08:14 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c |9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/block/quor

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-16 Thread Benoît Canet
Le Thursday 16 Aug 2012 à 11:47:27 (+0100), Richard Davies a écrit : > Hi, > > We run a cloud hosting provider using qemu-kvm 1.1, and are keen to find a > contractor to track down and fix problems we have with large memory Windows > guests booting very slowly - they can take several hours. > > W

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
Le Tuesday 14 Aug 2012 à 16:14:02 (+0200), Benoît Canet a écrit : > This patchset create a block driver implementing a quorum using m qemu disk > images. Writes are mirrored on the m files. > For the reading part the m files are read at the same time and a vote is > done to determi

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
Le Monday 20 Aug 2012 à 12:24:33 (+0100), Stefan Hajnoczi a écrit : > On Mon, Aug 20, 2012 at 12:23 PM, Stefan Hajnoczi wrote: > > On Mon, Aug 20, 2012 at 11:12 AM, Benoît Canet > > wrote: > >> Le Tuesday 14 Aug 2012 à 16:14:02 (+0200), Benoît Canet a écrit : > >&

[Qemu-devel] [RFC V4 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
irl: replace n and m by threshold and total ignore flush errors in quorum_co_flush Stefan Hajnoczi: removal of a macro in "Add quorum mechanism" call qemu_iovec_destroy in the bh Benoît Canet: Now use QuorumVoteItem and QuorumVoteVersion as names for

[Qemu-devel] [RFC V4 8/9] quorum: Add quorum mechanism.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 211 +++- 1 file changed, 210 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 95f4668..a909ce2 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -14,6 +14,20 @@

[Qemu-devel] [RFC V4 7/9] quorum: Add quorum_aio_readv.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 092d1ea..95f4668 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -180,15 +180,24 @@ static void quo

[Qemu-devel] [RFC V4 4/9] quorum: Add quorum_aio_writev and its dependencies.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 112 1 file changed, 112 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 70e7216..5c87cec 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -159,6 +159,116 @@ static void

[Qemu-devel] [RFC V4 1/9] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2012-08-20 Thread Benoît Canet
) 2012 Nodalink, SARL. + * + * Author: + * Benoît Canet + * + * Based on the design and code of blkverify.c (Copyright (C) 2010 IBM, Corp) + * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc). + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING

[Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-20 Thread Benoît Canet
Valid quorum resources look like: quorum:threshold/total:path/to/image_1: ... :path/to/image_total '\' can escape the ':' character. Signed-off-by: Benoit Canet --- block/quorum.c | 110 1 file changed, 110 insertions(+) diff --git a/bl

[Qemu-devel] [RFC V4 9/9] quorum: Add quorum_getlength().

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a909ce2..7bd6f0e 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -525,12 +525,42 @@ static coroutine_fn int quorum_co_flus

[Qemu-devel] [RFC V4 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 65a6b55..19a9a44 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block_int.h" +typedef struct { +

[Qemu-devel] [RFC V4 5/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c | 108 + cutils.c | 103 ++ qemu-common.h |2 + 3 files changed, 107 insertions(+), 106 deletions(-) diff --git a/block/blkveri

[Qemu-devel] [RFC V4 6/9] quorum: Add quorum_co_flush().

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 13 + 1 file changed, 13 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 5c87cec..092d1ea 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -269,6 +269,18 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriverS

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
Le Monday 20 Aug 2012 à 13:56:53 (+0100), Stefan Hajnoczi a écrit : > On Mon, Aug 20, 2012 at 12:42 PM, Benoît Canet > wrote: > > > > Le Monday 20 Aug 2012 à 12:24:33 (+0100), Stefan Hajnoczi a écrit : > >> On Mon, Aug 20, 2012 at 12:23 PM, Stefan Hajnoczi > &

Re: [Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-21 Thread Benoît Canet
Le Monday 20 Aug 2012 à 14:37:08 (-0600), Eric Blake a écrit : > On 08/20/2012 01:47 PM, Blue Swirl wrote: > > On Mon, Aug 20, 2012 at 11:47 AM, Benoît Canet > > wrote: > >> Valid quorum resources look like: > >> quorum:threshold/total:path/to/image_1: ... :path

Re: [Qemu-devel] [PATCH V3 2/2] qemu-img: Add json output option to the info command.

2012-08-22 Thread Benoît Canet
Le Thursday 16 Aug 2012 à 11:13:05 (+0800), Wenchao Xia a écrit : >I was busy in coding libqblock so forgot to move forward on qemu json > info patches, thanks for your advance. > >one suggestion: >how about folder all human printf into function: > dump_human_image_info(image_info), an

[Qemu-devel] [PATCH V4 0/2] Add JSON output to qemu-img info

2012-08-22 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. the --output=(json|human) option is now mandatory on the command line. Benoît Canet (3): qapi

[Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 62 ++ 1 file changed, 62 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..4c4b9b9 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,68 @@

[Qemu-devel] [PATCH V4 2/2] qemu-img: Add json output option to the info command.

2012-08-22 Thread Benoît Canet
This option --output=[human|json] make qemu-img info output on human or JSON representation at the choice of the user. example: { "snapshots": [ { "vm-clock-nsec": 20637102488, "name": "vm-20120821145509", "date-sec": 1345553709, "date-ns

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Benoît Canet
Le Wednesday 22 Aug 2012 à 08:03:14 (-0600), Eric Blake a écrit : > On 08/22/2012 06:45 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > qapi-schema.json | 62 > > ++ > > 1 file change

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-22 Thread Benoît Canet
Le Wednesday 22 Aug 2012 à 08:56:06 (-0600), Eric Blake a écrit : > On 08/22/2012 08:32 AM, Benoît Canet wrote: > >> Since we have two fields named *-nsec, it might be worth clarifying that > >> date-nsec is merely the fractional portion to be combined with date-sec &

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-23 Thread Benoît Canet
> That seems backwards - with a raw file, don't you know the actual size, > but have no idea what it can further grow to? In raw it commes from fstat() with the field st.st_blocks. from man: blkcnt_t st_blocks; /* number of 512B blocks allocated */ Benoît

Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-23 Thread Benoît Canet
> > +## > > +# @ImageInfo: > > +# > > +# Information about a QEMU image file > > +# > > +# @filename: name of the image file > > +# > > +# @format: format of the image file > > +# > > +# @virtual-size: maximum capacity in bytes of the image > > +# > > +# @actual-size: #optional actual size on disk

[Qemu-devel] [PATCH 0/2] Add file url support to migration

2012-08-23 Thread Benoît Canet
virtualizer which share only the storage but do not see each other on the network. (cisco pvlan for example) Benoît Canet (2): migration: Allow the migrate command to work on file: urls migration: Allow -incoming to work on file: urls migration-fd.c |9 - migration.c| 34

[Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-23 Thread Benoît Canet
Usage: (qemu) migrate file:/path/to/vm_statefile Signed-off-by: Benoit Canet --- migration-fd.c |4 ++-- migration.c| 20 +++- migration.h|2 +- 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/migration-fd.c b/migration-fd.c index 50138ed..d39e44

[Qemu-devel] [PATCH 2/2] migration: Allow -incoming to work on file: urls

2012-08-23 Thread Benoît Canet
Usage: -incoming file:/path/to/vm_statefile Signed-off-by: Benoit Canet --- migration-fd.c |5 ++--- migration.c| 14 +- migration.h|2 +- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/migration-fd.c b/migration-fd.c index d39e44a..bf500a0 100644 -

[Qemu-devel] [PATCH V5 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-23 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 64 ++ 1 file changed, 64 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..ffe3a0a 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,70 @@

[Qemu-devel] [PATCH V5 0/2] Add JSON output to qemu-img info

2012-08-23 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. the --output=(json|human) option is now mandatory on the command line. Benoît Canet (3): qapi

[Qemu-devel] [PATCH V5 2/2] qemu-img: Add json output option to the info command.

2012-08-23 Thread Benoît Canet
This option --output=[human|json] make qemu-img info output on human or JSON representation at the choice of the user. example: { "snapshots": [ { "vm-clock-nsec": 637102488, "name": "vm-20120821145509", "date-sec": 1345553709, "date-nsec

Re: [Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-23 Thread Benoît Canet
Le Thursday 23 Aug 2012 à 13:34:01 (+0100), Daniel P. Berrange a écrit : > On Thu, Aug 23, 2012 at 02:28:07PM +0200, Benoît Canet wrote: > > Usage: > > (qemu) migrate file:/path/to/vm_statefile > > > > Signed-off-by: Benoit Canet > > --- > > migration-fd.c

Re: [Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-23 Thread Benoît Canet
Le Thursday 23 Aug 2012 à 14:48:19 (+0200), Benoît Canet a écrit : > Le Thursday 23 Aug 2012 à 13:34:01 (+0100), Daniel P. Berrange a écrit : > > On Thu, Aug 23, 2012 at 02:28:07PM +0200, Benoît Canet wrote: > > > Usage: > > > (qemu) migrate file:/path/to/vm_statefile

[Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info

2012-08-27 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. the --output=(json|human) option is now mandatory on the command line. Benoît Canet (3): qapi

[Qemu-devel] [PATCH V6 2/2] qemu-img: Add json output option to the info command.

2012-08-27 Thread Benoît Canet
This option --output=[human|json] make qemu-img info output on human or JSON representation at the choice of the user. example: { "snapshots": [ { "vm-clock-nsec": 637102488, "name": "vm-20120821145509", "date-sec": 1345553709, "date-nsec

[Qemu-devel] [PATCH V6 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 64 ++ 1 file changed, 64 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..ffe3a0a 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,70 @@

[Qemu-devel] [RFC V5 08/11] quorum: Add quorum mechanism.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 222 +++- 1 file changed, 221 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 791ef4a..3fa9d53 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -14,6 +14,20 @@

Re: [Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-27 Thread Benoît Canet
Adding Luiz to the thread since he is concerned by migration. Luiz do you have any hints on doing this properly ? Benoît > Le Thursday 23 Aug 2012 à 13:34:01 (+0100), Daniel P. Berrange a écrit : > On Thu, Aug 23, 2012 at 02:28:07PM +0200, Benoît Canet wrote: > > Usage: > > (

[Qemu-devel] [RFC V5 10/11] quorum: Add quorum_invalidate_cache().

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 09eed84..c9dcd9c 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -571,6 +571,16 @@ static int64_t quorum_getlength(BlockDriverState *bs)

[Qemu-devel] [RFC V5 04/11] quorum: Add quorum_aio_writev and its dependencies.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 112 1 file changed, 112 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index b9fb2b9..cd11cfb 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -172,6 +172,116 @@ static void

[Qemu-devel] [RFC V5 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 65a6b55..19a9a44 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block_int.h" +typedef struct { +

[Qemu-devel] [RFC V5 09/11] quorum: Add quorum_getlength().

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 24 1 file changed, 24 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 3fa9d53..09eed84 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -549,12 +549,36 @@ static coroutine_fn int quorum_co_flush(Bloc

[Qemu-devel] [RFC V5 11/11] quorum: Add quorum_co_is_allocated.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 32 1 file changed, 32 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index c9dcd9c..5a9f598 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -581,6 +581,37 @@ static void quorum_invalidate_cache(B

[Qemu-devel] [RFC V5 07/11] quorum: Add quorum_aio_readv.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index f83b4cf..791ef4a 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -193,15 +193,24 @@ static void quo

[Qemu-devel] [RFC V5 06/11] quorum: Add quorum_co_flush().

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 13 + 1 file changed, 13 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index cd11cfb..f83b4cf 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -282,6 +282,18 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriverS

[Qemu-devel] [RFC V5 00/11] Quorum disk image corruption resiliency

2012-08-27 Thread Benoît Canet
irl: replace n and m by threshold and total ignore flush errors in quorum_co_flush Stefan Hajnoczi: removal of a macro in "Add quorum mechanism" call qemu_iovec_destroy in the bh Benoît Canet: Now use QuorumVoteItem and QuorumVoteVersion as names for

[Qemu-devel] [RFC V5 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c | 108 + cutils.c | 103 ++ qemu-common.h |2 + 3 files changed, 107 insertions(+), 106 deletions(-) diff --git a/block/blkveri

[Qemu-devel] [RFC V5 03/11] quorum: Add quorum_open() and quorum_close().

2012-08-27 Thread Benoît Canet
Valid quorum resources look like quorum:threshold/total:path/to/image_1, ... ,path/to/image_total ',' is used as a separator to allow to use networked path '\' is the escaping character for filename containing ',' '\' escape itself On the command line for quorum files "img,test.raw", "img2.raw" a

[Qemu-devel] [RFC V5 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2012-08-27 Thread Benoît Canet
) 2012 Nodalink, SARL. + * + * Author: + * Benoît Canet + * + * Based on the design and code of blkverify.c (Copyright (C) 2010 IBM, Corp) + * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc). + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING

Re: [Qemu-devel] [RFC V5 03/11] quorum: Add quorum_open() and quorum_close().

2012-08-27 Thread Benoît Canet
Le Monday 27 Aug 2012 à 11:59:34 (-0600), Eric Blake a écrit : > On 08/27/2012 01:30 AM, Benoît Canet wrote: > > Valid quorum resources look like > > quorum:threshold/total:path/to/image_1, ... ,path/to/image_total > > > > ',' is used as a separator to allow

Re: [Qemu-devel] [RFC V5 09/11] quorum: Add quorum_getlength().

2012-08-27 Thread Benoît Canet
Le Monday 27 Aug 2012 à 12:03:48 (-0600), Eric Blake a écrit : > On 08/27/2012 01:30 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c | 24 > > 1 file changed, 24 insertions(+) > > Say I'

Re: [Qemu-devel] QEMU Mascot Contest

2012-02-15 Thread Benoît Canet
Made that one. http://files.nodalink.com/qemu/qemu.svg Best regards Benoît

Re: [Qemu-devel] QEMU Mascot Contest

2012-02-15 Thread Benoît Canet
This logo does even contains an emu. It's a quick draft it could be refined. http://files.nodalink.com/qemu/black_and_orange_qemu.svg Best regards Benoît On Thu, Nov 10, 2011 at 11:10 PM, Anthony Liguori wrote: > Hi > > We're long over due for a mascot for QEMU. Our wiki is nice, but is > mi

[Qemu-devel] [RFC V2 03/20] qcow2: Add deduplication structures and fields.

2012-10-17 Thread Benoît Canet
--- block/qcow2.h | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index b4eb654..e38667c 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -26,6 +26,7 @@ #define BLOCK_QCOW2_H #include "aes.h" +#include "rbtree.h" #

[Qemu-devel] [RFC V2 05/20] qcow2: Rename update_refcount into qcow2_update_refcount.

2012-10-17 Thread Benoît Canet
Also make it public so qcow2-dedup.c can use it. --- block/qcow2-refcount.c | 38 +++--- block/qcow2.h |4 +++- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 5e3f915..692f3fb 100

[Qemu-devel] [RFC V2 04/20] qcow2: Add qcow2_dedup_read_missing_and_concatenate

2012-10-17 Thread Benoît Canet
. 2012 + * + * Author: + * Benoît Canet + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rig

[Qemu-devel] [RFC V2 15/20] block: Add dedup image create option.

2012-10-17 Thread Benoît Canet
--- block_int.h |1 + 1 file changed, 1 insertion(+) diff --git a/block_int.h b/block_int.h index f4bae04..6419513 100644 --- a/block_int.h +++ b/block_int.h @@ -55,6 +55,7 @@ #define BLOCK_OPT_SUBFMT"subformat" #define BLOCK_OPT_COMPAT_LEVEL "compat" #define BLOCK_OPT_LAZ

[Qemu-devel] [RFC V2 01/20] qcow2: Add deduplication to the qcow2 specification.

2012-10-17 Thread Benoît Canet
--- docs/specs/qcow2.txt | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 36a559d..013a16b 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt @@ -80,7 +80,10 @@ in the description of a field.

  1   2   3   4   5   6   7   8   9   10   >