On 01/24/12 20:58, Markus Armbruster wrote:
Stefan Hajnoczi writes:
On Tue, Jan 24, 2012 at 6:22 PM, Benjamin wrote:
Hello Stefan,
Hi,
Please send QEMU development emails to the mailing list so others can
help or we can avoid duplicating work in case someone else is already
looking into
On 11/29/11 20:52, Stefan Hajnoczi wrote:
On Tue, Nov 29, 2011 at 7:55 PM, Benjamin wrote:
Signed-off-by: Benjamin
---
net.c |6 -
net/socket.c| 73 +-
qemu-options.hx |2 +
3 files changed, 78 insertions
Signed-off-by: Benjamin MARSILI
---
Added my last name. Check that localaddr= is supplied with udp=,
it crashed when misused...
net.c |6 +++-
net/socket.c| 77 +-
qemu-options.hx |2 +
3 files changed, 82 insertions
igate.
When an IP address is assigned to an interface it sends a who-has ARP
request with its own address. Which is not what happens on my OS. What
would be the correct and standard behavior?
Signed-off-by: Benjamin MARSILI
---
net.c | 11 -
net/socket.c|
On 11/06/11 14:54, Jan Kiszka wrote:
On 2011-11-06 21:55, Benjamin wrote:
Follow-up of:
http://www.mail-archive.com/qemu-devel@nongnu.org/msg81235.html
This enables connections between Qemu, Dynamips and VirtualBox guests.
Test it with:
qemu-system-i386 -netdev
socket,id=gns3,udp=127.0.0.1
On 11/07/11 12:23, Jan Kiszka wrote:
On 2011-11-07 15:01, Benjamin wrote:
Here is the updated patch, using only localaddr. mcast expects it to be
addr whereas udp expects addr:port. It's documented in the help output.
I also corrected the error message when checking udp parameters.
On 11/08/11 11:52, Jan Kiszka wrote:
On 2011-11-07 23:03, Benjamin wrote:
On 11/07/11 12:23, Jan Kiszka wrote:
On 2011-11-07 15:01, Benjamin wrote:
Here is the updated patch, using only localaddr. mcast expects it to be
addr whereas udp expects addr:port. It's documented in the help o
On 11/09/11 15:26, Benjamin wrote:
Oh, I forgot to remove a line from the old patch, when I wanted to
introduce -netdev udp. Now it's just -net[dev] socket.
Here's the updated patch, my apologies.
It didn't break anything, it's just useless, use this instead.
I sent the o
t any error though.
Signed-off-by: Benjamin MARSILI
diff --git a/Makefile.objs b/Makefile.objs
index 8d23fbb..6b4896b 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -45,6 +45,7 @@ net-obj-y = net.o
net-nested-y = queue.o checksum.o util.o
net-nested-y += socket.o
net-nested-y += dump.o
ice Bellard
>
> And here you might use your own copyright.
> Or did Fabrice start writing this code in 2003?
Yes, Fabrice wrote the code as a GNS3 developer back then.
Regards,
Benjamin
Signed-off-by: Benjamin MARSILI
---
net.c |6 -
net/socket.c| 71
+-
qemu-options.hx |2 +
3 files changed, 76 insertions(+), 3 deletions(-)
diff --git a/net.c b/net.c
index cb52050..8e957b2 100644
--- a/net.c
From: Benjamin MARSILI
Signed-off-by: Benjamin MARSILI
---
net.c |6 -
net/socket.c| 71 +-
qemu-options.hx |2 +
3 files changed, 76 insertions(+), 3 deletions(-)
diff --git a/net.c b/net.c
index cb52050..8e957b2
On 11/28/11 20:39, Stefan Hajnoczi wrote:
On Fri, Nov 25, 2011 at 12:49 PM, Benjamin wrote:
+fd = qemu_socket(PF_INET, SOCK_DGRAM, 0);
+if (fd< 0) {
+perror("socket(PF_INET, SOCK_DGRAM)");
+return -1;
+}
+val = 1;
+ret = setsockopt(f
On 11/29/11 18:47, Stefan Hajnoczi wrote:
On Tue, Nov 29, 2011 at 5:29 PM, Benjamin wrote:
On 11/28/11 20:39, Stefan Hajnoczi wrote:
On Fri, Nov 25, 2011 at 12:49 PM, Benjaminwrote:
+fd = qemu_socket(PF_INET, SOCK_DGRAM, 0);
+if (fd<0) {
+perror("socket
Signed-off-by: Benjamin
---
net.c |6 -
net/socket.c| 73 +-
qemu-options.hx |2 +
3 files changed, 78 insertions(+), 3 deletions(-)
diff --git a/net.c b/net.c
index cb52050..8e957b2 100644
--- a/net.c
+++ b/net.c
Qemu version 4.2.0 includes new functionality for something called TCG
Plugins. There are a few examples in the tests/plugins directory, and the
API is more or less defined in qemu-plugin.h.
This file defines two enumerated types, "qemu_plugin_cb_flags" and
"qemu_plugin_mem_rw", which are passed i
Thanks for your quick response.
On Mon, Mar 30, 2020 at 9:15 AM Alex Bennée wrote:
>
> Lukas Straub writes:
>
> >> My question is, how do I access the guest memory and registers from the
> >> plugin callback function? The API seems to indicate that it is possible,
> >> since the callback regist
On Mon, Mar 30, 2020 at 1:37 PM Alex Bennée wrote:
>
> Benjamin writes:
>
> > Thanks for your quick response.
> >
> > On Mon, Mar 30, 2020 at 9:15 AM Alex Bennée
> wrote:
> >
> >>
> >> Lukas Straub writes:
> >>
> >> >
On Mon, 2012-08-06 at 14:03 +0200, Gerd Hoffmann wrote:
> Hacked up something like that a while back (patch attached). Doesn't
> use DRM though, just plain old fbdev. Maybe you can reuse some bits
> nevertheless.
>
> /me wonders what the advantage of using drm is for non-3D hardware?
Thanks. Ye
On Mon, 2012-08-06 at 16:02 +0200, Gerd Hoffmann wrote:
>
> A vbe rom isn't a big deal. You probably want support the 0x01CE and
> 0x01CF ports (on x86) so the vgabios running in real mode can easily
> reach the bochs interface registers without a protected mode round
> trip
> for mmio access.
>
On Mon, 2012-08-06 at 15:20 +0200, Gerd Hoffmann wrote:
> There are discussions about re-doing the guest/host interface (command
> rings etc) now and then, by adding a qxl2 device (or maybe even extend
> stdvga), dropping a bunch of backward compatibility stuff in qxl.c.
>
> Sending the spice comm
On Tue, 2012-08-07 at 07:30 +0200, Gerd Hoffmann wrote:
> On 08/06/12 23:16, Benjamin Herrenschmidt wrote:
> > On Mon, 2012-08-06 at 15:20 +0200, Gerd Hoffmann wrote:
> >> There are discussions about re-doing the guest/host interface (command
> >> rings etc) now and th
On Tue, 2012-08-07 at 11:05 +0200, Alexander Graf wrote:
> > This patch therefore changes to ret = 0, which is both a bugfix and a small
> > optimization.
> >
> > Signed-off-by: David Gibson
>
> Thanks, applied to ppc-next.
When do you plan to send your queue to Anthony ? Some of that stuff
sh
On Tue, 2012-08-07 at 16:41 +1000, David Gibson wrote:
> qemu_system_reset() function always performs the same basic actions on
> all machines. This includes running all the reset handler hooks,
> however the order in which these will run is not always easily predictable.
>
> This patch splits th
On Fri, 2012-08-03 at 17:01 +0200, Andreas Färber wrote:
>
> I have posted a suggestion where CPU reset is triggered by "the
> machine
> as an abstract concept" (needs a bit of tweaking still, but the
> general
> idea is there).
> Based on that, shouldn't it be rather easy to add a Notifier simila
Only just saw this bug, I assume the problem still exist ? I have
somebody look at it next week
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1013691
Title:
ppc64 + virtio-scsi: only first scsi dis
Hi hard a brain fart when coding that function, it will
fail to "set" the memory beyond the first 512 bytes. This
is in turn causing guest crashes in ibmveth (spapr_llan.c
on the qemu side) due to the receive queue not being
properly initialized.
Signed-off-by: Benjamin Her
On Tue, 2012-08-14 at 13:04 +0200, Alexander Graf wrote:
> Thanks, applied to ppc-next without the USB bits. I also get the
> following warning now:
>
> $ ./ppc64-softmmu/qemu-system-ppc64 -nographic -M pseries -kernel
> /boot/vmlinux -initrd /boot/initrd -enable-kvm -m 1G -append
> root=/dev/nu
On Wed, 2012-08-15 at 09:10 +1000, David Gibson wrote:
> > I see. I will redo this patch. Send out it later. :)
> > Thanks for your comments.
>
> When you do that, please also change the default to make spapr _not_
> have usb.
FYI, I originally asked for USB as default ... however it looks like a
On Thu, 2012-08-16 at 09:29 +0800, Li Zhang wrote:
> > Yes, that's pretty much what I was asking for (here and for the
> mac99 u3 machine). Just base your patch on ppc-next. My patches are in
> there.
> That's great. Thanks a lot!
Note that you missed the hard freeze for qemu 1.2, it was today.
S
On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote:
> Again, device grouping is done by the IOMMU drivers, so this all
> belongs
> into the generic iommu-code rather than the driver core.
Except that there isn't really a "generic iommu code"... discovery,
initialization & matching of iommu vs.
On Wed, 2012-02-08 at 16:27 +0100, Joerg Roedel wrote:
> Again, device grouping is done by the IOMMU drivers, so this all
> belongs
> into the generic iommu-code rather than the driver core.
>
> I think it makes sense to introduce a device->iommu pointer which
> depends on CONFIG_IOMMU_API and put
On Thu, 2012-10-11 at 15:26 +0200, Avi Kivity wrote:
> These patches add IOMMU support to the memory core. IOMMUs can be added
> anywhere in
> the memory hierarchy, and may be arranged in series.
I haven't had a chance to review in details yet, but one thing I noticed
is that you basically have a
On Thu, 2012-10-11 at 15:42 +0200, Paolo Bonzini wrote:
> Il 11/10/2012 15:26, Avi Kivity ha scritto:
> > +struct MemoryRegionIOMMUOps {
> > +/* Returns a TLB entry that contains a given address. */
> > +IOMMUTLBEntry (*translate)(MemoryRegion *iommu, target_phys_addr_t
> > addr,
> > +
On Thu, 2012-10-11 at 15:57 +0200, Avi Kivity wrote:
> >> Map/unmap is supported via address_space_map(), which calls
> >> ->translate(). I don't see how a lower-level map/unmap helps,
> unless
> >> the hardware supplies such a function.
> >
> > Yep, it's just the map/unmap callbacks that are not
On Sat, 2012-10-13 at 09:30 +, Blue Swirl wrote:
> > The problem with map and unmap is invalidations. How do you convey to
> > the devices having done a map that the guest has invalidated a
> > translation entry.
>
> Also in Sparc32, IOMMU uses a table in RAM which the guest can change,
> so
On Mon, 2012-10-15 at 12:45 +0200, Avi Kivity wrote:
> > I haven't had a chance to review in details yet, but one thing I
> noticed
> > is that you basically have a single read/write protection
> information
> > for a translation.
> >
> > This is a loss of functionality to some extent (well, maybe
On Tue, 2012-10-16 at 14:55 -0500, Anthony Liguori wrote:
>
> 4) If -boot is specified, the parameter should alter the contents of
>NVRAM to change the boot order to what is specified by -boot.
>
> 5) If ,bootorder is specified, it should take predence over -boot.
>
> 6) ,bootorder= should a
On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote:
> > > That's horrible; if you use -boot just once it will clobber a
> > > persistent NVRAM's boot order. I see that a means of changing the
> > > default boot order from management tools is desirable, but that
> > > shouldn't be the normal be
On Fri, 2012-10-19 at 09:21 -0500, Anthony Liguori wrote:
> > That's true to an extent. However, I vehemently disagree that it's
> > arbitrary which one gets the new option. Neither -boot nor bootindex=
> > alter any persistent data now and they should not suddenly start doing
> > so.
>
> That'
On Tue, 2012-10-30 at 19:11 +, Blue Swirl wrote:
> Why couple this with host endianness? I'd expect IOMMU to operate at
> target bus endianness, for example LE for PCI on PPC guest.
I'm not sure about putting the iommu "in charge" of endianness ...
On one hand it's fishy. It should be 'trans
swork which should do the right thing for
existing HV and PR implementations. The fallback might not be correct
for future versions, but that's ok, because they'll have
KVM_PPC_GET_SMMU_INFO.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: David Gibson
---
This is long overdue and
This patch generates this property using the supported page size
information that's already in the CPUState.
Signed-off-by: Nishanth Aravamudan
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
hw/spapr.c | 43 +++
1 files cha
We were incorrectly g_free'ing an object that isn't allocated
in one error path and failed to release it completely in another
This fixes qemu crashes with some cases of IO errors.
Signed-off-by: Benjamin Herrenschmidt
---
hw/spapr_vscsi.c |4 +++-
1 file changed, 3 insert
which internally calls H_RTAS.
We might in the future implement part (or even all) of RTAS inside the
guest like IBM's firmware does and replace H_RTAS with some finer grained
set of private hypercalls.
Signed-off-by: Benjamin Herrenschmidt
---
This should address all your comments, please
This is a rebase of the iommu series and the barrier patch together
on top of current qemu.
As for our discussions about doing things with Memory Regions etc
I eventually came to the conclusion that we should just apply this
first :-)
My reasons (other than it makes my life much easier which it d
DMAContext from pci_dma_context(), in
the SysBus case, it uses NULL - i.e. assumes for now that there will
be no IOMMU translation for a SysBus OHCI.
Cc: Gerd Hoffmann
Cc: Michael S. Tsirkin
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
hw/usb/hcd-ohci.c | 93
: Alexey Kardashevskiy
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
hw/spapr.h |1 +
hw/spapr_iommu.c | 40 ++--
hw/spapr_pci.c | 15 +++
hw/spapr_pci.h |1 +
4 files changed, 39 insertions(+), 18 deletions
this callback.
Cc: Michael S. Tsirkin
Cc: Richard Henderson
Signed-off-by: Eduard - Gabriel Munteanu
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma-helpers.c | 155 +
dma.h | 118
from pci_dma_context() in the PCI case and
set to NULL in the SysBus case (i.e. we assume for now that a SysBus
AHCI has no IOMMU translation).
Cc: Kevin Wolf
Cc: Michael S. Tsirkin
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
hw/ide/ahci.c |
: Benjamin Herrenschmidt
---
cpu-common.h |1 +
exec.c | 15 +++
2 files changed, 16 insertions(+)
diff --git a/cpu-common.h b/cpu-common.h
index 1fe3280..8d3596a 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -53,6 +53,7 @@ void qemu_ram_set_idstr(ram_addr_t addr, const char
ze of dma_addr_t.
* We add a new helper macro to create device properties which take a
dma_addr_t, currently an alias to DEFINE_PROP_TADDR().
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma.h |1 +
hw/qdev-dma.h | 12
2 files change
Signed-off-by: Benjamin Herrenschmidt
---
hw/usb.h |2 +-
hw/usb/hcd-ehci.c |4 ++--
hw/usb/hcd-uhci.c |2 +-
hw/usb/libhw.c| 21 +++--
4 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/hw/usb.h b/hw/usb.h
index 2a56fe5..a5623d3 100644
Munteanu
Signed-off-by: Benjamin Herrenschmidt
---
hw/pci.c |9 +
hw/pci.h |9 +++--
hw/pci_internals.h |2 ++
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index bdfb3d6..c8d16a4 100644
--- a/hw/pci.c
+++ b/hw
ts this code to make use of the new common IOMMU
infrastructure.
We don't yet handle synchronization of map/unmap callbacks vs. invalidations,
this will require some complex interaction with the kernel and is not a
major concern at this stage.
Cc: Alex Graf
Signed-off-by: David Gibson
Sig
: Benjamin Herrenschmidt
---
dma.h | 54 --
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/dma.h b/dma.h
index f1fcb71..0d57e50 100644
--- a/dma.h
+++ b/dma.h
@@ -13,6 +13,7 @@
#include
#include "hw/hw.h"
#include "blo
mu backend implementation
may choose to keep track of maps and call the respective cancel
callback whenever a translation within a map is removed, allowing
the driver to do things like cancel async IOs etc.
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
pass something else in some cases to allow proper IOMMU
translation in future, but that will be fixed in later patches.
Cc: Kevin Wolf
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma-helpers.c | 24
Henderson
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma.h | 100 +
hw/pci.h | 21 ++--
qemu-common.h |1 +
3 files changed, 113 insertions(+), 9 deletions(-)
diff --git a/dma.h b/d
On Tue, 2012-06-19 at 10:16 +, Richard W.M. Jones wrote:
> I switched to using virtio-scsi (instead of virtio-blk). This appears to
> have solved
> this problem, although it brings another problem. I also tried vscsi, which
> fixes
> both problems.
>
> Therefore I will (not definitively) c
On Tue, 2012-06-19 at 13:31 +0200, Andreas Färber wrote:
> Tab alert. :)
Argh :-) Gotta get an emacs config for use with qemu :-)
Cheers,
Ben.
On Tue, 2012-06-19 at 15:42 +0200, Gerd Hoffmann wrote:
> Well, that isn't guaranteed ...
>
> > - otherwise the guest
> > might invalidate IOMMU mappings while they are still in use by the device
> > code.
>
> Guest tearing down mapping while usb packets using them are still in
> flight would be
On Tue, 2012-06-19 at 16:59 +0200, Juan Quintela wrote:
> >> - The hash table (mentioned above). This is just a big chunk of
> memory
> >> (it will routinely be 16M), so I really don't want to start
> iterating
> >> all elements, just a bulk load will do, and the size might actually
> be
> >> varia
On Tue, 2012-06-19 at 22:20 +0200, Alexander Graf wrote:
> So do you want to resend? I can just fix it on the fly too.
If you can then sure, please do :-)
Cheers,
Ben.
On Tue, 2012-06-19 at 23:00 +0200, Alexander Graf wrote:
> How is the problem different from RAM? It's a 16MB region that can be
> accessed by the guest even during transfer time, so it can get dirty
> during the migration. But we only need to really transfer the last
> small delta at the end of th
On Tue, 2012-06-19 at 23:48 +0200, Alexander Graf wrote:
> > We could keep track manually maybe using some kind of dirty bitmap of
> > changes to the hash table but that would add overhead to things like
> > H_ENTER.
>
> Only during migration, right?
True. It will be an "interesting" user/kernel
On Wed, 2012-06-20 at 00:27 +0200, Alexander Graf wrote:
>
> > I need to understand better how do that vs. qemu save/restore
> though. IE. That means
> > we can't just save the hash as a bulk and reload it, but we'd have
> to save bits of
> > it at a time or something like that no ? Or do we save
On Wed, 2012-06-20 at 00:55 +0200, Juan Quintela wrote:
>
> This was going to be my question.
>
> If we can do something like: send hash register, and get a bitmap of
> the
> ones that get changed, we should be good. Perhaps we need something
> "interesting" like removing old entries (no clue if
On Wed, 2012-06-20 at 01:11 +0200, Juan Quintela wrote:
>
> > I am confident I can come up with something as far as the kernel and
> > qemu <-> kernel interface goes. I need to get my head around the details
> > on how to implement that two stage save process in qemu though and the
> > correspondi
On Wed, 2012-06-20 at 01:30 +0200, Alexander Graf wrote:
> > We support the paravirtualized -M pseries in full emu as well, in which
> > case the hashed page table is handled by qemu itself who implements the
> > H_ENTER & co hypercalls. So it's very similar, except that qemu doesn't
> > have to as
On Wed, 2012-06-20 at 13:14 +1000, David Gibson wrote:
> So, in fact the original comment is a bit out of date. With the
> current version of this series, then a guest attempt to invalidate
> will be delayed until the unmap occurs.
No, this code was dropped, including the tracking of the maps, f
On Wed, 2012-06-20 at 08:25 +0200, Gerd Hoffmann wrote:
> Hi,
>
> >> Like with any other device, it's hard ... what would happen on real
> >> hardware is that the USB controller will get a target abort, which will
> >> result in the controller reporting an error (typically in the PCI status
> >> r
On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote:
> Why not make life easy and fix dma_addr_t to 64-bit?
No opinion on my side, that's from the original patch series, I suppose
the goal was to avoid the overhead/bloat on 32-bit only
platforms/targets.
Cheers,
Ben.
On Wed, 2012-06-20 at 16:15 -0500, Anthony Liguori wrote:
> On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote:
> > From: David Gibson
> >
> > This patch adds cpu_physical_memory_set() function. This is equivalent to
> > calling cpu_physical_memory_write() with a buf
> > /* DMA access functions */
> > +static inline DMAContext *pci_dma_context(PCIDevice *dev)
> > +{
> > +/* Stub for when we have no PCI iommu support */
> > +return NULL;
> > +}
>
> Why is all of this stuff static inline?
Why not ? Not doing so is gratuitous bloat & overhead
> >
> > Cc: Gerd Hoffmann
> > Cc: Michael S. Tsirkin
> >
> > Signed-off-by: David Gibson
> > Signed-off-by: Benjamin Herrenschmidt
>
>
> So... the DMA api is designed to allow for partial result returns which I
> presume an implementation would use a
On Wed, 2012-06-20 at 16:21 -0500, Anthony Liguori wrote:
> Again, you return an error but ignore it now.
>
> In the very least, on error you should scrub the passed in buffer to avoid
> leaking data to the guest.
>
> You can imagine a malicious guest programming the IOMMU with invalid mappings
On Wed, 2012-06-20 at 16:25 -0500, Anthony Liguori wrote:
> So this cancellation stuff is hopelessly broken
>
> It's simply not possible to fully cancel pending DMA in a synchronous
> callback.
Well, at least for PAPR H_PUT_TCE, cancellation must be synchronous, ie
the hypercall must not return
On Wed, 2012-06-20 at 16:40 -0500, Anthony Liguori wrote:
> Well let's return void in the DMA methods and let the IOMMUs assert on error.
> At least that will avoid surprises until someone decides they care enough
> about
> errors to touch all callers.
>
> I think silently failing a memcpy() c
On Thu, 2012-06-21 at 11:45 +1000, David Gibson wrote:
> > Why should this be in the core API? Shouldn't this be a helper on
> > top of the DMA API?
>
> Well, I was hoping to avoid having to allocate a temporary buffer of
> zeroes, which is necessary to do this in terms of the existing
> cpu_phys
On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote:
> diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h
> > new file mode 100644
> > index 000..f0ff558
> > --- /dev/null
> > +++ b/hw/qdev-dma.h
> > @@ -0,0 +1,12 @@
> > +/*
> > + * Support for dma_addr_t typed properties
> > + *
> > + * Copyrig
On Wed, 2012-06-20 at 16:15 -0500, Anthony Liguori wrote:
> On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote:
> > From: David Gibson
> >
> > This patch adds cpu_physical_memory_set() function. This is equivalent to
> > calling cpu_physical_memory_write() with a buf
On Wed, 2012-06-20 at 16:11 -0400, Jason Baron wrote:
> There are several instances of 'typedef struct DMAContext DMAContext'. Remove
> them
> all except for the one in qemu-common.h.
Actually, the other way around :-) I'm removing the one in qemu-common.h
in favor of the one in dma.h (at Anthony
On Wed, 2012-06-20 at 16:16 -0500, Anthony Liguori wrote:
> > diff --git a/qemu-common.h b/qemu-common.h
> > index 8f87e41..80026af 100644
> > --- a/qemu-common.h
> > +++ b/qemu-common.h
> > @@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier;
> > typedef struct VirtIODevice VirtIODevi
On Thu, 2012-06-21 at 07:55 -0500, Anthony Liguori wrote:
> As long as we scrub the buffers, returning an unhandled error seems okay to
> me.
>
> I've long thought we should have some sort of generic way to throw an error
> and
> effectively pause a single device. I'm not sure how it would wo
On Wed, 2012-06-20 at 16:25 -0500, Anthony Liguori wrote:
> > +static void dma_aio_cancel(BlockDriverAIOCB *acb)
> > +{
> > +DMAAIOCB *dbs = container_of(acb, DMAAIOCB, common);
> > +
> > +trace_dma_aio_cancel(dbs);
> > +
> > +if (dbs->acb) {
> > +BlockDriverAIOCB *acb = dbs->a
Here's the latest drop as discussed on the list. 2 patches are gone,
the _set variant is folded in the DMA helpers and I ditched all the
broken cancellation bits.
ze of dma_addr_t.
* We add a new helper macro to create device properties which take a
dma_addr_t, currently an alias to DEFINE_PROP_TADDR().
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma.h |1 +
hw/qdev-dma.h | 12
2 files change
pass something else in some cases to allow proper IOMMU
translation in future, but that will be fixed in later patches.
Cc: Kevin Wolf
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma-helpers.c | 24
DMAContext from pci_dma_context(), in
the SysBus case, it uses NULL - i.e. assumes for now that there will
be no IOMMU translation for a SysBus OHCI.
Cc: Gerd Hoffmann
Cc: Michael S. Tsirkin
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
hw/usb/hcd-ohci.c | 93
: Benjamin Herrenschmidt
---
dma-helpers.c |2 ++
dma.h | 52 ++--
2 files changed, 52 insertions(+), 2 deletions(-)
diff --git a/dma-helpers.c b/dma-helpers.c
index 2e09ceb..35cb500 100644
--- a/dma-helpers.c
+++ b/dma-helpers.c
@@ -31,6 +31,8
: Alexey Kardashevskiy
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
hw/spapr.h |1 +
hw/spapr_iommu.c | 40 ++--
hw/spapr_pci.c | 15 +++
hw/spapr_pci.h |1 +
4 files changed, 39 insertions(+), 18 deletions
Munteanu
Signed-off-by: Benjamin Herrenschmidt
---
hw/pci.c |9 +
hw/pci.h |9 +++--
hw/pci_internals.h |2 ++
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index bdfb3d6..c8d16a4 100644
--- a/hw/pci.c
+++ b/hw
Signed-off-by: Benjamin Herrenschmidt
---
hw/usb.h |2 +-
hw/usb/hcd-ehci.c |4 ++--
hw/usb/hcd-uhci.c |2 +-
hw/usb/libhw.c| 21 +++--
4 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/hw/usb.h b/hw/usb.h
index 2a56fe5..a5623d3 100644
from pci_dma_context() in the PCI case and
set to NULL in the SysBus case (i.e. we assume for now that a SysBus
AHCI has no IOMMU translation).
Cc: Kevin Wolf
Cc: Michael S. Tsirkin
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
hw/ide/ahci.c |
ts this code to make use of the new common IOMMU
infrastructure.
We don't yet handle synchronization of map/unmap callbacks vs. invalidations,
this will require some complex interaction with the kernel and is not a
major concern at this stage.
Cc: Alex Graf
Signed-off-by: David Gibson
Sig
this callback.
Cc: Michael S. Tsirkin
Cc: Richard Henderson
Signed-off-by: Eduard - Gabriel Munteanu
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma-helpers.c | 172 -
dma.h | 108
Henderson
Signed-off-by: David Gibson
Signed-off-by: Benjamin Herrenschmidt
---
dma-helpers.c | 16 ++
dma.h | 95 +
hw/pci.h | 21 +++--
3 files changed, 123 insertions(+), 9 deletions(-)
diff -
On Sun, 2012-06-24 at 06:03 +, Blue Swirl wrote:
> > + * A smarter implementation can be devised if needed to
> > + * use lighter barriers based on the direction of the
> > + * transfer, the DMA context, etc...
> > + */
> > +if (kvm_enabled())
> > +smp_mb();
>
> Mis
On Mon, 2012-06-25 at 22:55 -0600, Alex Williamson wrote:
> Hi,
>
> VFIO has been kicking around for well over a year now and has been
> posted numerous times for review. The pre-requirements are finally
> available in linux-next (or will be in the 20120626 build) so I'd like
> to request a new b
1 - 100 of 1367 matches
Mail list logo
