On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote: > diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h > > new file mode 100644 > > index 0000000..f0ff558 > > --- /dev/null > > +++ b/hw/qdev-dma.h > > @@ -0,0 +1,12 @@ > > +/* > > + * Support for dma_addr_t typed properties > > + * > > + * Copyright (C) 2012 David Gibson, IBM Corporation. > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2 or > > later. > > + * See the COPYING file in the top-level directory. > > + */ > > +#include "qdev-addr.h" > > + > > +#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d) \ > > + DEFINE_PROP_TADDR(_n, _s, _f, _d) > > Why not make life easy and fix dma_addr_t to 64-bit?
So you guys haven't come to a firm conclusion yet :) I'll leave that as it is for now, it's trivial anyway. If you want to change target_addr to be 64-bit that will make dma_addr_t 64-bit too. If you want to make it 64-bit unconditionally, just drop this patch (and change the definition). Cheers, Ben.
