Re: [PATCH v5 0/9] Misc clean ups to target/ppc exception handling

2024-02-16 Thread BALATON Zoltan
On Tue, 30 Jan 2024, BALATON Zoltan wrote: On Thu, 18 Jan 2024, BALATON Zoltan wrote: These are some small clean ups for target/ppc/excp_helper.c trying to make this code a bit simpler. No functional change is intended. This series was submitted before but only partially merged due to freeze

Re: [PATCH 1/6] target/ppc: Fix 440 tlbwe TLB invalidation gaps

2024-02-16 Thread BALATON Zoltan
series to miss release. So an early pull request would help to get everybody on the same page. Regards, BALATON Zoltan

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-16 Thread BALATON Zoltan
be easy to do in a generic way so not sure about that). What do you think? Regards, BALATON Zoltan

Re: [PATCH v3] vl: Print display options for -display help

2024-02-18 Thread BALATON Zoltan
erefore I don't ask you to do that instead but this patch is also not what I wanted. Regards. BALATON Zoltan Regards, Akihiko Odaki On 2023/12/16 17:03, Akihiko Odaki wrote: -display lists display backends, but does not tell their options. Use the help messages from qemu-options.def, wh

Re: [PATCH 0/5] Implement port 92 in south bridges

2024-02-18 Thread BALATON Zoltan
nd get rid of TYPE_PORT92 and just implement it in the south bridges. But due to how it's currently done and how that's now baked in because of backward compatibility requrement for migration, I'm not sure it would really simplify the code, so we may need to live with what we have now. Bu

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 16/2/24 20:54, Philippe Mathieu-Daudé wrote: On 16/2/24 18:14, BALATON Zoltan wrote: On Fri, 16 Feb 2024, Philippe Mathieu-Daudé wrote: We want to set another qdev property (a link) for the pl110 and pl111 devices, we can not use

Re: [PATCH] tests/qtest: Fix boot-serial-test when using --without-default-devices

2024-02-19 Thread BALATON Zoltan
created even with -nodefaults and should always present on sam460ex. The -device option just adds a device that appears before the sm501 and stops the test there. Not sure if this is testing more than looking for a PCI device created by the board code. Regards, BALATON Zoltan { "i386", "isapc", "-cpu qemu32 -M graphics=off", "SeaBIOS" }, { "i386", "pc", "-M graphics=off", "SeaBIOS" }, { "i386", "q35", "-M graphics=off", "SeaBIOS" },

Re: [PATCH 2/7] hw/ide: Split qdev.c into ide-bus.c and ide-dev.c

2024-02-19 Thread BALATON Zoltan
select IDE_CORE Maybe we can assume if something has an IDE bus it also wants to connect IDE devices to it so just select IDE_DEV here and not at every place IDE_BUS is selected? Or is there a place that only wants IDE_BUS? Regards, BALATON Zoltan +config IDE_DEV +bool +depends

Re: [PATCH 5/7] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h

2024-02-19 Thread BALATON Zoltan
of the DMA and IDE types not defined above? Regards, BALATON Zoltan +}; + +#endif diff --git a/include/hw/ide/internal.h b/include/hw/ide/internal.h index 642bd1a979..d1d3fcd23a 100644 --- a/include/hw/ide/internal.h +++ b/include/hw/ide/internal.h @@ -9,6 +9,7 @@ #include "hw/ide.h"

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 19/2/24 12:27, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 16/2/24 20:54, Philippe Mathieu-Daudé wrote: On 16/2/24 18:14, BALATON Zoltan wrote: On Fri, 16 Feb 2024, Philippe Mathieu-Daudé wrote: We want to

Re: [PATCH] tests/qtest: Fix boot-serial-test when using --without-default-devices

2024-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2024, Thomas Huth wrote: On 19/02/2024 12.37, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Thomas Huth wrote: If "configure" has been run with "--without-default-devices", there is no e1000 device in the binaries, so the boot-serial-test currently fails in that

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 19/2/24 13:00, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 19/2/24 12:27, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 16/2/24 20:54, Philippe Mathieu-Daudé wrote: On 16/2/24

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2024, Mark Cave-Ayland wrote: On 19/02/2024 12:00, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 19/2/24 12:27, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: On 16/2/24 20:54, Philippe Mathieu-Daudé wrote: On 16/2/24 18

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2024, Mark Cave-Ayland wrote: On 19/02/2024 13:05, Peter Maydell wrote: On Mon, 19 Feb 2024 at 12:49, Mark Cave-Ayland wrote: On 19/02/2024 12:00, BALATON Zoltan wrote: For new people trying to contribute to QEMU QDev is overwhelming so having some way to need less of it to

Re: [PULL 09/49] tests/avocado: Add FreeBSD distro boot tests for ppc

2024-02-19 Thread BALATON Zoltan
be added so this does not get a ppc_ prefix but is instead named similarly to boot_linux. Reviewed-by: Warner Losh Signed-off-by: Nicholas Piggin Didn't you mean to put this below ---? Regards, BALATON Zoltan Unfortunately the latest stable (14.0) x86-64 VM image does not seem to outp

Re: [PULL 22/49] hw/pci-host/raven.c: Mark raven_io_ops as implementing unaligned accesses

2024-02-19 Thread BALATON Zoltan
t non-contiguous I/O region") Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: Peter Maydell Signed-off-by: Nicholas Piggin Hm, this seems to be missing the actual patch. Regards, BALATON Zoltan

Re: [PATCH 06/14] hw/pci-bridge: Extract QOM ICH definitions to 'ich_dmi_pci.h'

2024-02-19 Thread BALATON Zoltan
with: 4 files changed, 25 insertions(+), 9 deletions(-) but really simplifying it. Regards, BALATON Zoltan + +#endif diff --git a/include/hw/southbridge/ich9.h b/include/hw/southbridge/ich9.h index bee522a4cf..b2abf483e0 100644 --- a/include/hw/southbridge/ich9.h +++ b/include/hw/southbridge/ic

Re: [PATCH 06/14] hw/pci-bridge: Extract QOM ICH definitions to 'ich_dmi_pci.h'

2024-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2024, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: Expose TYPE_ICH_DMI_PCI_BRIDGE to the new "hw/pci-bridge/ich_dmi_pci.h" header. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + include/hw/

Re: [PATCH 09/14] hw/southbridge/ich9: Add a AHCI function

2024-02-19 Thread BALATON Zoltan
cms->sata_enabled) { Shouldn't this condition be inverted if you only leave the else leg? Regards,. BALATON Zoltan -PCIDevice *pdev; -AHCIPCIState *ich9; - -/* ahci and SATA device, for q35 1 ahci controller is built-in */ -pdev = pci_create_simple_multifu

[PATCH v2] docs/system/ppc: Document running Linux on AmigaNG machines

2024-02-19 Thread BALATON Zoltan
ff-by: BALATON Zoltan --- v2: Move top level title one level up so subsections will be below it in TOC MAINTAINERS | 1 + docs/system/ppc/amigang.rst | 161 docs/system/target-ppc.rst | 1 + 3 files changed, 163 insertions(+) create mode 1

Re: [PATCH] docs/system/ppc: Document running Linux on AmigaNG machines

2024-02-19 Thread BALATON Zoltan
On Fri, 16 Feb 2024, Thomas Huth wrote: On 16/02/2024 01.10, BALATON Zoltan wrote: Documentation on how to run Linux on the amigaone, pegasos2 and sam460ex machines is currently burried in the depths of the qemu-devel s/burried/buried/ mailing list and in the source code. Let's collec

Re: [PATCH v1 06/21] ppc: correct typos

2024-02-20 Thread BALATON Zoltan
bit 21 as an actual Rc bit. In general, these pairs This one is a typo. Regards, BALATON Zoltan * come from different versions of the ISA, so we must also support a * pair of flags for each instruction. */

Re: [PATCH 06/14] hw/pci-bridge: Extract QOM ICH definitions to 'ich_dmi_pci.h'

2024-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2024, Philippe Mathieu-Daudé wrote: On 19/2/24 19:24, BALATON Zoltan wrote: On Mon, 19 Feb 2024, BALATON Zoltan wrote: On Mon, 19 Feb 2024, Philippe Mathieu-Daudé wrote: Expose TYPE_ICH_DMI_PCI_BRIDGE to the new "hw/pci-bridge/ich_dmi_pci.h" header. Signed-off-by

[PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-02-20 Thread BALATON Zoltan
ff-by: BALATON Zoltan Reviewed-by: Nicholas Piggin Tested-by: Bernhard Beschow --- v3: Apply changes and Tested-by tag from Bernhard v2: Move top level title one level up so subsections will be below it in TOC MAINTAINERS | 1 + docs/system/ppc/amigang.rst

Re: [PATCH 3/5] hw/isa: Embed TYPE_PORT92 in south bridges used in PC machines

2024-02-21 Thread BALATON Zoltan
idge untouched and changes the superio instead that I care less about but the issue is the same there.) Regards, BALATON Zoltan

Re: [PATCH v5 9/9] target/ppc: Remove interrupt handler wrapper functions

2024-02-22 Thread BALATON Zoltan
On Thu, 22 Feb 2024, Harsh Prateek Bora wrote: On 1/19/24 03:31, BALATON Zoltan wrote: These wrappers call out to handle POWER7 and newer in separate functions but reduce to the generic case when TARGET_PPC64 is not defined. It is easy enough to include the switch in the beginning of the

[PATCH v6 2/9] target/ppc: Readability improvements in exception handlers

2024-02-22 Thread BALATON Zoltan
Improve readability by shortening some long comments, removing comments that state the obvious and dropping some empty lines so they don't distract when reading the code. Signed-off-by: BALATON Zoltan Acked-by: Nicholas Piggin --- target/ppc/cpu.h | 1 + target/ppc/excp_hel

[PATCH v6 4/9] target/ppc: Move patching nip from exception handler to helper_scv

2024-02-22 Thread BALATON Zoltan
ge it. [balaton: added commit message] Signed-off-by: BALATON Zoltan --- target/ppc/excp_helper.c | 2 +- target/ppc/translate.c | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index 1c07a11405..411d67376c 100644 --- a/t

[PATCH v6 6/9] target/ppc: Clean up ifdefs in excp_helper.c, part 1

2024-02-22 Thread BALATON Zoltan
Use #ifdef, #ifndef for brevity and add comments to #endif that are more than a few lines apart for clarity. Signed-off-by: BALATON Zoltan Reviewed-by: Harsh Prateek Bora --- target/ppc/excp_helper.c | 49 1 file changed, 24 insertions(+), 25 deletions

[PATCH v6 1/9] target/ppc: Use env_cpu for cpu_abort in excp_helper

2024-02-22 Thread BALATON Zoltan
Use the env_cpu function to get the CPUState for cpu_abort. These are only needed in case of fatal errors so this allows to avoid casting and storing CPUState in a local variable wnen not needed. Signed-off-by: BALATON Zoltan Reviewed-by: Harsh Prateek Bora --- target/ppc/excp_helper.c | 118

[PATCH v6 5/9] target/ppc: Simplify syscall exception handlers

2024-02-22 Thread BALATON Zoltan
After previous changes the hypercall handling in 7xx and 74xx exception handlers can be folded into one if statement to simpilfy this code. Also add "unlikely" to mark the less freqiently used branch for the compiler. Signed-off-by: BALATON Zoltan Reviewed-by: Harsh Prateek Bora ---

[PATCH v6 7/9] target/ppc: Clean up ifdefs in excp_helper.c, part 2

2024-02-22 Thread BALATON Zoltan
Remove check for !defined(CONFIG_USER_ONLY) as this is already within an #ifndef CONFIG_USER_ONLY block. Signed-off-by: BALATON Zoltan Reviewed-by: Harsh Prateek Bora --- target/ppc/excp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/excp_helper.c b

[PATCH v6 0/9] Misc clean ups to target/ppc exception handling

2024-02-22 Thread BALATON Zoltan
master - added R-b tags and changes from Harsh v5: - rebase on master - keep logging nip pointing to the sc instruction - add another patch v4: Rebased on master dropping what was merged BALATON Zoltan (9): target/ppc: Use env_cpu for cpu_abort in excp_helper target/ppc: Readability improvements

[PATCH v6 3/9] target/ppc: Fix gen_sc to use correct nip

2024-02-22 Thread BALATON Zoltan
is in the exception handlers. Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggin --- target/ppc/excp_helper.c | 43 ++-- target/ppc/translate.c | 10 ++ 2 files changed, 8 insertions(+), 45 deletions(-) diff --git a/target/ppc/excp_helpe

[PATCH v6 9/9] target/ppc: Remove interrupt handler wrapper functions

2024-02-22 Thread BALATON Zoltan
avoids one indirection and entirely compiles out the switch without TARGET_PPC64. Signed-off-by: BALATON Zoltan Reviewed-by: Harsh Prateek Bora --- target/ppc/excp_helper.c | 67 +--- 1 file changed, 28 insertions(+), 39 deletions(-) diff --git a/target/ppc

[PATCH v6 8/9] target/ppc: Clean up ifdefs in excp_helper.c, part 3

2024-02-22 Thread BALATON Zoltan
Concatenate #if blocks that are ending then beginning on the next line again. Signed-off-by: BALATON Zoltan Reviewed-by: Harsh Prateek Bora --- target/ppc/excp_helper.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/target/ppc/excp_helper.c b/target/ppc

Re: [PATCH v6 5/9] target/ppc: Simplify syscall exception handlers

2024-02-22 Thread BALATON Zoltan
On Thu, 22 Feb 2024, Philippe Mathieu-Daudé wrote: On 22/2/24 12:33, BALATON Zoltan wrote: After previous changes the hypercall handling in 7xx and 74xx exception handlers can be folded into one if statement to simpilfy "simplify" this code. Also add "unlikely" to mark

[PATCH] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide

2024-02-23 Thread BALATON Zoltan
Remove last two includes of hw/ide/intarnal.h outside of hw/ide and replace them with newly added public header to allow moving internal.h into hw/ide to really stop exposing it. Fixes: a11f439a0e (hw/ide: Stop exposing internal.h to non-IDE files) Signed-off-by: BALATON Zoltan --- hw/arm/sbsa

Re: [PATCH] ui/cocoa: Fix incorrect window clipping on macOS Sonoma

2024-02-23 Thread BALATON Zoltan
e you did the first time. (You can use -v2 option to git format-patch to add v2 to subject but if you're not using git format-patch directly then I'm not sure what option will do that for the way you send the patch.) Regards, BALATON Zoltan Dave diff --git a/ui/cocoa.m b/u

Re: [PATCH 05/10] hppa: do not require CONFIG_USB

2024-02-23 Thread BALATON Zoltan
s already disabled if defaults_enabled() is not set? Isn't enable_graphics controlled by -nographic and defaults_enabled controlled by -nodefaults? I think they are independent but maybe that does not answer the question if it's needed or not. Regards, BALATON Zoltan Thomas

Re: [PATCH v11 6/6] ui/cocoa: Remove stretch_video flag

2024-02-24 Thread BALATON Zoltan
after all. If not a method how about a macro just to make it less long? But if Peter is otherwise happy with the current version just this does not need another version IMO. Regards, BALATON Zoltan

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-25 Thread BALATON Zoltan
but there are others elsewhere such as pci_device.h). Maybe we should be consistent at least within IDE and this series is now a good opportunity for renaming these headers to match. But it's just a small nit, thanks for picking this up. Regards, BALATON Zoltan it via its relative local pat

Re: [PATCH] hw/us/bus.c PCAP adding 0xA in Windows version

2024-02-25 Thread BALATON Zoltan
t for whoever will manage this patch. Regards, BALATON Zoltan Resolves: https://bugs.launchpad.net/qemu/+bug/2054889 Signed-off-by: Benjamin David Lunt --- hw/usb/bus.c | 2 +- 1 file changed, 2 insertions(+), 2 deletions(-) diff -u a/hw/usb/bus.c b/hw/usb/bus.c --- a/hw/usb/bus.c +++ b/h

Re: [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find()

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Markus Armbruster wrote: Please ignore this one; I replied to the wrong patch by accident. Your comment is still valid for that patch so no need to ignore it. Regards, BALATON Zoltan

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and include Is there a convention about using underscore o

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 09:00, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.h" as "ide_internal.h", and

Re: [PATCH v2 06/15] hw/ide: Rename ich.c -> ich9_ahci.c

2024-02-26 Thread BALATON Zoltan
ahci-allwinnet.c maybe? Regsards, BALATON Zoltan hw/ide/meson.build| 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename hw/ide/{ich.c => ich9_ahci.c} (100%) diff --git a/hw/ide/ich.c b/hw/ide/ich9_ahci.c similarity index 100% rename from hw/ide/ich.c rename to hw/ide/ich9_

Re: [PATCH v2 08/15] hw/pci-bridge: Extract QOM ICH definitions to 'ich9_dmi.h'

2024-02-26 Thread BALATON Zoltan
x for what it does or used for. Regards, BALATON Zoltan Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + include/hw/pci-bridge/ich9_dmi.h | 20 include/hw/southbridge/ich9.h | 2 -- hw/pci-bridge/{i82801b11.c =>

Re: [PATCH v2 08/15] hw/pci-bridge: Extract QOM ICH definitions to 'ich9_dmi.h'

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 14:01, BALATON Zoltan wrote: On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: Expose TYPE_ICH_DMI_PCI_BRIDGE to the new "hw/pci-bridge/ich9_dmi.h" header. Since this is effectively an empty object (that's not ev

Re: [PATCH v2 06/15] hw/ide: Rename ich.c -> ich9_ahci.c

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 13:52, BALATON Zoltan wrote: On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: Most ICH9-related files use the 'ich9_' prefix. Mention 'AHCI' in the file name. Signed-off-by: Philippe Mathieu-Daud

Re: [PATCH 06/14] hw/pci-bridge: Extract QOM ICH definitions to 'ich_dmi_pci.h'

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 20/2/24 13:55, Thomas Huth wrote: On 20/02/2024 13.20, BALATON Zoltan wrote: On Tue, 20 Feb 2024, Philippe Mathieu-Daudé wrote: On 19/2/24 19:24, BALATON Zoltan wrote: On Mon, 19 Feb 2024, BALATON Zoltan wrote: On Mon, 19 Feb 2024

Re: [PATCH v2 3/3] hw/ide: Include 'ide_internal.h' from current path

2024-02-26 Thread BALATON Zoltan
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 11:50, BALATON Zoltan wrote: On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote: On 26/2/24 08:40, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote: Rename "internal.

Re: [PATCH v3 01/29] bulk: Access existing variables initialized to &S->F when available

2024-01-29 Thread BALATON Zoltan
he adb_bus local is used so maybe can drop the local and chnage next line to use &s->adb_bus instead. Regards, BALATON Zoltan dev, "adb.0"); adb_register_autopoll_callback(adb_bus, pmu_adb_poll, s); }

Re: [PATCH 16/22] target/split: Split ver from env->fsr

2024-01-30 Thread BALATON Zoltan
gards, BALATON Zoltan

Re: [PATCH v5 0/9] Misc clean ups to target/ppc exception handling

2024-01-30 Thread BALATON Zoltan
On Thu, 18 Jan 2024, BALATON Zoltan wrote: These are some small clean ups for target/ppc/excp_helper.c trying to make this code a bit simpler. No functional change is intended. This series was submitted before but only partially merged due to freeze and conflicting series os thia was postponed

Re: why various devices are loading x86 roms on non-x86 architectures?

2024-01-31 Thread BALATON Zoltan
a PC option ROM. Regards, BALATON Zoltan

Re: [PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread BALATON Zoltan
include/hw/ide/internal.h to ide.h and name this one internal.h maybe? Regards, BALATON Zoltan @@ -0,0 +1,41 @@ +/* + * ide bus support for qdev. + * + * Copyright (c) 2009 Gerd Hoffmann + * + * This code is free software; you can redistribute it and/or + * modify it under the terms of the

Re: [PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread BALATON Zoltan
On Thu, 1 Feb 2024, Thomas Huth wrote: On 01/02/2024 13.39, BALATON Zoltan wrote: On Thu, 1 Feb 2024, Thomas Huth wrote: For distros like downstream RHEL, it would be helpful to allow to disable the CompactFlash device. For making this possible, we need a separate Kconfig switch for this

Re: [PATCH] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-01 Thread BALATON Zoltan
On Thu, 1 Feb 2024, Thomas Huth wrote: On 01/02/2024 13.54, BALATON Zoltan wrote: On Thu, 1 Feb 2024, Thomas Huth wrote: On 01/02/2024 13.39, BALATON Zoltan wrote: On Thu, 1 Feb 2024, Thomas Huth wrote: For distros like downstream RHEL, it would be helpful to allow to disable the

Re: ehci: more than 16 ITDs

2024-02-03 Thread BALATON Zoltan
from the simple enable=pattern these can also be controlled from QEMU monitor or put the list in a text file and use that with --trace to enable several of these. Regards, BALATON Zoltan

Re: [PATCH v2 2/4] hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h

2024-02-07 Thread BALATON Zoltan
On Wed, 7 Feb 2024, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Message-Id: <20231011132427.65001-3-phi...@linaro.org> --- MAINTAINERS | 1 + include/hw/pci-host/ppc4xx.h | 17 + include/hw/ppc/pp

Re: [PATCH v2 4/4] hw/ppc/ppc440_pcix: Move ppc440_pcix.c to hw/pci-host/

2024-02-07 Thread BALATON Zoltan
hosts in different SoCs so I'm not sure there isn't another earlier one with is called just pci so better call this one pcix as it's referred to in the device tree so we don't need to rename it if another SoC with just PCI host is added later. Regards, BALATON Zoltan

Re: [PATCH v2 4/8] isa: fix ISA_SUPERIO dependencies

2024-02-07 Thread BALATON Zoltan
: BALATON Zoltan --- hw/isa/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 7884179d08b..5df3c09cd51 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -15,7 +15,7 @@ config I82378 config ISA_SUPERIO bool -select ISA_BUS

Re: [PATCH v2 6/8] isa: extract FDC37M81X to a separate file

2024-02-07 Thread BALATON Zoltan
On Wed, 7 Feb 2024, Paolo Bonzini wrote: isa-superio.c currently defines a SuperIO chip that is not used by any other user of the faile. Extract the chip to a separate file. Typo: faile -> file? Regards, BALATON Zoltan Signed-off-by: Paolo Bonzini --- hw/isa/fdc37m81x-superio.c |

Re: [PATCH v2 7/8] mips: allow compiling out CONFIG_MIPS_ITU

2024-02-07 Thread BALATON Zoltan
t; + +void itc_reconfigure(MIPSITUState *tag) +{ +abort(); Isn't g_assert_not_reached() preferred now for it giving better dignostics? But I don't know, just asking. Regards, BALATON Zoltan +} diff --git a/hw/mips/meson.build b/hw/mips/meson.build index f06d88f3430..2b1b96147a6 10064

Re: [PATCH v2 8/8] mips: do not list individual devices from configs/

2024-02-07 Thread BALATON Zoltan
b-tablet"); +Object *usb_bus = object_resolve_path_type("", TYPE_USB_BUS, NULL); +usb_create_simple(USB_BUS(usb_bus), "usb-kbd"); +usb_create_simple(USB_BUS(usb_bus), "usb-tablet"); } for (i = 0; i < nb_nics; i++) { Is th

Re: [PATCH v3 04/11] hw/i386/pc_q35: Realize LPC PCI function before accessing it

2024-02-08 Thread BALATON Zoltan
On Thu, 8 Feb 2024, Philippe Mathieu-Daudé wrote: We should not wire IRQs on unrealized device. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 7ca3f465e0..f67e5a55df 100644 -

Re: [PATCH v3 06/11] hw/misc/macio: Realize IDE controller before accessing it

2024-02-08 Thread BALATON Zoltan
ccess = qdev_realize(DEVICE(ide), BUS(&s->macio_bus), errp); If realize is unsuccessful can you connect irqs if device may be unrealized? So maybe either the next two lines should be in an if block or drop the success flag and return false here if (!qdev_realize) and true at

[PATCH] system: Move memory_ldst.c.inc to system

2024-02-08 Thread BALATON Zoltan
This file is only used by system/physmem.c so move them together. Signed-off-by: BALATON Zoltan --- memory_ldst.c.inc => system/memory_ldst.c.inc | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename memory_ldst.c.inc => system/memory_ldst.c.inc (100%) diff --git a/memory_ldst.c

[PATCH] qemu-options.hx: Add zoom-to-fit to option summary for gtk

2024-02-08 Thread BALATON Zoltan
The detailed help lists zoom-to-fit as valid option but it is missing from the short option summary. Add it there too. Signed-off-by: BALATON Zoltan --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 5adbed1101

Re: [RFC PATCH 0/7] hw/qdev: Split 'wiring' phase from 'realize'

2024-02-09 Thread BALATON Zoltan
it in the device realize method. I probably don't understand the problem fully, what I want to say is that device creation is complex enough now so trying to avoid adding more complexity to it would be a good thing. Regards, BALATON Zoltan

Re: [PATCH] hw/hppa/Kconfig: Fix building with "configure --without-default-devices"

2024-02-09 Thread BALATON Zoltan
isting it separately but not sure what's the policy for these configs. Regards, BALATON Zoltan Other than that, Acked-by: Helge Deller Thank you! Helge select ISA_BUS select I8259 select IDE_CMD646 @@ -16,3 +16,4 @@ config HPPA_B160L select LASIPS2 select PARALLEL select ARTIST +select USB_OHCI_PCI

Re: TCG change broke MorphOS boot on sam460ex

2024-03-21 Thread BALATON Zoltan
On 27/2/24 17:47, BALATON Zoltan wrote: Hello, Commit 18a536f1f8 (accel/tcg: Always require can_do_io) broke booting MorphOS on sam460ex (this was before 8.2.0 and I thought I've verified it before that release but apparently missed it back then). It can be reproduced with

[PATCH] docs/system/ppc/amigang.rst: Fix formatting

2024-03-24 Thread BALATON Zoltan
Add missing space to fix character formatting where it was missed in two places. Fixes: 623d9065b6 (docs/system/ppc: Document running Linux on AmigaNG machines) Signed-off-by: BALATON Zoltan --- docs/system/ppc/amigang.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH-for-9.1 05/21] target/m68k: Replace qemu_printf() by monitor_printf() in monitor

2024-03-24 Thread BALATON Zoltan
monitor_puts(mon, "W"); /* Write protect */ } else { -qemu_printf("."); +monitor_puts(mon, "."); } if (env->mmu.mmusr & M68K_MMU_T_040) { -qemu_printf("T"); /* Transparent */ +

Re: [RFC PATCH-for-9.1 09/29] hw/i386/pc: Pass PCMachineState argument to acpi_setup()

2024-03-28 Thread BALATON Zoltan
8 #define ACPI_PCIHP_BNMR_BASE 0x10 -void acpi_setup(void); +void acpi_setup(PCMachineState *pcms); This is changed to PcPciMachineState * in a following patch so can't you already introduce it here to avoid some churn? Regards, BALATON Zoltan Object *acpi_get_i386_pci_host(void); #endif

Re: [RFC PATCH-for-9.1 13/29] hw/i386/pc: Remove non-PCI code from pc_system_firmware_init()

2024-03-28 Thread BALATON Zoltan
r PCI PC machine now? Regards, BALATON Zoltan int i; BlockBackend *pflash_blk[ARRAY_SIZE(pcms->flash)]; -if (!pc_machine_is_pci_enabled(pcms)) { -x86_bios_rom_init(MACHINE(pcms), "bios.bin", rom_memory, true); -return; -} +assert(pc_machine_is_pci_e

Re: [RFC PATCH-for-9.1 14/29] hw/i386/pc: Move pc_system_flash_create() to pc_pci_machine_initfn()

2024-03-28 Thread BALATON Zoltan
;system.flash0", "pflash0"); +pcms->flash[1] = pc_pflash_create(pcms, "system.flash1", "pflash1"); } This could just be inlined as it's called once, then no need for assert and a separate function. Regards, BALATON Zoltan void pc_system_flash_cleanup_unused(PCMachineState *pcms)

Re: Qemu Display Coacoa Patch Serie Qemu 9.0 RC1

2024-03-28 Thread BALATON Zoltan
full available window but try to keep the zoom factor some integer value to avoid fractional scaling but I'm not sure that's the best way to solve it. Regards, BALATON Zoltan I'll leave you 2 videos so you can decide for yourself what would make the most sense. It shows once fo

Re: [PATCH-for-9.1 05/21] target/m68k: Replace qemu_printf() by monitor_printf() in monitor

2024-03-28 Thread BALATON Zoltan
On Thu, 28 Mar 2024, Dr. David Alan Gilbert wrote: * BALATON Zoltan (bala...@eik.bme.hu) wrote: On Sun, 24 Mar 2024, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@linaro.org) wrote: Replace qemu_printf() by monitor_printf() / monitor_puts() in monitor. Signed-off-by

Re: TCG change broke MorphOS boot on sam460ex

2024-04-02 Thread BALATON Zoltan
On Thu, 21 Mar 2024, BALATON Zoltan wrote: On 27/2/24 17:47, BALATON Zoltan wrote: Hello, Commit 18a536f1f8 (accel/tcg: Always require can_do_io) broke booting MorphOS on sam460ex (this was before 8.2.0 and I thought I've verified it before that release but apparently missed it back

Re: TCG change broke MorphOS boot on sam460ex

2024-04-03 Thread BALATON Zoltan
On Wed, 3 Apr 2024, Nicholas Piggin wrote: On Tue Apr 2, 2024 at 9:32 PM AEST, BALATON Zoltan wrote: On Thu, 21 Mar 2024, BALATON Zoltan wrote: On 27/2/24 17:47, BALATON Zoltan wrote: Hello, Commit 18a536f1f8 (accel/tcg: Always require can_do_io) broke booting MorphOS on sam460ex (this was

Re: Point where target instructions are read

2024-04-03 Thread BALATON Zoltan
ode if the boot loader exepects it to be present. Regards, BALATON Zoltan Here simple_test.bin is the raw binary file converted using objcopy. addr=0xFFFE is the vector location where the PC will load with the starting address. Now how do I load the address in that reset vector location and set

[PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-09 Thread BALATON Zoltan
. Signed-off-by: BALATON Zoltan --- This is only used by sam460ex and this fixes an issue with AmigaOS on this machine so I'd like this to be merged for 9.0 please. hw/pci-host/ppc440_pcix.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/hw/pci-host/ppc440_pci

Re: [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-10 Thread BALATON Zoltan
On Wed, 10 Apr 2024, Nicholas Piggin wrote: On Wed Apr 10, 2024 at 9:55 AM AEST, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which machine it is running on. Since

[PATCH] hw/isa/vt82c686: Keep track of PIRQ/PINT pins separately

2024-04-10 Thread BALATON Zoltan
Move calculation of mask after the switch which sets the function number for PIRQ/PINT pins to make sure the state of these pins are kept track of separately and IRQ is raised if any of them is active. Fixes: 7e01bd80c1 hw/isa/vt82c686: Bring back via_isa_set_irq() Signed-off-by: BALATON Zoltan

Re: [PATCH 00/12] misc: Remove sprintf() due to macOS deprecation

2024-04-10 Thread BALATON Zoltan
cases that way, if allowed. I had the same thought as some of these might also have performance implications (although most of them are in rarely called places). Regards, BALATON Zoltan

Re: [PATCH] hw/ppc/sam460ex: Support short options for adding drives

2024-03-09 Thread BALATON Zoltan
On Tue, 5 Mar 2024, BALATON Zoltan wrote: Having to use -drive if=none,... and -device ide-[cd,hd] is inconvenient. Add support for shorter convenience options such as -cdrom and -drive media=disk. Also adjust two nearby comments for code style. Signed-off-by: BALATON Zoltan Ping for freeze

Re: [PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-03-09 Thread BALATON Zoltan
On Thu, 29 Feb 2024, BALATON Zoltan wrote: On Wed, 21 Feb 2024, BALATON Zoltan wrote: Documentation on how to run Linux on the amigaone, pegasos2 and sam460ex machines is currently buried in the depths of the qemu-devel mailing list and in the source code. Let's collect the information i

Re: [PATCH v7 02/10] target/ppc: Readability improvements in exception handlers

2024-03-09 Thread BALATON Zoltan
On Thu, 29 Feb 2024, Nicholas Piggin wrote: On Wed Feb 28, 2024 at 6:24 AM AEST, BALATON Zoltan wrote: On Tue, 27 Feb 2024, BALATON Zoltan wrote: On Tue, 27 Feb 2024, Peter Maydell wrote: On Tue, 27 Feb 2024 at 15:10, BALATON Zoltan wrote: Improve readability by shortening some long

Re: [PATCH] usb: add support for sending MSIs from EHCI PCI devices

2024-03-09 Thread BALATON Zoltan
f (ret) { +error_propagate(errp, err); +} else { +error_free(err); +} I could be wrong but I think you don't have to do this and can just pass errp to msi_init here. You might need to check if (msi_init()) { return;} but as this is at the end even that does not matter (a

Re: [PATCH] hw/ide/ahci: Rename ahci_internal.h to ahci-internal.h

2024-03-10 Thread BALATON Zoltan
On Tue, 27 Feb 2024, Philippe Mathieu-Daudé wrote: On 27/2/24 14:13, BALATON Zoltan wrote: Other headers now use dash instead of underscore. Rename ahci_internal.h accordingly for consistency. Signed-off-by: BALATON Zoltan --- hw/ide/{ahci_internal.h => ahci-internal.h} | 0 hw/ide/ahc

Re: [PATCH 06/13] ppc/spapr: Add pa-features for POWER10 machines

2024-03-11 Thread BALATON Zoltan
and 0x00 is not the most readable. Regards, BALATON Zoltan +/* 0: MMU|FPU|SLB|RUN|DABR|NX, 1: fri[nzpm]|DABRX|SPRG3|SLB0|PP110 */ +/* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, 5: LE|CFAR|EB|LSQ */ +0xf6, 0x1f, 0xc7, 0xc0, 0x00, 0xf0, /* 0 - 5 */ +/* 6: DS207

Re: [PATCH 06/13] ppc/spapr: Add pa-features for POWER10 machines

2024-03-12 Thread BALATON Zoltan
On Tue, 12 Mar 2024, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 7:07 AM AEST, BALATON Zoltan wrote: On Mon, 11 Mar 2024, Philippe Mathieu-Daudé wrote: On 11/3/24 19:51, Nicholas Piggin wrote: From: Benjamin Gray Add POWER10 pa-features entry. Notably DEXCR and and [P]HASHST/[P]HASHCHK

Re: [PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-03-12 Thread BALATON Zoltan
On Wed, 13 Mar 2024, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 8:36 PM AEST, Nicholas Piggin wrote: On Tue Mar 12, 2024 at 7:28 PM AEST, Bernhard Beschow wrote: Am 9. März 2024 11:34:56 UTC schrieb BALATON Zoltan : On Thu, 29 Feb 2024, BALATON Zoltan wrote: On Wed, 21 Feb 2024, BALATON

Re: Request for Support: QEMU IPv6 Port Forwarding Issue

2024-03-19 Thread BALATON Zoltan
0::5054:ff:fecd:585a] out completely then the rule should applie to all guests but if you only have one guest then it does not matter. Regards, BALATON Zoltan Thomas Our primary concern is whether QEMU supports port forwarding for IPv6 networking. If it does, we kindly request your assistan

[PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-11 Thread BALATON Zoltan
Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which machine it is running on. Signed-off-by: BALATON Zoltan --- Here's another version that keeps the values and only drops the devi

Re: [PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-12 Thread BALATON Zoltan
On Thu, 11 Apr 2024, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which machine it is running on. Signed-off-by: BALATON Zoltan --- Here's another version

Re: [PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-14 Thread BALATON Zoltan
On Sat, 13 Apr 2024, Philippe Mathieu-Daudé wrote: On 11/4/24 21:24, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which machine it is running on. Signed-off-by

Re: [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-16 Thread BALATON Zoltan
On Tue, 16 Apr 2024, Nicholas Piggin wrote: On Wed Apr 10, 2024 at 9:03 PM AEST, BALATON Zoltan wrote: On Wed, 10 Apr 2024, Nicholas Piggin wrote: On Wed Apr 10, 2024 at 9:55 AM AEST, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI

<    1   2   3   4   5   6   7   8   9   10   >