On Sun, 18 Feb 2024, Akihiko Odaki wrote:
Hi Marc-André, Paolo,
This patch has Reviewed-by: and Tested-by: but not pulled yet. Can either of
you pull this?
I think we dropped this because it's not consistent with the other help
options such as -cpu help -device help that print the available options.
What we need instead is e.g. -display cocoa,help to print help about the
specific ui backend which isn't what this patch does so it's not the right
way. To do that however we probably need an expert on options and QOM
because it does not seem easy to add such option. Therefore I don't ask
you to do that instead but this patch is also not what I wanted.
Regards.
BALATON Zoltan
Regards,
Akihiko Odaki
On 2023/12/16 17:03, Akihiko Odaki wrote:
-display lists display backends, but does not tell their options.
Use the help messages from qemu-options.def, which include the list of
options.
Note that this change also has an unfortunate side effect that it will
no longer tell what UI modules are actually available.
Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Tested-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
Changes in v3:
- Dropped qapi/qapi-commands-ui.h inclusion. (Philippe Mathieu-Daudé)
- Link to v2:
https://lore.kernel.org/r/20231215-help-v2-1-3d39b58af...@daynix.com
Changes in v2:
- Noted that it no longer tells the availability of UI modules.
(Marc-André Lureau)
- Link to v1:
https://lore.kernel.org/r/20231214-help-v1-1-23823ac5a...@daynix.com
---
include/ui/console.h | 1 -
system/vl.c | 11 ++++++-----
ui/console.c | 21 ---------------------
3 files changed, 6 insertions(+), 27 deletions(-)
