the links posted on the
ideas page and the source code on github.
I also had some ideas related to it and wanted to discuss those with you.
Please let me know how you are planning to proceed with it and the
technical skills required for the same.
Thanks!
Ashijeet Acharya
From: Ashijeet
Replaced connect()/listen()/parse_host_port() in net/socket.c with
inet_connect()/inet_listen/inet_parse() in include/qemu/sockets.h.
Signed-off-by: Ashijeet Acharya
---
net/socket.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/net
Changed the listen(),connect(),parse_host_port() in net/socket.c with the
socket_*()functions in include/qemu/sockets.h.
Signed-off-by: Ashijeet Acharya
---
net/socket.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/net/socket.c b
On Tuesday 31 May 2016 08:31 PM, Paolo Bonzini wrote:
On 31/05/2016 11:27, Ashijeet Acharya wrote:
Changed the listen(),connect(),parse_host_port() in net/socket.c with the
socket_*()functions in include/qemu/sockets.h.
Signed-off-by: Ashijeet Acharya
---
net/socket.c | 38
socket_address_to_string() in util/qemu-sockets.c which returns
the string representation of socket address. The task was listed on
http://wiki.qemu.org/BiteSizedTasks page.
Signed-off-by: Ashijeet Acharya
---
include/qemu/sockets.h | 16 ++-
net/socket.c | 56
socket_address_to_string() in util/qemu-sockets.c which returns
the string representation of socket address. Thetask was listed on
http://wiki.qemu.org/BiteSizedTasks page.
Signed-off-by: Ashijeet Acharya
---
include/qemu/sockets.h | 16 ++-
net/socket.c | 55
On Tue, Jun 21, 2016 at 7:19 AM, Jason Wang wrote:
>
>
> On 2016年06月20日 23:09, Peter Maydell wrote:
>>
>> On 20 June 2016 at 15:55, Paolo Bonzini wrote:
>>>
>>>
>>> On 18/06/2016 09:54, Ashijeet Acharya wrote:
>>>>
>>>> Use
Changed the listen(),connect(),parse_host_port() in net/socket.c with the
socket_*()functions in include/qemu/sockets.h.
Signed-off-by: Ashijeet Acharya
---
net/socket.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/net/socket.c b
r" easily.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Max Reitz
Reviewed-by: Kevin Wolf
---
block/ssh.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 5ce12b6..75cb7bc 100644
--- a/block/ssh.c
+++ b/block/ssh.
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
support blockdev-add for SSH network protocol driver. Use only 'struct
InetSocketAddress' since SSH only supports connection over TCP.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Kevin Wolf
---
qapi/
Drop the use of legacy options in favour of the InetSocketAddress
options.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Max Reitz
Reviewed-by: Kevin Wolf
---
block/ssh.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index d814006
Add InetSocketAddress compatibility to SSH driver.
Add a new option "server" to the SSH block driver which then accepts
a InetSocketAddress.
"host" and "port" are supported as legacy options and are mapped to
their InetSocketAddress representation.
Signed-off-by
in v2:
- Use strstart() instead of strcmp() (Kevin)
- Use qobject_input_visitor_new_autocast() instead of
qmp_input_visitor_new() and change header files accordingly (Kevin)
- Use inet_connect_saddr() instead of inet_connect() (Kevin)
- Drop the contruction of : string (Kevin)
- Fix the bug in ssh_pro
Make inet_connect_saddr() in util/qemu-sockets.c public in order to be
able to use it with InetSocketAddress sockets outside of
util/qemu-sockets.c independently.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Kevin Wolf
---
include/qemu/sockets.h | 2 ++
util/qemu-sockets.c| 4 ++--
2 files
On Wed, Oct 26, 2016 at 3:19 PM, Kevin Wolf wrote:
> Am 25.10.2016 um 23:16 hat Eric Blake geschrieben:
>> On 10/24/2016 02:27 PM, Ashijeet Acharya wrote:
>> > Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
>> > support blockdev-add for N
parameters
- change the names of query parameters in JSON
Changes in v2:
- drop strcmp() condition check for host and path in nfs_parse_uri()
- drop "export" completely
- initialize client->context bedore setting query parameters
- fix the QDict options being passed to nfs_client_ope
Make NFS block driver use various fine grained runtime_opts.
Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
the URI.
Signed-off-by: Ashijeet Acharya
---
block/nfs.c | 331
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
support blockdev-add for NFS network protocol driver. Also make a new
struct NFSServer to support tcp connection.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core
k for host and path in nfs_parse_uri()
- drop "export" completely
- initialize client->context bedore setting query parameters
- fix the QDict options being passed to nfs_client_open() and make use of url
Ashijeet Acharya (2):
block/nfs: Introduce runti
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
support blockdev-add for NFS network protocol driver. Also make a new
struct NFSServer to support tcp connection.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core
t" is supported as a legacy option and is mapped to its NFSServer
representation.
Signed-off-by: Ashijeet Acharya
---
block/nfs.c | 457 +++-
1 file changed, 364 insertions(+), 93 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
in
pletely
- initialize client->context bedore setting query parameters
- fix the QDict options being passed to nfs_client_open() and make use of url
Ashijeet Acharya (2):
block/nfs: Introduce runtime_opts in NFS
qapi: allow blockdev-add for NFS
block/nfs.c | 430 +++
t" is supported as a legacy option and is mapped to its NFSServer
representation.
Signed-off-by: Ashijeet Acharya
---
block/nfs.c | 430 +++-
1 file changed, 337 insertions(+), 93 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
in
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
support blockdev-add for NFS network protocol driver. Also make a new
struct NFSServer to support tcp connection.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core
ned-off-by: Ashijeet Acharya
---
block/nfs.c | 442 +++-
1 file changed, 349 insertions(+), 93 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
index c3db2ec..487d798 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -35,8 +35,15 @@
#include &
ompletely
- initialize client->context bedore setting query parameters
- fix the QDict options being passed to nfs_client_open() and make use of url
Ashijeet Acharya (2):
block/nfs: Introduce runtime_opts in NFS
qapi: allow blockdev-add for NFS
block/nfs.c | 442 +
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
support blockdev-add for NFS network protocol driver. Also make a new
struct NFSServer to support tcp connection.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core
This patch drops the unused parameter "BDRVSSHState" being passed into
the ssh_config() function and fixes the bug.
Signed-off-by: Ashijeet Acharya
---
block/ssh.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index ca071c5..15ed
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it.
Signed-off-by: Ashijeet Acharya
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd.c b/block/nbd.c
index 8ef1438..ff9d01a 100644
--- a/block/nbd.c
+++ b/block/nbd.c
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Eric Blake
---
Changes in v2:
- Include the regression commit id in the commit message
---
block/nbd.c | 1
On Wed, Nov 2, 2016 at 4:00 PM, Kevin Wolf wrote:
> Am 02.11.2016 um 10:48 hat Ashijeet Acharya geschrieben:
>> This patch frees the leaked visitor in nbd_refresh_filename() and uses
>> visit_free() to fix it. The leak was introduced by the commit 491d6c7.
>>
>> Sign
On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf wrote:
> Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben:
>> This patch drops the unused parameter "BDRVSSHState" being passed into
>> the ssh_config() function and fixes the bug.
>>
>> Signed-off-by: Ashij
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Eric Blake
---
Changes in v3:
- Modify the Subject line
- Free the visitor immediately after visit_complete
This patch drops the unused parameter "BDRVSSHState" being passed into
the ssh_config() function and does code cleanup. The unused parameter
was introduced by the commit c322712.
Signed-off-by: Ashijeet Acharya
---
Changes in v2:
- Modify the commit message and subject line
---
block
I am still waiting for review on this one.
On Tue, Aug 16, 2016 at 10:40 PM, Ashijeet Acharya
wrote:
> Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add
> idebus_unrealize() in hw/ide/qdev.c to have calls to
> qemu_del_vm_change_state_handler() to deal with the
On Thu, Sep 1, 2016 at 9:13 PM, Paolo Bonzini wrote:
> On 01/09/2016 07:31, Ashijeet Acharya wrote:
>> I am still waiting for review on this one.
>
> Hi,
>
> QEMU is in hard freeze now so it's normal to have some delay in patch
> review. Maintainers often use t
Include migrate_set_speed and migrate_set_downtime inside
migrate_set_parameters respectively for setting maximum migration speed and
expected downtime parameters. Also add the query part for both in qmp and hmp
qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
hmp-commands.hx
On Mon, Sep 5, 2016 at 1:31 PM, Paolo Bonzini wrote:
>
>
> On 05/09/2016 09:45, Ashijeet Acharya wrote:
>> Include migrate_set_speed and migrate_set_downtime inside
>> migrate_set_parameters respectively for setting maximum migration
>> speed and expected downtime par
On Mon, Sep 5, 2016 at 1:46 PM, Paolo Bonzini wrote:
>
>
> On 05/09/2016 10:11, Ashijeet Acharya wrote:
>> > > Include migrate_set_speed and migrate_set_downtime inside
>> > > migrate_set_parameters respectively for setting maximum migration
>> > > spe
Include migrate_set_speed and migrate_set_downtime inside
migrate_set_parameters for setting maximum migration speed and expected
downtime parameters respectively. Also update the query part for both in qmp
and hmp qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
hmp-commands.hx
On Mon, Sep 5, 2016 at 5:15 PM, Paolo Bonzini wrote:
>
>
> On 05/09/2016 13:37, Ashijeet Acharya wrote:
>> Include migrate_set_speed and migrate_set_downtime inside
>> migrate_set_parameters for setting maximum migration speed and expected
>> downtime parameters re
On Mon, Sep 5, 2016 at 5:31 PM, Paolo Bonzini wrote:
>
>
> On 05/09/2016 13:59, Ashijeet Acharya wrote:
>>>> >> +if (has_migrate_set_speed) {
>>>> >> +qmp_migrate_set_speed(migrate_set_speed, NULL);
>>>
On Mon, Sep 5, 2016 at 5:15 PM, Paolo Bonzini wrote:
>
>
> On 05/09/2016 13:37, Ashijeet Acharya wrote:
>> Include migrate_set_speed and migrate_set_downtime inside
>> migrate_set_parameters for setting maximum migration speed and expected
>> downtime parameters re
Include migrate_set_speed and migrate_set_downtime inside
migrate_set_parameters for setting maximum migration speed and expected
downtime parameters respectively. Also update the query part for both in qmp
and hmp qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
hmp.c
qmp_migrate_set_downtime() as wrappers on qmp_migrate_set_parameters().
Signed-off-by: Ashijeet Acharya
---
hmp.c | 33
include/migration/migration.h | 1 -
migration/migration.c | 116 --
qapi-schema.json | 26
On Mon, Sep 5, 2016 at 8:06 PM, Daniel P. Berrange wrote:
> On Mon, Sep 05, 2016 at 07:56:26PM +0530, Ashijeet Acharya wrote:
>> Include migrate_set_speed and migrate_set_downtime inside
>> migrate_set_parameters for setting maximum migration speed and expected
>>
On Mon, Sep 5, 2016 at 9:09 PM, Daniel P. Berrange wrote:
> On Mon, Sep 05, 2016 at 08:44:26PM +0530, Ashijeet Acharya wrote:
>> On Mon, Sep 5, 2016 at 8:06 PM, Daniel P. Berrange
>> wrote:
>> > On Mon, Sep 05, 2016 at 07:56:26PM +0530, Ashijeet Acharya wrote:
&
qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
hmp-commands.hx | 8 +--
hmp.c | 29 +-
include/migration/migration.h | 1 -
migration/migration.c | 122 +++---
qapi-schema.json
On Mon, Sep 5, 2016 at 11:26 PM, Daniel P. Berrange wrote:
> On Mon, Sep 05, 2016 at 11:20:11PM +0530, Ashijeet Acharya wrote:
>> Mark old-commands for speed and downtime as deprecated.
>> Move max-bandwidth and downtime-limit into migrate-set-parameters for
>> setting maximu
On Mon, Sep 5, 2016 at 11:37 PM, Ashijeet Acharya
wrote:
> On Mon, Sep 5, 2016 at 11:26 PM, Daniel P. Berrange
> wrote:
>> On Mon, Sep 05, 2016 at 11:20:11PM +0530, Ashijeet Acharya wrote:
>>> Mark old-commands for speed and downtime as deprecated.
>>> Move max-ban
in both hmp and qmp qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
hmp.c | 27 ++
include/migration/migration.h | 1 -
migration/migration.c | 120 --
qapi-schema.json | 33
On Tue, Sep 6, 2016 at 4:32 PM, Dr. David Alan Gilbert
wrote:
> * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote:
>> Mark old-commands for speed and downtime as deprecated.
>> Move max-bandwidth and downtime-limit into migrate-set-parameters for
>> setting maximum migrati
On Tue, Sep 6, 2016 at 6:52 PM, Ashijeet Acharya
wrote:
> On Tue, Sep 6, 2016 at 4:32 PM, Dr. David Alan Gilbert
> wrote:
>> * Ashijeet Acharya (ashijeetacha...@gmail.com) wrote:
>>> Mark old-commands for speed and downtime as deprecated.
>>> Move max-bandwidth a
in both hmp and qmp qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
hmp.c | 26 ++
include/migration/migration.h | 1 -
migration/migration.c | 116 --
qapi-schema.json | 33
On Wed, Sep 7, 2016 at 2:11 PM, Juan Quintela wrote:
> Ashijeet Acharya wrote:
>> Mark old-commands for speed and downtime as deprecated.
>> Move max-bandwidth and downtime-limit into migrate-set-parameters for
>> setting maximum migration speed and expected down
On Thu, Sep 8, 2016 at 3:33 AM, Eric Blake wrote:
> On 09/06/2016 08:39 AM, Ashijeet Acharya wrote:
>> Mark old-commands for speed and downtime as deprecated.
>> Move max-bandwidth and downtime-limit into migrate-set-parameters for
>> setting maximum migration speed and ex
On Thu, Sep 8, 2016 at 8:11 PM, Juan Quintela wrote:
> Eric Blake wrote:
>
>>> +if (has_max_bandwidth) {
>>> +s->parameters.max_bandwidth = max_bandwidth;
>>> +if (s->to_dst_file) {
>>> +qemu_file_set_rate_limit(s->to_dst_file,
>>> +
in both hmp and qmp qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
hmp.c | 26 ++
include/migration/migration.h | 1 -
migration/migration.c | 116 --
qapi-schema.json | 33
On Fri, Sep 9, 2016 at 12:02 AM, Eric Blake wrote:
> On 09/08/2016 10:59 AM, Ashijeet Acharya wrote:
>
> Long subject line; we strive to stay below 70 bytes so that you can
> prepend commit ids and still stay in an 80-column window. Also, you can
> look at 'git shortlog -3
On Fri, Sep 9, 2016 at 8:41 AM, Eric Blake wrote:
> On 09/08/2016 10:59 AM, Ashijeet Acharya wrote:
>> Mark old-commands for speed and downtime as deprecated.
>> Move max-bandwidth and downtime-limit into migrate-set-parameters for
>> setting maximum migration speed and ex
in both hmp and qmp qemu control interfaces.
NOTE: This patch is solely based on Eric's new boxed parameters from QAPI
patch series.
Signed-off-by: Ashijeet Acharya
---
Changes in v5:
- Include units in the output of 'info migrte_parameters'
- Change 'old-commands' to &
.
Signed-off-by: Ashijeet Acharya
---
migration/migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 9b4aa55..cd8334c 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -805,6 +805,7 @@ void qmp_migrate_set_parameters
, parameters were getting set to
out-of-bounds values despite the error.
Signed-off-by: Ashijeet Acharya
---
migration/migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 9b4aa55..cd8334c 100644
--- a/migration/migration.c
+++ b
On Sat, Sep 10, 2016 at 2:03 AM, Ashijeet Acharya
wrote:
> This patch fixes the out-of-bounds check of migration parameters in
> qmp_migrate_set_parameters() for cpu-throttle-initial and
> cpu-throttle-increment by adding a return statement for both as they
> were broken since their
, parameters were getting set to
out-of-bounds values despite the error.
Signed-off-by: Ashijeet Acharya
---
migration/migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 9b4aa55..cd8334c 100644
--- a/migration/migration.c
+++ b
, parameters were getting set to
out-of-bounds values despite the error.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Eric Blake
---
Changes in v4:
-Fix the typo in commit message
-Include the commit id which caused the regression
---
migration/migration.c | 2 ++
1 file changed, 2 insertions
Hi Dave,
I have added the compatibility of this option for both command line
and hotplug via qmp and hmp. Although, please confirm that making use
of "device_add" is the only way of hotplugging devices into a QEMU
instance.
With this sorted out, there is one special case left where the device
dyn
On Wed, Sep 14, 2016 at 12:52 AM, Eric Blake wrote:
> On 09/09/2016 02:02 PM, Ashijeet Acharya wrote:
>> Mark old-commands for speed and downtime as deprecated.
>
> Maybe s/old-commands for speed and downtime/the old commands
> 'migrate_set_speed' and 'mig
On Wed, Sep 14, 2016 at 7:28 PM, Eric Blake wrote:
> On 09/14/2016 03:05 AM, Ashijeet Acharya wrote:
>
>>>> +if (params->has_max_bandwidth &&
>>>> +(params->max_bandwidth < 0 || params->max_bandwidth > SIZE_MAX)) {
>&g
>> +++ b/migration/migration.c
>> @@ -44,6 +44,10 @@
>> #define BUFFER_DELAY 100
>> #define XFER_LIMIT_RATIO (1000 / BUFFER_DELAY)
>>
>> +/* Time in nanoseconds we are allowed to stop the source,
>> + * for sending the last part */
>> +#define DEFAULT_MIGRATE_SET_DOWNTIME 3
>> +
>
> I
only for new-command) and set
its upper bound limit to 2000 seconds.
Update the query part in both hmp and qmp qemu control interfaces.
Signed-off-by: Ashijeet Acharya
---
Changes in v6
-Improve the commit message
-Mention new upper limit of downtime in commit message
-Drop the use of
On Thu, Sep 15, 2016 at 9:18 PM, Eric Blake wrote:
> On 09/14/2016 12:40 PM, Ashijeet Acharya wrote:
>> Mark the old commands 'migrate_set_speed' and 'migrate_set_downtime' as
>> deprecated.
>> Move max-bandwidth and downtime-limit into migrate-set-pa
only for new-command) and set
its upper bound limit to 2000 seconds.
Update the query part in both hmp and qmp qemu control interfaces.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Eric Blake
---
Changes in v7
- Fix the error message for bounds check of max-bandwidth
---
hmp.c
Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add
idebus_unrealize() in hw/ide/qdev.c to have calls to
qemu_del_vm_change_state_handler() to deal with the dangling change
state handler during hot-unplugging ide devices which might lead to a
crash.
Signed-off-by: Ashijeet
On Mon, Feb 13, 2017 at 11:34 PM, Ashijeet Acharya
wrote:
> Commit a3a3d8c7 introduced a segfault bug while checking for
> 'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add
> devices which do no set their 'dc->vmsd' yet while initializa
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
support blockdev-add for SSH network protocol driver. Use only 'struct
InetSocketAddress' since SSH only supports connection over TCP.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core.json | 24 +++
On Sat, Oct 8, 2016 at 4:24 PM, Richard W.M. Jones wrote:
> On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote:
>> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
>> support blockdev-add for SSH network protocol driver. Use only &#x
Hi all,
I was working on trying to add blockdev-add compatibility for the nfs
block driver but before that runtime options need to be separated into
various options rather than just a simple "filename" option.
I have added the following until now:
a) host
b) port (not sure about this one, do we j
On Mon, Oct 10, 2016 at 2:45 PM, Kevin Wolf wrote:
> Am 08.10.2016 um 12:44 hat Ashijeet Acharya geschrieben:
>> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
>> support blockdev-add for SSH network protocol driver. Use only 'struct
>&g
On Mon, Oct 10, 2016 at 5:01 PM, Kevin Wolf wrote:
> Am 10.10.2016 um 12:48 hat Ashijeet Acharya geschrieben:
>> On Mon, Oct 10, 2016 at 2:45 PM, Kevin Wolf wrote:
>> > Am 08.10.2016 um 12:44 hat Ashijeet Acharya geschrieben:
>> >> +{ 'struct': 'Bl
On Mon, Oct 10, 2016 at 6:23 PM, Kevin Wolf wrote:
> Am 10.10.2016 um 13:54 hat Ashijeet Acharya geschrieben:
>> On Mon, Oct 10, 2016 at 5:01 PM, Kevin Wolf wrote:
>> > Your .bdrv_open() callback in ssh gets these options as keys in
>> > QDict *options, using the dot
driver
by making the SSH option available.
*** This series depends on the following patch: ***
"qdict: implement a qdict_crumple method for un-flattening a dict"
from Daniel's "QAPI/QOM work for non-scalar object properties"
series.
Ashijeet Acharya (4):
block/ssh: Add
Drop the use of legacy options in favour of the InetSocketAddress
options.
Signed-off-by: Ashijeet Acharya
---
block/ssh.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 702871a..399ed60 100644
--- a/block/ssh.c
+++ b/block/ssh.c
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
support blockdev-add for SSH network protocol driver. Use only 'struct
InetSocketAddress' since SSH only supports connection over TCP.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core.json | 24 +++
Add InetSocketAddress compatibility to SSH driver.
Add a new option "server" to the SSH block driver which then accepts
a InetSocketAddress.
"host" and "port" are supported as legacy options and are mapped to
their InetSocketAddress representation.
Signed-off-by
r" easily.
Signed-off-by: Ashijeet Acharya
---
block/ssh.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 5ce12b6..75cb7bc 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -254,15 +254,30 @@ static int parse_uri(const c
On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya
wrote:
> This series adds blockdev-add support for SSH block driver.
>
> Patch 1 prepares the code for the addition of a new option prefix,
> which is "server.". This is accomplished by adding a
> ssh_has_filename_options_
On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote:
> Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben:
> Of course, we must be able to build qemu correctly both with ssh enabled
> and disabled, so if you can indeed see a (different) build error with
> disabled libssh2, that
> I received a mail saying my series failed the automatic build test but
> it builds completely fine (after applying Dan's patch obviously) in my
> local environment.
>
> Going through the config output of the test script, I see that the
> supporting library for SSH which is "libssh2" seems to be d
On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote:
> Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben:
>> This series adds blockdev-add support for SSH block driver.
>>
>> Patch 1 prepares the code for the addition of a new option prefix,
>> which is "s
On Wed, Oct 12, 2016 at 9:21 PM, Kevin Wolf wrote:
> Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben:
>> Add InetSocketAddress compatibility to SSH driver.
>>
>> Add a new option "server" to the SSH block driver which then accepts
>> a InetSocke
On Wed, Oct 12, 2016 at 10:10 PM, Kevin Wolf wrote:
> Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben:
>> On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote:
>> > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben:
>> >> This series adds blockdev-ad
On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya
wrote:
> Add InetSocketAddress compatibility to SSH driver.
>
> Add a new option "server" to the SSH block driver which then accepts
> a InetSocketAddress.
>
> "host" and "port" are suppo
On Thu, Oct 13, 2016 at 5:12 PM, Kevin Wolf wrote:
> Am 28.09.2016 um 22:55 hat Max Reitz geschrieben:
>> Add a new option "address" to the NBD block driver which accepts a
>> SocketAddress.
>>
>> "path", "host" and "port" are still supported as legacy options and are
>> mapped to their correspond
bject_input_visitor_new_autocast() instead of
qmp_input_visitor_new() and change header files accordingly (Kevin)
- Use inet_connect_saddr() instead of inet_connect() (Kevin)
- Drop the contruction of : string (Kevin)
- Fix the bug in ssh_process_legacy_socket_options()
Ashijeet Acharya (5):
b
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
support blockdev-add for SSH network protocol driver. Use only 'struct
InetSocketAddress' since SSH only supports connection over TCP.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core.json | 24 +++
Add InetSocketAddress compatibility to SSH driver.
Add a new option "server" to the SSH block driver which then accepts
a InetSocketAddress.
"host" and "port" are supported as legacy options and are mapped to
their InetSocketAddress representation.
Signed-off-by
r" easily.
Signed-off-by: Ashijeet Acharya
---
block/ssh.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 5ce12b6..75cb7bc 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -254,15 +254,30 @@ static int parse_uri(const c
Make inet_connect_saddr() in util/qemu-socktets.c public and use it
instead of inet_connect() because this directly takes the
InetSocketAddress to establish a socket connection for the SSH
block driver.
Signed-off-by: Ashijeet Acharya
---
block/ssh.c| 5 +
include/qemu/sockets.h
Drop the use of legacy options in favour of the InetSocketAddress
options.
Signed-off-by: Ashijeet Acharya
---
block/ssh.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 6420359..7fec0e1 100644
--- a/block/ssh.c
+++ b/block/ssh.c
1 - 100 of 330 matches
Mail list logo
