On Mon, Sep 5, 2016 at 5:15 PM, Paolo Bonzini <pbonz...@redhat.com> wrote:
>
>
> On 05/09/2016 13:37, Ashijeet Acharya wrote:
>> Include migrate_set_speed and migrate_set_downtime inside
>> migrate_set_parameters for setting maximum migration speed and expected
>> downtime parameters respectively. Also update the query part for both in qmp
>> and hmp qemu control interfaces.
>>
>> Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com>
>> ---
>> hmp-commands.hx | 6 +++---
>> hmp.c | 30 +++++++++++++++++++++++++++++-
>> include/migration/migration.h | 1 -
>> migration/migration.c | 30 ++++++++++++++++++++++++++----
>> qapi-schema.json | 26 +++++++++++++++++++++++---
>> qmp-commands.hx | 13 ++++++++++---
>> 6 files changed, 91 insertions(+), 15 deletions(-)
>> Example:
>> @@ -3803,7 +3805,7 @@ EQMP
>> {
>> .name = "migrate-set-parameters",
>> .args_type =
>> -
>> "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?",
>> +
>> "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?,migrate-set-speed:o?,migrate-set-downtime:T?",
>
> Same here about the names. Also use "i" for QMP commands.
I think we will have to use "T" for downtime at-least otherwise you
cant use float values for setting seconds like "0.2" for example.
No issues using "i" with bandwidth though.
Ashijeet
