Public bug reported:
In some cases the ldp instruction (and presumably other multi-register
loads and stores) can behave incorrectly.
Given the following instruction:
ldp x0, x1, [x0]
This will load two 64 bit values from memory, however if each location
to load is on a different page and the se
Yes, D1.13.4 is what I want, I'm not completely familiar with this part
of the document.
Based on my reading of gen_load_exclusive I agree that it looks correct,
and loading to a float/vector won't affect the address generation.
I have worked around this in FreeBSD my switching the order of the
r
From: Andrew Oates
On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
read from. On macOS, however, the socket acts like a SOCK_RAW socket
and includes the IP header as well.
This change strips the extra IP header from the received packet on macOS
before sending it to the
From: Andrew Oates
The current implementation has three bugs,
* segment limits are not enforced in protected mode if the L bit is set
in the target segment descriptor[1]
* segment limits are not enforced in compatability mode (ljmp to 32-bit
code segment in long mode)
* #GP(new_cs) is
From: Andrew Oates
Currently call gates are always treated as 32-bit gates. In IA-32e mode
(either compatibility or 64-bit submode), system segment descriptors are
always 64-bit. Treating them as 32-bit has the expected unfortunate
effect: only the lower 32 bits of the offset are loaded, the
That patch seems to have fixed the issue. I don't get the segfault I was
previously getting without the patch.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1713066
Title:
Incorrect handling of aar
From: Andrew Melnychenko
https://bugzilla.redhat.com/show_bug.cgi?id=1737400
Fixed setting max_queue_num if there are no peers in NICConf. qemu_new_nic()
creates NICState with 1 NetClientState(index 0) without peers, set
max_queue_num to 0 - It prevents undefined behavior and possible crashes
From: Andrew Melnychenko
Fixes: 6f3fbe4ed06
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1737400
Fixed setting max_queue_num if there are no peers in NICConf. qemu_new_nic()
creates NICState with 1 NetClientState(index 0) without peers, set
max_queue_num to 0 - It prevents undefined
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1707441
Added ICR clearing if there is IMS bit - according to the note by
section 13.3.27 of the 8257X developers manual.
Signed-off-by: Andrew Melnychenko
---
hw/net/e1000e_core.c | 9 +
hw/net/trace-events
From: Andrew
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065
With network backend with 'virtual header' - there was an issue
in 'plen' field. Overall, during TSO, 'plen' would be changed,
but with 'vheader' this field should be set to the
From: Andrew
The basic IPv6 fragmentation - adding 'frag' extension to
the packet, overall shares some logic with IPv4. It works,
but there are still issues with a combination of
extensions - in the future, it would require refactoring
work to implement workflow with IPv6 and extensi
From: Andrew Melnychenko
There is an issue, that netdev can't be removed if it was added using hmp.
The bug appears after 08712fcb851034228b61f75bd922863a984a4f60 commit.
It happens because of unclear QemuOpts that was created during
hmp_netdev_add(), now it uses qmp analog fun
From: Andrew
Removed hardcoded offset for ats. Added cap offset counter
for future capabilities like AER.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index
From: Andrew
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1857668
Added AER capability for virtio-pci devices.
Also added property for devices, by default AER is enabled.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 16
hw/virtio/virtio-pci.h | 4
From: Andrew
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065
Overall, there was an issue that big frames of IPv6 doesn't sent.
With network backend with 'virtual header' - there was an issue
in 'plen' field. Overall, during TSO, 'plen' would be cha
From: Andrew
Added fix for checksum offload for IPv6 if a backend doesn't
have a virtual header.
This patch is a part of IPv6 fragmentation.
Signed-off-by: Andrew Melnychenko
---
hw/net/net_tx_pkt.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/h
From: Andrew Melnychenko
Main motivation:
According to Microsoft driver\device certification requirements
for next version of Window Server, PCIe device must support AER.
"Windows Server PCI Express devices are required to support
Advanced Error Reporting [AER] as defined in
PCI Express
From: Andrew
Removed hardcoded offset for ats. Added cap offset counter
for future capabilities like AER.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index
From: Andrew
Added AER capability for virtio-pci devices.
Also added property for devices, by default AER is disabled.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 16
hw/virtio/virtio-pci.h | 4
2 files changed, 20 insertions(+)
diff --git a/hw
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065
e1000e driver doesn't sets 'plen' field for IPv6 for big packets
if TSO is enabled. Jumbo option isn't added yet, until
qemu supports packets greater than 64K.
Signed-off-by: Andrew Meln
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065
e1000e driver doesn't sets 'plen' field for IPv6 for big packets
if TSO is enabled. Jumbo option isn't added yet, until
qemu supports packets greater than 64K.
Signed-off-by: Andrew Meln
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1707441
Added ICR clearing if there is IMS bit - according to the note by
section 13.3.27 of the 8257X developers manual.
Signed-off-by: Andrew Melnychenko
---
hw/net/e1000e_core.c | 9 +
hw/net/trace-events
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065
Overall, there was an issue that big frames of IPv6 doesn't sent.
With network backend with 'virtual header' - there was an issue
in 'plen' field. Overall, during TSO, 'plen'
From: Andrew Melnychenko
Compare to previous patch - fixed issue with compilation in docker fedora test.
Andrew Melnychenko (1):
hw/net: Added basic IPv6 fragmentation. Fixed IPv6 payload length.
Fixed CSO for IPv6.
hw/net/net_tx_pkt.c | 54 ---
hw/net
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1708065
Overall, there was an issue that big frames of IPv6 doesn't sent.
With network backend with 'virtual header' - there was an issue
in 'plen' field. Overall, during TSO, 'plen'
From: Andrew Melnychenko
Added E1000_ICR_ASSERTED check.
Andrew Melnychenko (1):
e1000e: Added ICR clearing by corresponding IMS bit.
hw/net/e1000e_core.c | 9 +
hw/net/trace-events | 1 +
2 files changed, 10 insertions(+)
--
2.26.2
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1707441
Added ICR clearing if there is IMS bit - according to the note by
section 13.3.27 of the 8257X developers manual.
Signed-off-by: Andrew Melnychenko
---
hw/net/e1000e_core.c | 9 +
hw/net/trace-events
From: Andrew Melnychenko
Added E1000_ICR_ASSERTED check.
Andrew Melnychenko (1):
e1000e: Added ICR clearing by corresponding IMS bit.
hw/net/e1000e_core.c | 10 ++
hw/net/trace-events | 1 +
2 files changed, 11 insertions(+)
--
2.26.2
From: Andrew Melnychenko
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1707441
Added ICR clearing if there is IMS bit - according to the note by
section 13.3.27 of the 8257X developers manual.
Signed-off-by: Andrew Melnychenko
---
hw/net/e1000e_core.c | 10 ++
hw/net/trace
From: Andrew Melnychenko
Now, AER capability for virtio-pci is disabled by default.
AER capability is only for PCI with PCIe interface on PCIe bus.
During migration - device "realize" should initialize AER
if requested by device properties.
Andrew (2):
hw/virtio-pci Added counte
From: Andrew
Removed hardcoded offset for ats. Added cap offset counter
for future capabilities like AER.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index
From: Andrew
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1857668
Added AER capability for virtio-pci devices.
Also added property for devices, by default AER is enabled.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 16
hw/virtio/virtio-pci.h | 4
From: Andrew Melnychenko
Now, AER capability for virtio-pci is disabled by default.
AER capability is only for PCI with PCIe interface on PCIe bus.
During migration - device "realize" should initialize AER
if requested by device properties.
Also fixed commit message and added prop
From: Andrew
Removed hardcoded offset for ats. Added cap offset counter
for future capabilities like AER.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index
From: Andrew
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1878465
Added AER capability for virtio-pci devices.
Also added property for devices, by default AER is disabled.
Signed-off-by: Andrew Melnychenko
---
hw/virtio/virtio-pci.c | 16
hw/virtio/virtio-pci.h | 4
From: Andrew Melnychenko
There is an issue when callback may be called with invalid vdev.
It happens on unplug when vdev already deleted and VirtIOPciProxy is not.
So now, callbacks accept proxy device, and vdev retrieved from it.
Technically memio callbacks should be removed during the flatview
On Wed, Aug 08, 2012 at 10:43:01AM +0800, Wen Congyang wrote:
> diff --git a/Documentation/virtual/kvm/pv_event.txt
> b/Documentation/virtual/kvm/pv_event.txt
> new file mode 100644
> index 000..0ebc890
> --- /dev/null
> +++ b/Documentation/virtual/kvm/pv_event.txt
> @@ -0,0 +1,32 @@
> +The KV
- Original Message -
> On Tue, Dec 4, 2012 at 4:10 AM, Andrew Jones
> wrote:
> >
> >
> > - Original Message -
> >> On Thu, Nov 29, 2012 at 1:34 AM, liu ping fan
> >> wrote:
> >> > On Thu, Nov 29, 2012 at 12:42 PM, Cam Macd
e running the
shadowed copy from memory provided by the SeaBIOS for compatibility.
Thanks,
Andrew
>> (From §4.1 System Address Map):
>>
>> 2. High BIOS Area (FFE0_h−− _h)
>> The top 2 Mbytes of the Extended Memory Region is reserved for System
>>
On Fri, 21 Sep 2012 11:46:18 +0100
Mel Gorman wrote:
> Changelog since V2
> o Fix BUG_ON triggered due to pages left on cc.migratepages
> o Make compact_zone_order() require non-NULL arg `contended'
>
> Changelog since V1
> o only abort the compaction if lock is contended or run too long
> o Rea
On Fri, 21 Sep 2012 11:46:22 +0100
Mel Gorman wrote:
> When compaction was implemented it was known that scanning could potentially
> be excessive. The ideal was that a counter be maintained for each pageblock
> but maintaining this information would incur a severe penalty due to a
> shared writa
On Fri, 21 Sep 2012 11:46:20 +0100
Mel Gorman wrote:
> Compactions free scanner acquires the zone->lock when checking for PageBuddy
> pages and isolating them. It does this even if there are no PageBuddy pages
> in the range.
>
> This patch defers acquiring the zone lock for as long as possible.
On Mon, 24 Sep 2012 10:39:38 +0100
Mel Gorman wrote:
> On Fri, Sep 21, 2012 at 02:36:56PM -0700, Andrew Morton wrote:
>
> > Also, what has to be done to avoid the polling altogether? eg/ie, zap
> > a pageblock's PB_migrate_skip synchronously, when something was done to
&
On Tue, 25 Sep 2012 10:12:07 +0100
Mel Gorman wrote:
> First, we'd introduce a variant of get_pageblock_migratetype() that returns
> all the bits for the pageblock flags and then helpers to extract either the
> migratetype or the PG_migrate_skip. We already are incurring the cost of
> get_pageblo
On Tue, 25 Sep 2012 17:13:27 +0900
Minchan Kim wrote:
> I see. To me, your saying is better than current comment.
> I hope comment could be more explicit.
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index df01b4e..f1d2cc7 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -542,
- Original Message -
> On 03/05/13 22:08, Eric Blake wrote:
> > On 03/04/2013 03:19 PM, Laszlo Ersek wrote:
> >> Signed-off-by: Laszlo Ersek
> >> ---
> >
> >> +# @guest-set-vcpus:
> >> +#
> >> +# Attempt to reconfigure (currently: enable/disable) logical
> >> processors inside
> >> +# t
- Original Message -
> Set the guest numa nodes memory policies using the mbind(2)
> system call node by node.
> After this patch, we are able to set guest nodes memory policies
> through the QEMU options, this arms to solve the guest cross
> nodes memory access performance issue.
> And a
- Original Message -
> On 08/20/2013 09:41 PM, Andrew Jones wrote:
> >> +
> >> +/* This is a workaround for a long standing bug in Linux'
> >> + * mbind implementation, which cuts off the last specified
> >> + * node. To
qemu should check KVM_CAP_NR_VCPUS for
the recommended number of vcpus. This patch adds a warning if a user
specifies a number of cpus between the recommended and max.
Signed-off-by: Andrew Jones
---
kvm-all.c | 45 +++--
1 file changed, 27 insertions(+
- Original Message -
> Add detection of libnuma (mostly contained in the numactl package)
> to the configure script. Can be enabled or disabled on the command line,
> default is use if available.
>
> Signed-off-by: Andre Przywara
> Signed-off-by: Wanlong Gao
Is this patch still necess
- Original Message -
> Set the guest numa nodes memory policies using the mbind(2)
> system call node by node.
> After this patch, we are able to set guest nodes memory policies
> through the QEMU options, this arms to solve the guest cross
> nodes memory access performance issue.
> And a
- Original Message -
> Am 22.08.2013 18:12, schrieb Eduardo Habkost:
> >
> > On 22/08/2013, at 12:39, Andrew Jones wrote:
> >
> >> The comment in kvm_max_vcpus() states that it's using the recommended
> >> procedure from the kernel API docum
- Original Message -
> Il 22/08/2013 17:39, Andrew Jones ha scritto:
> > The comment in kvm_max_vcpus() states that it's using the recommended
> > procedure from the kernel API documentation to get the max number
> > of vcpus that kvm supports. It is, b
r
the fail case was slightly changed, 'exceeds max cpus' to
'exceeds the maximum cpus'. If this is unacceptable change for
users like libvirt, then I'll need to spin a v3.
Signed-off-by: Andrew Jones
---
kvm-all.c | 69 -
- Original Message -
> The memory policy setting format is like:
>
> policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N
> And we are adding this setting as a suboption of "-numa mem,",
> the memory policy then can be set like following:
> -numa node,node
- Original Message -
> On 08/23/2013 10:11 PM, Andrew Jones wrote:
> >
> >
> > - Original Message -
> >> The memory policy setting format is like:
> >>
> >> policy={default|membind|interleave|preferred}[,relative=true],host-
- Original Message -
> On 08/23/2013 04:40 PM, Andrew Jones wrote:
> >
> >
> > - Original Message -
> >> Add detection of libnuma (mostly contained in the numactl package)
> >> to the configure script. Can be enabled or disabled on t
- Original Message -
> Il 23/08/2013 13:33, Andrew Jones ha scritto:
> > Does smp_cpus map to the current
> > number of cpus, or to the number of possible cpus? If it maps to the number
> > of possible cpus, then this is the right place. If the former, then I gues
- Original Message -
> On 08/26/2013 03:46 PM, Andrew Jones wrote:
> >>> Is this patch still necessary? I thought that dropping the
> >>> > > numa_num_configured_nodes() calls from patch 8/12 got rid
> >>> > > of the need for this lib
- Original Message -
> On 08/23/2013 07:24 AM, Andrew Jones wrote:
> > The comment in kvm_max_vcpus() states that it's using the recommended
> > procedure from the kernel API documentation to get the max number
> > of vcpus that kvm supports. It is, b
- Original Message -
> On 08/28/2013 09:44 PM, Paolo Bonzini wrote:
> > Il 26/08/2013 10:43, Andrew Jones ha scritto:
> >>
> >> - Original Message -
> >>>> On 08/26/2013 03:46 PM, Andrew Jones wrote:
> >>>>>>
- Original Message -
>
>
> - Original Message -
> > On 08/28/2013 09:44 PM, Paolo Bonzini wrote:
> > > Il 26/08/2013 10:43, Andrew Jones ha scritto:
> > >>
> > >> - Original Message -
> > >>>> On 08/
Replace all the fprintf(stderr, ...) calls with error_report.
Signed-off-by: Andrew Jones
---
hw/misc/ivshmem.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index bf585b7691998..d285df7d65a9f 100644
--- a
On Thu, Sep 18, 2014 at 04:46:55PM -0600, Eric Blake wrote:
> On 09/18/2014 04:39 PM, Andrew Jones wrote:
> > Replace all the fprintf(stderr, ...) calls with error_report.
> >
> > Signed-off-by: Andrew Jones
> > ---
> > hw/misc/ivshmem.c | 27 +-
Replace all the fprintf(stderr, ...) calls with error_report.
Also make sure exit() consistently uses the error code 1. A few calls
used -1.
Signed-off-by: Andrew Jones
---
hw/misc/ivshmem.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff
..e6a7fbd 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
@@ -6,6 +6,7 @@
* Isaku Yamahata
* VA Linux Systems Japan K.K.
* Copyright (C) 2012 Jason Baron
+ * Copyright (C) 2014 Andrew Barnes IGD Support
*
* This is based on piix_pci.c, but heavily modified
thors:
* Alex Williamson
+ * Andrew Barnes IGD Support
*
* This work is licensed under the terms of the GNU GPL, version 2. See
* the COPYING file in the top-level directory.
@@ -56,6 +57,45 @@
#define VFIO_ALLOW_KVM_MSI 1
#define VFIO_ALLOW_KVM_MSIX 1
+/* A handy list of IGD device
d are the patches, incase this is a more usable format. They do also
include Alex Williamsons e820 patch, this is not mentioned in the following
patch emails.
Kind Regards,
Andrew Barnes
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 97932a6..18c72d2 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -
+ *2014 Andrew Barnes IGD Support
+ *Temporarily extended to provide host config read/write.
*
* Permission is hereby granted, free of charge, to any person obtaining a
copy
* of this software and associated documentation files (the "Software"),
to deal
@@ -37,9 +39,9 @@
#inc
@@
* Isaku Yamahata
* VA Linux Systems Japan K.K.
* Copyright (C) 2012 Jason Baron
+ * 2014 Andrew barnes IGD Support
*
* This is based on piix_pci.c, but heavily modified.
*
@@ -30,11 +31,26 @@
#include "hw/hw.h"
#include "hw/pci-host/q
Seabios patch
This patch covers all the changes to seabios. The intentions are to make
seabios behave like the hosts BIOS. and like the hosts BIOS, configure the
Q35 chipset more thoroughly.
This patch configures TOM, TOUUD, TOLUD, BDSM, BGSM, TSEG, IGD-OPREGION.
by writing new base addresses, V
-host/q35.h
@@ -4,6 +4,7 @@
* Copyright (c) 2009 Isaku Yamahata
*VA Linux Systems Japan K.K.
* Copyright (C) 2012 Jason Baron
+ * 2014 Andrew Baranes IGD Support
*
* This program is free software; you can redistribute it and/or modify
* it under the
include/hw/pci/pci_ids.h
A very last minute realisation is that this is not needed. Its purpose is
to make sure anything else that references LPC device ID is given the
hacked-in host's ID. but in verifying the patch validity it appears this
not referenced anywhere, other than where its taken care
include/hw/pci/pci.h
patch
-
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index c352c7b..d3bc224 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -338,6 +338,9 @@ typedef PCIINTxRoute (*pci_route_irq_fn)(void *opaque,
int pin);
#define PCI_BUS(obj)
On Mon, Sep 22, 2014 at 02:20:09PM +0300, Michael S. Tsirkin wrote:
> On Fri, Sep 19, 2014 at 04:42:59PM +0800, zhanghailiang wrote:
> > On 2014/9/19 15:34, zhanghailiang wrote:
> > >On 2014/9/19 7:17, Andrew Jones wrote:
> > >>Replace all the fprintf(stderr
Replace all the fprintf(stderr, ...) calls with error_report.
Also make sure exit() consistently uses the error code 1. A few calls
used -1. While at it cleanup some indentation in the printf argument
lists.
Signed-off-by: Andrew Jones
---
v3: fix indentation of printf argument lists [Hailiang
On Thu, Jun 19, 2014 at 06:07:40PM +0300, Nikolay Nikolaev wrote:
> Additional stubs:
> - chr_baum_init
> - qemu_chr_open_spice_vmc
> - qemu_chr_open_spice_port
>
> Signed-off-by: Nikolay Nikolaev
> ---
> stubs/Makefile.objs |2 ++
> stubs/chr-baum-init.c |7 +++
> s
written to
the disks several hours before the crash was corrupted, which makes me think
that it was never fsync()-ed to the non-volatile storage.
Is it safe in this setup to use cache=writeback? Or, should I use
cache=writethrough instead?
Thanks,
Andrew Martin
- Original Message -
> From: "Stefan Hajnoczi"
> To: "Andrew Martin"
> Cc: qemu-devel@nongnu.org
> Sent: Tuesday, August 19, 2014 9:59:25 AM
> Subject: Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later
>
> If you strace -f t
- Original Message -
> From: "Stefan Hajnoczi"
> To: "Andrew Martin"
> Cc: "qemu-devel"
> Sent: Thursday, August 21, 2014 7:59:50 AM
> Subject: Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later
>
> > When the di
- Original Message -
> From: "Paolo Bonzini"
> To: "Andrew Martin" , "Stefan Hajnoczi"
>
> Cc: "qemu-devel"
> Sent: Tuesday, August 26, 2014 2:03:18 AM
> Subject: Re: Using cache=writeback safely on qemu 1.4.0 and later
>
- Original Message -
> From: "Paolo Bonzini"
> To: "Andrew Martin"
> Cc: "Stefan Hajnoczi" , "qemu-devel"
>
> Sent: Wednesday, August 27, 2014 9:34:27 AM
> Subject: Re: Using cache=writeback safely on qemu 1.4.0 and later
>
Without the mask, control bits are passed on in the keycode, generating
incorrect PS/2 sequences when SHIFT, ALT, etc are held down.
Signed-off-by: Andrew Oates
---
ui/curses.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/curses.c b/ui/curses.c
index b044790
return;
>>> +} else {
>>> +if (add) {
>>> +xen_map_memory_section(xen_xc, xen_domid, state->ioservid,
>>> + section);
>>> +} else {
>>> +xen_unmap_memory_section(xen_xc, xen_domid, state->ioservid,
>>> + section);
>>> +}
>>> +}
>>> if (!memory_region_is_ram(section->mr)) {
>>> return;
>>> }
>>>
>>> -if (!(section->mr != &ram_memory
>>> - && ( (log_dirty && add) || (!log_dirty && !add {
>>> +if (!(log_dirty && add) && !(!log_dirty && !add)) {
>>> return;
>> if (!((log_dirty && add) || (!log_dirty && !add)))
>>
> I'm not sure which is better TBH.
I set simplification problems like this to my Part 1a digital
electronics supervisees.
This is "if (!(log_dirty ^ add))" as they are both booleans, and reads
rather more easily that either of the above.
~Andrew
timer inaccurate. Is this to be expected? Is there
something I can do to have the bh callback be scheduled immediately? Do I
have to rewrite the ptimer myself to get that functionality?
Also I'm interested in contributing the STM32 implementation upstream - is
this something that the qemu project is interested in?
Cheers,
Andrew
interested the Bottom handlers callbacks in ptimer can be
somwhat forced to "respect" vm_time by using the command line flag 'icount
1'. Using this flag my behavior was closer to what I expected.
Cheers,
Andrew
pl031's base address should be 0x9001000, 0x9001. While in there
also add some spacing and zeros to make it easier to read the map.
Signed-off-by: Andrew Jones
---
hw/arm/virt.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/arm/virt.c b/h
On Tue, Jul 29, 2014 at 04:58:44PM +0100, Peter Maydell wrote:
> On 29 July 2014 16:44, Andrew Jones wrote:
> > pl031's base address should be 0x9001000, 0x9001. While in there
^ meant to type 'not' here,
but guess that
pl031's base address should be 0x901, not 0x9001, otherwise
it sits in ram when configuring a guest with greater than 1G.
Signed-off-by: Andrew Jones
---
v2:
- pl031 needs 64K alignment
- don't change the formatting, will send another patch, which may
get ignored :-)
-
Signed-off-by: Andrew Jones
---
hw/arm/virt.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 89532bd786436..ba9429806 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -98,17 +98,17 @@ typedef struct VirtBoardInfo {
*
driver is “free”.
How you write a GPL licensed FAT driver seems like a legal quagmire. Probably
something better discussed with a lawyer. From the outside looking in it seems
like the IP rights are enforced by charging licensing fees to devices that
support FAT. So free can still cost you….
T
From: Andrew Towers
Replaces the ARM_FEATURE_VFP3 check when reading MVFR0/1 with a check for
ARM_FEATURE_V6K. Rationale: MVFR0/1 were introduced in the ARM1136 at the
same time as ARMv6K, and a survey of TRMs indicates support in later models.
According to reference documentation on arm.com
: Andrew Towers
---
v2:
* introduced ARM_FEATURE_MVFR, implied by ARM_FEATURE_V6K.
Paul: I'd love to work on an rPi board model, and I'll see what I can put
together, but much of the hardware is under NDA and I'm not in the loop..
target-arm/cpu.h |1 +
target-arm/hel
Public bug reported:
version 0.14.1 when using qcow2 images, after some time, glibc detects a
double free or corruption.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU
Public bug reported:
unless compiled without optimizations, no system may be ran except the default
with -kvm-enabled
I had to modify config-host.mak and remove -O2 from CFLAGS to be able to work
without kvm.
GCC 4.4.4 qemu-0.14.1
***NOTE: this has been an issue for several versions.
** Affect
dress the problems you were thinking about?
-Andrew Barry
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 87b6e04..2ed1cca 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -615,8 +615,12 @@ static void hugetlbfs_put_super(struct s
struct hugetlbfs_sb_info
unmounted, it frees the hugetlbfs_sb_info struct, but only if the reference
count is zero, otherwise it clears the active bit. The last hugetlb_put_quota
then frees the hugetlbfs_sb_info struct.
Signed-off-by: Andrew Barry
---
fs/hugetlbfs/inode.c| 40
get this going. (done)
2. For you all to review the patch and let me know if I've missed anything.
Patch RFC coming ASAP.
-Andrew Barry
On 08/15/2011 10:47 PM, David Gibson wrote:
> On Mon, Aug 15, 2011 at 03:25:35PM -0500, Andrew Barry wrote:
>> I've been doing something s
- Original Message -
> From: "Raj Rajasekaran"
> To: qemu-devel@nongnu.org
> Sent: Monday, April 23, 2012 11:35:56 AM
> Subject: [Qemu-devel] Spice vdagent on SLED 11
>
> I am not able to get Spice vdagent running on SLED 11 virtual
> machine. Log file has the error message 'Missing vir
- Original Message -
> From: "Raj Rajasekaran"
> To: "Andrew Cathrow"
> Cc: qemu-devel@nongnu.org
> Sent: Tuesday, April 24, 2012 11:43:12 AM
> Subject: Re: [Qemu-devel] Spice vdagent on SLED 11
>
>
> Where do I check whether VM is configur
1 - 100 of 3788 matches
Mail list logo
