On Fri, Aug 03, 2012 at 08:41:36AM -0500, Anthony Liguori wrote:
> Alon Levy writes:
>
> > On Wed, Aug 01, 2012 at 02:22:37PM -0500, Anthony Liguori wrote:
> >> Andreas Färber writes:
> >>
> >> > Am 30.07.2012 18:19, schrieb Alon Levy:
> >> &g
On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote:
> > diff --git a/configure b/configure
> > index cef0a71..5fcd315 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2630,7 +2630,7 @@ EOF
> >spice_cflags=$($pkg_config --cflags spice-protocol spice-server
> > 2>/dev/null)
> >
On Thu, Aug 09, 2012 at 03:50:12PM +0200, Gerd Hoffmann wrote:
> On 08/09/12 15:41, Alon Levy wrote:
> > On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote:
> >>> diff --git a/configure b/configure
> >>> index cef0a71..5fcd315 100755
> >&
Revision bumped to 4 for new IO support, enabled for spice-server >=
0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >=
0.12.0.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
configure |
Signed-off-by: Alon Levy
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 913077f..2c8399a 100755
--- a/configure
+++ b/configure
@@ -2638,6 +2638,8 @@ EOF
spice="yes"
libs_softmmu="$libs_soft
On Mon, Aug 06, 2012 at 02:03:59PM +0200, Gerd Hoffmann wrote:
> On 07/25/12 05:57, Benjamin Herrenschmidt wrote:
> > Hi folks !
> >
> > Would there be any objection to adding a second MMIO BAR to qemu-vga
> > which mirrors the bochs magic VBE ports ?
>
> No.
>
> > Once done, I'd like to look in
On Wed, Aug 15, 2012 at 10:23:23AM +0200, Gerd Hoffmann wrote:
> On 08/09/12 16:21, Alon Levy wrote:
> > Revision bumped to 4 for new IO support, enabled for spice-server >=
> > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >=
> > 0.12.
Hi Gerd,
Rebased on the lastest, redid ifdefs to use a single line,
QXL_HAS_IO_MONITORS_CONFIG_ASYNC is 0 by default, 1 if spice-protocol is new
enough.
Also available at
git://people.freedesktop.org/~alon/qemu qxl/pull
Alon Levy (4):
qxl/update_area_io: guest_bug on invalid
Signed-off-by: Alon Levy
---
hw/qxl.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index c2dd3b4..6c48eb9 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1385,6 +1385,18 @@ async_common:
QXLCookie *cookie = NULL;
QXLRect update = d->
Signed-off-by: Alon Levy
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index dbf3af6..af4f68d 100755
--- a/configure
+++ b/configure
@@ -2657,6 +2657,8 @@ EOF
spice="yes"
libs_softmmu="$libs_soft
Signed-off-by: Alon Levy
---
hw/qxl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c48eb9..c978f5e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl)
io_size = 16
Revision bumped to 4 for new IO support, enabled for spice-server >=
0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >=
0.12.0.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
configure |
Revision bumped to 4 for new IO support, enabled for spice-server >=
0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >=
0.12.0.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
Left in one defined, fixed
Revision bumped to 4 for new IO support, enabled for spice-server >=
0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >=
0.12.0.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
Fixed another defined I misse
On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote:
> On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote:
> > Revision bumped to 4 for new IO support, enabled for spice-server >=
> > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >=
> Hi,
>
> >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
> >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
> >>
> >> Just delete this and use
> >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
> >
> > So you are telling me to undo a change that Gerd asked for - could
> > you
> > please at least debat
> > Hi,
> >
> > >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
> > >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
> > >>
> > >> Just delete this and use
> > >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
> > >
> > > So you are telling me to undo a change that Gerd asked for -
> > > could
> > > you
> On 08/20/12 10:00, Alon Levy wrote:
> >> Hi,
> >>
> >>>>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define
> >>>>> QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
> >>>>
> >>>> Just delete this and use
> >>&
On Sat, Aug 18, 2012 at 07:07:46PM +, Blue Swirl wrote:
> On Sat, Aug 18, 2012 at 4:16 PM, Alon Levy wrote:
> > On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote:
> >> On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote:
> >> > Revision bumped to 4 for new
Signed-off-by: Alon Levy
---
Changes for patchset v7->v8:
QXL_IO_MONITORS_CONFIG_ASYNC is defined even when spice-protocol < 0.12 (Gerd
Hoffman)
QXL_HAS_.. is either defined or not, same as other feature definitions (Blue
Swirl)
Only the third patch "qxl: add QXL_IO_MONITORS_C
Signed-off-by: Alon Levy
---
hw/qxl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c48eb9..c978f5e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl)
io_size = 16
nfig_async to let spice-server read a new guest set
monitors config and notify the client.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
configure | 3 +++
hw/qxl.c | 66 +++
Signed-off-by: Alon Levy
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index ff6443e..aae051b 100755
--- a/configure
+++ b/configure
@@ -2657,6 +2657,8 @@ EOF
spice="yes"
libs_softmmu="$libs_soft
- Original Message -
> Hi,
>
> >> Maybe revisit upstream spice packaging? spice internal usage of
> >> spice-protocol is handled via submodules now. Are there external
> >> users, other than qemu? Does it make sense to keep the
> >> spice-server / spice-protocol split in the first pla
Signed-off-by: Alon Levy
---
v8->v9:
* split guest_monitors_config to a subsection (Gerd Hoffman)
- no change to other patches.
hw/qxl.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index c2dd3b4..6c48eb9 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -138
---
.gitmodules| 3 +++
compiler.h | 7 +++
spice-protocol | 1 +
3 files changed, 11 insertions(+)
create mode 16 spice-protocol
diff --git a/.gitmodules b/.gitmodules
index eca876f..ba6844b 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -19,3 +19,6 @@
[submodule "roms/sgabios"]
nfig_async to let spice-server read a new guest set
monitors config and notify the client.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
configure | 3 ++
hw/qxl.c | 91 +++
Signed-off-by: Alon Levy
---
hw/qxl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c48eb9..c978f5e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl)
io_size = 16
Signed-off-by: Alon Levy
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index ff6443e..aae051b 100755
--- a/configure
+++ b/configure
@@ -2657,6 +2657,8 @@ EOF
spice="yes"
libs_softmmu="$libs_soft
> On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy wrote:
> > ---
> > .gitmodules| 3 +++
> > compiler.h | 7 +++
> > spice-protocol | 1 +
> > 3 files changed, 11 insertions(+)
> > create mode 16 spice-protocol
I accidentally sent this patch
Signed-off-by: Alon Levy
---
v9->v10
Use CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC instead of -D directly, define is
created in config-host.h
so hw/qxl.[ch] is unchanged except for
s/QXL_HAS_IO_MONITORS_CONFIG_ASYNC/CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC
(Blue Swirl)
No other patches chan
Signed-off-by: Alon Levy
---
hw/qxl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c48eb9..c978f5e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl)
io_size = 16
Signed-off-by: Alon Levy
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 84fa2c6..02c06aa 100755
--- a/configure
+++ b/configure
@@ -2657,6 +2657,8 @@ EOF
spice="yes"
libs_softmmu="$libs_soft
nfig_async to let spice-server read a new guest set
monitors config and notify the client.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
configure | 7 +
hw/qxl.c | 91 +++
Signed-off-by: Alon Levy
---
hw/qxl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c48eb9..c978f5e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl)
io_size = 16
Signed-off-by: Alon Levy
---
v10->v11
fixed coding style: space before square bracket. fixed an old instance too.
(Gerd)
hw/qxl.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index c2dd3b4..6c48eb9 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -138
nfig_async to let spice-server read a new guest set
monitors config and notify the client.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
configure | 7
hw/qxl.c | 93 +++
Signed-off-by: Alon Levy
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 84fa2c6..02c06aa 100755
--- a/configure
+++ b/configure
@@ -2657,6 +2657,8 @@ EOF
spice="yes"
libs_softmmu="$libs_soft
Signed-off-by: Alon Levy
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 84fa2c6..02c06aa 100755
--- a/configure
+++ b/configure
@@ -2657,6 +2657,8 @@ EOF
spice="yes"
libs_softmmu="$libs_soft
nfig_async to let spice-server read a new guest set
monitors config and notify the client.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy
---
v11->v12:
fix build with older spice server (Gerd).
configure | 7
hw/
On Wed, Feb 08, 2012 at 03:39:35PM +0200, Yonit Halperin wrote:
> RHBZ #788444
769512
ACK, just a few comment fixes (take it or leave it).
>
> CC: Gerd Hoffmann
>
> Signed-off-by: Gerd Hoffmann
> Signed-off-by: Yonit Halperin
> ---
> server/reds.c | 21 +
> server/spi
On Thu, Feb 09, 2012 at 07:05:29PM +, Paul Brook wrote:
> libcacard is only used by system emulation.
> Only define libcacard_libs/cflags once.
>
ACK.
Anthony, do you want a single patch pull request in general or is it ok
to ask that you pick this directly?
Alon
> Signed-off-by: Paul Broo
On Wed, Feb 15, 2012 at 11:22:15AM +0200, Yonit Halperin wrote:
> We used to assure the guest surfaces were saved before migration by
> setting the whole vram dirty. This patch sets dirty only the areas
> that are actually used in the vram.
>
Series is
Reviewed-by: Alon Levy
>
On Wed, Feb 15, 2012 at 02:11:06PM +0100, Gerd Hoffmann wrote:
> This patch fixes the local qxl renderer to not kick spice-server in case
> the vm is stopped. First it is pointless because we render evevything
*everything
> when the vm is stopped. Thus there is nothing to render anyway because
>
On Wed, Feb 15, 2012 at 03:45:30PM +0100, Gerd Hoffmann wrote:
> This patch fixes the local qxl renderer to not kick spice-server
> in case the vm is stopped. First it is largely pointless because
> we ask spice-server to process all not-yet processed commands when
> the vm is stopped, so there is
On Wed, Feb 15, 2012 at 06:28:53PM +0200, Alon Levy wrote:
> On Wed, Feb 15, 2012 at 03:45:30PM +0100, Gerd Hoffmann wrote:
> > This patch fixes the local qxl renderer to not kick spice-server
> > in case the vm is stopped. First it is largely pointless because
> > we ask sp
This allows us to reduce the size of the surfaces bar minimally while
not breaking current drivers. To completely disable the bar, or make it
zero sized, would break them.
Signed-off-by: Alon Levy
---
hw/qxl.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw
Removes the last user of QXL_SYNC when using update drivers that use the
_ASYNC io ports.
The last user is qxl_render_update, it is called both by qxl_hw_update
which is the vga_hw_update_ptr passed to graphic_console_init, and by
qxl_hw_screen_dump.
Signed-off-by: Alon Levy
---
hw/qxl
Will be used in the next patch.
Signed-off-by: Alon Levy
---
hw/qxl-render.c|2 +-
hw/qxl.c | 63 +++
hw/qxl.h |2 +-
ui/spice-display.c | 24 +--
ui/spice-display.h | 10
5 files
Vadim, Could this be related to the hangs during boot with qxl and
virtio-serial in a single windows vm?
Alon
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/818673
Title:
virtio: trying to map MMIO
On Fri, Feb 17, 2012 at 01:11:27AM +0200, Alon Levy wrote:
> Will be used in the next patch.
Self NACK, some errors in this patchset, sending v2 with cleanup
(qxl_cookie_new to reduce the duplicate code).
>
> Signed-off-by: Alon Levy
> ---
> hw/qxl-render.c|2
Will be used in the next patch.
Signed-off-by: Alon Levy
---
hw/qxl-render.c|2 +-
hw/qxl.c | 60 +--
hw/qxl.h |2 +-
ui/spice-display.c | 26 --
ui/spice-display.h | 12 ++
5 files
area being passed to the red_worker thread
is passed as a copy, allocated and copied before passing, deallocated on
the interface_async_complete callback.
Signed-off-by: Alon Levy
---
hw/qxl-render.c| 43 ---
hw/qxl.c | 19
On Fri, Feb 17, 2012 at 10:44:59AM +0200, Alon Levy wrote:
> Will be used in the next patch.
NACK these two, Marc Andre found a cookie I missed, and the bz in the
commit message is a dup of an existing bug (747011).
>
> Signed-off-by: Alon Levy
> ---
> hw/qxl-render.c|2
On Fri, Feb 17, 2012 at 02:11:40PM +0100, Gerd Hoffmann wrote:
> On 02/17/12 09:44, Alon Levy wrote:
> > Will be used in the next patch.
> >
> > Signed-off-by: Alon Levy
> > ---
> > hw/qxl-render.c|2
On Fri, Feb 17, 2012 at 01:49:20PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Fri, Feb 17, 2012 at 9:44 AM, Alon Levy wrote:
> > +/* called from spice server thread context only */
> > +static void interface_async_complete(QXLInstance *sin, uint6
On Fri, Feb 17, 2012 at 04:11:59PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > -if (qxl->vram_size < 16 * 1024 * 1024) {
> > +/* a request of 0 vram_size is translated to the smallest vram that
> > doesn't
> > + * break current off screen surfaces using drivers */
> > +if (qxl->vram
On Fri, Feb 17, 2012 at 12:16:53PM -0600, Anthony Liguori wrote:
> On 02/09/2012 01:05 PM, Paul Brook wrote:
> >libcacard is only used by system emulation.
> >Only define libcacard_libs/cflags once.
> >
> >Signed-off-by: Paul Brook
>
> Ah, I applied this without realizing it was from pbrook :-)
>
On Fri, Feb 17, 2012 at 09:09:11PM +0200, Alon Levy wrote:
> On Fri, Feb 17, 2012 at 01:49:20PM +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Fri, Feb 17, 2012 at 9:44 AM, Alon Levy wrote:
> > > +/* called from spice server thread context only */
> > >
On Fri, Feb 17, 2012 at 04:10:30PM +0100, Gerd Hoffmann wrote:
> There is no reason to require a minimum size of 16 MB for the vram.
> Lower the limit to 4096 (one page). Make it disapper completely would
> break guests.
> ---
> hw/qxl.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletion
On Fri, Feb 17, 2012 at 04:10:30PM +0100, Gerd Hoffmann wrote:
> There is no reason to require a minimum size of 16 MB for the vram.
> Lower the limit to 4096 (one page). Make it disapper completely would
> break guests.
NM my nitpick, more readable this way, ACK.
> ---
> hw/qxl.c |4 ++--
>
On Fri, Feb 17, 2012 at 04:10:31PM +0100, Gerd Hoffmann wrote:
> Factor memory bar sizing bits out to a separate function.
ACK.
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw/qxl.c | 41 ++---
> 1 files changed, 22 insertions(+), 19 deletions(-)
>
> diff --g
On Fri, Feb 17, 2012 at 04:10:33PM +0100, Gerd Hoffmann wrote:
> This patch adds an 64bit pci bar for vram. It is turned off by default.
> It can be enabled by setting the size of the 64bit bar to be larger than
> the 32bit bar. Both 32bit and 64bit bar refer to the same memory. Only
> the first
On Fri, Feb 17, 2012 at 04:10:32PM +0100, Gerd Hoffmann wrote:
> Add two properties to specify bar sizes in megabytes instead of bytes,
> which is alot more user-friendly.
>
ACK.
> Signed-off-by: Gerd Hoffmann
> ---
> hw/qxl.c |8
> hw/qxl.h |4
> 2 files changed, 12 inse
Signed-off-by: Alon Levy
---
Try to warn people who keep getting bitten by this. In addition maybe
we should bug out if revision >= 3 and sync io is used, and warn if revision <
3 is used in the first place?
hw/qxl.c | 27 +++
1 file changed, 27 insertions(+)
diff
> Hi,
>
> > +static void sync_io_warning(PCIQXLDevice *qxl, uint32_t io_port)
> > +{
> > +fprintf(stderr, "qxl-%d: WARNING: sync io used, see (RHBZ
> > 747011)",
> > +qxl->id);
> > +fprintf(stderr, "qxl-%d: WARNING: virt-viewer/remote-viewer
> > can hang\n",
> > +qx
creen surface creation.
Recently windows guests got odd width support which triggers a non word
aligned primary surface in 16bit color depth. Off screen surfaces have
always been word aligned, but doesn't hurt to check them here too.
Signed-off-by: Alon Levy
---
hw/qxl.c | 12 ++
Signed-off-by: Alon Levy
---
Spice package is not yet available, I assumed it will be the next version,
0.12.1, for the added API spice_server_set_ws_ports. Patches are on spice-devel
and git is at http://cgit.freedesktop.org/~alon/spice master branch
(db5817a059d640fb4ca21740e1362fc6c3e98765
Signed-off-by: Alon Levy
---
hw/qxl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index 1b47ed3..620b476 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -453,6 +453,16 @@ static int qxl_track_command(PCIQXLDevice *qxl, struct
QXLCommandExt *ext
On Mon, Jul 02, 2012 at 10:20:17AM +0200, Jan Kiszka wrote:
One comment below.
Reviewed-by: Alon Levy
> Let the text console cursor blink at 5 HZ.
>
> Signed-off-by: Jan Kiszka
> ---
> console.c | 26 +-
> 1 files changed, 25 insertions(+), 1 dele
On Tue, Jul 03, 2012 at 11:05:50AM +0200, Jan Kiszka wrote:
> On 2012-07-03 10:59, Alon Levy wrote:
> > On Mon, Jul 02, 2012 at 10:20:17AM +0200, Jan Kiszka wrote:
> >
> > One comment below.
> >
> > Reviewed-by: Alon Levy
> >
> >> Let the text co
There is already support for that in spice-server afaik, though I don't
remember the api or what commit, or if it's in a released version (well,
it's surely in 0.11.0, but that's unstable). Sorry about the lack of
details, I suggest you search spice-devel mailing list archive though. I
think libvir
Signed-off-by: Alon Levy
---
arch_init.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch_init.c b/arch_init.c
index e6effe8..84bca99 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -808,8 +808,10 @@ static int ram_load(QEMUFile *f, void *opaque, int
version_id
Signed-off-by: Alon Levy
---
Please ignore previous version, accidentally removed goto done and used wrong
format size specifiers.
arch_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch_init.c b/arch_init.c
index e6effe8..fba24f3 100644
--- a/arch_init.c
+++ b/arch_init.c
> On 12/06/2012 02:02 PM, Alon Levy wrote:
> > Signed-off-by: Alon Levy
> > ---
> > arch_init.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch_init.c b/arch_init.c
> > index e6effe8..84bca99 100644
> > --
of
the revision and nop-ing.
Signed-off-by: Alon Levy
---
hw/qxl.c | 37 -
hw/qxl.h | 2 ++
trace-events | 2 ++
3 files changed, 36 insertions(+), 5 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 3f835b8..4794f13 100644
--- a/hw/qxl.c
+++ b/hw
> On 12/06/12 16:41, Alon Levy wrote:
> > RHBZ 869981
> >
> > Before this patch revision < 4 (4 is the default) would result in a
> > wrong
> > qxl_rom size of 16384 instead of 8192 when building with
> > spice-protocol-0.12, due to the addition of fie
All looks good.
Reviewed-by: Alon Levy
- Original Message -
> This series reworks the post_load code recently introduced to
> allocate
> the structures only when required (i.e. only at load time). This
> helps keep the VirtIOSerial struct clean, and use less RAM.
>
&
esult in failure at
startup (could do this compile time also but not sure how).
Signed-off-by: Alon Levy
---
hw/qxl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 8611ee9..99b354a 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -88,9 +88,7 @@
#d
Signed-off-by: Alon Levy
---
hw/qxl.c | 11 +++
trace-events | 2 ++
2 files changed, 13 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index 3f835b8..8611ee9 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -981,6 +981,12 @@ static void interface_set_client_capabilities(QXLInstance
*sin
On Thu, Dec 13, 2012 at 01:05:48PM +0100, Gerd Hoffmann wrote:
> On 12/13/12 12:36, Alon Levy wrote:
> > This is a simpler solution to 869981, where migration breaks since qxl's
> > rom bar size has changed. Instead of ignoring fields in QXLRom, which is
> > what ha
On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> >> That is indeed a better solution, but it does change functionality. I
> >> think it is correct but I'd like to get some other opinions - Uri,
> >> Arnon, Yonit, Soren - any problems with dropping these?
> >>
> > Orientat
On Wed, Dec 19, 2012 at 09:33:28AM +0100, Paolo Bonzini wrote:
> Il 28/11/2012 10:53, Alon Levy ha scritto:
> >> Il 28/11/2012 10:16, Alon Levy ha scritto:
> >>> > > diff --git a/roms/openbios b/roms/openbios
> >>> > > index f095c85..d1d2787 1600
Broken since:
commit 927d4878b0ff319ed87fed9363f314613b0a5ed9
Author: Paolo Bonzini
Date: Mon Dec 17 18:20:05 2012 +0100
softmmu: move remaining include files to include/ subdirectories
Signed-off-by: Alon Levy
---
hw/usb/redirect.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
static in the guest.
By registering the interface on post load spice server will pass on the
agent messages fixing the mouse behavior after migration.
RHBZ #725965
Signed-off-by: Alon Levy
---
spice-qemu-char.c | 42 ++
1 file changed, 42 insertions(+)
diff
> On 02/06/2013 05:52 PM, Cole Robinson wrote:
> > On 01/22/2013 05:09 AM, Gerd Hoffmann wrote:
> >> From: Alon Levy
> >>
> >> This is a simpler solution to 869981, where migration breaks since
> >> qxl's
> >> rom bar size has changed. I
> On 02/07/2013 07:31 AM, Alon Levy wrote:
> >> On 02/06/2013 05:52 PM, Cole Robinson wrote:
> >>> On 01/22/2013 05:09 AM, Gerd Hoffmann wrote:
> >>>> From: Alon Levy
> >>>>
> >>>> This is a simpler solution to 869981, whe
Reported and suggested by Paolo Bonzini, thanks.
Signed-off-by: Alon Levy
---
hw/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 33169f3..58c4643 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1461,7 +1461,7 @@ static void ioport_write(void *opaque
This prevents a segfault later on when the device reset handler
tries to access a NULL ssd.worker since interface_attach_worker has
not been called.
Signed-off-by: Alon Levy
---
hw/qxl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 58c4643
On Fri, Sep 28, 2012 at 11:51:29AM +0200, Paolo Bonzini wrote:
> Il 06/09/2012 09:21, Gerd Hoffmann ha scritto:
> > +#ifndef CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC
> > +/* spice-protocol is too old, add missing definitions */
> > +#define QXL_IO_MONITORS_CONFIG_ASYNC (QXL_IO_FLUSH_RELEASE + 1)
> > +#e
As suggested by Paolo Bonzini, to avoid possible integer overflow issues.
Signed-off-by: Alon Levy
---
hw/qxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 4effb66..97ae22a 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1811,7 +1811,7 @@ static
On Wed, Aug 29, 2012 at 02:58:14AM +0200, Søren Sandmann wrote:
> Gerd Hoffmann writes:
>
> > On 08/27/12 19:20, Søren Sandmann Pedersen wrote:
> >> From: Søren Sandmann Pedersen
> >>
> >> The client_present field is a byte that is set of non-zero when a
> >> client is connected and to zero whe
Signed-off-by: Alon Levy
---
scripts/tracetool/backend/dtrace.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tracetool/backend/dtrace.py
b/scripts/tracetool/backend/dtrace.py
index 9cab75c..6be7047 100644
--- a/scripts/tracetool/backend/dtrace.py
+++ b/scripts
> ---
> server/red_worker.c | 2 ++
> spice-common| 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 843f559..23f3464 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -10377,6 +10377,8 @@ static v
> From: Søren Sandmann Pedersen
>
> This new interface lets spice server inform the guest whether
>
> (a) a client is connected
> (b) what capabilities the client has
>
> There is a fixed number (464) of bits reserved for capabilities, and
> when the capabilities bits change, the QXL_INTERRUPT_
> From: Søren Sandmann Pedersen
>
> When a new client connects, there may be commands in the ring that it
> can't understand, so we need to process these before forwarding new
> commands to the client. By doing this after changing the capability
> bits we ensure that the new client will never see
On Thu, Sep 06, 2012 at 07:39:23AM +0200, Gerd Hoffmann wrote:
> Hi,
Series is
Reviewed-by: Alon Levy
>
> This patch series makes spice be more clever on screen updates when in
> vga mode (i.e. without qxl guest driver loaded or when using a non-qxl
> vga card). qemu keep
Signed-off-by: Alon Levy
---
scripts/tracetool/backend/dtrace.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tracetool/backend/dtrace.py
b/scripts/tracetool/backend/dtrace.py
index 9cab75c..6be7047 100644
--- a/scripts/tracetool/backend/dtrace.py
+++ b/scripts
lace.
Signed-off-by: Alon Levy
---
hw/qxl.c | 8 +---
trace-events | 6 --
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 80ba401..94eb3c8 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -141,6 +141,7 @@ static void qxl_ring_set_dirty(PCIQXLD
Guest set capabilities are written to the spice server via
spice_qxl_guest_capabilities_set, provided the compiled against
spice server is new enough to provide this symbol.
QXL device revision will be raised in a later patch to advertise this
support to the guest.
Signed-off-by: Alon Levy
1 - 100 of 1513 matches
Mail list logo
