On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote: > > diff --git a/configure b/configure > > index cef0a71..5fcd315 100755 > > --- a/configure > > +++ b/configure > > @@ -2630,7 +2630,7 @@ EOF > > spice_cflags=$($pkg_config --cflags spice-protocol spice-server > > 2>/dev/null) > > spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null) > > if $pkg_config --atleast-version=0.8.2 spice-server >/dev/null 2>&1 && \ > > - $pkg_config --atleast-version=0.8.1 spice-protocol > /dev/null 2>&1 > > && \ > > + $pkg_config --atleast-version=0.12.0 spice-protocol > /dev/null 2>&1 > > && \ > > I'd prefer to not require cutting-edge spice bits to build ...
I only increased the protocol requirement, not the server. This is actually not related to the SERVER_VERSION below, it's needed for the new io code QXL_IO_MONITORS_CONFIG_ASYNC. I would like to propose we add spice-protocol as a submodule to fix this dependency, since it's a small module containing headers, so even if it isn't used it shouldn't place a large burden on qemu developers. Meanwhile I'll add a define based on the pkg-config spice-protocol version, which I can test from hw/qxl.c, since the commit adding QXL_IO_MONITORS_CONFIG_ASYNC didn't introduce any new define I can check. > > > case QXL_IO_FLUSH_SURFACES_ASYNC: > > +#if SPICE_SERVER_VERSION >= 0x000b01 /* 0.11.1 */ > > + case QXL_IO_MONITORS_CONFIG_ASYNC: > > +#endif > > ... and given you #ifdef the new stuff anyway it should not be needed. > > cheers, > Gerd >
