Public bug reported:
http://mikeos.berlios.de/write-your-own-os.html
Following the steps,
it works on ubuntu,
but on osx, it ALWAYS dumps.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which
Having exactly the same problem here...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/886621
Title:
Mac OS X Lion: segmentation fault
Status in QEMU:
New
Bug description:
/usr/local/xeos-buil
caused by setting ideal_nops to p6_nops (k8_nops was used before
> > > the break statement was added).
> >
> > Maybe I overlooked it or maybe it was implied but did you try
> > reverting
> > the patch and rerunning your test? Does it work ok then?
> >
>
> Yes, if I remove the break statement (introduced by this commit), it works
> fine.
What version of qemu is this - do we have qemu bug here I wonder.
Alan
lose it. I see no reason not to do that.
Also the LSM hooks apply to file objects mostly, so its a natural fit on
top *IF* you choose to use them.
Finally you can pass file handles around between processes - do that any
other way 8)
Alan
hich can be shortcut and a completion set of inb/inw ops that can
be predicted.
You should hit userspace about once per IDE operation. Fix the hot paths
with good design and the noise doesn't matter.
Alan
ng them to
follow the qemu gpl license rules?
Alan
On Sun, 14 Apr 2013, Gonglei (Arei) wrote:
> > > Hi Alan,
> > > We pass-throughed USB 2.0 disk to guest using usb-host (qemu option:
> > -device usb-ehci,id=ehci -device usb-host,bus=ehci.0,hostbus=2,hostport=1)
> > on
> > KVM(on linux-3.8.3 or linux-3.0.1
>
> > It's okay to have an URB size that isn't a multiple of 512 if that URB
> > is the last one in a transfer. For example, the 31-byte URBs were the
> > only URBs in their transfers, so they were okay. But the 4064-byte
> > URBs occurred at the start and i
Public bug reported:
I am virtualzing a physical server for which I need to set the SCSI/SATA
drive serial. It is comprised of 12 " " spaces then 8 letter/digits.
If I exclude the spaces, the drive serial is not accurate. If I include
the spaces I get the following error.
error: Failed to start
I am virtualzing a physical server for which I need to set the SCSI/SATA drive
serial. It is comprised of 12 " " spaces then 8 letter/digits. If I exclude the
spaces, the drive serial is not accurate. If I include the spaces I get the
following error.
error: Failed to start domain test1
error:
ote:
>
>
>
> On 02/19/2015 02:48 PM, Alan Latteri wrote:
>> I am virtualzing a physical server for which I need to set the SCSI/SATA
>> drive serial. It is comprised of 12 " " spaces then 8 letter/digits. If
>> I exclude the spaces, the drive serial is not accurate. If
s/372419e1-ca68-408f-b809-04ce54450e60-0.img,if=none,id=drive-sata0-0-0,format=qcow2,serial=:
could not open disk image ABCD1234,cache=none: Could not open file: No such
file or directory
tried with quotes around the serial value and also using escpare characters.
No go.
Thanks,
Alan
> On Fe
From what I can tell in the code, padstr() is only coded in the IDE section,
not SCSI/SATA?
> On Feb 19, 2015, at 11:42 PM, Markus Armbruster wrote:
>
> John Snow mailto:js...@redhat.com>> writes:
>
>> On 02/19/2015 02:48 PM, Alan Latteri wrote:
>>> I am
The left padding is important and necessary to keep for my particular
application. This is broken in libvirt, but works fine with direct Qemu
invocation.
Thank you for the help.
Alan
> On Feb 20, 2015, at 1:28 AM, Markus Armbruster wrote:
>
> Alan Latteri mailto:a...@insti
Bug 1195660 <https://bugzilla.redhat.com/show_bug.cgi?id=1195660> has been
added to the database
> On Feb 23, 2015, at 3:41 AM, Michal Privoznik wrote:
>
> On 23.02.2015 11:18, Markus Armbruster wrote:
>> Alan Latteri writes:
>>
>>> The left padding is im
I missed for exposing such an
ability or similar for Qemu-KVM based virtual machines.
Thanks in advance,
Alan.
hich doesn't fit with
> > >>>> their plan.
> > >>>> Remember that we already had this problem with ivshmem which
> was
> > >>>> planned to be dropped.
> > >>>
> > >>> Unfortunately, I have not yet received an
Hello: I am Alan Jacobs in Green Bay Wisconsin USA ( north of Chicago). I have
a difficult emulation question regarding interrupt driven bidirectional
parallel port communication on a Celeron 220 Intel processor with 2GB RAM ( but
no hardware KVM extension I can find ), but with bios option to
bus = pci_dev->bus; bus_irq_num = bus->map_irq(pci_dev, bus_irq_num); if (bus->set_irq) break; pci_dev = bus->parent_dev; }
assert(irq_num >= 0); assert(irq_num < bus->nirq); bus->irq_count[irq_num] += change; bus->se
0 or 1 */
static void pci_set_irq(void *opaque, int irq_num, int level)
so, that implies to me that it's probably always 4... Sorry for the confusion.
From: Richard Henderson
Sent: Tue 9/20/2011 2:57 PM
To: Alan Amaral
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] pci_change_irq_level is
From: Jan Kiszka
Sent: Tue 9/20/2011 3:41 PM
To: Alan Amaral
Cc: Richard Henderson; qemu-devel@nongnu.org
Subject: Re: pci_change_irq_level is broken...
> On 2011-09-20 21:19, Alan Amaral wrote:
> > QEMU emulator version 0.14.50, Copyright (c) 2003-2008 Fabrice Bellard
>
my earlier reply to Jan Kiszka for full details.
Thanks,
Alan
From: Richard Henderson
Sent: Tue 9/20/2011 3:56 PM
To: Alan Amaral
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] pci_change_irq_level is broken...
On 09/20/2011 12:19 PM, Alan Amaral wrote:
> QEMU emulator version 0.14.
Excellent! Thanks...
Alan
From: Jan KiszkaSent: Wed 9/21/2011 12:33 PMTo: Alan AmaralCc: qemu-devel@nongnu.org; r...@twiddle.netSubject: Re: pci_change_irq_level is broken...
On 2011-09-21 18:26, Alan Amaral wrote:
>
>
>
>
> From: Jan Kiszka
> Sent: Tue 9/20
ns on NMI or if you take an ECC exception and scrubbing stall
off the memory controller while loading part of that cache line of code
into memory ?
Alan
On 02/01/06, Ishwar Rattan <[EMAIL PROTECTED]> wrote:
>
> Has there been a change in -user-net part
> (other than -net user) for qemu-0.8.0?
>
Yes, you need -net nic as well as -net user.
Cheers,
Al.
___
Qemu-devel mailing list
Qemu-devel@nongnu.org
h
/Screen02 examples from Baking Pi tutorial[2] didn't work
before this patch.
[1] https://github.com/qemu/qemu/blob/master/hw/misc/bcm2835_property.c#L158
[2] https://www.cl.cam.ac.uk/projects/raspberrypi/tutorials/os/screen01.html
Signed-off-by: Alan Jian
---
This patch is v2 because the pre
as the max atomic write size.
Future Work
---
- Namespace support (NAWUN, NAWUPF and NACWU)
- Namespace Boundary support (NABSN, NABO, and NABSPF)
- Atomic Compare and Write Unit (ACWU)
Alan Adamson (1):
nvme: add atomic write support
hw
=UINT16 (default: 0)
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 147 -
hw/nvme/nvme.h | 17 ++
2 files changed, 163 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 127c3d238346..5d19965122d0 100644
--- a/hw
gt;
> Question is: What is actually wrong ? Something in the generic interrupt
> handling code in Linux, something in the Linux usb-ohci driver, or
> something in qemu ? Any idea how a proper fix might look like ?
To answer these questions we need more information.
Alan Stern
On Tue, Apr 23, 2024 at 02:10:13PM -0700, Guenter Roeck wrote:
> Hi Alan,
>
> On 4/23/24 10:30, Alan Stern wrote:
> > On Tue, Apr 23, 2024 at 10:04:17AM -0700, Guenter Roeck wrote:
> > > Hi,
> > >
> > > when testing usb-ohci
> >
> > What
in LE order */
>
> Oh, this was always wrong on BE :(
Am I right in thinking this patch correctly matches the SVE BE changes from
June?
Specifically, this patch:
http://lists.infradead.org/pipermail/linux-arm-kernel/2019-June/657826.html
Alan.
>
> Reviewed-by: Philippe Mathieu-D
ite support, this error no longer happens.
Future Work
---
- Namespace support (NAWUN, NAWUPF and NACWU)
- Namespace Boundary support (NABSN, NABO, and NABSPF)
- Atomic Compare and Write Unit (ACWU)
Alan Adamson (1):
hw/nvme: add atomic write support
hw/nvme/c
.
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 161 +
hw/nvme/nvme.h | 12
2 files changed, 173 insertions(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index c6d4f61a47f9..ac0efa95588d 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
On 9/17/24 12:59 AM, Klaus Jensen wrote:
On Aug 20 09:11, Alan Adamson wrote:
Since there is work in the Linux NVMe Driver community to add Atomic Write
support, it would be desirable to be able to test it with qemu nvme emulation.
This patch will focus on supporting NVMe controller atomic
On 9/17/24 9:21 AM, alan.adam...@oracle.com wrote:
On 9/17/24 12:59 AM, Klaus Jensen wrote:
On Aug 20 09:11, Alan Adamson wrote:
Since there is work in the Linux NVMe Driver community to add Atomic
Write
support, it would be desirable to be able to test it with qemu nvme
emulation.
This
Public bug reported:
Seeing this in qemu-user version 3.1.0
Demo:
$ QEMU_LD_PREFIX=$(pwd)/usr/armv7a-cros-linux-gnueabi ../run/qemu-arm
/tmp/coreutils --coreutils-prog=ls /
etc lib usr
$ ls /
boot etc lib lib64 lost+found mntroot sbin sys usr
bin dev export homelib32
Public bug reported:
Seeing this in qemu-user 3.1.0
The code in is_proc_myself which supports remapping of /proc/self/maps
and /proc//maps does not support remapping of
/proc/self/task//maps or /proc//task//maps. Extending
is_proc_myself to cover these cases causes the maps to be rewritten
correc
(dom, "vm", vm);
>
> /* memory */
> -xenstore_write_int(dom, "memory/target", ram_size >> 10); // kB
> -xenstore_write_int(vm, "memory", ram_size >> 20); // MB
> -xenstore_write_int(vm, "maxmem"
ry", ram_size / M_BYTE);
> +xenstore_write_int(vm, "maxmem", ram_size / M_BYTE);
>
Yes - Alan
smime.p7s
Description: S/MIME cryptographic signature
Public bug reported:
Found in QEMU 4.1, and reproduced on master.
QEMU appears to suffer from remarkably poor disk performance when
writing to sparse-extent VMDKs. Of course it's to be expected that
allocation takes time and sparse VMDKs peform worse than allocated
VMDKs, but surely not on the or
Thanks Stefan.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1875762
Title:
Poor disk performance on sparse VMDKs
Status in QEMU:
New
Bug description:
Found in QEMU 4.1, and reproduced on mas
size. There is no
need to
change the xml at this stage as it’ll be done the next time GDB uses the
description.
Blindly enabling the above when using a stub results in in GDB *constantly*
asking the
stub for a new XML description, spamming the pipe, so this needs something more
nuanced.
I plan on sending Luis my ideas I had for VG changing when using a stub.
>> But this is all special casing for feature
>> name="org.gnu.gdb.aarch64.sve" right?
>
> Yes, vg is only available if feature org.gnu.gdb.aarch64.sve is available.
Nod.
Alan.
> On 9 Jan 2020, at 12:08, Alex Bennée wrote:
>
>
> Alan Hayward writes:
>
>>> On 20 Dec 2019, at 13:18, Luis Machado wrote:
>>>
>>> On 12/20/19 10:14 AM, Alex Bennée wrote:
>>>> Luis Machado writes:
>>>>> On
On 9/24/24 5:15 AM, Klaus Jensen wrote:
On Sep 19 17:07, Alan Adamson wrote:
Adds support for the controller atomic parameters: AWUN and AWUPF. Atomic
Compare and Write Unit (ACWU) is not currently supported.
Writes that adhere to the ACWU and AWUPF parameters are guaranteed to be atomic
536
(requested block: offset=347799552, length=65536, flags=88)
Expected CRC: d54d5f50d2569c94
Received CRC: 691e1aed4669ba33
Future Work
---
- Namespace support (NAWUN, NAWUPF and NACWU)
- Namespace Boundary support (NABSN, NABO, and NABSPF)
- Atomic Compare and Write Unit
.
Signed-off-by: Alan Adamson
Reviewed-by: Klaus Jensen
---
hw/nvme/ctrl.c | 157 -
hw/nvme/nvme.h | 11
2 files changed, 167 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 9e94a2405407..c8346709a20d 100644
--- a
- Atomic Compare and Write Unit (ACWU)
Alan Adamson (1):
hw/nvme: add atomic write support
hw/nvme/ctrl.c | 164 -
hw/nvme/nvme.h | 12
2 files changed, 175 insertions(+), 1 deletion(-)
--
2.43.5
.
Signed-off-by: Alan Adamson
Reviewed-by: Klaus Jensen
---
hw/nvme/ctrl.c | 164 -
hw/nvme/nvme.h | 12
2 files changed, 175 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 9e94a2405407..0af46c57ee86 100644
--- a
Tested-by: Alan Adamson
Reviewed-by: Alan Adamson
le:
-device nvme-subsys,id=subsys0,cmic=on \
-device
nvme,serial=deadbeef,id=nvme0,subsys=subsys0,atomic.dn=off,atomic.awun=31,atomic.awupf=15
\
-drive id=ns1,file=/dev/nullb3,if=none \
-device nvme-ns,drive=ns1,bus=nvme0,nsid=1,shared=false
Alan Adamson (1):
hw/nvme: create
On 4/8/25 11:47 PM, Klaus Jensen wrote:
On Apr 8 15:56, Alan Adamson wrote:
While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Linux was
incorrectly displaying atomic_write_max_bytes
# cat /sys/block/nvme0n1/queue/atomic_write_max_bytes
0
# nvme id-ctrl /dev/nvme0n1 | grep awupf
Allow the value of CMIC to to be set via a new subsystem specific parameter.
This removes the requirement that all subsystems must have the CMIC bit enabled.
New NVMe Subsystem QEMU Parameter (See NVMe Specification for details):
,cmic=BOOLEAN (default: off)
Signed-off-by: Alan Adamson
Parameter (See NVMe Specification for details):
,cmic-mctrs=BOOLEAN (default: off)
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 15 ++-
hw/nvme/nvme.h | 2 ++
hw/nvme/subsys.c | 1 +
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme
v2: - Change the parameter name from "cmic" to "cmic-mctrs".
- If there is more than 1 controller in a subsystem, set CMIC.MCTRS
for each controller whether or not the cmic-mctrs parameter is set.
While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Linux was
incorrectly displa
Parameter (See NVMe Specification for details):
,cmic-mctrs=BOOLEAN (default: off)
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 15 ++-
hw/nvme/nvme.h | 2 ++
hw/nvme/subsys.c | 1 +
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme
systems.
,cmic-mctrs=BOOLEAN (default: off)
Example:
-device nvme-subsys,id=subsys0,cmic-mctrs=on \
-device
nvme,serial=deadbeef,id=nvme0,subsys=subsys0,atomic.dn=off,atomic.awun=31,atomic.awupf=15
\
-drive id=ns1,file=/dev/nullb0,if=none \
-device nvme-ns,drive=ns1,bus=nvm
llers.
I'm sending out diffs that resolve the problem but would like to get
some feedback before sending a formal patch.
See below.
Thanks,
Alan Adamson
[root@localhost qemu-subsys]# git describe
v10.0.0-rc2
[root@localhost qemu-subsys]#
QEMU NVMe Config
-device n
Reposting.
Alan
On 5/1/25 11:45 AM, Alan Adamson wrote:
If there are multiple controllers in a subsystem, CMIC.MCTRS should be set to on
for all controllers. For single controller subsystems, CMIC.MCTRS will be off by
default. A new subsystem specific parameter will allow setting CMIC.MCTRS
=UINT16 (default: 0)
See the NVMe Specification for more information.
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 53 ++
hw/nvme/ns.c | 36 ++
hw/nvme/nvme.h | 8
3 files changed, 97 insertions(+)
diff
NVMe Specification for more information.
Signed-off-by: Alan Adamson
---
hw/nvme/ctrl.c | 23 +++
hw/nvme/ns.c | 38 ++
hw/nvme/nvme.h | 6 ++
3 files changed, 67 insertions(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index fd935507
not subject to partial updates, thereby
improving
the robustness of atomic operations across boundaries.
See the NVMe Specification for more information.
Alan Adamson (2):
hw/nvme: enable ns atomic writes
hw/nvme: add atomic boundary support
hw/nv
where this was only set if an nvme-subsys device was explicitly
created (to configure a subsystem with multiple controllers/namespaces).
Revert the behavior to only set CMIC.MCTRS if an nvme-subsys device is
created explicitly.
Reported-by: Alan Adamson
Fixes: cd59f50ab017 ("hw/nvme: alwa
* Eric Blake (ebl...@redhat.com) wrote:
> On 08/07/2014 04:24 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > This is based on Stefan and Joel's patch that creates a QEMUFile that goes
> > to a memory buffer; from:
Hi
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: "Dr. David Alan Gilbert"
>
> This is based on Stefan and Joel's patch that creates a QEMUFile that goes
> to a memory buffer; from:
Actually, just spotted a bug in this; v4 coming shortly.
Dave
-kvm
> tree has been merged (or even before that), but it's been some
> years ago already.
It's amazing what different combinations of QEMU people have
out there; and it seems reasonable to let Alex fix this problem
if it helps him; there's no reason to deny others the same fix.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
es
> Cc: m...@redhat.com; qemu-devel@nongnu.org; arm...@redhat.com; Dr. David Alan
> Gilbert; aligu...@amazon.com; Anthony PERARD
> Subject: Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of
> VMWare ioport emulation
>
> Hi,
>
> > It was disabled in
* Slutz, Donald Christopher (dsl...@verizon.com) wrote:
> On 09/25/14 11:07, Dr. David Alan Gilbert wrote:
> > * Slutz, Donald Christopher (dsl...@verizon.com) wrote:
> >> What is happening with this patch? I would like to use this code.
> > I need to rework it for the new
* Eric Blake (ebl...@redhat.com) wrote:
> On 09/17/2014 05:26 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > This is based on Stefan and Joel's patch that creates a QEMUFile that goes
> > to a memory buffer; from:
tmap_try_new
use that and then fix up those users as we convert them to use the try?
Dave
>
> static inline void bitmap_zero(unsigned long *dst, long nbits)
> --
> 1.7.9.5
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
ey can confirm
> if they are OK with the copyright/license information being added.
Since it's come from vl.c that seems to make sense.
It should probably go to the stable branch as well, since reading the ~/LICENSE
file would make you think it's GPLd.
Reviewed-by: Dr. David Alan
I've updated our github at:
https://github.com/orbitfp7/qemu/tree/wp3-postcopy
to have this version.
and it corresponds to the tag:
https://github.com/orbitfp7/qemu/releases/tag/wp3-postcopy-v4
Dave
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote:
> From: "Dr. David
ither
1) get caught by userfault etc or
2) must succeed in it's access
and we'll have that happening somewhere between thousands and millions of times
to pages in no particular order, so we need to avoid creating millions of
mappings.
Dave
>
> Linus
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
e ago.
>
> Patch trades one bug for another. Hiding the menu bar also kills the
> accelerator keys, which is especially problematic for the fullscreen
> hotkey as there is no way out of fullscreen mode then.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Don Slutz (dsl...@verizon.com) wrote:
> Changes v1 to v2 (Don Slutz):
> make vmport a pc & q35 only machine opt I.E. a machine property.
>
> Dr. David Alan Gilbert (1):
> -machine vmport=off: Allow disabling of VMWare ioport emulation
Thanks for updating this!
Dave
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> >
> > I've seen it go negative once during dev, it shouldn't
> > happen.
>
> You can move it earlier, perhaps even as patch 1, since it does not
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > +static int postcopy_ram_sensitise_area(const char *block_name, void
> > *host_addr,
> > + ram_addr_t offset, r
* Eric Blake (ebl...@redhat.com) wrote:
> On 10/03/2014 11:47 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > Reviewed-by: Eric Blake
> > ---
> > inc
* Cristian Klein (cristian.kl...@cs.umu.se) wrote:
> On 04 Oct 2014, at 4:21 , Dr. David Alan Gilbert wrote:
>
> >
> > I've updated our github at:
> > https://github.com/orbitfp7/qemu/tree/wp3-postcopy
> >
> > to have this version.
> >
> >
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> >
> > +/* These are ORable flags */
>
> ... make them an "enum".
OK, will do - I'd generally tended to avoid using enum for things
that were O
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > +#ifndef WIN32
> > +if (rd) {
> > +how = SHUT_RD;
> > +}
> > +
> > +if (wr) {
> > +how = rd ? SHU
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 07/10/2014 10:58, Dr. David Alan Gilbert ha scritto:
> >
> >>> > > +if (exitcode & LOADVM_EXITCODE_QUITPARENT) {
> >>> > > +DPRINTF("loadvm_handlers_state_main: End of loop wit
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > +mis->postcopy_ram_state);
> > +if (mis->postcopy_ram_state == POSTCOPY_RAM_INCOMING_ADVISE) {
> > +/*
> > + * Where
emory.
Aren't DONTNEED and DONTDUMP similar cases of madvise operations that are
expected to do what they say ?
> I would suggest to consider to use some other interface for the
> functionality: a new syscall or, perhaps, mprotect().
Dave
> --
> Kirill A. Shutemov
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Kirill A. Shutemov (kir...@shutemov.name) wrote:
> On Tue, Oct 07, 2014 at 11:46:04AM +0100, Dr. David Alan Gilbert wrote:
> > * Kirill A. Shutemov (kir...@shutemov.name) wrote:
> > > On Fri, Oct 03, 2014 at 07:07:58PM +0200, Andrea Arcangeli wrote:
> > > > MADV_U
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto:
> > +/*
> > + * Don't break host-page chunks up with queue items
> > + * so only unqueue if,
> > + * a) The last
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Il 07/10/2014 19:07, Dr. David Alan Gilbert ha scritto:
> >> >
> >> > So I'd *much* rather have a "write()" style interface (ie _copying_
> >> > bytes from user space into a newly allocated p
lt is less general.
Dave
> remapping anonymous pages involves page table games that really aren't
> necessarily a good idea, and tlb invalidates for the old page etc.
> Just don't do it.
>
>Linus
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
("migrate_handle_rp_reqpages: at %zx for len %zx", start, len);
> >+DPRINTF("migrate_handle_rp_reqpages: in %s start %zx len %zx",
> >+rbname, start, len);
> >+
> >+/* Round everything up to our host page size */
> >+long our_host_ps
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> On 2014/10/8 15:49, Dr. David Alan Gilbert wrote:
> >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> >
> >>> typedef struct Visitor Visitor;
> >>>@@ -80,6 +81,6 @@ typedef struct FWCfg
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> On 2014/9/29 17:41, Dr. David Alan Gilbert (git) wrote:
> >+static ssize_t qsb_grow(QEMUSizedBuffer *qsb, size_t new_size)
> >+{
> >+size_t needed_chunks, i;
> >+
> >+if (qsb->size < new_si
+
> >+const QEMUSizedBuffer *qemu_buf_get(QEMUFile *f)
> >+{
> >+QEMUBuffer *p;
> >+
> >+qemu_fflush(f);
> >+
> >+p = f->opaque;
> >+
> >+return p->qsb;
> >+}
> >+
> >+static const QEMUFileOps buf_read_ops = {
> >+.get_buffer = buf_get_buffer,
> >+.close = buf_close,
> >+};
> >+
> >+static const QEMUFileOps buf_write_ops = {
> >+.put_buffer = buf_put_buffer,
> >+.close = buf_close,
> >+};
> >+
> >+QEMUFile *qemu_bufopen(const char *mode, QEMUSizedBuffer *input)
> >+{
> >+QEMUBuffer *s;
> >+
> >+if (mode == NULL || (mode[0] != 'r' && mode[0] != 'w') ||
> >+mode[1] != '\0') {
> >+error_report("qemu_bufopen: Argument validity check failed");
> >+return NULL;
> >+}
> >+
> >+s = g_malloc0(sizeof(QEMUBuffer));
> >+if (mode[0] == 'r') {
> >+s->qsb = input;
> >+}
> >+
> >+if (s->qsb == NULL) {
> >+s->qsb = qsb_create(NULL, 0);
> >+}
> >+if (!s->qsb) {
> >+g_free(s);
> >+error_report("qemu_bufopen: qsb_create failed");
> >+return NULL;
> >+}
> >+
> >+
> >+if (mode[0] == 'r') {
> >+s->file = qemu_fopen_ops(s, &buf_read_ops);
> >+} else {
> >+s->file = qemu_fopen_ops(s, &buf_write_ops);
> >+}
> >+return s->file;
> >+}
> >
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
d at least somewhere in the code of RDMA.
There's also RAM_SAVE_FLAG_CONTINUE that's used as a tweak to
make for smaller headers.
Dave
> For that matter, we could handle the hook separately and everything
> else in the switch statement. This would immediately solve the is
trace_vmstate_load_field_error(field->name, ret);
> return ret;
> }
Reviewed-by: Dr. David Alan Gilbert
I wonder about turning that trace into an error_report; the process is doomed
anyway at this point and it would be nice to know why.
Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Juan Quintela (quint...@redhat.com) wrote:
> This commit refactor the simple tests to test all integer types. We
> move to hex because it is easier to read values of different types.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/te
* Juan Quintela (quint...@redhat.com) wrote:
> Once there, make checkpatch happy.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
> ---
> hw/usb/hcd-ohci.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/usb
);
> +FIELD_EQUAL(d);
> +FIELD_NOT_EQUAL(e);
> +FIELD_NOT_EQUAL(f);
> +
> +SUCCESS(load_vmstate(&vmstate_simple_skipping, &obj, &obj_clone,
> + obj_versioned_copy, 2, wire_simple_skip,
> + sizeof(wire_simple_skip)));
> +
> +FIELD_EQUAL(skip_c_e);
> +FIELD_EQUAL(a);
> +FIELD_EQUAL(b);
> +FIELD_NOT_EQUAL(c);
> +FIELD_EQUAL(d);
> +FIELD_NOT_EQUAL(e);
> +FIELD_EQUAL(f);
> }
Couldn't those functions just be merged and take a flag?
> +#undef FIELD_EQUAL
> +#undef FIELD_NOT_EQUAL
>
> int main(int argc, char **argv)
> {
> @@ -490,12 +499,10 @@ int main(int argc, char **argv)
>
> g_test_init(&argc, &argv, NULL);
> g_test_add_func("/vmstate/simple/primitive", test_simple_primitive);
> -g_test_add_func("/vmstate/versioned/load/v1", test_load_v1);
> -g_test_add_func("/vmstate/versioned/load/v2", test_load_v2);
> -g_test_add_func("/vmstate/field_exists/load/noskip", test_load_noskip);
> -g_test_add_func("/vmstate/field_exists/load/skip", test_load_skip);
> -g_test_add_func("/vmstate/field_exists/save/noskip", test_save_noskip);
> -g_test_add_func("/vmstate/field_exists/save/skip", test_save_skip);
> +g_test_add_func("/vmstate/simple/v1", test_simple_v1);
> +g_test_add_func("/vmstate/simple/v2", test_simple_v2);
> +g_test_add_func("/vmstate/simple/skip", test_simple_skip);
> +g_test_add_func("/vmstate/simple/no_skip", test_simple_no_skip);
> g_test_run();
>
> close(temp_fd);
> --
> 1.9.3
>
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* Eric Blake (ebl...@redhat.com) wrote:
> On 07/10/2014 05:29 AM, Dr. David Alan Gilbert wrote:
> > * Paolo Bonzini (pbonz...@redhat.com) wrote:
> >> Il 07/07/2014 16:02, Dr. David Alan Gilbert ha scritto:
> >>>>> Could you have instead a "migra
* Eric Blake (ebl...@redhat.com) wrote:
> On 08/11/2014 08:29 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > ---
> > docs/migration.txt | 150
> >
ven QEMUSizedBuffer.
> > + *
> > + * @qsb : A QEMUSizedBuffer
> > + *
> > + * Returns a clone of @qsb
> > + */
> > +QEMUSizedBuffer *qsb_clone(const QEMUSizedBuffer *qsb)
> > +{
> > +QEMUSizedBuffer *out = qsb_create(NULL, qsb_get_length(qsb));
> > +size_t i;
> > +off_t pos = 0;
> > +
> > +for (i = 0; i < qsb->n_iov; i++) {
> > +pos += qsb_write_at(out, qsb->iov[i].iov_base,
> > +pos, qsb->iov[i].iov_len);
>
> If qsb_write_at() return -ENOMEM, just simply add it to pos ?
qsb_create uses g_new0 so it will abort on out of memory;
what should qsb_clone do if qsb_write_at returns -ENOMEM?
(Admittedly anything is better than getting the position wrong).
I guess the choice is to allow it to return NULL, tidying up
and offering the chance sometime in the future of tidying up
the other allocators.
Dave
>
> Best regards,
> -Gonglei
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> On 2014/8/11 22:29, Dr. David Alan Gilbert (git) wrote:
> >From: "Dr. David Alan Gilbert"
> >
> >+testarea2 = mmap(NULL, pagesize, PROT_READ | PROT_WRITE, MAP_PRIVATE |
> >+
1 - 100 of 8557 matches
Mail list logo
