Hi,
I'm getting a segfault for qemu-system-arm (git).
Git bisect points to 33e95c6328a3149a52615176617997c4f8f7088b.
Host is x86-32, I'm not getting it in a 64bit environment.
However, valgrind is showing a similar output for arm_gic_class_init and
arm_gic_init.
$ arm-softmmu/qemu-system-arm -M r
Hi,
On Sun Aug 03, 2014 at 21:36:21 +0200, Christoffer Dall wrote:
> On 3 August 2014 15:21, Peter Maydell wrote:
> > On 3 August 2014 09:53, Adam Lackorzynski wrote:
> >> Hi,
> >>
> >> the following three patches address the behavior of the GIC
On Fri Aug 15, 2014 at 14:07:14 +0200, Christoffer Dall wrote:
> On Sun, Aug 03, 2014 at 10:53:46AM +0200, Adam Lackorzynski wrote:
> > Writes to SGIs for GICD_ICFGR register must be ignored.
> >
> > Signed-off-by: Adam Lackorzynski
> > ---
> > hw/intc/arm_g
The GICD_ICFGR register covers 4 interrupts per byte.
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 1532ef9..d2b1aaf 100644
--- a/hw/intc
Setting the model is only available in pre-v1 GIC models.
---
hw/intc/arm_gic.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index d2b1aaf..e546647 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc/arm_gic.c
@@ -561,10 +561,12 @@ s
Only SGIs must be WI, done by forcing them to their default
(edge-triggered).
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index e546647..55019c9 100644
--- a/hw/intc/arm_gic.c
Adam Lackorzynski (3):
arm_gic: Fix read of GICD_ICFGR
arm_gic: GICD_ICFGR: Write model only for pre v1 GICs
arm_gic: Do not force PPIs to edge-triggered mode
hw/intc/arm_gic.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
--
2.1.0.rc1
On Fri Aug 15, 2014 at 14:12:17 +0200, Christoffer Dall wrote:
> On Sun, Aug 03, 2014 at 10:53:46AM +0200, Adam Lackorzynski wrote:
> > Writes to SGIs for GICD_ICFGR register must be ignored.
> >
> > Signed-off-by: Adam Lackorzynski
> > ---
> > hw/intc/arm_g
On Mon Aug 18, 2014 at 14:48:15 +0200, Christoffer Dall wrote:
> On Sat, Aug 16, 2014 at 09:48:21PM +0200, Adam Lackorzynski wrote:
> > Only SGIs must be WI, done by forcing them to their default
> > (edge-triggered).
> >
> > Signed-off-by: Adam Lackorzynski
> &g
The GICD_ICFGR register covers 4 interrupts per byte.
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 1532ef9..d2b1aaf 100644
--- a/hw/intc
Only SGIs must be WI, done by forcing them to their default
(edge-triggered).
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index e546647..55019c9
Setting the model is only available in pre-v1 GIC models.
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index d2b1aaf..e546647 100644
--- a
Use constant rather than a plain number.
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic_common.c b/hw/intc/arm_gic_common.c
index 6d884ec..18b01ba 100644
--- a/hw/intc/arm_gic_common.c
+++ b/hw
revisions
- Less invasive change for PPI settings
Adam Lackorzynski (4):
arm_gic: Fix read of GICD_ICFGR
arm_gic: GICD_ICFGR: Write model only for pre v1 GICs
arm_gic: Do not force PPIs to
Setting the model is only available in pre-v1 GIC models.
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index d2b1aaf..e546647 100644
--- a
The GICD_ICFGR register covers 4 interrupts per byte.
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 1532ef9..d2b1aaf 100644
--- a/hw/intc
Use constant rather than a plain number.
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic_common.c b/hw/intc/arm_gic_common.c
index 6d884ec..18b01ba 100644
--- a/hw/intc
Only SGIs must be WI, done by forcing them to their default
(edge-triggered).
Acked-by: Christoffer Dall
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index e546647..55019c9
model mode only for old GIC revisions
- Less invasive change for PPI settings
Adam Lackorzynski (4):
arm_gic: Fix read of GICD_ICFGR
arm_gic: GICD_ICFGR: Write model only for pre v1 GICs
On Mon Aug 18, 2014 at 16:30:51 +0200, Adam Lackorzynski wrote:
> The following patches address the behavior of the GICD_ICFGR register
> in the ARM GIC.
Any takers or comments?
> Changes to v3:
> - Tag patchset with proper version
>
> Changes to v2:
> - Replace 16 with
The GICD_ICFGR register covers 4 interrupts per byte.
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 1532ef9..d2b1aaf 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc/arm_gic.c
Writes to SGIs for GICD_ICFGR register must be ignored.
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index d2b1aaf..cd6e6ea 100644
--- a/hw/intc/arm_gic.c
+++ b/hw
supported.
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index cd6e6ea..066a7f2 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc/arm_gic.c
@@ -558,8 +558,6 @@ static void gic_dist_writeb(void *opaque
Hi,
the following three patches address the behavior of the GICD_ICFGR register
in the ARM GIC.
Adam Lackorzynski (3):
arm_gic: Fix read of GICD_ICFGR
arm_gic: SGIs for GICD_ICFGR are WI
arm_gic: GICD_ICFGR: Do not force edge-triggered PPIs
hw/intc/arm_gic.c | 15 ---
1 file
Support commas in the parameter list of multiboot modules, by using double
commas (via get_opt_value()).
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 394ed01
Support commas in the parameter list of multiboot modules, by using double
commas (via get_opt_value()).
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 6e6cfb9
Support commas in the parameter list of multiboot modules as well as for the
kernel command line, by using double commas (via get_opt_value()).
Signed-off-by: Adam Lackorzynski
Reviewed-by: Kevin Wolf
---
hw/multiboot.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions
following.
Comments?
Signed-off-by: Adam Lackorzynski
---
vl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index fcd7395..1459bde 100644
--- a/vl.c
+++ b/vl.c
@@ -886,6 +886,8 @@ static void smp_parse(const char *optarg)
max_cpus = strto
+ MBI_MODS_COUNT, mbs.mb_mods_count); /* mods_count */
>
> @@ -314,7 +335,8 @@ int load_multiboot(FWCfgState *fw_cfg,
> | MULTIBOOT_FLAGS_BOOT_DEVICE
> | MULTIBOOT_FLAGS_CMDLINE
> | MULTIBOOT_FLAGS_MOD
Hi,
I'm seeing the following segfault of qemu-system-i386 and
qemu-system-x86_64 with master. git bisect points to
258711c6448c44b60b0fecef1d3b09c71e23e304.
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xea930b70 (LWP 14297)]
0x in ?? ()
(gdb) bt
#0 0x000
> The previous behaviour of this both ioport is to return 0x.
> So keep this behaviour.
Thanks, confirmed.
> Reported-by: Adam Lackorzynski
> Signed-off-by: Julien Grall
Tested-by: Adam Lackorzynski
> ---
> hw/pc.c | 12
> 1 file changed, 12 inser
On Thu Apr 07, 2011 at 14:52:34 +0100, Stefan Hajnoczi wrote:
> On Thu, Apr 7, 2011 at 1:56 PM, Ralf Ramsauer
> wrote:
> > On 07.04.2011, at 14:48, Stefan Hajnoczi wrote:
> >
> >> Out of curiousity, why are you trying to kill spaces at all?
> >>
> >> Why not just use a correct command-line to inv
Quote filename in error message to spot possible whitespace character in
the filename.
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 0d2bfb4..6be6fa0 100644
--- a/hw/multiboot.c
Quote filename in error message to spot possible whitespace character in
the filename and make error message more meaningful.
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index
On Fri Apr 08, 2011 at 00:44:36 +0200, Alexander Graf wrote:
>
> On 07.04.2011, at 20:22, Adam Lackorzynski wrote:
>
> > Quote filename in error message to spot possible whitespace character in
> > the filename.
> >
> > Signed-off-by: Adam Lackorzynski
Support quoting of ',' (and '\') to allow commas in the parameter list of
modules.
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c | 33 +
1 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
in
On Fri Apr 15, 2011 at 15:17:28 +0200, Kevin Wolf wrote:
> Am 15.04.2011 09:56, schrieb Adam Lackorzynski:
> > Support quoting of ',' (and '\') to allow commas in the parameter list of
> > modules.
> >
> > Signed-off-by: Adam Lackorzynski
&
Support commas in the parameter list of modules, by using double commas
(via get_opt_value()).
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 394ed01..7d5cb22
Support commas in the parameter list of multiboot modules, by using double
commas (via get_opt_value()).
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 394ed01
Refine check on bkpt so that smc and undefined instruction encodings are
handled as an undefined instruction and trap.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target
A via -kernel supplied x86_64 ELF image is being started in 32bit mode.
Detect and exit if a 64bit image has been supplied.
Signed-off-by: Adam Lackorzynski
Acked-by: Alexander Graf
---
hw/multiboot.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/multiboot.c
Handle smc as an undefined instruction instead of having it wrongly
interpreted as some other one.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index
A via -kernel supplied x86_64 ELF image is being started in 32bit mode.
Detect and exit if a 64bit image has been supplied.
Signed-off-by: Adam Lackorzynski
Acked-by: Alexander Graf
---
hw/multiboot.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/multiboot.c
Handle smc as an undefined instruction instead of having it wrongly
interpreted as some other one.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index
On Thu Sep 02, 2010 at 23:14:23 +0100, Peter Maydell wrote:
> On Thu, Sep 02, 2010 at 11:40:50PM +0200, Adam Lackorzynski wrote:
> > +case 7:
> > +/* SMC? */
> > +if ((insn & 0xfff0) == 0xe1600070) {
> > +
Refine check on bkpt so that smc and undefined instruction encodings are
handled as an undefined instruction and trap.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target
A via -kernel supplied x86_64 ELF image is being started in 32bit mode.
Detect and exit if a 64bit image has been supplied.
Signed-off-by: Adam Lackorzynski
Acked-by: Alexander Graf
---
hw/multiboot.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/multiboot.c
Handle smc as undefined instruction instead of having it wrongly interpreted
as some other instruction.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
On Thu Mar 03, 2011 at 22:59:03 +, Peter Maydell wrote:
> On 21 February 2011 23:19, Adam Lackorzynski
> wrote:
> > diff --git a/target-arm/machine.c b/target-arm/machine.c
> > index 3925d3a..a18b7dc 100644
> > --- a/target-arm/machine.c
> > +++ b/target-ar
correctly
for newer cores. In particular, the old 0,c7,c8,2 encoding used on
ARM940 has been reused for VA-to-PA translation in v6 and v7.
Signed-off-by: Peter Maydell
Reviewed-by: Adam Lackorzynski
---
target-arm/translate.c | 35 ++-
1 files changed, 30 insertions
The following patches fix and enhance ARM related functionality.
Adam Lackorzynski (3):
target-arm: Fix soft interrupt in GIC distributor
target-arm: Implement cp15 VA->PA translation
target-arm: Integrate secondary CPU reset in arm_boot
Peter Maydell (1):
target-arm: Don't de
Implement VA->PA translations by cp15-c7 that went through unchanged
previously.
Signed-off-by: Adam Lackorzynski
---
target-arm/cpu.h |3 ++-
target-arm/helper.c | 48 ++--
target-arm/machine.c |2 ++
3 files changed, 50 inserti
Integrate secondary CPU reset into arm_boot, removing it from realview.c.
On non-Linux systems secondary CPUs start with the same entry as the boot
CPU.
Signed-off-by: Adam Lackorzynski
---
hw/arm_boot.c | 23 +++
hw/realview.c | 14 --
2 files changed, 15
Fix selection of target list filter mode.
Signed-off-by: Adam Lackorzynski
Reviewed-by: Peter Maydell
---
hw/arm_gic.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index e6b1953..0e934ec 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
CPUID claims that extended monitor/mwait features are available but the
mwait helper instantly raises a GPF if they are used. Thus do not announce
that the extension are available.
Signed-off-by: Adam Lackorzynski
---
target-i386/cpuid.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
Make smpboot available not only for Linux but for all setups.
Signed-off-by: Adam Lackorzynski
---
hw/arm_boot.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/hw/arm_boot.c b/hw/arm_boot.c
index 620550b..a68b396 100644
--- a/hw/arm_boot.c
+++ b/hw
Fix selection of target list filter mode.
Signed-off-by: Adam Lackorzynski
---
hw/arm_gic.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index e6b1953..0e934ec 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -549,10 +549,10 @@ static
Implement VA->PA translations by cp15-c7 that went through unchanged
previously.
Signed-off-by: Adam Lackorzynski
---
target-arm/cpu.h|1 +
target-arm/helper.c | 51 +--
2 files changed, 50 insertions(+), 2 deletions(-)
diff --gi
On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote:
> On 15 February 2011 10:48, Adam Lackorzynski
> wrote:
> > Make smpboot available not only for Linux but for all setups.
>
> I'm not convinced about this. I think if you're providing a raw
> image f
On Tue Feb 15, 2011 at 13:37:44 +, Peter Maydell wrote:
> On 15 February 2011 13:12, Adam Lackorzynski
> wrote:
> >
> > On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote:
> >> On 15 February 2011 10:48, Adam Lackorzynski
> >> wrote:
> &
Hi,
On Tue Feb 15, 2011 at 10:02:05 -0500, Vincent Palatin wrote:
> >> Moving in the right direction, but it would be cleaner if the secondary
> >> CPU reset was handled inside arm_boot.c, I think (there is a TODO
> >> in that file to that effect). Then we could get rid of the cpu reset
> >> hook
Hi,
thanks for the review!
On Wed Feb 16, 2011 at 15:57:59 +, Peter Maydell wrote:
> On 15 February 2011 10:49, Adam Lackorzynski
> wrote:
> > Implement VA->PA translations by cp15-c7 that went through unchanged
> > previously.
>
> > + uint32_t
Integrate secondary CPU reset into arm_boot, removing it from realview.c.
On non-Linux systems secondary CPUs start with the same entry as the boot
CPU.
Signed-off-by: Adam Lackorzynski
---
hw/arm_boot.c | 23 +++
hw/realview.c | 14 --
2 files changed, 15
Implement VA->PA translations by cp15-c7 that went through unchanged
previously.
Signed-off-by: Adam Lackorzynski
---
target-arm/cpu.h |1 +
target-arm/helper.c | 48 ++--
target-arm/machine.c |2 ++
3 files changed, 49 insertions(+)
The following patches fix and enhance ARM related functionality.
Adam Lackorzynski (3):
target-arm: Fix soft interrupt in GIC distributor
target-arm: Implement cp15 VA->PA translation
target-arm: Integrate secondary CPU reset in arm_boot
hw/arm_boot.c|
Fix selection of target list filter mode.
Signed-off-by: Adam Lackorzynski
Reviewed-by: Peter Maydell
---
hw/arm_gic.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index e6b1953..0e934ec 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
oding of the cp15 WFI instructions so that they behave correctly
> for newer cores. In particular, the old 0,c7,c8,2 encoding used on
> ARM940 has been reused for VA-to-PA translation in v6 and v7.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Adam Lackorzynski
> ---
> This
Handle smc as an undefined instruction instead of having it wrongly
interpreted as some other one.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index
Handle smc as an undefined instruction instead of having it wrongly
interpreted as some other one.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index
Correct the calculation of the offset in the msrpm
for the MSR range 0 - 0x1fff.
Signed-off-by: Adam Lackorzynski
---
target-i386/op_helper.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index c50e818..ec6b3e9
A via -kernel supplied x86_64 ELF image is being started in 32bit mode.
Detect and exit if a 64bit image has been supplied.
Signed-off-by: Adam Lackorzynski
---
hw/multiboot.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index
On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote:
>
> On 19.08.2010, at 13:24, Adam Lackorzynski wrote:
>
> > A via -kernel supplied x86_64 ELF image is being started in 32bit mode.
> > Detect and exit if a 64bit image has been supplied.
>
> According to
On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote:
>
> On 19.08.2010, at 13:36, Adam Lackorzynski wrote:
>
> >
> > On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote:
> >>
> >> On 19.08.2010, at 13:24, Adam Lackorzynski wrote:
> &
On Thu Aug 19, 2010 at 14:34:10 +0200, Alexander Graf wrote:
>
> On 19.08.2010, at 14:32, Adam Lackorzynski wrote:
>
> >
> > On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote:
> >>
> >> On 19.08.2010, at 13:36, Adam Lackorzynski wrote:
> >
There's a return missing in the srs handling which leads to srs always being
treated an an invalid op.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
The rfe instruction can be used with any register, not just sp. Adjust the
condition check accordingly.
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index
Signed-off-by: Adam Lackorzynski
---
hw/debugcon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/debugcon.c b/hw/debugcon.c
index d549091..5ee6821 100644
--- a/hw/debugcon.c
+++ b/hw/debugcon.c
@@ -60,7 +60,7 @@ static uint32_t debugcon_ioport_read(void *opaque
Signed-off-by: Adam Lackorzynski
---
target-i386/op_helper.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index 22259df..dcbdfe7 100644
--- a/target-i386/op_helper.c
+++ b/target-i386/op_helper.c
@@ -1231,7 +1231,7
Signed-off-by: Adam Lackorzynski
---
target-arm/translate.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 0eccca5..afd6716 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -6344,7 +6344,11
multiboot: Fix module loading and setting of mmap.
Signed-off-by: Adam Lackorzynski
Acked-by: Alexander Graf
---
hw/pc.c |2 +-
pc-bios/multiboot.bin | Bin 512 -> 1024 bytes
pc-bios/optionrom/multiboot.S |5 -
3 files changed, 5 insertions(+)
multiboot: Support arbitrary number of modules
Signed-off-by: Adam Lackorzynski
---
hw/pc.c | 216 +-
1 files changed, 143 insertions(+), 73 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 6bcfe1b..163bec1 100644
--- a/hw/pc.c
multiboot: Support arbitrary number of modules.
Addressed comments by Anthony.
Signed-off-by: Adam Lackorzynski
---
hw/pc.c | 260 ++
1 files changed, 159 insertions(+), 101 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 8c1b7ea
multiboot: Separate multiboot loading into separate file
Move multiboot loading functionality to a separate file as suggested by
Alex Graf.
Signed-off-by: Adam Lackorzynski
---
Makefile.target |2 +-
hw/multiboot.c | 318 +++
hw
mode?).
>
> mb_buf_phys should not be a u32. It should be a target address type.
The spec defines all values as u32 but since the offsets are relative to
mb_buf_phys I've made them of type target_phys_addr_t too.
Signed-off-by: Adam Lackorzynski
---
hw/pc.c | 268 +++
Move multiboot loading code into a separate files as suggested by Alex Graf.
Signed-off-by: Adam Lackorzynski
---
Makefile.target |2 +-
hw/multiboot.c | 326 +++
hw/multiboot.h | 12 ++
hw/pc.c | 300
multiboot: Support arbitrary number of modules.
Signed-off-by: Adam Lackorzynski
---
hw/pc.c | 268 +++
1 files changed, 167 insertions(+), 101 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index db7d58e..2f5b3a1 100644
--- a/hw/pc.c
multiboot: Separate multiboot loading into separate file
Move multiboot loading code into a separate file as suggested by Alex Graf.
Signed-off-by: Adam Lackorzynski
---
Makefile.target |2 +-
hw/multiboot.c | 326 +++
hw/multiboot.h
Signed-off-by: Adam Lackorzynski
---
hw/pc.c | 268 +++
1 files changed, 167 insertions(+), 101 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 83f8dd0..2dca777 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -51,6 +51,12 @@
/* Show
Move multiboot loading code into separate files as suggested by Alex Graf.
Signed-off-by: Adam Lackorzynski
---
Makefile.target |2 +-
hw/multiboot.c | 331 +++
hw/multiboot.h | 12 ++
hw/pc.c | 305
Hi,
On Mon Oct 19, 2009 at 10:30:12 +0200, Kevin Wolf wrote:
> Am 14.10.2009 18:11, schrieb Adam Lackorzynski:
> > Subject: [PATCH 3/3] multiboot: Support arbitrary number of modules
> >
> > Signed-off-by: Adam Lackorzynski
>
> Looks good in general. I'm a
Hi,
I need to following to fix multiboot booting for me.
Should linuxboot.bin and multiboot.bin end up in pc-bios instead of
pc-bios/optionrom?
Signed-off-by: Adam Lackorzynski
---
hw/pc.c |4 ++--
pc-bios/optionrom/multiboot.S |5 -
2 files changed, 6
On Wed Nov 18, 2009 at 15:33:10 +0100, Alexander Graf wrote:
> Adam Lackorzynski wrote:
> > I need to following to fix multiboot booting for me.
> >
> > Should linuxboot.bin and multiboot.bin end up in pc-bios instead of
> > pc-bios/optionrom?
>
> >
Hi,
On Thu May 17, 2007 at 14:06:57 -0700, H. Peter Anvin wrote:
> +/* Generate an initial boot sector which sets state and jump to
> + a specified vector */
> +static int generate_bootsect(uint32_t gpr[8], uint16_t segs[6], uint16_t ip)
> +{
> +uint8_t bootsect[512], *p;
> +int i;
> +
>
Hi,
I think there's a small issue with the pl110 emulation.
LCDIMSC and LCDControl are swapped depending whether versatile is used
as a platform or not. This is done in the write function but not in the
read function where it also should be done.
Possible patch:
Index: pl110.c
==
Hi,
this patch fixes two typos in the gic_cpu_write and gic_cpu_read
functions of arm_gic.c.
Index: arm_gic.c
===
RCS file: /sources/qemu/qemu/hw/arm_gic.c,v
retrieving revision 1.5
diff -u -r1.5 arm_gic.c
--- arm_gic.c 3 Jun 2007
Hello,
this patch fixes two typos in the gic_cpu_write and gic_cpu_read
functions of arm_gic.c.
Index: hw/arm_gic.c
===
RCS file: /sources/qemu/qemu/hw/arm_gic.c,v
retrieving revision 1.5
diff -u -r1.5 arm_gic.c
--- hw/arm_gic.c
Hi,
the priority array of the gic_state structure contains 96 elements but
gic_set_running_irq is also called with irq == 1023 so that without the
fix some random value is used for s->running_priority.
The printf patch is necessary to make the DPRINTFs work.
Index: arm_gic.c
==
Hi,
I'd like to have "make install prefix=/some/other/dir" work, the files
will be linked/moved to their final destination later (e.g. /usr/local).
The following modification makes this possible.
Index: configure
===
RCS file: /cvsr
ähnel
Signed-off-by: Adam Lackorzynski
---
pc-bios/multiboot.bin | Bin 1024 -> 1536 bytes
pc-bios/optionrom/multiboot.S | 10 ++---
pc-bios/optionrom/optionrom.h | 77 ++
3 files changed, 82 insertions(+), 5 deletions(-)
diff --git a/pc-bios/multiboot.
Hi,
On Tue Jun 13, 2017 at 17:05:41 -0700, Anatol Pomozov wrote:
> Do these arguments sound reasonable to apply the patch?
I'm not really convinced.
> On Thu, Jun 8, 2017 at 2:07 PM, Anatol Pomozov
> wrote:
> > +reply-all
> >
> > On Thu, Jun 8, 2017 at 1:41
1 - 100 of 109 matches
Mail list logo
