RE: [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE

>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE > >On 6/11/25 04:42, Zhenzhong Duan wrote: >> Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). >> It should be sizeof(VFIOPCIDevice), VFIO_PCI uses same

Re: [PATCH v5 00/10] target/i386/kvm/pmu: PMU Enhancement, Bugfix and Cleanup

Hi Zhao, On 6/9/25 5:26 AM, Zhao Liu wrote: > Hi Dongli, > > Since the patch 3 was merged. I think you can rebase this series. > I will rebase the series. Thank you very much! Dongli Zhang

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

On Wed, 11 Jun 2025 08:47:36 +0200 Eric Auger wrote: > Hi Igor, > > On 5/27/25 1:58 PM, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:04 +0200 > > Eric Auger wrote: > > > >> acpi_pcihp VirtMachineClass state flag will allow > >> to opt in for acpi pci hotplug. This is guarded by a > >> c

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

On Wed, 11 Jun 2025 08:53:28 +0200 Eric Auger wrote: > Hi Gustavo, Alex, > > On 5/28/25 12:33 PM, Igor Mammedov wrote: > > On Tue, 27 May 2025 15:54:15 +0200 > > Eric Auger wrote: > > > >> Hi Igor, > >> > >> On 5/27/25 1:58 PM, Igor Mammedov wrote: > >>> On Tue, 27 May 2025 09:40:04 +0200 >

Re: [PATCH v3 04/23] vfio: mark posted writes in region write callbacks

On 6/7/25 02:10, John Levon wrote: For vfio-user, the region write implementation needs to know if the write is posted; add the necessary plumbing to support this. Signed-off-by: John Levon Reviewed-by: Cédric Le Goater Applied to vfio-next. Thanks, C. --- include/hw/vfio/vfio-device

Re: [PATCH v5 3/7] vhost_user.rst: Add SHMEM_MAP/_UNMAP to spec

On Wed, Jun 11, 2025 at 8:21 AM Alyssa Ross wrote: > > Albert Esteve writes: > > > Add SHMEM_MAP/_UNMAP request to the vhost-user > > spec documentation. > > > > Reviewed-by: Stefan Hajnoczi > > Signed-off-by: Albert Esteve > > --- > > docs/interop/vhost-user.rst | 55 +

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

On Tue, 10 Jun 2025 11:29:02 -0300 Gustavo Romero wrote: > Hi Igor, > > On 6/2/25 03:06, Gustavo Romero wrote: > > Hi Igor and Eric, > > > > I'm sending again this to the mailing list since it seems the first one > > got lost... I can't find it either in qemu-devel@ or in qemu-arm@ :( > > > >

Re: [PATCH 23/31] hw/nvme/ctrl: skip automatic zero-init of large arrays

On Jun 10 13:37, Daniel P. Berrangé wrote: > The 'nvme_map_sgl' method has a 256 element array used for copying > data from the device. Skip the automatic zero-init of this array > to eliminate the performance overhead in the I/O hot path. > > The 'segment' array will be fully initialized when rea

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

On 6/11/25 10:49 AM, Igor Mammedov wrote: > On Wed, 11 Jun 2025 08:47:36 +0200 > Eric Auger wrote: > >> Hi Igor, >> >> On 5/27/25 1:58 PM, Igor Mammedov wrote: >>> On Tue, 27 May 2025 09:40:04 +0200 >>> Eric Auger wrote: >>> acpi_pcihp VirtMachineClass state flag will allow to opt

Re: [PATCH preview 0/3] reviving minimal QAPI generation from 2021

On Wed, Jun 11, 2025 at 9:52 AM Zhao Liu wrote: > As patch 3 did, qapi will generate Rust types: > > - char* is mapped to String, scalars to there corresponding Rust types > - enums are simply aliased from FFI > - has_foo/foo members are mapped to Option > - lists are represented as Vec Yep, so f

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

On Wed, Jun 11, 2025 at 09:46:15AM +0200, Cédric Le Goater wrote: > > > can't we simply have a CONFIG option and select the device on platforms > > > supporting it ? > > > > You mean always build vfio-user client rather than optionally? Why would it > > be > > different from other optional compo

Re: [PATCH v2 06/25] hw/pci-host/gpex-acpi: Propagate hotplug type info from virt machine downto gpex

Hi Igor, On 5/27/25 2:33 PM, Igor Mammedov wrote: > On Tue, 27 May 2025 09:40:08 +0200 > Eric Auger wrote: > >> Propagate the type of pci hotplug mode downto the gpex >> acpi code. In case machine acpi_pcihp is unset we configure >> pci native hotplug on pci0. For expander bridges we keep >> lega

Re: [PATCH 4/5] configure: Add dtc option

On Wed, Jun 11, 2025 at 02:37:08AM +0200, BALATON Zoltan wrote: > On Tue, 10 Jun 2025, Bernhard Beschow wrote: > > The next patch will make dtc mandatory for boards with a bundled DTB, > > causing > > these boards to be omitted when dtc is missing. Allow packagers to force the > > build of those b

Re: [PATCH 25/31] hw/ppc/spapr_tpm_proxy: skip automatic zero-init of large arrays

On 6/10/25 18:07, Daniel P. Berrangé wrote: The 'tpm_execute' method has a pair of 4k arrays used for copying data between guest and host. Skip the automatic zero-init of these arrays to eliminate the performance overhead in the I/O hot path. The two arrays will be fully initialized when read

Re: [PATCH 2/5] rust: hpet: fully initialize object after instance_init

On Mon, Jun 09, 2025 at 05:44:20PM +0200, Paolo Bonzini wrote: > Date: Mon, 9 Jun 2025 17:44:20 +0200 > From: Paolo Bonzini > Subject: [PATCH 2/5] rust: hpet: fully initialize object after instance_init > X-Mailer: git-send-email 2.49.0 > > The array of BqlRefCell is not initialized yet at the >

Re: [PATCH v2 0/1] Add RISCV ZALASR Extension

On 11/06/2025 05:31, Alistair Francis wrote: On Tue, Jun 10, 2025 at 6:33 PM Roan Richmond wrote: Ping, resending as no responses in over week. V2: - rebased patch onto master branch - added check for RV64() for Load Double, as pointed out by Alistair Palmer. In response to Alistair Pa

Re: [PATCH 1/5] rust: qemu_api: introduce MaybeUninit field projection

On Mon, Jun 09, 2025 at 05:44:19PM +0200, Paolo Bonzini wrote: > Date: Mon, 9 Jun 2025 17:44:19 +0200 > From: Paolo Bonzini > Subject: [PATCH 1/5] rust: qemu_api: introduce MaybeUninit field projection > X-Mailer: git-send-email 2.49.0 > > Add a macro that makes it possible to convert a MaybeUni

Re: [PATCH v2 2/2] rust/hw/char/pl011/src/device: Implement logging

On Tue, Jun 10, 2025 at 11:21 PM Bernhard Beschow wrote: > > Now that there is logging support in Rust for QEMU, use it in the pl011 > device. > > Signed-off-by: Bernhard Beschow > --- > rust/hw/char/pl011/src/device.rs | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > dif

Re: [PATCH v1 01/15] intel_iommu: Rename vtd_ce_get_rid2pasid_entry to vtd_ce_get_pasid_entry

On 2025/6/6 18:04, Zhenzhong Duan wrote: In early days vtd_ce_get_rid2pasid_entry() was used to get pasid entry of rid2pasid, then it was extended to get any pasid entry. So a new name vtd_ce_get_pasid_entry is better to match what it actually does. No functional change intended. Signed-off-by:

Re: [PATCH v3 03/23] vfio: add per-region fd support

On 6/7/25 02:10, John Levon wrote: For vfio-user, each region has its own fd rather than sharing vbasedev's. Add the necessary plumbing to support this, and use the correct fd in vfio_region_mmap(). Signed-off-by: John Levon Reviewed-by: Cédric Le Goater Applied to vfio-next. Thanks, C.

Re: [PATCH v3 03/23] vfio: add per-region fd support

On 6/10/25 14:34, John Levon wrote: On Tue, Jun 10, 2025 at 09:42:41AM +0200, Cédric Le Goater wrote: On 6/7/25 02:10, John Levon wrote: For vfio-user, each region has its own fd rather than sharing vbasedev's. Add the necessary plumbing to support this, and use the correct fd in vfio_region_m

Re: [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE

On 6/11/25 04:42, Zhenzhong Duan wrote: Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). It should be sizeof(VFIOPCIDevice), VFIO_PCI uses same structure as base class VFIO_PCI_BASE, so no need to set its instance_size explicitly. This isn't catastrophic only because VFIO

Re: [PATCH v2 2/2] rust/hw/char/pl011/src/device: Implement logging

On 6/10/25 22:21, Bernhard Beschow wrote: Now that there is logging support in Rust for QEMU, use it in the pl011 device. Adding also this to match the C code: diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.rs index 42dfa9509dc..e505abfae86 100644 --- a/rust/hw/ch

Re: [PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

On 6/10/25 22:21, Bernhard Beschow wrote: +/// A macro to log messages conditionally based on a provided mask. +/// +/// The `log_mask` macro checks whether the given mask matches the current log +/// level and, if so, formats and logs the message. It is the Rust counterpart +/// of the qemu_log_

Re: [PATCH 24/31] hw/ppc/pnv_occ: skip automatic zero-init of large struct

On 6/10/25 18:07, Daniel P. Berrangé wrote: The 'occ_model_tick' method has a 12k struct used for copying data between guest and host. Skip the automatic zero-init of this struct to eliminate the performance overhead in the I/O hot path. The 'dynamic_data' buffer will be fully initialized whe

Re: [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE

On Wed, Jun 11, 2025 at 10:42:28AM +0800, Zhenzhong Duan wrote: > Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). > It should be sizeof(VFIOPCIDevice), VFIO_PCI uses same structure as > base class VFIO_PCI_BASE, so no need to set its instance_size explicitly. > > This isn

Re: [PATCH 1/5] hw: Fix type constant for DTB files

On 10/06/2025 22.41, Bernhard Beschow wrote: Commit fcb1ad456c58 ("system/datadir: Add new type constant for DTB files") introduced a new type constant for DTB files and converted the boards with bundled device trees to use it. Convert the other boards for consistency. Fixes: fcb1ad456c58 ("syst

Re: [PATCH v2] linux-user: fix resource leaks in gen-vdso

Ping for review/acks On Tue, May 13, 2025 at 04:03:46PM +0100, Daniel P. Berrangé wrote: > There are a number of resource leaks in gen-vdso. In theory they are > harmless because this is a short lived process, but when building QEMU > with --extra-cflags="-fsanitize=address" problems ensure. The g

RE: [PATCH v1 02/15] intel_iommu: Optimize context entry cache utilization

>-Original Message- >From: Liu, Yi L >Subject: Re: [PATCH v1 02/15] intel_iommu: Optimize context entry cache >utilization > >On 2025/6/6 18:04, Zhenzhong Duan wrote: >> There are many call sites referencing context entry by calling >> vtd_dev_to_context_entry() which will traverse the D

Re: [PATCH 2/5] pc-bios/dtb/meson: Prefer target name to be outfile, not infile

On 10/06/2025 22.41, Bernhard Beschow wrote: Makes this custom_target() usage consistent with other ones in QEMU. Fixes: 6e0dc9d2a88a ("meson: compile bundled device trees") Signed-off-by: Bernhard Beschow --- pc-bios/dtb/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH 3/5] scripts/meson-buildoptions: Sort coroutine_backend choices lexicographically

On 10/06/2025 22.41, Bernhard Beschow wrote: When changing meson_options.txt, this script gets updated automatically by QEMU tooling which sorts the choices lexicographically. Fix this in preparation of the ext patch. s/ext/next/ Fixes: ccc403ed5844 ("meson: Add wasm build in build scripts")

Re: [PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

Il mer 11 giu 2025, 12:21 Bernhard Beschow ha scritto: > Am 11. Juni 2025 07:56:23 UTC schrieb Paolo Bonzini : > >Clippy complains that it wants `` around the function name. > > Will fix in v3. > While at it, please run it through rustfmt and add a "//!" comment at the top, such as "Bindings for

RE: [PATCH v1 05/15] intel_iommu: Introduce two helpers vtd_as_from/to_iommu_pasid_locked

>-Original Message- >From: Liu, Yi L >Subject: Re: [PATCH v1 05/15] intel_iommu: Introduce two helpers >vtd_as_from/to_iommu_pasid_locked > >On 2025/6/6 18:04, Zhenzhong Duan wrote: >> We already have vtd_find_add_as() to find an AS from BDF+pasid, but this >> pasid is passed from PCI su

[PATCH] vfio: improve VFIODeviceIOOps docs

Explicitly describe every parameter rather than summarizing. Signed-off-by: John Levon --- include/hw/vfio/vfio-device.h | 52 +-- 1 file changed, 43 insertions(+), 9 deletions(-) diff --git a/include/hw/vfio/vfio-device.h b/include/hw/vfio/vfio-device.h index f3

Re: [PATCH] vfio: improve VFIODeviceIOOps docs

On 6/11/25 12:47, John Levon wrote: Explicitly describe every parameter rather than summarizing. Signed-off-by: John Levon Reviewed-by: Cédric Le Goater Applied to vfio-next. Thanks, C. --- include/hw/vfio/vfio-device.h | 52 +-- 1 file changed, 43 i

Re: [PATCH v3 05/23] vfio-user: introduce vfio-user protocol specification

On 6/7/25 02:10, John Levon wrote: From: Thanos Makatos This patch introduces the vfio-user protocol specification (formerly known as VFIO-over-socket), which is designed to allow devices to be emulated outside QEMU, in a separate process. vfio-user reuses the existing VFIO defines, structs and

Re: [PATCH v12 2/6] arm/virt.c: add cache hierarchy to device tree

On Thu, 5 Jun 2025 17:44:52 +0800 Zhao Liu wrote: > Hi Ali, > > I'm very sorry to bother you with some comments after so many > versions. > > > diff --git a/hw/cpu/core.c b/hw/cpu/core.c > > index 5cb2e9a7f5..7339782663 100644 > > --- a/hw/cpu/core.c > > +++ b/hw/cpu/core.c > > core.c is not

Re: [PATCH 4/5] configure: Add dtc option

On Wed, 11 Jun 2025, Daniel P. Berrangé wrote: On Wed, Jun 11, 2025 at 02:37:08AM +0200, BALATON Zoltan wrote: On Tue, 10 Jun 2025, Bernhard Beschow wrote: The next patch will make dtc mandatory for boards with a bundled DTB, causing these boards to be omitted when dtc is missing. Allow package

Re: [PATCH v3 1/2] tests/migration: Setup pre-listened cpr.sock to remove race-condition.

Jaehoon Kim writes: Hi, These patches should be the other way around, first add the support, then add the test. > When the source VM attempts to connect to the destination VM's Unix > domain socket (cpr.sock) during a cpr-transfer test, race conditions can > occur if the socket file isn't ready

Re: [PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

On Wed, Jun 11, 2025 at 2:05 PM Paolo Bonzini wrote: > > On Wed, Jun 11, 2025 at 12:57 PM Manos Pitsidianakis > wrote: > > > Maybe we could take this chance to remove the requirement for trailing > > newline? Not urgent, and also something we could change afterwards > > anyway. We could also intr

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

Hi Jonathan, On 5/30/25 12:02 PM, Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:07 +0200 > Eric Auger wrote: > >> acpi_dsdt_add_pci_osc() name is confusing as it gives the impression >> it appends the _OSC method but in fact it also appends the _DSM method >> for the host bridge. Let's spli

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

Hi Jonathan On 5/30/25 12:02 PM, Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:07 +0200 > Eric Auger wrote: > >> acpi_dsdt_add_pci_osc() name is confusing as it gives the impression >> it appends the _OSC method but in fact it also appends the _DSM method >> for the host bridge. Let's split

Re: [PATCH v2 04/25] hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to acpi_dsdt_add_pci_osc

Hi Jonathan, On 5/30/25 11:27 AM, Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:06 +0200 > Eric Auger wrote: > >> Add a new argument to acpi_dsdt_add_pci_osc to be able to disable >> native pci hotplug. >> >> Signed-off-by: Eric Auger >> Reviewed-by: Gustavo Romero > Hi Eric, > > Makes me

Re: [PATCH v3 1/2] tests/migration: Setup pre-listened cpr.sock to remove race-condition.

On 6/11/2025 8:08 AM, Fabiano Rosas wrote: Jaehoon Kim writes: Hi, These patches should be the other way around, first add the support, then add the test. When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions

Re: [PATCH v2 09/25] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

On 5/30/25 12:05 PM, Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:11 +0200 > Eric Auger wrote: > >> gpex build_host_bridge_osc() and x86 originated >> build_pci_host_bridge_osc_method() are mostly identical. >> >> In GPEX, SUPP is set to CDW2 but is not further used. CTRL >> is same as L

Re: [PATCH v3 2/2] migration: Support fd-based socket address in cpr_transfer_input

On 6/10/2025 6:33 PM, Jaehoon Kim wrote: Extend cpr_transfer_input to handle SOCKET_ADDRESS_TYPE_FD alongside SOCKET_ADDRESS_TYPE_UNIX. This change supports the use of pre-listened socket file descriptors for cpr migration channels. This change is particularly useful in qtest environments, where

Re: [PATCH v2 06/25] hw/pci-host/gpex-acpi: Propagate hotplug type info from virt machine downto gpex

Hi Jonathan, On 5/30/25 12:14 PM, Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:08 +0200 > Eric Auger wrote: > >> Propagate the type of pci hotplug mode downto the gpex >> acpi code. In case machine acpi_pcihp is unset we configure >> pci native hotplug on pci0. For expander bridges we keep

Re: [PATCH] ui/vnc: Update display update interval when VM state changes to RUNNING

On Wed, May 21, 2025 at 05:16:13PM +0200, Juraj Marcin wrote: > From: Juraj Marcin > > If a virtual machine is paused for an extended period time, for example, > due to an incoming migration, there are also no changes on the screen. > VNC in such case increases the display update interval by > VN

Re: [PATCH V5 23/38] backends/iommufd: change process ioctl

On 6/10/25 17:39, Steve Sistare wrote: Define the change process ioctl Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater Thanks, C. --- include/system/iommufd.h | 3 +++ backends/iommufd.c | 24 backends/trace-events| 1 + 3 files chan

Re: [PATCH V5 27/38] vfio/iommufd: add vfio_device_free_name

On 6/10/25 17:39, Steve Sistare wrote: Define vfio_device_free_name to free the name created by vfio_device_get_name. A subsequent patch will do more there. No functional change. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-device.h

Re: [PATCH] ui/vnc: Update display update interval when VM state changes to RUNNING

Hi On Wed, Jun 11, 2025 at 4:34 PM Peter Xu wrote: > On Wed, May 21, 2025 at 05:16:13PM +0200, Juraj Marcin wrote: > > From: Juraj Marcin > > > > If a virtual machine is paused for an extended period time, for example, > > due to an incoming migration, there are also no changes on the screen. >

Re: [PULL 0/2] Seabios 1.17.0 20250611 patches

ository at: https://gitlab.com/kraxel/qemu.git tags/seabios-1.17.0-20250611-pull-request for you to fetch changes up to cba36cf3881e907553ba2de38abd5edf7f952de1: seabios: update binaries to 1.17.0 (2025-06-11 09:45:00 +0200) seabi

[PULL 05/31] chardev/char-pty: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'pty_chr_read' method has a 4k byte array used for copying data between the PTY and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when reading data off the PTY.

[PULL 0/1] Tracing patches

The following changes since commit bc98ffdc7577e55ab8373c579c28fe24d600c40f: Merge tag 'pull-10.1-maintainer-may-2025-070625-1' of https://gitlab.com/stsquad/qemu into staging (2025-06-07 15:08:55 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/traci

[PULL 31/31] net/stream: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'net_stream_send' method has a 68k byte array used for copying data between guest and host. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf1' array will be fully initialized when reading data off the netw

Re: [PATCH 00/31] Skip automatic zero-init of large arrays / structs in I/O paths

On Tue, Jun 10, 2025 at 01:36:38PM +0100, Daniel P. Berrangé wrote: > This series is an extension of Stefan's proposal: > > https://lists.nongnu.org/archive/html/qemu-devel/2025-06/msg00736.html > > It used '-Wframe-larger-than=4096' to identify all code locations > with more than 4k on the sta

Re: [PULL 0/2] Seabios 1.17.0 20250611 patches

Merge tag 'pull-10.1-maintainer-may-2025-070625-1' of > > https://gitlab.com/stsquad/qemu into staging (2025-06-07 15:08:55 -0400) > > > > are available in the Git repository at: > > > > https://gitlab.com/kraxel/qemu.git > > tags/seabios-1.17.0-20

[PULL 10/31] hw/audio/gus: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'GUS_read_DMA' method has a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initialized when reading data

[PULL 08/31] hw/audio/cs4231a: skip automatic zero-init of large arrays

From: Daniel P. Berrangé The 'cs_write_audio' method has a pair of byte arrays, one 4k in size and one 8k, which are used in converting audio samples. Skip the automatic zero-init of these arrays to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initiali

[PULL 19/31] hw/net/rtl8139: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'rtl8139_transmit_one' method has a 8k byte array used for copying data between guest and host. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'txbuffer' will be fully initialized when reading PCI DMA buffers

Re: [PATCH v11 8/8] plugins: Update plugin version and add notes

On 6/9/25 12:38 PM, Rowan Hart wrote: From: novafacing This patch updates the plugin version to gate new APIs and adds notes describing what has been added. Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by:

Re: [PATCH v11 7/8] plugins: Add hypercalls plugin and test

On 6/9/25 12:38 PM, Rowan Hart wrote: From: novafacing This patch adds a plugin that implements a simple form of hypercalls from guest code to the plugin by using the register read API. It accepts only one hypercall, which writes a magic value to guest memory. Signed-off-by: Rowan Hart ---

[PULL 24/31] hw/ppc/pnv_occ: skip automatic zero-init of large struct

From: Daniel P. Berrangé The 'occ_model_tick' method has a 12k struct used for copying data between guest and host. Skip the automatic zero-init of this struct to eliminate the performance overhead in the I/O hot path. The 'dynamic_data' buffer will be fully initialized when reading data from th

Re: [PATCH 1/2] qemu/timer: introduce time dilation factor

Il mer 11 giu 2025, 20:55 Pierrick Bouvier ha scritto: > > 1) different clocks have different starts, so the clock_start must be > > stored per clock type > > > > I was not sure if several clocks are used, so I'll simply use static in > concerned functions. > Ok. The cycles counter is also prob

[PULL 27/31] hw/scsi/lsi53c895a: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'lsi_memcpy' method has a 4k byte array used for copying data to/from the device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when data is copied. Signed-off-by: Dani

[PULL 26/31] hw/usb/hcd-ohci: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'ohci_service_iso_td' method has a 8k byte array used for copying data between guest and host. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when reading data from guest

Re: [PATCH 0/4] Docs: bump sphinx version to 6.2.1

On Fri, Jun 6, 2025 at 4:50 PM John Snow wrote: > This is a re-send of Akihiko Odaki's series, rebased and altered to cope > with the new QAPI static analysis tests now running on GitLab CI. > > Changes in this "v1": > > - Update python static analysis testing configuration to work with the >

[PULL 18/31] hw/misc/aspeed_hace: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'do_hash_operation' method has a 256 element iovec array used for holding pointers to data that is to be hashed. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'iovec' array will be selectively initialized ba

[PULL 23/31] hw/nvme/ctrl: skip automatic zero-init of large arrays

From: Daniel P. Berrangé The 'nvme_map_sgl' method has a 256 element array used for copying data from the device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'segment' array will be fully initialized when reading data from the device.

[PULL 07/31] hw/audio/ac97: skip automatic zero-init of large arrays

From: Daniel P. Berrangé The 'read_audio' & 'write_audio' methods have a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of these arrays to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initialized

[PULL 15/31] hw/dma/xlnx_csu_dma: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'xlnx_csu_dma_src_notify' method has a 4k byte array used for copying DMA data. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when data is copied. Signed-off-by: Daniel

[PULL 13/31] hw/audio/via-ac97: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'out_cb' method has a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initialized when reading data from d

Request for QEMU Wiki Account

Hi QEMU Maintainers, I'm new to the QEMU community. While going through the wiki to get started, I noticed a few issues and I'd like to help correct: - Some links point to documents that have been renamed or removed. - Commit IDs and filenames could be hyperlinked. - Some sub-pages might benefit

Re: [PATCH v2 00/11] migration: Some enhancements and cleanups for 10.1

On Mon, Jun 09, 2025 at 12:18:44PM -0400, Peter Xu wrote: > v2: > - Collected R-bs > - Avoid using "\b" in HMP dumps [Markus, Dave] > > The series is based on a small patch from Yanfei Xu here: > > Based-on: <20250514115827.3216082-1-yanfei...@bytedance.com> > https://lore.kernel.org/r/2025051411

Re: [PULL 00/27] vfio queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

[PULL 12/31] hw/audio/sb16: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'write_audio' method has a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initialized when reading data f

Re: [PULL 0/7] loongarch-to-apply queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

[PULL 04/31] chardev/char-fd: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'fd_chr_read' method has a 4k byte array used for copying data between the socket and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when reading data off the net

[PULL 16/31] hw/display/vmware_vga: skip automatic zero-init of large struct

From: Daniel P. Berrangé The 'vmsvga_fifo_run' method has a struct which is a little over 20k in size, used for holding image data for cursor changes. Skip the automatic zero-init of this struct to eliminate the performance overhead in the I/O hot path. The cursor variable will be fully initiali

[PULL 29/31] hw/ufs/lu: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'ufs_emulate_scsi_cmd' method has a 4k byte array used for copying data from the device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'outbuf' array will be fully initialized when data is copied from the gu

Re: [PULL 1/1] meson: fix Windows build

On Wed, 11 Jun 2025, Stefan Hajnoczi wrote: From: oltolm Sorry, I forgot to cc the maintainers. Do we want comments like this end up in git log? This could have been fixed before a pull. Also the other pull request about uninitialised stack variables had hw/audio/gus twice which was pointed

Re: [PATCH v11 6/8] plugins: Add patcher plugin and test

On 6/9/25 12:38 PM, Rowan Hart wrote: From: novafacing This patch adds a plugin that exercises the virtual and hardware memory read-write API functions added in a previous patch. The plugin takes a target and patch byte sequence, and will overwrite any instruction matching the target byte seque

[PATCH v4 1/2] tests/migration: Setup pre-listened cpr.sock to remove race-condition.

When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to connection failures when running tests. This patch creates and listens on the socket in advance, and p

[PATCH v4 0/2] migration: Support socket fd for CPR and fix

Hello, This is v4 of the patch series. Changes since v3: - [Patch 1/2]: Applid review feedback from Steve Sistare - now using '%d' in g_strdup_printf - [Patch 2/2]: No changes; Kept as-is with Reviewed-by from Steve Sistare. Jaehoon Kim (2): tests/migration: Setup pre-listened cpr.sock to

[PATCH v4 2/2] migration: Support fd-based socket address in cpr_transfer_input

Extend cpr_transfer_input to handle SOCKET_ADDRESS_TYPE_FD alongside SOCKET_ADDRESS_TYPE_UNIX. This change supports the use of pre-listened socket file descriptors for cpr migration channels. This change is particularly useful in qtest environments, where the socket may be created externally and p

Re: [PATCH v3 2/2] migration: Support fd-based socket address in cpr_transfer_input

On 6/11/2025 7:28 AM, Steven Sistare wrote: On 6/10/2025 6:33 PM, Jaehoon Kim wrote: Extend cpr_transfer_input to handle SOCKET_ADDRESS_TYPE_FD alongside SOCKET_ADDRESS_TYPE_UNIX. This change supports the use of pre-listened socket file descriptors for cpr migration channels. This change is p

[RFC PATCH v1] hw/vfio/ap: attribute constructor for cfg_chg_events_lock

Created an attribute constructor for cfg_chg_events_lock for locking mechanism when storing event information for an AP configuration change event Fixes: fd03360215 ("Storing event information for an AP configuration change event") Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 12 +---

[PULL 01/31] include/qemu/compiler: add QEMU_UNINITIALIZED attribute macro

The QEMU_UNINITIALIZED macro is to be used to skip the default compiler variable initialization done by -ftrivial-auto-var-init=zero. Use this in cases where there a method in the device I/O path (or other important hot paths), that has large variables on the stack. A rule of thumb is that "large"

[PULL 22/31] hw/net/xgamc: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'xgmac_enet_send' method has a 8k byte array used for copying data between guest and host. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'frame' buffer will be fully initialized when reading guest memory to

Re: [PATCH 1/2] qemu/timer: introduce time dilation factor

On 6/11/25 12:22 AM, Paolo Bonzini wrote: Il mar 10 giu 2025, 23:28 Pierrick Bouvier > ha scritto: This factor is applied to time spent since we read clock for the first time. It impacts value returned by get_clock() and get_clock_realtime(). Soun

[PULL 00/31] Block patches

The following changes since commit bc98ffdc7577e55ab8373c579c28fe24d600c40f: Merge tag 'pull-10.1-maintainer-may-2025-070625-1' of https://gitlab.com/stsquad/qemu into staging (2025-06-07 15:08:55 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block

[PULL 20/31] hw/net/tulip: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'tulip_setup_frame' method has a 4k byte array used for copynig DMA data from the device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when reading data from the device

[PULL 30/31] net/socket: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'net_socket_send' method has a 68k byte array used for copying data between guest and host. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf1' array will be fully initialized when reading data off the netw

[PULL 06/31] chardev/char-socket: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'tcp_chr_read' method has a 4k byte array used for copying data between the socket and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when reading data off the ne

Re: [PATCH v11 3/8] plugins: Add enforcement of QEMU_PLUGIN_CB flags in register R/W callbacks

On 6/9/25 12:38 PM, Rowan Hart wrote: This patch adds functionality to enforce the requested QEMU_PLUGIN_CB_ flags level passed when registering a callback function using the plugins API. Each time a callback is about to be invoked, a thread-local variable will be updated with the level that call

[PULL 21/31] hw/net/virtio-net: skip automatic zero-init of large arrays

From: Daniel P. Berrangé The 'virtio_net_receive_rcu' method has three arrays with VIRTQUEUE_MAX_SIZE elements, which are apprixmately 32k in size used for copying data between guest and host. Skip the automatic zero-init of these arrays to eliminate the performance overhead in the I/O hot path.

[PULL 02/31] hw/virtio/virtio: avoid cost of -ftrivial-auto-var-init in hot path

Since commit 7ff9ff039380 ("meson: mitigate against use of uninitialize stack for exploits") the -ftrivial-auto-var-init=zero compiler option is used to zero local variables. While this reduces security risks associated with uninitialized stack data, it introduced a measurable bottleneck in the vir

Re: [PULL 00/10] Misc patches (functional tests, travis.yml, MAINTAINERS, ...)

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

[PULL 09/31] hw/audio/es1370: skip automatic zero-init of large array

From: Daniel P. Berrangé The 'es1370_transfer_audio' method has a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initialized when read

Re: [PULL 00/24] Misc HW patches for 2025-06-10

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

  1   2   3   >