RE: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2025-05-22 Thread Salil Mehta via
Hi Gavin, Thanks for your email and sorry for the delay in reply as I was in transit and on annual leave since Monday. Please check my replies inline. Best regards Salil > From: Gavin Shan > Sent: Wednesday, May 21, 2025 1:22 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.or

Re: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2025-05-22 Thread Igor Mammedov
On Wed, 21 May 2025 12:06:57 -0300 Gustavo Romero wrote: > Hi Salil, Gavin, and folks, > > On 5/20/25 21:22, Gavin Shan wrote: > > Hi Salil, > > > > A kindly ping. vCPU hotplug is an important feature and You has put so much > > energies and amazing efforts to enable the feature from QEMU side,

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Cédric Le Goater
On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 39 +

RE: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2025-05-22 Thread Salil Mehta via
HI Gavin, > -Original Message- > From: Gavin Shan > Sent: Thursday, May 22, 2025 12:54 AM > To: Gustavo Romero ; Salil Mehta > ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org; m...@redhat.com; Jonathan Cameron > ; Igor Mammedov > ; Eric Auger [..] > > Hi Gustavo and Salil, > > On 5/

Re: [PATCH v7 2/2] tests/functional: add memlock tests

2025-05-22 Thread Thomas Huth
On 22/05/2025 12.36, Alexandr Moshkov wrote: On 5/22/25 14:16, Thomas Huth wrote: On 22/05/2025 10.51, Alexandr Moshkov wrote: On 5/22/25 12:49, Thomas Huth wrote: On 21/05/2025 15.55, Alexandr Moshkov wrote: Add new tests to check the correctness of the `-overcommit memlock` option (possib

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Cédric Le Goater
On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 39 +

RE: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2025-05-22 Thread Salil Mehta via
Hi Igor, Thanks for the email and reminding the points we discussed last year. I'm mostly in sync with what you've mentioned. Please find my replies inline for more details. Best regards Salil. > From: Igor Mammedov > Sent: Thursday, May 22, 2025 1:40 PM > To: Gustavo Romero > Cc: Gavin Shan

[PATCH] hw/block: Drop unused nand.c

2025-05-22 Thread Peter Maydell
The nand.c device (TYPE_NAND) is an emulation of a NAND flash memory chip which was used by the old OMAP boards. No current QEMU board uses it, and although techically "-device nand,chip-id=0x6b" doesn't error out, it's not possible to usefully use it from the command line because the only interfa

[PATCH 2/5] include: define vaddr based on TCG_VADDR_BITS

2025-05-22 Thread Kohei Tokunaga
This commit defines vaddr based on TCG_VADDR_BITS. For non-wasm hosts, TCG_VADDR_BITS maches the pointer size, so this change preserves the original behaviour. Signed-off-by: Kohei Tokunaga --- include/exec/helper-head.h.inc | 9 + include/exec/vaddr.h | 28 +++

[PATCH 3/5] tlb: specify address field size based on TCG_VADDR_BITS

2025-05-22 Thread Kohei Tokunaga
This commit sets the address field sizes in CPUTLBEntry based on the value of TCG_VADDR_BITS. For non-wasm hosts, TCG_VADDR_BITS matches the pointer size so this change preserves the original behaviour. WebAssembly supports 64bit atomics even though sizeof(void *) is 4. This commit also updates AT

RFC: How to make max_bounce_buffer_size configurable for address_space_memory

2025-05-22 Thread Jonathan Cameron via
Hi All, This closely related to Mattias' work to resolve bounce buffer limitations for PCI memory spaces. https://lore.kernel.org/qemu-devel/20240819135455.2957406-1-mniss...@rivosinc.com/ For CXL memory, due to the way interleave memory is emulated we end up with the same problem with concurrent

Re: [PATCH] vfio/igd: Fix incorrect error propagation in vfio_pci_igd_opregion_detect()

2025-05-22 Thread edmund.raile
Hi Moeko, >I did some further debugging, and found it was caused by a mistake in >error handling. In vfio_pci_igd_opregion_detect(), `errp` is set when >OpRegion is not found. However, in pci_qdev_realize(), the caller of >vfio_realize(), it checks if the errp is set for failure, rather than >the

Re: [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-22 Thread Cédric Le Goater
On 5/22/25 16:28, Rorie Reyes wrote: On 5/22/25 9:27 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for a

[PULL 05/23] tests: skip legacy qcow2 encryption test if AES is not available

2025-05-22 Thread Daniel P . Berrangé
This avoids test breakage when we drop support for using the built-in AES impl as a fallback for missing crypto libraries. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/unit/te

Re: [PATCH v2 2/2] migration/hmp: Add "info migrate -a", reorg the dump

2025-05-22 Thread Peter Xu
On Thu, May 22, 2025 at 12:55:05AM +, Zhijian Li (Fujitsu) wrote: > > > On 22/05/2025 05:04, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > >> On Wed, May 21, 2025 at 08:43:37AM +, Zhijian Li (Fujitsu) wrote: > >> [...] > After this change, sample output (d

Re: [PATCH V3 07/42] vfio/container: preserve descriptors

2025-05-22 Thread Cédric Le Goater
On 5/12/25 17:32, Steve Sistare wrote: At vfio creation time, save the value of vfio container, group, and device descriptors in CPR state. On qemu restart, vfio_realize() finds and uses the saved descriptors, and remembers the reused status for subsequent patches. The reused status is cleared

Re: [PATCH V3 07/42] vfio/container: preserve descriptors

2025-05-22 Thread Steven Sistare
On 5/22/2025 9:51 AM, Cédric Le Goater wrote: On 5/12/25 17:32, Steve Sistare wrote: At vfio creation time, save the value of vfio container, group, and device descriptors in CPR state.  On qemu restart, vfio_realize() finds and uses the saved descriptors, and remembers the reused status for sub

Re: [PATCH V3 10/42] vfio/container: restore DMA vaddr

2025-05-22 Thread Steven Sistare
On 5/22/2025 2:37 AM, Cédric Le Goater wrote: On 5/12/25 17:32, Steve Sistare wrote: In new QEMU, do not register the memory listener at device creation time. Register it later, in the container post_load handler, after all vmstate that may affect regions and mapping boundaries has been loaded. 

[PATCH v5 1/7] vdpa: check for iova tree initialized at net_client_start

2025-05-22 Thread Jonah Palmer
From: Eugenio Pérez To map the guest memory while it is migrating we need to create the iova_tree, as long as the destination uses x-svq=on. Checking to not override it. The function vhost_vdpa_net_client_stop clear it if the device is stopped. If the guest starts the device again, the iova tree

[PATCH v5 7/7] vdpa: move memory listener register to vhost_vdpa_init

2025-05-22 Thread Jonah Palmer
From: Eugenio Pérez Current memory operations like pinning may take a lot of time at the destination. Currently they are done after the source of the migration is stopped, and before the workload is resumed at the destination. This is a period where neigher traffic can flow, nor the VM workload

[PATCH v5 6/7] vdpa: move iova_tree allocation to net_vhost_vdpa_init

2025-05-22 Thread Jonah Palmer
From: Eugenio Pérez As we are moving to keep the mapping through all the vdpa device life instead of resetting it at VirtIO reset, we need to move all its dependencies to the initialization too. In particular devices with x-svq=on need a valid iova_tree from the beginning. Simplify the code als

[PATCH v5 3/7] vdpa: set backend capabilities at vhost_vdpa_init

2025-05-22 Thread Jonah Palmer
From: Eugenio Pérez The backend does not reset them until the vdpa file descriptor is closed so there is no harm in doing it only once. This allows the destination of a live migration to premap memory in batches, using VHOST_BACKEND_F_IOTLB_BATCH. Tested-by: Lei Yang Reviewed-by: Si-Wei Liu A

[PATCH v5 5/7] vdpa: reorder listener assignment

2025-05-22 Thread Jonah Palmer
From: Eugenio Pérez Since commit f6fe3e333f ("vdpa: move memory listener to vhost_vdpa_shared") this piece of code repeatedly assign shared->listener members. This was not a problem as it was not used until device start. However next patches move the listener registration to this vhost_vdpa_ini

Re: [PATCH v2] file-posix: Probe paths and retry SG_IO on potential path errors

2025-05-22 Thread Kevin Wolf
Am 22.05.2025 um 16:46 hat Stefan Hajnoczi geschrieben: > On Thu, May 22, 2025 at 03:08:03PM +0200, Kevin Wolf wrote: > > When scsi-block is used on a host multipath device, it runs into the > > problem that the kernel dm-mpath doesn't know anything about SCSI or > > SG_IO and therefore can't decid

[PATCH v5 0/7] Move memory listener register to vhost_vdpa_init

2025-05-22 Thread Jonah Palmer
Current memory operations like pinning may take a lot of time at the destination. Currently they are done after the source of the migration is stopped, and before the workload is resumed at the destination. This is a period where neigher traffic can flow, nor the VM workload can continue (downtim

Re: [PATCH v2 1/4] tests: Move the old vmstate-static-checker files to tests/data/

2025-05-22 Thread Peter Xu
On Thu, May 22, 2025 at 03:37:53PM +0200, Thomas Huth wrote: > From: Thomas Huth > > All other test data resides in tests/data/, so let's move the dump > files here, too. > > Signed-off-by: Thomas Huth Reviewed-by: Peter Xu -- Peter Xu

[PATCH v5 4/7] vdpa: add listener_registered

2025-05-22 Thread Jonah Palmer
From: Eugenio Pérez Check if the listener has been registered or not, so it needs to be registered again at start. Tested-by: Lei Yang Reviewed-by: Si-Wei Liu Acked-by: Jason Wang Signed-off-by: Eugenio Pérez Signed-off-by: Jonah Palmer --- hw/virtio/vhost-vdpa.c | 7 ++- inclu

Re: [PATCH v3 2/8] Add register write API

2025-05-22 Thread Rowan Hart
Hi Julian, > Again, what was the reason for moving `qemu_plugin_read_register`? I moved it so it's grouped with get_registers above instead of being separated below the memory functions. I can move it back, just seemed nicer that way. -Rowan On Thu, May 22, 2025, 4:59 AM Julian Ganz wrote: >

Re: [RFC PATCH 25/25] accel/mshv: Add memory remapping workaround

2025-05-22 Thread Magnus Kulke
On Tue, May 20, 2025 at 03:53:10PM +0200, Paolo Bonzini wrote: > On 5/20/25 13:30, Magnus Kulke wrote: > > Qemu maps regions of userland multiple times into the guest. The MSHV > > kernel driver detects those overlapping regions and rejects those > > mappings. > > Can you explain what you see? QE

RE: [PATCH RFC V5 00/30] Support of Virtual CPU Hotplug for ARMv8 Arch

2025-05-22 Thread Salil Mehta via
Hi Gustavo, > From: Gustavo Romero > Sent: Wednesday, May 21, 2025 4:07 PM > To: Gavin Shan ; Salil Mehta > ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org; m...@redhat.com; Jonathan Cameron > ; Igor Mammedov > ; Eric Auger [...] > > Hi Salil, Gavin, and folks, > > On 5/20/25 21:22, Gavin S

Re: [PATCH v2 09/24] block: move drain outside of bdrv_try_change_aio_context()

2025-05-22 Thread Kevin Wolf
Am 22.05.2025 um 11:56 hat Fiona Ebner geschrieben: > Am 21.05.25 um 18:36 schrieb Kevin Wolf: > > Am 20.05.2025 um 12:29 hat Fiona Ebner geschrieben: > >> This is part of resolving the deadlock mentioned in commit "block: > >> move draining out of bdrv_change_aio_context() and mark GRAPH_RDLOCK".

Re: [PATCH v7 2/2] tests/functional: add memlock tests

2025-05-22 Thread Alexandr Moshkov
On 5/22/25 16:13, Daniel P. Berrangé wrote: On Thu, May 22, 2025 at 01:51:44PM +0500, Alexandr Moshkov wrote: On 5/22/25 12:49, Thomas Huth wrote: On 21/05/2025 15.55, Alexandr Moshkov wrote: Add new tests to check the correctness of the `-overcommit memlock` option (possible values: off, on

Re: [PATCH 2/5] hw/timer/hpet: Adjust num_timers in hpet_init()

2025-05-22 Thread Zhao Liu
On Tue, May 20, 2025 at 05:16:22PM +0200, Paolo Bonzini wrote: > Date: Tue, 20 May 2025 17:16:22 +0200 > From: Paolo Bonzini > Subject: Re: [PATCH 2/5] hw/timer/hpet: Adjust num_timers in hpet_init() > > On 5/20/25 17:27, Zhao Liu wrote: > > Currently, HPET adjusts num_timers in hpet_realize(), a

Re: [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-22 Thread Cédric Le Goater
On 5/12/25 20:02, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-off-by:

[PATCH v2 4/4] tests/functional/test_vmstate: Test whether the checker script works as expected

2025-05-22 Thread Thomas Huth
From: Thomas Huth We've got two vmstate dump files in the repository which are meant for verifying whether the vmstate-static-checker.py works as expected. Since running this manually is a cumbersome job, let's add an automated test for this instead that runs the script with the two dump files an

Re: [PATCH v2 2/4] tests/data/vmstate-static-checker: Add dump files from QEMU 7.2.17

2025-05-22 Thread Peter Xu
On Thu, May 22, 2025 at 03:37:54PM +0200, Thomas Huth wrote: > From: Thomas Huth > > For automatic tests, we need reference files from older QEMU versions. > QEMU 7.2 is a long term stable release, so it's a good candidate for > checking whether the migration could still work correctly. Let's add

Re: [RFC PATCH] util: split unix socket functions out of qemu-sockets

2025-05-22 Thread Ilya Leoshkevich
Thanks for looking into this! On 2025-05-20 17:57, Alex Bennée wrote: Since fccb744f41 (gdbstub: Try unlinking the unix socket before binding) we use the unix_listen() function from linux-user which causes complications when trying to build statically. Should this be in Fixes: tag? Fix this

Re: [PATCH v2 4/4] tests/functional/test_vmstate: Test whether the checker script works as expected

2025-05-22 Thread Peter Xu
On Thu, May 22, 2025 at 03:37:56PM +0200, Thomas Huth wrote: > From: Thomas Huth > > We've got two vmstate dump files in the repository which are meant > for verifying whether the vmstate-static-checker.py works as expected. > Since running this manually is a cumbersome job, let's add an automate

Re: [PATCH v2 3/4] tests/functional: Test with scripts/vmstate-static-checker.py

2025-05-22 Thread Peter Xu
On Thu, May 22, 2025 at 03:37:55PM +0200, Thomas Huth wrote: [...] > +def test_vmstate(self): > +target_machine = { > +'aarch64': 'virt-7.2', > +'m68k': 'virt-7.2', > +'ppc64': 'pseries-7.2', > +'s390x': 's390-ccw-virtio-7.2', > +

Re: [PATCH v2] file-posix: Probe paths and retry SG_IO on potential path errors

2025-05-22 Thread Stefan Hajnoczi
On Thu, May 22, 2025 at 03:08:03PM +0200, Kevin Wolf wrote: > When scsi-block is used on a host multipath device, it runs into the > problem that the kernel dm-mpath doesn't know anything about SCSI or > SG_IO and therefore can't decide if a SG_IO request returned an error > and needs to be retried

Re: [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-22 Thread Rorie Reyes
On 5/22/25 9:27 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CH

Re: [PATCH v3 2/8] Add register write API

2025-05-22 Thread Alex Bennée
Rowan Hart writes: > From: novafacing > > Signed-off-by: novafacing > Signed-off-by: Rowan Hart > --- > include/qemu/qemu-plugin.h | 57 +- > plugins/api.c | 26 - > 2 files changed, 56 insertions(+), 27 deletions(-) > > diff --

Re: [PATCH] tests/functional/test_mips_malta: Re-enable the check for the PCI host bridge

2025-05-22 Thread Alex Bennée
Thomas Huth writes: > From: Thomas Huth > > The problem with the PCI bridge has been fixed in commit e5894fd6f411c1 > ("hw/pci-host/gt64120: Fix endianness handling"), so we can enable the > corresponding test again. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée -- Alex Bennée Vir

Re: [RFC PATCH 08/25] accel/mshv: Initialize VM partition

2025-05-22 Thread Magnus Kulke
On Tue, May 20, 2025 at 07:07:06PM +, Wei Liu wrote: > On Tue, May 20, 2025 at 01:30:01PM +0200, Magnus Kulke wrote: > > +static void mshv_reset(void *param) > > +{ > > +warn_report("mshv reset"); > > What's missing for this hook? > Ah, I suppose this was inspired by the KVM accel. The h

[PATCH 0/5] Enable QEMU TCI to run 64bit guests on browsers

2025-05-22 Thread Kohei Tokunaga
This patch series is split from the original "Enable QEMU to run on browsers" series, focusing solely on supporting 64bit guest on QEMU TCI compiled with Emscripten. The implementation is based on discussions from the thread in the "tcg: Add WebAssembly backend" patch series, particulalrly Paolo Bo

Re: [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-22 Thread Rorie Reyes
On 5/22/25 11:36 AM, Cédric Le Goater wrote: On 5/22/25 16:28, Rorie Reyes wrote: On 5/22/25 9:27 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects wil

Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-22 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 11, 2025 at 04:14:34PM -0300, Fabiano Rosas wrote: >> The migration parameters validation involves producing a temporary >> structure which merges the current parameter values with the new >> parameters set by the user. >> >> The has_ boolean fields of MigrateSetPa

Re: [PATCH] Add support for FMAPI Get Mutliheaded Head info opcode (5501h)

2025-05-22 Thread Fan Ni
On Thu, May 22, 2025 at 12:01:35PM +0530, Vinayak Holikatti wrote: > CXL spec 3.2 section 7.6.7.5.2 describes Get Head Info. > > Signed-off-by: Vinayak Holikatti > --- > This patch is generated against Jonathan Cameron's branch cxl-2025-03-20 > > hw/cxl/cxl-mailbox-utils.c | 21 + > h

[PATCH 0/3] docs: remove legacy qapidoc

2025-05-22 Thread John Snow
This series is RFC-ish and based on python-qapi-linting-v4, which I think ... should show up in origin/master soon(?). John Snow (3): docs: fix errors formatting in test-good docs: remove legacy QAPI manual generator docs: remove special parsing for freeform sections docs/devel/qapi-code-g

[PATCH 3/3] docs: remove special parsing for freeform sections

2025-05-22 Thread John Snow
This change removes special parsing for freeform sections and allows them to simply be unmodified rST syntax. The existing headings in the QAPI schema are adjusted to reflect the new paradigm. Markus: presumably you'll want to update the tests and/or change the parser errors. Please advise! Signe

[PATCH 2/3] docs: remove legacy QAPI manual generator

2025-05-22 Thread John Snow
Thanks for your service! Remove the old qapidoc and the option to enable the transmogrifier, leaving the transmogrifier as the ONLY qapi doc generator. This has the side effect of converting the tests to use the new system, too. Signed-off-by: John Snow --- docs/interop/qemu-ga-ref.rst

[PATCH 1/3] docs: fix errors formatting in test-good

2025-05-22 Thread John Snow
If we remove the legacy parser, this formulation begins to fail because the body text is appended directly after the field list entry, which is invalid rST syntax. Markus: suggest where the new Exception(s) should go, if anywhere, and how to update the tests? I'm assuming deeply you'll want to. S

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Rorie Reyes
On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie R

Re: [PATCH v2 09/12] qapi: make most CPU commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
On 5/21/25 10:12 PM, Markus Armbruster wrote: Pierrick Bouvier writes: On 5/18/25 11:29 PM, Markus Armbruster wrote: Pierrick Bouvier writes: From: Daniel P. Berrangé This removes the TARGET_* conditions from all the CPU commands that are conceptually target independent. Top level stubs

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 9:35 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie

[PATCH v4 15/15] qapi/misc-i386: move errors to their own documentation section

2025-05-22 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- qapi/misc-i386.json | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json index 6f79817e382..796eaa5f406 100644 --- a/qapi/misc-i386.json +++ b/qapi/misc-i386.json

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 1:17 PM, Rorie Reyes wrote: On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct pr

[PATCH v4 04/15] qapi: expose query-gic-capability command unconditionally

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_ARM condition from the query-gic-capability command. This requires providing a QMP command stub for non-ARM targets. This in turn requires moving the command out of misc-target.json, since that will trigger symbol poisoning errors when built from t

[PATCH v4 03/15] qapi: make SEV commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the SEV confidential virtualization commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé

[PATCH v4 09/15] qapi: make most CPU commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
This removes the TARGET_* conditions from all the CPU commands that are conceptually target independent. Top level stubs are provided to cope with targets which do not currently implement all of the commands. Adjust the doc comments accordingly. Reviewed-by: Richard Henderson Signed-off-by: Danie

[PATCH v4 14/15] qapi/misc-i386: s/field will be set/field is set/

2025-05-22 Thread Pierrick Bouvier
As requested by Markus: > I'd prefer "field is set". Signed-off-by: Pierrick Bouvier --- qapi/misc-i386.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json index 3fda7a20bdd..6f79817e382 100644 --- a/qapi/misc-i386.json +++ b/qapi/mi

[PATCH v4 12/15] qapi: make all generated files common

2025-05-22 Thread Pierrick Bouvier
Monolithic files (qapi_nonmodule_outputs) can now be compiled just once, so we can remove qapi_util_outputs logic. This removes the need for any specific_ss file. Signed-off-by: Pierrick Bouvier --- qapi/meson.build | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-)

[PATCH v4 02/15] qapi: expand docs for SEV commands

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This gives some more context about the behaviour of the commands in unsupported guest configuration or platform scenarios. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Signed-off-by: Pierrick Bouvier --- qapi/misc-target.json | 43

[PATCH v4 13/15] qapi: use imperative style in documentation

2025-05-22 Thread Pierrick Bouvier
As requested by Markus: > We prefer imperative mood "Return" over "Returns". Signed-off-by: Pierrick Bouvier --- qapi/audio.json | 2 +- qapi/char.json | 4 ++-- qapi/cryptodev.json | 2 +- qapi/machine.json | 4 ++-- qapi/migration.json | 8 qapi/misc-i386.json | 6 +++--- q

[PATCH v4 10/15] qapi: make s390x specific CPU commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_S390X and CONFIG_KVM conditions from the CPU commands that are conceptually specific to s390x. Top level stubs are provided to cope with non-s390x targets, or builds without KVM. The removal of CONFIG_KVM is justified by the fact there is no conce

[PATCH v4 11/15] qapi: remove qapi_specific_outputs from meson.build

2025-05-22 Thread Pierrick Bouvier
There is no more QAPI files that need to be compiled per target, so we can remove this. qapi_specific_outputs is now empty, so we can remove the associated logic in meson. Reviewed-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Reviewed-by: Markus Armbruster Signed-off-by: Pierrick Bouvi

[PATCH v4 07/15] qapi: remove the misc-target.json file

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This file is now empty and can thus be removed. Observe the pre-existing bug with s390-skeys.c and target/i386/monitor.c both including qapi-commands-misc-target.h despite not requiring it. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Signed-off-by

[PATCH v4 05/15] qapi: make SGX commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the SGX confidential virtualization commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Observe a pre-existing bug that the "SGXEPCSection" struct lacked

[PATCH v4 00/15] qapi: remove all TARGET_* conditionals from the schema

2025-05-22 Thread Pierrick Bouvier
This series exposes all qmp commands for any target unconditionally, allowing to compile QAPI generated code without any TARGET conditionals. Based on original RFC from Daniel P. Berrangé: https://lore.kernel.org/qemu-devel/20250508135816.673087-1-berra...@redhat.com/ v4 -- - Update commit descr

[PATCH v4 06/15] qapi: make Xen event commands unconditionally available

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the Xen event channel commands, moving them to the recently introduced misc-i386.json QAPI file, given they are inherantly i386 specific commands. Reviewed-by: Richard Henderson Signed-off-by: Daniel P. Berrangé Acked-by: Dav

Re: [PATCH v2 2/7] hw/arm: remove explicit dependencies listed

2025-05-22 Thread Pierrick Bouvier
On 5/21/25 9:52 PM, Thomas Huth wrote: On 22/05/2025 00.34, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/arm/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth There is another bunch of pixmans in hw/display/meson.build and

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-22 Thread Eric Blake
On Thu, May 22, 2025 at 08:38:34PM +0300, Andrey Drobyshev wrote: > On 4/28/25 9:46 PM, Eric Blake wrote: > > From: "Richard W.M. Jones" > > > > Add multi-conn option to the NBD client. This commit just adds the > > option, it is not functional. > > > > Setting this to a value > 1 permits multi

Re: [PULL 00/12] Migration 20250520 patches

2025-05-22 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v4 08/15] qapi: Make CpuModelExpansionInfo::deprecated-props optional and generic

2025-05-22 Thread Pierrick Bouvier
From: Philippe Mathieu-Daudé We'd like to have some unified QAPI schema. Having a structure field conditional to a target being built in is not very practical. While @deprecated-props is only used by s390x target, it is generic enough and could be used by other targets (assuming we expand CpuMod

[PATCH v4 01/15] qapi: expose rtc-reset-reinjection command unconditionally

2025-05-22 Thread Pierrick Bouvier
From: Daniel P. Berrangé This removes the TARGET_I386 condition from the rtc-reset-reinjection command. This requires providing a QMP command stub for non-i386 target. This in turn requires moving the command out of misc-target.json, since that will trigger symbol poisoning errors when built from

Re: [PATCH v3 00/14] qapi: remove all TARGET_* conditionals from the schema

2025-05-22 Thread Pierrick Bouvier
This series contains a rebase mistake (two patches were merged together), please skip it and check v4 instead: https://lore.kernel.org/qemu-devel/20250522190542.588267-1-pierrick.bouv...@linaro.org Regards, Pierrick

Re: [PATCH 2/8] python: update pylint ignores

2025-05-22 Thread John Snow
On Tue, May 20, 2025 at 3:42 AM Markus Armbruster wrote: > John Snow writes: > > > The next patch will synchronize the qemu.qmp library with the external, > > standalone version. That synchronization will require a few extra > > ignores for pylint, so do that now. > > Just one, unless I'm cross-

Re: [PATCH 4/8] python: use 3.9+ builtin type hints

2025-05-22 Thread John Snow
On Tue, May 20, 2025 at 5:26 AM Markus Armbruster wrote: > John Snow writes: > > > This patch changes type hints that have built-in equivalents as of > > Python 3.9. The versions we currently use, imported from the typing > > module, have been deprecated since 3.9 and may be removed at any time

Re: [PATCH] Add support for FMAPI Get Mutliheaded Head info opcode (5501h)

2025-05-22 Thread Davidlohr Bueso
On Thu, 22 May 2025, Vinayak Holikatti wrote: CXL spec 3.2 section 7.6.7.5.2 describes Get Head Info. So how was this tested? Ideally this now comes with a libcxlmi (or equivalent) test case. See for example how Anisa is going about this with the FMAPI DCD patches: https://lore.kernel.org/li

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-22 Thread Pierrick Bouvier
On 5/22/25 4:59 AM, Julian Ganz wrote: This definition strikes me as odd. What was your reason to assert `current_cpu` here, but not in the other two functions? Also a bit surprising is the declaration of `cpu` if you use it in just one place (rather than just use `current_cpu` directly as for th

Re: [PATCH 5/8] python: convert remaining deprecated type hints for 3.9+

2025-05-22 Thread John Snow
On Tue, May 20, 2025 at 5:31 AM Markus Armbruster wrote: > John Snow writes: > > > In this patch, we don't have a builtin type to use for a type hint, but > > we do have collections.abc and other standard library types. Replace > > deprecated type hints with their standard library equivalents: >

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-22 Thread Nicolin Chen
On Thu, May 22, 2025 at 06:50:42AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Nicolin Chen > >Subject: Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to > >host > > > >On Wed, May 21, 2025 at 07:14:45PM +0800, Zhenzhong Duan wrote: > >> +static co

Re: [PATCH rfcv3 05/21] vfio/iommufd: Save vendor specific device info

2025-05-22 Thread Nicolin Chen
On Thu, May 22, 2025 at 09:21:04AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Nicolin Chen > >Subject: Re: [PATCH rfcv3 05/21] vfio/iommufd: Save vendor specific device > >info > > > >On Wed, May 21, 2025 at 07:14:35PM +0800, Zhenzhong Duan wrote: > >> @@ -852,6 +8

Re: [PATCH v3 5/8] Add memory hardware address read/write API

2025-05-22 Thread Pierrick Bouvier
On 5/21/25 8:34 PM, Rowan Hart wrote: Well, first I just noticed that I left a debug print in this function! So I'll fix that. Reading this patch, and patch 3 (Add address space API), I am not sure AddressSpace is something we want to leak in plugins interface. It is a concept *very* internal t

Re: [PATCH v7 2/2] tests/functional: add memlock tests

2025-05-22 Thread Thomas Huth
On 22/05/2025 14.40, Alexandr Moshkov wrote: On 5/22/25 16:13, Daniel P. Berrangé wrote: On Thu, May 22, 2025 at 01:51:44PM +0500, Alexandr Moshkov wrote: On 5/22/25 12:49, Thomas Huth wrote: On 21/05/2025 15.55, Alexandr Moshkov wrote: Add new tests to check the correctness of the `-overcom

[PATCH v2] file-posix: Probe paths and retry SG_IO on potential path errors

2025-05-22 Thread Kevin Wolf
When scsi-block is used on a host multipath device, it runs into the problem that the kernel dm-mpath doesn't know anything about SCSI or SG_IO and therefore can't decide if a SG_IO request returned an error and needs to be retried on a different path. Instead of getting working failover, an error

[PATCH v2 3/4] tests/functional: Test with scripts/vmstate-static-checker.py

2025-05-22 Thread Thomas Huth
From: Thomas Huth We've got this nice vmstate-static-checker.py script that can help to detect screw-ups in the migration states. Unfortunately, it's currently only run manually, so there are regressions that nobody notices immediately. Let's run it from a functional test automatically so that we

[PATCH v2 0/4] tests/functional: Test with scripts/vmstate-static-checker.py

2025-05-22 Thread Thomas Huth
This set of patches adds an automatic test of the vmstate via the scripts/vmstate-static-checker.py script. For this we need some reference files from an older version of QEMU. I chose to use QEMU 7.2 for the reference files since this is a long term support release that is still actively being mai

[PATCH v2 1/4] tests: Move the old vmstate-static-checker files to tests/data/

2025-05-22 Thread Thomas Huth
From: Thomas Huth All other test data resides in tests/data/, so let's move the dump files here, too. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- .../vmstate-static-checker}/dump1.json | 0 .../vmstate-static-c

[PATCH v5 2/7] vdpa: reorder vhost_vdpa_set_backend_cap

2025-05-22 Thread Jonah Palmer
From: Eugenio Pérez It will be used directly by vhost_vdpa_init. Tested-by: Lei Yang Reviewed-by: Si-Wei Liu Acked-by: Jason Wang Signed-off-by: Eugenio Pérez Signed-off-by: Jonah Palmer --- hw/virtio/vhost-vdpa.c | 60 +- 1 file changed, 30 insertio

Re: [PATCH] vfio/igd: Fix incorrect error propagation in vfio_pci_igd_opregion_detect()

2025-05-22 Thread Tomita Moeko
On 5/22/25 15:31, edmund.raile wrote: > Hi Moeko, > >> I did some further debugging, and found it was caused by a mistake in >> error handling. In vfio_pci_igd_opregion_detect(), `errp` is set when >> OpRegion is not found. However, in pci_qdev_realize(), the caller of >> vfio_realize(), it checks

Re: [PATCH v2] file-posix: Probe paths and retry SG_IO on potential path errors

2025-05-22 Thread Hanna Czenczek
On 22.05.25 15:08, Kevin Wolf wrote: When scsi-block is used on a host multipath device, it runs into the problem that the kernel dm-mpath doesn't know anything about SCSI or SG_IO and therefore can't decide if a SG_IO request returned an error and needs to be retried on a different path. Instead

Re: [PATCH v3 2/8] Add register write API

2025-05-22 Thread Julian Ganz
Hi Rowan, May 22, 2025 at 5:02 PM, Rowan Hart wrote: > > Again, what was the reason for moving `qemu_plugin_read_register`? > > I moved it so it's grouped with get_registers above instead of being > separated below the memory functions. I can move it back, just seemed nicer > that way. The mov

[PATCH v2] vfio/igd: Fix incorrect error propagation in vfio_pci_igd_opregion_detect()

2025-05-22 Thread Tomita Moeko
In vfio_pci_igd_opregion_detect(), errp will be set when the device does not have OpRegion or is hotplugged. This errp will be propagated to pci_qdev_realize(), which interprets it as failure, causing unexpected termination on devices without OpRegion like SR-IOV VFs or discrete GPUs. Fix it by not

[PATCH 4/5] tci: define TCG_TARGET_REG_BITS based on TCG_VADDR_BITS

2025-05-22 Thread Kohei Tokunaga
This commit defines TCG_TARGET_REG_BITS based on the value of TCG_VADDR_BITS. For non-wasm hosts, TCG_VADDR_BITS matches the pointer size, so this change preserves the original behaviour. For the wasm host, this change enables support for 64bit guests. Signed-off-by: Kohei Tokunaga --- tcg/tci/t

[PATCH 1/5] meson.build: add TCG_VADDR_BITS for defining the vaddr size

2025-05-22 Thread Kohei Tokunaga
This commit introduces TCG_VADDR_BITS in meson.build to explicitly define the vaddr size. For non-wasm hosts, this is set to the value of host_long_bits, preserving the original behaviour of the check in the target loop. For the wasm host, it's explicitly set to 64 to enable support for 64bit guest

[PATCH 5/5] tci: use tcg_target_ulong when retrieving the pool data

2025-05-22 Thread Kohei Tokunaga
TCI's tcg_out_call stores "func" and "cif" as tcg_target_ulong in the TB using the pool feature. On non-wasm hosts, tcg_target_ulong matches the pointer size so this commit preserves the original behaviour. On the wasm host, tcg_target_ulong differs from the pointer size so this change ensures TCI

Re: [PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-22 Thread Cédric Le Goater
On 5/21/25 23:55, John Levon wrote: Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later, to translate the vaddr into an offset for the dma map vfio-user message; CPR will also will need this. Originally-by: John Johnson Signed

Re: [PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-22 Thread Steven Sistare
On 5/22/2025 1:20 PM, Cédric Le Goater wrote: On 5/21/25 23:55, John Levon wrote: Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later, to translate the vaddr into an offset for the dma map vfio-user message; CPR will also will

Re: [PATCH v2 4/4] nbd: Enable multi-conn using round-robin

2025-05-22 Thread Andrey Drobyshev
On 4/28/25 9:46 PM, Eric Blake wrote: > From: "Richard W.M. Jones" > > Enable NBD multi-conn by spreading operations across multiple > connections. > > (XXX) This uses a naive round-robin approach which could be improved. > For example we could look at how many requests are in flight and > assig

  1   2   3   >