Re: [PATCH v7 0/6] Report vfio-ap configuration changes

2025-05-06 Thread Cédric Le Goater
On 4/28/25 23:29, Cédric Le Goater wrote: On 4/25/25 07:23, Rorie Reyes wrote: Changelog: v7: - Dropped initial commit for linux-header file vfio.h since I created two new commits to address the changes made in v6 - Moved patches 6 and 7 to the beginning of the series after dropping the first

Re: [PATCH] acpi: Set maximum size to 64k for "etc/acpi/rsdp" blob

2025-05-06 Thread Dongli Zhang
Would you mind suggesting any next steps on this issue? 1. Increase maximum size for "etc/acpi/rsdp", or 2. Remove host page size based alignment, and then fix any further live migration issue? Thank you very much! Dongli Zhang On 1/31/23 1:17 AM, Feng Sun wrote: > Michael S. Tsirkin 于2023年1月

Re: [PATCH 02/11] meson, cargo: require Rust 1.77.0

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:27AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:27 +0200 > From: Paolo Bonzini > Subject: [PATCH 02/11] meson, cargo: require Rust 1.77.0 > X-Mailer: git-send-email 2.49.0 > > Signed-off-by: Paolo Bonzini > --- > meson.build | 6 +++--- > rust/

Re: [PATCH 03/11] rust: use std::ffi instead of std::os::raw

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:28AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:28 +0200 > From: Paolo Bonzini > Subject: [PATCH 03/11] rust: use std::ffi instead of std::os::raw > X-Mailer: git-send-email 2.49.0 > > This is allowed since Rust 1.64.0. > > Reviewed-by: Manos Pitsidi

Re: [PATCH v4 1/4] hw/s390x: add SCLP event type CPI

2025-05-06 Thread Thomas Huth
On 06/05/2025 08.48, Nina Schoetterl-Glausch wrote: On Mon, 2025-05-05 at 08:55 +0200, Shalini Chellathurai Saroja wrote: On 2025-04-28 11:22, Janis Schoetterl-Glausch wrote: On Thu, 2025-04-10 at 17:09 +0200, Shalini Chellathurai Saroja wrote: Implement the Service-Call Logical Processor (SCL

Re: [PATCH 07/11] rust: qom: fix TODO about zeroability of classes

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:32AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:32 +0200 > From: Paolo Bonzini > Subject: [PATCH 07/11] rust: qom: fix TODO about zeroability of classes > X-Mailer: git-send-email 2.49.0 > > The proposed suggestion is not correct. First it is not nec

Re: [PATCH 08/11] rust: enable clippy::ptr_cast_constness

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:33AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:33 +0200 > From: Paolo Bonzini > Subject: [PATCH 08/11] rust: enable clippy::ptr_cast_constness > X-Mailer: git-send-email 2.49.0 > > Reviewed-by: Manos Pitsidianakis > Signed-off-by: Paolo Bonzini > -

Re: [PATCH] bsd-user: add option to enable plugins

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 02:25, Warner Losh wrote: I'm also ignorant of plugins, but (a) if not enabling plugins is a nop and (b) plugins either work or fail completely, then I think we can enable them. If they cause problems when not enabled by the user, though, we'll likely have to revert. Elsewhere in this

Re: [PATCH 11/11] docs: rust: update for newer minimum supported version

2025-05-06 Thread Zhao Liu
> -* Generic Associated Types (1.65.0) > - > -* ``CStr::from_bytes_with_nul()`` as a ``const`` function (1.72.0). > - > -* "Return position ``impl Trait`` in Traits" (1.75.0, blocker for including > - the pinned-init create). > - Glad to see it's possible to include pinned-init. Reviewed-by: Zh

Re: [PATCH] tests/qtest: Add qtest for NPCM8XX PSPI module

2025-05-06 Thread Philippe Mathieu-Daudé
Hi Tim, On 6/5/25 04:14, Tim Lee wrote: This fails on top of current master, please take a look: $ QTEST_LOG=1 QTEST_QEMU_BINARY=./qemu-system-aarch64 ./tests/qtest/npcm8xx_pspi-test # random seed: R02S03f79fc48ba73b76c881f93f90b015e9 1..3 # Start of aarch64 tests # Start of npcm8xx_pspi tests

[[PATCH V3] hw/loongarch/boot: Adjust the loading position of the initrd

2025-05-06 Thread Xianglai Li
When only the -kernel parameter is used to load the elf kernel, the initrd is loaded in the ram. If the initrd size is too large, the loading fails, resulting in a VM startup failure. This patch first loads initrd near the kernel. When the nearby memory space of the kernel is insufficient, it trie

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Zhao Liu
> This series does not cover enabling the newer compiler in CI because, > while both Debian and Ubuntu have a new-enough Rust compiler to support > 1.77, they pose problems for this further bump. For Debian, the bookworm > release probably will not have new compilers and is supported by QEMU > for

RE: [PATCH v2 5/6] hw/arm/virt: Add support for smmuv3 device

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Nicolin Chen > Sent: Friday, May 2, 2025 6:55 PM > To: Shameerali Kolothum Thodi > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath...@nvidia.

[PATCH v6 09/14] arm/cpu: Store id_pfr0/1/2 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 5 +- target/arm/cpu-features.h | 10 ++-- target/arm/cpu.c | 8 +-- target/arm/cpu.h | 3 - target/arm/c

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Zhao Liu
> > "enable Rust" supports v1.77 and "enable all devices written in Rust" > > supports v1.83, correct? > > Both support v1.83 only. However, if Rust is missing or old, "enable > all devices written in Rust" will fail compilation (e.g. Kconfig would > fail for ARM/x86 targets due to unsatisfiable

RE: [PATCH v2 1/6] hw/arm/smmuv3: Add support to associate a PCIe RC

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Eric Auger > Sent: Monday, May 5, 2025 9:19 AM > To: Donald Dutile ; Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org; Markus Armbruster ; > Peter Maydell ; Daniel P. Berrange > ; Alex Bennée > Cc: j...@nvidia.com; nicol...@nvidia.c

RE: [PATCH v2 2/6] hw/arm/virt-acpi-build: Update IORT for multiple smmuv3 devices

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: qemu-devel- > bounces+shameerali.kolothum.thodi=huawei@nongnu.org devel-bounces+shameerali.kolothum.thodi=huawei@nongnu.org> On > Behalf Of Eric Auger > Sent: Monday, May 5, 2025 9:40 AM > To: Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-

Re: [RFC PATCH] hw/virtio: Introduce CONFIG_VIRTIO_LEGACY to disable legacy support

2025-05-06 Thread Michael S. Tsirkin
On Tue, May 06, 2025 at 10:55:34AM +0200, Philippe Mathieu-Daudé wrote: > On 6/5/25 10:12, Michael S. Tsirkin wrote: > > On Tue, May 06, 2025 at 09:04:50AM +0100, Daniel P. Berrangé wrote: > > > On Fri, May 02, 2025 at 03:24:41PM +0200, Philippe Mathieu-Daudé wrote: > > > > Legacy VirtIO devices do

RE: [PATCH v2 3/6] hw/arm/virt: Factor out common SMMUV3 dt bindings code

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Eric Auger > Sent: Monday, May 5, 2025 10:02 AM > To: Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath...@nvidia.co

Re: [PATCH 05/11] rust: qemu_api_macros: make pattern matching more readable and efficient

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:30AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:30 +0200 > From: Paolo Bonzini > Subject: [PATCH 05/11] rust: qemu_api_macros: make pattern matching more > readable and efficient > X-Mailer: git-send-email 2.49.0 > > "let ... else" is useful when vis

Re: [PATCH 06/11] rust: use MaybeUninit::zeroed() in const context

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:31AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:31 +0200 > From: Paolo Bonzini > Subject: [PATCH 06/11] rust: use MaybeUninit::zeroed() in const context > X-Mailer: git-send-email 2.49.0 > > Reviewed-by: Manos Pitsidianakis > Signed-off-by: Paolo Bon

Re: [PATCH 04/11] rust: let bilge use "let ... else"

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:29AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:29 +0200 > From: Paolo Bonzini > Subject: [PATCH 04/11] rust: let bilge use "let ... else" > X-Mailer: git-send-email 2.49.0 > > Reviewed-by: Manos Pitsidianakis > Signed-off-by: Paolo Bonzini > --- >

RE: [PATCH v2 2/6] hw/arm/virt-acpi-build: Update IORT for multiple smmuv3 devices

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Nicolin Chen > Sent: Friday, May 2, 2025 6:14 PM > To: Shameerali Kolothum Thodi > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath...@nvidia.c

Re: [RFC PATCH] hw/virtio: Introduce CONFIG_VIRTIO_LEGACY to disable legacy support

2025-05-06 Thread Daniel P . Berrangé
On Fri, May 02, 2025 at 03:24:41PM +0200, Philippe Mathieu-Daudé wrote: > Legacy VirtIO devices don't have their endianness clearly defined. > QEMU infers it taking the endianness of the (target) binary, or, > when a target support switching endianness at runtime, taking the > endianness of the vCP

Re: [RFC PATCH] hw/virtio: Introduce CONFIG_VIRTIO_LEGACY to disable legacy support

2025-05-06 Thread Michael S. Tsirkin
On Tue, May 06, 2025 at 09:04:50AM +0100, Daniel P. Berrangé wrote: > On Fri, May 02, 2025 at 03:24:41PM +0200, Philippe Mathieu-Daudé wrote: > > Legacy VirtIO devices don't have their endianness clearly defined. > > QEMU infers it taking the endianness of the (target) binary, or, > > when a target

Re: [PATCH v2 2/9] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.11 machine type

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth The s390-ccw-virtio-2.11 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 25 - 1 file changed, 25 dele

Re: [PATCH v2 1/9] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.10 machine type

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth The s390-ccw-virtio-2.10 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 12 1 file changed, 12 deletions(-) Re

Re: [PATCH 09/11] rust: remove offset_of replacement

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:34AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:34 +0200 > From: Paolo Bonzini > Subject: [PATCH 09/11] rust: remove offset_of replacement > X-Mailer: git-send-email 2.49.0 > > --- > docs/devel/rust.rst | 6 - > rust/Cargo.lock

Re: [PATCH v2 6/9] hw/s390x/s390-virtio-ccw: Remove the deprecated 3.0 machine type

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth The s390-ccw-virtio-3.0 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 15 --- 1 file changed, 15 deletions(-)

Re: [PATCH v2 5/9] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.12 machine type

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth The s390-ccw-virtio-2.12 machine is older than 6 years, so according to our machine support policy, it can be removed now. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 14 -- 1 file changed, 14 deletions(-)

Re: [PATCH 10/11] rust: replace c_str! with c"" literals

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 11:04:35AM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 11:04:35 +0200 > From: Paolo Bonzini > Subject: [PATCH 10/11] rust: replace c_str! with c"" literals > X-Mailer: git-send-email 2.49.0 > > Reviewed-by: Manos Pitsidianakis > Signed-off-by: Paolo Bonzini > --

Re: [PATCH v2 4/9] target/s390x: Rename the qemu_V2_11 feature set to qemu_MIN

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth Now that the v2.11 machine type has been removed, it does not make sense to keep the qemu_V2_11 feature set around. This is rather the (minimum) feature set of the oldest supported machine now, so rename it to qemu_MIN. Signed-off-by: Thoma

RE: [PATCH v2 1/6] hw/arm/smmuv3: Add support to associate a PCIe RC

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Nicolin Chen > Sent: Friday, May 2, 2025 6:23 PM > To: Shameerali Kolothum Thodi > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath...@nvidia.

Re: [PATCH v2 9/9] hw/s390x/s390-virtio-ccw: Remove the deprecated 4.0 machine type

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth The s390-ccw-virtio-4.0 machine is older than 6 years, so according to our machine support policy, it can be removed now. The corresponding v4.0 CPU feature group gets merged into the minimum feature group now. Signed-off-by: Thomas Huth -

Re: [PATCH v2 8/9] hw/s390x/s390-virtio-ccw: Remove the deprecated 3.1 machine type

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth The s390-ccw-virtio-3.1 machine is older than 6 years, so according to our machine support policy, it can be removed now. The v3.1 CPU feature group gets merged into the minimum CPU feature group now. Signed-off-by: Thomas Huth --- hw/s3

Re: [PATCH v2 3/9] hw/s390x/event-facility: Remove the obsolete "allow_all_mask_sizes" code

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 08:21, Thomas Huth wrote: From: Thomas Huth Now that the machine types 2.11 and older have been removed, we don't need the "allow_all_mask_sizes" compatibility handling code anymore and can remove it now. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/s390x

RE: [PATCH v2 1/6] hw/arm/smmuv3: Add support to associate a PCIe RC

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Donald Dutile > Sent: Friday, May 2, 2025 7:17 PM > To: Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > nicol...@nvidia.com; berra...@redhat.com; nath...@nvid

Re: [RFC 07/24] hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to acpi_dsdt_add_pci_osc

2025-05-06 Thread Eric Auger
On 5/6/25 2:13 AM, Gustavo Romero wrote: > Hi Eric, > > On 4/28/25 07:25, Eric Auger wrote: >> Add a new argument to acpi_dsdt_add_pci_osc to be able to disable >> native pci hotplug. >> >> Signed-off-by: Eric Auger >> --- >>   hw/pci-host/gpex-acpi.c | 11 ++- >>   1 file changed, 6 ins

Re: Rust in QEMU update, April 2025

2025-05-06 Thread Manos Pitsidianakis
On Mon, May 5, 2025 at 4:45 PM Paolo Bonzini wrote: > > On 5/5/25 14:26, Manos Pitsidianakis wrote: > >> Something I do notice is that there's some inconsistency in > >> how we've structured things between the two devices, e.g.: > >> > >> * the pl011 main source file is device.rs, but

RE: [PATCH v2 2/6] hw/arm/virt-acpi-build: Update IORT for multiple smmuv3 devices

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Donald Dutile > Sent: Friday, May 2, 2025 7:18 PM > To: Nicolin Chen ; Shameerali Kolothum Thodi > > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; j...@nvidia.com; > berra...@redhat.com; nath...@nvidia.com

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Paolo Bonzini
On Tue, May 6, 2025 at 10:35 AM Zhao Liu wrote: > > > This series does not cover enabling the newer compiler in CI because, > > while both Debian and Ubuntu have a new-enough Rust compiler to support > > 1.77, they pose problems for this further bump. For Debian, the bookworm > > release probably

Re: [RFC 05/24] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-05-06 Thread Eric Auger
Hi Gustavo, On 5/6/25 2:12 AM, Gustavo Romero wrote: > Hi Eric, > > On 4/28/25 07:25, Eric Auger wrote: >> acpi_pcihp VirtMachineClass state flag will allow >> to opt in for acpi pci hotplug. This is guarded by a >> class no_acpi_pcihp flag to manage compats (<= 10.0 >> machine types will not supp

Re: [RFC 06/24] hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp

2025-05-06 Thread Eric Auger
On 5/6/25 2:12 AM, Gustavo Romero wrote: > Hi Eric, > > On 4/28/25 07:25, Eric Auger wrote: >> We plan to reuse build_x86_acpi_pci_hotplug() implementation >> for ARM so let's move the code to generic pcihp. >> >> Associated static aml_pci_pdsm() helper is also moved along. >> build_x86_acpi_pci

Re: [PATCH 2/5] rust: use inline const expressions

2025-05-06 Thread Zhao Liu
On Mon, May 05, 2025 at 12:08:51PM +0200, Paolo Bonzini wrote: > Date: Mon, 5 May 2025 12:08:51 +0200 > From: Paolo Bonzini > Subject: [PATCH 2/5] rust: use inline const expressions > X-Mailer: git-send-email 2.49.0 > > They were stabilized in Rust 1.79.0. > > Signed-off-by: Paolo Bonzini > --

[PATCH v6 02/14] arm/cpu: Store aa64isar0/aa64zfr0 into the idregs arrays

2025-05-06 Thread Cornelia Huck
From: Eric Auger Also add kvm accessors for storing host features into idregs. Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 57 --- target/arm/cpu.c

[PATCH v6 00/14] arm: rework id register storage

2025-05-06 Thread Cornelia Huck
Just some small changes: - fixed up some botched conversions noted by Eric (thanks!) - rebased to current master - new patch with a small cleanup suggested by Eric Also available at https://gitlab.com/cohuck/qemu/-/commits/arm-rework-idreg-storage-v6 Just a quick respin to fix a missed conversio

[PATCH v6 01/14] arm/cpu: Add sysreg definitions in cpu-sysregs.h

2025-05-06 Thread Cornelia Huck
From: Eric Auger This new header contains macros that define aarch64 registers. In a subsequent patch, this will be replaced by a more exhaustive version that will be generated from linux arch/arm64/tools/sysreg file. Those macros are sufficient to migrate the storage of those ID regs from named

[PATCH v6 08/14] arm/cpu: Store id_isar0-7 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 12 ++-- target/arm/cpu-features.h | 36 +- target/arm/cpu.c | 24 +++ target/arm/cpu.h | 7 --

[PATCH v6 03/14] arm/cpu: Store aa64isar1/2 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 44 +++ target/arm/cpu.c | 12 --- target/arm/cpu.h | 2 -- target/

[PATCH v6 07/14] arm/cpu: Store aa64smfr0 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 6 +++--- target/arm/cpu.h | 1 - target/arm/cpu64.c| 7 ++- target/arm/helper.c | 2 +- target/arm/kvm

[PATCH v6 10/14] arm/cpu: Store id_dfr0/1 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 2 +- target/arm/cpu-features.h | 16 target/arm/cpu.c | 13 + target/arm/cpu.h |

[PATCH v6 05/14] arm/cpu: Store aa64mmfr0-3 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 74 +++ target/arm/cpu.h | 4 --- target/arm/cpu64.c| 8 ++--- target/arm/h

[PATCH v6 13/14] arm/cpu: switch to a generated cpu-sysregs.h.inc

2025-05-06 Thread Cornelia Huck
Generated against Linux 6.14-rc1. Reviewed-by: Sebastian Ott Reviewed-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-sysregs.h.inc | 43 +--- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/target/arm/cpu-sysregs.h.inc b/target/ar

[PATCH v6 04/14] arm/cpu: Store aa64pfr0/1 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 40 - target/arm/cpu.c | 29 target/arm/cpu.h | 2 --

[PATCH v6 11/14] arm/cpu: Store id_mmfr0-5 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 8 ++-- target/arm/cpu-features.h | 18 target/arm/cpu.h | 6 --- target/arm/cpu64.c| 16 +++ targ

[PATCH v6 06/14] arm/cpu: Store aa64dfr0/1 into the idregs array

2025-05-06 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 16 target/arm/cpu.c | 15 +-- target/arm/cpu.h | 2 -- target/arm/cpu64.c

Re: [RFC PATCH] hw/virtio: Introduce CONFIG_VIRTIO_LEGACY to disable legacy support

2025-05-06 Thread Philippe Mathieu-Daudé
On 6/5/25 10:12, Michael S. Tsirkin wrote: On Tue, May 06, 2025 at 09:04:50AM +0100, Daniel P. Berrangé wrote: On Fri, May 02, 2025 at 03:24:41PM +0200, Philippe Mathieu-Daudé wrote: Legacy VirtIO devices don't have their endianness clearly defined. QEMU infers it taking the endianness of the (

[PATCH v6 12/14] arm/cpu: Add sysreg generation scripts

2025-05-06 Thread Cornelia Huck
From: Eric Auger Introduce scripts that automate the generation of system register definitions from a given linux source tree arch/arm64/tools/sysreg. Invocation of ./update-aarch64-sysreg-code.sh $PATH_TO_LINUX_SOURCE_TREE in scripts directory generates target/arm/cpu-sysregs.h.inc containing d

[PATCH v6 14/14] arm/kvm: use fd instead of fdarray[2]

2025-05-06 Thread Cornelia Huck
We have fd, so might as well neaten things up. Suggested-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index abb63b7f617f..1ffd67a39056 100644 --- a/target/arm/kvm.

Re: [PATCH] hw/acpi/pcihp: Fix typo in function name

2025-05-06 Thread Eric Auger
Hi Gustavo, On 5/6/25 2:26 AM, Gustavo Romero wrote: > Hi Eric, > > On 5/5/25 11:19, Eric Auger wrote: >> Hi Gustavo, >> >> On 5/5/25 2:29 PM, Gustavo Romero wrote: >>> Hi Eric, >>> >>> On 5/5/25 04:13, Eric Auger wrote: On 5/4/25 11:56 PM, Gustavo Romero wrote: > Fix typo in QE

Re: [PATCH v1 15/22] test/qtest/hace: Add SHA-384 test cases for ASPEED HACE model

2025-05-06 Thread Cédric Le Goater
On 5/5/25 08:51, Jamin Lin wrote: Hi Cédric Subject: RE: [PATCH v1 15/22] test/qtest/hace: Add SHA-384 test cases for ASPEED HACE model Hi Cédric, Subject: Re: [PATCH v1 15/22] test/qtest/hace: Add SHA-384 test cases for ASPEED HACE model On 3/21/25 10:26, Jamin Lin wrote: Introduced SHA-3

Re: [PATCH v1 01/22] hw/misc/aspeed_hace: Remove unused code for better readability

2025-05-06 Thread Cédric Le Goater
On 5/5/25 05:28, Jamin Lin wrote: Hi Cédric Subject: Re: [PATCH v1 01/22] hw/misc/aspeed_hace: Remove unused code for better readability On 3/21/25 10:25, Jamin Lin wrote: This cleanup follows significant changes in commit 4c1d0af4a28d, making the model more readable. - Deleted "iov_cache" a

RE: [PATCH 1/5] vfio/iommufd: Save host iommu capabilities in VFIODevice.caps

2025-05-06 Thread Duan, Zhenzhong
Hi Eric, >-Original Message- >From: Eric Auger >Sent: Tuesday, May 6, 2025 12:15 AM >To: Cédric Le Goater ; Duan, Zhenzhong >; qemu-devel@nongnu.org >Cc: alex.william...@redhat.com; nicol...@nvidia.com; >joao.m.mart...@oracle.com; Peng, Chao P ; Liu, Yi L > >Subject: Re: [PATCH 1/5] vfio/

RE: [PATCH v2 5/6] hw/arm/virt: Add support for smmuv3 device

2025-05-06 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Eric Auger > Sent: Monday, May 5, 2025 11:12 AM > To: Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath...@nvidia.co

Re: [PATCH] meson: use thorough test setup as default

2025-05-06 Thread Daniel P . Berrangé
On Mon, May 05, 2025 at 10:46:52AM -0700, Pierrick Bouvier wrote: > On 5/5/25 3:32 AM, Thomas Huth wrote: > > On 03/05/2025 22.18, Pierrick Bouvier wrote: > > > Allows all tests to be visible by default when using meson test > > > directly. > > > > > > This has no impact on make check-* commands,

Re: [PATCH v2 1/6] hw/arm/smmuv3: Add support to associate a PCIe RC

2025-05-06 Thread Eric Auger
Hi Shameer, On 5/6/25 11:07 AM, Shameerali Kolothum Thodi wrote: > >> -Original Message- >> From: Eric Auger >> Sent: Monday, May 5, 2025 9:19 AM >> To: Donald Dutile ; Shameerali Kolothum Thodi >> ; qemu-...@nongnu.org; >> qemu-devel@nongnu.org; Markus Armbruster ; >> Peter Maydell ; Dan

Re: [PATCH] meson: use thorough test setup as default

2025-05-06 Thread Daniel P . Berrangé
On Sat, May 03, 2025 at 01:18:06PM -0700, Pierrick Bouvier wrote: > Allows all tests to be visible by default when using meson test > directly. > > This has no impact on make check-* commands, which use SPEED=quick by > default (see scripts/mtest2make.py). IMHO it would be conceptually confusing

Re: [PATCH 3/5] rust: vmstate: convert to use builder pattern

2025-05-06 Thread Zhao Liu
> +unsafe extern "C" fn vmstate_pre_load_cb< > +T, > +F: for<'a> FnCall<(&'a T,), Result<(), impl Into>>, > +>( > +opaque: *mut c_void, > +) -> c_int { > +// SAFETY: assumes vmstate_struct! is used correctly > +let result = F::call((unsafe { &*(opaque.cast::()) },)); > +into

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Daniel P . Berrangé
On Tue, May 06, 2025 at 05:26:12PM +0800, Zhao Liu wrote: > > > "enable Rust" supports v1.77 and "enable all devices written in Rust" > > > supports v1.83, correct? > > > > Both support v1.83 only. However, if Rust is missing or old, "enable > > all devices written in Rust" will fail compilation

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Daniel P . Berrangé
On Tue, May 06, 2025 at 05:26:12PM +0800, Zhao Liu wrote: > > > "enable Rust" supports v1.77 and "enable all devices written in Rust" > > > supports v1.83, correct? > > > > Both support v1.83 only. However, if Rust is missing or old, "enable > > all devices written in Rust" will fail compilation

Re: [PATCH v2 10/15] vfio: add device IO ops vector

2025-05-06 Thread Cédric Le Goater
On 4/30/25 21:39, John Levon wrote: For vfio-user, device operations such as IRQ handling and region read/writes are implemented in userspace over the control socket, not ioctl() to the vfio kernel driver; add an ops vector to generalize this, and implement vfio_device_io_ops_ioctl for interactin

RE: [PATCH v5 0/2] intel_iommu: Fix locking issues

2025-05-06 Thread Duan, Zhenzhong
Hi Clement, >-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: [PATCH v5 0/2] intel_iommu: Fix locking issues > >This series introduces 2 fixes and improves locking style >consistency in the VT-d device. > >Changes since v4: > - Re-check if the address space is present once

Re: [PATCH] meson: use thorough test setup as default

2025-05-06 Thread Thomas Huth
On 06/05/2025 11.36, Daniel P. Berrangé wrote: On Sat, May 03, 2025 at 01:18:06PM -0700, Pierrick Bouvier wrote: Allows all tests to be visible by default when using meson test directly. This has no impact on make check-* commands, which use SPEED=quick by default (see scripts/mtest2make.py).

Re: [PATCH 8/9] virtio-gpu: fix hang under TCG when unmapping blob

2025-05-06 Thread Alex Bennée
Akihiko Odaki writes: > On 2025/04/30 3:48, Dmitry Osipenko wrote: >> On 4/28/25 15:59, Alex Bennée wrote: >>> From: Manos Pitsidianakis >>> >>> This commit fixes an indefinite hang when using VIRTIO GPU blob objects >>> under TCG in certain conditions. >>> >>> The VIRTIO_GPU_CMD_RESOURCE_MAP_B

Re: [PATCH 6/9] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

2025-05-06 Thread Alex Bennée
Dmitry Osipenko writes: > On 5/4/25 10:20, Akihiko Odaki wrote: >> On 2025/04/30 3:56, Dmitry Osipenko wrote: >>> On 4/28/25 15:59, Alex Bennée wrote: Seeing as I've taken a few patches to here now I might as well put myself forward to maintain virtio-gpu. I've marked it as Odd Fixes a

Re: [PATCH 3/5] rust: vmstate: convert to use builder pattern

2025-05-06 Thread Paolo Bonzini
On Tue, May 6, 2025 at 11:35 AM Zhao Liu wrote: > > > +unsafe extern "C" fn vmstate_pre_load_cb< > > +T, > > +F: for<'a> FnCall<(&'a T,), Result<(), impl Into>>, > > +>( > > +opaque: *mut c_void, > > +) -> c_int { > > +// SAFETY: assumes vmstate_struct! is used correctly > > +l

Re: [PATCH for-10.1 00/10] Support vdagent migration

2025-05-06 Thread Marc-André Lureau
Hi On Tue, Mar 11, 2025 at 8:16 PM Daniel P. Berrangé wrote: > > On Tue, Mar 11, 2025 at 07:59:22PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > > > iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmfQXbMcHG1hcmNhbmRy > > ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5bmLD

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Paolo Bonzini
On Tue, May 6, 2025 at 11:49 AM Daniel P. Berrangé wrote: > > > [...] If Rust is missing or old, "enable > > > all devices written in Rust" will fail compilation (e.g. Kconfig would > > > fail for ARM/x86 targets due to unsatisfiable CONFIG_PL011); > > > "enable Rust" will simply pick the C versio

Re: [PATCH 2/5] rust: use inline const expressions

2025-05-06 Thread Paolo Bonzini
On Tue, May 6, 2025 at 10:51 AM Zhao Liu wrote: > > -let _: () = CanReceiveFn::ASSERT_IS_SOME; > > +const { assert!(CanReceiveFn::IS_SOME) }; > > Do you think it's a good idea to warp this as a helper for easy > callback calls? I think the wrapper would be very similar to what exi

Re: [PATCH v2] ui/gtk-gl-area: Remove extra draw call in refresh

2025-05-06 Thread Alex Bennée
dongwon@intel.com writes: > From: Dongwon Kim > > This partially reverts commit 77bf310084dad38b3a2badf01766c659056f1cf2 > which causes some guest display corruption when gtk-gl-area > is used for GTK rendering (e.g. Wayland Compositor) possibly due to > simulataneous accesses on the guest fr

Re: [PATCH 02/20] tcg/optimize: Add one's mask to TempOptInfo

2025-05-06 Thread Paolo Bonzini
On 5/5/25 22:27, Richard Henderson wrote: +/* Bits that are known 1 and bits that are known 0 must not overlap. */ +tcg_debug_assert((o_mask & ~z_mask) == 0); + +/* All bits that are not known zero are known one is a constant. */ +if (z_mask == o_mask) { +return tcg_opt_ge

Re: [PATCH v8 48/55] i386/tdx: Add XFD to supported bit of TDX

2025-05-06 Thread Zhao Liu
On Tue, Apr 01, 2025 at 09:01:58AM -0400, Xiaoyao Li wrote: > Date: Tue, 1 Apr 2025 09:01:58 -0400 > From: Xiaoyao Li > Subject: [PATCH v8 48/55] i386/tdx: Add XFD to supported bit of TDX > X-Mailer: git-send-email 2.34.1 > > Just mark XFD as always supported for TDX. This simple solution relies

Re: [PATCH v8 46/55] i386/tdx: Add supported CPUID bits related to TD Attributes

2025-05-06 Thread Zhao Liu
On Tue, Apr 01, 2025 at 09:01:56AM -0400, Xiaoyao Li wrote: > Date: Tue, 1 Apr 2025 09:01:56 -0400 > From: Xiaoyao Li > Subject: [PATCH v8 46/55] i386/tdx: Add supported CPUID bits related to TD > Attributes > X-Mailer: git-send-email 2.34.1 > > For TDX, some CPUID feature bit is configured via

Re: [PATCH 15/20] tcg/optimize: Build and use z_bits and o_bits in fold_extract2

2025-05-06 Thread Paolo Bonzini
On 5/5/25 22:27, Richard Henderson wrote: +uint64_t v1 = ti_const_val(t1); +uint64_t v2 = ti_const_val(t2); Are v1 and v2 needed at all? If starting from z1==o1 and z2==o2, you will always end up with z1|z2 == o1|o2 after these: +z1 = (uint32_t)z1 >> shr; +o1 = (uin

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-06 Thread John Levon
On Mon, May 05, 2025 at 11:19:30AM +0200, Cédric Le Goater wrote: > > +int vfio_device_get_irq_info(VFIODevice *vbasedev, int index, > > +struct vfio_irq_info *info); > > This is breaking the windows build. Sorry, I forgot to set up cross-compile. I've done so now

Re: [PATCH v2 1/6] hw/arm/smmuv3: Add support to associate a PCIe RC

2025-05-06 Thread Markus Armbruster
Shameer Kolothum via writes: > Although this change does not affect functionality at present, it lays > the groundwork for enabling user-created SMMUv3 devices in > future patches > > Signed-off-by: Shameer Kolothum > --- > hw/arm/smmuv3.c | 26 ++ > hw/arm/virt.c | 3

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-06 Thread John Levon
On Tue, May 06, 2025 at 02:27:21PM +0200, Cédric Le Goater wrote: > !---| > CAUTION: External Email > > |---! > > On 5/6/25 13:38, John Levon wrote: > > On Mon, May 05

[PATCH v2 07/14] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

2025-05-06 Thread Alex Bennée
Seeing as I've taken a few patches to here now I might as well put myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as it is not my core focus. If someone with more GPU experience comes forward we can always update again. Signed-off-by: Alex Bennée --- v2 - s/M:/S:/ for the m

[PATCH v2 09/14] hw/display: re-arrange memory region tracking

2025-05-06 Thread Alex Bennée
QOM objects can be embedded in other QOM objects and managed as part of their lifetime but this isn't the case for virtio_gpu_virgl_hostmem_region. However before we can split it out we need some other way of associating the wider data structure with the memory region. Fortunately MemoryRegion has

[PATCH v2 12/14] ui/gtk-gl-area: Remove extra draw call in refresh

2025-05-06 Thread Alex Bennée
From: Dongwon Kim This partially reverts commit 77bf310084dad38b3a2badf01766c659056f1cf2 which causes some guest display corruption when gtk-gl-area is used for GTK rendering (e.g. Wayland Compositor) possibly due to simulataneous accesses on the guest frame buffer by host compositor and the gues

Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-06 Thread Peter Maydell
On Thu, 1 May 2025 at 20:02, Philippe Mathieu-Daudé wrote: > > On 1/5/25 20:34, Bernhard Beschow wrote: > > The DEFINE_TYPES() macro doesn't need the qemu/module.h include. > > > > Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using > > DEFINE_TYPES() macro") > > The 'Fixes:'

Re: [PATCH 1/2] migration/multifd: Fix received packets tracepoint

2025-05-06 Thread Peter Xu
On Mon, May 05, 2025 at 06:51:58PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, Apr 16, 2025 at 10:43:55AM -0300, Fabiano Rosas wrote: > >> When qatomic_fetch_inc() started being used to count the number of > >> packets sent, the printing of the number of packets received stopped

Re: [PATCH v4 1/4] hw/s390x: add SCLP event type CPI

2025-05-06 Thread Shalini Chellathurai Saroja
On 2025-05-06 09:48, Thomas Huth wrote: On 06/05/2025 08.48, Nina Schoetterl-Glausch wrote: On Mon, 2025-05-05 at 08:55 +0200, Shalini Chellathurai Saroja wrote: On 2025-04-28 11:22, Janis Schoetterl-Glausch wrote: On Thu, 2025-04-10 at 17:09 +0200, Shalini Chellathurai Saroja wrote: Implemen

RE: [PATCH v2 1/6] hw/arm/smmuv3: Add support to associate a PCIe RC

2025-05-06 Thread Shameerali Kolothum Thodi via
Hi Markus, > -Original Message- > From: Markus Armbruster > Sent: Tuesday, May 6, 2025 12:47 PM > To: Shameer Kolothum via > Cc: qemu-...@nongnu.org; Shameerali Kolothum Thodi > ; eric.au...@redhat.com; > peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > ddut...@redhat.co

[PATCH v2 14/14] docs: Use uniquelabel in qemu-block-drivers.rst.inc

2025-05-06 Thread Alex Bennée
From: Peter Maydell Use the uniquelabel directive for the 'nbd' label in qemu-block-drivers.rst.inc. This avoids a complaint from some Sphinx versions about it being a duplicate label, and means that we can reliably ensure that the link in codebase.rst goes to the document file that we intend (i

[PATCH v2 03/14] tests/tcg: make aarch64 boot.S handle different starting modes

2025-05-06 Thread Alex Bennée
Currently the boot.S code assumes everything starts at EL1. This will break things like the memory test which will barf on unaligned memory access when run at a higher level. Adapt the boot code to do some basic verification of the starting mode and the minimal configuration to move to the lower e

[PATCH v2 04/14] Running with --enable-ubsan leads to a qtest failure

2025-05-06 Thread Alex Bennée
From: Nabih Estefan ../tests/qtest/libqos/igb.c:106:5: runtime error: load of misaligned address 0x562040be8e33 for type 'uint32_t', which requires 4 byte alignment Instead of straight casting the uint8_t array, we use use ldl_le_p and lduw_l_p to assure alignment is correct against uint32_t

[PATCH v2 05/14] contrib/plugins: add a scaling factor to the ips arg

2025-05-06 Thread Alex Bennée
It's easy to get lost in zeros while setting the numbers of instructions per second. Add a scaling suffix to make things simpler. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- v2 - normalise the suffix before a full strcmp0 - check endptr actually set - fix checkpatch ---

[PATCH v2 10/14] virtio-gpu: fix hang under TCG when unmapping blob

2025-05-06 Thread Alex Bennée
From: Manos Pitsidianakis This commit fixes an indefinite hang when using VIRTIO GPU blob objects under TCG in certain conditions. The VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB VIRTIO command creates a MemoryRegion and attaches it to an offset on a PCI BAR of the VirtIOGPUdevice. The VIRTIO_GPU_CMD_RESOU

[PATCH v2 01/14] tests/docker: expose $HOME/.cache/qemu as docker volume

2025-05-06 Thread Alex Bennée
If you want to run functional tests we should share .cache/qemu so we don't force containers to continually re-download images. Signed-off-by: Alex Bennée --- v2 - Share a whole .cache/qemu path. --- tests/docker/Makefile.include | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-

  1   2   3   4   >