[PATCH 0/5] accel/kvm: Support KVM PMU filter

2025-04-09 Thread Zhao Liu
Hi all, Now I've converted the previous RFC (v2) to PATCH. Compared with RFC v2 [1], this version mianly have the following changes: * Make PMU related QAPIs accept decimal value instead of string. * Introduce a three-level QAPI section to organize KVM PMU stuff. * Fix QAPI related style issue

RE: [PATCH rfcv2 03/20] HostIOMMUDevice: Introduce realize_late callback

2025-04-09 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH rfcv2 03/20] HostIOMMUDevice: Introduce realize_late >callback > >On 4/7/25 13:19, Cédric Le Goater wrote: >> On 2/19/25 09:22, Zhenzhong Duan wrote: >>> Currently we have realize() callback which is called before attachmen

Re: [PULL 0/4] Block layer patches

2025-04-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v3 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
Actualize documentation and synchronize it for commands which actually call the same functions internally. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 61 ++-- qapi/job.json| 30 -- 2 files changed, 64

[PATCH v3 0/2] deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
This is for 10.1, of course. v3: fix wording, typos v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsement...@yandex-team.ru> Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and blo

RE: [PATCH v2] hw/i2c/aspeed: Fix wrong I2CC_DMA_LEN when I2CM_DMA_TX/RX_ADDR set first

2025-04-09 Thread Jamin Lin
Hi Cedric, After discussing with the I2C hardware designers, we confirmed that the I2c design in AST2600 and AST2700 A1 is the same. The datasheet will be updated accordingly for AST2700. However, please note that bit 15 and bit 31 are not available on AST2700 A0 and FW do not set either bit 15

Re: [PATCH v4 01/13] memory: Export a helper to get intersection of a MemoryRegionSection with a given range

2025-04-09 Thread Alexey Kardashevskiy
On 9/4/25 16:26, Chenyi Qiang wrote: On 4/9/2025 10:47 AM, Alexey Kardashevskiy wrote: On 7/4/25 17:49, Chenyi Qiang wrote: Rename the helper to memory_region_section_intersect_range() to make it more generic. Meanwhile, define the @end as Int128 and replace the related operations with In

[PATCH v3 01/16] hw/intc/loongarch_pch: Modify name of some registers

2025-04-09 Thread Bibo Mao
For some registers with width 8 bytes, its name is something like PCH_PIC_INT_ID_LO and PCH_PIC_INT_ID_HI. From hardware manual, register name is PCH_PIC_INT_ID instead. Here name PCH_PIC_INT_ID is used, and PCH_PIC_INT_ID + 4 is used for PCH_PIC_INT_ID_HI. Signed-off-by: Bibo Mao --- hw/intc/lo

Re: [PULL 00/11] QAPI patches patches for 2025-04-08

2025-04-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

[PATCH 2/5] i386/kvm: Support basic KVM PMU filter

2025-04-09 Thread Zhao Liu
Filter PMU events with raw format in i386 code. For i386, raw format indicates that the PMU event code is already encoded according to the KVM ioctl requirements, and can be delivered directly to KVM without additional encoding work. Signed-off-by: Zhao Liu Tested-by: Yi Lai --- Changes since R

Re: [PATCH 13/16] mcd: Implement register/memory access

2025-04-09 Thread Mario Fleischmann
Just found out that in the call stack of address_space_rw, the len argument eventually becomes the access width, if applicable. I wasn't aware of that because GDB's 'm' and 'M' packets don't pose any requirements on the access width ("the stub is free to use byte accesses, or not") and therefore th

Re: [PATCH v4 04/13] memory: Introduce generic state change parent class for RamDiscardManager

2025-04-09 Thread Alexey Kardashevskiy
On 7/4/25 17:49, Chenyi Qiang wrote: RamDiscardManager is an interface used by virtio-mem to adjust VFIO mappings in relation to VM page assignment. It manages the state of populated and discard for the RAM. To accommodate future scnarios for managing RAM states, such as private and shared sta

Re: [PATCH v4 06/13] vfio: Add the support for PrivateSharedManager Interface

2025-04-09 Thread Alexey Kardashevskiy
On 7/4/25 17:49, Chenyi Qiang wrote: Subsystems like VFIO previously disabled ram block discard and only allowed coordinated discarding via RamDiscardManager. However, guest_memfd in confidential VMs relies on discard operations for page conversion between private and shared memory. This can l

Re: [PATCH rfcv2 03/20] HostIOMMUDevice: Introduce realize_late callback

2025-04-09 Thread Cédric Le Goater
On 4/9/25 10:27, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Subject: Re: [PATCH rfcv2 03/20] HostIOMMUDevice: Introduce realize_late callback On 4/7/25 13:19, Cédric Le Goater wrote: On 2/19/25 09:22, Zhenzhong Duan wrote: Currently we have realize() callback

Re: [PATCH v4 05/13] memory: Introduce PrivateSharedManager Interface as child of GenericStateManager

2025-04-09 Thread Alexey Kardashevskiy
On 7/4/25 17:49, Chenyi Qiang wrote: To manage the private and shared RAM states in confidential VMs, introduce a new class of PrivateShareManager as a child of missing "d" in "PrivateShareManager" GenericStateManager, which inherits the six interface callbacks. With a different interface

[PATCH v1 1/9] hw/arm/aspeed_ast27x0: Add "vbootrom_size" field to AspeedSoCClass

2025-04-09 Thread Jamin Lin via
Introduced a "vbootrom_size" attribute in "AspeedSoCClass" to define virtual boot ROM size. Initialized "vbootrom_size" to "0x2" for both AST2700 A0 and A1 variants. Signed-off-by: Jamin Lin --- include/hw/arm/aspeed_soc.h | 1 + hw/arm/aspeed_ast27x0.c | 2 ++ 2 files changed, 3 inserti

[PATCH v1 6/9] hw/arm/aspeed: Add support for loading vbootrom image via "-bios"

2025-04-09 Thread Jamin Lin via
Introduce "aspeed_load_vbootrom()" to support loading a virtual boot ROM image into the vbootrom memory region, using the "-bios" command-line option. Signed-off-by: Jamin Lin --- hw/arm/aspeed.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/arm/aspeed.

[PATCH v1 9/9] docs/system/arm/aspeed: Support vbootrom for AST2700

2025-04-09 Thread Jamin Lin via
Using the vbootrom image instead of manually loading boot components with -device loader. The boot ROM binary is now passed via the -bios option, using the image located in pc-bios/ast27x0_bootrom.bin. Signed-off-by: Jamin Lin --- docs/system/arm/aspeed.rst | 18 -- 1 file change

[PATCH v1 5/9] hw/arm/aspeed: Reuse rom_size variable for vbootrom setup

2025-04-09 Thread Jamin Lin via
Move the declaration of `rom_size` to an outer scope in aspeed_machine_init() so it can be reused for setting up the vbootrom region as well. This avoids introducing a redundant local variable and ensures consistent ROM sizing logic when both SPI boot and vbootrom are used. Signed-off-by: Jamin L

[PATCH v1 0/9] Support vbootrom for AST2700

2025-04-09 Thread Jamin Lin via
v1: Add initial support for AST27x0 The purpose of vbootrom here is to simulate the work of BootMCU SPL (riscv) in AST2700, because QEMU doesn't support heterogenous architecture yet. ast27x0_bootrom.bin is a simplified, free (Apache 2.0) boot ROM for ASPEED AST27x0 BMC SOC. It currentl

[PATCH v1 7/9] pc-bios: Add AST27x0 vBootrom

2025-04-09 Thread Jamin Lin via
The boot ROM is a minimal implementation designed to load an AST27x0 boot image. Its source code is available at: https://github.com/google/vbootrom Signed-off-by: Jamin Lin --- MAINTAINERS | 1 + pc-bios/README | 6 ++ pc-bios/ast27x0_bootrom.bin | Bin 0 ->

[PATCH v1 4/9] hw/arm/aspeed: Enable vbootrom support by default on AST2700 EVB machines

2025-04-09 Thread Jamin Lin via
Introduce a new "vbootrom" field in the AspeedMachineClass to indicate whether a machine supports the virtual boot ROM region. Set this field to true by default for the AST2700-A0 and AST2700-A1 EVB machines. Signed-off-by: Jamin Lin --- include/hw/arm/aspeed.h | 1 + hw/arm/aspeed.c |

[PATCH v1 8/9] tests/functional/aspeed: Update AST2700 functional test to use vbootrom

2025-04-09 Thread Jamin Lin via
Refactor the AST2700 functional test to boot using the vbootrom image instead of manually loading boot components with -device loader. The boot ROM binary is now passed via the -bios option, using the image located in pc-bios/ast27x0_bootrom.bin. Signed-off-by: Jamin Lin --- tests/functional/tes

Re: [PATCH v2] hw/i2c/aspeed: Fix wrong I2CC_DMA_LEN when I2CM_DMA_TX/RX_ADDR set first

2025-04-09 Thread Cédric Le Goater
Hello, On 4/9/25 11:10, Jamin Lin wrote: Hi Cedric, After discussing with the I2C hardware designers, we confirmed that the I2c design in AST2600 and AST2700 A1 is the same. The datasheet will be updated accordingly for AST2700. However, please note that bit 15 and bit 31 are not available on

Re: [PATCH for-10.1 v4 04/13] arm/cpu: Store aa64pfr0/1 into the idregs array

2025-04-09 Thread Cornelia Huck
On Wed, Mar 26 2025, Cornelia Huck wrote: > From: Eric Auger > > Reviewed-by: Richard Henderson > Reviewed-by: Sebastian Ott > Signed-off-by: Eric Auger > Signed-off-by: Cornelia Huck > --- > target/arm/cpu-features.h | 40 - > target/arm/cpu.c | 29

[PATCH v1 3/9] hw/arm/aspeed_ast27x0 Introduce vbootrom memory region

2025-04-09 Thread Jamin Lin via
Introduce a new vbootrom memory region. The region is mapped at address "0x" and has a size of 128KB, identical to the SRAM region size. This memory region is intended for loading a vbootrom image file as part of the boot process. The vbootrom region is initialized as ROM and registered in

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-09 Thread Mario Fleischmann
On 08.04.2025 16:37, Markus Armbruster wrote: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> Alex Bennée writes: >>> Markus Armbruster writes: > Mario Fleischmann writes: > >> Apologies for the line wrapping in yesterday's answer. Should be fixed >> no

Re: [PATCH 1/3] scripts: nixify archive-source.sh

2025-04-09 Thread Thomas Huth
On 08/04/2025 22.14, Joel Granados wrote: Use "#!/usr/bin/env bash" instead of "#!/bin/bash". This is necessary for nix environments as they only provide /usr/bin/env at the standard location. Signed-off-by: Joel Granados --- scripts/archive-source.sh | 2 +- 1 file changed, 1 insertion(+),

[PATCH v6] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dumps or do some other debugging - inform the user through a management API or UI, so that (s)he

Re: [PATCH v4 07/13] ram-block-attribute: Introduce RamBlockAttribute to manage RAMBLock with guest_memfd

2025-04-09 Thread Alexey Kardashevskiy
On 7/4/25 17:49, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") highlighted that subsystems like VFIO may disable RAM block discard. However, guest_memfd relies on discard operations for page conversion between private and shared memory, pote

Re: [PATCH v1 0/2] virtio-gpu: fix blob unmapping sequence

2025-04-09 Thread Alex Bennée
Manos Pitsidianakis writes: > A hang was observed when running a small kernel that exercised VIRTIO > GPU under TCG. This is an edge-case and won't happen under typical > conditions. > > When unmapping a blob object, its MemoryRegion's freeing is deferred to > the RCU thread. The hang's cause

Re: [PATCH v6] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-09 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > For now we only log the vhost device error, when virtqueue is actually > stopped. Let's add a QAPI event, which makes possible: > > - collect statistics of such errors > - make immediate actions: take core dumps or do some other debugging > - inform the u

Re: [PULL 0/2] ppc-for-10.0-3 queue

2025-04-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v6] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

2025-04-09 Thread Kevin Wolf
Am 07.04.2025 um 17:47 hat Pinku Deb Nath geschrieben: > Full Unit Access (FUA) is an optimization where a disk write with the > flag set will be persisted to disk immediately instead of potentially > remaining in the disk's write cache. > > This commit address the todo task > for using pwritev2()

[PATCH 5/5] i386/kvm: Support fixed counter in KVM PMU filter

2025-04-09 Thread Zhao Liu
KVM_SET_PMU_EVENT_FILTER of x86 KVM allows user to configure x86 fixed function counters by a bitmap. Add the support of x86-fixed-counter in kvm-pmu-filter object and handle this in i386 kvm codes. Signed-off-by: Zhao Liu Tested-by: Yi Lai --- Changes since RFC v2: * Drop KVMPMUX86FixedCounte

[PATCH 4/5] i386/kvm: Support event with masked entry format in KVM PMU filter

2025-04-09 Thread Zhao Liu
KVM_SET_PMU_EVENT_FILTER of x86 KVM supports masked events mode, which accepts masked entry format event to flexibly represent a group of PMU events. Support masked entry format in kvm-pmu-filter object and handle this in i386 kvm codes. Signed-off-by: Zhao Liu Tested-by: Yi Lai --- Changes sin

[PATCH v3 10/16] hw/intc/loongarch_pch: Use generic write callback for iomem32_low region

2025-04-09 Thread Bibo Mao
For memory region iomem32_low, generic write callback is used. Signed-off-by: Bibo Mao --- hw/intc/loongarch_pch_pic.c | 140 +++- 1 file changed, 73 insertions(+), 67 deletions(-) diff --git a/hw/intc/loongarch_pch_pic.c b/hw/intc/loongarch_pch_pic.c index 06fac

[PATCH v1 24/24] hw/s390x/ipl: Handle secure boot without specifying a boot device

2025-04-09 Thread Zhuoying Cai
If secure boot in audit mode or True Secure IPL mode is enabled without specifying a boot device, the boot process will terminate with an error. Signed-off-by: Zhuoying Cai --- hw/s390x/ipl.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 60

Re: [PATCH 07/10] tcg: Add a TCG backend for WebAssembly

2025-04-09 Thread Philippe Mathieu-Daudé
On 7/4/25 16:45, Kohei Tokunaga wrote: A TB consists of a wasmTBHeader followed by the data listed below. The wasmTBHeader contains pointers for each element: - TCI code - Wasm code - Array of function indices imported into the Wasm instance - Counter tracking the number of TB executions - Point

Re: [PATCH PoC 1/7] QAPI: gpio JSON

2025-04-09 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Mar 19, 2025 at 10:57:51AM +0300, Nikita Shubin via B4 Relay wrote: >> From: Nikita Shubin >> >> Signed-off-by: Nikita Shubin The commit message should briefly explain the purpose of the change. >> --- >> qapi/gpio.json| 68 >> ++

Re: [PATCH 00/16] Add Multi-Core Debug (MCD) API support

2025-04-09 Thread Markus Armbruster
Alex Bennée writes: > Mario Fleischmann writes: > >> On 08.04.2025 16:37, Markus Armbruster wrote: [...] >>> Use of QAPI/QMP does not imply use of the QMP monitor. We can keep the >>> monitor and the debugging interface separate even though both are based >>> on QAPI/QMP. >>> >>> The monitor

Re: [PATCH v3 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-09 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Actualize documentation and synchronize it for commands which actually > call the same functions internally. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-04-09 Thread Ani Sinha
> On Apr 9, 2025, at 03:12, Dionna Amalie Glaze wrote: > > On Tue, Apr 8, 2025 at 1:33 AM Gerd Hoffman wrote: >> >> Hi, >> Well. If you want put the db into the igvm and the igvm into the uki you've got a chicken-and-egg problem. Moving the firmware from the main UKI to UK

[PATCH v3 11/16] hw/intc/loongarch_pch: Use generic write callback for iomem32_high region

2025-04-09 Thread Bibo Mao
Add iomem32_high region register write operation emulation in generic write function loongarch_pch_pic_write(), and use this function for iomem32_high region. Signed-off-by: Bibo Mao --- hw/intc/loongarch_pch_pic.c | 28 +--- 1 file changed, 5 insertions(+), 23 deletions(

<    1   2