[Bug 2072564] Autopkgtest regression report (qemu/1:9.0.2+ds-4ubuntu5.3)

2025-04-09 Thread Ubuntu SRU Bot
All autopkgtests for the newly accepted qemu (1:9.0.2+ds-4ubuntu5.3) for oracular have finished running. The following regressions have been reported in tests triggered by the package: casper/1.502 (amd64) glance/2:29.0.0-0ubuntu1 (amd64) nova/unknown (s390x) sbuild/0.85.10ubuntu1 (ppc64el) Ple

Re: [PATCH v4 04/13] memory: Introduce generic state change parent class for RamDiscardManager

2025-04-09 Thread Chenyi Qiang
On 4/10/2025 8:11 AM, Alexey Kardashevskiy wrote: > > > On 9/4/25 22:57, Chenyi Qiang wrote: >> >> >> On 4/9/2025 5:56 PM, Alexey Kardashevskiy wrote: >>> >>> >>> On 7/4/25 17:49, Chenyi Qiang wrote: RamDiscardManager is an interface used by virtio-mem to adjust VFIO mappings in rela

Re: [PATCH v3 05/10] target/i386/kvm: extract unrelated code out of kvm_x86_build_cpuid()

2025-04-09 Thread Zhao Liu
On Sun, Mar 30, 2025 at 06:32:24PM -0700, Dongli Zhang wrote: > Date: Sun, 30 Mar 2025 18:32:24 -0700 > From: Dongli Zhang > Subject: [PATCH v3 05/10] target/i386/kvm: extract unrelated code out of > kvm_x86_build_cpuid() > X-Mailer: git-send-email 2.43.5 > > The initialization of 'has_architect

Re: [PATCH v4 06/13] vfio: Add the support for PrivateSharedManager Interface

2025-04-09 Thread Chenyi Qiang
On 4/9/2025 5:58 PM, Alexey Kardashevskiy wrote: > > > On 7/4/25 17:49, Chenyi Qiang wrote: >> Subsystems like VFIO previously disabled ram block discard and only >> allowed coordinated discarding via RamDiscardManager. However, >> guest_memfd in confidential VMs relies on discard operations f

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster
Steven Sistare writes: > On 4/9/2025 10:44 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >>> On 4/9/2025 9:34 AM, Markus Armbruster wrote: Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: [...] Anyway, asking you to fix design mistakes all over

RE: [PATCH v1 0/9] Support vbootrom for AST2700

2025-04-09 Thread Jamin Lin
Hi all, > Subject: [PATCH v1 0/9] Support vbootrom for AST2700 > > v1: > Add initial support for AST27x0 > The purpose of vbootrom here is to simulate the work of BootMCU SPL > (riscv) > in AST2700, because QEMU doesn't support heterogenous architecture yet. > > ast27x0_bootrom.bin is a

[PATCH 0/2] block: discard alignment fixes

2025-04-09 Thread Stefan Hajnoczi
Two discard alignment issues were identified in https://issues.redhat.com/browse/RHEL-86032: 1. pdiscard_alignment is not populated for host_device in file-posix.c. 2. Misaligned head/tail discard requests are not skipped when file-posix.c returns -EINVAL. This causes an undesired pause when gue

[PATCH v3 0/5] misc hexagon patches

2025-04-09 Thread Brian Cain
Changes since previous "misc hexagon patches" series (v2): - changed author to match MAINTAINERS (I was fooled by the mailmap before -- so, for real this time). Brian Cain (5): target/hexagon: handle .new values target/hexagon: Fix badva reference, delete CAUSE target/hexagon: Add missing A

[PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-09 Thread Bernhard Beschow
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow -- v2: * Make test file executable (Thomas) * Omit fetch() (Thomas) * Omit "-accel

[PATCH v3 2/5] target/hexagon: Fix badva reference, delete CAUSE

2025-04-09 Thread Brian Cain
The BADVA reg is referred to with the wrong identifier. The CAUSE reg field of SSR is not yet modeled. Signed-off-by: Brian Cain --- target/hexagon/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 766b678651..62f1fe15b

Note improvements to QAPI-generated manuals in ChangeLog/10.0?

2025-04-09 Thread Markus Armbruster
John improved looks and usabilibity of the QAPI-generated manuals quite a bit. These are QEMU QMP Reference Manual QEMU Storage Daemon QMP Reference Manual QEMU Guest Agent Protocol Reference Where should it go? https://wiki.qemu.org/ChangeLog/10.0 has no section dedicated to the ma

Re: [PULL 0/2] loongarch bug fix for 10.0

2025-04-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v6] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
On 09.04.25 13:48, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dumps or d

[PATCH for-10.1 v5 06/13] arm/cpu: Store aa64dfr0/1 into the idregs array

2025-04-09 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 16 target/arm/cpu.c | 15 +-- target/arm/cpu.h | 2 -- target/arm/cpu64.c

[PATCH for-10.1 v5 09/13] arm/cpu: Store id_pfr0/1/2 into the idregs array

2025-04-09 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 5 +- target/arm/cpu-features.h | 10 ++-- target/arm/cpu.c | 8 +-- target/arm/cpu.h | 3 - target/arm/c

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster
Steven Sistare writes: > On 4/9/2025 9:34 AM, Markus Armbruster wrote: >> Steven Sistare writes: >>> On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes and pro

[PATCH for-10.1 v5 01/13] arm/cpu: Add sysreg definitions in cpu-sysregs.h

2025-04-09 Thread Cornelia Huck
From: Eric Auger This new header contains macros that define aarch64 registers. In a subsequent patch, this will be replaced by a more exhaustive version that will be generated from linux arch/arm64/tools/sysreg file. Those macros are sufficient to migrate the storage of those ID regs from named

Re: [PATCH 02/14] vfio: refactor out vfio_pci_config_setup()

2025-04-09 Thread Tomita Moeko
Hi, John On 4/9/25 21:48, John Levon wrote: > Refactor the PCI config setup code out of vfio_realize() for > readability. > > Reviewed-by: Cédric Le Goater > Signed-off-by: John Levon > --- > hw/vfio/pci.c | 176 +++--- > 1 file changed, 94 insertion

Re: [PATCH v3 0/2] vfio/spapr: Fix L2 crash with PCI device passthrough

2025-04-09 Thread Cédric Le Goater
On 4/8/25 14:40, Amit Machhiwal wrote: Hi, This patch series addresses two aspects in vfio_spapr_create_window() that includes the enhancement in error handling in this function and also fixes an issue with KVM guests (L2) inside a pSeries logical partition (LPAR) with larger memory configuratio

Re: [PATCH V7 00/24] Live update: cpr-transfer

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
On 09.04.25 19:22, Vladimir Sementsov-Ogievskiy wrote: [offlist] Hah, decided to send offlist, but forget to clear CC. Sorry. However, nothing secret here. Moreover, interesting, what do all think about a cpr-exec variant with loading QEMU as library instead of doing exec. On 15.01.25 22:

Re: [PATCH V7 00/24] Live update: cpr-transfer

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
On 09.04.25 20:48, Steven Sistare wrote: On 4/9/2025 12:22 PM, Vladimir Sementsov-Ogievskiy wrote: On 15.01.25 22:00, Steve Sistare wrote: This patch series implements a minimal version of cpr-transfer.  Additional series are ready to be posted to deliver the complete vision described above, i

[PATCH v1 2/9] hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize

2025-04-09 Thread Jamin Lin via
The variable "sram_name" was only used for naming the SRAM memory region. Rename it to "name" for consistency with similar code and avoid unnecessary new local variable declarations. Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 8 1 file changed, 4 insertions(+), 4 deletions(-

Re: [PATCH 0/1] hw/nvme: create parameter to enable/disable cmic on subsystem

2025-04-09 Thread alan . adamson
On 4/8/25 11:47 PM, Klaus Jensen wrote: On Apr 8 15:56, Alan Adamson wrote: While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Linux was incorrectly displaying atomic_write_max_bytes # cat /sys/block/nvme0n1/queue/atomic_write_max_bytes 0 # nvme id-ctrl /dev/nvme0n1 | grep awupf aw

Re: [PATCH v4 04/13] memory: Introduce generic state change parent class for RamDiscardManager

2025-04-09 Thread Alexey Kardashevskiy
On 9/4/25 22:57, Chenyi Qiang wrote: On 4/9/2025 5:56 PM, Alexey Kardashevskiy wrote: On 7/4/25 17:49, Chenyi Qiang wrote: RamDiscardManager is an interface used by virtio-mem to adjust VFIO mappings in relation to VM page assignment. It manages the state of populated and discard for the

Re: [PATCH 02/14] vfio: refactor out vfio_pci_config_setup()

2025-04-09 Thread John Levon
On Wed, Apr 09, 2025 at 11:38:01PM +0800, Tomita Moeko wrote: > On 4/9/25 21:48, John Levon wrote: > > Refactor the PCI config setup code out of vfio_realize() for > > readability. > > +if (!vfio_msix_early_setup(vdev, errp)) { > > +return false; > > +} > > + > > +vfio_bars_re

Re: [PATCH-for-10.1 v3 6/9] qtest/bios-tables-test: Whitelist aarch64/virt 'its_off' variant blobs

2025-04-09 Thread Gustavo Romero
Hi Igor, On 4/9/25 11:05, Igor Mammedov wrote: On Fri, 4 Apr 2025 00:01:22 -0300 Gustavo Romero wrote: Hi Phil, On 4/3/25 17:40, Philippe Mathieu-Daudé wrote: We are going to fix the test_acpi_aarch64_virt_tcg_its_off() test. In preparation, copy the ACPI tables which will be altered as 'it

Re: [PATCH 11/14] vfio: add vfio_pci_config_space_read/write()

2025-04-09 Thread Tomita Moeko
On 4/9/25 21:48, John Levon wrote: > Add these helpers that access config space and return an -errno style > return. > > Signed-off-by: John Levon > --- > hw/vfio/pci.c | 134 ++ > 1 file changed, 91 insertions(+), 43 deletions(-) > > diff --git a

Re: [PATCH V7 00/24] Live update: cpr-transfer

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
[offlist] On 15.01.25 22:00, Steve Sistare wrote: This patch series implements a minimal version of cpr-transfer. Additional series are ready to be posted to deliver the complete vision described above, including * vfio * chardev * vhost and tap * blockers * cpr-exec mode Hi St

Re: [PATCH v3 4/4] hw/s390x: compat handling for backward migration

2025-04-09 Thread Shalini Chellathurai Saroja
On 2025-04-09 07:49, Thomas Huth wrote: On 03/04/2025 14.49, Shalini Chellathurai Saroja wrote: On 2025-04-02 09:52, Thomas Huth wrote: On 31/03/2025 16.00, Shalini Chellathurai Saroja wrote: Add Control-Program Identification (CPI) device to QOM only when the virtual machine supports CPI. CPI

Re: [PATCH v4 04/13] memory: Introduce generic state change parent class for RamDiscardManager

2025-04-09 Thread Chenyi Qiang
On 4/9/2025 5:56 PM, Alexey Kardashevskiy wrote: > > > On 7/4/25 17:49, Chenyi Qiang wrote: >> RamDiscardManager is an interface used by virtio-mem to adjust VFIO >> mappings in relation to VM page assignment. It manages the state of >> populated and discard for the RAM. To accommodate future

[PATCH 1/5] qapi/qom: Introduce kvm-pmu-filter object

2025-04-09 Thread Zhao Liu
Introduce the kvm-pmu-filter object and support the PMU event with raw format. The raw format, as a native PMU event code representation, can be used for several architectures. Signed-off-by: Zhao Liu Tested-by: Yi Lai --- Changes since RFC v2: * Drop hexadecimal variants and support numeric v

[PATCH v3 2/2] qapi/block-core: deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() checks whether the found job is a block-job. Th

Re: [PATCH 11/14] vfio: add vfio_pci_config_space_read/write()

2025-04-09 Thread John Levon
On Wed, Apr 09, 2025 at 11:51:09PM +0800, Tomita Moeko wrote: > On 4/9/25 21:48, John Levon wrote: > > Add these helpers that access config space and return an -errno style > > return. > > > > Signed-off-by: John Levon > > --- > > hw/vfio/pci.c | 134 ++--

Re: [PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-09 Thread Philippe Mathieu-Daudé
Hi Kohei, On 7/4/25 16:45, Kohei Tokunaga wrote: On emscripten, function pointer casts can cause function call failure. This commit fixes the function definition to match to the type of the function call. - qtest_set_command_cb passed to g_once should match to GThreadFunc - object_class_cmp and

Re: [PATCH 00/10] Enable QEMU to run on browsers

2025-04-09 Thread Stefan Hajnoczi
On Mon, Apr 07, 2025 at 11:45:51PM +0900, Kohei Tokunaga wrote: > This patch series enables QEMU's system emulator to run in a browser using > Emscripten. > It includes implementations and workarounds to address browser environment > limitations, as shown in the following. I think it would be grea

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Steven Sistare
On 4/9/2025 10:44 AM, Markus Armbruster wrote: Steven Sistare writes: On 4/9/2025 9:34 AM, Markus Armbruster wrote: Steven Sistare writes: On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: Using qom-list and qom-get to get

Re: [PATCH v6] [for-10.1] virtio: add VIRTQUEUE_ERROR QAPI event

2025-04-09 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 09.04.25 13:48, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> For now we only log the vhost device error, when virtqueue is actually >>> stopped. Let's add a QAPI event, which makes possible: >>> >>> - collect statistics of s

Re: [PATCH 11/14] vfio: add vfio_pci_config_space_read/write()

2025-04-09 Thread Tomita Moeko
On 4/9/25 23:54, John Levon wrote: > On Wed, Apr 09, 2025 at 11:51:09PM +0800, Tomita Moeko wrote: > >> On 4/9/25 21:48, John Levon wrote: >>> Add these helpers that access config space and return an -errno style >>> return. >>> >>> Signed-off-by: John Levon >>> --- >>> hw/vfio/pci.c | 134 +

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster
Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: >> Hi Steve, I apologize for the slow response. >> >> Steve Sistare writes: >> >>> Using qom-list and qom-get to get all the nodes and property values in a >>> QOM tree can take multiple seconds because it requires 1000's o

[PATCH 07/14] vfio: specify VFIO_DMA_UNMAP_FLAG_ALL to callback

2025-04-09 Thread John Levon
Use the new flags parameter to indicate when we want to unmap everything; no functional change is intended. Signed-off-by: John Levon --- hw/vfio/container.c | 49 - hw/vfio/iommufd.c | 19 +- hw/vfio/listener.c | 19 ++--

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Peter Krempa
On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: > Hi Steve, I apologize for the slow response. > > Steve Sistare writes: > > > Using qom-list and qom-get to get all the nodes and property values in a > > QOM tree can take multiple seconds because it requires 1000's of

[PATCH for-10.1 v5 05/13] arm/cpu: Store aa64mmfr0-3 into the idregs array

2025-04-09 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 74 +++ target/arm/cpu.h | 4 --- target/arm/cpu64.c| 8 ++--- target/arm/h

Re: [PATCH V7 00/24] Live update: cpr-transfer

2025-04-09 Thread Steven Sistare
On 4/9/2025 12:22 PM, Vladimir Sementsov-Ogievskiy wrote: On 15.01.25 22:00, Steve Sistare wrote: This patch series implements a minimal version of cpr-transfer.  Additional series are ready to be posted to deliver the complete vision described above, including    * vfio    * chardev    * vhost

[Bug 2072564] Please test proposed package

2025-04-09 Thread Andreas Hasenack
Hello Dimitry, or anyone else affected, Accepted qemu into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:9.0.2+ds-4ubuntu5.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https

[Bug 2072564] Please test proposed package

2025-04-09 Thread Andreas Hasenack
Hello Dimitry, or anyone else affected, Accepted qemu into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:8.2.2+ds-0ubuntu1.7 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://

[Bug 2072564] Re: qemu-aarch64-static segfaults running ldconfig.real (amd64 host)

2025-04-09 Thread Andreas Hasenack
Given this possible regression: * This changes the alignment of sections in the ELF binary via QEMUs elfloader, if something goes wrong with this change, it could lead to all kind of crashes (segfault) of any emulated binaries. Is there something we could do to mitigate it? Perhaps a q

[Bug 2072564] Autopkgtest regression report (qemu/1:8.2.2+ds-0ubuntu1.7)

2025-04-09 Thread Ubuntu SRU Bot
All autopkgtests for the newly accepted qemu (1:8.2.2+ds-0ubuntu1.7) for noble have finished running. The following regressions have been reported in tests triggered by the package: glance/2:28.1.0-0ubuntu1 (amd64, arm64, ppc64el) livecd-rootfs/24.04.87 (s390x) Please visit the excuses page lis

Re: [PATCH v3 07/10] target/i386/kvm: query kvm.enable_pmu parameter

2025-04-09 Thread Zhao Liu
Hi Dongli, The logic is fine for me :-) And thank you to take my previous suggestion. When I revisit here after these few weeks, I have some thoughts: > +if (pmu_cap) { > +if ((pmu_cap & KVM_PMU_CAP_DISABLE) && > +!X86_CPU(cpu)->enable_pmu) { > +

[PATCH 0/2] amd_iommu: Fixes

2025-04-09 Thread Sairaj Kodilkar
Fix following two issues in the amd viommu 1. The guest fails to setup the device when pt_supported=on, because amd iommu enables the no DMA memory region even when device is using DMA remapping mode. 2. The guest fails to boot with xtsup=on and <= 255 vCPUs, because amd_iommu does not ena

[PATCH v2 05/10] hw/arm/aspeed: Enable vbootrom support by default on AST2700 EVB machines

2025-04-09 Thread Jamin Lin via
Introduce a new "vbootrom" field in the AspeedMachineClass to indicate whether a machine supports the virtual boot ROM region. Set this field to true by default for the AST2700-A0 and AST2700-A1 EVB machines. Signed-off-by: Jamin Lin --- include/hw/arm/aspeed.h | 1 + hw/arm/aspeed.c |

[PATCH v2 08/10] pc-bios: Add AST27x0 vBootrom

2025-04-09 Thread Jamin Lin via
The boot ROM is a minimal implementation designed to load an AST27x0 boot image. Its source code is available at: https://github.com/google/vbootrom Signed-off-by: Jamin Lin --- MAINTAINERS | 1 + pc-bios/README | 6 ++ pc-bios/ast27x0_bootrom.bin | Bin 0 ->

[PATCH v2 00/10] Support vbootrom for AST2700

2025-04-09 Thread Jamin Lin via
v1: Add initial support for AST27x0 The purpose of vbootrom here is to simulate the work of BootMCU SPL (riscv) in AST2700, because QEMU doesn't support heterogenous architecture yet. ast27x0_bootrom.bin is a simplified, free (Apache 2.0) boot ROM for ASPEED AST27x0 BMC SOC. It currentl

[PATCH v2 03/10] hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize

2025-04-09 Thread Jamin Lin via
The variable "sram_name" was only used for naming the SRAM memory region. Rename it to "name" for consistency with similar code and avoid unnecessary new local variable declarations. Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 8 1 file changed, 4 insertions(+), 4 deletions(-

[PATCH v2 06/10] hw/arm/aspeed: Reuse rom_size variable for vbootrom setup

2025-04-09 Thread Jamin Lin via
Move the declaration of `rom_size` to an outer scope in aspeed_machine_init() so it can be reused for setting up the vbootrom region as well. This avoids introducing a redundant local variable and ensures consistent ROM sizing logic when both SPI boot and vbootrom are used. Signed-off-by: Jamin L

[PATCH v2 04/10] hw/arm/aspeed_ast27x0 Introduce vbootrom memory region

2025-04-09 Thread Jamin Lin via
Introduce a new vbootrom memory region. The region is mapped at address "0x" and has a size of 128KB, identical to the SRAM region size. This memory region is intended for loading a vbootrom image file as part of the boot process. The vbootrom region is initialized as ROM and registered in

[PATCH v2 09/10] tests/functional/aspeed: Update AST2700 functional test to use vbootrom

2025-04-09 Thread Jamin Lin via
Refactor the AST2700 functional test to boot using the vbootrom image instead of manually loading boot components with -device loader. The boot ROM binary is now passed via the -bios option, using the image located in pc-bios/ast27x0_bootrom.bin. Signed-off-by: Jamin Lin --- tests/functional/tes

[PATCH v2 01/10] hw/arm/aspeed: Introduced ASPEED_DEV_VBOOTROM in the device enumeration

2025-04-09 Thread Jamin Lin via
Introduced ASPEED_DEV_VBOOTROM into the ASPEED device enumeration to support a virtual boot ROM. Signed-off-by: Jamin Lin --- include/hw/arm/aspeed_soc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index f069d17d16..37cd7cd793 100

[PATCH v2 10/10] docs/system/arm/aspeed: Support vbootrom for AST2700

2025-04-09 Thread Jamin Lin via
Using the vbootrom image instead of manually loading boot components with -device loader. The boot ROM binary is now passed via the -bios option, using the image located in pc-bios/ast27x0_bootrom.bin. Signed-off-by: Jamin Lin --- docs/system/arm/aspeed.rst | 18 -- 1 file change

[PATCH v2 07/10] hw/arm/aspeed: Add support for loading vbootrom image via "-bios"

2025-04-09 Thread Jamin Lin via
Introduce "aspeed_load_vbootrom()" to support loading a virtual boot ROM image into the vbootrom memory region, using the "-bios" command-line option. Signed-off-by: Jamin Lin --- hw/arm/aspeed.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/arm/aspeed.

Re: [PATCH v4 05/13] memory: Introduce PrivateSharedManager Interface as child of GenericStateManager

2025-04-09 Thread Chenyi Qiang
On 4/9/2025 5:56 PM, Alexey Kardashevskiy wrote: > > > On 7/4/25 17:49, Chenyi Qiang wrote: >> To manage the private and shared RAM states in confidential VMs, >> introduce a new class of PrivateShareManager as a child of > > missing "d" in "PrivateShareManager" Fixed. Thanks! > > >> Gene

Re: [PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-09 Thread Thomas Huth
On 09/04/2025 22.26, Bernhard Beschow wrote: Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow -- v2: * Make test file executable (

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-04-09 Thread Ani Sinha
> On 9 Apr 2025, at 11:51 AM, Gerd Hoffman wrote: > > Hi, > >>> The chicken-and-egg problem arises if you go for hashing and want embed >>> the igvm file in the UKI. >> >> I don't really see how signing the IGVM file for secure boot helps anything. > > It doesn't help indeed. This comes f

Re: Note improvements to QAPI-generated manuals in ChangeLog/10.0?

2025-04-09 Thread Stefan Hajnoczi
On Wed, Apr 9, 2025 at 9:44 AM Markus Armbruster wrote: > > John improved looks and usabilibity of the QAPI-generated manuals quite > a bit. These are > > QEMU QMP Reference Manual > QEMU Storage Daemon QMP Reference Manual > QEMU Guest Agent Protocol Reference > > Where should it go?

Re: [PATCH-for-10.1 v3 6/9] qtest/bios-tables-test: Whitelist aarch64/virt 'its_off' variant blobs

2025-04-09 Thread Igor Mammedov
On Fri, 4 Apr 2025 00:01:22 -0300 Gustavo Romero wrote: > Hi Phil, > > On 4/3/25 17:40, Philippe Mathieu-Daudé wrote: > > We are going to fix the test_acpi_aarch64_virt_tcg_its_off() > > test. In preparation, copy the ACPI tables which will be > > altered as 'its_off' variants, and whitelist the

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Steven Sistare
On 4/9/2025 9:34 AM, Markus Armbruster wrote: Steven Sistare writes: On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: Using qom-list and qom-get to get all the nodes and property values in a QOM tree can take multiple seconds

[PATCH for-10.1 v5 12/13] arm/cpu: Add sysreg generation scripts

2025-04-09 Thread Cornelia Huck
From: Eric Auger Introduce scripts that automate the generation of system register definitions from a given linux source tree arch/arm64/tools/sysreg. Invocation of ./update-aarch64-sysreg-code.sh $PATH_TO_LINUX_SOURCE_TREE in scripts directory generates target/arm/cpu-sysregs.h.inc containing d

[PATCH for-10.1 v5 08/13] arm/cpu: Store id_isar0-7 into the idregs array

2025-04-09 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 12 ++-- target/arm/cpu-features.h | 36 +- target/arm/cpu.c | 24 +++ target/arm/cpu.h | 7 --

[PATCH for-10.1 v5 13/13] arm/cpu: switch to a generated cpu-sysregs.h.inc

2025-04-09 Thread Cornelia Huck
Generated against Linux 6.14-rc1. Reviewed-by: Sebastian Ott Signed-off-by: Cornelia Huck --- target/arm/cpu-sysregs.h.inc | 43 +--- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/target/arm/cpu-sysregs.h.inc b/target/arm/cpu-sysregs.h.inc index

[PATCH 1/2] file-posix: probe discard alignment on Linux block devices

2025-04-09 Thread Stefan Hajnoczi
Populate the pdiscard_alignment block limit so the block layer is able align discard requests correctly. Signed-off-by: Stefan Hajnoczi --- block/file-posix.c | 56 +- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/block/file-posix.c b/b

[PATCH 2/2] block/io: skip head/tail requests on EINVAL

2025-04-09 Thread Stefan Hajnoczi
When guests send misaligned discard requests, the block layer breaks them up into a misaligned head, an aligned main body, and a misaligned tail. The file-posix block driver on Linux returns -EINVAL on misaligned discard requests. This causes bdrv_co_pdiscard() to fail and guests configured with w

[PULL 3/3] tests/tcg/plugins: add plugin to test reset and uninstall

2025-04-09 Thread Alex Bennée
From: Pierrick Bouvier We perform a plugin reset, uninstall, and make sure we went through those steps. Signed-off-by: Pierrick Bouvier Message-Id: <20250404032027.430575-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée diff --git a/tests/tcg/plugins/reset.c b/tests/tcg/plugins/reset

[PULL 2/3] plugins/loader: fix deadlock when resetting/uninstalling a plugin

2025-04-09 Thread Alex Bennée
From: Pierrick Bouvier Reported and fixed by Dmitry Kurakin. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2901 Signed-off-by: Pierrick Bouvier Message-Id: <20250404032027.430575-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a

[PULL for 10.0 0/3] final fixes (tcg tests, plugins)

2025-04-09 Thread Alex Bennée
The following changes since commit c302660920acf48425a1317d56122ea8af60fbc4: Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2025-04-08 09:59:33 -0400) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-10.0-final-fixes-090425-1 fo

[PULL 1/3] tests/tcg: fix semihosting SYS_EXIT for aarch64 in boot.S

2025-04-09 Thread Alex Bennée
We don't expect to hit exceptions in our testing so currently all the vectors report an un-expected exception and then attempt to exit. However for aarch64 we should always use the extended information block as we do in _exit. Rather than duplicate the code on the error handler just branch to the _

[PATCH for-10.1 v5 00/13] arm: rework id register storage

2025-04-09 Thread Cornelia Huck
Just a quick respin to fix a missed conversion in hvf.c. Also available at https://gitlab.com/cohuck/qemu/-/commits/arm-rework-idreg-storage-v5 Next iteration of the id register patches; only small changes. Changed from v3: - added R-bs (thanks!) - added missing SPDX header - merged patch intro

Re: [RFC PATCH v2 0/5] virtio-balloon: Working Set Reporting

2025-04-09 Thread Yuanchu Xie
On Mon, Apr 7, 2025 at 2:39 AM Michael S. Tsirkin wrote: > > On Thu, May 25, 2023 at 10:20:11PM +, T.J. Alumbaugh wrote: > > This is the device implementation for the proposed expanded balloon feature > > described here: > > > > https://lore.kernel.org/linux-mm/20230509185419.1088297-1-yuan...

Re: [PATCH 05/10] meson: Add wasm build in build scripts

2025-04-09 Thread Paolo Bonzini
On 4/9/25 12:55, Philippe Mathieu-Daudé wrote: Cc'ing Pierrick On 7/4/25 16:45, Kohei Tokunaga wrote: has_int128_type is set to false on emscripten as of now to avoid errors by libffi. What is the error here? How hard would it be to test for it? And tests aren't integrated with Wasm execut

Re: [PATCH 07/10] tcg: Add a TCG backend for WebAssembly

2025-04-09 Thread Kohei Tokunaga
> Eh TBH this is too much to review as a single patch. > > Do you already have an idea how different the wasm64 implementation can be? Sorry for the large patch. I'll split it into smaller patches in the next version of the series. With wasm64, instructions that manipulate pointers (e.g., ld/st,

[PATCH 00/14] vfio: preparation for vfio-user

2025-04-09 Thread John Levon
Hi, this series is based on Cédric Le Goater's vfio cleanup series: https://github.com/legoater/qemu/commits/vfio-10.1 The series contains patches to vfio to prepare for the vfio-user implementation. A previous version of these patches can be found at https://lore.kernel.org/all/7dd34008-e0f1-4eed

[PATCH 09/14] vfio: add vfio_device_get_irq_info() helper

2025-04-09 Thread John Levon
Add a helper similar to vfio_device_get_region_info() and use it everywhere. Replace a couple of needless allocations with stack variables. As a side-effect, this fixes a minor error reporting issue in the call from vfio_msix_early_setup(). Signed-off-by: John Levon --- hw/vfio/ap.c

[PATCH 03/14] vfio: add vfio_prepare_device()

2025-04-09 Thread John Levon
Commonize some initialization code shared by the legacy and iommufd vfio implementations. Signed-off-by: John Levon --- hw/vfio/container.c | 14 ++ hw/vfio/device.c | 14 ++ hw/vfio/iommufd.c | 9 + include/hw/vfio/vfio-device.

[PATCH 01/14] vfio: refactor out vfio_interrupt_setup()

2025-04-09 Thread John Levon
Refactor the interrupt setup code out of vfio_realize() for readability. Signed-off-by: John Levon --- hw/vfio/pci.c | 55 +++ 1 file changed, 34 insertions(+), 21 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 05a7a62204..02f23efab

[PATCH 06/14] vfio: add flags parameter to DMA unmap callback

2025-04-09 Thread John Levon
We'll use this parameter shortly; this just adds the plumbing. Signed-off-by: John Levon --- hw/vfio/container-base.c | 4 ++-- hw/vfio/container.c | 8 ++-- hw/vfio/iommufd.c | 6 +- hw/vfio/listener.c| 8 i

[PATCH 04/14] vfio: add vfio_attach_device_by_iommu_type()

2025-04-09 Thread John Levon
Allow attachment by explicitly passing a TYPE_VFIO_IOMMU_* string; vfio-user will use this later. Signed-off-by: John Levon --- hw/vfio/device.c | 24 include/hw/vfio/vfio-device.h | 3 +++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/hw/

[PATCH 08/14] vfio: add vfio-pci-base class

2025-04-09 Thread John Levon
Split out parts of TYPE_VFIO_PCI into a base TYPE_VFIO_PCI_BASE. The base type contains properties generic to all vfio-pci implementations (although we have not yet introduced another subclass). Note that currently there is no need for additional data for TYPE_VFIO_PCI, so it shares the same C str

[PATCH 13/14] vfio: add device IO ops vector

2025-04-09 Thread John Levon
For vfio-user, device operations such as IRQ handling and region read/writes are implemented in userspace over the control socket, not ioctl() or read()/write() to the vfio kernel driver; add an ops vector to generalize this, and implement vfio_device_io_ops_ioctl for interacting with the kernel vf

[PATCH 14/14] vfio/container: pass MemoryRegion to DMA operations

2025-04-09 Thread John Levon
Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later. Originally-by: John Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John Levon --- hw/vfio/container-base.c | 4 ++--

[PATCH 12/14] vfio: add region info cache

2025-04-09 Thread John Levon
Instead of requesting region information on demand with VFIO_DEVICE_GET_REGION_INFO, maintain a cache: this will become necessary for performance for vfio-user, where this call becomes a message over the control socket, so is of higher overhead than the traditional path. We will also need it to ge

[PATCH 05/14] vfio/container: pass listener_begin/commit callbacks

2025-04-09 Thread John Levon
The vfio-user container will later need to hook into these callbacks; set up vfio to use them, and optionally pass them through to the container. Signed-off-by: John Levon --- hw/vfio/listener.c| 28 +++ include/hw/vfio/vfio-container-base.h | 2 ++ 2

[PATCH 11/14] vfio: add vfio_pci_config_space_read/write()

2025-04-09 Thread John Levon
Add these helpers that access config space and return an -errno style return. Signed-off-by: John Levon --- hw/vfio/pci.c | 134 ++ 1 file changed, 91 insertions(+), 43 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index ddeee33aa9..c384

[PATCH 10/14] vfio: consistently handle return value for helpers

2025-04-09 Thread John Levon
Various bits of code that call vfio device APIs should consistently use the "return -errno" approach for passing errors back, rather than presuming errno is (still) set correctly. Signed-off-by: John Levon --- hw/vfio/pci.c | 30 +- 1 file changed, 17 insertions(+), 1

[PATCH for-10.1 v5 10/13] arm/cpu: Store id_dfr0/1 into the idregs array

2025-04-09 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 2 +- target/arm/cpu-features.h | 16 target/arm/cpu.c | 13 + target/arm/cpu.h |

[PATCH for-10.1 v5 04/13] arm/cpu: Store aa64pfr0/1 into the idregs array

2025-04-09 Thread Cornelia Huck
From: Eric Auger Reviewed-by: Richard Henderson Reviewed-by: Sebastian Ott Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 40 - target/arm/cpu.c | 29 target/arm/cpu.h | 2 --

Re: [PATCH 0/1] hw/nvme: create parameter to enable/disable cmic on subsystem

2025-04-09 Thread Klaus Jensen
On Apr 8 15:56, Alan Adamson wrote: > While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Linux was > incorrectly displaying atomic_write_max_bytes > # cat /sys/block/nvme0n1/queue/atomic_write_max_bytes > 0 > # nvme id-ctrl /dev/nvme0n1 | grep awupf > awupf : 15 > # > Since AWUPF w

Re: [PATCH v6 2/4] virtio_net: Add the check for vdpa's mac address

2025-04-09 Thread Cindy Lu
On Tue, Apr 8, 2025 at 2:46 PM Jason Wang wrote: > > On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote: > > > > When using a VDPA device, it is important to ensure that the MAC > > address is correctly set. The MAC address in the hardware should > > match the MAC address from the QEMU command line. T

Re: [PATCH v4 03/13] memory: Unify the definiton of ReplayRamPopulate() and ReplayRamDiscard()

2025-04-09 Thread Chenyi Qiang
On 4/9/2025 1:43 PM, Alexey Kardashevskiy wrote: > > > On 7/4/25 17:49, Chenyi Qiang wrote: >> Update ReplayRamDiscard() function to return the result and unify the >> ReplayRamPopulate() and ReplayRamDiscard() to ReplayStateChange() at >> the same time due to their identical definitions. This

Re: [PATCH v6 4/4] virtio_net: Add third acceptable configuration for MAC setup.

2025-04-09 Thread Cindy Lu
On Tue, Apr 8, 2025 at 2:48 PM Jason Wang wrote: > > On Tue, Apr 8, 2025 at 2:14 PM Cindy Lu wrote: > > > > For VDPA devices, Allow configurations where both the hardware MAC address > > and QEMU command line MAC address are zero. > > > > Let's explain why this can work. > > Thanks > Sure, will d

Re: [PATCH v4 01/13] memory: Export a helper to get intersection of a MemoryRegionSection with a given range

2025-04-09 Thread Chenyi Qiang
On 4/9/2025 2:45 PM, Alexey Kardashevskiy wrote: > > > On 9/4/25 16:26, Chenyi Qiang wrote: >> >> >> On 4/9/2025 10:47 AM, Alexey Kardashevskiy wrote: >>> >>> On 7/4/25 17:49, Chenyi Qiang wrote: Rename the helper to memory_region_section_intersect_range() to make it more generic. Me

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster
Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes and property values in a > QOM tree can take multiple seconds because it requires 1000's of individual > QOM requests. Some managers fetch the entire tree or a large subset > of

Re: [PATCH v6 1/4] vhost_vdpa : Add a new parameter to enable check mac address

2025-04-09 Thread Cindy Lu
On Tue, Apr 8, 2025 at 2:38 PM Jason Wang wrote: > > On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote: > > > > When using a VDPA device, it's important to ensure that the MAC > > address is correctly set. > > Add a new parameter in qemu cmdline to enable this check, default value > > is false > > >

  1   2   >