Re: [PATCH-for-10.1 6/8] target/mips: Introduce mips_cpu_is_64bit() helper

2025-03-27 Thread Philippe Mathieu-Daudé
On 26/3/25 19:22, Richard Henderson wrote: On 3/25/25 10:40, Philippe Mathieu-Daudé wrote: mips_cpu_is_64bit() returns whether the CPU is a 32-bit or a 64-bit one. Signed-off-by: Philippe Mathieu-Daudé ---   target/mips/cpu-qom.h | 2 ++   target/mips/cpu.c | 6 ++   2 files changed, 8 i

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-03-27 Thread Marco Cavenati
Hello Fabiano, First of all thanks a lot for the quick follow up to my issue! I just want to point out that with only mapped-ram enabled (without multifd) savevm/loadvm do not lead to a crash but just to an error according to my (few) experiments (on upstream). Ciao Marco On Thursday, March 27

Re: [PATCH v2 0/5] target/riscv: Smepmp fixes to match specification

2025-03-27 Thread Loïc Lefort
Ping On Thu, Mar 13, 2025 at 8:30 PM Loïc Lefort wrote: > These patches fix Smepmp implementation to make it compliant with the spec. > > First patch limits RLB to CSR changes since RLB should not affect privilege > evaluation. Patch 2 extracts some common code into a function (to be used > in >

RE: [PATCH for-10.1 v2 09/37] vfio: Move VFIOHostDMAWindow definition into spapr.c

2025-03-27 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: [PATCH for-10.1 v2 09/37] vfio: Move VFIOHostDMAWindow definition >into spapr.c > >VFIOHostDMAWindow is only used in file "spapr.c". Move it there. > >Reviewed-by: John Levon >Link: https://lore.kernel.org/qemu-devel/20250318095415.

Re: [PATCH v1 00/22] Fix incorrect hash results on AST2700

2025-03-27 Thread Cédric Le Goater
Hello Jamin On 3/21/25 10:25, Jamin Lin wrote: v1: 1. Added support for 64-bit DMA in the HACE model 2. Refactored the do_hash operation in the HACE model 3. Fixed a crash caused by out-of-bound memory access in HACE 4. Added more trace events and implemented dumping of source hash data

Re: [PATCH v1 2/2] block/nvme: Enable NVMe userspace driver for s390x

2025-03-27 Thread Farhan Ali
On 3/27/2025 12:26 PM, Stefan Hajnoczi wrote: On Wed, Mar 26, 2025 at 11:10:07AM -0700, Farhan Ali wrote: +static inline uint32_t nvme_mmio_read_32(const void *addr) +{ +uint32_t ret; + +#ifdef __s390x__ +ret = s390x_pci_mmio_read_32(addr); +#else +/* Prevent the compiler from opti

Re: [RFC v5 5/7] vhost: Forward descriptors to guest via packed vqs

2025-03-27 Thread Sahil Siddiq
Hi, On 3/26/25 2:04 PM, Eugenio Perez Martin wrote: On Mon, Mar 24, 2025 at 3:34 PM Sahil Siddiq wrote: Hi, I had a few more queries here as well. On 3/24/25 7:29 PM, Sahil Siddiq wrote: Detect when used descriptors are ready for consumption by the guest via packed virtqueues and forward t

Re: [PATCH v2 08/10] target/i386/kvm: reset AMD PMU registers during VM reset

2025-03-27 Thread ewanhai
Hi Zhao, Thank you for pointing out the potential impact on Zhaoxin CPUs! Hi Dongli, Zhaoxin (including vendor "__shanghai__" and "centaurhauls")'s PMU is compatible with Intel, so I have some advice for this patch. 在 2025/3/3 06:00, Dongli Zhang 写道: [snip] + +static bool is_same_vendor(CPUX8

Re: [RFC v5 3/7] vhost: Forward descriptors to device via packed SVQ

2025-03-27 Thread Eugenio Perez Martin
On Fri, Mar 28, 2025 at 6:10 AM Sahil Siddiq wrote: > > Hi, > > On 3/26/25 5:32 PM, Eugenio Perez Martin wrote: > > On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote: > >> > >> Implement the insertion of available buffers in the descriptor area of > >> packed shadow virtqueues. It takes into acc

Re: [RFC v5 1/7] vhost: Refactor vhost_svq_add_split

2025-03-27 Thread Sahil Siddiq
Hi, On 3/26/25 4:55 PM, Eugenio Perez Martin wrote: On Mon, Mar 24, 2025 at 2:59 PM Sahil Siddiq wrote: This commit refactors vhost_svq_add_split and vhost_svq_add to simplify their implementation and prepare for the addition of packed vqs in the following commits. Signed-off-by: Sahil Siddi

Re: [PATCH for-10.0] Revert "target/riscv/kvm: add missing KVM CSRs"

2025-03-27 Thread Alistair Francis
On Fri, Mar 28, 2025 at 1:22 AM Daniel Henrique Barboza wrote: > > This commit breaks KVM boot on older kernels, like reported in [1], due > to senvcfg not being available in them. > > There's also another problem related to scounteren. Using a recent > enough guest buildroot, 'ping' will be build

[PULL 3/3] Revert "target/riscv/kvm: add missing KVM CSRs"

2025-03-27 Thread Alistair Francis
From: Daniel Henrique Barboza This commit breaks KVM boot on older kernels, like reported in [1], due to senvcfg not being available in them. There's also another problem related to scounteren. Using a recent enough guest buildroot, 'ping' will be build with rdtime support. In this case, doing a

[PULL 2/3] docs/specs/riscv-iommu: Fixed broken link to external risv iommu document

2025-03-27 Thread Alistair Francis
From: "hemanshu.khilari.foss" The links to riscv iommu specification document are incorrect. This patch updates all the said link to point to correct location. Cc: qemu-sta...@nongnu.org Cc: qemu-ri...@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2808 Signed-off-by: hemansh

[PULL 1/3] docs: Added docs/specs/riscv-iommu.rst in MAINTAINERS file.

2025-03-27 Thread Alistair Francis
From: "hemanshu.khilari.foss" Added docs/specs/riscv-iommu.rst under `RISC-V TCG CPUs` section in in MAINTAINERS file since `scripts/get_maintainer.pl -f docs/specs/riscv-iommu.rst` doesn't list any maintainers. Signed-off-by: hemanshu.khilari.foss Reviewed-by: Alistair Francis Message-ID: <20

Re: [RFC v5 3/7] vhost: Forward descriptors to device via packed SVQ

2025-03-27 Thread Sahil Siddiq
Hi, On 3/26/25 5:32 PM, Eugenio Perez Martin wrote: On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote: Implement the insertion of available buffers in the descriptor area of packed shadow virtqueues. It takes into account descriptor chains, but does not consider indirect descriptors. Enable

Re: [RFC v5 6/7] vhost: Validate transport device features for packed vqs

2025-03-27 Thread Sahil Siddiq
Hi, On 3/26/25 5:36 PM, Eugenio Perez Martin wrote: On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote: Validate transport device features required for utilizing packed SVQ that both guests can use with the SVQ and SVQs can use with vdpa. Signed-off-by: Sahil Siddiq --- Changes from v4 -> v

Re: [PATCH for-10.0] Revert "target/riscv/kvm: add missing KVM CSRs"

2025-03-27 Thread Alistair Francis
On Fri, Mar 28, 2025 at 1:22 AM Daniel Henrique Barboza wrote: > > This commit breaks KVM boot on older kernels, like reported in [1], due > to senvcfg not being available in them. > > There's also another problem related to scounteren. Using a recent > enough guest buildroot, 'ping' will be build

[PATCH v7 1/7] ppc/pnv: Introduce Pnv11Chip

2025-03-27 Thread Aditya Gupta
Implement Pnv11Chip, currently without chiptod, xive and phb. Chiptod, XIVE, PHB are implemented in later patches. Since Power11 core is same as Power10, the implementation of Pnv11Chip is a duplicate of corresponding Pnv10Chip. Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivas

[PATCH v7 2/7] ppc/pnv: Introduce Power11 PowerNV machine

2025-03-27 Thread Aditya Gupta
The Powernv11 machine doesn't have XIVE & PHBs as of now XIVE2 interface and PHB5 added in later patches to Powernv11 machine Also add mention of Power11 to powernv documentation Note: A difference from P10's and P11's machine_class_init is, in P11 different number of PHBs cannot be used on the

[PATCH v7 5/7] ppc/pnv: Add ChipTOD model for Power11

2025-03-27 Thread Aditya Gupta
Introduce Power11 ChipTod. The code has been copied from Power10 ChipTod code as the Power11 core is same as Power10 core. Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya Gupta --- hw/ppc/pnv.c

[PATCH v7 6/7] tests/powernv: Switch to buildroot images instead of op-build

2025-03-27 Thread Aditya Gupta
As op-build images haven't been updated from long time (and may not get updated in future), use buildroot images provided by cedric [1]. Use existing nvme device being used in the test to mount the initrd. Also replace the check for "zImage loaded message" to skiboot's message when it starts the

[PATCH v7 4/7] ppc/pnv: Add PHB5 PCIe Host bridge to Power11

2025-03-27 Thread Aditya Gupta
Power11 also uses PHB5, same as Power10. Add Power11 PHBs with similar code as the corresponding Power10 implementation. Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Cédric Le Goater Signed-off-by: Aditya Gupta --- hw/ppc/pnv.c | 57 +

[PATCH v7 3/7] ppc/pnv: Add XIVE2 controller to Power11

2025-03-27 Thread Aditya Gupta
Add a XIVE2 controller to Power11 chip and machine. The controller has the same logic as Power10. Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Cédric Le Goater Signed-off-by: Aditya Gupta --- hw/ppc/pnv.c | 133

Re: [PATCH-for-10.0 10/12] hw/rtc: Categorize and add description

2025-03-27 Thread Bernhard Beschow
Am 25. März 2025 22:43:08 UTC schrieb "Philippe Mathieu-Daudé" : >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/rtc/ds1338.c | 2 ++ > hw/rtc/m41t80.c | 2 ++ > hw/rtc/rs5c372.c | 2 ++ For rs5c372: Acked-by: Bernhard Beschow > 3 files changed, 6 insertions(+) > >diff --git a/hw/rtc/ds1338

Re: [PATCH 12/15] fuse: Reduce max read size

2025-03-27 Thread Stefan Hajnoczi
On Tue, Mar 25, 2025 at 05:06:52PM +0100, Hanna Czenczek wrote: > We are going to introduce parallel processing via coroutines, a maximum > read size of 64 MB may be problematic, allowing users of the export to > force us to allocate quite large amounts of memory with just a few > requests. > > At

Re: [PATCH v8 0/7] Allow to enable multifd and postcopy migration together

2025-03-27 Thread Fabiano Rosas
Prasad Pandit writes: > Hello Fabiano, > > On Tue, 18 Mar 2025 at 18:10, Prasad Pandit wrote: >> * This series (v8) splits earlier patch-2 which enabled multifd and >> postcopy options together into two separate patches. One modifies >> the channel discovery in migration_ioc_process_incoming

Re: [PATCH 1/4] migration/savevm: Add a compatibility check for capabilities

2025-03-27 Thread Daniel P . Berrangé
On Thu, Mar 27, 2025 at 11:39:31AM -0300, Fabiano Rosas wrote: > It has always been possible to enable arbitrary migration capabilities > and attempt to take a snapshot of the VM with the savevm/loadvm > commands as well as their QMP counterparts > snapshot-save/snapshot-load. > > Most migration c

[PULL 0/1] Migration patches for 2025-03-27

2025-03-27 Thread Fabiano Rosas
The following changes since commit b876e721f1c939f3e83ac85bd3c1c2821e12b3fa: Update version for v10.0.0-rc1 release (2025-03-25 13:58:14 -0400) are available in the Git repository at: https://gitlab.com/farosas/qemu.git tags/migration-20250327-pull-request for you to fetch changes up to

[PULL 1/1] migration: Avoid SNP guest crash due to duplicate cpr blocker

2025-03-27 Thread Fabiano Rosas
From: Steve Sistare With aux-ram-share=off, booting an SNP guest fails with: ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. This is because a CPR blocker for the guest_memfd ramblock is added twice, once in ram_block_add_cpr_blocker because aux-ram-share=off so rb->fd < 0,

RE: [PATCH for-10.1 v2 14/37] vfio: Move VFIOAddressSpace helpers into container-base.c

2025-03-27 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: [PATCH for-10.1 v2 14/37] vfio: Move VFIOAddressSpace helpers into >container-base.c > >VFIOAddressSpace is a common object used by VFIOContainerBase which is >declared in "hw/vfio/vfio-container-base.h". Move the VFIOAddressSpace >r

Re: [PATCH] hw/pci-host/gt64120.c: Fix PCI host bridge endianness handling

2025-03-27 Thread BALATON Zoltan
On Thu, 27 Mar 2025, rakeshj wrote: The GT-64120 PCI controller requires special handling where: 1. Host bridge (device 0) must use native endianness 2. Other devices follow MByteSwap bit in GT_PCI0_CMD Previous implementation accidentally swapped all accesses, breaking host bridge detection (ls

Re: [PATCH v1 1/2] util: Add functions for s390x mmio read/write

2025-03-27 Thread Farhan Ali
On 3/27/2025 12:20 PM, Stefan Hajnoczi wrote: On Wed, Mar 26, 2025 at 11:10:06AM -0700, Farhan Ali wrote: Starting with z15 (or newer) we can execute mmio instructions from userspace. On older platforms where we don't have these instructions available we can fallback to using system calls to a

Re: [RFC v5 2/7] vhost: Data structure changes to support packed vqs

2025-03-27 Thread Sahil Siddiq
Hi, On 3/26/25 4:56 PM, Eugenio Perez Martin wrote: On Mon, Mar 24, 2025 at 3:00 PM Sahil Siddiq wrote: Introduce "struct vring_packed". Modify VhostShadowVirtqueue so it can support split and packed virtqueue formats. Signed-off-by: Sahil Siddiq --- Changes from v4 -> v5: - This was commi

Re: [RFC PATCH v2 17/20] hw/arm/smmuv3: Check idr registers for STE_S1CDMAX and STE_S1STALLD

2025-03-27 Thread Eric Auger
Hi, On 3/27/25 8:54 AM, Shameerali Kolothum Thodi wrote: > >> -Original Message- >> From: Nicolin Chen >> Sent: Wednesday, March 26, 2025 7:47 PM >> To: Eric Auger >> Cc: Shameerali Kolothum Thodi >> ; qemu-...@nongnu.org; >> qemu-devel@nongnu.org; peter.mayd...@linaro.org; j...@nvidia.c

Re: [PATCH v2 2/4] docs, qapi: generate undocumented return sections

2025-03-27 Thread Markus Armbruster
John Snow writes: > This patch changes the qapidoc transmogrifier to generate Return value > documentation for any command that has a return value but hasn't > explicitly documented that return value. > > Signed-off-by: John Snow Might want to briefly explain placement of the auto-generated ret

Re: [PATCH v2 1/2] qcow2: handle discard-no-unref in measure

2025-03-27 Thread Jean-Louis Dupond
Any chance this can get reviewed and perhaps merged? We would like to enable discard-no-unref by default on oVirt, as this makes qcow2 inside LVM LV's way more reliable (because we can calculate the size). But we are still missing this measure patch to be able to properly calculate the destina

Re: [PATCH] qtest/migration/rdma: Add test for rdma migration with ipv6

2025-03-27 Thread Jinpu Wang
On Thu, Mar 27, 2025 at 3:13 AM Li Zhijian wrote: > > Recently, we removed ipv6 restriction[0] from RDMA migration, add a > test for it. > > [0] > https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/ > > Cc: Jack Wang > Cc: Michael R. Galaxy > Cc: Peter Xu > Cc: Yu Zh

Re: [PATCH for-10.1 v2 06/37] vfio: Introduce a new header file for internal migration services

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:50:51AM +0100, Cédric Le Goater wrote: > Gather all VFIO migration related declarations into > "vfio-migration-internal.h" to reduce exposure of VFIO internals in > "hw/vfio/vfio-common.h". > > Cc: Kirti Wankhede > Cc: Avihai Horon > Signed-off-by: Cédric Le Goater

Re: [PATCH for-10.1 v2 14/37] vfio: Move VFIOAddressSpace helpers into container-base.c

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:50:59AM +0100, Cédric Le Goater wrote: > VFIOAddressSpace is a common object used by VFIOContainerBase which is > declared in "hw/vfio/vfio-container-base.h". Move the VFIOAddressSpace > related services into "container-base.c". > > While at it, rename : > > vfio_get

Re: [PATCH for-10.1 v2 32/37] vfio: Introduce new files for VFIO MemoryListener

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:51:17AM +0100, Cédric Le Goater wrote: > File "common.c" has been emptied of most of its definitions by the > previous changes and the only definitions left are related to the VFIO > MemoryListener handlers. Rename it to "listener.c" and introduce its > associated "vfio-

Re: [PATCH for-10.1 v2 29/37] vfio: Rename vfio_devices_all_dirty_tracking_started()

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:51:14AM +0100, Cédric Le Goater wrote: > Also rename vfio_devices_all_device_dirty_tracking_started() while at > it and use the prefix 'vfio_container_devices_' for routines simply > looping over the container's device list. > > Signed-off-by: Cédric Le Goater Reviewe

[PATCH] hw/net/virtio-net: fix memory leak in timer_del()

2025-03-27 Thread Zheng Huang
Hi, This patch addresses a memory leak bug in the usages of `timer_del()`. The issue arisesfrom the incorrect use of the ambiguous timer API `timer_del()`, which does not free the timer object. The leak sanitizer report this issue during fuzzing. The correct API `timer_free()` freed the timer obje

RE: [PATCH for-10.1 v2 16/37] vfio: Introduce a new header file for helper services

2025-03-27 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: [PATCH for-10.1 v2 16/37] vfio: Introduce a new header file for helper >services > >Gather all helper routine declarations into "vfio-helpers.h" to reduce >exposure of VFIO internals in "hw/vfio/vfio-common.h". > >Reviewed-by: John L

Re: [PATCH for-10.1 v2 36/37] vfio: Rename VFIODevice related services

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:51:21AM +0100, Cédric Le Goater wrote: > /* Returns 0 on success, or a negative errno. */ > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index > 4fdb74e33c427595a9b0a4d28b2b5a70df951e4e..9000702aed960ccb69ca67ec052f1ebe11ee1919 > 100644 > --- a/hw/vfio/ap.c > +++ b/hw/v

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-27 Thread Ani Sinha
On Wed, Mar 26, 2025 at 8:52 PM Alexander Graf wrote: > > > On 26.03.25 13:27, Gerd Hoffman wrote: > >Hi, > > > >> The problem is that add-ons are > >> > >>1) Separate binaries. So you need to match multiple files. > >>2) In this case, get generated out of the vendor (RH)'s control in

Re: [PATCH for-10.1 v2 07/37] vfio: Move vfio_device_state_is_running/precopy() into migration.c

2025-03-27 Thread Prasad Pandit
On Wed, 26 Mar 2025 at 13:22, Cédric Le Goater wrote: > These routines are migration related. Move their declaration and > implementation under the migration files. > > Signed-off-by: Cédric Le Goater > --- > hw/vfio/vfio-migration-internal.h | 2 ++ > include/hw/vfio/vfio-common.h | 3 ---

Re: [PATCH for-10.1 v2 03/37] vfio: Introduce a new header file for external migration services

2025-03-27 Thread Prasad Pandit
On Wed, 26 Mar 2025 at 13:24, Cédric Le Goater wrote: > The migration core subsystem makes use of the VFIO migration API to > collect statistics on the number of bytes transferred. These services > are declared in "hw/vfio/vfio-common.h" which also contains VFIO > internal declarations. Move the m

Re: [PATCH 14/15] fuse: Implement multi-threading

2025-03-27 Thread Markus Armbruster via
Hanna Czenczek writes: > On 26.03.25 12:41, Markus Armbruster wrote: >> Hanna Czenczek writes: >> >>> On 26.03.25 06:38, Markus Armbruster wrote: Hanna Czenczek writes: > FUSE allows creating multiple request queues by "cloning" /dev/fuse FDs > (via open("/dev/fuse") + ioctl(F

[PATCH] hw/timer/hpet: fix memory leak in hpet_del_timer()

2025-03-27 Thread Zheng Huang
Hi, This patch addresses a memory leak bug in the function `hpet_del_timer()`. The issue arisesfrom the incorrect use of the ambiguous timer API `timer_del()`, which does not free the timer object. The leak sanitizer report this issue during fuzzing. The correct API, `timer_free()`, was introduce

Re: [PATCH-for-10.0 1/1] goldfish_rtc: keep time offset when resetting

2025-03-27 Thread Philippe Mathieu-Daudé
Hi Heinrich, On 21/3/25 09:12, Heinrich Schuchardt wrote: Currently resetting leads to resynchronizing the Goldfish RTC with the system clock of the host. In real hardware an RTC reset would not change the wall time. Other RTCs like pl031 do not show this behavior. Move the synchronization of t

[PATCH] hw/net/virtio-net: fix memory leak in timer_del()

2025-03-27 Thread Zheng Huang
Hi, This patch addresses a memory leak bug in the usages of `timer_del()`. The issue arisesfrom the incorrect use of the ambiguous timer API `timer_del()`, which does not free the timer object. The leak sanitizer report this issue during fuzzing. The correct API `timer_free()` freed the timer obje

Re: [PULL 2/8] migration: ram block cpr blockers

2025-03-27 Thread Steven Sistare
On 3/26/2025 5:34 PM, Michael Roth wrote: On Wed, Mar 26, 2025 at 05:13:50PM -0300, Fabiano Rosas wrote: Michael Roth writes: Quoting Tom Lendacky (2025-03-26 14:21:31) On 3/26/25 13:46, Tom Lendacky wrote: On 3/7/25 12:15, Fabiano Rosas wrote: From: Steve Sistare Unlike cpr-reboot mode,

Re: [PATCH for-10.1 v2 06/37] vfio: Introduce a new header file for internal migration services

2025-03-27 Thread Prasad Pandit
On Wed, 26 Mar 2025 at 13:32, Cédric Le Goater wrote: > Gather all VFIO migration related declarations into > "vfio-migration-internal.h" to reduce exposure of VFIO internals in > "hw/vfio/vfio-common.h". > > Cc: Kirti Wankhede > Cc: Avihai Horon > Signed-off-by: Cédric Le Goater > --- > hw/vf

Re: [PATCH v2] 9pfs: fix 'total_open_fd' decrementation

2025-03-27 Thread Christian Schoenebeck
On Thursday, March 20, 2025 1:16:20 PM CET Christian Schoenebeck wrote: > According to 'man 2 close' errors returned by close() should only be used > for either diagnostic purposes or for catching data loss due to a previous > write error, as an error result of close() usually indicates a deferred

[PATCH V1] migration: cpr breaks SNP guest

2025-03-27 Thread Steve Sistare
With aux-ram-share=off, booting an SNP guest fails with: ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. This is because a CPR blocker for the guest_memfd ramblock is added twice, once in ram_block_add_cpr_blocker because aux-ram-share=off so rb->fd < 0, and once in ram_block_

[PATCH] hw/net/e1000: fix memory leak in timer_del()

2025-03-27 Thread Zheng Huang
Hi, This patch addresses a memory leak bug in the usages of `timer_del()`. The issue arisesfrom the incorrect use of the ambiguous timer API `timer_del()`, which does not free the timer object. The leak sanitizer report this issue during fuzzing. The correct API `timer_free()` freed the timer obje

RE: [PATCH for-10.1 v2 20/37] vfio: Introduce a new file for VFIODevice definitions

2025-03-27 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: [PATCH for-10.1 v2 20/37] vfio: Introduce a new file for VFIODevice >definitions > >Move all VFIODevice related routines of "helpers.c" into a new "device.c" >file. > >Signed-off-by: Cédric Le Goater Reviewed-by: Zhenzhong Duan Th

Re: [PATCH for-10.1 v2 30/37] vfio: Rename vfio_devices_all_device_dirty_tracking()

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:51:15AM +0100, Cédric Le Goater wrote: > Use the prefix 'vfio_container_devices_' to reflect the routine simply > loops over the container's device list. > > Signed-off-by: Cédric Le Goater Reviewed-by: John Levon regards john

Re: Questions about vfio-pci

2025-03-27 Thread yangjinqian via
> > Hello Jinqian > > On 3/25/25 09:00, yangjinqian via wrote: > > Hi, > > > > I'm observing intermittent failures when enabling the HNS3 network > > port in VM using > > > > QEMU with the mainline kernel. > > > Would you mind opening a gitlab issue with more details on the context, host, > gue

[PATCH for-10.1] hw/riscv: do not mark any machine as default

2025-03-27 Thread Daniel Henrique Barboza
Commit 5b4beba124 ("RISC-V Spike Machines") added the Spike machine and made it default for qemu-system-riscv32/64. It was the first RISC-V machine added in QEMU so setting it as default was sensible. Today we have 7 risc64 and 6 riscv32 machines and having 'spike' as default machine is not intuit

Re: [RFC PATCH v2 17/20] hw/arm/smmuv3: Check idr registers for STE_S1CDMAX and STE_S1STALLD

2025-03-27 Thread Jason Gunthorpe
On Wed, Mar 26, 2025 at 06:18:49PM +0100, Eric Auger wrote: > Again I think we need to understand the consequence of having a more > comprehensive support of SSID. This also holds with old the IDR fields > that may be inherited from the HW and we don't support yet in the > emulation code To be ver

Re: [PATCH qemu 1/1] Add IOURING_SETUP_SINGLE_ISSUER flag to improve iouring performance

2025-03-27 Thread Kevin Wolf
Am 26.03.2025 um 18:46 hat Stefan Hajnoczi geschrieben: > On Wed, Mar 26, 2025 at 06:13:44PM +0100, Kevin Wolf wrote: > > Am 25.03.2025 um 21:49 hat ~h0lyalg0rithm geschrieben: > > > From: Suraj Shirvankar > > > > > > Signed-off-by: Suraj Shirvankar > > > --- > > > util/fdmon-io_uring.c | 8 +++

Re: [PATCH v3 2/2] qapi/throttle: add timeout parameter for qmp_block_set_io_throttle()

2025-03-27 Thread zoudongjie via
On Thu, 27 Mar 2025 09:04:51 +0100, Markus wrote: > zoudongjie writes: > > > On Wed, Mar 26, 2025 at 10:53:20 +0100, Markus wrote: > >> zoudongjie via writes: > >> > >> > From: Zhu Yangyang > >> > > >> > Calling qmp_block_set_io_throttle() will be blocked for a long time > >> > when a network

Re: [PATCH v1 1/1] hw/i2c/aspeed: Fix wrong I2CC_DMA_LEN when I2CM_DMA_TX/RX_ADDR set first

2025-03-27 Thread Cédric Le Goater
Hello Jamin On 3/27/25 08:44, Jamin Lin wrote: In the previous design, the I2C model would update I2CC_DMA_LEN (0x54) based on the value of I2CM_DMA_LEN (0x1C) when the firmware set either I2CM_DMA_TX_ADDR (0x30) or I2CM_DMA_RX_ADDR (0x34). However, this only worked correctly if the firmware set

Re: [RFC PATCH] migration/rdma: Remove qemu_rdma_broken_ipv6_kernel

2025-03-27 Thread Jinpu Wang
Hi Zhijian, On Thu, Mar 27, 2025 at 2:18 AM Zhijian Li (Fujitsu) wrote: > > > Please fix this compiling error. > > > cc -m64 -mcx16 -Ilibcommon.a.p -Isubprojects/libvduse > -I../subprojects/libvduse -I/usr/include/p11-kit-1 -I/usr/include/pixman-1 > -I/usr/include/libpng16 -I/usr/include/spice-

Re: [PATCH for-10.1 v2 07/37] vfio: Move vfio_device_state_is_running/precopy() into migration.c

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:50:52AM +0100, Cédric Le Goater wrote: > These routines are migration related. Move their declaration and > implementation under the migration files. > > Signed-off-by: Cédric Le Goater Reviewed-by: John Levon regards john

RE: [PATCH for-10.1 v2 10/37] vfio: Introduce a new header file for VFIOIOMMUFD declarations

2025-03-27 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Subject: [PATCH for-10.1 v2 10/37] vfio: Introduce a new header file for >VFIOIOMMUFD declarations > >Gather all VFIOIOMMUFD related declarations introduced by commits >5ee3dc7af785 ("vfio/iommufd: Implement the iommufd backend") and >5b1e96e

Re: [PATCH for-10.1 v2 34/37] vfio: Introduce vfio_listener_un/register() routines

2025-03-27 Thread John Levon
On Wed, Mar 26, 2025 at 08:51:19AM +0100, Cédric Le Goater wrote: > This hides the MemoryListener implementation and makes the code common > to both IOMMU backends, legacy and IOMMUFD. > > Signed-off-by: Cédric Le Goater Reviewed-by: John Levon regards john

Re: [PATCH] hw/net/e1000: fix memory leak in timer_del()

2025-03-27 Thread Prasad Pandit
Hello, On Thu, 27 Mar 2025 at 16:59, Zheng Huang wrote: > This patch addresses a memory leak bug in the usages of `timer_del()`. > The issue arisesfrom the incorrect use of the ambiguous timer API > `timer_del()`, which does not free the timer object. The leak sanitizer > report this issue during

Re: [PATCH] hw/net/virtio-net: fix memory leak in timer_del()

2025-03-27 Thread Prasad Pandit
On Thu, 27 Mar 2025 at 16:15, Zheng Huang wrote: > +++ b/hw/net/virtio-net.c > @@ -422,7 +422,7 @@ static void virtio_net_set_status(struct VirtIODevice > *vdev, uint8_t status) > } > } else { > if (q->tx_timer) { > -timer_del(q->tx_timer); > +

Re: [PATCH v3 2/2] qapi/throttle: add timeout parameter for qmp_block_set_io_throttle()

2025-03-27 Thread Markus Armbruster
zoudongjie writes: > On Thu, 27 Mar 2025 09:04:51 +0100, Markus wrote: >> zoudongjie writes: >> >> > On Wed, Mar 26, 2025 at 10:53:20 +0100, Markus wrote: >> >> zoudongjie via writes: >> >> >> >> > From: Zhu Yangyang >> >> > >> >> > Calling qmp_block_set_io_throttle() will be blocked for a l

Re: [PULL 2/8] migration: ram block cpr blockers

2025-03-27 Thread Tom Lendacky
On 3/27/25 07:27, Steven Sistare wrote: > On 3/26/2025 5:34 PM, Michael Roth wrote: >> On Wed, Mar 26, 2025 at 05:13:50PM -0300, Fabiano Rosas wrote: >>> Michael Roth writes: Quoting Tom Lendacky (2025-03-26 14:21:31) > On 3/26/25 13:46, Tom Lendacky wrote: >> On 3/7/25 12:15, Fabiano

Re: [PATCH for-10.1] hw/riscv: do not mark any machine as default

2025-03-27 Thread Frank Chang
Reviewed-by: Frank Chang Daniel Henrique Barboza 於 2025年3月27日 週四 下午9:04寫道: > > Commit 5b4beba124 ("RISC-V Spike Machines") added the Spike machine and > made it default for qemu-system-riscv32/64. It was the first RISC-V > machine added in QEMU so setting it as default was sensible. > > Today we

Re: [PATCH V1] migration: cpr breaks SNP guest

2025-03-27 Thread Tom Lendacky
On 3/27/25 08:36, Steve Sistare wrote: > With aux-ram-share=off, booting an SNP guest fails with: > > ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. > > This is because a CPR blocker for the guest_memfd ramblock is added > twice, once in ram_block_add_cpr_blocker because aux-

Re: [PATCH 14/15] fuse: Implement multi-threading

2025-03-27 Thread Hanna Czenczek
On 27.03.25 13:18, Markus Armbruster wrote: Hanna Czenczek writes: On 26.03.25 12:41, Markus Armbruster wrote: Hanna Czenczek writes: On 26.03.25 06:38, Markus Armbruster wrote: Hanna Czenczek writes: FUSE allows creating multiple request queues by "cloning" /dev/fuse FDs (via open("/d

Re: [PATCH V1] migration: cpr breaks SNP guest

2025-03-27 Thread Fabiano Rosas
Steve Sistare writes: > With aux-ram-share=off, booting an SNP guest fails with: > > ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. > > This is because a CPR blocker for the guest_memfd ramblock is added > twice, once in ram_block_add_cpr_blocker because aux-ram-share=off so

<    1   2