On 3/27/25 07:27, Steven Sistare wrote:
> On 3/26/2025 5:34 PM, Michael Roth wrote:
>> On Wed, Mar 26, 2025 at 05:13:50PM -0300, Fabiano Rosas wrote:
>>> Michael Roth <michael.r...@amd.com> writes:
>>>> Quoting Tom Lendacky (2025-03-26 14:21:31)
>>>>> On 3/26/25 13:46, Tom Lendacky wrote:
>>>>>> On 3/7/25 12:15, Fabiano Rosas wrote:
>>>>>>> From: Steve Sistare <steven.sist...@oracle.com>

> 
> Thanks everyone for debugging this.  To summarize,
> ram_block_add_cpr_blocker already blocks
> guest_memfd, because rb->fd < 0.  The fix is to delete this redundant
> code in ram_block_add:
> 
>         error_setg(&new_block->cpr_blocker,
>                    "Memory region %s uses guest_memfd, "
>                    "which is not supported with CPR.",
>                    memory_region_name(new_block->mr));
>         migrate_add_blocker_modes(&new_block->cpr_blocker, errp,
>                                   MIG_MODE_CPR_TRANSFER, MIG_MODE_CPR_EXEC,
>                                   -1);
> 
> I will submit a fix (unless Tom or Michael would prefer to author it).

Steve, please do submit the fix. Thanks!

Tom

> 
> - Steve

Reply via email to