Re: [PATCH] ppc/spapr: fix default cpu for pre-10.0 machines.

2025-03-13 Thread Harsh Prateek Bora
On 3/13/25 15:02, Daniel P. Berrangé wrote: On Wed, Mar 12, 2025 at 11:28:04AM +0530, Harsh Prateek Bora wrote: When POWER10 CPU was made as default, we missed keeping POWER9 as default for older pseries releases (pre-10.0) at that time. This caused breakge in default cpu evaluation for older

RE: [RFC PATCH v2 05/20] hw/arm/smmuv3-accel: Associate a pxb-pcie bus

2025-03-13 Thread Shameerali Kolothum Thodi via
Hi Eric, > -Original Message- > From: Eric Auger > Sent: Wednesday, March 12, 2025 4:42 PM > To: Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath

[PULL 1/8] docs: Rename default-configs to configs

2025-03-13 Thread Thomas Huth
From: Greg Kurz This was missed at the time. Fixes: 812b31d3f91 ("configs: rename default-configs to configs and reorganise") Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20250306174113.427116-1-gr...@kaod.org> Signed-off-by: Thomas Huth --- docs/devel/build-syst

Re: [RFC PATCH 01/18] hw/xen/hvm: Fix Aarch64 typo

2025-03-13 Thread Michael Tokarev
05.03.2025 18:39, Philippe Mathieu-Daudé wrote: There is no TARGET_ARM_64 definition. Luckily enough, when TARGET_AARCH64 is defined, TARGET_ARM also is. Fixes: 733766cd373 ("hw/arm: introduce xenpvh machine") Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/arch_hvm.h | 2 +- 1 file

[PULL 0/8] Fixes for functional tests

2025-03-13 Thread Thomas Huth
The following changes since commit 825b96dbcee23d134b691fc75618b59c5f53da32: Merge tag 'migration-20250310-pull-request' of https://gitlab.com/farosas/qemu into staging (2025-03-11 09:32:07 +0800) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-20

RE: [RFC PATCH v2 04/20] hw/arm/virt: Add support for smmuv3-accel

2025-03-13 Thread Shameerali Kolothum Thodi via
Hi Eric, > -Original Message- > From: Eric Auger > Sent: Wednesday, March 12, 2025 6:31 PM > To: Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath

Re: [PATCH] vfio/igd: Update IGD passthrough docoumentation

2025-03-13 Thread Cédric Le Goater
Please fix in the Subject "documentation" On 3/12/25 16:50, Tomita Moeko wrote: A previous change made the OpRegion and LPC quirks independent of the exising legacy mode, update the docoumentation accordingly. More related existing documentation Thanks, C. topics

Re: [PATCH 1/2] Demo for integration coroutin into fuse export

2025-03-13 Thread Stefan Hajnoczi
On Wed, Mar 12, 2025 at 02:22:05PM +0800, saz97 wrote: The email subject says [PATCH 1/2] but I only see one patch email. The second patch is at the bottom of this email. Please send each patch in a separate email with email threading (this is what git-send-email(1) does by default) in the future.

Re: Broken NetBSD Orange Pi image URL in QEMU tests

2025-03-13 Thread Stefan Hajnoczi
On Thu, Mar 13, 2025 at 1:48 PM Thomas Huth wrote: > > On 13/03/2025 03.22, Stefan Hajnoczi wrote: > > Hi, > > CI jobs that run test_arm_orangepi.py are failing: > > https://gitlab.com/qemu-project/qemu/-/jobs/9390048284#L1138 > > > > Please consider how to resolve this so the CI job passes again.

Re: [PULL 09/72] ppc/pnv/occ: Fix common area sensor offsets

2025-03-13 Thread Michael Tokarev
11.03.2025 15:57, Nicholas Piggin wrote: The commit to fix the OCC common area sensor mappings didn't update the register offsets to match. Before this change, skiboot reports: [0.347100086,3] OCC: Chip 0 sensor data invalid Afterward, there is no error and the sensor_groups directory appe

[PULL 5/8] tests/functional/asset: Fail assert fetch when retries are exceeded

2025-03-13 Thread Thomas Huth
From: Nicholas Piggin Currently the fetch code does not fail gracefully when retry limit is exceeded, it just falls through the loop with no file, which ends up hitting other errors. Add a check for non-existing file, which indicates the retry limit was exceeded. Reviewed-by: Daniel P. Berrangé

[PATCH RFC v4 06/11] virtio-net: Add hash type options

2025-03-13 Thread Akihiko Odaki
By default, virtio-net limits the hash types that will be advertised to the guest so that all hash types are covered by the offloading capability the client provides. This change allows to override this behavior and to advertise hash types that require user-space hash calculation by specifying "on"

Re: Giving your own patches your Reviewed-by

2025-03-13 Thread Markus Armbruster
CLEMENT MATHIEU--DRIF writes: > On 12/03/2025 13:54, Yi Liu wrote: [...] >> Commit eda4c9b5b3c is the similar case. Zhenzhong and Clément took >> the patch from me and I was cced when Zhenzhong sent it out. I gave >> my r-b after reviewing it. > > Some other commits of the same series were in a

Re: [PULL SUBSYSTEM qemu-pnv] ppc/pnv: Update skiboot firmware image

2025-03-13 Thread Stefan Hajnoczi
On Thu, Mar 13, 2025 at 3:05 PM Stefan Hajnoczi wrote: > > Applied, thanks. This email was sent by mistake, please ignore. This pull request is for the ppc subsystem and I didn't merge it into qemu.git myself. Stefan

[PULL 8/8] tests/functional: skip vulkan test if missing vulkaninfo

2025-03-13 Thread Thomas Huth
From: Alex Bennée I could have sworn I had this is a previous iteration of the patches but I guess it got lost in a re-base. As we are going to call vulkaninfo to probe for "bad" drivers we need to skip if the binary isn't available. Fixes: 9f7e493d11 (tests/functional: skip vulkan tests with nV

[PULL 2/8] tests/functional: Require 'user' netdev for ppc64 e500 test

2025-03-13 Thread Thomas Huth
From: Cédric Le Goater When commit 72cdd672e18c extended the ppc64 e500 test to add network support, it forgot to require the 'user' netdev backend. Fix that. Fixes: 72cdd672e18c ("tests/functional: Replace the ppc64 e500 advent calendar test") Signed-off-by: Cédric Le Goater Reviewed-by: Thom

RE: [RFC PATCH v2 07/20] hw/arm/smmu-common: Introduce callbacks for PCIIOMMUOps

2025-03-13 Thread Shameerali Kolothum Thodi via
Hi Eric, > -Original Message- > From: Eric Auger > Sent: Wednesday, March 12, 2025 4:24 PM > To: Shameerali Kolothum Thodi > ; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; j...@nvidia.com; nicol...@nvidia.com; > ddut...@redhat.com; berra...@redhat.com; nath

Re: [PATCH] error: Strip trailing '\n' from an error string argument

2025-03-13 Thread gaosong
在 2025/3/12 下午10:35, Markus Armbruster 写道: Tracked down with scripts/coccinelle/err-bad-newline.cocci. Signed-off-by: Markus Armbruster --- net/vmnet-common.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Song Gao Thanks. Song Gao diff --git a/net/vmnet-common.m b/ne

Re: [PATCH 13/37] include/exec: Split out mmap-lock.h

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 04:44, Richard Henderson wrote: Split out mmap_lock, et al from page-protection.h to a new header. Signed-off-by: Richard Henderson --- accel/tcg/internal-target.h| 1 + include/exec/mmap-lock.h | 33 + What about include/accel/tcg/mmap-

Re: [PULL 00/21] vfio queue

2025-03-13 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 22/37] semihosting: Move user-only implementation out-of-line

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 04:45, Richard Henderson wrote: Avoid testing CONFIG_USER_ONLY in semihost.h. Signed-off-by: Richard Henderson --- include/semihosting/semihost.h | 29 ++--- semihosting/user.c | 30 ++ semihosting/meson.build

Re: [PATCH] target/arm: Define raw write for PMU CLR registers

2025-03-13 Thread Peter Maydell
On Thu, 13 Mar 2025 at 07:16, Akihiko Odaki wrote: > > PMCNTENCLR_EL0 and PMINTENCLR_EL1 clears written bits so we need an > alternative raw write functions, which will be used to copy KVM kernel > coprocessor state into userspace. > > Signed-off-by: Akihiko Odaki Nice catch. Did you find this b

Re: [PATCH] target/arm: Define raw write for PMU CLR registers

2025-03-13 Thread Akihiko Odaki
On 2025/03/13 19:13, Peter Maydell wrote: On Thu, 13 Mar 2025 at 07:16, Akihiko Odaki wrote: PMCNTENCLR_EL0 and PMINTENCLR_EL1 clears written bits so we need an alternative raw write functions, which will be used to copy KVM kernel coprocessor state into userspace. Signed-off-by: Akihiko Odak

[PATCH 1/2] target/i386/kvm: add AMD support for RAPL MSR

2025-03-13 Thread Anthony Harivel
Rework the RAPL MSR support to function with AMD specific RAPL MSR. Implement support for AMD-specific RAPL MSRs. AMD CPUs support three MSRs: MSR_AMD_RAPL_POWER_UNIT, MSR_AMD_PKG_ENERGY_STATUS, and MSR_AMD_CORE_ENERGY_STATUS. These MSRs have different addresses compared to their Intel counterpart

[PATCH 0/2] Add AMD CPU for RAPL MSR support

2025-03-13 Thread Anthony Harivel
Hi, The following patch add the support for AMD CPU for RAPL MSR. This was one of the two current limitation of the introduction patch. This has been tested on AMD Ryzen 5850U. I was able to mount the RAPL driver in a VM with '-cpu host'. The counter value are increasing properly. I added a s

Re: [PATCH 1/2] hw/arm/fsl-imx8mp: Make SoC not user-creatable, derive from TYPE_SYS_BUS_DEVICE

2025-03-13 Thread Peter Maydell
On Wed, 12 Mar 2025 at 23:58, BALATON Zoltan wrote: > > On Wed, 12 Mar 2025, Bernhard Beschow wrote: > > Fixes a crash when creating the SoC object on the command line: > > > > $ ./qemu-system-aarch64 -M virt -device fsl-imx8mp > > ** > > ERROR:../../devel/qemu/tcg/tcg.c:1006:tcg_register_thre

Re: [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines.

2025-03-13 Thread Daniel P . Berrangé
On Thu, Mar 13, 2025 at 03:17:05PM +0530, Harsh Prateek Bora wrote: > When POWER10 CPU was made as default, we missed keeping POWER9 as > default for older pseries releases (pre-9.0) at that time. > This caused breakge in default cpu evaluation for older pseries > machines and hence this fix. > >

Re: [PATCH 15/37] include/system: Move exec/address-spaces.h to system/address-spaces.h

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 04:44, Richard Henderson wrote: Convert the existing includes with sed. Signed-off-by: Richard Henderson --- hw/net/i82596.h | 2 +- hw/s390x/ipl.h| 2 +- include/hw/misc/lasi.h| 2 +- include/hw/nubus/nub

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-13 Thread Jörg Rödel
Hi Ani, On Thu, Mar 13, 2025 at 03:07:42PM +0530, Ani Sinha wrote: > The state before reset is the state that uses stock firmware from the > hyperscaler. The state after reset is a fresh new state that uses the > "trusted and known firmware" from the end user. So the launch > measurements would no

Re: [PATCH 10/37] accel/tcg: Use cpu_ld*_code_mmu in translator.c

2025-03-13 Thread Philippe Mathieu-Daudé
Hi Richard, On 13/3/25 04:44, Richard Henderson wrote: Cache the mmu index in DisasContextBase. Perform the read on host endianness, which lets us share code with the translator_ld fast path. Signed-off-by: Richard Henderson --- include/exec/translator.h | 1 + accel/tcg/translator.c|

Re: [PATCH 12/37] accel/tcg: Remove mmap_lock/unlock from watchpoint.c

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 04:44, Richard Henderson wrote: The mmap_lock is user-only, whereas watchpoint.c is only compiled for system mode. Signed-off-by: Richard Henderson --- accel/tcg/watchpoint.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2025-03-13 Thread Kevin Wolf
Am 30.07.2024 um 16:15 hat Alberto Garcia geschrieben: > This tool converts a disk image to qcow2, writing the result directly > to stdout. This can be used for example to send the generated file > over the network. > > This is equivalent to using qemu-img to convert a file to qcow2 and > then wri

Re: [PATCH 1/3] target/loongarch: Return directly when detect KVM disabled features

2025-03-13 Thread Markus Armbruster
Suggest something like arget/loongarch: Fix error handling of KVM feature checks That way, the nature of the patch (it's an error handling bug fix) is obvious at a glance. Bibo Mao writes: > For some paravirt KVM features, if user forces to enable it however > KVM does not support, qemu shou

[PATCH 2/2] target/i386/kvm: Change error_report() to tracepoint in vmsr_read_thread_stat()

2025-03-13 Thread Anthony Harivel
Threads in QEMU are frequently created and destroyed, leading to non-critical errors. Replace `error_report()` with a tracepoint to prevent flooding the serial terminal with non-essential error messages. Signed-off-by: Anthony Harivel --- target/i386/kvm/trace-events | 3 +++ target/i386/kvm/vm

Re: [PATCH 22/37] semihosting: Move user-only implementation out-of-line

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 11:04, Philippe Mathieu-Daudé wrote: On 13/3/25 04:45, Richard Henderson wrote: Avoid testing CONFIG_USER_ONLY in semihost.h. Signed-off-by: Richard Henderson ---   include/semihosting/semihost.h | 29 ++---   semihosting/user.c | 30 ++

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-13 Thread Ani Sinha
On Thu, Mar 13, 2025 at 3:40 PM Jörg Rödel wrote: > > Hi Ani, > > On Thu, Mar 13, 2025 at 03:07:42PM +0530, Ani Sinha wrote: > > The state before reset is the state that uses stock firmware from the > > hyperscaler. The state after reset is a fresh new state that uses the > > "trusted and known fi

Re: [PATCH 3/3] target/loongarch: Remove unnecessary temporary variable assignment

2025-03-13 Thread Markus Armbruster
Bibo Mao writes: > Temporary variable ret is assigned at last line and return, it can > be removed and return directly. > > Signed-off-by: Bibo Mao Reviewed-by: Markus Armbruster

[PATCH 07/13] hw/arm/aspeed_ast27x0-tsp: Introduce AST27x0 A0 TSP SoC

2025-03-13 Thread Steven Lee via
AST2700 TSP(Tertiary Service Processor) is a Cortex-M4 coprocessor The patch adds support for TSP with following update: - Introduce Aspeed27x0TSPSoCState structure in aspeed_soc.h - Define memory map and IRQ map for AST27x0 A0 TSP SoC - Implement initialization and realization functions - Add sup

Re: [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines.

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 10:47, Harsh Prateek Bora wrote: When POWER10 CPU was made as default, we missed keeping POWER9 as default for older pseries releases (pre-9.0) at that time. This caused breakge in default cpu evaluation for older pseries machines and hence this fix. Fixes: 51113013f3 ("ppc/spapr: cha

Re: [PATCH 25/37] common-user: Split out watchpoint-stub.c

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 04:45, Richard Henderson wrote: Uninline the user-only stubs from hw/core/cpu.h. Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 23 --- common-user/watchpoint-stub.c | 28 common-user/meson.build | 1 +

Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 12.03.2025 um 15:37 hat Markus Armbruster geschrieben: >> bdrv_activate() returns failure without setting an error when >> !bs->drv. This is suspicious. Turns out it used to succeed then, >> until commit 5416645fcf82 changed it to return -ENOMEDIUM. >> >> Return zero in

Re: [PATCH] block: Fix bdrv_activate() not to fail without medium

2025-03-13 Thread Markus Armbruster
Butterfingers, please ignore this one. I'll send a real reply soon.

[PULL 6/8] tests/functional/asset: Verify downloaded size

2025-03-13 Thread Thomas Huth
From: Nicholas Piggin If the server provides a Content-Length header, use that to verify the size of the downloaded file. This catches cases where the connection terminates early, and gives the opportunity to retry. Without this, the checksum will likely mismatch and fail without retry. Reviewed

Re: [PATCH 3/3] target/loongarch: Remove unnecessary temporary variable assignment

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 10:13, Bibo Mao wrote: Temporary variable ret is assigned at last line and return, it can be removed and return directly. Signed-off-by: Bibo Mao --- target/loongarch/tcg/tlb_helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 34/37] include/system: Remove ifndef CONFIG_USER_ONLY

2025-03-13 Thread Philippe Mathieu-Daudé
On 13/3/25 04:45, Richard Henderson wrote: This is include/system, so CONFIG_USER_ONLY will never be true. Ideally yes. I started moving headers in include/system/ to clarify APIs, but that doesn't mean some of these APIs aren't being (incorrectly) used in user emulation. Signed-off-by: Richa

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-13 Thread Jörg Rödel
Hi Ani, Don't get me wrong, I really like the general idea of vmfwupdate as a way to implement BYOFW, and for non-confidential VMs it is great. I just think the interface design is not well suited for confidential VMs yet and want to discuss how to change that. On Thu, Mar 13, 2025 at 04:02:11PM

Re: [PATCH] vfio/igd: Update IGD passthrough docoumentation

2025-03-13 Thread Corvin Köhne
On Wed, 2025-03-12 at 23:50 +0800, Tomita Moeko wrote: > A previous change made the OpRegion and LPC quirks independent of the > exising legacy mode, update the docoumentation accordingly. More related > topics, like creating EFI Option ROM of IGD for OVMF, how to solve the > VFIO_DMA_MAP Invalid A

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-13 Thread Ani Sinha
On Thu, Mar 13, 2025 at 4:29 PM Jörg Rödel wrote: > > Hi Ani, > > Don't get me wrong, I really like the general idea of vmfwupdate as > a way to implement BYOFW, and for non-confidential VMs it is great. I > just think the interface design is not well suited for confidential VMs > yet and want to

Re: [PATCH 1/3] target/loongarch: Return directly when detect KVM disabled features

2025-03-13 Thread bibo mao
On 2025/3/13 下午6:26, Markus Armbruster wrote: Suggest something like target/loongarch: Fix error handling of KVM feature checks That way, the nature of the patch (it's an error handling bug fix) is obvious at a glance. yeap, will modify title like this. Bibo Mao writes: For some pa

Re: [PATCH 2/3] hw/loongarch/virt: Remove unnecessary NULL pointer checking

2025-03-13 Thread bibo mao
On 2025/3/13 下午6:32, Markus Armbruster wrote: Bibo Mao writes: There is NULL pointer checking function error_propagate() already, it is not necessary to add checking for function parameter. Here remove NULL pointer checking with function parameter. Signed-off-by: Bibo Mao --- hw/loongar

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-13 Thread Jörg Rödel
On Thu, Mar 13, 2025 at 12:27:13PM +0100, Jörg Rödel wrote: > Fine with me. Just note that supporting the current non-IGVM process for > confidential guests still causes the implicit ABI issue I mentioned > before. But not being a KVM/QEMU maintainer I can live with that :) Small addition: Note th

Re: [PATCH] hw/uefi: flush variable store to disk in post load

2025-03-13 Thread Peter Krempa
On Thu, Mar 13, 2025 at 11:41:19 +0100, Gerd Hoffmann wrote: > Makes live migration more robust. Commit 4c0cfc72b31a ("pflash_cfi01: > write flash contents to bdrv on incoming migration") elaborates in > detail on the motivation. > > Cc: Peter Krempa > Signed-off-by: Gerd Hoffmann > --- Thanks

<    1   2   3