11.03.2025 15:57, Nicholas Piggin wrote:
The commit to fix the OCC common area sensor mappings didn't update the register offsets to match.Before this change, skiboot reports: [ 0.347100086,3] OCC: Chip 0 sensor data invalid Afterward, there is no error and the sensor_groups directory appears under /sys/firmware/opal/. The SLW_IMAGE_BASE address looks like a workaround to intercept firmware memory accesses, but that does not seem to be required now (and would have been broken by the OCC common area region mapping change anyway). So it can be removed. Fixes: 3a1b70b66b5cb4 ("ppc/pnv: Fix OCC common area region mapping")
Is it a qemu-stable material? Not sure it's worth the effort though, since 3a1b70b66b5cb4 is rather old. I picked this one up for 9.2, 8.2 and 7.2 series. Please let me know if I shouldn't. Thanks, /mjt
