[RFC PATCH v2 18/20] hw/arm/smmu-common: Bypass emulated IOTLB for a accel SMMUv3

2025-03-11 Thread Shameer Kolothum via
From: Nicolin Chen If a vSMMU is configured as a accelerated one, HW IOTLB will be used and all cache invalidation should be done to the HW IOTLB too, v.s. the emulated iotlb. In this case, an iommu notifier isn't registered, as the devices behind a SMMUv3-accel would stay in the system address s

[RFC PATCH v2 14/20] hw/arm/smmuv3: Install nested ste for CFGI_STE

2025-03-11 Thread Shameer Kolothum via
Make use of smmuv3_accel provided _install_nested_ste() for CFGI_STE. Signed-off-by: Shameer Kolothum --- hw/arm/smmuv3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index ea63731d61..83159db1d4 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -12

Re: [PATCH 2/4] 9pfs: Don't use file descriptors in core code

2025-03-11 Thread Greg Kurz
On Tue, 11 Mar 2025 15:03:13 +0100 Greg Kurz wrote: > On Tue, 11 Mar 2025 12:13:06 +0100 > Christian Schoenebeck wrote: > > > On Monday, March 10, 2025 6:10:59 PM CET Greg Kurz wrote: > > > v9fs_getattr() currently peeks into V9fsFidOpenState to know if a fid > > > has a valid file descriptor o

[PATCH v3 01/14] scsi-disk: drop unused SCSIDiskState->bh field

2025-03-11 Thread Stefan Hajnoczi
Commit 71544d30a6f8 ("scsi: push request restart to SCSIDevice") removed the only user of SCSIDiskState->bh. Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c

[RFC PATCH v2 20/20] hw/arm/smmuv3-accel: Enable smmuv3-accel creation

2025-03-11 Thread Shameer Kolothum via
Signed-off-by: Shameer Kolothum --- hw/arm/smmuv3-accel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/smmuv3-accel.c b/hw/arm/smmuv3-accel.c index fb08e1d66b..812f8e358f 100644 --- a/hw/arm/smmuv3-accel.c +++ b/hw/arm/smmuv3-accel.c @@ -595,6 +595,7 @@ static void smmuv3_accel_clas

[PULL 68/72] ppc/amigaone: Implement NVRAM emulation

2025-03-11 Thread Nicholas Piggin
From: BALATON Zoltan The board has a battery backed NVRAM where U-Boot environment is stored which is also accessed by AmigaOS and e.g. C:NVGetVar command crashes without it having at least a valid checksum. [npiggin: 32-bit compile fix] Signed-off-by: BALATON Zoltan Reviewed-by: Nicholas Piggi

[PULL 45/72] target/ppc: Move ppc_ldl_code() to tcg-excp_helper.c

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Harsh Prateek Bora Message-ID: <20250127102620.39159-6-phi...@linaro.org> Signed-off-by: Nicholas Piggin --- target/ppc/excp_helper.c | 21 - target/ppc/tcg-excp_helper.c | 18 +

[RFC PATCH v2 03/20] hw/arm/smmuv3-accel: Add initial infrastructure for smmuv3-accel device

2025-03-11 Thread Shameer Kolothum via
Based on SMMUv3 as a parent device, add a user-creatable smmuv3-accel device. In order to support vfio-pci dev assignment with a Guest SMMUv3, the physical SMMUv3 has to be configured in nested(S1+s2) mode, with Guest owning the S1 page tables. Subsequent patches will add support for smmuv3-accel t

[PULL 48/72] target/ppc: Remove raise_exception_ra()

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Introduced in commit db789c6cd33 ("ppc: Provide basic raise_exception_* functions"), raise_exception_ra() has never been used. Remove as dead code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Harsh Prateek Bora Message-ID: <20250127102620.39159-9-phi...@lina

[PATCH v3 62/63] docs: add qapi-domain syntax documentation

2025-03-11 Thread John Snow
Who documents the documentation? Me, I guess. Signed-off-by: John Snow --- docs/devel/index-build.rst | 1 + docs/devel/qapi-domain.rst | 670 + 2 files changed, 671 insertions(+) create mode 100644 docs/devel/qapi-domain.rst diff --git a/docs/devel/index

Re: [PATCH v5 14/14] hw/sd/sdhci: Remove unnecessary 'endianness' property

2025-03-11 Thread Bernhard Beschow
Am 10. März 2025 00:06:20 UTC schrieb "Philippe Mathieu-Daudé" : >The previous commit removed the single use of instance >setting the "endianness" property. > >Since classes can register their io_ops with correct >endianness, no need to support different ones. > >Remove the code related to SDHC

Re: [PATCH v5 01/14] hw/qdev-properties-system: Include missing 'qapi/qapi-types-common.h'

2025-03-11 Thread Philippe Mathieu-Daudé
+Markus On 10/3/25 01:06, Philippe Mathieu-Daudé wrote: DEFINE_PROP_ENDIAN_NODEFAULT() macro uses ENDIAN_MODE_UNSPECIFIED which is defined in "qapi/qapi-types-common.h". Fixes: 4ec96630f93 ("hw/qdev-properties-system: Introduce EndianMode QAPI enum") Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 1/4] 9pfs: local : Introduce local_fid_fd() helper

2025-03-11 Thread Christian Schoenebeck
On Monday, March 10, 2025 6:10:58 PM CET Greg Kurz wrote: > Factor out duplicated code to a single helper. More users to come. > > Signed-off-by: Greg Kurz > --- > hw/9pfs/9p-local.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/hw/9pfs/9p-loca

[PULL 03/61] docs/qapi-domain: add QAPI domain object registry

2025-03-11 Thread Markus Armbruster
From: John Snow This is the first step towards QAPI domain cross-references and a QAPI reference index. This patch just creates the object registry, and updates the merge_domaindata stub method now that we have actual data we may need to merge. Note that how to handle merge conflict resolution

[PULL 47/61] docs/qapidoc: add visit_returns() method

2025-03-11 Thread Markus Armbruster
From: John Snow Generates :return: fields for explicit returns statements. Note that this does not presently handle undocumented returns, which is handled in a later commit. Signed-off-by: John Snow Message-ID: <20250311034303.75779-51-js...@redhat.com> Acked-by: Markus Armbruster Signed-off-b

[PULL 10/61] docs/qapi-domain: add QAPIObject class

2025-03-11 Thread Markus Armbruster
From: John Snow This patch adds another abstract class that describes "a QAPI thingie". The main difference here is that this class will be generating visible documentation, unlike the QAPIDescription class. Signed-off-by: John Snow Message-ID: <20250311034303.75779-13-js...@redhat.com> Acked-b

[PULL 40/61] docs/qapidoc: add preamble() method

2025-03-11 Thread Markus Armbruster
From: John Snow This method adds the options/preamble to each definition block. Notably, :since: and :ifcond: are added, as are any "special features" such as :deprecated: and :unstable:. If conditionals, if attached to special features, are currently unhandled in this patch and will be addresse

[PULL 04/61] docs/qapi-domain: add QAPI index

2025-03-11 Thread Markus Armbruster
From: John Snow Use the QAPI object registry to generate a special index just for QAPI definitions. The index can show entries both by definition type and all together, alphabetically. The index can be linked from anywhere in the QEMU manual by using the reference `qapi-index`. Signed-off-by: J

[PULL 60/61] MAINTAINERS: Add jsnow as maintainer for Sphinx documentation

2025-03-11 Thread Markus Armbruster
From: John Snow Since I've just about rewritten the entirety of the QAPI documentation system, it's probably fair that I be the contact point for if it goes awry. Signed-off-by: John Snow Message-ID: <20250311034303.75779-64-js...@redhat.com> Acked-by: Markus Armbruster Signed-off-by: Markus A

[PULL 11/61] docs/qapi-domain: add qapi:command directive

2025-03-11 Thread Markus Armbruster
From: John Snow This commit adds a stubbed version of QAPICommand that utilizes the QAPIObject class, the qapi:command directive, the :qapi:cmd: cross-reference role, and the "command" object type in the QAPI object registry. They don't do anything *particularly* interesting yet, but that will c

[PULL 32/61] qapi/schema: add __repr__ to QAPIDoc.Section

2025-03-11 Thread Markus Armbruster
From: John Snow Makes debugging far more pleasant when you can just print(section) and get something reasonable to display. Signed-off-by: John Snow Message-ID: <20250311034303.75779-35-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/qapi/parser.

[PULL 09/61] docs/qapi-domain: add qapi:module directive

2025-03-11 Thread Markus Armbruster
From: John Snow This adds the qapi:module directive, which just notes the current module being documented and performs a nested parse of the content block, if present. This code is based pretty heavily on Sphinx's PyModule directive, but with unnecessary features excised. For example: .. qapi:

[PULL 00/61] QAPI patches patches for 2025-03-11

2025-03-11 Thread Markus Armbruster
The following changes since commit 825b96dbcee23d134b691fc75618b59c5f53da32: Merge tag 'migration-20250310-pull-request' of https://gitlab.com/farosas/qemu into staging (2025-03-11 09:32:07 +0800) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2025

[PULL 48/61] docs/qapidoc: add visit_member() method

2025-03-11 Thread Markus Armbruster
From: John Snow This method is used for generating the "members" of a wide variety of things, including structs, unions, enums, alternates, etc. The field name it uses to do so is dependent on the type of entity the "member" belongs to. Currently, IF conditionals for individual members are not h

[PULL 19/61] docs/qapi-domain: add qapi:event directive

2025-03-11 Thread Markus Armbruster
From: John Snow Adds the .. qapi:event:: directive, object, and :qapi:event:`name` cross-referencing role. Adds the :memb type name: field list syntax for documenting event data members. As this syntax and phrasing will be shared with Structs and Unions as well, add the field list definition to

[PULL 46/61] docs/qapidoc: prepare to record entity being transmogrified

2025-03-11 Thread Markus Armbruster
From: John Snow Prepare to keep a record of which entity we're working on documenting for the purposes of being able to change certain generative features conditionally and create stronger assertions. If you find yourself asking: "Wait, but where does the current entity actually get recorded?!",

[PULL 41/61] docs/qapidoc: add visit_paragraph() method

2025-03-11 Thread Markus Armbruster
From: John Snow This transforms "formerly known as untagged sections" into our pure intermediate rST format. These sections are already pure rST, so this method doesn't do a whole lot except ensure appropriate newlines. Signed-off-by: John Snow Message-ID: <20250311034303.75779-45-js...@redhat.

[PATCH-for-10.0 v3 1/8] system: Declare qemu_[min/max]rampagesize() in 'system/hostmem.h'

2025-03-11 Thread Philippe Mathieu-Daudé
Both qemu_minrampagesize() and qemu_maxrampagesize() are related to host memory backends, having the following call stack: qemu_minrampagesize() -> find_min_backend_pagesize() -> object_dynamic_cast(obj, TYPE_MEMORY_BACKEND) qemu_maxrampagesize() -> find_max_backend_pagesiz

[PULL 51/61] docs/qapidoc: implement transmogrify() method

2025-03-11 Thread Markus Armbruster
From: John Snow This is the true top-level processor for the new transmogrifier; responsible both for generating the intermediate rST and then running the nested parse on that generated document to produce the final docutils tree that is then - very finally - postprocessed by sphinx for final ren

Re: [PATCH v7 0/7] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop

2025-03-11 Thread Philippe Mathieu-Daudé
Hi Peter, On 10/3/25 18:28, Peter Maydell wrote: On Mon, 10 Mar 2025 at 14:42, Peter Maydell wrote: On Mon, 10 Mar 2025 at 01:28, Philippe Mathieu-Daudé wrote: Hi, This series add support for (async) FIFO on the transmit path of the PL011 UART. This hasn't made the last pre-softfreeze a

[PULL 33/61] docs/qapidoc: add transmogrifier stub

2025-03-11 Thread Markus Armbruster
From: John Snow This commit adds a stubbed option to the qapi-doc directive that opts-in to the new rST generator; the implementation of which will follow in subsequent commits. Once all QAPI documents have been converted, this option and the old qapidoc implementation can be dropped. Note that

[PULL 31/61] qapi: clean up encoding of section kinds

2025-03-11 Thread Markus Armbruster
From: John Snow We have several kinds of sections, and to tell them apart, we use Section attribute @tag and also the section object's Python type: type@tag untagged Section None @foo: ArgSection 'foo' Returns: Section 'Returns' Errors: Sect

[PATCH v3 01/63] do-not-merge

2025-03-11 Thread John Snow
Ad-hoc linting scripts to scrub down the new docs/sphinx files. Should work with a reasonably modern mypy/pylint/etc, and Sphinx 8.2.0. Older versions of Sphinx ought to still work at runtime, but may not type check correctly. Signed-off-by: John Snow --- scripts/qapi-lint.sh | 57 ++

[PULL 54/61] docs/qapidoc: Add "the members of" pointers

2025-03-11 Thread Markus Armbruster
From: John Snow Add "the members of ..." pointers to Members and Arguments lists where appropriate, with clickable cross-references - so it's a slight improvement over the old system :) This patch is meant to be a temporary solution until we can review and merge the inliner. The implementation

[PULL 42/61] docs/qapidoc: add visit_errors() method

2025-03-11 Thread Markus Armbruster
From: John Snow Notably, this method does not currently address the formatting issues present with the "errors" section in QAPIDoc and just vomits the text verbatim into the rST doc, with somewhat inconsistent results. To be addressed in a future patch. Signed-off-by: John Snow Message-ID: <20

Re: [PATCH v2 11/13] virtio-scsi: add iothread-vq-mapping parameter

2025-03-11 Thread Kevin Wolf
Am 11.03.2025 um 11:11 hat Stefan Hajnoczi geschrieben: > Allow virtio-scsi virtqueues to be assigned to different IOThreads. This > makes it possible to take advantage of host multi-queue block layer > scalability by assigning virtqueues that have affinity with vCPUs to > different IOThreads that

[PATCH v4 02/13] dma: use current AioContext for dma_blk_io()

2025-03-11 Thread Stefan Hajnoczi
In the past a single AioContext was used for block I/O and it was fetched using blk_get_aio_context(). Nowadays the block layer supports running I/O from any AioContext and multiple AioContexts at the same time. Remove the dma_blk_io() AioContext argument and use the current AioContext instead. Th

[PATCH v4 01/13] scsi-disk: drop unused SCSIDiskState->bh field

2025-03-11 Thread Stefan Hajnoczi
Commit 71544d30a6f8 ("scsi: push request restart to SCSIDevice") removed the only user of SCSIDiskState->bh. Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c

[PULL 51/72] target/ppc: Fix style in excp_helper.c

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Fix style in do_rfi() before moving the code around. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Harsh Prateek Bora Message-ID: <20250127102620.39159-13-phi...@linaro.org> Signed-off-by: Nicholas Piggin --- target/ppc/excp_helper.c | 3 ++- 1 file changed,

[PULL 65/72] target/ppc: Avoid warning message for zero process table entries

2025-03-11 Thread Nicholas Piggin
A translation that encounters a process table entry that is zero is something that Linux does to cause certain kernel NULL pointer dereferences to fault. It is not itself a programming error, so avoid the guest error log. Message-ID: <20241219034035.1826173-5-npig...@gmail.com> Signed-off-by: Nich

[PATCH v4 09/13] virtio-blk: tidy up iothread_vq_mapping functions

2025-03-11 Thread Stefan Hajnoczi
Use noun_verb() function naming instead of verb_noun() because the former is the most common naming style for APIs. The next commit will move these functions into a header file so that virtio-scsi can call them. Shorten iothread_vq_mapping_apply()'s iothread_vq_mapping_list argument to just "list"

Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-11 Thread Thomas Huth
On 11/03/2025 14.37, Daniel P. Berrangé wrote: On Tue, Mar 11, 2025 at 11:13:26PM +1000, Nicholas Piggin wrote: The NetBSD archive is currently failing part-way through downloads, which results in no clean HTTP error but a short transfer and checksum error. This is treated as fatal in the precac

[PULL 57/72] hw/ppc/spapr: Convert CLEAN_HPTE() macro as hpte_set_clean() method

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Convert CLEAN_HPTE() macro as hpte_set_clean() method. sPAPR data structures including the hash page table are big-endian regardless of current CPU endian mode, so use the big-endian LD/ST API to access the hash PTEs. Reviewed-by: Nicholas Piggin Signed-off-by: Phi

[PULL 47/72] target/ppc: Restrict powerpc_checkstop() to TCG

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Expose powerpc_checkstop() prototype, and move it to tcg-excp_helper.c, only built when TCG is available. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Harsh Prateek Bora Message-ID: <20250127102620.39159-8-phi...@linaro.org> Signed-off-by: Nicholas Piggin --

[PULL 07/72] ppc/pnv/homer: Fix OCC registers

2025-03-11 Thread Nicholas Piggin
The HOMER OCC registers seem to have bitrotted and fail for various reasons on powernv8, 9, and 10. The major problems are that POWER8 has the wrong version value and its pstate ordering is incorrect. POWER9/10 have not set the OCC state to active. Non-zero chips are also set to OCC slaves for POW

[PATCH v4 04/13] scsi: introduce requests_lock

2025-03-11 Thread Stefan Hajnoczi
SCSIDevice keeps track of in-flight requests for device reset and Task Management Functions (TMFs). The request list requires protection so that multi-threaded SCSI emulation can be implemented in commits that follow. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf --- include/hw/scsi/sc

[PULL 31/72] ppc/xive2: Add support for MMIO operations on the NVPG/NVC BAR

2025-03-11 Thread Nicholas Piggin
From: Frederic Barrat Add support for the NVPG and NVC BARs. Access to the BAR pages will cause backlog counter operations to either increment or decriment the counter. Also added qtests for the same. Signed-off-by: Frederic Barrat Signed-off-by: Michael Kowal Reviewed-by: Nicholas Piggin S

[PATCH v3 05/14] virtio-scsi: introduce event and ctrl virtqueue locks

2025-03-11 Thread Stefan Hajnoczi
Virtqueues are not thread-safe. Until now this was not a major issue since all virtqueue processing happened in the same thread. The ctrl queue's Task Management Function (TMF) requests sometimes need the main loop, so a BH was used to schedule the virtqueue completion back in the thread that has v

[PULL 57/61] docs: disambiguate cross-references

2025-03-11 Thread Markus Armbruster
From: John Snow The next patch will engage the qapidoc transmogrifier, which creates a lot of cross-reference targets. Some of the existing targets ("migration", "qom", "replay") will become ambiguous as a result. Nail them down more explicitly to prevent ambiguous cross-reference warnings. Sign

[PATCH] qapi/block-core: Improve x-blockdev-change documentation

2025-03-11 Thread Markus Armbruster
The description of feature @unstable is three paragraphs. The second and third became part of the description by accident in commit 9fb49daabfb (qapi: Mark unstable QMP parts with feature 'unstable'). The second paragraph describes a defect in terms of the implementation. Fine, but doesn't belon

[RFC PATCH v2 08/20] hw/arm/smmuv3-accel: Provide get_address_space callback

2025-03-11 Thread Shameer Kolothum via
Also introduce a struct SMMUv3AccelDevice to hold accelerator specific device info. This will be populated accordingly in subsequent patches. Signed-off-by: Shameer Kolothum --- hw/arm/smmuv3-accel.c | 36 +++ include/hw/arm/smmuv3-accel.h | 4 2 fil

Re: [PATCH 2/4] 9pfs: Don't use file descriptors in core code

2025-03-11 Thread Christian Schoenebeck
On Tuesday, March 11, 2025 3:03:13 PM CET Greg Kurz wrote: > On Tue, 11 Mar 2025 12:13:06 +0100 > Christian Schoenebeck wrote: > > > On Monday, March 10, 2025 6:10:59 PM CET Greg Kurz wrote: [...] > > Follow-up on previous patch, this could be reduced to: > > > > static int local_fid_fd(int fid_

[PULL 42/72] ppc/pnv: Add new PowerPC Special Purpose Registers (RWMR)

2025-03-11 Thread Nicholas Piggin
From: dan tan Register RWMR - Region Weighted Mode Register for privileged access in Power9 and Power10 It controls what the SPURR register produces. Specs: - Power10: https://files.openpower.foundation/s/EgCy7C43p2NSRfR TCG does not model SMT priority, timing, resource controls and status so

Re: [PATCH v2 03/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h

2025-03-11 Thread Pierrick Bouvier
On 3/10/25 21:08, Pierrick Bouvier wrote: They are now accessible through exec/memory.h instead, and we make sure all variants are available for common or target dependent code. Signed-off-by: Pierrick Bouvier --- include/exec/cpu-all.h | 12 include/exec/memory_ldst.h.i

Re: [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup

2025-03-11 Thread Philippe Mathieu-Daudé
On 7/3/25 22:56, Pierrick Bouvier wrote: Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/hw/hyperv/hyperv.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/hyperv/hyperv.h b/include/hw/hyperv/hyperv.h index d717b4e13d4..63a8b65278f

Re: [PULL 05/10] Add Hyper-V Dynamic Memory Protocol driver (hv-balloon) base

2025-03-11 Thread Maciej S. Szmigiero
On 11.03.2025 16:00, Philippe Mathieu-Daudé wrote: Hi Maciej, On 6/11/23 15:20, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and (in the next patch) inserting pieces of

Re: [PATCH v2 07/16] exec/exec-all: remove dependency on cpu.h

2025-03-11 Thread Pierrick Bouvier
On 3/11/25 00:26, Philippe Mathieu-Daudé wrote: On 11/3/25 05:08, Pierrick Bouvier wrote: Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Missing the "why" justification we couldn't do that before. --- include/exec/exec-all.h | 1 - 1 file changed, 1 deletion(-) diff -

Re: [PATCH v2 08/16] exec/memory-internal: remove dependency on cpu.h

2025-03-11 Thread Pierrick Bouvier
On 3/11/25 00:26, Philippe Mathieu-Daudé wrote: On 11/3/25 05:08, Pierrick Bouvier wrote: Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Missing the "why" justification we couldn't do that before. --- include/exec/memory-internal.h | 2 -- 1 file changed, 2 deletions(-

[PULL 53/72] target/ppc: Restrict ATTN / SCV / PMINSN helpers to TCG

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Move helper_attn(), helper_scv() and helper_pminsn() to tcg-excp_helper.c. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Harsh Prateek Bora Message-ID: <20250127102620.39159-15-phi...@linaro.org> Signed-off-by: Nicholas Piggin --- target/ppc/cpu.h

Re: [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup

2025-03-11 Thread Philippe Mathieu-Daudé
On 11/3/25 16:05, Philippe Mathieu-Daudé wrote: On 7/3/25 22:56, Pierrick Bouvier wrote: Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier ---   include/hw/hyperv/hyperv.h | 3 ++-   1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/hyperv/hyperv.h b/include/h

[RFC PATCH v4 0/5] Report vfio-ap configuration changes

2025-03-11 Thread Rorie Reyes
Changelog: v4: - allocating cfg_chg_event before inserting into the queue - calling nt0_have_event in if loop to check if there are any elemenets in the queue, then calling QTAILQ_FIRST when the check passes - moving memset() after the check v3: - changes that were made to patch 3/5 should have b

[RFC PATCH v4 4/5] hw/vfio/ap: Storing event information for an AP configuration change event

2025-03-11 Thread Rorie Reyes
These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 39 inc

Re: [PATCH v2 11/16] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled

2025-03-11 Thread Pierrick Bouvier
On 3/11/25 00:29, Philippe Mathieu-Daudé wrote: On 11/3/25 05:08, Pierrick Bouvier wrote: Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier I didn't follow this direction because Richard had a preference on removing unnecessary inlined functions: https://lore.kernel.org/qemu-dev

[RFC PATCH v4 5/5] s390: implementing CHSC SEI for AP config change

2025-03-11 Thread Rorie Reyes
Handle interception of the CHSC SEI instruction for requests indicating the guest's AP configuration has changed. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak --- target/s390x/ioinst.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[RFC PATCH v4 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-03-11 Thread Rorie Reyes
Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak --- hw/vfio/ap.c | 31 +++ 1 file cha

Re: [PATCH v2 00/14] XIVE2 changes to support Group and Crowd operations

2025-03-11 Thread Nicholas Piggin
Thanks, I merged this series with some tweaks, except for patch 12 Support ESB Escalation because it has some outstanding problems as commented. Thanks, Nick On Tue Dec 10, 2024 at 10:05 AM AEST, Michael Kowal wrote: > XIVE2 has the concepts of a Group of interrupts and a Crowd of interrupts > (w

Re: [PATCH v2 14/16] include/exec/memory: extract devend_big_endian from devend_memop

2025-03-11 Thread Pierrick Bouvier
On 3/11/25 00:36, Philippe Mathieu-Daudé wrote: On 11/3/25 05:08, Pierrick Bouvier wrote: we'll use it in system/memory.c. Having part of the commit description separated in its subject is a bit annoying. But then I'm probably using 20-years too old tools in my patch workflow. Only used in sy

Re: [PATCH v4 00/13] virtio-scsi: add iothread-vq-mapping parameter

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 21:26:03 +0800, Stefan Hajnoczi wrote: > v4: > - Squash fixup commit properly this time >_< [Peter] > v3: > - Use vq_aio_context[VIRTIO_SCSI_VQ_NUM_FIXED] as the AioContext for the Block > Backend [Kevin] > v2: > - Only expose cmd vqs via iothread-vq-mapping [Kevin, Peter]

Re: [PATCH v2] QIOChannelSocket: Flush zerocopy socket error queue on ENOBUF failure for sendmsg

2025-03-11 Thread Peter Xu
On Tue, Mar 11, 2025 at 04:15:38AM +0530, Manish wrote: > Thanks Peter, Daniel > > Are there any code pointers where something similar is done? I can follow > that. Sorry to make you feel like we can simplify the code, it's my fault. Dan has a point that at least for now it's part of ABI, so we

Re: [PATCH v2] vfio: Add property documentation

2025-03-11 Thread Joao Martins
On 05/03/2025 13:13, Cédric Le Goater wrote: > Joao, > > On 3/5/25 12:16, Joao Martins wrote: >> On 14/02/2025 13:05, Cédric Le Goater wrote: >>> +Kirti >>> +Joao >>> >>> On 2/13/25 22:45, Alex Williamson wrote: > + > +    /* > + * Migration support > + */ > +    object

[PULL 15/72] ppc/pnv/occ: Implement a basic dynamic OCC model

2025-03-11 Thread Nicholas Piggin
The OCC is an On Chip Controller that handles various thermal and power management. It is a PPC405 microcontroller that runs its own firmware which is out of scope of the powernv machine model. Some dynamic behaviour and interfaces that are important for host CPU testing can be implemented with a m

[PULL 44/72] target/ppc: Move TCG specific exception handlers to tcg-excp_helper.c

2025-03-11 Thread Nicholas Piggin
From: Philippe Mathieu-Daudé Move the TCGCPUOps handlers to a new unit: tcg-excp_helper.c, only built when TCG is selected. See in target/ppc/cpu_init.c: #ifdef CONFIG_TCG static const TCGCPUOps ppc_tcg_ops = { ... .do_unaligned_access = ppc_cpu_do_unaligned_access, .d

Sapphire Rapids missing from "Preferred CPU models for Intel x86 hosts" ?

2025-03-11 Thread Chris Friesen via
Hi, I was looking at the website and noticed that the various Sapphire Rapids variants were missing from the list of "Preferred CPU models for Intel x86 hosts" located at https://qemu-project.gitlab.io/qemu/system/qemu-cpu-models.html#preferred-cpu-models-for-intel-x86-hosts Is this intentio

[PULL 13/61] docs/qapi-domain: add "Arguments:" field lists

2025-03-11 Thread Markus Armbruster
From: John Snow This adds special rendering for Sphinx's typed info field lists. This patch does not add any QAPI-aware markup, rendering, or cross-referencing for the type names, yet. That feature requires a subclass to TypedField which will happen in its own commit quite a bit later in this se

Re: [PATCH v2 0/5] ppc/amigaone patches

2025-03-11 Thread Nicholas Piggin
On Fri Feb 28, 2025 at 2:39 AM AEST, BALATON Zoltan wrote: > Hello, > > v2: > - change unused read function to g_assert_not_reached() > - new patch to add defines to constants > - added R-b tags > > This series adds NVRAM and support for -kernel, -initrd and -append > options to the amigaone machin

Re: [PATCH v2 14/16] include/exec/memory: extract devend_big_endian from devend_memop

2025-03-11 Thread Philippe Mathieu-Daudé
On 11/3/25 05:08, Pierrick Bouvier wrote: we'll use it in system/memory.c. Having part of the commit description separated in its subject is a bit annoying. But then I'm probably using 20-years too old tools in my patch workflow. Only used in system/{memory,physmem}.c, worth move to a local sy

Re: [RFC PATCH-for-9.1 00/21] qapi: Make @query-cpu-definitions command target-agnostic

2025-03-11 Thread Philippe Mathieu-Daudé
(+Pierrick for historical background) On 15/3/24 14:08, Philippe Mathieu-Daudé wrote: Hi Alex, Markus, Markus mentioned QAPI problems with the heterogeneous emulation binary. My understanding is, while QAPI can use host-specific conditional (OS, library available, configure option), it shouldn'

Re: [PATCH] bcm2838: Add GIC-400 timer interupt connections

2025-03-11 Thread Peter Maydell
On Mon, 10 Mar 2025 at 06:29, Sourojeet Adhikari wrote: > > Hello, > > So far I've figured out that I need to add a member called SplitIRQ > in the BCMSocPeripheralBaseState struct, which is of size defined > by `BCM2835_NUM_SPLITTERS`. Then from what I can tell through > reading through the codeb

[PATCH] tests/9p: add 'Tsetattr' request to test client

2025-03-11 Thread Christian Schoenebeck
Add and implement functions to 9pfs test client for sending a 9p2000.L 'Tsetattr' request and receiving its 'Rsetattr' response counterpart. Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio-9p-client.c | 49 +++ tests/qtest/libqos/virtio-9p-client.h | 34

Re: Building QEMU as a Shared Library

2025-03-11 Thread Saanjh Sengupta
Hi, I have a couple of questions: 1. When I use the libstoptrigger.so: in that case the QEMU 's emulation stops after executing the defined number of instructions. Post this, the whole QEMU terminates. And while using the libips.so I am assuming that the QEMU doesn't execute no more than the

Re: [PATCH 0/4] 9pfs: Fix ftruncate-after-unlink

2025-03-11 Thread Christian Schoenebeck
On Monday, March 10, 2025 6:10:57 PM CET Greg Kurz wrote: > QEMU 9.2 already fixed the long standing limitation of failing fstat() on > unlinked files. This series does something similar for ftruncate(). > > The following program can be straced inside the guest with a shared fs in > passthrough mo

[PULL 17/61] docs/qapi-domain: add qapi:enum directive

2025-03-11 Thread Markus Armbruster
From: John Snow Add the .. qapi:enum:: directive, object, and :qapi:enum:`name` cross-reference role. Add the :value name: field list for documenting Enum values. Of note, also introduce a new "type" role that is intended to be used by other QAPI object directives to cross-reference arbitrary Q

[PULL 26/61] docs/qapi-domain: add CSS styling

2025-03-11 Thread Markus Armbruster
From: John Snow Improve the general look and feel of generated QAPI docs. Attempt to limit line lengths to offer a more comfortable measure on maximized windows, and improve some margin and spacing for field lists. Signed-off-by: Harmonie Snow Signed-off-by: John Snow Message-ID: <20250311034

[PULL 55/61] docs/qapidoc: generate entries for undocumented members

2025-03-11 Thread Markus Armbruster
From: John Snow Presently, we never have any empty text entries for members. The next patch will explicitly generate such sections, so enable support for it in advance. The parser will generate placeholder sections to indicate undocumented members, but it's the qapidoc generator that's responsib

Re: [RFC PATCH-for-9.1? 0/2] hw/intc/arm_gic: Only provide query-gic-capabilities when GIC built-in

2025-03-11 Thread Philippe Mathieu-Daudé
+Pierrick for historical context On 6/8/24 16:19, Philippe Mathieu-Daudé wrote: Attempt to clarify confuse output from the 'query-gic-capabilities' QMP command when no GIC devices are built in. Philippe Mathieu-Daudé (2): target/arm: Move qmp_query_gic_capabilities() to hw/intc/ hw/intc/a

[PATCH-for-10.0 v3 0/8] hw/vfio: Build various objects once

2025-03-11 Thread Philippe Mathieu-Daudé
Hi Cédric, Here are the VFIO cleanup patches ready enough for 10.0, with Richard and Eric comments from v2 addressed. I'd prefer the rest (of v2) to wait for 10.1. Thanks, Phil. Philippe Mathieu-Daudé (8): system: Declare qemu_[min/max]rampagesize() in 'system/hostmem.h' hw/vfio/spapr: Do

Re: [PATCH 6/7] hw/ppc: [WIP] Add Processor Dump Area offsets in Pnv SBE

2025-03-11 Thread Harsh Prateek Bora
On 2/17/25 12:49, Aditya Gupta wrote: Add offsets for the processor state captured during MPIPL dump. This is incomplete. And might be implemented in future if the effort to implement MPIPL is resumed again. Please use RFC prefix in next iteration of patch series until the patches are requ

Re: [PATCH v5 14/14] hw/sd/sdhci: Remove unnecessary 'endianness' property

2025-03-11 Thread Philippe Mathieu-Daudé
On 11/3/25 08:31, Bernhard Beschow wrote: Am 10. März 2025 00:06:20 UTC schrieb "Philippe Mathieu-Daudé" : The previous commit removed the single use of instance setting the "endianness" property. Since classes can register their io_ops with correct endianness, no need to support different o

Re: [PATCH v3 52/63] docs/qapidoc: add visit_sections() method

2025-03-11 Thread Markus Armbruster
John Snow writes: > Implement the actual main dispatch method that processes and handles the > list of doc sections for a given QAPI entity. Your PATCH 59 mentions in passing that the new doc generator "blindly operates on a sequence of QAPIDoc.Section instances." I think that's worth noting he

Re: [PATCH v7 5/5] migration: add MULTIFD_RECV_SYNC migration command

2025-03-11 Thread Fabiano Rosas
Prasad Pandit writes: > Hi, > > On Tue, 11 Mar 2025 at 01:28, Fabiano Rosas wrote: >> They occur when cleanup code is allowed to run when resources have not >> yet been allocated or while the resources are still being accessed. >> >> Having the shutdown routine at a single point when it's clear

Re: [PATCH 3/3] vhost-user: return failure if backend crash when live migration

2025-03-11 Thread Haoqian He
Thanks for reviewing, I will fix this grammar issue in the next version. > > > 2025年3月10日 00:30,Raphael Norwitz 写道: > > I'll let others chime in on higher level device model changes you're > making. For the vhost-user-blk and vhost-user-scsi bits: > > On Sun, Mar 9, 2025 at 11:41 AM Haoqian

Re: Building QEMU as a Shared Library

2025-03-11 Thread Saanjh Sengupta
Hi, You can find the image attached. Regards Saanjh Sengupta From: Saanjh Sengupta Sent: Tuesday, March 11, 2025 3:20:48 PM To: Pierrick Bouvier ; Philippe Mathieu-Daudé ; Paolo Bonzini ; Marc-André Lureau Cc: amir.gon...@neuroblade.ai ; qemu-devel@nongnu.o

Re: [PATCH] pci-ids.rst: Add Red Hat pci-id for AMD IOMMU device

2025-03-11 Thread Gerd Hoffmann
Hi, > As a heads up, I believe we have a similar problem with a few of the CXL IDs. > The root port and type 3 device both use Intel IDs that were not reserved > for this purpose. VID=0x8086, DID=0x7075 and DID=0x0d93 Essentially we have two kinds of PCI devices in qemu. * The ones which try

Re: [PATCH v2 00/21] hw/vfio: Build various objects once

2025-03-11 Thread Cédric Le Goater
On 3/9/25 00:08, Philippe Mathieu-Daudé wrote: By doing the following changes: - Clean some headers up - Replace compile-time CONFIG_KVM check by kvm_enabled() - Replace compile-time CONFIG_IOMMUFD check by iommufd_builtin() we can build less vfio objects. Since v1: - Added R-b tags - Introduce

[PULL SUBSYSTEM qemu-pnv] ppc/pnv: Update skiboot firmware image

2025-03-11 Thread Nicholas Piggin
The following changes since commit 223c7908fe016d3fc79ea9b14f95c3e35c8c1436: ppc/pnv: Update skiboot to 7.1-106 (2025-03-11 17:49:03 +1000) are available in the Git repository at: https://gitlab.com/npiggin/qemu.git rom-skiboot for you to fetch changes up to 223c7908fe016d3fc79ea9b14f95c3e3

[PATCH-for-10.0 v3 3/8] hw/vfio/common: Include missing 'system/tcg.h' header

2025-03-11 Thread Philippe Mathieu-Daudé
Always include necessary headers explicitly, to avoid when refactoring unrelated ones: hw/vfio/common.c:1176:45: error: implicit declaration of function ‘tcg_enabled’; 1176 | tcg_enabled() ? DIRTY_CLIENTS_ALL : |

Re: [PATCH 0/3] hw/net/smc91c111: Fix potential array overflows

2025-03-11 Thread Jason Wang
On Tue, Mar 11, 2025 at 5:00 PM Philippe Mathieu-Daudé wrote: > > Hi Peter, Jason, > > On 28/2/25 18:47, Peter Maydell wrote: > > This patchset fixes some potential array overflows in the > > smc91c111 ethernet device model, including the one found in > > https://gitlab.com/qemu-project/qemu/-/iss

Re: [PATCH v2] hw/sd/sdhci: Set reset value of interrupt registers

2025-03-11 Thread Philippe Mathieu-Daudé
On 6/3/25 19:23, BALATON Zoltan wrote: On Mon, 3 Mar 2025, BALATON Zoltan wrote: On Mon, 3 Mar 2025, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 10/2/25 17:03, BALATON Zoltan wrote: The interrupt enable registers are not reset to 0 on Freescale eSDHC but some bits are enabled on reset. At lea

[PATCH v2 05/16] exec/memory.h: make devend_memop "target defines" agnostic

2025-03-11 Thread Pierrick Bouvier
Will allow to make system/memory.c common later. Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index ff3a06e6ced..60c0fb6ccd4 100644 --- a/include/exec/

[PATCH v2 00/13] virtio-scsi: add iothread-vq-mapping parameter

2025-03-11 Thread Stefan Hajnoczi
v2: - Only expose cmd vqs via iothread-vq-mapping [Kevin, Peter] Implement --device virtio-scsi-pci,iothread-vq-mapping= support so that virtqueues can be assigned to different IOThreads. This improves SMP guest scalability where I/O-intensive applications can become bottlenecked on a single IOThr

<    1   2   3   4   5   6   7   8   >