Re: [PATCH v3 03/14] acpi/ghes: Use HEST table offsets when preparing GHES records

2025-02-03 Thread Igor Mammedov
On Fri, 31 Jan 2025 18:42:44 +0100 Mauro Carvalho Chehab wrote: > There are two pointers that are needed during error injection: > > 1. The start address of the CPER block to be stored; > 2. The address of the ack. > > It is preferable to calculate them from the HEST table. This allows > check

Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 04:18, Richard Henderson wrote: Define TARGET_LONG_BITS in each target's configure fragment. Do this without removing the define in target/*/cpu-param.h so that errors are caught like so: In file included from .../src/include/exec/cpu-defs.h:26, from ../src/target/hpp

Re: [PATCH v2 11/14] target/*: Remove TARGET_LONG_BITS from cpu-param.h

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 04:18, Richard Henderson wrote: This is now handled by the configs/targets/*.mak fragment. Signed-off-by: Richard Henderson --- target/alpha/cpu-param.h | 2 -- target/arm/cpu-param.h| 2 -- target/avr/cpu-param.h| 1 - target/hexagon/cpu-param.h| 1 - t

Re: [PATCH v2 01/14] meson: Drop tcg as a module

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 10:58, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: The fact that this is only enabled for x86 probably means it was done incorrectly.  Certainly the set of files selected to go into the module is woefully incomplete.  Drop it for now. Maybe add: This mostly reve

Re: [PATCH v2 01/14] meson: Drop tcg as a module

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 04:18, Richard Henderson wrote: The fact that this is only enabled for x86 probably means it was done incorrectly. Certainly the set of files selected to go into the module is woefully incomplete. Drop it for now. Signed-off-by: Richard Henderson --- accel/tcg/meson.build | 11 +++

Re: qemu-iotests 302 failing

2025-02-03 Thread Nir Soffer
> On 3 Feb 2025, at 20:26, Stefan Hajnoczi wrote: > > Hi Nir, > qemu-iotests 302 is failing: > > $ git show > commit 6fccaa2fba391815308a746d68f7fa197bc93586 > ... > $ python --version # on Fedora 41 x86_64 > Python 3.13.1 > $ tests/qemu-iotests/check -qcow2 302 > 302 fail [13:1

Re: [PATCH v2 01/15] block: Add 'active' field to BlockDeviceInfo

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:32PM +0100, Kevin Wolf wrote: > This allows querying from QMP (and also HMP) whether an image is > currently active or inactive (in the sense of BDRV_O_INACTIVE). > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 6 +- > block/monitor/block

Re: [PATCH v2 02/15] block: Inactivate external snapshot overlays when necessary

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:33PM +0100, Kevin Wolf wrote: > Putting an active block node on top of an inactive one is strictly > speaking an invalid configuration and the next patch will turn it into a > hard error. > > However, taking a snapshot while disk images are inactive after > completing

Re: [PATCH v2 03/15] migration/block-active: Remove global active flag

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:34PM +0100, Kevin Wolf wrote: > Block devices have an individual active state, a single global flag > can't cover this correctly. This becomes more important as we allow > users to manually manage which nodes are active or inactive. > > Now that it's allowed to call b

Re: [PATCH v2 04/15] block: Don't attach inactive child to active node

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:35PM +0100, Kevin Wolf wrote: > An active node makes unrestricted use of its children and would possibly > run into assertion failures when it operates on an inactive child node. > > Signed-off-by: Kevin Wolf > --- > block.c | 5 + > 1 file changed, 5 insertions

Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable nested SMMUv3

2025-02-03 Thread Nicolin Chen
On Fri, Jan 31, 2025 at 05:54:56PM +0100, Eric Auger wrote: > On 1/9/25 5:45 AM, Nicolin Chen wrote: > > On Mon, Dec 16, 2024 at 10:01:29AM +, Shameerali Kolothum Thodi wrote: > >> And patches prior to this commit adds that support: > >> 4ccdbe3: ("cover-letter: Add HW accelerated nesting supp

Re: [PATCH v2 06/15] block: Fix crash on block_resize on inactive node

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:37PM +0100, Kevin Wolf wrote: > In order for block_resize to fail gracefully on an inactive node instead > of crashing with an assertion failure in bdrv_co_write_req_prepare() > (called from bdrv_co_truncate()), we need to check for inactive nodes > also when they are

Re: [PATCH v2 05/15] block: Allow inactivating already inactive nodes

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:36PM +0100, Kevin Wolf wrote: > What we wanted to catch with the assertion is cases where the recursion > finds that a child was inactive before its parent. This should never > happen. But if the user tries to inactivate an image that is already > inactive, that's harm

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Maciej S. Szmigiero
On 3.02.2025 19:20, Peter Xu wrote: On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" Multifd send channels are terminated by calling qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in multifd_send_terminate_threads(), which in the TLS case essent

Re: [PATCH v2 07/15] block: Add option to create inactive nodes

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:38PM +0100, Kevin Wolf wrote: > In QEMU, nodes are automatically created inactive while expecting an > incoming migration (i.e. RUN_STATE_INMIGRATE). In qemu-storage-daemon, > the notion of runstates doesn't exist. It also wouldn't necessarily make > sense to introduce

Re: [PATCH v2 08/15] block: Add blockdev-set-active QMP command

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:39PM +0100, Kevin Wolf wrote: > The system emulator tries to automatically activate and inactivate block > nodes at the right point during migration. However, there are still > cases where it's necessary that the user can do this manually. > > Images are only activate

Re: [PATCH v2 09/15] block: Support inactive nodes in blk_insert_bs()

2025-02-03 Thread Stefan Hajnoczi
On Thu, Jan 30, 2025 at 06:12:40PM +0100, Kevin Wolf wrote: > Device models have a relatively complex way to set up their block > backends, in which blk_attach_dev() sets blk->disable_perm = true. > We want to support inactive images in exports, too, so that > qemu-storage-daemon can be used with m

Re: [PATCH v2 10/15] block/export: Don't ignore image activation error in blk_exp_add()

2025-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2025 at 10:50:46AM +0100, Kevin Wolf wrote: > Currently, block jobs can't handle inactive images correctly. Incoming Did you mean "block exports" instead of "block jobs"? If it's really "block jobs", please give an example scenario of the iteraction between jobs and exports. Other

Re: [PATCH v3 00/14] Change ghes to use HEST-based offsets and add support for error inject

2025-02-03 Thread Jonathan Cameron via
On Fri, 31 Jan 2025 18:42:41 +0100 Mauro Carvalho Chehab wrote: > Now that the ghes preparation patches were merged, let's add support > for error injection. > > On this series, the first 6 patches chang to the math used to calculate > offsets at HEST > table and hardware_error firmware file, t

Re: [PATCH] tests/functional: Add a ppc sam460ex test

2025-02-03 Thread BALATON Zoltan
On Mon, 3 Feb 2025, Cédric Le Goater wrote: The test sequence boots from kernel a sam460ex machine with a virtio-net device to check PCI. The buildroot is built with config : BR2_powerpc=y BR2_powerpc_440fp=y and the kernel with the '44x/canyonlands' deconfig and virtio support. Cc: BALATON

[PATCH 07/18] Revert "util/timer: avoid deadlock when shutting down"

2025-02-03 Thread Alex Bennée
This reverts commit bc02be4508d8753d1f6071b77d10f4661587df6f. Now we catch attempts to clock_step to the next timer when none are enabled we can revert the previous attempt to prevent deadlock. As long as a new target time is given we will move time forward even if no timers will fire. This is des

[PATCH 08/18] tests/qtest/migration: Add --full option

2025-02-03 Thread Alex Bennée
From: Fabiano Rosas Add a new command line option to allow selecting between running the full set of tests or a smaller set of tests. The default will be to run the small set (i.e. no comand line option provided) so we can reduce the amount of tests run by default. Only hosts which support KVM fo

[PATCH 05/18] tests/qtest: rename qtest_send_prefix and roll-up into qtest_send

2025-02-03 Thread Alex Bennée
qtest_send_prefix never actually sent something over the chardev, all it does is print the timestamp to the QTEST_LOG when enabled. So rename the function, make it static, remove the unused CharDev and simplify all the call sites by handling that directly with qtest_send (and qtest_log_send). Sign

[PATCH 10/18] gdbstub: Allow the %d placeholder in the socket path

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich Just like for QEMU_LOG_FILENAME, replace %d with PID in the GDB socket path. This allows running multi-process applications with, e.g., export QEMU_GDB=/tmp/qemu-%d.sock. Currently this is not possible, since the first process will cause the subsequent ones to fail due to n

[PATCH 01/18] tests/docker: replicate the check-rust-tools-nightly CI job

2025-02-03 Thread Alex Bennée
This allows people to run the test locally: make docker-test-rust@fedora-rust-nightly Signed-off-by: Alex Bennée --- v2 - update MAINTAINERS --- MAINTAINERS | 1 + tests/docker/Makefile.include | 3 +++ tests/docker/test-rust| 21 + 3 files c

[PATCH 09/18] tests/qtest/migration: Pick smoke tests

2025-02-03 Thread Alex Bennée
From: Fabiano Rosas Choose a few tests per group and move them from the full set to the smoke set. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu Message-Id: <20250130184012.5711-3-faro...@suse.de> Signed-off-by: Alex Bennée --- tests/qtest/migration-test.c | 1 - tests/qte

[PATCH 11/18] gdbstub: Try unlinking the unix socket before binding

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich In case an emulated process execve()s another emulated process, bind() will fail, because the socket already exists. So try deleting it. Use the existing unix_listen() function which does this. Link qemu-user with qemu-sockets.c and add the monitor_get_fd() stub. Note that

[PATCH 12/18] user: Introduce user/signal.h

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich gdbstub needs target_to_host_signal(), so move its declaration to a public header. Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Signed-off-by: Ilya Leoshkevich Message-Id: <20250117001542.8290-4-...@linux.ibm.com> Signed-off-by: Alex Bennée --- bsd-user/sig

[PATCH 04/18] tests/qtest: simplify qtest_process_inbuf

2025-02-03 Thread Alex Bennée
Don't both creating a GString to temporarily hold our qtest command. Instead do a simpler g_strndup and use autofree to clean up afterwards. Signed-off-by: Alex Bennée --- system/qtest.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/system/qtest.c b/sy

[PATCH 14/18] osdep: Introduce qemu_kill_thread()

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich Add a function for sending signals to individual threads. It does not make sense on Windows, so do not provide an implementation, so that if someone uses it by accident, they will get a linker error. Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Signed-off-by:

Re: [PATCH v2 08/14] target/mips: Protect objects with CONFIG_TCG

2025-02-03 Thread Philippe Mathieu-Daudé
Hi Richard, On 3/2/25 04:18, Richard Henderson wrote: Hack around mips32 host allowing kvm acceleration of mips64 guest, but tcg is disabled. We have in target/mips/meson.build: if 'CONFIG_TCG' in config_all_accel subdir('tcg') endif What is the problem you are trying to address here? Si

[RFC PATCH v12 qemu 0/2] arm/virt: CXL support via pxb_cxl

2025-02-03 Thread Jonathan Cameron via
Back in 2022, this series stalled on the absence of a solution to device tree support for PCI Expander Bridges (PXB) and we ended up only having x86 support upstream. I've been carrying the arm64 support out of tree since then, with occasional nasty surprises (e.g. UNIMP + DT issue seen a few weeks

[RFC PATCH v12 qemu 1/2] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-02-03 Thread Jonathan Cameron via
Code based on i386/pc enablement. The memory layout places space for 16 host bridge register regions after the GIC_REDIST2 in the extended memmap. Note this is in a hole, so nothing should move. The CFMWs are placed above the extended memmap. Only create the CEDT table if cxl=on set for the machi

[RFC PATCH v12 qemu 2/2] qtest/cxl: Add aarch64 virt test for CXL

2025-02-03 Thread Jonathan Cameron via
Add a single complex case for aarch64 virt machine. Given existing much more comprehensive tests for x86 cover the common functionality, a single test should be enough to verify that the aarch64 part continue to work. Signed-off-by: Jonathan Cameron --- tests/qtest/cxl-test.c | 59 +

[PULL v2 1/8] chardev/char-pty: send CHR_EVENT_CLOSED on disconnect

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev Change makes code symmetric to the code, which handles the "connected" state, i.e. send CHR_EVENT_CLOSED when state changes from "connected" to "disconnected". This behavior is similar to char-socket, for example. Signed-off-by: Roman Penyaev Reviewed-by: "Marc-André Lureau

Re: [PATCH 1/1] target/riscv: log guest errors when reserved bits are set in PTEs

2025-02-03 Thread Daniel Henrique Barboza
On 2/3/25 11:15 AM, Alex Bennée wrote: Julia writes: This happens because 'pte' is a 'target_ulong' type that, for riscv32, will be interpreted as uint32_t while the FMT being used is PRIx64. You can fix it by using TARGET_FMT_lx instead of PRIx64: I've sent a follow-up patch fixing the

Re: [PATCH v2 07/14] accel/stubs: Expand stubs for TCG

2025-02-03 Thread Thomas Huth
On 03/02/2025 17.43, Richard Henderson wrote: On 2/3/25 02:22, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: Add tcg_allowed, qmp_x_query_jit, qmp_x_query_opcount. These are referenced when CONFIG_TCG is enabled globally, but not for a specific target. Signed-off-by: Richard

Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

2025-02-03 Thread Thomas Huth
On 03/02/2025 17.49, Richard Henderson wrote: On 2/3/25 02:39, Thomas Huth wrote: [...]> diff --git a/configs/targets/hppa-linux-user.mak b/configs/targets/ hppa-linux-user.mak index 8e0a80492f..4295cf384e 100644 --- a/configs/targets/hppa-linux-user.mak +++ b/configs/targets/hppa-linux-user.ma

Re: [PATCH V1 05/26] vfio/container: preserve descriptors

2025-02-03 Thread Cédric Le Goater
On 1/29/25 15:43, Steve Sistare wrote: At vfio creation time, save the value of vfio container, group, and device descriptors in CPR state. On qemu restart, vfio_realize() finds and uses the saved descriptors, and remembers the reused status for subsequent patches. The reused status is cleared

Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 04:18, Richard Henderson wrote: Define TARGET_LONG_BITS in each target's configure fragment. Do this without removing the define in target/*/cpu-param.h so that errors are caught like so: In file included from .../src/include/exec/cpu-defs.h:26, from ../src/target/hpp

Re: [PATCH v2 00/14] meson: Deprecate 32-bit host support

2025-02-03 Thread Paolo Bonzini
On 2/3/25 04:18, Richard Henderson wrote: v1: 20250128004254.33442-1-richard.hender...@linaro.org For v2, immediately disable 64-on-32 TCG. I *suspect* that we should disable 64-on-32 for *all* accelerators. The idea that an i686 binary on an x86_64 host may be used to spawn an x86_64 guest via

[PULL 2/8] chardev/char-hub: implement backend chardev aggregator

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev This patch implements a new chardev backend `hub` device, which aggregates input from multiple backend devices and forwards it to a single frontend device. Additionally, `hub` device takes the output from the frontend device and sends it back to all the connected backend devic

[PULL 5/8] ui/dbus: on win32, allow ANONYMOUS with p2p

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau GLib doesn't implement EXTERNAL on win32 at the moment, and disables ANONYMOUS by default. zbus dropped support for COOKIE_SHA1 in 5.0, making it no longer possible to connect to qemu -display dbus. Since p2p connections are gated by existing QMP (or a D-Bus connection),

[PULL 8/8] dbus: add -audio dbus nsamples option

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau Allow to set the number of audio samples per read/write to dbus. Signed-off-by: Marc-André Lureau --- qapi/audio.json | 22 +- audio/dbusaudio.c| 21 ++--- ui/dbus-display1.xml | 12 3 files changed, 51 insertion

[PULL 1/8] chardev/char-pty: send CHR_EVENT_CLOSED on disconnect

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev Change makes code symmetric to the code, which handles the "connected" state, i.e. send CHR_EVENT_CLOSED when state changes from "connected" to "disconnected". This behavior is similar to char-socket, for example. Signed-off-by: Roman Penyaev Reviewed-by: "Marc-André Lureau

[PULL 6/8] ui/dbus: clarify the kind of win32 handle that is shared

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau "-display dbus" hands over a file mapping handle to the peer process (not a file handle). Signed-off-by: Marc-André Lureau --- ui/dbus-display1.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/dbus-display1.xml b/ui/dbus-display1.xml index

[PULL 0/8] Ui patches

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 6fccaa2fba391815308a746d68f7fa197bc93586: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2025-02-02 11:09:10 -0500) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu

[PULL 4/8] qemu-options.hx: describe hub chardev and aggregation of several backends

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev This adds a few lines describing `hub` aggregator configuration for aggregation of several backend devices with a single frontend device. Signed-off-by: Roman Penyaev Reviewed-by: "Marc-André Lureau" Cc: qemu-devel@nongnu.org Message-ID: <20250123085327.965501-5-r.peni...@g

[PULL 7/8] plugins: fix -Werror=maybe-uninitialized false-positive

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau ../contrib/plugins/cache.c:638:9: error: ‘l2_cache’ may be used uninitialized [-Werror=maybe-uninitialized] 638 | append_stats_line(rep, l1_dmem_accesses, l1_dmisses, | ^~~~ Is a false-positive, sinc

[PULL 3/8] tests/unit/test-char: add unit tests for hub chardev backend

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev This commit introduces a new test function `char_hub_test` to validate the functionality and constraints of the "hub" chardev backend in QEMU. The test includes multiple scenarios: 1. Invalid hub creation: - Creating a hub without defining `chardevs.N` (expects an error).

[PATCH 15/18] gdbstub: Allow late attachment

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich Allow debugging individual processes in multi-process applications by starting them with export QEMU_GDB=/tmp/qemu-%d.sock,suspend=n. Currently one would have to attach to every process to ensure the app makes progress. In case suspend=n is not specified, the flow remains

[PATCH] target/sparc: Fix gdbstub incorrectly handling registers f32-f62

2025-02-03 Thread Mikael Szreder
The gdbstub implementation for the Sparc architecture would incorectly calculate the the floating point register offset. This would cause register pairs(eg f32,f33) to point to the same value. Fixes: 30038fd81808 ("target-sparc: Change fpr representation to doubles.") Signed-off-by: Mikael Szrede

[PATCH 06/18] tests/qtest: tighten up the checks on clock_step

2025-02-03 Thread Alex Bennée
It is invalid to call clock_step with an implied time to step forward as if no timers are running we won't be able to advance. Signed-off-by: Alex Bennée --- v3 - used Peter's suggested wording - used plain old if over ternary operator --- system/qtest.c | 13 +++-- 1 file changed,

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Peter Maydell
On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: > > Peter Maydell writes: > > > > > On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: > > >> > > >> On Sat, 1 Feb 2025, Philippe Mathieu-Daudé wrote: > > >> > - Deprecate the

[PATCH 03/18] tests/qtest: don't step clock at start of npcm7xx periodic IRQ test

2025-02-03 Thread Alex Bennée
Until there are timers enabled the semantics of clock_step_next() will fail. Since d524441a36 (system/qtest: properly feedback results of clock_[step|set]) we will signal a FAIL if time doesn't advance. Signed-off-by: Alex Bennée Reviewed-by: Hao Wu --- tests/qtest/npcm7xx_timer-test.c | 1 - 1

[PATCH 18/18] plugins: fix -Werror=maybe-uninitialized false-positive

2025-02-03 Thread Alex Bennée
From: Marc-André Lureau ../contrib/plugins/cache.c:638:9: error: ‘l2_cache’ may be used uninitialized [-Werror=maybe-uninitialized] 638 | append_stats_line(rep, l1_dmem_accesses, l1_dmisses, | ^~~~ Is a false-positive, sinc

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Daniel P . Berrangé
On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: > On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: > > > > On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: > > > Peter Maydell writes: > > > > > > > On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: > > > >> > > >

[PATCH 17/18] tests/tcg: Add late gdbstub attach test

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich Add a small test to prevent regressions. Make sure that host_interrupt_signal is not visible to the guest. Reviewed-by: Alex Bennée Signed-off-by: Ilya Leoshkevich Message-Id: <20250117001542.8290-9-...@linux.ibm.com> Signed-off-by: Alex Bennée --- tests/tcg/multiarch/

[PATCH 16/18] docs/user: Document the %d placeholder and suspend=n QEMU_GDB features

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich Reviewed-by: Alex Bennée Signed-off-by: Ilya Leoshkevich Message-Id: <20250117001542.8290-8-...@linux.ibm.com> Signed-off-by: Alex Bennée --- docs/user/main.rst | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/docs/user/main.rst b/do

Re: [PATCH v3 05/14] acpi/generic_event_device: add logic to detect if HEST addr is available

2025-02-03 Thread Igor Mammedov
On Fri, 31 Jan 2025 18:42:46 +0100 Mauro Carvalho Chehab wrote: > Create a new property (x-has-hest-addr) and use it to detect if > the GHES table offsets can be calculated from the HEST address > (qemu 10.0 and upper) or via the legacy way via an offset obtained > from the hardware_errors firmwa

Re: [PATCH v2 08/14] target/mips: Protect objects with CONFIG_TCG

2025-02-03 Thread Richard Henderson
On 2/3/25 09:25, Philippe Mathieu-Daudé wrote: Hi Richard, On 3/2/25 04:18, Richard Henderson wrote: Hack around mips32 host allowing kvm acceleration of mips64 guest, but tcg is disabled. We have in target/mips/meson.build: if 'CONFIG_TCG' in config_all_accel   subdir('tcg') endif What is

Re: [PATCH v4 09/33] migration: postcopy_ram_listen_thread() needs to take BQL for some calls

2025-02-03 Thread Maciej S. Szmigiero
On 2.02.2025 13:45, Dr. David Alan Gilbert wrote: * Maciej S. Szmigiero (m...@maciej.szmigiero.name) wrote: On 2.02.2025 03:06, Dr. David Alan Gilbert wrote: * Maciej S. Szmigiero (m...@maciej.szmigiero.name) wrote: From: "Maciej S. Szmigiero" postcopy_ram_listen_thread() is a free running t

Re: [PATCH v2 14/14] tcg: Remove TCG_OVERSIZED_GUEST

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > This is now prohibited in configuration. > > Signed-off-by: Richard Henderson > -#if TARGET_LONG_BITS > TCG_TARGET_REG_BITS Is it worth keeping a compile time assert with a comment so if anyone attempts to hack 32 bit support back in they will find out quickly? Oth

Re: [PATCH v2 13/14] meson: Deprecate 32-bit host support

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > We deprecated i686 system mode support for qemu 8.0. However, to > make real cleanups to TCG we need to deprecate all 32-bit hosts. > > Signed-off-by: Richard Henderson > --- > docs/about/deprecated.rst | 7 +++ > meson.build | 6 ++ > 2 files

Re: [PATCH 0/2] migration: Reduce migration-test time for non-KVM archs

2025-02-03 Thread Alex Bennée
Fabiano Rosas writes: > Hi, continuing the work from the previous[1] series to reduce the time > migration-test takes during make check, here's a couple of patches to > create a smaller set of tests. Queued to testing/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] tests/functional: Add a ppc sam460ex test

2025-02-03 Thread Thomas Huth
On 03/02/2025 12.29, BALATON Zoltan wrote: On Mon, 3 Feb 2025, Cédric Le Goater wrote: The test sequence boots from kernel a sam460ex machine with a virtio-net device to check PCI. The buildroot is built with config :  BR2_powerpc=y  BR2_powerpc_440fp=y and the kernel with the '44x/canyonland

Re: [PATCH v3 4/4] qapi: expose all schema features to code

2025-02-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > This replaces use of the constants from the QapiSpecialFeatures > enum, with constants from the auto-generate QapiFeatures enum > in qapi-features.h > > The 'deprecated' and 'unstable' features still have a little bit of > special handling, being force defined to be t

Re: [PATCH v3 02/14] acpi/ghes: add a firmware file with HEST address

2025-02-03 Thread Igor Mammedov
On Fri, 31 Jan 2025 18:42:43 +0100 Mauro Carvalho Chehab wrote: > Store HEST table address at GPA, placing its the start of the table at > hest_addr_le variable. > > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov > --- > hw/acpi/ghes.c

Re: [PATCH v3 00/14] Change ghes to use HEST-based offsets and add support for error inject

2025-02-03 Thread Igor Mammedov
On Mon, 3 Feb 2025 11:09:34 + Jonathan Cameron wrote: > On Fri, 31 Jan 2025 18:42:41 +0100 > Mauro Carvalho Chehab wrote: > > > Now that the ghes preparation patches were merged, let's add support > > for error injection. > > > > On this series, the first 6 patches chang to the math used t

RE: [PATCH v6 00/10] Support virtio-gpu DRM native context

2025-02-03 Thread Kim, Dongwon
Hi, The commit below could change the timing of drawing by making the drawing done at refresh cycle instead of via drawing event. So it looks like either dmabuf or client's framebuffer is being written and read at the same time. Hey, can you describe how the corruption looks like? Is it just garb

Re: [PATCH v4 08/33] migration/multifd: Allow premature EOF on TLS incoming channels

2025-02-03 Thread Peter Xu
On Thu, Jan 30, 2025 at 11:08:29AM +0100, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > Multifd send channels are terminated by calling > qio_channel_shutdown(QIO_CHANNEL_SHUTDOWN_BOTH) in > multifd_send_terminate_threads(), which in the TLS case essentially > calls shutdown(SHUT_R

[PATCH] block: remove unused BLOCK_OP_TYPE_DATAPLANE

2025-02-03 Thread Stefan Hajnoczi
BLOCK_OP_TYPE_DATAPLANE prevents BlockDriverState from being used by virtio-blk/virtio-scsi with IOThread. Commit b112a65c52aa ("block: declare blockjobs and dataplane friends!") eliminated the main reason for this blocker in 2014. Nowadays the block layer supports I/O from multiple AioContexts, s

Re: [PATCH v7 51/52] i386/tdx: Validate phys_bits against host value

2025-02-03 Thread Paolo Bonzini
On 2/2/25 15:39, Xiaoyao Li wrote: On 2/1/2025 2:27 AM, Paolo Bonzini wrote: On Fri, Jan 24, 2025 at 2:40 PM Xiaoyao Li wrote: For TDX guest, the phys_bits is not configurable and can only be host/native value. Validate phys_bits inside tdx_check_features(). Hi Xiaoyao, to avoid qemu-kvm

Re: [PATCH V1 06/26] vfio/container: preserve DMA mappings

2025-02-03 Thread Cédric Le Goater
On 1/29/25 15:43, Steve Sistare wrote: Preserve DMA mappings during cpr-transfer. In the container pre_save handler, suspend the use of virtual addresses in DMA mappings with VFIO_DMA_UNMAP_FLAG_VADDR, because guest RAM will be remapped at a different VA after exec. DMA to already-mapped pages

qemu-iotests 302 failing

2025-02-03 Thread Stefan Hajnoczi
Hi Nir, qemu-iotests 302 is failing: $ git show commit 6fccaa2fba391815308a746d68f7fa197bc93586 ... $ python --version # on Fedora 41 x86_64 Python 3.13.1 $ tests/qemu-iotests/check -qcow2 302 302 fail [13:16:45] [13:16:45] 0.5s (last: 0.5s) failed, exit status 1 ---

Re: [PATCH v2 05/14] tcg: Link only when required in system mode

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > Rather than unconditional linkage via system_ss, conditinally > include the static library via specific_ss. This will elide > the code when CONFIG_TCG is disabled for a specific target. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 06/14] plugins: Link only when required in system mode

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > Provide out-of-line versions of some of the qemu/plugin.h API. > These will be referenced with --enable-plugin, but CONFIG_TCG > is disabled for a specific target. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lea

Re: [PATCH v2 01/14] meson: Drop tcg as a module

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > The fact that this is only enabled for x86 probably means it > was done incorrectly. Certainly the set of files selected to > go into the module is woefully incomplete. Drop it for now. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 03/14] plugins: Uninline qemu_plugin_add_opts

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > No need to expand this function inline. > Unexport qemu_plugin_opts to match. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/2] target/i386: Fix 0 * Inf + QNaN regression

2025-02-03 Thread Paolo Bonzini
On 2/3/25 12:05, Peter Maydell wrote: On Fri, 24 Jan 2025 at 17:22, Paolo Bonzini wrote: Queued, thanks. Thanks; do you plan to send a pullreq with these in soon? I ask because the Arm FEAT_AFP set is now ready to land and it has a dependency on these. I do but if you want to send it yourse

[PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests

2025-02-03 Thread Thomas Huth
All other vhost-user tests here use modern virtio, too, so let's adjust the vhost-user-net test accordingly. Signed-off-by: Thomas Huth --- tests/qtest/vhost-user-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-t

Re: [PATCH 1/1] target/riscv: log guest errors when reserved bits are set in PTEs

2025-02-03 Thread Alex Bennée
Julia writes: >> This happens because 'pte' is a 'target_ulong' type that, for riscv32, will >> be >> interpreted as uint32_t while the FMT being used is PRIx64. >> >> You can fix it by using TARGET_FMT_lx instead of PRIx64: >> > > I've sent a follow-up patch fixing these build errors, it builds

Re: [PULL 00/42] Migration patches for 2025-01-29

2025-02-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 0/9] Hppa system mfdiag for v10 patches

2025-02-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/20] Functional tests, s390x improvements and slirp fixes

2025-02-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/36] Misc HW patches for 2025-01-31

2025-02-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/7] Trivial patches for 2025-01-30

2025-02-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/1] Block patches

2025-02-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

[PATCH] target/sparc: Fix register selection for the fdtox and fqtox instructions

2025-02-03 Thread Mikael Szreder
A bug was introduced in commit 0bba7572d40d which causes the fdtox and fqtox instructions to incorrectly select the destination registers. More information and a test program can be found in issue #2802. Fixes: 0bba7572d40d ("target/sparc: Perform DFPREG/QFPREG in decodetree") Resolves: https://g

Re: [PATCH 1/1] target/riscv: log guest errors when reserved bits are set in PTEs

2025-02-03 Thread Alex Bennée
Julia writes: >> This happens because 'pte' is a 'target_ulong' type that, for riscv32, will >> be >> interpreted as uint32_t while the FMT being used is PRIx64. >> >> You can fix it by using TARGET_FMT_lx instead of PRIx64: >> > > I've sent a follow-up patch fixing these build errors, it builds

[PULL v2 2/8] chardev/char-hub: implement backend chardev aggregator

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev This patch implements a new chardev backend `hub` device, which aggregates input from multiple backend devices and forwards it to a single frontend device. Additionally, `hub` device takes the output from the frontend device and sends it back to all the connected backend devic

[PULL v2 0/8] Ui patches

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 6fccaa2fba391815308a746d68f7fa197bc93586: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2025-02-02 11:09:10 -0500) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu

[PULL v2 4/8] qemu-options.hx: describe hub chardev and aggregation of several backends

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev This adds a few lines describing `hub` aggregator configuration for aggregation of several backend devices with a single frontend device. Signed-off-by: Roman Penyaev Reviewed-by: "Marc-André Lureau" Cc: qemu-devel@nongnu.org Message-ID: <20250123085327.965501-5-r.peni...@g

[PULL v2 7/8] plugins: fix -Werror=maybe-uninitialized false-positive

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau ../contrib/plugins/cache.c:638:9: error: ‘l2_cache’ may be used uninitialized [-Werror=maybe-uninitialized] 638 | append_stats_line(rep, l1_dmem_accesses, l1_dmisses, | ^~~~ Is a false-positive, sinc

[PULL v2 8/8] dbus: add -audio dbus nsamples option

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau Allow to set the number of audio samples per read/write to dbus. Signed-off-by: Marc-André Lureau --- qapi/audio.json | 22 +- audio/dbusaudio.c| 21 ++--- ui/dbus-display1.xml | 12 3 files changed, 51 insertion

[PULL v2 3/8] tests/unit/test-char: add unit tests for hub chardev backend

2025-02-03 Thread marcandre . lureau
From: Roman Penyaev This commit introduces a new test function `char_hub_test` to validate the functionality and constraints of the "hub" chardev backend in QEMU. The test includes multiple scenarios: 1. Invalid hub creation: - Creating a hub without defining `chardevs.N` (expects an error).

[PULL v2 6/8] ui/dbus: clarify the kind of win32 handle that is shared

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau "-display dbus" hands over a file mapping handle to the peer process (not a file handle). Signed-off-by: Marc-André Lureau --- ui/dbus-display1.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/dbus-display1.xml b/ui/dbus-display1.xml index

Re: [PULL 0/8] Ui patches

2025-02-03 Thread Marc-André Lureau
Hi On Mon, Feb 3, 2025 at 6:29 PM Stefan Hajnoczi wrote: > > On Mon, Feb 3, 2025 at 7:58 AM wrote: > > > > From: Marc-André Lureau > > > > The following changes since commit 6fccaa2fba391815308a746d68f7fa197bc93586: > > > > Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu in

[PULL v2 5/8] ui/dbus: on win32, allow ANONYMOUS with p2p

2025-02-03 Thread marcandre . lureau
From: Marc-André Lureau GLib doesn't implement EXTERNAL on win32 at the moment, and disables ANONYMOUS by default. zbus dropped support for COOKIE_SHA1 in 5.0, making it no longer possible to connect to qemu -display dbus. Since p2p connections are gated by existing QMP (or a D-Bus connection),

Re: [PATCH v2 12/14] meson: Disallow 64-bit on 32-bit TCG emulation

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > For system mode, we can rarely support the amount of RAM that > the guest requires. Emulation is restricted to round-robin > mode, which solves many of the atomicity issues, but not those > associated with virtio. In any case, round-robin does nothing > to help the sp

<    1   2   3   >