On 2/3/25 11:15 AM, Alex Bennée wrote:
Julia <midni...@trainwit.ch> writes:
This happens because 'pte' is a 'target_ulong' type that, for riscv32, will be
interpreted as uint32_t while the FMT being used is PRIx64.
You can fix it by using TARGET_FMT_lx instead of PRIx64:
I've sent a follow-up patch fixing these build errors, it builds on 32 & 64 bit
on my system. Cheers
As for the Signed-off-by, I'd rather not, and the contributing guide
does not require it.
Apologies - I missed the context.
The name used with “Signed-off-by” does not need to be your legal name,
nor birth name, nor appear on any government ID. It is the identity you
choose to be known by in the community, but should not be anonymous, nor
misrepresent whom you are.
That's correct.
The reason I mentioned about the "git" commands in my reply is that newcomers
aren't necessarily well versed with git and creating a patch without doing
a prior setup will, in Linux, use login_name@hostname as author. I saw the
Signed-off-by of this patch and I figured that could be the case. Apparently
I was wrong and the git identity used is intention, so we're good.
By the way I wonder if we could amend docs/devel/submitting-a-patch.rst with
a handful of lines about how to set author in git. We have docs about how to
send git send-mail, format-patch and so on, but apparently nothing about how
to set the author.
Thanks,
Daniel
Regards,
Julia
